coreboot-gerrit February 2025

coreboot-gerrit@coreboot.org

1 participants
2887 discussions

[XS] Change in coreboot[main]: device/dram/ddr5: Add 7500 MT/s support
by Alicja Michalska (Code Review) 27 Feb '25

27 Feb '25

Attention is currently required from: Maximilian Brune, Paul Menzel. Alicja Michalska has posted comments on this change by Maximilian Brune. ( https://review.coreboot.org/c/coreboot/+/86543?usp=email ) Change subject: device/dram/ddr5: Add 7500 MT/s support ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/86543?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I141f63c4fc505a9e16eed132a9a550441f4ad68d Gerrit-Change-Number: 86543 Gerrit-PatchSet: 2 Gerrit-Owner: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Alicja Michalska <ahplka19(a)gmail.com> Gerrit-Reviewer: Marvin Drees <marvin.drees(a)9elements.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Comment-Date: Thu, 27 Feb 2025 13:17:25 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in coreboot[main]: mb/siemens/fa_ehl/variants/fa_ehl: Remove I210 driver
by Uwe Poeche (Code Review) 27 Feb '25

27 Feb '25

Attention is currently required from: Johannes Hahn, Paul Menzel, Werner Zeh. Uwe Poeche has posted comments on this change by Johannes Hahn. ( https://review.coreboot.org/c/coreboot/+/86425?usp=email ) Change subject: mb/siemens/fa_ehl/variants/fa_ehl: Remove I210 driver ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/86425?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I413cb334ee06e3fc7183dc2621b6091f0d0b602b Gerrit-Change-Number: 86425 Gerrit-PatchSet: 2 Gerrit-Owner: Johannes Hahn <johannes-hahn(a)siemens.com> Gerrit-Reviewer: Mario Scheithauer <mario.scheithauer(a)siemens.com> Gerrit-Reviewer: Uwe Poeche <uwe.poeche(a)siemens.com> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Johannes Hahn <johannes-hahn(a)siemens.com> Gerrit-Attention: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Comment-Date: Thu, 27 Feb 2025 13:11:30 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in coreboot[main]: device/dram/ddr5: Add 7500 MT/s support
by Marvin Drees (Code Review) 27 Feb '25

27 Feb '25

Attention is currently required from: Maximilian Brune, Paul Menzel. Marvin Drees has posted comments on this change by Maximilian Brune. ( https://review.coreboot.org/c/coreboot/+/86543?usp=email ) Change subject: device/dram/ddr5: Add 7500 MT/s support ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/86543?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I141f63c4fc505a9e16eed132a9a550441f4ad68d Gerrit-Change-Number: 86543 Gerrit-PatchSet: 2 Gerrit-Owner: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Marvin Drees <marvin.drees(a)9elements.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Comment-Date: Thu, 27 Feb 2025 13:06:03 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in coreboot[main]: mb/trulo/var/uldrenite: Fix boot time caused by WWAN initialization
by Kapil Porwal (Code Review) 27 Feb '25

27 Feb '25

Attention is currently required from: Dinesh Gehlot, Dtrain Hsu, Jayvik Desai, John Su, Nick Vaccaro. Kapil Porwal has posted comments on this change by John Su. ( https://review.coreboot.org/c/coreboot/+/86514?usp=email ) Change subject: mb/trulo/var/uldrenite: Fix boot time caused by WWAN initialization ...................................................................... Patch Set 8: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/86514?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ie01019eca7eaa4bbb34dd80aeb65b9b6b08587fd Gerrit-Change-Number: 86514 Gerrit-PatchSet: 8 Gerrit-Owner: John Su <john_su(a)compal.corp-partner.google.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Jamie Chen <jamie_chen(a)compal.corp-partner.google.com> Gerrit-CC: Van Chen <van_chen(a)compal.corp-partner.google.com> Gerrit-Attention: Jayvik Desai <jayvik(a)google.com> Gerrit-Attention: John Su <john_su(a)compal.corp-partner.google.com> Gerrit-Attention: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Comment-Date: Thu, 27 Feb 2025 12:27:58 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in coreboot[main]: mb/trulo: Add host event EC_HOST_EVENT_BODY_DETECT_CHANGE
by Kapil Porwal (Code Review) 27 Feb '25

27 Feb '25

Attention is currently required from: Dinesh Gehlot, Eric Lai, Ivan Chen, Jayvik Desai, John Su, Nick Vaccaro, Subrata Banik. Kapil Porwal has posted comments on this change by John Su. ( https://review.coreboot.org/c/coreboot/+/86615?usp=email ) Change subject: mb/trulo: Add host event EC_HOST_EVENT_BODY_DETECT_CHANGE ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/86615?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ifac0460e0e8feb33ad0085d250928adb593bb8ca Gerrit-Change-Number: 86615 Gerrit-PatchSet: 1 Gerrit-Owner: John Su <john_su(a)compal.corp-partner.google.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Ivan Chen <yulunchen(a)google.com> Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com> Gerrit-CC: Jamie Chen <jamie_chen(a)compal.corp-partner.google.com> Gerrit-Attention: Jayvik Desai <jayvik(a)google.com> Gerrit-Attention: John Su <john_su(a)compal.corp-partner.google.com> Gerrit-Attention: Eric Lai <ericllai(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Attention: Ivan Chen <yulunchen(a)google.com> Gerrit-Comment-Date: Thu, 27 Feb 2025 12:13:02 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in coreboot[main]: mb/google/trulo/var/uldrenite: Support body detection to DPTF
by Kapil Porwal (Code Review) 27 Feb '25

27 Feb '25

Attention is currently required from: Boris Mittelberg, Caveh Jalali, Dinesh Gehlot, Jayvik Desai, John Su, Nick Vaccaro, Subrata Banik. Kapil Porwal has posted comments on this change by John Su. ( https://review.coreboot.org/c/coreboot/+/86494?usp=email ) The change is no longer submittable: All-Comments-Resolved is unsatisfied now. Change subject: mb/google/trulo/var/uldrenite: Support body detection to DPTF ...................................................................... Patch Set 3: (1 comment) File src/ec/google/chromeec/acpi/ec.asl: https://review.coreboot.org/c/coreboot/+/86494/comment/6ab6b961_b680e5b2?us… : PS3, Line 484: Method (_Q21, 0, NotSerialized) This method doesn't have any action/commands. Could you please confirm? -- To view, visit https://review.coreboot.org/c/coreboot/+/86494?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I6e98b9c3fd1b38d10a1aa7c30d5d92e1638449f2 Gerrit-Change-Number: 86494 Gerrit-PatchSet: 3 Gerrit-Owner: John Su <john_su(a)compal.corp-partner.google.com> Gerrit-Reviewer: Boris Mittelberg <bmbm(a)google.com> Gerrit-Reviewer: Caveh Jalali <caveh(a)chromium.org> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Jamie Chen <jamie_chen(a)compal.corp-partner.google.com> Gerrit-CC: Van Chen <van_chen(a)compal.corp-partner.google.com> Gerrit-Attention: Jayvik Desai <jayvik(a)google.com> Gerrit-Attention: John Su <john_su(a)compal.corp-partner.google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Caveh Jalali <caveh(a)chromium.org> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Attention: Boris Mittelberg <bmbm(a)google.com> Gerrit-Comment-Date: Thu, 27 Feb 2025 11:57:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[L] Change in coreboot[main]: mb/hp: Add Pro 3400
by Angel Pons (Code Review) 27 Feb '25

27 Feb '25

Attention is currently required from: Nicholas Chin, Václav Straka. Angel Pons has posted comments on this change by Václav Straka. ( https://review.coreboot.org/c/coreboot/+/85825?usp=email ) Change subject: mb/hp: Add Pro 3400 ...................................................................... Patch Set 12: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/85825?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I833996f6eddcaac91fb0ad0cd95fcc2a99447387 Gerrit-Change-Number: 85825 Gerrit-PatchSet: 12 Gerrit-Owner: Václav Straka <venda.straka(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Václav Straka <venda.straka(a)gmail.com> Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Comment-Date: Thu, 27 Feb 2025 11:43:13 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in coreboot[main]: coreboot-sdk: Remove unnecessary files
by Elyes Haouas (Code Review) 27 Feb '25

27 Feb '25

Elyes Haouas has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/86617?usp=email ) Change subject: coreboot-sdk: Remove unnecessary files ...................................................................... coreboot-sdk: Remove unnecessary files Reduces the size of the Docker image by removing all unnecessary files. Change-Id: Ib8c658799217c3b6595e3b5fce8f5c8238054c45 Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> --- M util/docker/coreboot-sdk/Dockerfile 1 file changed, 2 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/17/86617/1 diff --git a/util/docker/coreboot-sdk/Dockerfile b/util/docker/coreboot-sdk/Dockerfile index 970d647..d4424d9 100644 --- a/util/docker/coreboot-sdk/Dockerfile +++ b/util/docker/coreboot-sdk/Dockerfile @@ -115,7 +115,8 @@ xfonts-unifont \ xz-utils \ zlib1g-dev \ - && apt-get clean + && apt-get clean && \ + rm -rf /var/lib/apt/lists/* # Build coreboot toolchain RUN \ -- To view, visit https://review.coreboot.org/c/coreboot/+/86617?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ib8c658799217c3b6595e3b5fce8f5c8238054c45 Gerrit-Change-Number: 86617 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr>

1 0

[S] Change in coreboot[main]: coreboot-sdk: Use same gcc & gnat version as the version in toolchain
by Elyes Haouas (Code Review) 27 Feb '25

27 Feb '25

Elyes Haouas has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/86616?usp=email ) Change subject: coreboot-sdk: Use same gcc & gnat version as the version in toolchain ...................................................................... coreboot-sdk: Use same gcc & gnat version as the version in toolchain Change-Id: I3d75f7cf06ed1421cb27e185d9ebf4887626f41a Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> --- M util/docker/coreboot-sdk/Dockerfile 1 file changed, 30 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/16/86616/1 diff --git a/util/docker/coreboot-sdk/Dockerfile b/util/docker/coreboot-sdk/Dockerfile index 6c3a06b..970d647 100644 --- a/util/docker/coreboot-sdk/Dockerfile +++ b/util/docker/coreboot-sdk/Dockerfile @@ -11,6 +11,34 @@ ARG SDK_VERSION ARG CROSSGCC_PARAM +# Add Debian Sid repository with pinning - needed to install same version +# of GCC/GNAT as the version used in coreboot toolchain +RUN \ + echo "deb http://deb.debian.org/debian sid main" >> /etc/apt/sources.list.d/sid.list && \ + echo "Package: *" > /etc/apt/preferences.d/sid-pinning && \ + echo "Pin: release a=stable" >> /etc/apt/preferences.d/sid-pinning && \ + echo "Pin-Priority: 900" >> /etc/apt/preferences.d/sid-pinning && \ + echo "Package: *" >> /etc/apt/preferences.d/sid-pinning && \ + echo "Pin: release a=testing" >> /etc/apt/preferences.d/sid-pinning && \ + echo "Pin-Priority: 800" >> /etc/apt/preferences.d/sid-pinning && \ + echo "Package: *" >> /etc/apt/preferences.d/sid-pinning && \ + echo "Pin: release a=unstable" >> /etc/apt/preferences.d/sid-pinning && \ + echo "Pin-Priority: 100" >> /etc/apt/preferences.d/sid-pinning && \ + apt-get update + +# Install GCC-14 and GNAT-14 +RUN \ + apt-get install -y --no-install-recommends \ + -t testing gcc-14 g++-14 \ + -t sid gnat-14 + +# Set GCC-14 and GNAT-14 as default compilers +RUN \ + update-alternatives --install /usr/bin/gcc gcc /usr/bin/gcc-14 60 --slave /usr/bin/g++ g++ /usr/bin/g++-14 && \ + update-alternatives --install /usr/bin/gnat gnat /usr/bin/gnat-14 60 && \ + update-alternatives --set gcc /usr/bin/gcc-14 + +# Install dependencies and create coreboot user RUN \ useradd -p locked -m coreboot && \ apt-get -qq update && \ @@ -30,12 +58,9 @@ diffutils \ exuberant-ctags \ flex \ - g++ \ gawk \ - gcc \ gettext \ git \ - gnat \ golang \ graphicsmagick-imagemagick-compat \ graphviz \ @@ -92,6 +117,7 @@ zlib1g-dev \ && apt-get clean +# Build coreboot toolchain RUN \ cd /tmp && \ git clone https://review.coreboot.org/coreboot && \ @@ -105,6 +131,7 @@ BUILD_LANGUAGES=c,ada CPUS=$(nproc) DEST=/opt/xgcc && \ rm -rf /tmp/coreboot +# Set up coreboot environment RUN mkdir /home/coreboot/.ccache && \ chown coreboot:coreboot /home/coreboot/.ccache && \ mkdir /home/coreboot/cb_build && \ -- To view, visit https://review.coreboot.org/c/coreboot/+/86616?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I3d75f7cf06ed1421cb27e185d9ebf4887626f41a Gerrit-Change-Number: 86616 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr>

1 0

[L] Change in coreboot[main]: mb/hp: Add Pro 3400
by Václav Straka (Code Review) 27 Feb '25

27 Feb '25

Attention is currently required from: Angel Pons, Nicholas Chin. Václav Straka has posted comments on this change by Václav Straka. ( https://review.coreboot.org/c/coreboot/+/85825?usp=email ) Change subject: mb/hp: Add Pro 3400 ...................................................................... Patch Set 11: (3 comments) File src/mainboard/hp/pro_3x00_series/Kconfig: https://review.coreboot.org/c/coreboot/+/85825/comment/98084df0_30d29ac9?us… : PS11, Line 46: config DRAM_RESET_GATE_GPIO : default 60 > That's the default and could be removed Done File src/mainboard/hp/pro_3x00_series/variants/pro_3400_series/board_info.txt: https://review.coreboot.org/c/coreboot/+/85825/comment/74a502c8_4da4e550?us… : PS11, Line 2: ROM IC: W25Q32BVSIG > I wouldn't list the chip model, not all boards have the same chip model Done File src/mainboard/hp/pro_3x00_series/variants/pro_3500_series/board_info.txt: https://review.coreboot.org/c/coreboot/+/85825/comment/7ec0537b_7c11a075?us… : PS11, Line 2: ROM IC: W25Q64FVSIG > Same, especially if the docs said something about a different chip model Done -- To view, visit https://review.coreboot.org/c/coreboot/+/85825?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I833996f6eddcaac91fb0ad0cd95fcc2a99447387 Gerrit-Change-Number: 85825 Gerrit-PatchSet: 11 Gerrit-Owner: Václav Straka <venda.straka(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Comment-Date: Thu, 27 Feb 2025 11:32:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com>

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit February 2025