Attention is currently required from: Johannes Hahn, Paul Menzel, Werner Zeh.
Uwe Poeche has posted comments on this change by Johannes Hahn. ( https://review.coreboot.org/c/coreboot/+/86425?usp=email )
Change subject: mb/siemens/fa_ehl/variants/fa_ehl: Remove I210 driver
......................................................................
Patch Set 2: Code-Review+1
--
To view, visit https://review.coreboot.org/c/coreboot/+/86425?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I413cb334ee06e3fc7183dc2621b6091f0d0b602b
Gerrit-Change-Number: 86425
Gerrit-PatchSet: 2
Gerrit-Owner: Johannes Hahn <johannes-hahn(a)siemens.com>
Gerrit-Reviewer: Mario Scheithauer <mario.scheithauer(a)siemens.com>
Gerrit-Reviewer: Uwe Poeche <uwe.poeche(a)siemens.com>
Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Johannes Hahn <johannes-hahn(a)siemens.com>
Gerrit-Attention: Werner Zeh <werner.zeh(a)siemens.com>
Gerrit-Comment-Date: Thu, 27 Feb 2025 13:11:30 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: Maximilian Brune, Paul Menzel.
Marvin Drees has posted comments on this change by Maximilian Brune. ( https://review.coreboot.org/c/coreboot/+/86543?usp=email )
Change subject: device/dram/ddr5: Add 7500 MT/s support
......................................................................
Patch Set 2: Code-Review+1
--
To view, visit https://review.coreboot.org/c/coreboot/+/86543?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I141f63c4fc505a9e16eed132a9a550441f4ad68d
Gerrit-Change-Number: 86543
Gerrit-PatchSet: 2
Gerrit-Owner: Maximilian Brune <maximilian.brune(a)9elements.com>
Gerrit-Reviewer: Marvin Drees <marvin.drees(a)9elements.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com>
Gerrit-Comment-Date: Thu, 27 Feb 2025 13:06:03 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: Dinesh Gehlot, Dtrain Hsu, Jayvik Desai, John Su, Nick Vaccaro.
Kapil Porwal has posted comments on this change by John Su. ( https://review.coreboot.org/c/coreboot/+/86514?usp=email )
Change subject: mb/trulo/var/uldrenite: Fix boot time caused by WWAN initialization
......................................................................
Patch Set 8: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/86514?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ie01019eca7eaa4bbb34dd80aeb65b9b6b08587fd
Gerrit-Change-Number: 86514
Gerrit-PatchSet: 8
Gerrit-Owner: John Su <john_su(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Reviewer: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Eric Lai <ericllai(a)google.com>
Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Jamie Chen <jamie_chen(a)compal.corp-partner.google.com>
Gerrit-CC: Van Chen <van_chen(a)compal.corp-partner.google.com>
Gerrit-Attention: Jayvik Desai <jayvik(a)google.com>
Gerrit-Attention: John Su <john_su(a)compal.corp-partner.google.com>
Gerrit-Attention: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com>
Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Comment-Date: Thu, 27 Feb 2025 12:27:58 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: Dinesh Gehlot, Eric Lai, Ivan Chen, Jayvik Desai, John Su, Nick Vaccaro, Subrata Banik.
Kapil Porwal has posted comments on this change by John Su. ( https://review.coreboot.org/c/coreboot/+/86615?usp=email )
Change subject: mb/trulo: Add host event EC_HOST_EVENT_BODY_DETECT_CHANGE
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/86615?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ifac0460e0e8feb33ad0085d250928adb593bb8ca
Gerrit-Change-Number: 86615
Gerrit-PatchSet: 1
Gerrit-Owner: John Su <john_su(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Reviewer: Eric Lai <ericllai(a)google.com>
Gerrit-Reviewer: Ivan Chen <yulunchen(a)google.com>
Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com>
Gerrit-CC: Jamie Chen <jamie_chen(a)compal.corp-partner.google.com>
Gerrit-Attention: Jayvik Desai <jayvik(a)google.com>
Gerrit-Attention: John Su <john_su(a)compal.corp-partner.google.com>
Gerrit-Attention: Eric Lai <ericllai(a)google.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Attention: Ivan Chen <yulunchen(a)google.com>
Gerrit-Comment-Date: Thu, 27 Feb 2025 12:13:02 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: Boris Mittelberg, Caveh Jalali, Dinesh Gehlot, Jayvik Desai, John Su, Nick Vaccaro, Subrata Banik.
Kapil Porwal has posted comments on this change by John Su. ( https://review.coreboot.org/c/coreboot/+/86494?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: mb/google/trulo/var/uldrenite: Support body detection to DPTF
......................................................................
Patch Set 3:
(1 comment)
File src/ec/google/chromeec/acpi/ec.asl:
https://review.coreboot.org/c/coreboot/+/86494/comment/6ab6b961_b680e5b2?us… :
PS3, Line 484: Method (_Q21, 0, NotSerialized)
This method doesn't have any action/commands. Could you please confirm?
--
To view, visit https://review.coreboot.org/c/coreboot/+/86494?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I6e98b9c3fd1b38d10a1aa7c30d5d92e1638449f2
Gerrit-Change-Number: 86494
Gerrit-PatchSet: 3
Gerrit-Owner: John Su <john_su(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Boris Mittelberg <bmbm(a)google.com>
Gerrit-Reviewer: Caveh Jalali <caveh(a)chromium.org>
Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Reviewer: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Eric Lai <ericllai(a)google.com>
Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Jamie Chen <jamie_chen(a)compal.corp-partner.google.com>
Gerrit-CC: Van Chen <van_chen(a)compal.corp-partner.google.com>
Gerrit-Attention: Jayvik Desai <jayvik(a)google.com>
Gerrit-Attention: John Su <john_su(a)compal.corp-partner.google.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Caveh Jalali <caveh(a)chromium.org>
Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Attention: Boris Mittelberg <bmbm(a)google.com>
Gerrit-Comment-Date: Thu, 27 Feb 2025 11:57:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Attention is currently required from: Nicholas Chin, Václav Straka.
Angel Pons has posted comments on this change by Václav Straka. ( https://review.coreboot.org/c/coreboot/+/85825?usp=email )
Change subject: mb/hp: Add Pro 3400
......................................................................
Patch Set 12: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/85825?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I833996f6eddcaac91fb0ad0cd95fcc2a99447387
Gerrit-Change-Number: 85825
Gerrit-PatchSet: 12
Gerrit-Owner: Václav Straka <venda.straka(a)gmail.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Václav Straka <venda.straka(a)gmail.com>
Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-Comment-Date: Thu, 27 Feb 2025 11:43:13 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: Angel Pons, Nicholas Chin.
Václav Straka has posted comments on this change by Václav Straka. ( https://review.coreboot.org/c/coreboot/+/85825?usp=email )
Change subject: mb/hp: Add Pro 3400
......................................................................
Patch Set 11:
(3 comments)
File src/mainboard/hp/pro_3x00_series/Kconfig:
https://review.coreboot.org/c/coreboot/+/85825/comment/98084df0_30d29ac9?us… :
PS11, Line 46: config DRAM_RESET_GATE_GPIO
: default 60
> That's the default and could be removed
Done
File src/mainboard/hp/pro_3x00_series/variants/pro_3400_series/board_info.txt:
https://review.coreboot.org/c/coreboot/+/85825/comment/74a502c8_4da4e550?us… :
PS11, Line 2: ROM IC: W25Q32BVSIG
> I wouldn't list the chip model, not all boards have the same chip model
Done
File src/mainboard/hp/pro_3x00_series/variants/pro_3500_series/board_info.txt:
https://review.coreboot.org/c/coreboot/+/85825/comment/7ec0537b_7c11a075?us… :
PS11, Line 2: ROM IC: W25Q64FVSIG
> Same, especially if the docs said something about a different chip model
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/85825?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I833996f6eddcaac91fb0ad0cd95fcc2a99447387
Gerrit-Change-Number: 85825
Gerrit-PatchSet: 11
Gerrit-Owner: Václav Straka <venda.straka(a)gmail.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-Comment-Date: Thu, 27 Feb 2025 11:32:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com>
Attention is currently required from: Angel Pons, Nicholas Chin, Václav Straka.
Hello Angel Pons, Nicholas Chin, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/85825?usp=email
to look at the new patch set (#12).
The following approvals got outdated and were removed:
Code-Review+1 by Angel Pons, Code-Review+2 by Nicholas Chin, Verified+1 by build bot (Jenkins)
Change subject: mb/hp: Add Pro 3400
......................................................................
mb/hp: Add Pro 3400
Based on autoport and HP Pro 3500.
As part of this change renamed 3500 to 3x00 and added this as
it's variant.
It's an almost identical board to the 3500 but has a smaller flash.
Other differences between boards were identified by autoport.
They may or may not important but were included anyway.
Tested on HP Pro 3400, behaves exactly as 3500 described in the docs.
Changes were not significant enough to require retesting on 3500.
Change-Id: I833996f6eddcaac91fb0ad0cd95fcc2a99447387
Signed-off-by: Vesek <venda.straka(a)gmail.com>
---
M Documentation/mainboard/hp/pro_3500_series.md
M Documentation/mainboard/index.md
D src/mainboard/hp/pro_3500_series/Kconfig
A src/mainboard/hp/pro_3x00_series/Kconfig
R src/mainboard/hp/pro_3x00_series/Kconfig.name
R src/mainboard/hp/pro_3x00_series/Makefile.mk
R src/mainboard/hp/pro_3x00_series/acpi/ec.asl
R src/mainboard/hp/pro_3x00_series/acpi/platform.asl
R src/mainboard/hp/pro_3x00_series/acpi/superio.asl
R src/mainboard/hp/pro_3x00_series/acpi_tables.c
A src/mainboard/hp/pro_3x00_series/board_info.txt
A src/mainboard/hp/pro_3x00_series/cmos.default
A src/mainboard/hp/pro_3x00_series/cmos.layout
R src/mainboard/hp/pro_3x00_series/common_defines.h
R src/mainboard/hp/pro_3x00_series/devicetree.cb
R src/mainboard/hp/pro_3x00_series/dsdt.asl
R src/mainboard/hp/pro_3x00_series/early_init.c
R src/mainboard/hp/pro_3x00_series/gma-mainboard.ads
R src/mainboard/hp/pro_3x00_series/hda_verb.c
R src/mainboard/hp/pro_3x00_series/led.c
R src/mainboard/hp/pro_3x00_series/led.h
R src/mainboard/hp/pro_3x00_series/mainboard.c
R src/mainboard/hp/pro_3x00_series/smihandler.c
C src/mainboard/hp/pro_3x00_series/variants/pro_3400_series/board_info.txt
A src/mainboard/hp/pro_3x00_series/variants/pro_3400_series/data.vbt
A src/mainboard/hp/pro_3x00_series/variants/pro_3400_series/gpio.c
A src/mainboard/hp/pro_3x00_series/variants/pro_3400_series/overridetree.cb
R src/mainboard/hp/pro_3x00_series/variants/pro_3500_series/board_info.txt
R src/mainboard/hp/pro_3x00_series/variants/pro_3500_series/data.vbt
R src/mainboard/hp/pro_3x00_series/variants/pro_3500_series/gpio.c
A src/mainboard/hp/pro_3x00_series/variants/pro_3500_series/overridetree.cb
31 files changed, 421 insertions(+), 96 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/25/85825/12
--
To view, visit https://review.coreboot.org/c/coreboot/+/85825?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I833996f6eddcaac91fb0ad0cd95fcc2a99447387
Gerrit-Change-Number: 85825
Gerrit-PatchSet: 12
Gerrit-Owner: Václav Straka <venda.straka(a)gmail.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Václav Straka <venda.straka(a)gmail.com>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com>