coreboot-gerrit January 2025

coreboot-gerrit@coreboot.org

1 participants
3269 discussions

[M] Change in coreboot[main]: [This Must Fail]Upgrade GCC to 15-20250119 Snapshot
by Elyes Haouas (Code Review) 22 Jan '25

22 Jan '25

1 0

[XS] Change in coreboot[main]: [LLVM test]: Use compiler-rt
by Elyes Haouas (Code Review) 22 Jan '25

22 Jan '25

Attention is currently required from: Felix Singer, Martin L Roth. Elyes Haouas has posted comments on this change by Elyes Haouas. ( https://review.coreboot.org/c/coreboot/+/86102?usp=email ) Change subject: [LLVM test]: Use compiler-rt ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: "make[2]: Entering directory '/home/coreboot/node-root/workspace/coreboot-gerrit' Updating git submodules. payloads/external/Makefile.mk:399: "Using host toolchain to build Linuxboot" OPTION option_table.h HOSTCC cbfstool/fmd_parser.o HOSTCC cbfstool/fmd_scanner.o HOSTCC /cb-build/coreboot-gerrit.0/emu_clang_allthreads/sharedutils/sconfig/sconfig (link) CC romstage/arch/x86/assembly_entry.o CC romstage/arch/x86/gdt_init.o CC romstage/arch/x86/idt.o GEN build.h make[2]: *** No rule to make target '/opt/xgcc/lib/clang/18/lib/baremetal/libclang_rt.builtins-i386.a', needed by '/cb-build/coreboot-gerrit.0/emu_clang_allthreads/EMULATION_QEMU_X86_Q35/smm/smm.elf'. Stop. make[2]: *** Waiting for unfinished jobs.... CC smm/arch/x86/idt.o make[2]: Leaving directory '/home/coreboot/node-root/workspace/coreboot-gerrit'" We have a problem using host toolchain, isn't it? -- To view, visit https://review.coreboot.org/c/coreboot/+/86102?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I7f015bbab530c7595e75279848e09e9edf74d5c5 Gerrit-Change-Number: 86102 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-CC: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Comment-Date: Wed, 22 Jan 2025 10:23:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[XS] Change in coreboot[main]: mb/google/nissa/var/telith: Configure Acoustic noise mitigation
by Subrata Banik (Code Review) 22 Jan '25

22 Jan '25

Attention is currently required from: Dinesh Gehlot, Eric Lai, Jayvik Desai, Jian Tong, Kapil Porwal, Kun Liu, Nick Vaccaro. Subrata Banik has posted comments on this change by Kun Liu. ( https://review.coreboot.org/c/coreboot/+/86103?usp=email ) Change subject: mb/google/nissa/var/telith: Configure Acoustic noise mitigation ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/86103?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I57055cdfc9377ba141c620dd4e9301f6e7601629 Gerrit-Change-Number: 86103 Gerrit-PatchSet: 1 Gerrit-Owner: Kun Liu <liukun11(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Dengwu Yu <yudengwu(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com> Gerrit-Reviewer: Jian Tong <tongjian(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Jayvik Desai <jayvik(a)google.com> Gerrit-Attention: Eric Lai <ericllai(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Attention: Jian Tong <tongjian(a)huaqin.corp-partner.google.com> Gerrit-Attention: Kun Liu <liukun11(a)huaqin.corp-partner.google.com> Gerrit-Comment-Date: Wed, 22 Jan 2025 09:56:51 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in coreboot[main]: mb/google/nissa/var/telith: Configure Acoustic noise mitigation
by Dengwu Yu (Code Review) 22 Jan '25

22 Jan '25

Attention is currently required from: Dinesh Gehlot, Eric Lai, Jayvik Desai, Jian Tong, Kapil Porwal, Kun Liu, Nick Vaccaro, Subrata Banik. Dengwu Yu has posted comments on this change by Kun Liu. ( https://review.coreboot.org/c/coreboot/+/86103?usp=email ) Change subject: mb/google/nissa/var/telith: Configure Acoustic noise mitigation ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/86103?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I57055cdfc9377ba141c620dd4e9301f6e7601629 Gerrit-Change-Number: 86103 Gerrit-PatchSet: 1 Gerrit-Owner: Kun Liu <liukun11(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Dengwu Yu <yudengwu(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com> Gerrit-Reviewer: Jian Tong <tongjian(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Jayvik Desai <jayvik(a)google.com> Gerrit-Attention: Eric Lai <ericllai(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Attention: Jian Tong <tongjian(a)huaqin.corp-partner.google.com> Gerrit-Attention: Kun Liu <liukun11(a)huaqin.corp-partner.google.com> Gerrit-Comment-Date: Wed, 22 Jan 2025 09:52:43 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in blobs[main]: soc/mediatek/mt8196: Add PI_IMG firmware v1.0
by Yu-Ping Wu (Code Review) 22 Jan '25

22 Jan '25

Attention is currently required from: Jarried Lin, Yidi Lin. Yu-Ping Wu has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/blobs/+/86095?usp=email ) Change subject: soc/mediatek/mt8196: Add PI_IMG firmware v1.0 ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: Note that this PI_IMG still contains unused sections. The concern in b/384392390 has not been addressed. -- To view, visit https://review.coreboot.org/c/blobs/+/86095?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: blobs Gerrit-Branch: main Gerrit-Change-Id: I4b36c928ad194f155442cf0e4314a826cfd3ef68 Gerrit-Change-Number: 86095 Gerrit-PatchSet: 1 Gerrit-Owner: Jarried Lin <jarried.lin(a)mediatek.com> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Attention: Jarried Lin <jarried.lin(a)mediatek.com> Gerrit-Attention: Yidi Lin <yidilin(a)google.com> Gerrit-Comment-Date: Wed, 22 Jan 2025 09:51:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[XS] Change in coreboot[main]: mb/google/nissa/var/telith: Configure Acoustic noise mitigation
by Kun Liu (Code Review) 22 Jan '25

22 Jan '25

Kun Liu has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/86103?usp=email ) Change subject: mb/google/nissa/var/telith: Configure Acoustic noise mitigation ...................................................................... mb/google/nissa/var/telith: Configure Acoustic noise mitigation - Set slow slew rate VCCIA and VCCGT to SLEW_FAST_4 BUG=b:387056119 BRANCH=none TEST=built firmware and verified by power team, and noise pass. Change-Id: I57055cdfc9377ba141c620dd4e9301f6e7601629 Signed-off-by: Kun Liu <liukun11(a)huaqin.corp-partner.google.com> --- M src/mainboard/google/brya/variants/telith/overridetree.cb 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/03/86103/1 diff --git a/src/mainboard/google/brya/variants/telith/overridetree.cb b/src/mainboard/google/brya/variants/telith/overridetree.cb index 231d83e..202b0ed 100644 --- a/src/mainboard/google/brya/variants/telith/overridetree.cb +++ b/src/mainboard/google/brya/variants/telith/overridetree.cb @@ -22,8 +22,8 @@ # Acoustic settings register "acoustic_noise_mitigation" = "true" - register "slow_slew_rate[VR_DOMAIN_IA]" = "SLEW_FAST_8" - register "slow_slew_rate[VR_DOMAIN_GT]" = "SLEW_FAST_8" + register "slow_slew_rate[VR_DOMAIN_IA]" = "SLEW_FAST_4" + register "slow_slew_rate[VR_DOMAIN_GT]" = "SLEW_FAST_4" register "fast_pkg_c_ramp_disable[VR_DOMAIN_IA]" = "1" register "fast_pkg_c_ramp_disable[VR_DOMAIN_GT]" = "1" -- To view, visit https://review.coreboot.org/c/coreboot/+/86103?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I57055cdfc9377ba141c620dd4e9301f6e7601629 Gerrit-Change-Number: 86103 Gerrit-PatchSet: 1 Gerrit-Owner: Kun Liu <liukun11(a)huaqin.corp-partner.google.com>

1 0

[XS] Change in coreboot[main]: amdfwtool: Set entry address mode based on current table header
by Bao Zheng (Code Review) 22 Jan '25

22 Jan '25

Attention is currently required from: Felix Held, Julius Werner, Marshall Dawson, Zheng Bao, ritul guru. Hello Felix Held, Julius Werner, Marshall Dawson, Zheng Bao, build bot (Jenkins), ritul guru, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/84530?usp=email to look at the new patch set (#13). Change subject: amdfwtool: Set entry address mode based on current table header ...................................................................... amdfwtool: Set entry address mode based on current table header The address field of each PSP or BIOS entry defines the location of the entry. For the family newer than Cezanne, the upper 2 bits define the address mode. In table header, the address mode of the table is set. They have the same definition. Address Mode 0: Physical Address Address Mode 1: Relative Address to entire BIOS image Address Mode 2: Relative Address to PSP/BIOS directory Address Mode 3: Relative Address to slot N In common case, the address mode of entry should be the same as its table. In spec, it says, "attribute is ignored if the directory address mode is not 2 or 3", In the old code, if the header defines address mode as relative BIOS(1), the entry address mode is not set. That meets the spec. PSP doesn't use, but amdfwtool can use it to record the address mode and transfer it to table. That can reduce the code complexity. Identidal binary test passes on platforms which are not based on Cezanne, V2000A, Genoa. Booting test passes on Majolica/Cezanne. Change-Id: I156b315d350d9e7217afc7442ca80277bb7f9095 Signed-off-by: Zheng Bao <fishbaozi(a)gmail.com> --- M util/amdfwtool/amdfwtool.c 1 file changed, 6 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/30/84530/13 -- To view, visit https://review.coreboot.org/c/coreboot/+/84530?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I156b315d350d9e7217afc7442ca80277bb7f9095 Gerrit-Change-Number: 84530 Gerrit-PatchSet: 13 Gerrit-Owner: Bao Zheng <fishbaozi(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Zheng Bao Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: ritul guru <ritul.bits(a)gmail.com> Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Attention: ritul guru <ritul.bits(a)gmail.com> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Zheng Bao Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>

1 0

[XS] Change in coreboot[main]: mb/google/corsola: fine tune the data lane trail
by Paul Menzel (Code Review) 22 Jan '25

22 Jan '25

Attention is currently required from: Hung-Te Lin, Xin Ji, Yidi Lin, Yu-Ping Wu. Paul Menzel has posted comments on this change by Xin Ji. ( https://review.coreboot.org/c/coreboot/+/86101?usp=email ) Change subject: mb/google/corsola: fine tune the data lane trail ...................................................................... Patch Set 1: (5 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/86101/comment/3be2de75_d9adccf2?us… : PS1, Line 7: fine tune the data lane trail More specific: > Increase ANX7625 data trail time https://review.coreboot.org/c/coreboot/+/86101/comment/7e686e82_486ef55b?us… : PS1, Line 8: Please start by describing the problem, like: Currently, the display flickers. https://review.coreboot.org/c/coreboot/+/86101/comment/02eaa915_b4368dd0?us… : PS1, Line 9: ANX7625 requires customized hs_da_trail time Why? According to the schematics? https://review.coreboot.org/c/coreboot/+/86101/comment/02aea16e_583bcfe7?us… : PS1, Line 9: override the : data trail for ANX7625 What is the current value, and what is the new value? Why is the new value correct? File src/mainboard/google/corsola/panel_anx7625.c: https://review.coreboot.org/c/coreboot/+/86101/comment/01d466a0_c0cba690?us… : PS1, Line 69: timing->da_hs_trail += 9; Maybe better use the absolute value, or does it always need to be increased by nine? -- To view, visit https://review.coreboot.org/c/coreboot/+/86101?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I677667240c7f3b0e14c6a728931921e32f539c57 Gerrit-Change-Number: 86101 Gerrit-PatchSet: 1 Gerrit-Owner: Xin Ji <xji(a)analogix.corp-partner.google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Xin Ji <xji(a)analogix.corp-partner.google.com> Gerrit-Attention: Yidi Lin <yidilin(a)google.com> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Comment-Date: Wed, 22 Jan 2025 09:26:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[M] Change in coreboot[main]: [This Must Fail]Upgrade GCC to 15-20250119 Snapshot
by Elyes Haouas (Code Review) 22 Jan '25

22 Jan '25

1 0

[L] Change in coreboot[main]: mb/asus: Add Maximus VI Gene (Haswell)
by Jan Philipp Groß (Code Review) 22 Jan '25

22 Jan '25

Attention is currently required from: Angel Pons, Máté Kukri, Nicholas Chin. Jan Philipp Groß has posted comments on this change by Jan Philipp Groß. ( https://review.coreboot.org/c/coreboot/+/85767?usp=email ) Change subject: mb/asus: Add Maximus VI Gene (Haswell) ...................................................................... Patch Set 8: (1 comment) File src/mainboard/asus/maximus_vi_gene/Kconfig: https://review.coreboot.org/c/coreboot/+/85767/comment/b0b02a5c_88129271?us… : PS7, Line 8: DRIVERS_ASMEDIA_ASPM_BLACKLIST > Needs rebase; this was changed to `DRIVERS_ASMEDIA_ASM1061` as of commit fee8bcbcfb55 ("drivers/asme […] Done -- To view, visit https://review.coreboot.org/c/coreboot/+/85767?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I31029c78cba65cad96718132235c140c3997c815 Gerrit-Change-Number: 85767 Gerrit-PatchSet: 8 Gerrit-Owner: Jan Philipp Groß <jeangrande(a)mailbox.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Máté Kukri <km(a)mkukri.xyz> Gerrit-Reviewer: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Máté Kukri <km(a)mkukri.xyz> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Comment-Date: Wed, 22 Jan 2025 08:55:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nicholas Chin <nic.c3.14(a)gmail.com>

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit January 2025