coreboot-gerrit January 2025

coreboot-gerrit@coreboot.org

1 participants
830 discussions

[M] Change in coreboot[main]: Documentation: Add Topton N100 (X2F)
by Nicholas Chin (Code Review) 05 Jan '25

05 Jan '25

Attention is currently required from: Alicja Michalska. Nicholas Chin has posted comments on this change by Alicja Michalska. ( https://review.coreboot.org/c/coreboot/+/85680?usp=email ) The change is no longer submittable: All-Comments-Resolved is unsatisfied now. Change subject: Documentation: Add Topton N100 (X2F) ...................................................................... Patch Set 2: (1 comment) File Documentation/mainboard/topton/adl/x2f-n100.md: https://review.coreboot.org/c/coreboot/+/85680/comment/e382bc19_dc277dbc?us… : PS2, Line 37: Without opening the case and connecting the SPI flasher. Is this indent intentional? Only the extra newline is necessary to make this appear on a separate line from the bullet points. The indent makes it aligned with the bullet point text, rather than the preceding paragraph (there's no indent in a similar line on the Polestar G613 patch) -- To view, visit https://review.coreboot.org/c/coreboot/+/85680?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Id585b064054b338ea8cead6edb6c5153030b9cde Gerrit-Change-Number: 85680 Gerrit-PatchSet: 2 Gerrit-Owner: Alicja Michalska <ahplka19(a)gmail.com> Gerrit-Reviewer: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Alicja Michalska <ahplka19(a)gmail.com> Gerrit-Comment-Date: Sun, 05 Jan 2025 22:35:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[M] Change in coreboot[main]: Documentation: Add Topton N100 (X2F)
by Nicholas Chin (Code Review) 05 Jan '25

05 Jan '25

Attention is currently required from: Alicja Michalska. Nicholas Chin has posted comments on this change by Alicja Michalska. ( https://review.coreboot.org/c/coreboot/+/85680?usp=email ) Change subject: Documentation: Add Topton N100 (X2F) ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/85680?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Id585b064054b338ea8cead6edb6c5153030b9cde Gerrit-Change-Number: 85680 Gerrit-PatchSet: 2 Gerrit-Owner: Alicja Michalska <ahplka19(a)gmail.com> Gerrit-Reviewer: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Alicja Michalska <ahplka19(a)gmail.com> Gerrit-Comment-Date: Sun, 05 Jan 2025 22:27:19 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in coreboot[main]: Documentation: Add Topton N100 (X2F)
by Alicja Michalska (Code Review) 05 Jan '25

05 Jan '25

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/85680?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by build bot (Jenkins) Change subject: Documentation: Add Topton N100 (X2F) ...................................................................... Documentation: Add Topton N100 (X2F) Document the board and how to flash coreboot. Change-Id: Id585b064054b338ea8cead6edb6c5153030b9cde Signed-off-by: Alicja Michalska <alicja.michalska(a)9elements.com> --- M Documentation/mainboard/index.md A Documentation/mainboard/topton/adl/x2f-n100.md 2 files changed, 108 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/80/85680/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/85680?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Id585b064054b338ea8cead6edb6c5153030b9cde Gerrit-Change-Number: 85680 Gerrit-PatchSet: 2 Gerrit-Owner: Alicja Michalska <ahplka19(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

[M] Change in coreboot[main]: Documentation: Add Erying Polestar G613 Pro
by Alicja Michalska (Code Review) 05 Jan '25

05 Jan '25

Attention is currently required from: Angel Pons, Felix Singer. Alicja Michalska has posted comments on this change by Alicja Michalska. ( https://review.coreboot.org/c/coreboot/+/81611?usp=email ) Change subject: Documentation: Add Erying Polestar G613 Pro ...................................................................... Patch Set 8: (1 comment) File Documentation/mainboard/erying/tgl/tgl_matx.md: https://review.coreboot.org/c/coreboot/+/81611/comment/71271716_2ad23d7c?us… : PS7, Line 119: Both blobs included in `3rdparty/blobs` repository have been extracted from vendor's firmware. : IFD region has been modified using `ifdtool` to flip `MeAltDisable` flag. > That is what I meant (regarding the indentation). Looks good to me. Awesome, thank you for taking a look! -- To view, visit https://review.coreboot.org/c/coreboot/+/81611?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I5d60508dbde10373b0da2fb4ece0992760d3121c Gerrit-Change-Number: 81611 Gerrit-PatchSet: 8 Gerrit-Owner: Alicja Michalska <ahplka19(a)gmail.com> Gerrit-Reviewer: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-CC: coreboot org <coreboot.org(a)gmail.com> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Sun, 05 Jan 2025 21:30:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Alicja Michalska <ahplka19(a)gmail.com> Comment-In-Reply-To: Nicholas Chin <nic.c3.14(a)gmail.com>

1 0

[M] Change in coreboot[main]: Documentation: Add Erying Polestar G613 Pro
by Nicholas Chin (Code Review) 05 Jan '25

05 Jan '25

Attention is currently required from: Alicja Michalska, Angel Pons, Felix Singer. Nicholas Chin has posted comments on this change by Alicja Michalska. ( https://review.coreboot.org/c/coreboot/+/81611?usp=email ) Change subject: Documentation: Add Erying Polestar G613 Pro ...................................................................... Patch Set 8: Code-Review+2 (1 comment) File Documentation/mainboard/erying/tgl/tgl_matx.md: https://review.coreboot.org/c/coreboot/+/81611/comment/23c49caa_37b2fc26?us… : PS7, Line 119: Both blobs included in `3rdparty/blobs` repository have been extracted from vendor's firmware. : IFD region has been modified using `ifdtool` to flip `MeAltDisable` flag. > I've re-phrased it a little bit and aligned to indentation (which makes sense IMO, as it's a part of […] That is what I meant (regarding the indentation). Looks good to me. -- To view, visit https://review.coreboot.org/c/coreboot/+/81611?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I5d60508dbde10373b0da2fb4ece0992760d3121c Gerrit-Change-Number: 81611 Gerrit-PatchSet: 8 Gerrit-Owner: Alicja Michalska <ahplka19(a)gmail.com> Gerrit-Reviewer: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-CC: coreboot org <coreboot.org(a)gmail.com> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Alicja Michalska <ahplka19(a)gmail.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Sun, 05 Jan 2025 21:29:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Alicja Michalska <ahplka19(a)gmail.com> Comment-In-Reply-To: Nicholas Chin <nic.c3.14(a)gmail.com>

1 0

[M] Change in coreboot[main]: Documentation: Add Erying Polestar G613 Pro
by Alicja Michalska (Code Review) 05 Jan '25

05 Jan '25

Attention is currently required from: Angel Pons, Felix Singer, Nicholas Chin. Alicja Michalska has posted comments on this change by Alicja Michalska. ( https://review.coreboot.org/c/coreboot/+/81611?usp=email ) Change subject: Documentation: Add Erying Polestar G613 Pro ...................................................................... Patch Set 8: (8 comments) File Documentation/mainboard/erying/tgl/tgl_matx.md: https://review.coreboot.org/c/coreboot/+/81611/comment/817aca04_2583b20a?us… : PS7, Line 37: By going to `Chipset -> Include CPU microcode in CBFS (Include external microcode binary)`. > Markdown ignores new lines without a blank line in between, so this […] ack :) https://review.coreboot.org/c/coreboot/+/81611/comment/36f8c647_5f32e552?us… : PS7, Line 66: If you're using [flashrom] or [flashprog] (fork of flashrom), you can skip extracting `SI_BIOS` and `SI_ME` regions from your ROM, and flash coreboot to `SI_BIOS` region by issuing the following command: > Please reflow to 72 characters Done https://review.coreboot.org/c/coreboot/+/81611/comment/f6ac8a98_a1c43ef0?us… : PS7, Line 112: `modprobe it87 force_id=0x8603 > Missing closing backtick? […] yup, thanks! https://review.coreboot.org/c/coreboot/+/81611/comment/a6be6789_5b76f940?us… : PS7, Line 117: - Intel Flash Descriptor (IFD) is required if you wish to flash the entire chip. : - Intel Management Engine blob is required if you wish to flash the entire chip. > These render a bit awkwardly (the bullets are at the same indent level […] Done https://review.coreboot.org/c/coreboot/+/81611/comment/99644cf4_4b8f904a?us… : PS7, Line 119: Both blobs included in `3rdparty/blobs` repository have been extracted from vendor's firmware. : IFD region has been modified using `ifdtool` to flip `MeAltDisable` flag. > As above; this renders as part of the bullet point about the Intel ME. […] I've re-phrased it a little bit and aligned to indentation (which makes sense IMO, as it's a part of point 1) https://review.coreboot.org/c/coreboot/+/81611/comment/13f2ca18_f59e2b06?us… : PS7, Line 123: It is possible to replace Winbond 16MB chip with 32MB equivalent, which would allow you to use LinuxBoot or implement RO + A/B VBOOT update scheme. > This renders on the same line as Modifications. […] Done https://review.coreboot.org/c/coreboot/+/81611/comment/3e46bf45_f69d7df7?us… : PS7, Line 126: If you are using an external graphics card (AMD Radeon, Nvidia GeForce, Intel Arc), you will see output in your OS as soon as kernel initializes the card (called "modprobing" in Linux) regardless of payload you chose. : This board have been tested with: : - EDK2 : - U-Boot : - LinuxBoot (U-Root + Linux kernel) > As above. I'd recommend indenting this to the same level as "Payload and ..." (i.e. […] Done https://review.coreboot.org/c/coreboot/+/81611/comment/0b4739ab_40ac145d?us… : PS7, Line 122: 2. Modifications : It is possible to replace Winbond 16MB chip with 32MB equivalent, which would allow you to use LinuxBoot or implement RO + A/B VBOOT update scheme. : : 3. Payload and pre-OS display output : If you are using an external graphics card (AMD Radeon, Nvidia GeForce, Intel Arc), you will see output in your OS as soon as kernel initializes the card (called "modprobing" in Linux) regardless of payload you chose. : This board have been tested with: : - EDK2 : - U-Boot : - LinuxBoot (U-Root + Linux kernel) : : If you would like to see output on your iGPU before that stage (for picking a different boot medium or toggling Secure Boot setting), you need to use [MrChromebox's EDK2] fork and include [GOP driver] for TigerLake iGPU in your build. : This will allow you to see output of EDK2 (payload, boot picker) on your monitor connected to iGPU. : : If you're planning to primarly use an external card, disable iGPU by toggling `Chipset -> Disable Integrated GFX Controller (0:2:0)` and use [elly's EDK2] tree. : In order to enable loading OpROMs from PCIe devices, go to `Payload -> edk2 additional custom build parameters` and add the string: `-D LOAD_OPTION_ROMS=TRUE`. : This functionality has been tested with following GPUs, with following results: : - Nvidia GeForce RTX3080;RTX3090: Works perfectly : - AMD Radeon RX6600XT;RX7800XT: Works with ReBAR disabled, no output in EDK2 with ReBAR enabled : - Intel Arc A580: Works with ReBAR disabled, glitched framebuffer before modprobing > Please reflow to 72 characters Done -- To view, visit https://review.coreboot.org/c/coreboot/+/81611?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I5d60508dbde10373b0da2fb4ece0992760d3121c Gerrit-Change-Number: 81611 Gerrit-PatchSet: 8 Gerrit-Owner: Alicja Michalska <ahplka19(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-CC: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-CC: coreboot org <coreboot.org(a)gmail.com> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Comment-Date: Sun, 05 Jan 2025 21:27:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nicholas Chin <nic.c3.14(a)gmail.com>

1 0

[M] Change in coreboot[main]: Documentation: Add Erying Polestar G613 Pro
by Alicja Michalska (Code Review) 05 Jan '25

05 Jan '25

Attention is currently required from: Alicja Michalska, Angel Pons, Felix Singer. Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/81611?usp=email to look at the new patch set (#8). The following approvals got outdated and were removed: Verified+1 by build bot (Jenkins) Change subject: Documentation: Add Erying Polestar G613 Pro ...................................................................... Documentation: Add Erying Polestar G613 Pro Document the board and process of building/flashing coreboot on it. Change-Id: I5d60508dbde10373b0da2fb4ece0992760d3121c Signed-off-by: Alicja Michalska <ahplka19(a)gmail.com> --- A Documentation/mainboard/erying/tgl/tgl_matx.md M Documentation/mainboard/index.md 2 files changed, 211 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/11/81611/8 -- To view, visit https://review.coreboot.org/c/coreboot/+/81611?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I5d60508dbde10373b0da2fb4ece0992760d3121c Gerrit-Change-Number: 81611 Gerrit-PatchSet: 8 Gerrit-Owner: Alicja Michalska <ahplka19(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-CC: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-CC: coreboot org <coreboot.org(a)gmail.com> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Alicja Michalska <ahplka19(a)gmail.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>

1 0

[L] Change in coreboot[main]: mb/starlabs/lite: Put options in CFR cbtable
by Sean Rhodes (Code Review) 05 Jan '25

05 Jan '25

Sean Rhodes has posted comments on this change by Sean Rhodes. ( https://review.coreboot.org/c/coreboot/+/76583?usp=email ) Change subject: mb/starlabs/lite: Put options in CFR cbtable ...................................................................... Set Ready For Review -- To view, visit https://review.coreboot.org/c/coreboot/+/76583?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I42ae5b35e6b53b5a13ec3f80180f4955db9b6ce2 Gerrit-Change-Number: 76583 Gerrit-PatchSet: 14 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 05 Jan 2025 20:17:43 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No

1 0

[XS] Change in coreboot[main]: ec/starlabs/merlin: Only include battery ACPI for systems with a battery
by Sean Rhodes (Code Review) 05 Jan '25

05 Jan '25

Sean Rhodes has posted comments on this change by Sean Rhodes. ( https://review.coreboot.org/c/coreboot/+/85716?usp=email ) Change subject: ec/starlabs/merlin: Only include battery ACPI for systems with a battery ...................................................................... Patch Set 5: -Code-Review -- To view, visit https://review.coreboot.org/c/coreboot/+/85716?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I381714887f4319d8e1a25c1e493ba03631cbf082 Gerrit-Change-Number: 85716 Gerrit-PatchSet: 5 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 05 Jan 2025 20:17:38 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in coreboot[main]: ec/starlabs/merlin: Only include battery ACPI for systems with a battery
by Sean Rhodes (Code Review) 05 Jan '25

05 Jan '25

Sean Rhodes has posted comments on this change by Sean Rhodes. ( https://review.coreboot.org/c/coreboot/+/85716?usp=email ) Change subject: ec/starlabs/merlin: Only include battery ACPI for systems with a battery ...................................................................... Patch Set 5: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/85716?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I381714887f4319d8e1a25c1e493ba03631cbf082 Gerrit-Change-Number: 85716 Gerrit-PatchSet: 5 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sun, 05 Jan 2025 20:17:32 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

← Newer
1
...
55
56
57
58
59
60
61
...
83
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit January 2025