coreboot-gerrit January 2025

coreboot-gerrit@coreboot.org

1 participants
3270 discussions

[XS] Change in coreboot[main]: util/crossgcc: Add missing printf variable
by Paul Menzel (Code Review) 26 Jan '25

26 Jan '25

Attention is currently required from: Jon Murphy, Karthik Ramasubramanian, Martin L Roth. Paul Menzel has posted comments on this change by Jon Murphy. ( https://review.coreboot.org/c/coreboot/+/86148?usp=email ) The change is no longer submittable: All-Comments-Resolved is unsatisfied now. Change subject: util/crossgcc: Add missing printf variable ...................................................................... Patch Set 2: (1 comment) File util/crossgcc/buildgcc: https://review.coreboot.org/c/coreboot/+/86148/comment/ad3efab5_d6ae7eef?us… : PS2, Line 859: if [[ ! -e ${LIBSTDCXX_INCLUDE_PATH} ]]; then Please also mention this change in the commit message. -- To view, visit https://review.coreboot.org/c/coreboot/+/86148?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I195718e43ea842970f5fa986315c9e9f11395362 Gerrit-Change-Number: 86148 Gerrit-PatchSet: 2 Gerrit-Owner: Jon Murphy <jpmurphy(a)google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Jon Murphy <jpmurphy(a)google.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Comment-Date: Sun, 26 Jan 2025 12:10:44 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[S] Change in coreboot[main]: mb/google/geralt: Enable CSOT_PNA957QT1_1 panel for Ciri
by Yang Wu (Code Review) 26 Jan '25

26 Jan '25

Attention is currently required from: Hung-Te Lin, Yidi Lin, Yu-Ping Wu. Hello Hung-Te Lin, Yidi Lin, Yu-Ping Wu, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/86158?usp=email to look at the new patch set (#2). Change subject: mb/google/geralt: Enable CSOT_PNA957QT1_1 panel for Ciri ...................................................................... mb/google/geralt: Enable CSOT_PNA957QT1_1 panel for Ciri Add CSOT_PNA957QT1_1 MIPI panel for Ciri. Datasheet: PNA957QT1-1 Product Spec_CSOT_V02_20250110.pdf BUG=b:391796227 TEST=Boot to firmware screen BRANCH=Geralt Change-Id: I306298c6eb172e4dd199e45a50e197fa87905e8c Signed-off-by: Yang Wu <wuyang5(a)huaqin.corp-partner.google.com> --- M src/mainboard/google/geralt/Kconfig M src/mainboard/google/geralt/panel_ciri.c 2 files changed, 10 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/58/86158/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/86158?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I306298c6eb172e4dd199e45a50e197fa87905e8c Gerrit-Change-Number: 86158 Gerrit-PatchSet: 2 Gerrit-Owner: Yang Wu <wuyang5(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Yidi Lin <yidilin(a)google.com> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com>

1 0

[XS] Change in coreboot[main]: soc/mediatek/mt8196: Correct SPM firmware file suffix to .bin
by Yu-Ping Wu (Code Review) 26 Jan '25

26 Jan '25

Attention is currently required from: Hung-Te Lin, Jarried Lin, Paul Menzel. Yu-Ping Wu has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/86156?usp=email ) Change subject: soc/mediatek/mt8196: Correct SPM firmware file suffix to .bin ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/86156?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I053e08c9665d434e4fc9a01bca52101218b2c634 Gerrit-Change-Number: 86156 Gerrit-PatchSet: 2 Gerrit-Owner: Jarried Lin <jarried.lin(a)mediatek.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Jarried Lin <jarried.lin(a)mediatek.com> Gerrit-Comment-Date: Sun, 26 Jan 2025 09:27:03 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in coreboot[main]: mb/google/geralt: Enable CSOT_PNA957QT1_1 panel for Ciri
by Yang Wu (Code Review) 26 Jan '25

26 Jan '25

Attention is currently required from: Hung-Te Lin, Yidi Lin, Yu-Ping Wu. Yang Wu has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/86158?usp=email ) Change subject: mb/google/geralt: Enable CSOT_PNA957QT1_1 panel for Ciri ...................................................................... mb/google/geralt: Enable CSOT_PNA957QT1_1 panel for Ciri Add CSOT_PNA957QT1_1 MIPI panel for Ciri. Datasheet: PNA957QT1-1 Product Spec_CSOT_V02_20250110.pdf BUG=b:391796227 TEST=Boot to firmware screen BRANCH=Geralt Change-Id: I306298c6eb172e4dd199e45a50e197fa87905e8c Signed-off-by: Yang Wu <wuyang5(a)huaqin.corp-partner.google.com> --- M src/mainboard/google/geralt/Kconfig M src/mainboard/google/geralt/panel_ciri.c 2 files changed, 10 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/58/86158/1 diff --git a/src/mainboard/google/geralt/Kconfig b/src/mainboard/google/geralt/Kconfig index 42522f5..ffd8431 100644 --- a/src/mainboard/google/geralt/Kconfig +++ b/src/mainboard/google/geralt/Kconfig @@ -40,6 +40,7 @@ select MIPI_PANEL_BOE_TV110C9M_LL0 if BOARD_GOOGLE_GERALT select MIPI_PANEL_BOE_NV110WUM_L60 if BOARD_GOOGLE_CIRI select MIPI_PANEL_IVO_T109NW41 if BOARD_GOOGLE_CIRI + select MIPI_PANEL_CSOT_PNA957QT1_1 if BOARD_GOOGLE_CIRI select FW_CONFIG select FW_CONFIG_SOURCE_CHROMEEC_CBI diff --git a/src/mainboard/google/geralt/panel_ciri.c b/src/mainboard/google/geralt/panel_ciri.c index 15c8859..4c21e90 100644 --- a/src/mainboard/google/geralt/panel_ciri.c +++ b/src/mainboard/google/geralt/panel_ciri.c @@ -44,6 +44,15 @@ .orientation = LB_FB_ORIENTATION_LEFT_UP, .disp_path = DISP_PATH_MIPI, .pwm_ctrl_gpio = true, + }, + + [51] = { + .name = "CSOT_PNA957QT1_1", + .power_on = power_on_mipi_himax_83102j, + .configure_backlight = configure_mipi_pwm_backlight, + .orientation = LB_FB_ORIENTATION_LEFT_UP, + .disp_path = DISP_PATH_MIPI, + .pwm_ctrl_gpio = true, } }; -- To view, visit https://review.coreboot.org/c/coreboot/+/86158?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I306298c6eb172e4dd199e45a50e197fa87905e8c Gerrit-Change-Number: 86158 Gerrit-PatchSet: 1 Gerrit-Owner: Yang Wu <wuyang5(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Yidi Lin <yidilin(a)google.com> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com>

1 0

[M] Change in coreboot[main]: drivers/mipi: Add support for CSOT_PNA957QT1_1 panel
by Yang Wu (Code Review) 26 Jan '25

26 Jan '25

Yang Wu has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/86157?usp=email ) Change subject: drivers/mipi: Add support for CSOT_PNA957QT1_1 panel ...................................................................... drivers/mipi: Add support for CSOT_PNA957QT1_1 panel Add CSOT panel PNA957QT1-1 serializable data to CBFS. Datasheet: HX83102-J Initial code_CSOT 10p95_USI_60Hz_DPHY_20250123_V2 BUG=b:391796227 TEST=build and check the CBFS include the panel BRANCH=Geralt Change-Id: Ibd092fa8f2e33f2692c61a7f302224c01678db05 Signed-off-by: Yang Wu <wuyang5(a)huaqin.corp-partner.google.com> --- M src/drivers/mipi/Kconfig M src/drivers/mipi/Makefile.mk A src/drivers/mipi/panel-CSOT_PNA957QT1_1.c 3 files changed, 113 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/57/86157/1 diff --git a/src/drivers/mipi/Kconfig b/src/drivers/mipi/Kconfig index 1edebf9..1d271c7 100644 --- a/src/drivers/mipi/Kconfig +++ b/src/drivers/mipi/Kconfig @@ -36,6 +36,9 @@ config MIPI_PANEL_CMN_P097PFG_SSD2858 bool +config MIPI_PANEL_CSOT_PNA957QT1_1 + bool + config MIPI_PANEL_INX_HJ110IZ_01A_B2 bool diff --git a/src/drivers/mipi/Makefile.mk b/src/drivers/mipi/Makefile.mk index de566d4..9464421 100644 --- a/src/drivers/mipi/Makefile.mk +++ b/src/drivers/mipi/Makefile.mk @@ -18,6 +18,8 @@ panel-params-$(CONFIG_MIPI_PANEL_CMN_P097PFG_SSD2858) += panel-CMN_P097PFG_SSD2858 +panel-params-$(CONFIG_MIPI_PANEL_CSOT_PNA957QT1_1) += panel-CSOT_PNA957QT1_1 + panel-params-$(CONFIG_MIPI_PANEL_INX_HJ110IZ_01A_B2) += panel-INX_HJ110IZ_01A_B2 panel-params-$(CONFIG_MIPI_PANEL_INX_OTA7290D10P) += panel-INX_OTA7290D10P diff --git a/src/drivers/mipi/panel-CSOT_PNA957QT1_1.c b/src/drivers/mipi/panel-CSOT_PNA957QT1_1.c new file mode 100644 index 0000000..6882db6 --- /dev/null +++ b/src/drivers/mipi/panel-CSOT_PNA957QT1_1.c @@ -0,0 +1,108 @@ +/* SPDX-License-Identifier: GPL-2.0-only */ + +#include <mipi/panel.h> + +struct panel_serializable_data CSOT_PNA957QT1_1 = { + .edid = { + .ascii_string = "PNA957QT1_1", + .manufacturer_name = "CSOT", + .panel_bits_per_color = 8, + .panel_bits_per_pixel = 24, + .mode = { + .pixel_clock = 177958, + .lvds_dual_channel = 0, + .refresh = 60, + .ha = 1200, .hbl = 244, .hso = 124, .hspw = 80, + .va = 1920, .vbl = 134, .vso = 88, .vspw = 8, + .phsync = '-', .pvsync = '-', + .x_mm = 147, .y_mm = 235, + }, + }, + .init = { + PANEL_DELAY(60), + PANEL_DCS(0xB9, 0x83, 0x10, 0x21, 0x55, 0x00), + PANEL_DCS(0xE9, 0xC4), + PANEL_DCS(0xD9, 0xD2), + PANEL_DCS(0xE9, 0x3F), + PANEL_DCS(0xB1, 0x2C, 0xB3, 0xB3, 0x31, 0xF1, 0x33, 0xE0, 0x54, 0x36, + 0x36, 0x3A, 0x3A, 0x32, 0x8B, 0x11, 0xE5, 0x98), + PANEL_DCS(0xE9, 0xD9), + PANEL_DCS(0xB1, 0x8B, 0x33), + PANEL_DCS(0xE9, 0x3F), + PANEL_DCS(0xB2, 0x00, 0x47, 0xB0, 0x80, 0x00, 0x2C, 0x80, 0x3C, 0x9F, + 0x22, 0x20, 0x00, 0x00, 0x98, 0x51), + PANEL_DCS(0xB4, 0x41, 0x41, 0x41, 0x41, 0x64, 0x64, 0x40, 0x84, 0x64, + 0x84, 0x01, 0x9D, 0x01, 0x02, 0x01, 0x00, 0x00), + PANEL_DCS(0xBC, 0x1B, 0x04), + PANEL_DCS(0xBE, 0x20), + PANEL_DCS(0xBF, 0xFC, 0xC4, 0x80, 0x9C, 0x36, 0x00, 0x0D, 0x04), + PANEL_DCS(0xC0, 0x32, 0x32, 0x22, 0x11, 0x22, 0xA0, 0x31, 0x08, 0xF5, + 0x03), + PANEL_DCS(0xE9, 0xCC), + PANEL_DCS(0xC7, 0x80), + PANEL_DCS(0xE9, 0x3F), + PANEL_DCS(0xE9, 0xC6), + PANEL_DCS(0xC8, 0x97), + PANEL_DCS(0xE9, 0x3F), + PANEL_DCS(0xC9, 0x00, 0x1E, 0x13, 0x88, 0x01), + PANEL_DCS(0xCB, 0x08, 0x13, 0x07, 0x00, 0x0F, 0x36), + PANEL_DCS(0xCC, 0x02, 0x03, 0x44), + PANEL_DCS(0xD1, 0x07, 0x06, 0x00, 0x02, 0x04, 0x2C, 0xFF), + PANEL_DCS(0xD3, 0x06, 0x00, 0x00, 0x00, 0x40, 0x04, 0x08, 0x04, 0x08, + 0x37, 0x07, 0x44, 0x37, 0x2B, 0x2B, 0x03, 0x03, 0x32, 0x10, 0x22, + 0x00, 0x25, 0x32, 0x10, 0x29, 0x00, 0x29, 0x32, 0x10, 0x08, 0x00, + 0x08, 0x00, 0x00), + PANEL_DCS(0xD5, 0x18, 0x18, 0x18, 0x18, 0x18, 0x18, 0x18, 0x18, 0x18, + 0x18, 0x07, 0x06, 0x07, 0x06, 0x05, 0x04, 0x05, 0x04, 0x03, 0x02, + 0x03, 0x02, 0x01, 0x00, 0x01, 0x00, 0x18, 0x18, 0x25, 0x24, 0x25, + 0x24, 0x1F, 0x1F, 0x1F, 0x1F, 0x1E, 0x1E, 0x1E, 0x1E, 0x20, 0x20, + 0x20, 0x20), + PANEL_DCS(0xD8, 0x0A, 0x2A, 0xAA, 0x8A, 0xAA, 0xA0, 0x0A, 0x2A, 0xAA, + 0x8A, 0xAA, 0xA0), + PANEL_DCS(0xE0, 0x0A, 0x0E, 0x1A, 0x21, 0x28, 0x46, 0x5C, 0x61, 0x63, + 0x5E, 0x78, 0x7D, 0x80, 0x8E, 0x89, 0x90, 0x98, 0xAA, 0xA8, 0x52, + 0x59, 0x60, 0x6F, 0x06, 0x0A, 0x16, 0x1D, 0x24, 0x46, 0x5C, 0x61, + 0x6B, 0x66, 0x7C, 0x7D, 0x80, 0x8E, 0x89, 0x90, 0x98, 0xAA, 0xA8, + 0x52, 0x59, 0x60, 0x6F), + PANEL_DCS(0xE7, 0xE0, 0x10, 0x10, 0x0D, 0x1E, 0x9D, 0x02, 0x52, 0x9D, + 0x14, 0x14), + PANEL_DCS(0xBD, 0x01), + PANEL_DCS(0xB1, 0x01, 0x7F, 0x11, 0xFD), + PANEL_DCS(0xE9, 0xC5), + PANEL_DCS(0xBA, 0x4F), + PANEL_DCS(0xE9, 0x3F), + PANEL_DCS(0xCB, 0x86), + PANEL_DCS(0xD2, 0x64), + PANEL_DCS(0xE9, 0xC5), + PANEL_DCS(0xD3, 0x00), + PANEL_DCS(0xE9, 0x3F), + PANEL_DCS(0xD8, 0x0A, 0x2A, 0xAA, 0x8A, 0xAA, 0xA0, 0x0A, 0x2A, 0xAA, + 0x8A, 0xAA, 0xA0, 0x05, 0x15, 0x55, 0x45, 0x55, 0x50, 0x05, 0x15, + 0x55, 0x45, 0x55, 0x50), + PANEL_DCS(0xE7, 0x02, 0x00, 0x24, 0x01, 0x7E, 0x0F, 0x7C, 0x10, 0xA0, + 0x00, 0x00), + PANEL_DCS(0xBD, 0x02), + PANEL_DCS(0xCB, 0x03, 0x07, 0x00, 0x10, 0x7B), + PANEL_DCS(0xD8, 0x0F, 0x3F, 0xFF, 0xCF, 0xFF, 0xF0, 0x0F, 0x3F, 0xFF, + 0xCF, 0xFF, 0xF0), + PANEL_DCS(0xE7, 0xFE, 0x01, 0xFE, 0x01, 0xFE, 0x01, 0x00, 0x00, 0x00, + 0x23, 0x00, 0x23, 0x81, 0x02, 0x40, 0x00, 0x20, 0x9D, 0x02, 0x01, + 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x01, 0x00), + PANEL_DCS(0xBD, 0x03), + PANEL_DCS(0xB2, 0x66, 0x81), + PANEL_DCS(0xE9, 0xC6), + PANEL_DCS(0xB4, 0x03, 0xFF, 0xF8), + PANEL_DCS(0xE9, 0x3F), + PANEL_DCS(0xD8, 0x0A, 0x2A, 0xAA, 0x8A, 0xAA, 0xA0, 0x0A, 0x2A, 0xAA, + 0x8A, 0xAA, 0xA0, 0x0F, 0x2A, 0xAA, 0x8A, 0xAA, 0xF0, 0x0F, 0x2A, + 0xAA, 0x8A, 0xAA, 0xF0, 0x0A, 0x2A, 0xAA, 0x8A, 0xAA, 0xA0, 0x0A, + 0x2A, 0xAA, 0x8A, 0xAA, 0xA0), + PANEL_DCS(0xBD, 0x00), + PANEL_DCS(0xB9, 0x00, 0x00, 0x00, 0x00), + PANEL_DCS(0x11), + PANEL_DELAY(120), + PANEL_DCS(0x29), + PANEL_DELAY(20), + PANEL_END, + }, +}; -- To view, visit https://review.coreboot.org/c/coreboot/+/86157?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ibd092fa8f2e33f2692c61a7f302224c01678db05 Gerrit-Change-Number: 86157 Gerrit-PatchSet: 1 Gerrit-Owner: Yang Wu <wuyang5(a)huaqin.corp-partner.google.com>

1 0

[XS] Change in coreboot[main]: mb/google/corsola: Increase ANX7625 data trail time
by Yidi Lin (Code Review) 26 Jan '25

26 Jan '25

Yidi Lin has submitted this change. ( https://review.coreboot.org/c/coreboot/+/86101?usp=email ) ( 4 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: mb/google/corsola: Increase ANX7625 data trail time ...................................................................... mb/google/corsola: Increase ANX7625 data trail time Currently, the eDP panel has display shift issue. This issue is caused by too short HS-trail time. Based on hardware design ANX7625 requires more HS-trail time to finish mipi data packet decoding before entering LP mode. So increase HS-trail time to avoid effect of entering LP mode. da_hs_trail value copy from "kukui/panel_anx7625.c", verified on corsola. BUG=b:391304679 BRANCH=corsola TEST=Display is normal on corsola Change-Id: I677667240c7f3b0e14c6a728931921e32f539c57 Signed-off-by: Xin Ji <xji(a)analogix.corp-partner.google.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/86101 Reviewed-by: Yu-Ping Wu <yupingso(a)google.com> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Paul Menzel <paulepanter(a)mailbox.org> Reviewed-by: Yidi Lin <yidilin(a)google.com> --- M src/mainboard/google/corsola/panel_anx7625.c 1 file changed, 6 insertions(+), 0 deletions(-) Approvals: build bot (Jenkins): Verified Paul Menzel: Looks good to me, but someone else must approve Yu-Ping Wu: Looks good to me, approved Yidi Lin: Looks good to me, approved diff --git a/src/mainboard/google/corsola/panel_anx7625.c b/src/mainboard/google/corsola/panel_anx7625.c index 193a501..048713f 100644 --- a/src/mainboard/google/corsola/panel_anx7625.c +++ b/src/mainboard/google/corsola/panel_anx7625.c @@ -5,6 +5,7 @@ #include <drivers/analogix/anx7625/anx7625.h> #include <edid.h> #include <gpio.h> +#include <soc/dsi.h> #include <soc/i2c.h> #include "gpio.h" @@ -62,3 +63,8 @@ mtk_i2c_bus_init(BRIDGE_I2C, I2C_SPEED_FAST); return &anx7625_bridge; } + +void mtk_dsi_override_phy_timing(struct mtk_phy_timing *timing) +{ + timing->da_hs_trail += 9; +} -- To view, visit https://review.coreboot.org/c/coreboot/+/86101?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I677667240c7f3b0e14c6a728931921e32f539c57 Gerrit-Change-Number: 86101 Gerrit-PatchSet: 6 Gerrit-Owner: Xin Ji <xji(a)analogix.corp-partner.google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

[XS] Change in coreboot[main]: soc/mediatek/mt8196: Correct SPM firmware file suffix to .bin
by Yidi Lin (Code Review) 26 Jan '25

26 Jan '25

Attention is currently required from: Hung-Te Lin, Jarried Lin, Paul Menzel, Yu-Ping Wu. Yidi Lin has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/86156?usp=email ) Change subject: soc/mediatek/mt8196: Correct SPM firmware file suffix to .bin ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/86156?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I053e08c9665d434e4fc9a01bca52101218b2c634 Gerrit-Change-Number: 86156 Gerrit-PatchSet: 2 Gerrit-Owner: Jarried Lin <jarried.lin(a)mediatek.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Jarried Lin <jarried.lin(a)mediatek.com> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Comment-Date: Sun, 26 Jan 2025 09:12:31 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in coreboot[main]: soc/mediatek/mt8196: Correct SPM firmware file suffix to .bin
by Jarried Lin (Code Review) 26 Jan '25

26 Jan '25

Attention is currently required from: Hung-Te Lin, Paul Menzel, Yidi Lin, Yu-Ping Wu. Jarried Lin has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/86156?usp=email ) Change subject: soc/mediatek/mt8196: Correct SPM firmware file suffix to .bin ...................................................................... Patch Set 2: (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/86156/comment/f05302c1_3ce1df65?us… : PS1, Line 7: extension > suffix to . […] Done https://review.coreboot.org/c/coreboot/+/86156/comment/7a253e45_f182315d?us… : PS1, Line 14: > > `'successfull' may be misspelled - perhaps 'successful'?` […] thanks -- To view, visit https://review.coreboot.org/c/coreboot/+/86156?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I053e08c9665d434e4fc9a01bca52101218b2c634 Gerrit-Change-Number: 86156 Gerrit-PatchSet: 2 Gerrit-Owner: Jarried Lin <jarried.lin(a)mediatek.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Yidi Lin <yidilin(a)google.com> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Comment-Date: Sun, 26 Jan 2025 08:53:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>

1 0

[XS] Change in coreboot[main]: soc/mediatek/mt8196: Correct SPM firmware file suffix to .bin
by Jarried Lin (Code Review) 26 Jan '25

26 Jan '25

Attention is currently required from: Hung-Te Lin, Jarried Lin, Yidi Lin, Yu-Ping Wu. Hello Hung-Te Lin, Yidi Lin, Yu-Ping Wu, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/86156?usp=email to look at the new patch set (#2). Change subject: soc/mediatek/mt8196: Correct SPM firmware file suffix to .bin ...................................................................... soc/mediatek/mt8196: Correct SPM firmware file suffix to .bin Correct SPM firmware file suffix from .pm to .bin in Kconfig. coreboot log: mtk_init_mcu: Loaded (and reset) spm_firmware.bin in 3 msecs (30114 bytes) SPM: spm_init done in 3 msecs, spm pc = 0x1430 TEST=Build pass, boot successful. BUG=b:348147674 Change-Id: I053e08c9665d434e4fc9a01bca52101218b2c634 Signed-off-by: Jarried Lin <jarried.lin(a)mediatek.corp-partner.google.com> --- M src/soc/mediatek/mt8196/Kconfig 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/56/86156/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/86156?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I053e08c9665d434e4fc9a01bca52101218b2c634 Gerrit-Change-Number: 86156 Gerrit-PatchSet: 2 Gerrit-Owner: Jarried Lin <jarried.lin(a)mediatek.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Jarried Lin <jarried.lin(a)mediatek.com> Gerrit-Attention: Yidi Lin <yidilin(a)google.com> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com>

1 0

[XS] Change in coreboot[main]: soc/mediatek/mt8196: Correct SPM firmware file extension
by Paul Menzel (Code Review) 26 Jan '25

26 Jan '25

Attention is currently required from: Hung-Te Lin, Jarried Lin, Yidi Lin, Yu-Ping Wu. Paul Menzel has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/86156?usp=email ) Change subject: soc/mediatek/mt8196: Correct SPM firmware file extension ...................................................................... Patch Set 1: (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/86156/comment/8f591aad_b7f355d6?us… : PS1, Line 7: extension suffix to .bin https://review.coreboot.org/c/coreboot/+/86156/comment/3d4cefd3_7104678f?us… : PS1, Line 14: > `'successfull' may be misspelled - perhaps 'successful'?` Please fix. -- To view, visit https://review.coreboot.org/c/coreboot/+/86156?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I053e08c9665d434e4fc9a01bca52101218b2c634 Gerrit-Change-Number: 86156 Gerrit-PatchSet: 1 Gerrit-Owner: Jarried Lin <jarried.lin(a)mediatek.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Jarried Lin <jarried.lin(a)mediatek.com> Gerrit-Attention: Yidi Lin <yidilin(a)google.com> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Comment-Date: Sun, 26 Jan 2025 08:49:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit January 2025