Attention is currently required from: Sean Rhodes.
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/84598?usp=email
to look at the new patch set (#5).
The following approvals got outdated and were removed:
Verified+1 by build bot (Jenkins)
Change subject: soc/intel/common/cnvi: Add CNMT Mutex
......................................................................
soc/intel/common/cnvi: Add CNMT Mutex
Add "CNMT" Mutex, that will be used by the Bluetooth and CNVi
driver.
Change-Id: I607865458f925d6f4aa713e07cfa34e83b2e5c8f
Signed-off-by: Sean Rhodes <sean(a)starlabs.systems>
---
M src/soc/intel/common/block/cnvi/cnvi.c
1 file changed, 18 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/98/84598/5
--
To view, visit https://review.coreboot.org/c/coreboot/+/84598?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I607865458f925d6f4aa713e07cfa34e83b2e5c8f
Gerrit-Change-Number: 84598
Gerrit-PatchSet: 5
Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems>
Attention is currently required from: Matt DeVillier, Nico Huber, Sean Rhodes.
Hello Matt DeVillier, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/83556?usp=email
to look at the new patch set (#16).
The following approvals got outdated and were removed:
Verified+1 by build bot (Jenkins)
Change subject: soc/intel/cnvi: Add CNVW OpRegion
......................................................................
soc/intel/cnvi: Add CNVW OpRegion
The CNVi driver is relatively basic in coreboot and most
noticeably, recent Linux kernels flag that lack of a _PRR
method, which is used to reset WiFi and Bluetooth.
This patch series adds methods recommended by Intel in
document #559910.
This patch defines an OpRegion for CNVi, for both
integrated and dedicated solutions.
Change-Id: Idd2ff93fb65c40f656804d96966e1881202ccb56
Signed-off-by: Sean Rhodes <sean(a)starlabs.systems>
---
M src/soc/intel/common/block/cnvi/cnvi.c
A src/soc/intel/common/block/include/intelblocks/cnvi.h
2 files changed, 82 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/56/83556/16
--
To view, visit https://review.coreboot.org/c/coreboot/+/83556?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Idd2ff93fb65c40f656804d96966e1881202ccb56
Gerrit-Change-Number: 83556
Gerrit-PatchSet: 16
Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com>
Attention is currently required from: Felix Singer.
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/83107?usp=email
to look at the new patch set (#28).
Change subject: mb/asrock: Add Asrock Industrial IMB-1222 motherboard
......................................................................
mb/asrock: Add Asrock Industrial IMB-1222 motherboard
ASRock IMB-1222 Intel Comet Lake-S Q470E industrial thin mini-ITX
motherboard [1].
Working:
- Dual Channel DDR4 2933/2666/2400 MHz;
- Intel UHD Graphics (VGA Option ROM, libgfxinit, GOP driver);
- DP (both), HDMI;
- PCIe x16 Slot (Gen3);
- SATA ports;
- USB 2.0 ports;
- USB 3.2 ports;
- M.2 Key-E 2230 slot for Wireless (PCIe x1, USB 2.0 and CNVi);
- M.2 Key-B 3042/3052 slot for 4G/5G modem (PCIe x1);
- M.2 Key-M 2242/2260/2280 for SSD/NVMe (PCIE x4, SATA3);
- LAN1 Intel I225LM/I225V, 10/100/1000/2500 Mbps;
- LAN2 Intel I219LM, 10/100/1000 Mbps;
- Realtek ALC887 HD Audio (line-out, mic-in);
- COM 1/2/3/4 ports;
- onboard speaker;
- HWM/FANs control (fintek f81966);
- S3 suspend and wake;
- TPM;
- disabling ME with me_cleaner [2];
Payload:
- Linux as payload;
- LinuxBoot;
- SeaBIOS;
- edk2 [3].
Bootable OS:
- Ubuntu 22.04 (Linux 6.5.0-15-generic);
- Ubuntu 24.04 (Linux 6.8.0-41-generic);
- Microsoft Windows 10 Pro 10.0.19045.4780 (22H2 2022).
Unknown/untested:
- USB3.0 in M.2 Key-B 3042/3052 slot;
- eDP/LVDS;
- PCIe riser cards;
- SPDIF.
There is no schematic/boardview, reverse engineering only.
This port is based on system76/bonw14 because it has a similar topology.
[1] https://web.archive.org/web/20220924171403/https://www.asrockind.com/en-gb/IMB-1222
[2] XutaxKamay's me_cleaner fork,
https://github.com/XutaxKamay/me_cleaner, v1.2-9-gf20532d
[3] MrChromebox's edk2 fork, https://github.com/mrchromebox/edk2
uefipayload_2408 branch
Change-Id: Id2b4c903546f9174b5e7dd26e54a0c5aaa09e1f8
Signed-off-by: Maxim Polyakov <max.senia.poliak(a)gmail.com>
---
A Documentation/mainboard/asrock/imb-1222.md
M Documentation/mainboard/index.md
A src/mainboard/asrock/imb-1222/Kconfig
A src/mainboard/asrock/imb-1222/Kconfig.name
A src/mainboard/asrock/imb-1222/Makefile.mk
A src/mainboard/asrock/imb-1222/acpi/mainboard.asl
A src/mainboard/asrock/imb-1222/acpi/sleep.asl
A src/mainboard/asrock/imb-1222/beep.c
A src/mainboard/asrock/imb-1222/board_info.txt
A src/mainboard/asrock/imb-1222/bootblock.c
A src/mainboard/asrock/imb-1222/cmos.default
A src/mainboard/asrock/imb-1222/cmos.layout
A src/mainboard/asrock/imb-1222/data.vbt
A src/mainboard/asrock/imb-1222/devicetree.cb
A src/mainboard/asrock/imb-1222/dsdt.asl
A src/mainboard/asrock/imb-1222/gma-mainboard.ads
A src/mainboard/asrock/imb-1222/gpio.c
A src/mainboard/asrock/imb-1222/hda_verb.c
A src/mainboard/asrock/imb-1222/include/mainboard/beep.h
A src/mainboard/asrock/imb-1222/include/mainboard/gpio.h
A src/mainboard/asrock/imb-1222/include/mainboard/superio.h
A src/mainboard/asrock/imb-1222/panic.c
A src/mainboard/asrock/imb-1222/ramstage.c
A src/mainboard/asrock/imb-1222/romstage.c
A src/mainboard/asrock/imb-1222/superio.c
25 files changed, 1,412 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/07/83107/28
--
To view, visit https://review.coreboot.org/c/coreboot/+/83107?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Id2b4c903546f9174b5e7dd26e54a0c5aaa09e1f8
Gerrit-Change-Number: 83107
Gerrit-PatchSet: 28
Gerrit-Owner: Maxim <max.senia.poliak(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Attention is currently required from: Mario Scheithauer, Maxim, Paul Menzel, Sean Rhodes, Tim Crawford.
Hello Mario Scheithauer, Paul Menzel, Sean Rhodes, Tim Crawford, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/84442?usp=email
to look at the new patch set (#5).
The following approvals got outdated and were removed:
Verified+1 by build bot (Jenkins)
Change subject: soc/intel/cannonlake: Add missing USB port aliases
......................................................................
soc/intel/cannonlake: Add missing USB port aliases
FSP for Comet Lake S allows one to configure 16 USB2 (PortUsb20Enable
array) ports and 10 USB3 (PortUsb30Enable array) ports [1, 2].
[1] src/soc/intel/cannonlake/chip.h
[2] 3rdparty/fsp/CometLakeFspBinPkg/CometLakeS/Include/FspsUpd.h
Change-Id: Ie69543f335be1a69cf0c068335c2e17eebf4c6a9
Signed-off-by: Maxim Polyakov <max.senia.poliak(a)gmail.com>
---
M src/soc/intel/cannonlake/chipset_pch_h.cb
1 file changed, 24 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/42/84442/5
--
To view, visit https://review.coreboot.org/c/coreboot/+/84442?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ie69543f335be1a69cf0c068335c2e17eebf4c6a9
Gerrit-Change-Number: 84442
Gerrit-PatchSet: 5
Gerrit-Owner: Maxim <max.senia.poliak(a)gmail.com>
Gerrit-Reviewer: Mario Scheithauer <mario.scheithauer(a)siemens.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-Reviewer: Tim Crawford <tcrawford(a)system76.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Tim Crawford <tcrawford(a)system76.com>
Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-Attention: Maxim <max.senia.poliak(a)gmail.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Mario Scheithauer <mario.scheithauer(a)siemens.com>
Attention is currently required from: Felix Singer.
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/83107?usp=email
to look at the new patch set (#27).
The following approvals got outdated and were removed:
Verified+1 by build bot (Jenkins)
Change subject: mb/asrock: Add Asrock Industrial IMB-1222 motherboard
......................................................................
mb/asrock: Add Asrock Industrial IMB-1222 motherboard
ASRock IMB-1222 Intel Comet Lake-S Q470E industrial thin mini-ITX
motherboard [1].
Working:
- Dual Channel DDR4 2933/2666/2400 MHz;
- Intel UHD Graphics (VGA Option ROM, libgfxinit, GOP driver);
- DP (both), HDMI;
- PCIe x16 Slot (Gen3);
- SATA ports;
- USB 2.0 ports;
- USB 3.2 ports;
- M.2 Key-E 2230 slot for Wireless (PCIe x1, USB 2.0 and CNVi);
- M.2 Key-B 3042/3052 slot for 4G/5G modem (PCIe x1);
- M.2 Key-M 2242/2260/2280 for SSD/NVMe (PCIE x4, SATA3);
- LAN1 Intel I225LM/I225V, 10/100/1000/2500 Mbps;
- LAN2 Intel I219LM, 10/100/1000 Mbps;
- Realtek ALC887 HD Audio (line-out, mic-in);
- COM 1/2/3/4 ports;
- onboard speaker;
- HWM/FANs control (fintek f81966);
- S3 suspend and wake;
- TPM;
- disabling ME with me_cleaner [2];
Payload:
- Linux as payload;
- LinuxBoot;
- SeaBIOS;
- edk2 [3].
Bootable OS:
- Ubuntu 22.04 (Linux 6.5.0-15-generic);
- Ubuntu 24.04 (Linux 6.8.0-41-generic);
- Microsoft Windows 10 Pro 10.0.19045.4780 (22H2 2022).
Unknown/untested:
- USB3.0 in M.2 Key-B 3042/3052 slot;
- eDP/LVDS;
- PCIe riser cards;
- SPDIF.
There is no schematic/boardview, reverse engineering only.
This port is based on system76/bonw14 because it has a similar topology.
[1] https://web.archive.org/web/20220924171403/https://www.asrockind.com/en-gb/IMB-1222
[2] XutaxKamay's me_cleaner fork,
https://github.com/XutaxKamay/me_cleaner, v1.2-9-gf20532d
[3] MrChromebox's edk2 fork, https://github.com/mrchromebox/edk2
uefipayload_2408 branch
Change-Id: Id2b4c903546f9174b5e7dd26e54a0c5aaa09e1f8
Signed-off-by: Maxim Polyakov <max.senia.poliak(a)gmail.com>
---
A Documentation/mainboard/asrock/imb-1222.md
M Documentation/mainboard/index.md
A src/mainboard/asrock/imb-1222/Kconfig
A src/mainboard/asrock/imb-1222/Kconfig.name
A src/mainboard/asrock/imb-1222/Makefile.mk
A src/mainboard/asrock/imb-1222/acpi/mainboard.asl
A src/mainboard/asrock/imb-1222/acpi/sleep.asl
A src/mainboard/asrock/imb-1222/beep.c
A src/mainboard/asrock/imb-1222/board_info.txt
A src/mainboard/asrock/imb-1222/bootblock.c
A src/mainboard/asrock/imb-1222/cmos.default
A src/mainboard/asrock/imb-1222/cmos.layout
A src/mainboard/asrock/imb-1222/data.vbt
A src/mainboard/asrock/imb-1222/devicetree.cb
A src/mainboard/asrock/imb-1222/dsdt.asl
A src/mainboard/asrock/imb-1222/gma-mainboard.ads
A src/mainboard/asrock/imb-1222/gpio.c
A src/mainboard/asrock/imb-1222/hda_verb.c
A src/mainboard/asrock/imb-1222/include/mainboard/beep.h
A src/mainboard/asrock/imb-1222/include/mainboard/gpio.h
A src/mainboard/asrock/imb-1222/include/mainboard/superio.h
A src/mainboard/asrock/imb-1222/panic.c
A src/mainboard/asrock/imb-1222/ramstage.c
A src/mainboard/asrock/imb-1222/romstage.c
A src/mainboard/asrock/imb-1222/superio.c
25 files changed, 1,413 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/07/83107/27
--
To view, visit https://review.coreboot.org/c/coreboot/+/83107?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Id2b4c903546f9174b5e7dd26e54a0c5aaa09e1f8
Gerrit-Change-Number: 83107
Gerrit-PatchSet: 27
Gerrit-Owner: Maxim <max.senia.poliak(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Attention is currently required from: Kapil Porwal, Nick Vaccaro, Sean Rhodes, Subrata Banik.
Hello Dinesh Gehlot, Kapil Porwal, Nick Vaccaro, Subrata Banik, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/81906?usp=email
to look at the new patch set (#9).
Change subject: soc/intel/alderlake: Hook up PCI Power Management to option API
......................................................................
soc/intel/alderlake: Hook up PCI Power Management to option API
Hook up PCICLK_PM, PCIEXP_ASPM and PCIEXP_L1_SUBSTATE to the
option API.
Change-Id: I2b06a7c734a4fd4073e86c668742ee35e1d79956
Signed-off-by: Sean Rhodes <sean(a)starlabs.systems>
---
M src/soc/intel/alderlake/fsp_params.c
1 file changed, 14 insertions(+), 8 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/06/81906/9
--
To view, visit https://review.coreboot.org/c/coreboot/+/81906?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I2b06a7c734a4fd4073e86c668742ee35e1d79956
Gerrit-Change-Number: 81906
Gerrit-PatchSet: 9
Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org>
Sean Rhodes has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/77128?usp=email )
Change subject: soc/intel/apollolake: Remove conflicting C1e settings
......................................................................
Abandoned
--
To view, visit https://review.coreboot.org/c/coreboot/+/77128?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: abandon
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I2345a4cb4610e7d731a986e929db7490c8878885
Gerrit-Change-Number: 77128
Gerrit-PatchSet: 1
Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz>
Sean Rhodes has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/83265?usp=email )
Change subject: soc/intel/common: Add fpt_support to override CSME and HECI disables
......................................................................
Abandoned
--
To view, visit https://review.coreboot.org/c/coreboot/+/83265?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: abandon
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I695fa96c5057303730492139904dfcc1d989880b
Gerrit-Change-Number: 83265
Gerrit-PatchSet: 5
Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>