Attention is currently required from: Knox Chiou, Paul Menzel, Xinxiong Xu, Yang Wu, Yu-Ping Wu.
Yidi Lin has posted comments on this change by Yang Wu. ( https://review.coreboot.org/c/coreboot/+/84342?usp=email )
Change subject: mb/google/corsola: Distinguish MT8186T's SKU ID from MT8186
......................................................................
Patch Set 10: Code-Review+1
--
To view, visit https://review.coreboot.org/c/coreboot/+/84342?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I91306d3abd508e104851916882fb36a4fd302036
Gerrit-Change-Number: 84342
Gerrit-PatchSet: 10
Gerrit-Owner: Yang Wu <wuyang5(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Knox Chiou <knoxchiou(a)google.com>
Gerrit-Reviewer: Xinxiong Xu <xuxinxiong(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Knox Chiou <knoxchiou(a)google.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Xinxiong Xu <xuxinxiong(a)huaqin.corp-partner.google.com>
Gerrit-Attention: Yang Wu <wuyang5(a)huaqin.corp-partner.google.com>
Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Comment-Date: Thu, 19 Sep 2024 06:07:14 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: Knox Chiou, Paul Menzel, Xinxiong Xu, Yang Wu, Yidi Lin, Yu-Ping Wu.
Hello Hung-Te Lin, Knox Chiou, Xinxiong Xu, Yidi Lin, Yu-Ping Wu, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/84342?usp=email
to look at the new patch set (#10).
Change subject: mb/google/corsola: Distinguish MT8186T's SKU ID from MT8186
......................................................................
mb/google/corsola: Distinguish MT8186T's SKU ID from MT8186
For MT8186, factory pre-flashed 0x7fffffff as unprovisioned SKU ID and
kernel can use the corresponding DTS file. To make MT8186T functional on
unprovisioned devices, change the SKU ID to 0x7ffffeff, so that the correct
dts file will be selected by the payload.
BUG=b:365730137
TEST=1. Pre-flashed 0x7fffffff and boot OS.
2. Check OS boot normally by 0x7ffffeff.
BRANCH=corsola
Change-Id: I91306d3abd508e104851916882fb36a4fd302036
Signed-off-by: Yang Wu <wuyang5(a)huaqin.corp-partner.google.com>
---
M src/mainboard/google/corsola/boardid.c
1 file changed, 13 insertions(+), 11 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/42/84342/10
--
To view, visit https://review.coreboot.org/c/coreboot/+/84342?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I91306d3abd508e104851916882fb36a4fd302036
Gerrit-Change-Number: 84342
Gerrit-PatchSet: 10
Gerrit-Owner: Yang Wu <wuyang5(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Knox Chiou <knoxchiou(a)google.com>
Gerrit-Reviewer: Xinxiong Xu <xuxinxiong(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Knox Chiou <knoxchiou(a)google.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Xinxiong Xu <xuxinxiong(a)huaqin.corp-partner.google.com>
Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Attention: Yang Wu <wuyang5(a)huaqin.corp-partner.google.com>
Gerrit-Attention: Yidi Lin <yidilin(a)google.com>
Attention is currently required from: Knox Chiou, Paul Menzel, Xinxiong Xu, Yang Wu, Yidi Lin, Yu-Ping Wu.
Hello Hung-Te Lin, Knox Chiou, Xinxiong Xu, Yidi Lin, Yu-Ping Wu, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/84342?usp=email
to look at the new patch set (#9).
The following approvals got outdated and were removed:
Verified+1 by build bot (Jenkins)
Change subject: mb/google/corsola: Distinguish MT8186T's SKU ID from MT8186
......................................................................
mb/google/corsola: Distinguish MT8186T's SKU ID from MT8186
For MT8186, factory pre-flashed 0x7fffffff as unprovisioned SKU ID and
kernel can use the corresponding DTS file. To make MT8186T functional on
unprovisioned devices, change the SKU ID to 0x7ffffeff, so that the correct
dts file will be selected by the payload.
BUG=b:365730137
TEST=1. Pre-flashed 0x7fffffff and boot OS.
2. Check OS boot normally by 0x7ffffeff.
BRANCH=corsola
Change-Id: I91306d3abd508e104851916882fb36a4fd302036
Signed-off-by: Yang Wu <wuyang5(a)huaqin.corp-partner.google.com>
---
M src/mainboard/google/corsola/boardid.c
1 file changed, 14 insertions(+), 12 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/42/84342/9
--
To view, visit https://review.coreboot.org/c/coreboot/+/84342?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I91306d3abd508e104851916882fb36a4fd302036
Gerrit-Change-Number: 84342
Gerrit-PatchSet: 9
Gerrit-Owner: Yang Wu <wuyang5(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Knox Chiou <knoxchiou(a)google.com>
Gerrit-Reviewer: Xinxiong Xu <xuxinxiong(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Knox Chiou <knoxchiou(a)google.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Xinxiong Xu <xuxinxiong(a)huaqin.corp-partner.google.com>
Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Attention: Yang Wu <wuyang5(a)huaqin.corp-partner.google.com>
Gerrit-Attention: Yidi Lin <yidilin(a)google.com>
Attention is currently required from: Karthik Ramasubramanian, Kenneth Chan.
Ren Kuo has posted comments on this change by Ren Kuo. ( https://review.coreboot.org/c/coreboot/+/84413?usp=email )
Change subject: mb/google/brox/jubilant: Modify start-up timing for WWAN RW101R-GL
......................................................................
Patch Set 2:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/84413/comment/51d30454_6c070f77?us… :
PS1, Line 10: PWR_EN
: FCPO#
: RESET#
> Are there any delays required between each signal?
Yes.the WWAN module datasheet is in the b:349698817
PWR_EN H H
FCPO# H H
RESET# L 20ms H
The PWR_EN and FCPO# from low to high in the same time and then have a 20ms delay
to set RESET# from low to high
--
To view, visit https://review.coreboot.org/c/coreboot/+/84413?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I7aa3e7a172143ff1cebea7f48bda45d4fb2c77f7
Gerrit-Change-Number: 84413
Gerrit-PatchSet: 2
Gerrit-Owner: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Kenneth Chan <kenneth.chan(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Kenneth Chan <kenneth.chan(a)quanta.corp-partner.google.com>
Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Comment-Date: Thu, 19 Sep 2024 05:22:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Karthik Ramasubramanian <kramasub(a)google.com>
Attention is currently required from: Kenneth Chan, Ren Kuo.
Hello Karthik Ramasubramanian, Kenneth Chan, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/84413?usp=email
to look at the new patch set (#2).
The following approvals got outdated and were removed:
Verified+1 by build bot (Jenkins)
Change subject: mb/google/brox/jubilant: Modify start-up timing for WWAN RW101R-GL
......................................................................
mb/google/brox/jubilant: Modify start-up timing for WWAN RW101R-GL
Modify start-up timing for WWAN RW101R-GL to follow spec:
PWR_EN
FCPO#
RESET#
BUG=b:349698817
BRANCH=None
TEST= Build firmware and verify on jubilant within RW101R-GL
Measure the start-up timing sequence
Check the LTE modem connection on OS
Change-Id: I7aa3e7a172143ff1cebea7f48bda45d4fb2c77f7
Signed-off-by: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com>
---
M src/mainboard/google/brox/variants/jubilant/gpio.c
1 file changed, 19 insertions(+), 7 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/13/84413/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/84413?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I7aa3e7a172143ff1cebea7f48bda45d4fb2c77f7
Gerrit-Change-Number: 84413
Gerrit-PatchSet: 2
Gerrit-Owner: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Kenneth Chan <kenneth.chan(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com>
Gerrit-Attention: Kenneth Chan <kenneth.chan(a)quanta.corp-partner.google.com>
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/84414?usp=email
to look at the new patch set (#2).
The following approvals got outdated and were removed:
Verified+1 by build bot (Jenkins)
Change subject: mb/google: Correct number of jacks in hda_verb.c
......................................................................
mb/google: Correct number of jacks in hda_verb.c
This was found due to the `_Static_assert()` from CB:84360 failing.
Change-Id: Id377281af310642a6ba77e5a0002ca1dfca38827
Signed-off-by: Nicholas Sudsgaard <devel+coreboot(a)nsudsgaard.com>
---
M src/mainboard/google/beltino/variants/monroe/hda_verb.c
M src/mainboard/google/link/hda_verb.c
2 files changed, 5 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/14/84414/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/84414?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Id377281af310642a6ba77e5a0002ca1dfca38827
Gerrit-Change-Number: 84414
Gerrit-PatchSet: 2
Gerrit-Owner: Nicholas Sudsgaard <devel+coreboot(a)nsudsgaard.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Attention is currently required from: Knox Chiou, Paul Menzel, Xinxiong Xu, Yang Wu, Yidi Lin, Yu-Ping Wu.
Hung-Te Lin has posted comments on this change by Yang Wu. ( https://review.coreboot.org/c/coreboot/+/84342?usp=email )
Change subject: mb/google/corsola: Distinguish MT8186T's SKU ID from MT8186
......................................................................
Patch Set 8:
(1 comment)
File src/mainboard/google/corsola/boardid.c:
https://review.coreboot.org/c/coreboot/+/84342/comment/649c0407_8873e0fa?us… :
PS6, Line 118: if (cached_sku_code == CROS_SKU_UNPROVISIONED ||
: cached_sku_code == CROS_SKU_UNKNOWN) {
: printk(BIOS_WARNING, "SKU code from EC: 0x%x\n", cached_sku_code);
:
: if (CONFIG(BOARD_GOOGLE_STARYU_COMMON)) {
: if (get_cpu_id() == MTK_CPU_ID_MT8186T) {
: /* Reserve last 4 bits to report PANEL_ID */
: cached_sku_code = 0x7FFFFEF0UL | panel_id();
: } else {
: cached_sku_code = 0x7FFFFFF0UL | panel_id();
: }
: } else if (get_cpu_id() == MTK_CPU_ID_MT8186T &&
: !CONFIG(BOARD_GOOGLE_VOLTORB) &&
: !CONFIG(BOARD_GOOGLE_SQUIRTLE)) {
: /*
: * Distinguish MT8186T from MT8186 to select different device trees
: * in the payload. Voltorb/Squirtle are exception here, because right now
: * they use 0x7FFFFFFF in the DTS compatible string. We'll need to change
: * that to 0x7FFFFEFF in kernel before the exception can be dropped.
: */
: cached_sku_code = CROS_SKU_UNPROVISIONED_MT8186T;
: }
: }
> That also works. […]
agree.
--
To view, visit https://review.coreboot.org/c/coreboot/+/84342?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I91306d3abd508e104851916882fb36a4fd302036
Gerrit-Change-Number: 84342
Gerrit-PatchSet: 8
Gerrit-Owner: Yang Wu <wuyang5(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Knox Chiou <knoxchiou(a)google.com>
Gerrit-Reviewer: Xinxiong Xu <xuxinxiong(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Knox Chiou <knoxchiou(a)google.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Xinxiong Xu <xuxinxiong(a)huaqin.corp-partner.google.com>
Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Attention: Yang Wu <wuyang5(a)huaqin.corp-partner.google.com>
Gerrit-Attention: Yidi Lin <yidilin(a)google.com>
Gerrit-Comment-Date: Thu, 19 Sep 2024 04:04:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Hung-Te Lin <hungte(a)chromium.org>
Comment-In-Reply-To: Yu-Ping Wu <yupingso(a)google.com>
Comment-In-Reply-To: Yidi Lin <yidilin(a)google.com>
Attention is currently required from: Andrey Petrov, Dinesh Gehlot, Eran Mitrani, Jakub Czapiga, Jayvik Desai, Jérémy Compostella, Kapil Porwal, Lean Sheng Tan, Nick Vaccaro, Paul Menzel, Pranava Y N, Rishika Raj, Ronak Kanabar, Sean Rhodes, Tarun, Werner Zeh.
Subrata Banik has posted comments on this change by Jérémy Compostella. ( https://review.coreboot.org/c/coreboot/+/84356?usp=email )
Change subject: drivers/intel/fsp2_0: Simplify FSP global reset definition
......................................................................
Patch Set 11:
(1 comment)
File src/soc/intel/common/fsp_reset.c:
https://review.coreboot.org/c/coreboot/+/84356/comment/9d3d1c8a_1e276b30?us… :
PS11, Line 35: CONFIG_FSP_STATUS_GLOBAL_RESET
can we implement a wrapper here instead which can convert 32-bit FSP status into 64-bit looking at if the FSP/platform is x86_64 compatible rather we start passing index?
```
#define CONVERT_TO_64BIT(value) (CONFIG_PLATFORM_USES_FSP2_X86_32 \
? value : \
((uint64_t)(value & 0xf0000000) << 32) | (value & 0xff))
#define FSP_STATUS_WRAPPER(x) CONVERT_TO_64BIT(x)
```
```
if (status == FSP_STATUS_WRAPPER(CONFIG_FSP_STATUS_GLOBAL_RESET))
```
in this case, you don't need to change the code significantly and no need to introduce new terminology like index, reset type. what we need is a seamless translation between 32-bit and 64-bit FSP reset status. Which has been done by FSP spec as 32-bit value 0x40000003 to 64-bit value 0x4000000000000003
--
To view, visit https://review.coreboot.org/c/coreboot/+/84356?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I914f73ff06bfb801fc319b45b23d7ce4cb7a6d5f
Gerrit-Change-Number: 84356
Gerrit-PatchSet: 11
Gerrit-Owner: Jérémy Compostella <jeremy.compostella(a)intel.com>
Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com>
Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com>
Gerrit-Reviewer: Jakub Czapiga <czapiga(a)google.com>
Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Reviewer: Pranava Y N <pranavayn(a)google.com>
Gerrit-Reviewer: Rishika Raj <rishikaraj(a)google.com>
Gerrit-Reviewer: Ronak Kanabar <ronak.kanabar(a)intel.com>
Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Tarun <tstuli(a)gmail.com>
Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Rishika Raj <rishikaraj(a)google.com>
Gerrit-Attention: Eran Mitrani <mitrani(a)google.com>
Gerrit-Attention: Jakub Czapiga <czapiga(a)google.com>
Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Attention: Andrey Petrov <andrey.petrov(a)gmail.com>
Gerrit-Attention: Tarun <tstuli(a)gmail.com>
Gerrit-Attention: Jayvik Desai <jayvik(a)google.com>
Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com>
Gerrit-Attention: Ronak Kanabar <ronak.kanabar(a)intel.com>
Gerrit-Attention: Werner Zeh <werner.zeh(a)siemens.com>
Gerrit-Attention: Pranava Y N <pranavayn(a)google.com>
Gerrit-Comment-Date: Thu, 19 Sep 2024 03:19:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No