coreboot-gerrit September 2024

coreboot-gerrit@coreboot.org

1 participants
1952 discussions

[L] Change in coreboot[main]: mb/google/fatcat: Add GPIO settings
by Cliff Huang (Code Review) 18 Sep '24

18 Sep '24

Attention is currently required from: Jérémy Compostella, Pranava Y N, Subrata Banik. Cliff Huang has posted comments on this change by Jérémy Compostella. ( https://review.coreboot.org/c/coreboot/+/84405?usp=email ) Change subject: mb/google/fatcat: Add GPIO settings ...................................................................... Patch Set 1: (2 comments) File src/mainboard/google/fatcat/variants/fatcat/gpio.c: https://review.coreboot.org/c/coreboot/+/84405/comment/ec410856_b6e05109?us… : PS1, Line 10: /* GPP_A */ > remove such comments from this file. […] Those GPP group comments are generated from the script. https://review.coreboot.org/c/coreboot/+/84405/comment/6964670d_f3eb4f47?us… : PS1, Line 427: /* GPP_A08: X1_PCIE_SLOT_PWR_EN */ : PAD_CFG_GPO(GPP_A08, 0, PLTRST), : > why we are enabling x1 power port here w/o probing the FW config ? Subrata, we don't use fw_config in early and romstage for our PTL and SoCs in the past. Jemery and I was trying to make the changes and we ran into several issues. There are some common code area that needs time to make it clean as well, as well Can we add a TODO list for using early stage fw_config and we can create a proper separate common code change and MB CLs later on? -- To view, visit https://review.coreboot.org/c/coreboot/+/84405?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I914f73ff06bfb801fc319b45b23d7ce4cb7a6d52 Gerrit-Change-Number: 84405 Gerrit-PatchSet: 1 Gerrit-Owner: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Pranava Y N <pranavayn(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Attention: Pranava Y N <pranavayn(a)google.com> Gerrit-Comment-Date: Wed, 18 Sep 2024 18:49:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com>

1 0

[XS] Change in coreboot[main]: mb/google/dedede: Select INTEL_CRASHLOG only for ChromeOS builds
by Subrata Banik (Code Review) 18 Sep '24

18 Sep '24

Attention is currently required from: Balaji Manigandan, Jakub Czapiga, Jędrzej Ciupis, Matt DeVillier, Pratikkumar V Prajapati, Sowmya Aralguppe. Subrata Banik has posted comments on this change by Matt DeVillier. ( https://review.coreboot.org/c/coreboot/+/84359?usp=email ) Change subject: mb/google/dedede: Select INTEL_CRASHLOG only for ChromeOS builds ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: > I will look into this and get back to you asap Thanks @sowmya.aralguppe@intel.com -- To view, visit https://review.coreboot.org/c/coreboot/+/84359?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I53be4befe9a04bdaece21f40f93af6599baa7e0b Gerrit-Change-Number: 84359 Gerrit-PatchSet: 2 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Balaji Manigandan <balaji.bmg(a)gmail.com> Gerrit-Reviewer: Jakub Czapiga <czapiga(a)google.com> Gerrit-Reviewer: Jędrzej Ciupis <jciupis(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Pratikkumar V Prajapati <pratikkumar.v.prajapati(a)intel.com> Gerrit-Reviewer: Sowmya Aralguppe <sowmya.aralguppe(a)intel.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Sowmya Aralguppe <sowmya.aralguppe(a)intel.com> Gerrit-Attention: Jędrzej Ciupis <jciupis(a)google.com> Gerrit-Attention: Jakub Czapiga <czapiga(a)google.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Attention: Balaji Manigandan <balaji.bmg(a)gmail.com> Gerrit-Attention: Pratikkumar V Prajapati <pratikkumar.v.prajapati(a)intel.com> Gerrit-Comment-Date: Wed, 18 Sep 2024 17:52:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Sowmya Aralguppe <sowmya.aralguppe(a)intel.com> Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com>

1 0

[XS] Change in coreboot[main]: mb/google/dedede: Select INTEL_CRASHLOG only for ChromeOS builds
by Sowmya Aralguppe (Code Review) 18 Sep '24

18 Sep '24

Attention is currently required from: Balaji Manigandan, Jakub Czapiga, Jędrzej Ciupis, Matt DeVillier, Pratikkumar V Prajapati, Subrata Banik. Sowmya Aralguppe has posted comments on this change by Matt DeVillier. ( https://review.coreboot.org/c/coreboot/+/84359?usp=email ) Change subject: mb/google/dedede: Select INTEL_CRASHLOG only for ChromeOS builds ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: > Hello Intel Team, […] I will look into this and get back to you asap -- To view, visit https://review.coreboot.org/c/coreboot/+/84359?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I53be4befe9a04bdaece21f40f93af6599baa7e0b Gerrit-Change-Number: 84359 Gerrit-PatchSet: 2 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Balaji Manigandan <balaji.bmg(a)gmail.com> Gerrit-Reviewer: Jakub Czapiga <czapiga(a)google.com> Gerrit-Reviewer: Jędrzej Ciupis <jciupis(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Pratikkumar V Prajapati <pratikkumar.v.prajapati(a)intel.com> Gerrit-Reviewer: Sowmya Aralguppe <sowmya.aralguppe(a)intel.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jędrzej Ciupis <jciupis(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Jakub Czapiga <czapiga(a)google.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Attention: Balaji Manigandan <balaji.bmg(a)gmail.com> Gerrit-Attention: Pratikkumar V Prajapati <pratikkumar.v.prajapati(a)intel.com> Gerrit-Comment-Date: Wed, 18 Sep 2024 17:47:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com>

1 0

[M] Change in coreboot[main]: mb/google/brox: Remove psys related implementation
by Sowmya Aralguppe (Code Review) 18 Sep '24

18 Sep '24

Attention is currently required from: Paul Menzel. Sowmya Aralguppe has posted comments on this change by Sowmya Aralguppe. ( https://review.coreboot.org/c/coreboot/+/84397?usp=email ) Change subject: mb/google/brox: Remove psys related implementation ...................................................................... Patch Set 8: (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/84397/comment/68a497ab_81e83ddc?us… : PS5, Line 9: PSys is not an optimal solution for no/low battery boot.Hence remove > I have mentioned the bug id where the problems are discussed in detail (in #58) Done https://review.coreboot.org/c/coreboot/+/84397/comment/90a3c9ca_48818d95?us… : PS5, Line 14: TEST=Build and boot on brox board > please refer to comment 64 and 65 in the bug Done -- To view, visit https://review.coreboot.org/c/coreboot/+/84397?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I6c0e9561367b5846b00be27012f002dd7c299414 Gerrit-Change-Number: 84397 Gerrit-PatchSet: 8 Gerrit-Owner: Sowmya Aralguppe <sowmya.aralguppe(a)intel.com> Gerrit-Reviewer: Ashish Kumar Mishra <ashish.k.mishra(a)intel.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Wed, 18 Sep 2024 17:15:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Sowmya Aralguppe <sowmya.aralguppe(a)intel.com> Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>

1 0

[M] Change in coreboot[main]: mb/google/brox: Remove psys related implementation
by Sowmya Aralguppe (Code Review) 18 Sep '24

18 Sep '24

Attention is currently required from: Paul Menzel. Sowmya Aralguppe has posted comments on this change by Sowmya Aralguppe. ( https://review.coreboot.org/c/coreboot/+/84397?usp=email ) Change subject: mb/google/brox: Remove psys related implementation ...................................................................... Patch Set 8: (5 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/84397/comment/a57284bf_27345dac?us… : PS5, Line 7: PSys > The code comments spell it Psys? Done https://review.coreboot.org/c/coreboot/+/84397/comment/09fd71a1_9aa71422?us… : PS5, Line 7: Platform(PSys) > Please add a space before the (. […] Done https://review.coreboot.org/c/coreboot/+/84397/comment/ae3adf32_97ab6127?us… : PS5, Line 9: boot.Hence > Please add a space after the dot/period. Done https://review.coreboot.org/c/coreboot/+/84397/comment/2f1efd27_66d6a0ba?us… : PS5, Line 9: PSys is not an optimal solution for no/low battery boot.Hence remove > Why? What problems are there? I have mentioned the bug id where the problems are discussed in detail (in #58) https://review.coreboot.org/c/coreboot/+/84397/comment/39dc52b0_393f82ea?us… : PS5, Line 14: TEST=Build and boot on brox board > How can it be checked, that the situation is better now? please refer to comment 64 and 65 in the bug -- To view, visit https://review.coreboot.org/c/coreboot/+/84397?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I6c0e9561367b5846b00be27012f002dd7c299414 Gerrit-Change-Number: 84397 Gerrit-PatchSet: 8 Gerrit-Owner: Sowmya Aralguppe <sowmya.aralguppe(a)intel.com> Gerrit-Reviewer: Ashish Kumar Mishra <ashish.k.mishra(a)intel.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Wed, 18 Sep 2024 17:15:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>

1 0

[M] Change in coreboot[main]: mb/google/brox: Remove psys related implementation
by Sowmya Aralguppe (Code Review) 18 Sep '24

18 Sep '24

Attention is currently required from: Sowmya Aralguppe. Hello Ashish Kumar Mishra, Karthik Ramasubramanian, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/84397?usp=email to look at the new patch set (#8). Change subject: mb/google/brox: Remove psys related implementation ...................................................................... mb/google/brox: Remove psys related implementation psys is not an optimal solution for no/low battery boot. Hence remove function and macros related to psys implementation. BUG=b:335046538 BRANCH=None TEST=Build and boot on brox board Change-Id: I6c0e9561367b5846b00be27012f002dd7c299414 Signed-off-by: Sowmya Aralguppe <sowmya.aralguppe(a)intel.com> --- M src/mainboard/google/brox/variants/baseboard/brox/ramstage.c M src/mainboard/google/brox/variants/baseboard/include/baseboard/variants.h 2 files changed, 0 insertions(+), 107 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/97/84397/8 -- To view, visit https://review.coreboot.org/c/coreboot/+/84397?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I6c0e9561367b5846b00be27012f002dd7c299414 Gerrit-Change-Number: 84397 Gerrit-PatchSet: 8 Gerrit-Owner: Sowmya Aralguppe <sowmya.aralguppe(a)intel.com> Gerrit-Reviewer: Ashish Kumar Mishra <ashish.k.mishra(a)intel.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Sowmya Aralguppe <sowmya.aralguppe(a)intel.com>

1 0

[M] Change in coreboot[main]: mb/google/brox: Remove Platform(psys) related implementation
by Sowmya Aralguppe (Code Review) 18 Sep '24

18 Sep '24

Attention is currently required from: Sowmya Aralguppe. Hello Ashish Kumar Mishra, Karthik Ramasubramanian, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/84397?usp=email to look at the new patch set (#7). Change subject: mb/google/brox: Remove Platform(psys) related implementation ...................................................................... mb/google/brox: Remove Platform(psys) related implementation psys is not an optimal solution for no/low battery boot. Hence remove function and macros related to psys implementation. BUG=b:335046538 BRANCH=None TEST=Build and boot on brox board Change-Id: I6c0e9561367b5846b00be27012f002dd7c299414 Signed-off-by: Sowmya Aralguppe <sowmya.aralguppe(a)intel.com> --- M src/mainboard/google/brox/variants/baseboard/brox/ramstage.c M src/mainboard/google/brox/variants/baseboard/include/baseboard/variants.h 2 files changed, 0 insertions(+), 107 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/97/84397/7 -- To view, visit https://review.coreboot.org/c/coreboot/+/84397?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I6c0e9561367b5846b00be27012f002dd7c299414 Gerrit-Change-Number: 84397 Gerrit-PatchSet: 7 Gerrit-Owner: Sowmya Aralguppe <sowmya.aralguppe(a)intel.com> Gerrit-Reviewer: Ashish Kumar Mishra <ashish.k.mishra(a)intel.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Sowmya Aralguppe <sowmya.aralguppe(a)intel.com>

1 0

[XS] Change in coreboot[main]: xcompile: Disable unterminated-string-initialization warning
by Elyes Haouas (Code Review) 18 Sep '24

18 Sep '24

Attention is currently required from: Martin L Roth. Elyes Haouas has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/84417?usp=email ) Change subject: xcompile: Disable unterminated-string-initialization warning ...................................................................... xcompile: Disable unterminated-string-initialization warning Change-Id: Icca87e333daf240b8dbc23c71863500294a37e74 Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> --- M util/xcompile/xcompile 1 file changed, 3 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/17/84417/1 diff --git a/util/xcompile/xcompile b/util/xcompile/xcompile index 13ed48b..33ae004 100755 --- a/util/xcompile/xcompile +++ b/util/xcompile/xcompile @@ -238,6 +238,9 @@ testcc "$GCC" "$CFLAGS_GCC -Wno-cast-function-type" && CFLAGS_GCC="$CFLAGS_GCC -Wno-cast-function-type" + testcc "$GCC" "$CFLAGS_GCC -Wno-unterminated-string-initialization" && + CFLAGS_GCC="$CFLAGS_GCC -Wno-nterminated-string-initialization" + testcc "$GCC" "$CFLAGS_GCC -Wextra" && CFLAGS_GCC="$CFLAGS_GCC -Wextra" -- To view, visit https://review.coreboot.org/c/coreboot/+/84417?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Icca87e333daf240b8dbc23c71863500294a37e74 Gerrit-Change-Number: 84417 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>

1 0

[XS] Change in coreboot[main]: [for test] test upgrade crossgcc
by Elyes Haouas (Code Review) 18 Sep '24

18 Sep '24

Attention is currently required from: Martin L Roth. Hello Martin L Roth, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/81419?usp=email to look at the new patch set (#32). Change subject: [for test] test upgrade crossgcc ...................................................................... [for test] test upgrade crossgcc Change-Id: I463c303694c304bb3bf664bc1d914462e7af5dbb Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> --- M util/crossgcc/buildgcc R util/crossgcc/patches/gcc-15-20240915_asan_shadow_offset_callback.patch R util/crossgcc/patches/gcc-15-20240915_gnat.patch R util/crossgcc/patches/gcc-15-20240915_libcpp.patch R util/crossgcc/patches/gcc-15-20240915_libgcc.patch R util/crossgcc/patches/gcc-15-20240915_musl_poisoned_calloc.patch R util/crossgcc/patches/gcc-15-20240915_rv32iafc.patch D util/crossgcc/sum/gcc-14.2.0.tar.xz.cksum A util/crossgcc/sum/gcc-15-20240915.tar.xz.cksum 9 files changed, 4 insertions(+), 4 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/19/81419/32 -- To view, visit https://review.coreboot.org/c/coreboot/+/81419?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I463c303694c304bb3bf664bc1d914462e7af5dbb Gerrit-Change-Number: 81419 Gerrit-PatchSet: 32 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>

1 0

[XS] Change in coreboot[main]: commonlib/loglevel.h: Fix Wunterminated-string-initialization error
by Elyes Haouas (Code Review) 18 Sep '24

18 Sep '24

Elyes Haouas has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/84171?usp=email ) Change subject: commonlib/loglevel.h: Fix Wunterminated-string-initialization error ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/c/coreboot/+/84171?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: abandon Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I6b149239cf301aa00b2c1ee8ff811492590a07f9 Gerrit-Change-Number: 84171 Gerrit-PatchSet: 4 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

← Newer
1
2
3
4
5
6
7
...
196
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit September 2024