coreboot-gerrit September 2024

coreboot-gerrit@coreboot.org

1 participants
3343 discussions

[M] Change in coreboot[main]: acpi: Add IORT helper functions
by Naresh Solanki (Code Review) 30 Sep '24

30 Sep '24

Attention is currently required from: Angel Pons, Arthur Heymans, Cliff Huang, Felix Held, Felix Singer, Lance Zhao, Naresh Solanki, Patrick Rudolph, Tim Wawrzynczak. Hello Angel Pons, Arthur Heymans, Cliff Huang, Felix Held, Lance Zhao, Patrick Rudolph, Tim Wawrzynczak, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/79404?usp=email to look at the new patch set (#8). The following approvals got outdated and were removed: Verified-1 by build bot (Jenkins) Change subject: acpi: Add IORT helper functions ...................................................................... acpi: Add IORT helper functions IORT table represents IO topology of an Arm based system for use with the Advanced Configuration and Power Interface (ACPI) Add helper functions for ACPI IORT table for: 1. ITS(Interrupt Translation Service) 2. SMMUV3 3. ID MAP 4. Named Component 5. Root Complex Based on document: DEN0049E_IO_Remapping_Table_E.e Change-Id: I7feaf306b5eea21bfc9a2e2a1a2c3ddc3c683c0b Signed-off-by: Naresh Solanki <naresh.solanki(a)9elements.com> --- M src/acpi/Makefile.mk A src/acpi/acpi_iort.c M src/include/acpi/acpi_iort.h 3 files changed, 179 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/04/79404/8 -- To view, visit https://review.coreboot.org/c/coreboot/+/79404?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I7feaf306b5eea21bfc9a2e2a1a2c3ddc3c683c0b Gerrit-Change-Number: 79404 Gerrit-PatchSet: 8 Gerrit-Owner: Naresh Solanki <naresh.solanki(a)9elements.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-CC: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Attention: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Naresh Solanki <naresh.solanki(a)9elements.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>

1 0

[S] Change in coreboot[main]: util/lint: Use bigint for hexadecimal values in handle_range
by Karthik Ramasubramanian (Code Review) 30 Sep '24

30 Sep '24

Attention is currently required from: Felix Held, Jérémy Compostella, Martin L Roth, Paul Menzel, Subrata Banik. Karthik Ramasubramanian has posted comments on this change by Subrata Banik. ( https://review.coreboot.org/c/coreboot/+/84575?usp=email ) Change subject: util/lint: Use bigint for hexadecimal values in handle_range ...................................................................... Patch Set 5: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/84575?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I402bb9bec9ba5bfb79b4185f35228c41d4a7b674 Gerrit-Change-Number: 84575 Gerrit-PatchSet: 5 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Mon, 30 Sep 2024 18:58:24 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in coreboot[main]: soc/intel: Deprecate SoC-specific global reset status configs
by Christian Walter (Code Review) 30 Sep '24

30 Sep '24

Attention is currently required from: Andrey Petrov, David Hendricks, Dinesh Gehlot, Eran Mitrani, Jakub Czapiga, Jayvik Desai, Kapil Porwal, Lean Sheng Tan, Nick Vaccaro, Nico Huber, Pranava Y N, Ronak Kanabar, Sean Rhodes, Subrata Banik, Tarun, Werner Zeh. Christian Walter has posted comments on this change by Subrata Banik. ( https://review.coreboot.org/c/coreboot/+/84572?usp=email ) Change subject: soc/intel: Deprecate SoC-specific global reset status configs ...................................................................... Patch Set 9: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/84572?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I32bdbf7ea6afa7d5e5f91ea96d887719d26a593f Gerrit-Change-Number: 84572 Gerrit-PatchSet: 9 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Jakub Czapiga <czapiga(a)google.com> Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Pranava Y N <pranavayn(a)google.com> Gerrit-Reviewer: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Tarun <tstuli(a)gmail.com> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Attention: Eran Mitrani <mitrani(a)google.com> Gerrit-Attention: Jakub Czapiga <czapiga(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Attention: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Attention: Tarun <tstuli(a)gmail.com> Gerrit-Attention: Jayvik Desai <jayvik(a)google.com> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Attention: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Attention: Pranava Y N <pranavayn(a)google.com> Gerrit-Comment-Date: Mon, 30 Sep 2024 18:53:00 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in coreboot[main]: util/lint: Use bigint for hexadecimal values in handle_range
by Christian Walter (Code Review) 30 Sep '24

30 Sep '24

Attention is currently required from: Felix Held, Jérémy Compostella, Karthik Ramasubramanian, Martin L Roth, Paul Menzel, Subrata Banik. Christian Walter has posted comments on this change by Subrata Banik. ( https://review.coreboot.org/c/coreboot/+/84575?usp=email ) Change subject: util/lint: Use bigint for hexadecimal values in handle_range ...................................................................... Patch Set 5: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/84575?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I402bb9bec9ba5bfb79b4185f35228c41d4a7b674 Gerrit-Change-Number: 84575 Gerrit-PatchSet: 5 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Mon, 30 Sep 2024 18:47:33 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in coreboot[main]: util/lint: Use bigint for hexadecimal values in handle_range
by Subrata Banik (Code Review) 30 Sep '24

30 Sep '24

Attention is currently required from: Felix Held, Jérémy Compostella, Karthik Ramasubramanian, Martin L Roth, Paul Menzel. Subrata Banik has posted comments on this change by Subrata Banik. ( https://review.coreboot.org/c/coreboot/+/84575?usp=email ) Change subject: util/lint: Use bigint for hexadecimal values in handle_range ...................................................................... Patch Set 5: (1 comment) File util/lint/kconfig_lint: https://review.coreboot.org/c/coreboot/+/84575/comment/6b99609a_06728a7b?us… : PS4, Line 871: Use bigint for large hexadecimal values > > nit: I believe this is redundant and maybe not even necessary to mention it actually. > > let me remove it. > > > > > More importantly, shouldn't it make sense to also add support for default values ? > > 64-bit support for `default` value already existed hence, it's working over Rex64 w/o any problem. > > > It looks weird to me to only support large numbers for range only. > > this code changes only added to support https://review.coreboot.org/c/coreboot/+/84572/4..8/src/drivers/intel/fsp2_… where `range` is unable to handle > 32-bit value marking it resolved as I have removed the redundant comment and `use bigint` -- To view, visit https://review.coreboot.org/c/coreboot/+/84575?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I402bb9bec9ba5bfb79b4185f35228c41d4a7b674 Gerrit-Change-Number: 84575 Gerrit-PatchSet: 5 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Mon, 30 Sep 2024 18:44:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com> Comment-In-Reply-To: Jérémy Compostella <jeremy.compostella(a)intel.com>

1 0

[S] Change in coreboot[main]: util/lint: Use bigint for hexadecimal values in handle_range
by Subrata Banik (Code Review) 30 Sep '24

30 Sep '24

Attention is currently required from: Felix Held, Jérémy Compostella, Karthik Ramasubramanian, Martin L Roth, Paul Menzel. Hello Felix Held, Karthik Ramasubramanian, Martin L Roth, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/84575?usp=email to look at the new patch set (#5). The following approvals got outdated and were removed: Code-Review+2 by Karthik Ramasubramanian, Verified+1 by build bot (Jenkins) Change subject: util/lint: Use bigint for hexadecimal values in handle_range ...................................................................... util/lint: Use bigint for hexadecimal values in handle_range The `handle_range` function in `kconfig_lint` was failing to correctly handle large hexadecimal values (64-bit value) due to limitations with Perl's handling of standard integers. This commit modifies the function to use the `bigint` pragma, enabling it to handle arbitrarily large integers. This prevents issues with 64-bit hexadecimal values and ensures accurate comparisons for range validation. Change-Id: I402bb9bec9ba5bfb79b4185f35228c41d4a7b674 Signed-off-by: Subrata Banik <subratabanik(a)google.com> --- M util/lint/kconfig_lint 1 file changed, 13 insertions(+), 7 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/75/84575/5 -- To view, visit https://review.coreboot.org/c/coreboot/+/84575?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I402bb9bec9ba5bfb79b4185f35228c41d4a7b674 Gerrit-Change-Number: 84575 Gerrit-PatchSet: 5 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>

1 0

[S] Change in coreboot[main]: util/lint: Use bigint for hexadecimal values in handle_range
by Subrata Banik (Code Review) 30 Sep '24

30 Sep '24

Attention is currently required from: Felix Held, Jérémy Compostella, Martin L Roth, Paul Menzel. Subrata Banik has posted comments on this change by Subrata Banik. ( https://review.coreboot.org/c/coreboot/+/84575?usp=email ) Change subject: util/lint: Use bigint for hexadecimal values in handle_range ...................................................................... Patch Set 4: (1 comment) File util/lint/kconfig_lint: https://review.coreboot.org/c/coreboot/+/84575/comment/3e990bd1_d1da2be5?us… : PS4, Line 871: Use bigint for large hexadecimal values > nit: I believe this is redundant and maybe not even necessary to mention it actually. let me remove it. > > More importantly, shouldn't it make sense to also add support for default values ? 64-bit support for `default` value already existed hence, it's working over Rex64 w/o any problem. > It looks weird to me to only support large numbers for range only. this code changes only added to support https://review.coreboot.org/c/coreboot/+/84572/4..8/src/drivers/intel/fsp2_… where `range` is unable to handle > 32-bit value -- To view, visit https://review.coreboot.org/c/coreboot/+/84575?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I402bb9bec9ba5bfb79b4185f35228c41d4a7b674 Gerrit-Change-Number: 84575 Gerrit-PatchSet: 4 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Mon, 30 Sep 2024 18:36:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Jérémy Compostella <jeremy.compostella(a)intel.com>

1 0

[S] Change in coreboot[main]: util/lint: Use bigint for hexadecimal values in handle_range
by Jérémy Compostella (Code Review) 30 Sep '24

30 Sep '24

Attention is currently required from: Felix Held, Martin L Roth, Paul Menzel, Subrata Banik. Jérémy Compostella has posted comments on this change by Subrata Banik. ( https://review.coreboot.org/c/coreboot/+/84575?usp=email ) The change is no longer submittable: All-Comments-Resolved is unsatisfied now. Change subject: util/lint: Use bigint for hexadecimal values in handle_range ...................................................................... Patch Set 4: (1 comment) File util/lint/kconfig_lint: https://review.coreboot.org/c/coreboot/+/84575/comment/c47c4c63_eaeb0e8f?us… : PS4, Line 871: Use bigint for large hexadecimal values nit: I believe this is redundant and maybe not even necessary to mention it actually. More importantly, shouldn't it make sense to also add support for default values ? It looks weird to me to only support large numbers for range only. -- To view, visit https://review.coreboot.org/c/coreboot/+/84575?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I402bb9bec9ba5bfb79b4185f35228c41d4a7b674 Gerrit-Change-Number: 84575 Gerrit-PatchSet: 4 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Mon, 30 Sep 2024 17:54:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[S] Change in coreboot[main]: chromeec/ec_acpi: Define ACPI devices for USB-C ports using UCSI
by Felix Held (Code Review) 30 Sep '24

30 Sep '24

Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/84404?usp=email ) Change subject: chromeec/ec_acpi: Define ACPI devices for USB-C ports using UCSI ...................................................................... chromeec/ec_acpi: Define ACPI devices for USB-C ports using UCSI Add support to define ACPI devices for USB-C ports using UCSI. When defining the typec configuration do not set mux/retimer information. cros_ec_ucsi does not support setting USB muxes. BUG=b:349822718 TEST=emerge-brox coreboot chromeos-bootimage. Boot to OS on brox, confirmed that there are ACPI devices for each USB-C port and cros_ec_ucsi correctly matched the ACPI devices ("ls -l /sys/class/typec" with an update to add an ACPI match table to the cros_ec_ucsi driver). Change-Id: Ie7c281fe2a7fab705d3c238dcc4be68c93afd652 Signed-off-by: Jameson Thies <jthies(a)google.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/84404 Reviewed-by: Subrata Banik <subratabanik(a)google.com> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- M src/ec/google/chromeec/ec_acpi.c 1 file changed, 19 insertions(+), 8 deletions(-) Approvals: Subrata Banik: Looks good to me, approved build bot (Jenkins): Verified diff --git a/src/ec/google/chromeec/ec_acpi.c b/src/ec/google/chromeec/ec_acpi.c index 1c97dcc..65a425b 100644 --- a/src/ec/google/chromeec/ec_acpi.c +++ b/src/ec/google/chromeec/ec_acpi.c @@ -18,6 +18,12 @@ #define GOOGLE_CHROMEEC_USBC_DEVICE_HID "GOOG0014" #define GOOGLE_CHROMEEC_USBC_DEVICE_NAME "USBC" +/* + * Boards using UCSI need the USB-C ports to match with cros_ec_ucsi, not + * cros-ec-typec. + */ +#define GOOGLE_CHROMEEC_USBC_UCSI_DEVICE_HID "GOOG0021" + const char *google_chromeec_acpi_name(const struct device *dev) { /* @@ -157,11 +163,6 @@ struct acpi_pld pld = {0}; uint32_t pcap_mask = 0; - /* UCSI implementations do not require an ACPI device with mux info since the - linux kernel doesn't set the muxes. */ - if (google_chromeec_get_ucsi_enabled()) - return; - rv = google_chromeec_get_num_pd_ports(&num_ports); if (rv || num_ports == 0) return; @@ -173,9 +174,19 @@ acpigen_write_scope(acpi_device_path(dev)); acpigen_write_device(GOOGLE_CHROMEEC_USBC_DEVICE_NAME); - acpigen_write_name_string("_HID", GOOGLE_CHROMEEC_USBC_DEVICE_HID); - acpigen_write_name_string("_DDN", "ChromeOS EC Embedded Controller " - "USB Type-C Control"); + + bool ucsi_platform = google_chromeec_get_ucsi_enabled(); + if (ucsi_platform) { + acpigen_write_name_string("_HID", + GOOGLE_CHROMEEC_USBC_UCSI_DEVICE_HID); + acpigen_write_name_string("_DDN", "ChromeOS EC UCSI USB Type-C " + "Control"); + } else { + acpigen_write_name_string("_HID", + GOOGLE_CHROMEEC_USBC_DEVICE_HID); + acpigen_write_name_string("_DDN", "ChromeOS EC Embedded " + "Controller USB Type-C Control"); + } for (i = 0; i < num_ports; ++i) { rv = google_chromeec_get_pd_port_caps(i, &port_caps); -- To view, visit https://review.coreboot.org/c/coreboot/+/84404?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ie7c281fe2a7fab705d3c238dcc4be68c93afd652 Gerrit-Change-Number: 84404 Gerrit-PatchSet: 7 Gerrit-Owner: Jameson Thies <jthies(a)google.com> Gerrit-Reviewer: Caveh Jalali <caveh(a)chromium.org> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Forest Mittelberg <bmbm(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Abhishek Pandit-Subedi <abhishekpandit(a)google.com>

1 0

[XS] Change in coreboot[main]: device_util: Add support for GICv3 path in device path handling
by Felix Held (Code Review) 30 Sep '24

30 Sep '24

Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/79972?usp=email ) Change subject: device_util: Add support for GICv3 path in device path handling ...................................................................... device_util: Add support for GICv3 path in device path handling Change-Id: Ib4004c1f1b854a54dfdf9eaa7f25583dec947302 Signed-off-by: Naresh Solanki <naresh.solanki(a)9elements.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/79972 Reviewed-by: Angel Pons <th3fanbus(a)gmail.com> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- M src/device/device_util.c 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved diff --git a/src/device/device_util.c b/src/device/device_util.c index 3514de7..f33c925 100644 --- a/src/device/device_util.c +++ b/src/device/device_util.c @@ -230,6 +230,9 @@ case DEVICE_PATH_MDIO: snprintf(buffer, sizeof(buffer), "MDIO: %02x", dev->path.mdio.addr); break; + case DEVICE_PATH_GICC_V3: + snprintf(buffer, sizeof(buffer), "GICV3: %02x", dev->path.gicc_v3.mpidr); + break; default: printk(BIOS_ERR, "Unknown device path type: %d\n", dev->path.type); -- To view, visit https://review.coreboot.org/c/coreboot/+/79972?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ib4004c1f1b854a54dfdf9eaa7f25583dec947302 Gerrit-Change-Number: 79972 Gerrit-PatchSet: 3 Gerrit-Owner: Naresh Solanki <naresh.solanki(a)9elements.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit September 2024