Attention is currently required from: Felix Held, Felix Singer, Michał Żygowski.
Maxim has posted comments on this change by Maxim. ( https://review.coreboot.org/c/coreboot/+/83001?usp=email )
Change subject: util/superiotool: Add callback to switch chip-specific selector
......................................................................
Patch Set 8:
(1 comment)
Patchset:
PS8:
Reworked in CB:83196
--
To view, visit https://review.coreboot.org/c/coreboot/+/83001?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Icfa0554aabcefd2f681d6b0fade6dbfc1b53a232
Gerrit-Change-Number: 83001
Gerrit-PatchSet: 8
Gerrit-Owner: Maxim <max.senia.poliak(a)gmail.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Martin Roth <martin.roth(a)amd.corp-partner.google.com>
Gerrit-CC: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Comment-Date: Fri, 28 Jun 2024 11:01:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Maxim has posted comments on this change by Maxim. ( https://review.coreboot.org/c/coreboot/+/83196?usp=email )
Change subject: util/superiotool: Add extra selectors support
......................................................................
Set Ready For Review
--
To view, visit https://review.coreboot.org/c/coreboot/+/83196?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: If56af9f977381e637245bdd26563f5ba7e6cbead
Gerrit-Change-Number: 83196
Gerrit-PatchSet: 2
Gerrit-Owner: Maxim <max.senia.poliak(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Fri, 28 Jun 2024 10:59:11 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Attention is currently required from: Felix Held, Felix Singer, Maxim, Michał Żygowski.
Hello Felix Held, Felix Singer, Michał Żygowski, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/83004?usp=email
to look at the new patch set (#11).
The following approvals got outdated and were removed:
Verified+1 by build bot (Jenkins)
Change subject: util/superiotool/fintek: Add f81866 register table
......................................................................
util/superiotool/fintek: Add f81866 register table
In accordance with the F81866A datasheet:
Release Date: Jan, 2012, Version: V0.14P [1].
Should be added after CB:83196.
[1] http://www.jetwaycomputer.com/download/Fintek/F81866_wdt_gpio.zip
Change-Id: I4367a1129fe628e7bf05d49678ea1c3718da710b
Signed-off-by: Maxim Polyakov <max.senia.poliak(a)gmail.com>
---
M util/superiotool/fintek.c
1 file changed, 134 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/04/83004/11
--
To view, visit https://review.coreboot.org/c/coreboot/+/83004?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I4367a1129fe628e7bf05d49678ea1c3718da710b
Gerrit-Change-Number: 83004
Gerrit-PatchSet: 11
Gerrit-Owner: Maxim <max.senia.poliak(a)gmail.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Attention: Maxim <max.senia.poliak(a)gmail.com>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/83019?usp=email
to look at the new patch set (#9).
The following approvals got outdated and were removed:
Verified+1 by build bot (Jenkins)
Change subject: util/superiotool/fintek: Add f81966 register table
......................................................................
util/superiotool/fintek: Add f81966 register table
In accordance with the F81962/F81964/F81966/F81967 datasheet:
Release Date: Feb, 2018, Version: V0.18P [1].
Tested on Asrock IMB-1222 [2].
[1] http://www.jetwaycomputer.com/download/Fintek/F81966_wdt_gpio.zip
[2] CB:83107
Change-Id: Ic3418c337883538e47eb181cbe1ad2dc828e12a1
Signed-off-by: Maxim Polyakov <max.senia.poliak(a)gmail.com>
---
M util/superiotool/fintek.c
1 file changed, 100 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/19/83019/9
--
To view, visit https://review.coreboot.org/c/coreboot/+/83019?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ic3418c337883538e47eb181cbe1ad2dc828e12a1
Gerrit-Change-Number: 83019
Gerrit-PatchSet: 9
Gerrit-Owner: Maxim <max.senia.poliak(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Attention is currently required from: Felix Singer, Martin L Roth, Maximilian Brune.
Elyes Haouas has posted comments on this change by Felix Singer. ( https://review.coreboot.org/c/coreboot/+/83226?usp=email )
Change subject: Makefile.mk: Use one line per *_common flag
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
Patchset:
PS1:
By the paste, I've sorted CFLAGS by kind and alphabetically (https://review.coreboot.org/c/coreboot/+/72435 ).
what you think about sorting those CFLAGS ?
--
To view, visit https://review.coreboot.org/c/coreboot/+/83226?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I33c500e6eb74daf1e66c2b5e07b50f81c0f4587d
Gerrit-Change-Number: 83226
Gerrit-PatchSet: 1
Gerrit-Owner: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com>
Gerrit-Comment-Date: Fri, 28 Jun 2024 10:51:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Attention is currently required from: Dinesh Gehlot, Eran Mitrani, Jakub Czapiga, Paul Menzel, Subrata Banik, Tarun, Tim Crawford.
Michał Kopeć has posted comments on this change by Tim Crawford. ( https://review.coreboot.org/c/coreboot/+/82731?usp=email )
Change subject: soc/intel/mtl: Set HDA subsystem ID during FSP-M
......................................................................
Patch Set 4: Code-Review+1
(1 comment)
Patchset:
PS4:
I also needed this on Clevo V540TU w/ FSP 4122.14
--
To view, visit https://review.coreboot.org/c/coreboot/+/82731?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I5e668747d99b955b0a3946524c5918d328b8e1d3
Gerrit-Change-Number: 82731
Gerrit-PatchSet: 4
Gerrit-Owner: Tim Crawford <tcrawford(a)system76.com>
Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com>
Gerrit-Reviewer: Jakub Czapiga <czapiga(a)google.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Michał Kopeć <michal.kopec(a)3mdeb.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Tarun <tstuli(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Tim Crawford <tcrawford(a)system76.com>
Gerrit-Attention: Eran Mitrani <mitrani(a)google.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Jakub Czapiga <czapiga(a)google.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Attention: Tarun <tstuli(a)gmail.com>
Gerrit-Comment-Date: Fri, 28 Jun 2024 10:41:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Poornima Tom has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/82172?usp=email )
Change subject: mb/google/brya/var/nivviks: Support for discrete/integrated wifi module
......................................................................
Abandoned
Abandonig this Cl, as all relevant CB Cls for wifi7/6 are anabled & merged. Base CL in that relation list - https://review.coreboot.org/c/coreboot/+/83138
--
To view, visit https://review.coreboot.org/c/coreboot/+/82172?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: abandon
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ibea9688714a53440e5ac3a57505ed7c8f9cd4250
Gerrit-Change-Number: 82172
Gerrit-PatchSet: 2
Gerrit-Owner: Poornima Tom <poornima.tom(a)intel.com>
Gerrit-Reviewer: Sowmya V <v.sowmya(a)intel.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Hello Alexander Couzens, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/69066?usp=email
to look at the new patch set (#6).
The following approvals got outdated and were removed:
Verified+1 by build bot (Jenkins)
Change subject: mb/*/*/irq_tables.c: Use PCI_DEVFN(dev, fn)
......................................................................
mb/*/*/irq_tables.c: Use PCI_DEVFN(dev, fn)
Change-Id: Ic97bf7c8f04edbb56f200c34060d22a8c5fb7ec2
Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr>
---
M src/mainboard/asus/p2b/variants/p2b-d/irq_tables.c
M src/mainboard/asus/p2b/variants/p2b-ds/irq_tables.c
M src/mainboard/asus/p2b/variants/p2b-f/irq_tables.c
M src/mainboard/asus/p2b/variants/p2b-ls/irq_tables.c
M src/mainboard/asus/p2b/variants/p2b/irq_tables.c
M src/mainboard/asus/p2b/variants/p3b-f/irq_tables.c
M src/mainboard/emulation/qemu-i440fx/irq_tables.c
M src/mainboard/getac/p470/irq_tables.c
M src/mainboard/ibase/mb899/irq_tables.c
M src/mainboard/intel/d945gclf/irq_tables.c
M src/mainboard/kontron/986lcd-m/irq_tables.c
M src/mainboard/lenovo/x60/irq_tables.c
M src/mainboard/roda/rk886ex/irq_tables.c
13 files changed, 191 insertions(+), 178 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/66/69066/6
--
To view, visit https://review.coreboot.org/c/coreboot/+/69066?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ic97bf7c8f04edbb56f200c34060d22a8c5fb7ec2
Gerrit-Change-Number: 69066
Gerrit-PatchSet: 6
Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Subrata Banik has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/83258?usp=email )
Change subject: soc/intel/common: Skip ME version log for Lite SKU
......................................................................
soc/intel/common: Skip ME version log for Lite SKU
This change skips the ME firmware version logging in
print_me_fw_version() if the ME firmware SKU is detected as Lite SKU.
The reasoning is that the RO (BP1) and RW (BP2) versions are already
logged by the cse_print_boot_partition_info() function for Lite SKUs,
making the additional log redundant.
The check for the Lite SKU has been moved to print_me_fw_version(),
where the decision to print the version is made, instead of in
get_me_fw_version(), where the version information is retrieved.
TEST=Able to build and boot google/rex.
w/o this patch:
[DEBUG] ME: Version: Unavailable
w/ this patch:
Unable to see such debug msg.
Change-Id: Ic3843109326153d5060c2c4c25936aaa6b4cddda
Signed-off-by: Subrata Banik <subratabanik(a)google.com>
---
M src/soc/intel/common/block/cse/cse.c
1 file changed, 7 insertions(+), 7 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/58/83258/1
diff --git a/src/soc/intel/common/block/cse/cse.c b/src/soc/intel/common/block/cse/cse.c
index e4d57e1..0ec296c 100644
--- a/src/soc/intel/common/block/cse/cse.c
+++ b/src/soc/intel/common/block/cse/cse.c
@@ -880,13 +880,6 @@
return CB_ERR;
/*
- * Ignore if ME Firmware SKU type is Lite since
- * print_boot_partition_info() logs RO(BP1) and RW(BP2) versions.
- */
- if (cse_is_hfs3_fw_sku_lite())
- return CB_ERR;
-
- /*
* Prerequisites:
* 1) HFSTS1 Current Working State is Normal
* 2) HFSTS1 Current Operation Mode is Normal
@@ -917,6 +910,13 @@
if (!CONFIG(CONSOLE_SERIAL))
return;
+ /*
+ * Skip if ME firmware is Lite SKU, as RO/RW versions are
+ * already logged by `cse_print_boot_partition_info()`
+ */
+ if (cse_is_hfs3_fw_sku_lite())
+ return;
+
if (get_me_fw_version(&resp) == CB_SUCCESS) {
printk(BIOS_DEBUG, "ME: Version: %d.%d.%d.%d\n", resp.code.major,
resp.code.minor, resp.code.hotfix, resp.code.build);
--
To view, visit https://review.coreboot.org/c/coreboot/+/83258?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ic3843109326153d5060c2c4c25936aaa6b4cddda
Gerrit-Change-Number: 83258
Gerrit-PatchSet: 1
Gerrit-Owner: Subrata Banik <subratabanik(a)google.com>
Subrata Banik has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/83257?usp=email )
Change subject: soc/intel/cmn/cse: Make ME firmware version query function static
......................................................................
soc/intel/cmn/cse: Make ME firmware version query function static
This change modifies the get_me_fw_version() function to be statically
scoped within src/soc/intel/common/block/cse/cse.c, as it is only used
by the print_me_fw_version() function in the same file.
The function declaration is also removed from intelblocks/cse.h.
The order of the function definitions in cse.c was also changed to be
more logical, with the now static helper function get_me_fw_version()
defined first, before it is used.
TEST=Able to build google/rex.
Change-Id: Idd3a6431cfa824227361c7ed4f0d5300f1d04846
Signed-off-by: Subrata Banik <subratabanik(a)google.com>
---
M src/soc/intel/common/block/cse/cse.c
M src/soc/intel/common/block/include/intelblocks/cse.h
2 files changed, 18 insertions(+), 22 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/57/83257/1
diff --git a/src/soc/intel/common/block/cse/cse.c b/src/soc/intel/common/block/cse/cse.c
index d78b8a0..e4d57e1 100644
--- a/src/soc/intel/common/block/cse/cse.c
+++ b/src/soc/intel/common/block/cse/cse.c
@@ -861,23 +861,8 @@
return resp.status;
}
-void print_me_fw_version(void *unused)
-{
- struct me_fw_ver_resp resp = {0};
-
- /* Ignore if UART debugging is disabled */
- if (!CONFIG(CONSOLE_SERIAL))
- return;
-
- if (get_me_fw_version(&resp) == CB_SUCCESS) {
- printk(BIOS_DEBUG, "ME: Version: %d.%d.%d.%d\n", resp.code.major,
- resp.code.minor, resp.code.hotfix, resp.code.build);
- return;
- }
- printk(BIOS_DEBUG, "ME: Version: Unavailable\n");
-}
-
-enum cb_err get_me_fw_version(struct me_fw_ver_resp *resp)
+/* Queries and gets ME firmware version */
+static enum cb_err get_me_fw_version(struct me_fw_ver_resp *resp)
{
const struct mkhi_hdr fw_ver_msg = {
.group_id = MKHI_GROUP_ID_GEN,
@@ -924,6 +909,22 @@
return CB_SUCCESS;
}
+void print_me_fw_version(void *unused)
+{
+ struct me_fw_ver_resp resp = {0};
+
+ /* Ignore if UART debugging is disabled */
+ if (!CONFIG(CONSOLE_SERIAL))
+ return;
+
+ if (get_me_fw_version(&resp) == CB_SUCCESS) {
+ printk(BIOS_DEBUG, "ME: Version: %d.%d.%d.%d\n", resp.code.major,
+ resp.code.minor, resp.code.hotfix, resp.code.build);
+ return;
+ }
+ printk(BIOS_DEBUG, "ME: Version: Unavailable\n");
+}
+
void cse_trigger_vboot_recovery(enum csme_failure_reason reason)
{
printk(BIOS_DEBUG, "cse: CSE status registers: HFSTS1: 0x%x, HFSTS2: 0x%x "
diff --git a/src/soc/intel/common/block/include/intelblocks/cse.h b/src/soc/intel/common/block/include/intelblocks/cse.h
index 3db1324..552eb7b 100644
--- a/src/soc/intel/common/block/include/intelblocks/cse.h
+++ b/src/soc/intel/common/block/include/intelblocks/cse.h
@@ -444,11 +444,6 @@
void print_me_fw_version(void *unused);
/*
- * Queries and gets ME firmware version
- */
-enum cb_err get_me_fw_version(struct me_fw_ver_resp *resp);
-
-/*
* Checks current working operation state is normal or not.
* Returns true if CSE's current working state is normal, otherwise false.
*/
--
To view, visit https://review.coreboot.org/c/coreboot/+/83257?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Idd3a6431cfa824227361c7ed4f0d5300f1d04846
Gerrit-Change-Number: 83257
Gerrit-PatchSet: 1
Gerrit-Owner: Subrata Banik <subratabanik(a)google.com>