Attention is currently required from: Julius Werner.
Hello Julius Werner,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/83256?usp=email
to look at the new patch set (#2).
Change subject: security/vboot: Set VBOOT_ALWAYS_ENABLE_DISPLAY if BMP_LOGO
......................................................................
security/vboot: Set VBOOT_ALWAYS_ENABLE_DISPLAY if BMP_LOGO
If BMP_LOGO is set, currently display_init_required() will always return
1, so that platform code will always initialize display. However, that
information isn't passed to vboot, which may result in unnecessary extra
reboots, for example when the payload needs to request display init (by
vb2api_need_reboot_for_display()).
Since there is already a Kconfig option VBOOT_ALWAYS_ENABLE_DISPLAY to
tell vboot that "display is available on this boot", enable it by
default if BMP_LOGO is set.
BUG=b:345085042
TEST=none
BRANCH=brya,rex
Change-Id: I20113ec464aa036d0498dedb50f0e82cb677ae93
Signed-off-by: Yu-Ping Wu <yupingso(a)chromium.org>
---
M src/lib/bootmode.c
M src/security/vboot/Kconfig
2 files changed, 1 insertion(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/56/83256/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/83256?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I20113ec464aa036d0498dedb50f0e82cb677ae93
Gerrit-Change-Number: 83256
Gerrit-PatchSet: 2
Gerrit-Owner: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Attention: Julius Werner <jwerner(a)chromium.org>
Yu-Ping Wu has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/83256?usp=email )
Change subject: security/vboot: Set VBOOT_MUST_REQUEST_DISPLAY if BMP_LOGO
......................................................................
security/vboot: Set VBOOT_MUST_REQUEST_DISPLAY if BMP_LOGO
If BMP_LOGO is set, currently display_init_required() will always return
1, so that platform code will always initialize display. However, that
information isn't passed to vboot, which may result in unnecessary extra
reboots, for example when the payload needs to request display init (by
vb2api_need_reboot_for_display()).
Since there is already a Kconfig option VBOOT_MUST_REQUEST_DISPLAY to
tell vboot that "display is available on this boot", enable it by
default if BMP_LOGO is set.
BUG=b:345085042
TEST=none
BRANCH=brya,rex
Change-Id: I20113ec464aa036d0498dedb50f0e82cb677ae93
Signed-off-by: Yu-Ping Wu <yupingso(a)chromium.org>
---
M src/lib/bootmode.c
M src/security/vboot/Kconfig
2 files changed, 1 insertion(+), 5 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/56/83256/1
diff --git a/src/lib/bootmode.c b/src/lib/bootmode.c
index 2d5a7eb..3cf77d6 100644
--- a/src/lib/bootmode.c
+++ b/src/lib/bootmode.c
@@ -21,10 +21,6 @@
int display_init_required(void)
{
- /* Need display for showing splash screen. */
- if (CONFIG(BMP_LOGO))
- return 1;
-
/* For vboot, honor VB2_CONTEXT_DISPLAY_INIT. */
if (CONFIG(VBOOT)) {
/* Must always select MUST_REQUEST_DISPLAY when using this
diff --git a/src/security/vboot/Kconfig b/src/security/vboot/Kconfig
index d42dc74..e5ba701 100644
--- a/src/security/vboot/Kconfig
+++ b/src/security/vboot/Kconfig
@@ -146,7 +146,7 @@
config VBOOT_MUST_REQUEST_DISPLAY
bool
- default y if VGA_ROM_RUN
+ default y if VGA_ROM_RUN || BMP_LOGO
default n
help
Set this option to indicate to vboot that this platform will skip its
--
To view, visit https://review.coreboot.org/c/coreboot/+/83256?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I20113ec464aa036d0498dedb50f0e82cb677ae93
Gerrit-Change-Number: 83256
Gerrit-PatchSet: 1
Gerrit-Owner: Yu-Ping Wu <yupingso(a)google.com>
Attention is currently required from: Arthur Heymans, Chen, Gang C, Christian Walter, Johnny Lin, Jonathan Zhang, Lean Sheng Tan, Patrick Rudolph, Tim Chu.
Shuo Liu has posted comments on this change by Shuo Liu. ( https://review.coreboot.org/c/coreboot/+/82080?usp=email )
Change subject: soc/intel/xeon_sp/gnr: Support fast boot
......................................................................
Patch Set 4:
This change is ready for review.
--
To view, visit https://review.coreboot.org/c/coreboot/+/82080?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ib5dc76176b16ea1be5dd9b05a375c9179411f590
Gerrit-Change-Number: 82080
Gerrit-PatchSet: 4
Gerrit-Owner: Shuo Liu <shuo.liu(a)intel.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com>
Gerrit-Reviewer: Jonathan Zhang <jon.zhixiong.zhang(a)gmail.com>
Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com>
Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Reviewer: Tim Chu <Tim.Chu(a)quantatw.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Chen, Gang C <gang.c.chen(a)intel.com>
Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Attention: Jonathan Zhang <jon.zhixiong.zhang(a)gmail.com>
Gerrit-Attention: Chen, Gang C <gang.c.chen(a)intel.com>
Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com>
Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com>
Gerrit-Attention: Tim Chu <Tim.Chu(a)quantatw.com>
Gerrit-Comment-Date: Fri, 28 Jun 2024 08:23:17 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Attention is currently required from: Hung-Te Lin, Paul Menzel, Xuxin Xiong.
Yang Wu has posted comments on this change by Yang Wu. ( https://review.coreboot.org/c/coreboot/+/83221?usp=email )
Change subject: mb/google/corsola/var/wugtrio: Add LCE_LMFBX101117480 MIPI panel
......................................................................
Patch Set 2:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/83221/comment/d7f73d95_215683dc?us… :
PS2, Line 13: TEST=emerge-staryu coreboot chromeos-bootimage
> Add the new log messages?
Hi, Paul,Do you mean the emerge build log or coreboot boot log?
--
To view, visit https://review.coreboot.org/c/coreboot/+/83221?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I863e172400ffb26b5c9c240a21d15c6a2240b4ad
Gerrit-Change-Number: 83221
Gerrit-PatchSet: 2
Gerrit-Owner: Yang Wu <wuyang5(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Xuxin Xiong <xuxinxiong(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Xuxin Xiong <xuxinxiong(a)huaqin.corp-partner.google.com>
Gerrit-Comment-Date: Fri, 28 Jun 2024 08:21:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>
Attention is currently required from: Elyes Haouas, Julius Werner.
Felix Singer has posted comments on this change by Elyes Haouas. ( https://review.coreboot.org/c/coreboot/+/83255?usp=email )
Change subject: soc/nvidia: Remove unneeded white spaces
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/83255?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ifd19cdcfbdf0b01984e0db0aa880fdcb256663b4
Gerrit-Change-Number: 83255
Gerrit-PatchSet: 1
Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Attention: Julius Werner <jwerner(a)chromium.org>
Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Comment-Date: Fri, 28 Jun 2024 08:18:15 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: Paul Menzel, Yang Wu.
Yidi Lin has posted comments on this change by Yang Wu. ( https://review.coreboot.org/c/coreboot/+/83220?usp=email )
Change subject: drivers/mipi: Add support for LCE_LMFBX101117480 panel
......................................................................
Patch Set 2:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/83220/comment/2eb77138_5bf0833a?us… :
PS2, Line 15: TEST=build and check the CBFS includes the panel
> What is the effect on the boot time? Maybe add the new logs too.
Chromebook does not initialize FW screen in normal boot flow.
--
To view, visit https://review.coreboot.org/c/coreboot/+/83220?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I60858109e4b07f720461e320212d7b197ec1130c
Gerrit-Change-Number: 83220
Gerrit-PatchSet: 2
Gerrit-Owner: Yang Wu <wuyang5(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Xuxin Xiong <xuxinxiong(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Yang Wu <wuyang5(a)huaqin.corp-partner.google.com>
Gerrit-Comment-Date: Fri, 28 Jun 2024 07:04:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>
Attention is currently required from: Hung-Te Lin, Xuxin Xiong, Yang Wu.
Paul Menzel has posted comments on this change by Yang Wu. ( https://review.coreboot.org/c/coreboot/+/83221?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: mb/google/corsola/var/wugtrio: Add LCE_LMFBX101117480 MIPI panel
......................................................................
Patch Set 2:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/83221/comment/070b4fbb_f41088be?us… :
PS2, Line 13: TEST=emerge-staryu coreboot chromeos-bootimage
Add the new log messages?
--
To view, visit https://review.coreboot.org/c/coreboot/+/83221?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I863e172400ffb26b5c9c240a21d15c6a2240b4ad
Gerrit-Change-Number: 83221
Gerrit-PatchSet: 2
Gerrit-Owner: Yang Wu <wuyang5(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Xuxin Xiong <xuxinxiong(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Attention: Xuxin Xiong <xuxinxiong(a)huaqin.corp-partner.google.com>
Gerrit-Attention: Yang Wu <wuyang5(a)huaqin.corp-partner.google.com>
Gerrit-Comment-Date: Fri, 28 Jun 2024 06:56:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Attention is currently required from: Yang Wu.
Paul Menzel has posted comments on this change by Yang Wu. ( https://review.coreboot.org/c/coreboot/+/83220?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: drivers/mipi: Add support for LCE_LMFBX101117480 panel
......................................................................
Patch Set 2:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/83220/comment/37e11277_ba88f9b6?us… :
PS2, Line 15: TEST=build and check the CBFS includes the panel
What is the effect on the boot time? Maybe add the new logs too.
--
To view, visit https://review.coreboot.org/c/coreboot/+/83220?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I60858109e4b07f720461e320212d7b197ec1130c
Gerrit-Change-Number: 83220
Gerrit-PatchSet: 2
Gerrit-Owner: Yang Wu <wuyang5(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Xuxin Xiong <xuxinxiong(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Yang Wu <wuyang5(a)huaqin.corp-partner.google.com>
Gerrit-Comment-Date: Fri, 28 Jun 2024 06:55:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No