coreboot-gerrit May 2024

coreboot-gerrit@coreboot.org

1 participants
3267 discussions

[XS] Change in coreboot[main]: mb/razer/blade_stealth_kbl/h3q: add VBIOS table
by Nico Huber (Code Review) 25 May '24

25 May '24

Attention is currently required from: Paul Menzel, Reagan. Nico Huber has posted comments on this change by Reagan. ( https://review.coreboot.org/c/coreboot/+/82460?usp=email ) Change subject: mb/razer/blade_stealth_kbl/h3q: add VBIOS table ...................................................................... Patch Set 12: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/82460?usp=email To unsubscribe, or for help writing mail filters, visit https://review.… [View More]

1 0

[S] Change in coreboot[main]: mb/razer/blade_stealth_kbl: add panel_cfg
by Nico Huber (Code Review) 25 May '24

25 May '24

Attention is currently required from: Reagan. Nico Huber has posted comments on this change by Reagan. ( https://review.coreboot.org/c/coreboot/+/82458?usp=email ) Change subject: mb/razer/blade_stealth_kbl: add panel_cfg ...................................................................... Patch Set 13: (1 comment) File src/mainboard/razer/blade_stealth_kbl/devicetree.cb: https://review.coreboot.org/c/coreboot/+/82458/comment/1c4fe137_3cb190f6?us… : PS13, Line 163: .… [View More]

1 0

[M] Change in coreboot[main]: mb/razer/blade_stealth_kbl: Add H3Q variant
by Nico Huber (Code Review) 25 May '24

25 May '24

Attention is currently required from: Paul Menzel, Reagan. Nico Huber has posted comments on this change by Reagan. ( https://review.coreboot.org/c/coreboot/+/82506?usp=email ) Change subject: mb/razer/blade_stealth_kbl: Add H3Q variant ...................................................................... Patch Set 6: (3 comments) Patchset: PS6: Just one Kconfig nit and OC questions... looks quite good otherwise :) File src/mainboard/razer/blade_stealth_kbl/Kconfig: https://review.… [View More]

1 0

[L] Change in coreboot[main]: mb/asrock: Add SPR 1S server board ASRock Rack SPC741D8-2L2T/BCM
by Nico Huber (Code Review) 25 May '24

25 May '24

1 0

[L] Change in coreboot[main]: mb/asrock: Add SPR 1S server board ASRock Rack SPC741D8-2L2T/BCM
by Nico Huber (Code Review) 25 May '24

25 May '24

Attention is currently required from: Angel Pons, Fabian Meyer, Paul Menzel. Nico Huber has posted comments on this change by Fabian Meyer. ( https://review.coreboot.org/c/coreboot/+/82203?usp=email ) Change subject: mb/asrock: Add SPR 1S server board ASRock Rack SPC741D8-2L2T/BCM ...................................................................... Patch Set 9: Code-Review+1 (2 comments) Patchset: PS9: I guess we can just merge this without the FSP-header update. One would only have … [View More]to update the include path in menuconfig to build, right? WDYT? File src/mainboard/asrock/spc741d8/ramstage.c: https://review.coreboot.org/c/coreboot/+/82203/comment/87e19851_5d494707?us… : PS3, Line 15: // stub for EDK2 > I2C is used to retrieve the EDID of connected displays. […] The AST code actually expects CONFIG_SOFTWARE_I2C (i2c bitbanging, I suppose) to be selected. There's a ast_dp501_read_edid() on the primary path that probably gets a pre-read EDID from the AST. Only if that fails, I2C is tried. Which path is taken probably depends on the AST firmware. SOFTWARE_I2C, however, seems to be designed as a developer option, nothing that should be selected by a driver (expect bus number conflicts if some other driver tries to use a SoC's I2C bus 0). For this board, as we know there is no SoC I2C (i.e. no platform_i2c_transfer() implemented), the best solution might be to simply select SOFTWARE_I2C from the board Kconfig. The stub, however, will be needed anyway. Porting SOFTWARE_I2C to our devicetree infrastructure could solve the bigger puzzle. Doesn't seem necessary for the Aspeed-using boards so far, though. -- To view, visit https://review.coreboot.org/c/coreboot/+/82203?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I84b170669873f1a168ea2b7e3be1d6071e811fa5 Gerrit-Change-Number: 82203 Gerrit-PatchSet: 9 Gerrit-Owner: Fabian Meyer <fabian(a)meyfa.net> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Fabian Meyer <fabian(a)meyfa.net> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Sat, 25 May 2024 12:46:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Comment-In-Reply-To: Fabian Meyer <fabian(a)meyfa.net> [View Less]

1 0

[M] Change in coreboot[main]: arch/arm64: Implement initial set of SMBIOS tables
by Elyes Haouas (Code Review) 25 May '24

25 May '24

Attention is currently required from: Benjamin Doron. Elyes Haouas has posted comments on this change by Benjamin Doron. ( https://review.coreboot.org/c/coreboot/+/78285?usp=email ) Change subject: arch/arm64: Implement initial set of SMBIOS tables ...................................................................... Patch Set 18: (1 comment) File src/arch/arm64/smbios.c: https://review.coreboot.org/c/coreboot/+/78285/comment/08697a9a_c81524ac?us… : PS18, Line 6: <console/console.h&… [View More]

1 0

[XS] Change in coreboot[main]: src/acpi: Increase ACPI revision from 6.0 to 6.4
by Elyes Haouas (Code Review) 25 May '24

25 May '24

Attention is currently required from: Cliff Huang, Felix Singer, Lance Zhao, Paul Menzel, Tim Wawrzynczak, minyu li. Elyes Haouas has posted comments on this change by minyu li. ( https://review.coreboot.org/c/coreboot/+/80781?usp=email ) Change subject: src/acpi: Increase ACPI revision from 6.0 to 6.4 ...................................................................... Patch Set 2: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/80781/comment/10266da1_ac619b81?us… … [View More]

1 0

[S] Change in coreboot[main]: tree: Add smbios_processor_type
by Elyes Haouas (Code Review) 25 May '24

25 May '24

Attention is currently required from: Felix Singer, Julius Werner, Jérémy Compostella. Elyes Haouas has posted comments on this change by Elyes Haouas. ( https://review.coreboot.org/c/coreboot/+/82645?usp=email ) Change subject: tree: Add smbios_processor_type ...................................................................... Patch Set 2: (1 comment) File src/include/smbios.h: https://review.coreboot.org/c/coreboot/+/82645/comment/d0144b2d_2031a4a8?us… : PS1, Line 504: … [View More]

1 0

[S] Change in coreboot[main]: tree: Add some SMBIOS_PROCESSOR_FAMILY macros
by Elyes Haouas (Code Review) 25 May '24

25 May '24

Elyes Haouas has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/82648?usp=email ) Change subject: tree: Add some SMBIOS_PROCESSOR_FAMILY macros ...................................................................... tree: Add some SMBIOS_PROCESSOR_FAMILY macros Change-Id: Ibe551a4c83f416ba30326077aa165818cf79c1fd Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> --- M src/arch/arm64/smbios.c M src/arch/x86/smbios.c M src/include/smbios.h 3 files changed, 9 … [View More]insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/48/82648/1 diff --git a/src/arch/arm64/smbios.c b/src/arch/arm64/smbios.c index 291659a..fe41083 100644 --- a/src/arch/arm64/smbios.c +++ b/src/arch/arm64/smbios.c @@ -66,8 +66,8 @@ smbios_processor_id(t->processor_id); t->processor_manufacturer = smbios_processor_manufacturer(t->eos); t->processor_version = smbios_processor_name(t->eos); - t->processor_family = 0xfe; /* Use processor_family2 field */ - t->processor_family2 = 0x101; /* ARMv8 */ + t->processor_family = SMBIOS_PROCESSOR_FAMILY_FROM_FAMILY2; + t->processor_family2 = SMBIOS_PROCESSOR_FAMILY2_ARMV8; t->processor_type = SMBIOS_PROCESSOR_TYPE_CENTRAL; smbios_cpu_get_core_counts(&t->core_count2, &t->thread_count2); diff --git a/src/arch/x86/smbios.c b/src/arch/x86/smbios.c index 0338b60..ed475ee 100644 --- a/src/arch/x86/smbios.c +++ b/src/arch/x86/smbios.c @@ -68,7 +68,7 @@ unsigned int __weak smbios_processor_family(struct cpuid_result res) { - return (res.eax > 0) ? 0x0c : 0x6; + return (res.eax > 0) ? SMBIOS_PROCESSOR_FAMILY_PENTIUM_PRO : SMBIOS_PROCESSOR_FAMILY_INTEL486; } static size_t get_number_of_caches(size_t max_logical_cpus_sharing_cache) diff --git a/src/include/smbios.h b/src/include/smbios.h index 6eeaaa4..b1cb8ff 100644 --- a/src/include/smbios.h +++ b/src/include/smbios.h @@ -584,7 +584,13 @@ /* defines for processor family */ #define SMBIOS_PROCESSOR_FAMILY_OTHER 0x01 #define SMBIOS_PROCESSOR_FAMILY_UNKNOWN 0x02 +#define SMBIOS_PROCESSOR_FAMILY_INTEL486 0x06 +#define SMBIOS_PROCESSOR_FAMILY_PENTIUM_PRO 0x0c #define SMBIOS_PROCESSOR_FAMILY_XEON 0xb3 +#define SMBIOS_PROCESSOR_FAMILY_FROM_FAMILY2 0xfe + +/* defines for processor family 2 */ +#define SMBIOS_PROCESSOR_FAMILY2_ARMV8 0x101 /* defines for processor characteristics */ #define PROCESSOR_64BIT_CAPABLE (1 << 2) -- To view, visit https://review.coreboot.org/c/coreboot/+/82648?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ibe551a4c83f416ba30326077aa165818cf79c1fd Gerrit-Change-Number: 82648 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> [View Less]

1 0

[S] Change in coreboot[main]: tree: Add smbios_processor_type
by Felix Singer (Code Review) 25 May '24

25 May '24

Attention is currently required from: Elyes Haouas, Julius Werner, Jérémy Compostella. Felix Singer has posted comments on this change by Elyes Haouas. ( https://review.coreboot.org/c/coreboot/+/82645?usp=email ) Change subject: tree: Add smbios_processor_type ...................................................................... Patch Set 1: (1 comment) File src/include/smbios.h: https://review.coreboot.org/c/coreboot/+/82645/comment/11ebd554_cfdead31?us… : PS1, Line 504: … [View More]

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit May 2024