coreboot-gerrit May 2024

coreboot-gerrit@coreboot.org

1 participants
3267 discussions

[M] Change in coreboot[main]: mb/*: Add consolidated USB port config for SNB+MRC boards
by Keith Hui (Code Review) 25 May '24

25 May '24

Attention is currently required from: Alexander Couzens, Keith Hui, Patrick Rudolph. Hello Alexander Couzens, Patrick Rudolph, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/81880?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Code-Review+2 by Patrick Rudolph, Verified+1 by build bot (Jenkins) Change subject: mb/*: Add consolidated USB port config for SNB+MRC boards ...................................................................... mb/*: Add consolidated USB port config for SNB+MRC boards For each sandybridge boards with option to use MRC or native platform init code, add a copy of the board's USB port config, consolidated between both code paths, into the southbridge devicetree, using special values allocated for this consolidation. These get hooked up in a separate patch. Change-Id: I53efca3d29b3c5d4d5b7e3d6dc3e6ce6c34201e6 Signed-off-by: Keith Hui <buurin(a)gmail.com> --- M src/mainboard/asus/p8x7x-series/variants/p8z77-m/overridetree.cb M src/mainboard/asus/p8x7x-series/variants/p8z77-m_pro/overridetree.cb M src/mainboard/google/butterfly/devicetree.cb M src/mainboard/google/link/devicetree.cb M src/mainboard/google/parrot/devicetree.cb M src/mainboard/google/stout/devicetree.cb M src/mainboard/intel/dcp847ske/devicetree.cb M src/mainboard/intel/emeraldlake2/devicetree.cb M src/mainboard/kontron/ktqm77/devicetree.cb M src/mainboard/lenovo/x220/variants/x220/overridetree.cb M src/mainboard/roda/rv11/variants/rv11/devicetree.cb M src/mainboard/roda/rv11/variants/rw11/devicetree.cb M src/mainboard/samsung/lumpy/devicetree.cb M src/mainboard/samsung/stumpy/devicetree.cb 14 files changed, 219 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/80/81880/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/81880?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I53efca3d29b3c5d4d5b7e3d6dc3e6ce6c34201e6 Gerrit-Change-Number: 81880 Gerrit-PatchSet: 3 Gerrit-Owner: Keith Hui <buurin(a)gmail.com> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Attention: Keith Hui <buurin(a)gmail.com>

1 0

[M] Change in coreboot[main]: nb/sandybridge,sb/bd82x6x: Configure USB from southbridge
by Keith Hui (Code Review) 25 May '24

25 May '24

Attention is currently required from: Angel Pons, Keith Hui, Patrick Rudolph. Hello Angel Pons, Patrick Rudolph, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/81881?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Code-Review+2 by Patrick Rudolph, Verified+1 by build bot (Jenkins) The change is no longer submittable: Code-Review and Verified are unsatisfied now. Change subject: nb/sandybridge,sb/bd82x6x: Configure USB from southbridge ...................................................................... nb/sandybridge,sb/bd82x6x: Configure USB from southbridge Transfer all USB responsibilities to southbridge/intel/bd82x6x, using one set of USB port configurations supplied by mainboards in the southbridge section of their devicetree. For MRC raminit, export southbridge_fill_pei_data() as a hook for southbridge code to implement. With new code via this hook, bd82x6x fills pei_data based on this one set of USB port config. For native raminit, early_usb_init() now goes directly to the devicetree and no longer get passed an address to it. TEST=abuild passes for all affected boards. All USB ports still work on asus/p8x7x-series/v/p8z77-m. Change-Id: I38378c7ee0701abc434b030dd97873f2af63e6b0 Signed-off-by: Keith Hui <buurin(a)gmail.com> --- M src/northbridge/intel/sandybridge/pei_data.h M src/northbridge/intel/sandybridge/raminit_mrc.c M src/northbridge/intel/sandybridge/romstage.c M src/southbridge/intel/bd82x6x/early_usb.c M src/southbridge/intel/bd82x6x/early_usb_mrc.c M src/southbridge/intel/bd82x6x/pch.h 6 files changed, 60 insertions(+), 12 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/81/81881/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/81881?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I38378c7ee0701abc434b030dd97873f2af63e6b0 Gerrit-Change-Number: 81881 Gerrit-PatchSet: 3 Gerrit-Owner: Keith Hui <buurin(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Keith Hui <buurin(a)gmail.com>

1 0

[L] Change in coreboot[main]: mb/*: Remove old USB configurations from SNB/bd82x6x boards
by Keith Hui (Code Review) 25 May '24

25 May '24

Attention is currently required from: Alexander Couzens, Angel Pons, Evgeny Zinoviev, Keith Hui, Kevin Keijzer, Patrick Rudolph. Hello Alexander Couzens, Angel Pons, Evgeny Zinoviev, Kevin Keijzer, Patrick Rudolph, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/81882?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Code-Review+2 by Patrick Rudolph, Verified+1 by build bot (Jenkins) Change subject: mb/*: Remove old USB configurations from SNB/bd82x6x boards ...................................................................... mb/*: Remove old USB configurations from SNB/bd82x6x boards Remove USB configurations and data structures from northbridge devicetree (SNB+MRC boards) and bootblock/romstage C code (native-only SNB boards). All USB configurations are drawn from southbridge devicetree going forward. Change-Id: Ie1cd21077136998a6e90050c95263f2efed68a67 Signed-off-by: Keith Hui <buurin(a)gmail.com> --- M src/mainboard/apple/macbookair4_2/early_init.c M src/mainboard/asrock/b75m-itx/Makefile.mk D src/mainboard/asrock/b75m-itx/early_init.c M src/mainboard/asrock/b75pro3-m/early_init.c M src/mainboard/asrock/h77pro4-m/early_init.c M src/mainboard/asus/h61-series/variants/h61m-cs/early_init.c M src/mainboard/asus/h61-series/variants/p8h61-m_lx/early_init.c M src/mainboard/asus/h61-series/variants/p8h61-m_lx3_r2_0/early_init.c M src/mainboard/asus/h61-series/variants/p8h61-m_pro/early_init.c M src/mainboard/asus/h61-series/variants/p8h61-m_pro_cm6630/early_init.c M src/mainboard/asus/maximus_iv_gene-z/early_init.c M src/mainboard/asus/p8x7x-series/devicetree.cb M src/mainboard/asus/p8x7x-series/variants/p8c_ws/early_init.c M src/mainboard/asus/p8x7x-series/variants/p8h77-v/early_init.c M src/mainboard/asus/p8x7x-series/variants/p8z77-m/early_init.c M src/mainboard/asus/p8x7x-series/variants/p8z77-m/overridetree.cb M src/mainboard/asus/p8x7x-series/variants/p8z77-m_pro/early_init.c M src/mainboard/asus/p8x7x-series/variants/p8z77-m_pro/overridetree.cb M src/mainboard/asus/p8x7x-series/variants/p8z77-v/early_init.c M src/mainboard/asus/p8x7x-series/variants/p8z77-v_lx2/early_init.c M src/mainboard/biostar/th61-itx/Makefile.mk M src/mainboard/compulab/intense_pc/early_init.c M src/mainboard/dell/snb_ivb_workstations/early_init.c M src/mainboard/gigabyte/ga-b75m-d3h/early_init.c M src/mainboard/gigabyte/ga-h61m-series/early_init.c M src/mainboard/google/butterfly/devicetree.cb M src/mainboard/google/butterfly/early_init.c M src/mainboard/google/link/devicetree.cb M src/mainboard/google/link/early_init.c M src/mainboard/google/parrot/devicetree.cb M src/mainboard/google/parrot/early_init.c M src/mainboard/google/stout/devicetree.cb M src/mainboard/google/stout/early_init.c M src/mainboard/intel/dcp847ske/devicetree.cb M src/mainboard/intel/dcp847ske/early_southbridge.c D src/mainboard/intel/dcp847ske/usb.h M src/mainboard/intel/dq67sw/early_init.c M src/mainboard/intel/emeraldlake2/devicetree.cb M src/mainboard/intel/emeraldlake2/early_init.c M src/mainboard/kontron/ktqm77/devicetree.cb M src/mainboard/kontron/ktqm77/early_init.c M src/mainboard/lenovo/l520/Makefile.mk D src/mainboard/lenovo/l520/early_init.c M src/mainboard/lenovo/s230u/early_init.c M src/mainboard/lenovo/t420/early_init.c M src/mainboard/lenovo/t420s/early_init.c M src/mainboard/lenovo/t430/early_init.c M src/mainboard/lenovo/x220/Makefile.mk M src/mainboard/lenovo/x220/devicetree.cb D src/mainboard/lenovo/x220/variants/x1/romstage.c D src/mainboard/lenovo/x220/variants/x220/romstage.c M src/mainboard/roda/rv11/variants/rv11/devicetree.cb M src/mainboard/roda/rv11/variants/rv11/early_init.c M src/mainboard/roda/rv11/variants/rw11/devicetree.cb M src/mainboard/roda/rv11/variants/rw11/early_init.c M src/mainboard/samsung/lumpy/devicetree.cb M src/mainboard/samsung/lumpy/early_init.c M src/mainboard/samsung/stumpy/devicetree.cb M src/mainboard/samsung/stumpy/early_init.c M src/mainboard/sapphire/pureplatinumh61/early_init.c M src/northbridge/intel/sandybridge/chip.h M src/southbridge/intel/bd82x6x/pch.h 62 files changed, 0 insertions(+), 941 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/82/81882/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/81882?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ie1cd21077136998a6e90050c95263f2efed68a67 Gerrit-Change-Number: 81882 Gerrit-PatchSet: 3 Gerrit-Owner: Keith Hui <buurin(a)gmail.com> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Evgeny Zinoviev <me(a)ch1p.io> Gerrit-Reviewer: Kevin Keijzer <kevin(a)quietlife.nl> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Kevin Keijzer <kevin(a)quietlife.nl> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Attention: Evgeny Zinoviev <me(a)ch1p.io> Gerrit-Attention: Keith Hui <buurin(a)gmail.com>

1 0

[XS] Change in coreboot[main]: acpi/acpi_apic: use generic MADT IRQ override function for SCI override
by Nico Huber (Code Review) 25 May '24

25 May '24

Attention is currently required from: Cliff Huang, Felix Held, Lance Zhao, Tim Wawrzynczak. Nico Huber has posted comments on this change by Felix Held. ( https://review.coreboot.org/c/coreboot/+/82644?usp=email ) Change subject: acpi/acpi_apic: use generic MADT IRQ override function for SCI override ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/82644?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I7e6ee0eed837c2d46da62092b7cc5669dc177d8d Gerrit-Change-Number: 82644 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Reviewer: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Attention: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Sat, 25 May 2024 14:48:01 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in coreboot[main]: acpi/acpi_apic;arch/x86/acpi: better document ACPI_NO_PCAT_8259 case
by Nico Huber (Code Review) 25 May '24

25 May '24

Attention is currently required from: Cliff Huang, Felix Held, Jérémy Compostella, Lance Zhao. Nico Huber has posted comments on this change by Felix Held. ( https://review.coreboot.org/c/coreboot/+/82643?usp=email ) Change subject: acpi/acpi_apic;arch/x86/acpi: better document ACPI_NO_PCAT_8259 case ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/82643?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ia6dcf59d5ab9226c61e9c4af95a73a07771b71d1 Gerrit-Change-Number: 82643 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Attention: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Sat, 25 May 2024 14:46:47 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in coreboot[main]: acpi: add and use defines for LAPIC feature flags
by Nico Huber (Code Review) 25 May '24

25 May '24

Nico Huber has submitted this change. ( https://review.coreboot.org/c/coreboot/+/82641?usp=email ) Change subject: acpi: add and use defines for LAPIC feature flags ...................................................................... acpi: add and use defines for LAPIC feature flags Both the processor local APIC structure and the processor local x2APIC structure use the same flag bit definitions. ACPI spec 6.4 was used as a reference. Signed-off-by: Felix Held <felix-coreboot(a)felixheld.de> Change-Id: I8101c2ea874c8b12b130dbe9a0a7e0f0d94adffa Reviewed-on: https://review.coreboot.org/c/coreboot/+/82641 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Nico Huber <nico.h(a)gmx.de> Reviewed-by: Elyes Haouas <ehaouas(a)noos.fr> --- M src/acpi/acpi_apic.c M src/include/acpi/acpi.h 2 files changed, 6 insertions(+), 2 deletions(-) Approvals: Nico Huber: Looks good to me, approved build bot (Jenkins): Verified Elyes Haouas: Looks good to me, approved diff --git a/src/acpi/acpi_apic.c b/src/acpi/acpi_apic.c index 9098811..ebff44f 100644 --- a/src/acpi/acpi_apic.c +++ b/src/acpi/acpi_apic.c @@ -11,7 +11,7 @@ { lapic->type = LOCAL_APIC; /* Local APIC structure */ lapic->length = sizeof(acpi_madt_lapic_t); - lapic->flags = (1 << 0); /* Processor/LAPIC enabled */ + lapic->flags = ACPI_MADT_LAPIC_ENABLED; lapic->processor_id = cpu; lapic->apic_id = apic; @@ -23,7 +23,7 @@ lapic->type = LOCAL_X2APIC; /* Local APIC structure */ lapic->reserved = 0; lapic->length = sizeof(acpi_madt_lx2apic_t); - lapic->flags = (1 << 0); /* Processor/LAPIC enabled */ + lapic->flags = ACPI_MADT_LAPIC_ENABLED; lapic->processor_id = cpu; lapic->x2apic_id = apic; diff --git a/src/include/acpi/acpi.h b/src/include/acpi/acpi.h index 0e5b4b2..4a71aef 100644 --- a/src/include/acpi/acpi.h +++ b/src/include/acpi/acpi.h @@ -726,6 +726,10 @@ #define ACPI_MADT_MAX_LAPIC_ID 0xfe +/* MADT Local APIC Feature Flags */ +#define ACPI_MADT_LAPIC_ENABLED (1 << 0) +#define ACPI_MADT_LAPIC_ONLINE_CAPABLE (1 << 1) + /* MADT: Local APIC NMI Structure */ typedef struct acpi_madt_lapic_nmi { u8 type; /* Type (4) */ -- To view, visit https://review.coreboot.org/c/coreboot/+/82641?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I8101c2ea874c8b12b130dbe9a0a7e0f0d94adffa Gerrit-Change-Number: 82641 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

[XS] Change in coreboot[main]: acpi: add and use defines for LAPIC feature flags
by Nico Huber (Code Review) 25 May '24

25 May '24

Attention is currently required from: Cliff Huang, Felix Held, Lance Zhao, Tim Wawrzynczak. Nico Huber has posted comments on this change by Felix Held. ( https://review.coreboot.org/c/coreboot/+/82641?usp=email ) Change subject: acpi: add and use defines for LAPIC feature flags ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/82641?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I8101c2ea874c8b12b130dbe9a0a7e0f0d94adffa Gerrit-Change-Number: 82641 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Attention: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Sat, 25 May 2024 14:45:40 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in coreboot[main]: acpi: introduce and use ACPI_MADT_PCAT_COMPAT define
by Nico Huber (Code Review) 25 May '24

25 May '24

Nico Huber has submitted this change. ( https://review.coreboot.org/c/coreboot/+/82640?usp=email ) Change subject: acpi: introduce and use ACPI_MADT_PCAT_COMPAT define ...................................................................... acpi: introduce and use ACPI_MADT_PCAT_COMPAT define The multiple APIC flags table from the ACPI specification version 6.4 was used as a reference. Signed-off-by: Felix Held <felix-coreboot(a)felixheld.de> Change-Id: I36f67ca21465bc8753bb36896ee05669de6de333 Reviewed-on: https://review.coreboot.org/c/coreboot/+/82640 Reviewed-by: Nico Huber <nico.h(a)gmx.de> Reviewed-by: Elyes Haouas <ehaouas(a)noos.fr> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- M src/acpi/acpi_apic.c M src/include/acpi/acpi.h 2 files changed, 4 insertions(+), 1 deletion(-) Approvals: Nico Huber: Looks good to me, approved Elyes Haouas: Looks good to me, approved build bot (Jenkins): Verified diff --git a/src/acpi/acpi_apic.c b/src/acpi/acpi_apic.c index 2b3402a..9098811 100644 --- a/src/acpi/acpi_apic.c +++ b/src/acpi/acpi_apic.c @@ -234,7 +234,7 @@ madt->lapic_addr = cpu_get_lapic_addr(); if (CONFIG(ACPI_HAVE_PCAT_8259)) - madt->flags |= 1; + madt->flags |= ACPI_MADT_PCAT_COMPAT; if (CONFIG(ACPI_COMMON_MADT_LAPIC)) current = acpi_create_madt_lapics_with_nmis(current); diff --git a/src/include/acpi/acpi.h b/src/include/acpi/acpi.h index d6c30c1..0e5b4b2 100644 --- a/src/include/acpi/acpi.h +++ b/src/include/acpi/acpi.h @@ -458,6 +458,9 @@ u32 flags; /* Multiple APIC flags */ } __packed acpi_madt_t; +/* MADT Feature Flags */ +#define ACPI_MADT_PCAT_COMPAT (1 << 0) + /* * LPIT (Low Power Idle Table) * Conforms to "Intel Low Power S0 Idle" specification, rev 002 from July 2017. -- To view, visit https://review.coreboot.org/c/coreboot/+/82640?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I36f67ca21465bc8753bb36896ee05669de6de333 Gerrit-Change-Number: 82640 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

[XS] Change in coreboot[main]: acpi: introduce and use ACPI_MADT_PCAT_COMPAT define
by Nico Huber (Code Review) 25 May '24

25 May '24

Attention is currently required from: Cliff Huang, Felix Held, Lance Zhao, Tim Wawrzynczak. Nico Huber has posted comments on this change by Felix Held. ( https://review.coreboot.org/c/coreboot/+/82640?usp=email ) Change subject: acpi: introduce and use ACPI_MADT_PCAT_COMPAT define ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/82640?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I36f67ca21465bc8753bb36896ee05669de6de333 Gerrit-Change-Number: 82640 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Attention: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Sat, 25 May 2024 14:42:53 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in coreboot[main]: acpi: drop sort-of duplicate ACPI_HAVE_PCAT_8259 option
by Nico Huber (Code Review) 25 May '24

25 May '24

Attention is currently required from: Cliff Huang, Felix Held, Jérémy Compostella, Lance Zhao, Tim Wawrzynczak. Nico Huber has posted comments on this change by Felix Held. ( https://review.coreboot.org/c/coreboot/+/82642?usp=email ) The change is no longer submittable: All-Comments-Resolved is unsatisfied now. Change subject: acpi: drop sort-of duplicate ACPI_HAVE_PCAT_8259 option ...................................................................... Patch Set 1: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/82642/comment/505bae7b_5a7bb067?us… : PS1, Line 7: acpi: drop sort-of duplicate ACPI_HAVE_PCAT_8259 option Why? I actually don't "remember" why I added it. However given that there are always voices against double negatives, it seems very likely that was the concern here. The original use was ``` if (CONFIG(ACPI_HAVE_PCAT_8259)) ``` I'd like to keep that. The other cases actually seem better as they are, too, at least to me. A syntactical `!` seems more clear than a `NO` hidden in an identifier. -- To view, visit https://review.coreboot.org/c/coreboot/+/82642?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I246ecfda5bb156d151512e5dbf432a113fad51a2 Gerrit-Change-Number: 82642 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Attention: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Sat, 25 May 2024 14:42:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit May 2024