May 2024 - coreboot-gerrit - mail.coreboot.org

[L] Change in coreboot[main]: mb/dell: Add Latitude E6430 (Ivy Bridge)
by Nicholas Chin (Code Review) May 1, 2024

May 1, 2024

Attention is currently required from: Martin L Roth, Paul Menzel. Nicholas Chin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/77444?usp=email ) Change subject: mb/dell: Add Latitude E6430 (Ivy Bridge) ...................................................................... Patch Set 10: (2 comments) File src/mainboard/dell/snb_ivb_latitude/gma-mainboard.ads: PS10: Double check if this is the same for all the Latitudes in the patch train https://review.coreboot.org/c/coreboot/+/77444/comment/6cfc753b_6e2d5434 : PS10, Line 14: DP2, -- dock DP : DP3, -- dock DP Add HDMI for dock DVI ports -- To view, visit https://review.coreboot.org/c/coreboot/+/77444?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I93c6622fc5da1d0d61a5b2c197ac7227d9525908 Gerrit-Change-Number: 77444 Gerrit-PatchSet: 10 Gerrit-Owner: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-CC: Iru Cai <mytbk920423(a)gmail.com> Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Wed, 01 May 2024 15:13:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: util/crossgcc: Update LLVM from 17.0.6 to 18.1.4
by Elyes Haouas (Code Review) May 1, 2024

May 1, 2024

Attention is currently required from: Arthur Heymans, Felix Singer, Martin L Roth, Zebreus. Elyes Haouas has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80314?usp=email ) Change subject: util/crossgcc: Update LLVM from 17.0.6 to 18.1.4 ...................................................................... Patch Set 16: Code-Review+1 (1 comment) Patchset: PS13: > We want to make sure that the updates are free of errors. So better earlier than later. yep, sure! this what I also try to do here #81419. note that w'll have llvm version 18.1.5 in soon -- To view, visit https://review.coreboot.org/c/coreboot/+/80314?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I03a44e0c23a925396f614f282882405dc886ba58 Gerrit-Change-Number: 80314 Gerrit-PatchSet: 16 Gerrit-Owner: Zebreus <lennarteichhorn(a)googlemail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Zebreus <lennarteichhorn(a)googlemail.com> Gerrit-Comment-Date: Wed, 01 May 2024 14:49:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Comment-In-Reply-To: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-MessageType: comment

1 0

[L] Change in coreboot[main]: mb/dell: Add Latitude E6430 (Ivy Bridge)
by Felix Singer (Code Review) May 1, 2024

May 1, 2024

Attention is currently required from: Martin L Roth, Nicholas Chin, Paul Menzel. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/77444?usp=email ) Change subject: mb/dell: Add Latitude E6430 (Ivy Bridge) ...................................................................... Patch Set 10: (4 comments) File src/mainboard/dell/snb_ivb_latitude/acpi_tables.c: https://review.coreboot.org/c/coreboot/+/77444/comment/50f89e28_3b049744 : PS10, Line 6: /* FIXME: check this function. */ can this be removed? File src/mainboard/dell/snb_ivb_latitude/devicetree.cb: PS10: Missing license header File src/mainboard/dell/snb_ivb_latitude/dsdt.asl: https://review.coreboot.org/c/coreboot/+/77444/comment/a2d80758_80033509 : PS10, Line 3: /* SPDX-License-Identifier: GPL-2.0-only */ Move license header before the others File src/mainboard/dell/snb_ivb_latitude/variants/e6430/overridetree.cb: PS10: Missing license header -- To view, visit https://review.coreboot.org/c/coreboot/+/77444?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I93c6622fc5da1d0d61a5b2c197ac7227d9525908 Gerrit-Change-Number: 77444 Gerrit-PatchSet: 10 Gerrit-Owner: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-CC: Iru Cai <mytbk920423(a)gmail.com> Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Comment-Date: Wed, 01 May 2024 12:37:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[L] Change in coreboot[main]: mb/asrock/z97_extreme6: Add new mainboard
by Angel Pons (Code Review) May 1, 2024

May 1, 2024

Attention is currently required from: Felix Singer, Martin L Roth, Nico Huber. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68188?usp=email ) Change subject: mb/asrock/z97_extreme6: Add new mainboard ...................................................................... Patch Set 8: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/68188/comment/3822b47f_85c1849b : PS8, Line 51: - Flashing with flashrom > The `board_info.txt` says supported. Do you mean something in particular like […] It's probably out of sync. When I wrote this, I meant that I never tried flashing internally, but I was sure it would work. I primarily test this board using an EM100 so I don't really try flashing internally. That being said, I just reflashed the GbE region to one of the chips and it went well, so I'd say it is working. Will move. -- To view, visit https://review.coreboot.org/c/coreboot/+/68188?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: If1d22547725e59f435de36b973e1bf4f334269a9 Gerrit-Change-Number: 68188 Gerrit-PatchSet: 8 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-CC: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-CC: Martin L Roth <gaumless(a)gmail.com> Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Comment-Date: Wed, 01 May 2024 11:33:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Gerrit-MessageType: comment

1 0

[L] Change in coreboot[main]: mb/asrock/z97_extreme6: Add new mainboard
by Nico Huber (Code Review) May 1, 2024

May 1, 2024

Attention is currently required from: Angel Pons, Felix Singer, Martin L Roth. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68188?usp=email ) Change subject: mb/asrock/z97_extreme6: Add new mainboard ...................................................................... Patch Set 8: (10 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/68188/comment/401003ba_af64eadc : PS4, Line 59: - Acer B247Y board driving a FHD panel of a Samsung S24E650 monitor, : connected to the board's HDMI output says "Unsupported resolution" : after libgfxinit configured the iGPU outputs in linear framebuffer : mode. HDMI output works fine after Linux's i915 driver takes over. : Not sure if it's specific to the monitor: the HDMI cable is beaten : up, and it is hard to replace (need to relocate the logic board so : that the ports are accessible). > Worth checking if this problem occurs on other libgfxinit boards/platforms. […] I've also some special HDMI video grabber collecting dust that works with Linux HDMI but not libgfxinit HDMI. Funny thing, right now for the very first time I had this thought: It might be because we run HDMI in legacy DVI mode w/o audio channel (not sure, but this probably also implies a different transport w/o packets). Commit Message: https://review.coreboot.org/c/coreboot/+/68188/comment/e99df806_0aa7ad2a : PS8, Line 51: - Flashing with flashrom The `board_info.txt` says supported. Do you mean something in particular like flashing from the original firmware, or is this just out of sync? File src/mainboard/asrock/z97_extreme6/bootblock.c: https://review.coreboot.org/c/coreboot/+/68188/comment/37873ee8_f072c0e7 : PS8, Line 11: PP_OD_DEV Maybe not the best choice of names as there is also a parallel port (PP) device. Can't come up with something better and short, though, hence maybe the following: The other blocks below start with a comment, maybe the PP_OD_DEV one should too, e.g. `/* Select push-pull vs. open-drain output */` https://review.coreboot.org/c/coreboot/+/68188/comment/4a89075c_ac41bfaa : PS8, Line 18: pnp_write_config(GLOBAL_DEV, 0x1b, 0xf0); Bit 4 sets pin 95 to CIRRX? But CIR is disabled in the DT. Boardview says DEVSLP for SATAE_1. https://review.coreboot.org/c/coreboot/+/68188/comment/8968aec5_94142b1f : PS8, Line 18: pnp_write_config(GLOBAL_DEV, 0x1b, 0xf0); Meh, bit 5 is reserved in my ds. https://review.coreboot.org/c/coreboot/+/68188/comment/e14fc613_2baa623e : PS8, Line 18: pnp_write_config(GLOBAL_DEV, 0x1b, 0xf0); Bits 2..1 suggest pin 51 is MSDA, but WLAN1_ON/OFF in boardview. https://review.coreboot.org/c/coreboot/+/68188/comment/5f682d05_27617f26 : PS8, Line 19: pnp_write_config(GLOBAL_DEV, 0x1c, 0x10); Note to self, 0x1a (default 0x30) and 0x1c look reasonable. https://review.coreboot.org/c/coreboot/+/68188/comment/28497006_ad177341 : PS8, Line 33: pnp_write_config(ACPI_DEV, 0xe4, 0x70); This also seems to set "User defined mode for power loss last-state. (The last- state flag is located on “CRE6h, bit4.”)" is that intentional? File src/mainboard/asrock/z97_extreme6/devicetree.cb: https://review.coreboot.org/c/coreboot/+/68188/comment/d7dcf827_e07fd280 : PS8, Line 20: Bifurcable If the verb is 'bifurcate', this would be 'bifurcatable' right? https://review.coreboot.org/c/coreboot/+/68188/comment/d904bc51_7910926e : PS8, Line 27: c Not that it matters, but I guess 8 bytes would suffice. -- To view, visit https://review.coreboot.org/c/coreboot/+/68188?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: If1d22547725e59f435de36b973e1bf4f334269a9 Gerrit-Change-Number: 68188 Gerrit-PatchSet: 8 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-CC: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-CC: Martin L Roth <gaumless(a)gmail.com> Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Wed, 01 May 2024 10:44:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

[M] Change in coreboot[main]: spd.h: Move enum ddr4_module_type to ddr4.h
by Elyes Haouas (Code Review) May 1, 2024

May 1, 2024

Attention is currently required from: Angel Pons, Elyes Haouas, Jakub Czapiga. Hello Angel Pons, Jakub Czapiga, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/82124?usp=email to look at the new patch set (#3). Change subject: spd.h: Move enum ddr4_module_type to ddr4.h ...................................................................... spd.h: Move enum ddr4_module_type to ddr4.h Move specific enum ddr4_module_type to <device/dram/ddr4.h>. Change-Id: I33afccb768eaee94cc1cd947eb0ddbe15c2831bd Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> --- M src/device/dram/ddr3.c M src/device/dram/ddr4.c M src/device/dram/spd.c M src/include/device/dram/ddr3.h M src/include/device/dram/ddr4.h M src/include/spd.h M src/northbridge/intel/haswell/native_raminit/raminit_native.h M src/northbridge/intel/sandybridge/raminit.c M src/soc/intel/baytrail/romstage/raminit.c M tests/lib/dimm_info_util-test.c 10 files changed, 31 insertions(+), 43 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/24/82124/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/82124?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I33afccb768eaee94cc1cd947eb0ddbe15c2831bd Gerrit-Change-Number: 82124 Gerrit-PatchSet: 3 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Jakub Czapiga <czapiga(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jakub Czapiga <czapiga(a)google.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-MessageType: newpatchset

1 0

[M] Change in coreboot[main]: spd.h: Move enum ddr4_module_type to ddr4.h
by Elyes Haouas (Code Review) May 1, 2024

May 1, 2024

Attention is currently required from: Angel Pons, Elyes Haouas, Jakub Czapiga. Hello Angel Pons, Jakub Czapiga, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/82124?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified-1 by build bot (Jenkins) Change subject: spd.h: Move enum ddr4_module_type to ddr4.h ...................................................................... spd.h: Move enum ddr4_module_type to ddr4.h Move specific enum ddr4_module_type to <device/dram/ddr4.h>. Change-Id: I33afccb768eaee94cc1cd947eb0ddbe15c2831bd Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> --- M src/device/dram/ddr3.c M src/device/dram/ddr4.c M src/device/dram/spd.c M src/include/device/dram/ddr3.h M src/include/device/dram/ddr4.h M src/include/spd.h M src/northbridge/intel/haswell/native_raminit/raminit_native.h M src/northbridge/intel/sandybridge/raminit.c M src/soc/intel/baytrail/romstage/raminit.c M tests/lib/dimm_info_util-test.c 10 files changed, 31 insertions(+), 43 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/24/82124/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/82124?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I33afccb768eaee94cc1cd947eb0ddbe15c2831bd Gerrit-Change-Number: 82124 Gerrit-PatchSet: 2 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Jakub Czapiga <czapiga(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jakub Czapiga <czapiga(a)google.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[main]: mb/google/nissa: Create a riven variant
by Kapil Porwal (Code Review) May 1, 2024

May 1, 2024

Attention is currently required from: David Wu, Dinesh Gehlot, Eric Lai, Morris Hsu, Nick Vaccaro, Ren Kuo, Subrata Banik, Tyler Wang. Kapil Porwal has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/82132?usp=email ) Change subject: mb/google/nissa: Create a riven variant ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/82132?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I1be2346d87c891cc0e5fbda094e1f6e0dd60df1b Gerrit-Change-Number: 82132 Gerrit-PatchSet: 2 Gerrit-Owner: David Wu <david_wu(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Morris Hsu <morris-hsu(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tyler Wang <tyler.wang(a)quanta.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Eric Lai <ericllai(a)google.com> Gerrit-Attention: David Wu <david_wu(a)quanta.corp-partner.google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Attention: Tyler Wang <tyler.wang(a)quanta.corp-partner.google.com> Gerrit-Attention: Morris Hsu <morris-hsu(a)quanta.corp-partner.google.com> Gerrit-Comment-Date: Wed, 01 May 2024 07:54:45 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: mb/google/corsola: Add new board variant Squirtle
by Yang Wu (Code Review) May 1, 2024

May 1, 2024

Attention is currently required from: Hung-Te Lin. Yang Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/82117?usp=email ) Change subject: mb/google/corsola: Add new board variant Squirtle ...................................................................... Patch Set 3: (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/82117/comment/bf11de34_143d82cf : PS2, Line 9: squirtle > nit: Squirtle Done https://review.coreboot.org/c/coreboot/+/82117/comment/93e22f24_ca558d78 : PS2, Line 9: Add a new kingler follower 'squirtle'. > nit: Kingler Done -- To view, visit https://review.coreboot.org/c/coreboot/+/82117?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I393738fc470ffc907f125647a46bf81c243708d7 Gerrit-Change-Number: 82117 Gerrit-PatchSet: 3 Gerrit-Owner: Yang Wu <wuyang5(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Xuxin Xiong <xuxinxiong(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Comment-Date: Wed, 01 May 2024 07:04:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Yidi Lin <yidilin(a)google.com> Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: mb/google/corsola: Add new board variant Squirtle
by Yang Wu (Code Review) May 1, 2024

May 1, 2024

Attention is currently required from: Hung-Te Lin, Yang Wu. Hello Hung-Te Lin, Xuxin Xiong, Yidi Lin, Yu-Ping Wu, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/82117?usp=email to look at the new patch set (#3). Change subject: mb/google/corsola: Add new board variant Squirtle ...................................................................... mb/google/corsola: Add new board variant Squirtle Add a new Kingler follower 'Squirtle'. BRANCH=corsola BUG=b:333826091 TEST=emerge-corsola coreboot Change-Id: I393738fc470ffc907f125647a46bf81c243708d7 Signed-off-by: Yang Wu <wuyang5(a)huaqin.corp-partner.google.com> --- M src/mainboard/google/corsola/Kconfig M src/mainboard/google/corsola/Kconfig.name 2 files changed, 6 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/17/82117/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/82117?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I393738fc470ffc907f125647a46bf81c243708d7 Gerrit-Change-Number: 82117 Gerrit-PatchSet: 3 Gerrit-Owner: Yang Wu <wuyang5(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Xuxin Xiong <xuxinxiong(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Yang Wu <wuyang5(a)huaqin.corp-partner.google.com> Gerrit-MessageType: newpatchset

1 0