coreboot-gerrit May 2024

coreboot-gerrit@coreboot.org

1 participants
3267 discussions

[M] Change in coreboot[main]: Wifi: Support 320Mhz Bandwidth Enablement per MCC
by Bob Moragues (Code Review) 24 May '24

24 May '24

Attention is currently required from: Cliff Huang, Poornima Tom. Bob Moragues has posted comments on this change by Poornima Tom. ( https://review.coreboot.org/c/coreboot/+/81790?usp=email ) Change subject: Wifi: Support 320Mhz Bandwidth Enablement per MCC ...................................................................... Patch Set 2: (1 comment) File src/include/sar.h: https://review.coreboot.org/c/coreboot/+/81790/comment/29bb8279_01d04206?us… : PS2, Line 58: enablement_11ax; need to add enablement_11be ? -- To view, visit https://review.coreboot.org/c/coreboot/+/81790?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ie76794825f1a0104d199c078aa4ffc714aa95b17 Gerrit-Change-Number: 81790 Gerrit-PatchSet: 2 Gerrit-Owner: Poornima Tom <poornima.tom(a)intel.com> Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Bob Moragues <moragues(a)google.com> Gerrit-CC: Dinesh Sharma <dinesh.sharma(a)intel.corp-partner.google.com> Gerrit-Attention: Poornima Tom <poornima.tom(a)intel.com> Gerrit-Attention: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Comment-Date: Fri, 24 May 2024 20:44:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[S] Change in coreboot[main]: sio/nuvoton: Add Kconfig for shared PS/2 port
by Keith Hui (Code Review) 24 May '24

24 May '24

Attention is currently required from: Felix Held, Paul Menzel. Keith Hui has posted comments on this change by Keith Hui. ( https://review.coreboot.org/c/coreboot/+/82631?usp=email ) Change subject: sio/nuvoton: Add Kconfig for shared PS/2 port ...................................................................... Patch Set 1: (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/82631/comment/4537724a_642b17c8?us… : PS1, Line 11: On these boards (where a Y-cable cannot allow both : keyboard and mouse to work off the same port), if a PS/2 keyboard is : not present, SIO should be configured to swap its role to mouse, to : allow the OS to find and initialize any mouse connected. > Just to avoid misunderstandings. […] It is definitely board dependent. The PS/2 port have enough pins to carry both mouse and keyboard clock and data. But they have to be pinned in a particular way and have a matching Y-cable the breaks the two ports out properly. I can assume that most if not all will default that port to keyboards and will have to rely on the super i/O chip to use the keyboard lanes to carry mouse data, which the next 2 patches in the train will address. File src/superio/nuvoton/common/Kconfig: https://review.coreboot.org/c/coreboot/+/82631/comment/c84d3983_35406baf?us… : PS1, Line 15: HAVE_SHARED_PS2_PORT > Should this be namespaced, or could it be moved to `src/superio/Kconfig`? There is no src/superio/Kconfig. It probably should go to src/mainboard/Kconfig like the state after power loss option, but maybe that should wait till wide adoption e.g. ITE SIOs getting this feature as well. Some devs here actually prefer this option be replicated over there when that happens, when we discussed other things with similar wider adoption potential. -- To view, visit https://review.coreboot.org/c/coreboot/+/82631?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I156b15c6ba233cbe8b9ba4d2cfbca6836ad7483a Gerrit-Change-Number: 82631 Gerrit-PatchSet: 1 Gerrit-Owner: Keith Hui <buurin(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Fri, 24 May 2024 20:12:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>

1 0

[S] Change in coreboot[main]: vc/edk2-stable202302: Add config guards to support FSP 2.4
by Subrata Banik (Code Review) 24 May '24

24 May '24

Attention is currently required from: Appukuttan V K, Paul Menzel, Ronak Kanabar. Subrata Banik has posted comments on this change by Appukuttan V K. ( https://review.coreboot.org/c/coreboot/+/82425?usp=email ) Change subject: vc/edk2-stable202302: Add config guards to support FSP 2.4 ...................................................................... Patch Set 16: (1 comment) File src/vendorcode/intel/edk2/edk2-stable202302/IntelFsp2Pkg/Include/FspEas/FspApi.h: https://review.coreboot.org/c/coreboot/+/82425/comment/ef2b77a5_ac89b3a1?us… : PS12, Line 257: PLATFORM_USES_FSP2_X86_32 > Moved x86_32 specific structures under PLATFORM_USES_FSP2_X86_32 and FSP2.4 specific ones under PLATFORM_USES_FSP2_4 config note: this file belongs to the upsteam EDK2 hence, ideally any local change related to this file should eventually reach EDK2 upstream. Kindly follow this practice from now onwards while updating EDK2. -- To view, visit https://review.coreboot.org/c/coreboot/+/82425?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Idc849de73723036323f81dfd055730f6669cd52e Gerrit-Change-Number: 82425 Gerrit-PatchSet: 16 Gerrit-Owner: Appukuttan V K <appukuttan.vk(a)intel.com> Gerrit-Reviewer: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Appukuttan V K <appukuttan.vk(a)intel.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-Comment-Date: Fri, 24 May 2024 18:45:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Appukuttan V K <appukuttan.vk(a)intel.com> Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com>

1 0

[XS] Change in coreboot[main]: [TEST][MTL-x64]vendorcode/intel/edk2: Define EFIAPI as __ms_abi__
by Appukuttan V K (Code Review) 24 May '24

24 May '24

Appukuttan V K has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/81775?usp=email ) Change subject: [TEST][MTL-x64]vendorcode/intel/edk2: Define EFIAPI as __ms_abi__ ...................................................................... Abandoned Old recipe -- To view, visit https://review.coreboot.org/c/coreboot/+/81775?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: abandon Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I96337a8b4b745b0eb02f25c1d07107f786ed1b4e Gerrit-Change-Number: 81775 Gerrit-PatchSet: 4 Gerrit-Owner: Appukuttan V K <appukuttan.vk(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

[XL] Change in coreboot[main]: [TEST][MTL-x64]vendorcode/intel: FSP2.4 Header files
by Appukuttan V K (Code Review) 24 May '24

24 May '24

Appukuttan V K has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/81555?usp=email ) Change subject: [TEST][MTL-x64]vendorcode/intel: FSP2.4 Header files ...................................................................... Abandoned Old recipe -- To view, visit https://review.coreboot.org/c/coreboot/+/81555?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: abandon Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ib5ba5672d4eae9f9ab72b84b56a82d09022ee9d1 Gerrit-Change-Number: 81555 Gerrit-PatchSet: 6 Gerrit-Owner: Appukuttan V K <appukuttan.vk(a)intel.com> Gerrit-Reviewer: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

[XL] Change in coreboot[main]: [TEST][MTL-x64]vendorcode/intel/edk2: FSP2.4 x64 UDK 2022
by Appukuttan V K (Code Review) 24 May '24

24 May '24

Appukuttan V K has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/81450?usp=email ) Change subject: [TEST][MTL-x64]vendorcode/intel/edk2: FSP2.4 x64 UDK 2022 ...................................................................... Abandoned Old recipe -- To view, visit https://review.coreboot.org/c/coreboot/+/81450?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: abandon Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ib435b119c65ebca4458a26bea8f582e54279d9fe Gerrit-Change-Number: 81450 Gerrit-PatchSet: 10 Gerrit-Owner: Appukuttan V K <appukuttan.vk(a)intel.com> Gerrit-Reviewer: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

[S] Change in coreboot[main]: [TEST][W/A for MTL Build]: Changes for MTL x64 Build
by Appukuttan V K (Code Review) 24 May '24

24 May '24

Appukuttan V K has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/80339?usp=email ) Change subject: [TEST][W/A for MTL Build]: Changes for MTL x64 Build ...................................................................... Abandoned Old recipe -- To view, visit https://review.coreboot.org/c/coreboot/+/80339?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: abandon Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I0068ce99af7be937132c152293b7a670be7646ab Gerrit-Change-Number: 80339 Gerrit-PatchSet: 21 Gerrit-Owner: Appukuttan V K <appukuttan.vk(a)intel.com> Gerrit-Reviewer: Ashish Kumar Mishra <ashish.k.mishra(a)intel.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Jakub Czapiga <czapiga(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Krishna P Bhat D <krishna.p.bhat.d(a)intel.com> Gerrit-Reviewer: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-Reviewer: Saurabh Mishra <mishra.saurabh(a)intel.com> Gerrit-Reviewer: Tarun <tstuli(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Sanju Jose Thottan <sanjujose.thottan(a)intel.com> Gerrit-CC: Subrata Banik <subratabanik(a)google.com>

1 0

[S] Change in coreboot[main]: vc/edk2-stable202302: Add config guards to support FSP 2.4
by Appukuttan V K (Code Review) 24 May '24

24 May '24

Attention is currently required from: Paul Menzel, Ronak Kanabar, Subrata Banik. Appukuttan V K has posted comments on this change by Appukuttan V K. ( https://review.coreboot.org/c/coreboot/+/82425?usp=email ) Change subject: vc/edk2-stable202302: Add config guards to support FSP 2.4 ...................................................................... Patch Set 16: (5 comments) This change is ready for review. Commit Message: https://review.coreboot.org/c/coreboot/+/82425/comment/9eabf329_2d28a825?us… : PS13, Line 8: > It’d be great if you described the problem in more detail. Done https://review.coreboot.org/c/coreboot/+/82425/comment/c042a250_be7a1beb?us… : PS13, Line 14: have been > are Done https://review.coreboot.org/c/coreboot/+/82425/comment/516e56a6_e336382b?us… : PS13, Line 15: Added > Add Done https://review.coreboot.org/c/coreboot/+/82425/comment/d84c8dbd_8e008fb0?us… : PS13, Line 17: Introduced > Introduce Done File src/vendorcode/intel/edk2/edk2-stable202302/IntelFsp2Pkg/Include/FspEas/FspApi.h: https://review.coreboot.org/c/coreboot/+/82425/comment/cc517001_09f69f3f?us… : PS12, Line 257: PLATFORM_USES_FSP2_X86_32 > > as per this CL, FSPM_ARCH2_UPD/FSPS_ARCH2_UPD only enable for PLATFORM_USES_FSP2_X86_64,but that i […] Moved x86_32 specific structures under PLATFORM_USES_FSP2_X86_32 and FSP2.4 specific ones under PLATFORM_USES_FSP2_4 config -- To view, visit https://review.coreboot.org/c/coreboot/+/82425?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Idc849de73723036323f81dfd055730f6669cd52e Gerrit-Change-Number: 82425 Gerrit-PatchSet: 16 Gerrit-Owner: Appukuttan V K <appukuttan.vk(a)intel.com> Gerrit-Reviewer: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-Comment-Date: Fri, 24 May 2024 18:40:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com> Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>

1 0

[XS] Change in coreboot[main]: vc/intel/fsp/mtl: Organize FSP headers into x86_32 directory
by Appukuttan V K (Code Review) 24 May '24

24 May '24

Attention is currently required from: Subrata Banik. Appukuttan V K has posted comments on this change by Appukuttan V K. ( https://review.coreboot.org/c/coreboot/+/82424?usp=email ) Change subject: vc/intel/fsp/mtl: Organize FSP headers into x86_32 directory ...................................................................... Patch Set 11: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/82424/comment/70c27c3f_2ab1acc9?us… : PS10, Line 9: files > please specify the FSP version just for record Done -- To view, visit https://review.coreboot.org/c/coreboot/+/82424?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Id30186a8b1b5a9082f498e18a3378f5e9907b668 Gerrit-Change-Number: 82424 Gerrit-PatchSet: 11 Gerrit-Owner: Appukuttan V K <appukuttan.vk(a)intel.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Jakub Czapiga <czapiga(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun <tstuli(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Comment-Date: Fri, 24 May 2024 18:37:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com>

1 0

[XS] Change in coreboot[main]: vc/intel/fsp/mtl: Organize FSP headers into x86_32 directory
by Appukuttan V K (Code Review) 24 May '24

24 May '24

Attention is currently required from: Appukuttan V K, Dinesh Gehlot, Eran Mitrani, Jakub Czapiga, Kapil Porwal, Ronak Kanabar, Tarun. Hello Angel Pons, Dinesh Gehlot, Eran Mitrani, Jakub Czapiga, Kapil Porwal, Ronak Kanabar, Subrata Banik, Tarun, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/82424?usp=email to look at the new patch set (#11). Change subject: vc/intel/fsp/mtl: Organize FSP headers into x86_32 directory ...................................................................... vc/intel/fsp/mtl: Organize FSP headers into x86_32 directory This commit moves FSP V3471.91 header files for Meteor Lake into a new x86_32 directory to better organize the files based on the architecture. The Kconfig file has been modified accordingly to reflect the new paths of the relocated headers. BUG=b:329034258 TEST=Verified x86_32 and x86_64 builds on Meteor Lake board (Rex) Change-Id: Id30186a8b1b5a9082f498e18a3378f5e9907b668 Signed-off-by: Appukuttan V K <appukuttan.vk(a)intel.com> --- M src/soc/intel/meteorlake/Kconfig R src/vendorcode/intel/fsp/fsp2_0/meteorlake/x86_32/FirmwareVersionInfo.h R src/vendorcode/intel/fsp/fsp2_0/meteorlake/x86_32/FspProducerDataHeader.h R src/vendorcode/intel/fsp/fsp2_0/meteorlake/x86_32/FspUpd.h R src/vendorcode/intel/fsp/fsp2_0/meteorlake/x86_32/FspmUpd.h R src/vendorcode/intel/fsp/fsp2_0/meteorlake/x86_32/FspsUpd.h R src/vendorcode/intel/fsp/fsp2_0/meteorlake/x86_32/MemInfoHob.h 7 files changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/24/82424/11 -- To view, visit https://review.coreboot.org/c/coreboot/+/82424?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Id30186a8b1b5a9082f498e18a3378f5e9907b668 Gerrit-Change-Number: 82424 Gerrit-PatchSet: 11 Gerrit-Owner: Appukuttan V K <appukuttan.vk(a)intel.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Jakub Czapiga <czapiga(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun <tstuli(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Appukuttan V K <appukuttan.vk(a)intel.com> Gerrit-Attention: Eran Mitrani <mitrani(a)google.com> Gerrit-Attention: Jakub Czapiga <czapiga(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-Attention: Tarun <tstuli(a)gmail.com>

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit May 2024