Attention is currently required from: Arthur Heymans, Martin L Roth, Zebreus.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80314?usp=email )
Change subject: util/crossgcc: Update LLVM from 17.0.6 to 18.1.3
......................................................................
Patch Set 13:
(1 comment)
Patchset:
PS12:
> https://review.coreboot.org/c/coreboot/+/81777 should fix the last issue.
It did. Awesome. Thanks!
--
To view, visit https://review.coreboot.org/c/coreboot/+/80314?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I03a44e0c23a925396f614f282882405dc886ba58
Gerrit-Change-Number: 80314
Gerrit-PatchSet: 13
Gerrit-Owner: Zebreus <lennarteichhorn(a)googlemail.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Attention: Zebreus <lennarteichhorn(a)googlemail.com>
Gerrit-Comment-Date: Mon, 08 Apr 2024 15:23:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-MessageType: comment
Attention is currently required from: Arthur Heymans.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81777?usp=email )
Change subject: Makefile.mk: Account for large code model sections in cbfs_struct
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/81777?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ie07779ef548337772183ffe2d642f971d8cceae7
Gerrit-Change-Number: 81777
Gerrit-PatchSet: 2
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Comment-Date: Mon, 08 Apr 2024 15:22:38 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Hung-Te Lin, Ruihai Zhou, Yu-Ping Wu.
Yidi Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81685?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: mb/google/*: Drop unused header file console/console.h
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
@ruihai, do you want to take the chance to drop `console/console.h` in
`src/mainboard/google/geralt/panel_geralt.c`
--
To view, visit https://review.coreboot.org/c/coreboot/+/81685?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: If3689afe532b63384b7905116c44c598e5fa13ee
Gerrit-Change-Number: 81685
Gerrit-PatchSet: 1
Gerrit-Owner: Ruihai Zhou <zhouruihai(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Reviewer: Eric Lai <ericllai(a)google.com>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Reviewer: cong yang <yangcong5(a)huaqin.corp-partner.google.com>
Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Attention: Ruihai Zhou <zhouruihai(a)huaqin.corp-partner.google.com>
Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Comment-Date: Mon, 08 Apr 2024 14:12:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Arthur Heymans.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81777?usp=email )
Change subject: Makefile.mk: Account for large code model sections in cbfs_struct
......................................................................
Patch Set 2:
(1 comment)
File Makefile.mk:
https://review.coreboot.org/c/coreboot/+/81777/comment/cb061d19_b68714c6 :
PS1, Line 371: --set-section-flags .bss*=alloc,contents,load $(2).tmp $(2);
> A backslash is missing at the end of the line
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/81777?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ie07779ef548337772183ffe2d642f971d8cceae7
Gerrit-Change-Number: 81777
Gerrit-PatchSet: 2
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Comment-Date: Mon, 08 Apr 2024 13:46:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-MessageType: comment
Attention is currently required from: Dolan Liu, Eric Lai, Subrata Banik.
Jianeng Ceng has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81773?usp=email )
Change subject: drivers/i2c/rt5645: Add RT5645 amp driver
......................................................................
Patch Set 4:
(5 comments)
File src/drivers/i2c/rt5645/chip.h:
https://review.coreboot.org/c/coreboot/+/81773/comment/8eb474ab_20907869 :
PS2, Line 7: const char *name; /* ACPI _HID */
> `acpi name` in comments
Done
File src/drivers/i2c/rt5645/rt5645.c:
https://review.coreboot.org/c/coreboot/+/81773/comment/c2d0dae7_d9c237be :
PS2, Line 59: acpigen_write_name_string("_DDN", dev->chip_ops->name);
> better to use the `config->desc` if defined
Done
https://review.coreboot.org/c/coreboot/+/81773/comment/15e7d879_4129b913 :
PS2, Line 100: printk(BIOS_INFO, "%s: %s\n", path, dev->chip_ops->name);
> if chip_ops->name change to `&config->desc`, this should be changed to the same
Done
https://review.coreboot.org/c/coreboot/+/81773/comment/3d8c5ee7_a3c5760a :
PS2, Line 110: snprintf(name, sizeof(name), "D%03.3X", dev->chip_ops->name);
> better to print `dev->path.i2c. […]
Done
https://review.coreboot.org/c/coreboot/+/81773/comment/5ccda419_c4582d45 :
PS2, Line 112: //return RT5645_ACPI_NAME;
> remove this
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/81773?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I602fcc4dd8576043943f6e20884edc4703350320
Gerrit-Change-Number: 81773
Gerrit-PatchSet: 4
Gerrit-Owner: Jianeng Ceng <cengjianeng(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Dolan Liu <liuyong5(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Eric Lai <ericllai(a)google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Eric Lai <ericllai(a)google.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Dolan Liu <liuyong5(a)huaqin.corp-partner.google.com>
Gerrit-Comment-Date: Mon, 08 Apr 2024 13:37:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Dolan Liu <liuyong5(a)huaqin.corp-partner.google.com>
Gerrit-MessageType: comment
Attention is currently required from: Dolan Liu, Eric Lai, Jianeng Ceng, Subrata Banik.
Hello Dolan Liu, Eric Lai, Subrata Banik, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/81773?usp=email
to look at the new patch set (#4).
Change subject: drivers/i2c/rt5645: Add RT5645 amp driver
......................................................................
drivers/i2c/rt5645: Add RT5645 amp driver
Add RT5645 AMP support.
Add acpi name cbj-sleeve-gpios for sleeve power gate GPIO.
Realtek upstream link:(https://lore.kernel.org/all/20240404035747.118064-1-derek.fang@realte…
BUG=None
TEST=RT5645 driver can probe properly.
Change-Id: I602fcc4dd8576043943f6e20884edc4703350320
Signed-off-by: Jianeng Ceng <cengjianeng(a)huaqin.corp-partner.google.com>
---
A src/drivers/i2c/rt5645/Kconfig
A src/drivers/i2c/rt5645/Makefile.mk
A src/drivers/i2c/rt5645/chip.h
A src/drivers/i2c/rt5645/rt5645.c
4 files changed, 154 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/73/81773/4
--
To view, visit https://review.coreboot.org/c/coreboot/+/81773?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I602fcc4dd8576043943f6e20884edc4703350320
Gerrit-Change-Number: 81773
Gerrit-PatchSet: 4
Gerrit-Owner: Jianeng Ceng <cengjianeng(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Dolan Liu <liuyong5(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Eric Lai <ericllai(a)google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Eric Lai <ericllai(a)google.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Dolan Liu <liuyong5(a)huaqin.corp-partner.google.com>
Gerrit-Attention: Jianeng Ceng <cengjianeng(a)huaqin.corp-partner.google.com>
Gerrit-MessageType: newpatchset