coreboot-gerrit April 2024

coreboot-gerrit@coreboot.org

1 participants
3293 discussions

[S] Change in coreboot[main]: drivers/intel/fsp2_0: Support FSP 2.4 64-bits
by Appukuttan V K (Code Review) 08 Apr '24

08 Apr '24

Attention is currently required from: Andrey Petrov, Appukuttan V K, Arthur Heymans, Bora Guvendik, Christian Walter, Felix Held, Fred Reitberger, Jason Glenesk, Johnny Lin, Jérémy Compostella, Matt DeVillier, Patrick Rudolph, Paul Menzel, Ronak Kanabar, Shuo Liu, Subrata Banik, Tim Chu, Wonkyu Kim. Appukuttan V K has uploaded a new patch set (#37) to the change originally created by Jérémy Compostella. ( https://review.coreboot.org/c/coreboot/+/80277?usp=email ) Change subject: drivers/intel/fsp2_0: Support FSP 2.4 64-bits ...................................................................... drivers/intel/fsp2_0: Support FSP 2.4 64-bits FSP 2.4 brings FSP 64-bits support which requires some adjustments in coreboot: FSP/UEFI uses the Microsoft x64 calling convention. Appropriate attribute has to be set to all functions calling or called by the FSP. BUG=b:329034258 TEST=verified on Lunar Lake RVP board (lnlrvp) Change-Id: If0397f5cc8d0f4f1872bd37a001fe42e0c37ec99 Signed-off-by: Jeremy Compostella <jeremy.compostella(a)intel.com> --- M src/drivers/intel/fsp2_0/include/fsp/util.h M src/drivers/intel/fsp2_0/ppi/mp_service1.c M src/drivers/intel/fsp2_0/ppi/mp_service2.c M src/include/efi/efi_datatype.h 4 files changed, 23 insertions(+), 21 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/77/80277/37 -- To view, visit https://review.coreboot.org/c/coreboot/+/80277?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: If0397f5cc8d0f4f1872bd37a001fe42e0c37ec99 Gerrit-Change-Number: 80277 Gerrit-PatchSet: 37 Gerrit-Owner: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-Reviewer: Shuo Liu <shuo.liu(a)intel.com> Gerrit-Reviewer: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Reviewer: Wonkyu Kim <wonkyu.kim(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Appukuttan V K <appukuttan.vk(a)intel.com> Gerrit-CC: Ashish Kumar Mishra <ashish.k.mishra(a)intel.com> Gerrit-CC: Dinesh Gehlot <digehlot(a)google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Attention: Wonkyu Kim <wonkyu.kim(a)intel.com> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Attention: Appukuttan V K <appukuttan.vk(a)intel.com> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Shuo Liu <shuo.liu(a)intel.com> Gerrit-Attention: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Attention: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-MessageType: newpatchset

1 0

[M] Change in coreboot[master]: acpi: Helper functions to add certain _DSD properties
by Elyes Haouas (Code Review) 08 Apr '24

08 Apr '24

Elyes Haouas has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70063?usp=email ) Change subject: acpi: Helper functions to add certain _DSD properties ...................................................................... Patch Set 11: (1 comment) Patchset: PS11: -fanalyzer gives me: `src/acpi/device.c:1232:1: error: leak of '<unknown>' [CWE-401] [-Werror=analyzer-malloc-leak] 1232 | } | ^ 'acpi_device_add_integer_property_with_uuid': events 1-4 | | 1219 | static void acpi_device_add_integer_property_with_uuid(struct acpi_dp *dsd, | | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | | | | | (1) entry to 'acpi_device_add_integer_property_with_uuid' |...... | 1225 | if (prev_dsd == NULL) | | ~ | | | | | (2) following 'false' branch (when 'dsd' is non-NULL)... | 1226 | dsd = acpi_dp_new_table("_DSD"); | 1227 | pkg = acpi_dp_new_table(uuid); | | ~~~~~~~~~~~~~~~~~~~~~~~ | | | | | (3) ...to here | | (4) calling 'acpi_dp_new_table' from 'acpi_device_add_integer_property_with_uuid' | +--> 'acpi_dp_new_table': events 5-6 | | 953 | struct acpi_dp *acpi_dp_new_table(const char *name) | | ^~~~~~~~~~~~~~~~~ | | | | | (5) entry to 'acpi_dp_new_table' | 954 | { | 955 | return acpi_dp_new(NULL, ACPI_DP_TYPE_TABLE, name); | | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | | | | | (6) calling 'acpi_dp_new' from 'acpi_dp_new_table' | +--> 'acpi_dp_new': events 7-10 | | 929 | static struct acpi_dp *acpi_dp_new(struct acpi_dp *dp, enum acpi_dp_type type, | | ^~~~~~~~~~~ | | | | | (7) entry to 'acpi_dp_new' |...... | 935 | if (!new) | | ~ | | | | | (8) following 'false' branch (when 'new' is non-NULL)... |...... | 938 | memset(new, 0, sizeof(*new)); | | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | | | | | (9) ...to here |...... | 943 | if (dp) { | | ~ | | | | | (10) following 'false' branch (when 'dp' is NULL)... | 'acpi_dp_new': event 11 | |cc1: | (11): ...to here | <------+ | 'acpi_dp_new_table': event 12 | | 955 | return acpi_dp_new(NULL, ACPI_DP_TYPE_TABLE, name); | | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | | | | | (12) returning to 'acpi_dp_new_table' from 'acpi_dp_new' | <------+ | 'acpi_device_add_integer_property_with_uuid': events 13-14 | | 1227 | pkg = acpi_dp_new_table(uuid); | | ^~~~~~~~~~~~~~~~~~~~~~~ | | | | | (13) returning to 'acpi_device_add_integer_property_with_uuid' from 'acpi_dp_new_table' | 1228 | acpi_dp_add_integer(pkg, name, value); | | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | | | | | (14) calling 'acpi_dp_add_integer' from 'acpi_device_add_integer_property_with_uuid' | +--> 'acpi_dp_add_integer': events 15-18 | | 1000 | struct acpi_dp *acpi_dp_add_integer(struct acpi_dp *dp, const char *name, | | ^~~~~~~~~~~~~~~~~~~ | | | | | (15) entry to 'acpi_dp_add_integer' |...... | 1003 | if (!dp) | | ~ | | | | | (16) following 'false' branch (when 'dp' is non-NULL)... |...... | 1006 | struct acpi_dp *new = acpi_dp_new(dp, ACPI_DP_TYPE_INTEGER, name); | | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | | | | | (17) ...to here | | (18) calling 'acpi_dp_new' from 'acpi_dp_add_integer' | +--> 'acpi_dp_new': events 19-24 | | 929 | static struct acpi_dp *acpi_dp_new(struct acpi_dp *dp, enum acpi_dp_type type, | | ^~~~~~~~~~~ | | | | | (19) entry to 'acpi_dp_new' |...... | 934 | new = malloc(sizeof(struct acpi_dp)); | | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | | | | | (20) allocated here | 935 | if (!new) | | ~ | | | | | (21) assuming 'new' is non-NULL | | (22) following 'false' branch (when 'new' is non-NULL)... |...... | 938 | memset(new, 0, sizeof(*new)); | | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | | | | | (23) ...to here |...... | 943 | if (dp) { | | ~ | | | | | (24) following 'true' branch (when 'dp' is non-NULL)... | 'acpi_dp_new': event 25 | |cc1: | (25): ...to here | 'acpi_dp_new': events 26-27 | | 945 | while (dp->next) | | ^~ | | | | | (26) following 'false' branch... | 946 | dp = dp->next; | 947 | dp->next = new; | | ~~~~~~~~~~~~~~ | | | | | (27) ...to here | <------+ | 'acpi_dp_add_integer': events 28-30 | | 1006 | struct acpi_dp *new = acpi_dp_new(dp, ACPI_DP_TYPE_INTEGER, name); | | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | | | | | (28) returning to 'acpi_dp_add_integer' from 'acpi_dp_new' | 1007 | | 1008 | if (new) | | ~ | | | | | (29) following 'true' branch (when 'new' is non-NULL)... | 1009 | new->integer = value; | | ~~~~~~~~~~~~~~~~~~~~ | | | | | (30) ...to here | <------+ | 'acpi_device_add_integer_property_with_uuid': events 31-32 | | 1228 | acpi_dp_add_integer(pkg, name, value); | | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | | | | | (31) returning to 'acpi_device_add_integer_property_with_uuid' from 'acpi_dp_add_integer' | 1229 | acpi_dp_add_package(dsd, pkg); | | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | | | | | (32) calling 'acpi_dp_add_package' from 'acpi_device_add_integer_property_with_uuid' | +--> 'acpi_dp_add_package': events 33-34 | | 1059 | struct acpi_dp *acpi_dp_add_package(struct acpi_dp *dp, struct acpi_dp *package) | | ^~~~~~~~~~~~~~~~~~~ | | | | | (33) entry to 'acpi_dp_add_package' |...... | 1063 | if (!dp || !package || package->type != ACPI_DP_TYPE_TABLE) | | ~ | | | | | (34) following 'false' branch... | 'acpi_dp_add_package': event 35 | |cc1: | (35): ...to here | 'acpi_dp_add_package': event 36 | |cc1: | (36): calling 'acpi_dp_add_package.part.0' from 'acpi_dp_add_package' | +--> 'acpi_dp_add_package.part.0': events 37-38 | | 1059 | struct acpi_dp *acpi_dp_add_package(struct acpi_dp *dp, struct acpi_dp *package) | | ^~~~~~~~~~~~~~~~~~~ | | | | | (37) entry to 'acpi_dp_add_package.part.0' |...... | 1066 | new = acpi_dp_new(dp, ACPI_DP_TYPE_PACKAGE, NULL); | | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | | | | | (38) calling 'acpi_dp_new' from 'acpi_dp_add_package.part.0' | +--> 'acpi_dp_new': events 39-40 | | 929 | static struct acpi_dp *acpi_dp_new(struct acpi_dp *dp, enum acpi_dp_type type, | | ^~~~~~~~~~~ | | | | | (39) entry to 'acpi_dp_new' |...... | 935 | if (!new) | | ~ | | | | | (40) following 'true' branch (when 'new' is NULL)... | 'acpi_dp_new': event 41 | |cc1: | (41): ...to here | <------+ | 'acpi_dp_add_package.part.0': events 42-43 | | 1066 | new = acpi_dp_new(dp, ACPI_DP_TYPE_PACKAGE, NULL); | | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | | | | | (42) returning to 'acpi_dp_add_package.part.0' from 'acpi_dp_new' | 1067 | if (new) { | | ~ | | | | | (43) following 'false' branch (when 'new' is NULL)... | 'acpi_dp_add_package.part.0': event 44 | |cc1: | (44): ...to here | <------+ | 'acpi_dp_add_package': event 45 | |cc1: | (45): returning to 'acpi_dp_add_package' from 'acpi_dp_add_package.part.0' | <------+ | 'acpi_device_add_integer_property_with_uuid': events 46-49 | | 1229 | acpi_dp_add_package(dsd, pkg); | | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | | | | | (46) returning to 'acpi_device_add_integer_property_with_uuid' from 'acpi_dp_add_package' | 1230 | if (prev_dsd == NULL) | | ~ | | | | | (47) following 'false' branch (when 'dsd' is non-NULL)... | 1231 | acpi_dp_write(dsd); | 1232 | } | | ~ | | | | | (48) ...to here | | (49) '<unknown>' leaks here; was allocated at (20) | cc1: all warnings being treated as errors make: *** [Makefile:419 : build/ramstage/acpi/device.o] Erreur 1 ` -- To view, visit https://review.coreboot.org/c/coreboot/+/70063?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5bb432dd4e8f320d2c0d7f378dc2d7b3a770b541 Gerrit-Change-Number: 70063 Gerrit-PatchSet: 11 Gerrit-Owner: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Comment-Date: Mon, 08 Apr 2024 16:51:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: util/crossgcc: Update LLVM from 17.0.6 to 18.1.3
by Felix Singer (Code Review) 08 Apr '24

08 Apr '24

Attention is currently required from: Arthur Heymans, Martin L Roth, Zebreus. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80314?usp=email ) Change subject: util/crossgcc: Update LLVM from 17.0.6 to 18.1.3 ...................................................................... Patch Set 13: (1 comment) Patchset: PS12: > https://review.coreboot.org/c/coreboot/+/81777 should fix the last issue. It did. Awesome. Thanks! -- To view, visit https://review.coreboot.org/c/coreboot/+/80314?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I03a44e0c23a925396f614f282882405dc886ba58 Gerrit-Change-Number: 80314 Gerrit-PatchSet: 13 Gerrit-Owner: Zebreus <lennarteichhorn(a)googlemail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Zebreus <lennarteichhorn(a)googlemail.com> Gerrit-Comment-Date: Mon, 08 Apr 2024 15:23:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: Makefile.mk: Account for large code model sections in cbfs_struct
by Felix Singer (Code Review) 08 Apr '24

08 Apr '24

Attention is currently required from: Arthur Heymans. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81777?usp=email ) Change subject: Makefile.mk: Account for large code model sections in cbfs_struct ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/81777?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ie07779ef548337772183ffe2d642f971d8cceae7 Gerrit-Change-Number: 81777 Gerrit-PatchSet: 2 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Mon, 08 Apr 2024 15:22:38 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: mb/google/corsola: Add new board Skitty
by Yidi Lin (Code Review) 08 Apr '24

08 Apr '24

Attention is currently required from: Herbert Wu, Hung-Te Lin, Shawn Ku, Yu-Ping Wu. Yidi Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81772?usp=email ) Change subject: mb/google/corsola: Add new board Skitty ...................................................................... Patch Set 2: (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/81772/comment/1a349abe_92bfeecf : PS2, Line 7: mb/google/corsola: Add new board Skitty : : Add a new board 'Skitty' : : BUG=b:331702790 : BRANCH=corsola : TEST=none please follow the format of CB:81585 File src/mainboard/google/corsola/Kconfig: https://review.coreboot.org/c/coreboot/+/81772/comment/2e9b1fb7_63709b5e : PS2, Line 54: select DRIVER_ANALOGIX_ANX7625 if BOARD_GOOGLE_CHINCHOU || \ : BOARD_GOOGLE_KINGLER || \ : BOARD_GOOGLE_KYOGRE || \ : BOARD_GOOGLE_PONYTA || \ : BOARD_GOOGLE_STEELIX || \ : BOARD_GOOGLE_VOLTORB : select DRIVER_PARADE_PS8640 if BOARD_GOOGLE_KRABBY || \ : BOARD_GOOGLE_MAGIKARP || \ : BOARD_GOOGLE_STEELIX || \ : BOARD_GOOGLE_TENTACRUEL : select RTC : select FW_CONFIG : select FW_CONFIG_SOURCE_CHROMEEC_CBI : select MIPI_PANEL_KD_KD101NE3_40TI if BOARD_GOOGLE_WUGTRIO : select MIPI_PANEL_STA_HIMAX83102_J02 if BOARD_GOOGLE_STARMIE : select MIPI_PANEL_STA_ILI9882T if BOARD_GOOGLE_STARMIE Please either select eDP config `DRIVER_ANALOGIX_ANX7625` / `DRIVER_PARADE_PS8640` or implement `get_panel_description()` to fix the build error. -- To view, visit https://review.coreboot.org/c/coreboot/+/81772?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I2f12bccfda591a5baf8d23d217b6f1f81b059d15 Gerrit-Change-Number: 81772 Gerrit-PatchSet: 2 Gerrit-Owner: Herbert Wu <herbert1_wu(a)pegatron.corp-partner.google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Shawn Ku <shawnku(a)chromium.org> Gerrit-Reviewer: Shawn Ku <shawnku(a)google.com> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Herbert Wu <herbert1_wu(a)pegatron.corp-partner.google.com> Gerrit-Attention: Shawn Ku <shawnku(a)chromium.org> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Comment-Date: Mon, 08 Apr 2024 14:27:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: mb/google/*: Drop unused header file console/console.h
by Yidi Lin (Code Review) 08 Apr '24

08 Apr '24

Attention is currently required from: Hung-Te Lin, Ruihai Zhou, Yu-Ping Wu. Yidi Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81685?usp=email ) The change is no longer submittable: All-Comments-Resolved is unsatisfied now. Change subject: mb/google/*: Drop unused header file console/console.h ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: @ruihai, do you want to take the chance to drop `console/console.h` in `src/mainboard/google/geralt/panel_geralt.c` -- To view, visit https://review.coreboot.org/c/coreboot/+/81685?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: If3689afe532b63384b7905116c44c598e5fa13ee Gerrit-Change-Number: 81685 Gerrit-PatchSet: 1 Gerrit-Owner: Ruihai Zhou <zhouruihai(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: cong yang <yangcong5(a)huaqin.corp-partner.google.com> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Ruihai Zhou <zhouruihai(a)huaqin.corp-partner.google.com> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Comment-Date: Mon, 08 Apr 2024 14:12:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: mb/google/corsola: Set orientation to LB_FB_ORIENTATION_RIGHT_UP
by Yidi Lin (Code Review) 08 Apr '24

08 Apr '24

Attention is currently required from: Hung-Te Lin, Xuxin Xiong, Yang Wu, Yu-Ping Wu. Yidi Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81752?usp=email ) Change subject: mb/google/corsola: Set orientation to LB_FB_ORIENTATION_RIGHT_UP ...................................................................... Patch Set 3: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/81752/comment/cddfd3c8_ee1a8c2e : PS3, Line 7: mb/google/corsola mb/google/corsola/var/staryu -- To view, visit https://review.coreboot.org/c/coreboot/+/81752?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ie101cc8b983d3d16587f88fa787ed622e59d27eb Gerrit-Change-Number: 81752 Gerrit-PatchSet: 3 Gerrit-Owner: Yang Wu <wuyang5(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Ruihai Zhou <zhouruihai(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Xuxin Xiong <xuxinxiong(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Xuxin Xiong <xuxinxiong(a)huaqin.corp-partner.google.com> Gerrit-Attention: Yang Wu <wuyang5(a)huaqin.corp-partner.google.com> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Comment-Date: Mon, 08 Apr 2024 14:09:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: Makefile.mk: Account for large code model sections in cbfs_struct
by Felix Singer (Code Review) 08 Apr '24

08 Apr '24

Attention is currently required from: Arthur Heymans. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81777?usp=email ) Change subject: Makefile.mk: Account for large code model sections in cbfs_struct ...................................................................... Patch Set 2: (1 comment) File Makefile.mk: https://review.coreboot.org/c/coreboot/+/81777/comment/cb061d19_b68714c6 : PS1, Line 371: --set-section-flags .bss*=alloc,contents,load $(2).tmp $(2); > A backslash is missing at the end of the line Done -- To view, visit https://review.coreboot.org/c/coreboot/+/81777?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ie07779ef548337772183ffe2d642f971d8cceae7 Gerrit-Change-Number: 81777 Gerrit-PatchSet: 2 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Mon, 08 Apr 2024 13:46:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-MessageType: comment

1 0

[M] Change in coreboot[main]: [Test-only]
by Jianeng Ceng (Code Review) 08 Apr '24

08 Apr '24

Jianeng Ceng has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/81660?usp=email ) Change subject: [Test-only] ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/c/coreboot/+/81660?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I0e25863e720f247bc2813e40e29dcbb984973084 Gerrit-Change-Number: 81660 Gerrit-PatchSet: 1 Gerrit-Owner: Jianeng Ceng <cengjianeng(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: abandon

1 0

[M] Change in coreboot[main]: drivers/i2c/rt5645: Add RT5645 amp driver
by Jianeng Ceng (Code Review) 08 Apr '24

08 Apr '24

Attention is currently required from: Dolan Liu, Eric Lai, Subrata Banik. Jianeng Ceng has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81773?usp=email ) Change subject: drivers/i2c/rt5645: Add RT5645 amp driver ...................................................................... Patch Set 4: (5 comments) File src/drivers/i2c/rt5645/chip.h: https://review.coreboot.org/c/coreboot/+/81773/comment/8eb474ab_20907869 : PS2, Line 7: const char *name; /* ACPI _HID */ > `acpi name` in comments Done File src/drivers/i2c/rt5645/rt5645.c: https://review.coreboot.org/c/coreboot/+/81773/comment/c2d0dae7_d9c237be : PS2, Line 59: acpigen_write_name_string("_DDN", dev->chip_ops->name); > better to use the `config->desc` if defined Done https://review.coreboot.org/c/coreboot/+/81773/comment/15e7d879_4129b913 : PS2, Line 100: printk(BIOS_INFO, "%s: %s\n", path, dev->chip_ops->name); > if chip_ops->name change to `&config->desc`, this should be changed to the same Done https://review.coreboot.org/c/coreboot/+/81773/comment/3d8c5ee7_a3c5760a : PS2, Line 110: snprintf(name, sizeof(name), "D%03.3X", dev->chip_ops->name); > better to print `dev->path.i2c. […] Done https://review.coreboot.org/c/coreboot/+/81773/comment/5ccda419_c4582d45 : PS2, Line 112: //return RT5645_ACPI_NAME; > remove this Done -- To view, visit https://review.coreboot.org/c/coreboot/+/81773?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I602fcc4dd8576043943f6e20884edc4703350320 Gerrit-Change-Number: 81773 Gerrit-PatchSet: 4 Gerrit-Owner: Jianeng Ceng <cengjianeng(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Dolan Liu <liuyong5(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Eric Lai <ericllai(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Dolan Liu <liuyong5(a)huaqin.corp-partner.google.com> Gerrit-Comment-Date: Mon, 08 Apr 2024 13:37:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Dolan Liu <liuyong5(a)huaqin.corp-partner.google.com> Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit April 2024