coreboot-gerrit April 2024

coreboot-gerrit@coreboot.org

1 participants
3293 discussions

[XS] Change in coreboot[main]: mb/google/brox: Update verb table to fix headset detection
by Shelley Chen (Code Review) 08 Apr '24

08 Apr '24

Attention is currently required from: Paul Menzel, Poornima Tom, Terry Cheong, Vamshi Krishna Gopal. Shelley Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81654?usp=email ) Change subject: mb/google/brox: Update verb table to fix headset detection ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/81654?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I71b7d59b3ab5310a0b6cdb31fb5033f94263d151 Gerrit-Change-Number: 81654 Gerrit-PatchSet: 3 Gerrit-Owner: Poornima Tom <poornima.tom(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: Terry Cheong <htcheong(a)google.com> Gerrit-Reviewer: Vamshi Krishna Gopal <vamshi.krishna.gopal(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Poornima Tom <poornima.tom(a)intel.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Vamshi Krishna Gopal <vamshi.krishna.gopal(a)intel.com> Gerrit-Attention: Terry Cheong <htcheong(a)google.com> Gerrit-Comment-Date: Mon, 08 Apr 2024 20:42:36 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: soc/intel/alderlake: Support missing CLKREQ workaround on RaptorLake FSP
by Benjamin Doron (Code Review) 08 Apr '24

08 Apr '24

Benjamin Doron has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/81803?usp=email ) Change subject: soc/intel/alderlake: Support missing CLKREQ workaround on RaptorLake FSP ...................................................................... soc/intel/alderlake: Support missing CLKREQ workaround on RaptorLake FSP IoT variants of the RaptorLake FSP support the `PchPciePowerGating` and `PchPcieClockGating` UPDs, so, remove the preprocessor check that only enabled it for AlderLake FSPs. Change-Id: I583a4b257b72f992fdb6390d00e187d04a749177 Signed-off-by: Benjamin Doron <benjamin.doron(a)9elements.com> --- M src/soc/intel/alderlake/fsp_params.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/03/81803/1 diff --git a/src/soc/intel/alderlake/fsp_params.c b/src/soc/intel/alderlake/fsp_params.c index 33ebee3..ff5c83c 100644 --- a/src/soc/intel/alderlake/fsp_params.c +++ b/src/soc/intel/alderlake/fsp_params.c @@ -932,7 +932,7 @@ } s_cfg->PcieComplianceTestMode = CONFIG(SOC_INTEL_COMPLIANCE_TEST_MODE); -#if CONFIG(FSP_TYPE_IOT) && !CONFIG(SOC_INTEL_RAPTORLAKE) +#if CONFIG(FSP_TYPE_IOT) /* * Intel requires that all enabled PCH PCIe ports have a CLK_REQ signal connected. * The CLK_REQ is used to wake the silicon when link entered L1 link-state. L1 -- To view, visit https://review.coreboot.org/c/coreboot/+/81803?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I583a4b257b72f992fdb6390d00e187d04a749177 Gerrit-Change-Number: 81803 Gerrit-PatchSet: 1 Gerrit-Owner: Benjamin Doron <benjamin.doron00(a)gmail.com> Gerrit-MessageType: newchange

1 0

[M] Change in coreboot[main]: [TEST][W/A for MTL Build]: Changes for MTL x64 Build
by Appukuttan V K (Code Review) 08 Apr '24

08 Apr '24

Attention is currently required from: Ashish Kumar Mishra, Dinesh Gehlot, Krishna P Bhat D, Ronak Kanabar, Saurabh Mishra, Subrata Banik. Appukuttan V K has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80339?usp=email ) Change subject: [TEST][W/A for MTL Build]: Changes for MTL x64 Build ...................................................................... Patch Set 18: (16 comments) File src/commonlib/fsp_relocate.c: https://review.coreboot.org/c/coreboot/+/80339/comment/50b64638_de4859cd : PS12, Line 16: #include <vendorcode/intel/fsp/fsp1_1/IntelFspPkg/Include/FspInfoHeader.h> > need to use a config like FSP 1_1 to choose the correct header file between FSP 1_1 and going forwar […] Done File src/drivers/mrc_cache/Kconfig: https://review.coreboot.org/c/coreboot/+/80339/comment/295843c2_8ea3f8de : PS1, Line 57: default n if UDK_VERSION >= 202302 > This line is redundant when set to 'n', as next line does the same. Done File src/mainboard/google/rex/Kconfig: https://review.coreboot.org/c/coreboot/+/80339/comment/ce658583_531f987c : PS12, Line 34: select FSP_FULL_FD : select ADD_FSP_BINARIES > don't need It not including the correct FSP binaries if this is not used. https://review.coreboot.org/c/coreboot/+/80339/comment/9221c3b0_aa7327cd : PS12, Line 247: config FSP_FD_PATH : string : depends on FSP_USE_REPO : default "3rdparty/fsp/MeteorLakeFspBinPkg/Fsp.fd" > unable to follow the motivation of migrating this config from SoC to mainboard ? Moved to SOC config. File src/soc/intel/meteorlake/Kconfig: https://review.coreboot.org/c/coreboot/+/80339/comment/7783e775_41521e57 : PS12, Line 23: #select FSP_USES_CB_DEBUG_EVENT_HANDLER > u can un-comment this config after making below changes […] Done https://review.coreboot.org/c/coreboot/+/80339/comment/a5226610_b0e7135a : PS12, Line 41: # select MRC_CACHE_USING_MRC_VERSION > do you know the reason for commenting this Kconfig. […] FspProducerDataHeader.h header is missing in the used fsp collaterals. Commented to bypass build error. https://review.coreboot.org/c/coreboot/+/80339/comment/14819157_81c37cac : PS12, Line 109: select ARCH_ALL_STAGES_X86_64 > u don't need this, auto selected by USE_EXP_X86_64_SUPPORT config Acknowledged https://review.coreboot.org/c/coreboot/+/80339/comment/8a62c894_1b1ef60c : PS12, Line 112: select HAVE_INTEL_FSP_REPO > don't need Done https://review.coreboot.org/c/coreboot/+/80339/comment/4404f008_0cea21f1 : PS12, Line 113: select FSP_USES_CB_STACK > any idea why is this even needed ? […] Acknowledged File src/soc/intel/meteorlake/fsp_params.c: https://review.coreboot.org/c/coreboot/+/80339/comment/4f2a411a_0a870e40 : PS1, Line 398: s_cfg->CpuMpPpi = (uintptr_t)NULL;//mp_fill_ppi_services_data(); > Please remove the extra comment at end of line. Done https://review.coreboot.org/c/coreboot/+/80339/comment/92e5a6c8_cabfb6b6 : PS1, Line 711: //s_arch_cfg->EnableMultiPhaseSiliconInit = 1; > If we're not using MP stage 1 better remove this line or put in a conditional if/else. Done File src/soc/intel/meteorlake/fsp_params.c: https://review.coreboot.org/c/coreboot/+/80339/comment/da2db028_8dd41cc9 : PS12, Line 716: s_arch_cfg->FspEventHandler = (uintptr_t)(FSP_EVENT_HANDLER) : fsp_debug_event_handler; > ```suggestion […] Done https://review.coreboot.org/c/coreboot/+/80339/comment/5d3dfd1e_13ca66f4 : PS12, Line 876: #if 0 > don't need https://b.corp.google. […] Done File src/soc/intel/meteorlake/meminit.c: https://review.coreboot.org/c/coreboot/+/80339/comment/fc8e7d35_ec2defe6 : PS12, Line 80: uint64_t > uintptr_t Getting build error if changed to uintptr_t https://review.coreboot.org/c/coreboot/+/80339/comment/4e263861_35fbf941 : PS12, Line 109: uint64_t > uintptr_t Getting build error if changed to uintptr_t File src/soc/intel/meteorlake/romstage/fsp_params.c: https://review.coreboot.org/c/coreboot/+/80339/comment/f763137c_2dc0881f : PS12, Line 506: arch_upd->FspEventHandler = (uintptr_t)((FSP_EVENT_HANDLER *) : fsp_debug_event_handler); > ``` […] Done -- To view, visit https://review.coreboot.org/c/coreboot/+/80339?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I0068ce99af7be937132c152293b7a670be7646ab Gerrit-Change-Number: 80339 Gerrit-PatchSet: 18 Gerrit-Owner: Appukuttan V K <appukuttan.vk(a)intel.com> Gerrit-Reviewer: Ashish Kumar Mishra <ashish.k.mishra(a)intel.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Krishna P Bhat D <krishna.p.bhat.d(a)intel.com> Gerrit-Reviewer: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-Reviewer: Saurabh Mishra <mishra.saurabh(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Sanju Jose Thottan <sanjujose.thottan(a)intel.com> Gerrit-CC: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Ashish Kumar Mishra <ashish.k.mishra(a)intel.com> Gerrit-Attention: Saurabh Mishra <mishra.saurabh(a)intel.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Krishna P Bhat D <krishna.p.bhat.d(a)intel.com> Gerrit-Attention: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-Comment-Date: Mon, 08 Apr 2024 17:42:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Ashish Kumar Mishra <ashish.k.mishra(a)intel.com> Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com> Gerrit-MessageType: comment

1 0

[M] Change in coreboot[main]: [TEST][W/A for MTL Build]: Changes for MTL x64 Build
by Appukuttan V K (Code Review) 08 Apr '24

08 Apr '24

Attention is currently required from: Appukuttan V K, Ashish Kumar Mishra, Kilari Raasi, Krishna P Bhat D, Ronak Kanabar, Saurabh Mishra, V Sowmya. Appukuttan V K has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80339?usp=email ) Change subject: [TEST][W/A for MTL Build]: Changes for MTL x64 Build ...................................................................... Set Ready For Review -- To view, visit https://review.coreboot.org/c/coreboot/+/80339?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I0068ce99af7be937132c152293b7a670be7646ab Gerrit-Change-Number: 80339 Gerrit-PatchSet: 18 Gerrit-Owner: Appukuttan V K <appukuttan.vk(a)intel.com> Gerrit-Reviewer: Ashish Kumar Mishra <ashish.k.mishra(a)intel.com> Gerrit-Reviewer: Kilari Raasi <kilari.raasi(a)intel.com> Gerrit-Reviewer: Krishna P Bhat D <krishna.p.bhat.d(a)intel.com> Gerrit-Reviewer: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-Reviewer: Saurabh Mishra <mishra.saurabh(a)intel.com> Gerrit-Reviewer: V Sowmya <v.sowmya(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Sanju Jose Thottan <sanjujose.thottan(a)intel.com> Gerrit-CC: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: V Sowmya <v.sowmya(a)intel.com> Gerrit-Attention: Appukuttan V K <appukuttan.vk(a)intel.com> Gerrit-Attention: Ashish Kumar Mishra <ashish.k.mishra(a)intel.com> Gerrit-Attention: Saurabh Mishra <mishra.saurabh(a)intel.com> Gerrit-Attention: Kilari Raasi <kilari.raasi(a)intel.com> Gerrit-Attention: Krishna P Bhat D <krishna.p.bhat.d(a)intel.com> Gerrit-Attention: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-Comment-Date: Mon, 08 Apr 2024 17:41:38 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: drivers/intel/fsp2_0: Support FSP 2.4 64-bits
by Subrata Banik (Code Review) 08 Apr '24

08 Apr '24

Attention is currently required from: Andrey Petrov, Appukuttan V K, Arthur Heymans, Bora Guvendik, Christian Walter, Felix Held, Fred Reitberger, Jason Glenesk, Johnny Lin, Jérémy Compostella, Matt DeVillier, Patrick Rudolph, Paul Menzel, Ronak Kanabar, Shuo Liu, Tim Chu, Wonkyu Kim. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80277?usp=email ) Change subject: drivers/intel/fsp2_0: Support FSP 2.4 64-bits ...................................................................... Patch Set 37: (1 comment) File src/include/efi/efi_datatype.h: https://review.coreboot.org/c/coreboot/+/80277/comment/bdae80cd_30e09da9 : PS30, Line 19: #define EFIAPI __attribute__((__ms_abi__)) > Added to EDK2 headers and tried. It is working fine. https://review.coreboot.org/c/coreboot/+/81775/1 can you please file a EDK2/FSP bug to add the required changes under GCC section as part of future EDK2 release. -- To view, visit https://review.coreboot.org/c/coreboot/+/80277?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: If0397f5cc8d0f4f1872bd37a001fe42e0c37ec99 Gerrit-Change-Number: 80277 Gerrit-PatchSet: 37 Gerrit-Owner: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-Reviewer: Shuo Liu <shuo.liu(a)intel.com> Gerrit-Reviewer: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Reviewer: Wonkyu Kim <wonkyu.kim(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Appukuttan V K <appukuttan.vk(a)intel.com> Gerrit-CC: Ashish Kumar Mishra <ashish.k.mishra(a)intel.com> Gerrit-CC: Dinesh Gehlot <digehlot(a)google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Attention: Wonkyu Kim <wonkyu.kim(a)intel.com> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Attention: Appukuttan V K <appukuttan.vk(a)intel.com> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Shuo Liu <shuo.liu(a)intel.com> Gerrit-Attention: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Attention: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Comment-Date: Mon, 08 Apr 2024 17:41:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Appukuttan V K <appukuttan.vk(a)intel.com> Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com> Gerrit-MessageType: comment

1 0

[M] Change in coreboot[main]: mb/google/brya: Create trulo variant
by Subrata Banik (Code Review) 08 Apr '24

08 Apr '24

Attention is currently required from: Dinesh Gehlot, Kapil Porwal, Nick Vaccaro, Sumeet R Pawnikar, Varshit Pandya. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81627?usp=email ) Change subject: mb/google/brya: Create trulo variant ...................................................................... Patch Set 17: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/81627?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I91157d252ef56c8938bfc08ed0f734c5dc7e614d Gerrit-Change-Number: 81627 Gerrit-PatchSet: 17 Gerrit-Owner: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Varshit Pandya <pandyavarshit(a)gmail.com> Gerrit-Attention: Varshit Pandya <pandyavarshit(a)gmail.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Comment-Date: Mon, 08 Apr 2024 17:39:09 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in coreboot[main]: mb/google/brya: Add new baseboard trulo
by Subrata Banik (Code Review) 08 Apr '24

08 Apr '24

Attention is currently required from: Dinesh Gehlot, Kapil Porwal, Nick Vaccaro, Sumeet R Pawnikar, Varshit Pandya. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81626?usp=email ) Change subject: mb/google/brya: Add new baseboard trulo ...................................................................... Patch Set 15: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/81626?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Iad6230064c6b8359698d37c3e0440614cc7b073d Gerrit-Change-Number: 81626 Gerrit-PatchSet: 15 Gerrit-Owner: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Reviewer: Varshit Pandya <pandyavarshit(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Varshit Pandya <pandyavarshit(a)gmail.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Comment-Date: Mon, 08 Apr 2024 17:39:04 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in coreboot[main]: mb/google/brya: Remove baseboard-specific FMD names
by Subrata Banik (Code Review) 08 Apr '24

08 Apr '24

Attention is currently required from: Dinesh Gehlot, Kapil Porwal, Nick Vaccaro, Sumeet R Pawnikar. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81676?usp=email ) Change subject: mb/google/brya: Remove baseboard-specific FMD names ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/81676?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I9151a4bcbe9cc084cc19b1a3e91c0321fe4dcc37 Gerrit-Change-Number: 81676 Gerrit-PatchSet: 4 Gerrit-Owner: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Comment-Date: Mon, 08 Apr 2024 17:38:59 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in coreboot[main]: mb/google/brya: Remove baseboard-specific FMD names
by Dinesh Gehlot (Code Review) 08 Apr '24

08 Apr '24

Attention is currently required from: Kapil Porwal, Nick Vaccaro, Subrata Banik, Sumeet R Pawnikar. Dinesh Gehlot has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81676?usp=email ) Change subject: mb/google/brya: Remove baseboard-specific FMD names ...................................................................... Patch Set 4: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/81676/comment/a1666211_2addafc3 : PS4, Line 15: Nivviks > > There is no regression observed in boot-time w/ and w/o this change in both normal and recovery mo […] Successful boot verified on marasov with this change. -- To view, visit https://review.coreboot.org/c/coreboot/+/81676?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I9151a4bcbe9cc084cc19b1a3e91c0321fe4dcc37 Gerrit-Change-Number: 81676 Gerrit-PatchSet: 4 Gerrit-Owner: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Comment-Date: Mon, 08 Apr 2024 17:37:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com> Comment-In-Reply-To: Dinesh Gehlot <digehlot(a)google.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: drivers/intel/fsp2_0: Support FSP 2.4 64-bits
by Appukuttan V K (Code Review) 08 Apr '24

08 Apr '24

Attention is currently required from: Andrey Petrov, Arthur Heymans, Bora Guvendik, Christian Walter, Felix Held, Fred Reitberger, Jason Glenesk, Johnny Lin, Jérémy Compostella, Matt DeVillier, Patrick Rudolph, Paul Menzel, Ronak Kanabar, Shuo Liu, Subrata Banik, Tim Chu, Wonkyu Kim. Appukuttan V K has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80277?usp=email ) Change subject: drivers/intel/fsp2_0: Support FSP 2.4 64-bits ...................................................................... Patch Set 37: (6 comments) File 3rdparty/vboot: https://review.coreboot.org/c/coreboot/+/80277/comment/003121f7_b48db7c5 : PS30, Line 1: Subproject commit 493f7afc9d6b19c97498713a26e72992c60b3ede > remove this file Done File src/drivers/intel/fsp2_0/include/fsp/soc_binding.h: https://review.coreboot.org/c/coreboot/+/80277/comment/c579792f_4395dadb : PS31, Line 10: #include <efi/efi_datatype.h> > Will check and update I removed this and tried. Didn't face any issues. Removing from the patch. File src/include/efi/efi_datatype.h: https://review.coreboot.org/c/coreboot/+/80277/comment/1e2ffa84_d1c7cc68 : PS30, Line 65: EFI_STATUS > nit: UINTN? Done https://review.coreboot.org/c/coreboot/+/80277/comment/daf84478_cf39dbb0 : PS30, Line 19: #define EFIAPI __attribute__((__ms_abi__)) > should be defined by EDK2 headers […] Added to EDK2 headers and tried. It is working fine. https://review.coreboot.org/c/coreboot/+/81775/1 https://review.coreboot.org/c/coreboot/+/80277/comment/6e60db3b_8b8bf688 : PS30, Line 7: /* : * EDK2 EFIAPI macro definition relies on compiler flags such as __GNUC__ which : * is not working well when included by coreboot. While it has no side-effect on : * i386 because the C calling convention used by coreboot and FSP are the same, : * it breaks on x86_64 because FSP/UEFI uses the Microsoft x64 calling : * convention while coreboot uses the System V AMD64 ABI. : * : * Fortunately, EDK2 header allows to override EFIAPI. : */ : #if CONFIG(PLATFORM_USES_FSP2_X86_32) : #define EFIAPI __attribute__((regparm(0))) : #else : #define EFIAPI __attribute__((__ms_abi__)) : #endif : > can you please submit this as a separate CL to start with ? Acknowledged https://review.coreboot.org/c/coreboot/+/80277/comment/86b7b792_21016840 : PS30, Line 90: /* EFI function calling convention attribute */ : #define __efiapi EFIAPI > keep this part of the above CL. Done -- To view, visit https://review.coreboot.org/c/coreboot/+/80277?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: If0397f5cc8d0f4f1872bd37a001fe42e0c37ec99 Gerrit-Change-Number: 80277 Gerrit-PatchSet: 37 Gerrit-Owner: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-Reviewer: Shuo Liu <shuo.liu(a)intel.com> Gerrit-Reviewer: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Reviewer: Wonkyu Kim <wonkyu.kim(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Appukuttan V K <appukuttan.vk(a)intel.com> Gerrit-CC: Ashish Kumar Mishra <ashish.k.mishra(a)intel.com> Gerrit-CC: Dinesh Gehlot <digehlot(a)google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Attention: Wonkyu Kim <wonkyu.kim(a)intel.com> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Shuo Liu <shuo.liu(a)intel.com> Gerrit-Attention: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Attention: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Comment-Date: Mon, 08 Apr 2024 17:25:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Appukuttan V K <appukuttan.vk(a)intel.com> Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com> Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit April 2024