Attention is currently required from: Hung-Te Lin, Ruihai Zhou, Xuxin Xiong, Yidi Lin, Yu-Ping Wu.
Hello Hung-Te Lin, Ruihai Zhou, Xuxin Xiong, Yidi Lin, Yu-Ping Wu, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/81752?usp=email
to look at the new patch set (#5).
Change subject: mb/google/corsola: Set orientation to LB_FB_ORIENTATION_RIGHT_UP
......................................................................
mb/google/corsola: Set orientation to LB_FB_ORIENTATION_RIGHT_UP
Set orientation of KD_KD101NE3_40TI to LB_FB_ORIENTATION_RIGHT_UP to
align the volume up/down direction with menu up/down in FW screen.
BUG=b:331870701
TEST=emerge-staryu coreboot chromeos-bootimage, and check FW screen on
wugtrio, test volume key behaves as expected.
BRANCH=corsola
Change-Id: Ie101cc8b983d3d16587f88fa787ed622e59d27eb
Signed-off-by: Yang Wu <wuyang5(a)huaqin.corp-partner.google.com>
---
M src/mainboard/google/corsola/panel_wugtrio.c
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/52/81752/5
--
To view, visit https://review.coreboot.org/c/coreboot/+/81752?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ie101cc8b983d3d16587f88fa787ed622e59d27eb
Gerrit-Change-Number: 81752
Gerrit-PatchSet: 5
Gerrit-Owner: Yang Wu <wuyang5(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Ruihai Zhou <zhouruihai(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Xuxin Xiong <xuxinxiong(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Attention: Ruihai Zhou <zhouruihai(a)huaqin.corp-partner.google.com>
Gerrit-Attention: Xuxin Xiong <xuxinxiong(a)huaqin.corp-partner.google.com>
Gerrit-Attention: Yidi Lin <yidilin(a)google.com>
Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Hung-Te Lin, Ruihai Zhou, Xuxin Xiong, Yidi Lin, Yu-Ping Wu.
Yang Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81752?usp=email )
Change subject: mb/google/corsola/var/staryu: Set orientation to LB_FB_ORIENTATION_RIGHT_UP
......................................................................
Patch Set 4:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/81752/comment/bb002548_2e7a81fd :
PS3, Line 7: mb/google/corsola
> sorry, I did not notice this should be wugtrio
need `mb/google/corsola/var/staryu/wugtrio` ?
--
To view, visit https://review.coreboot.org/c/coreboot/+/81752?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ie101cc8b983d3d16587f88fa787ed622e59d27eb
Gerrit-Change-Number: 81752
Gerrit-PatchSet: 4
Gerrit-Owner: Yang Wu <wuyang5(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Ruihai Zhou <zhouruihai(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Xuxin Xiong <xuxinxiong(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Attention: Ruihai Zhou <zhouruihai(a)huaqin.corp-partner.google.com>
Gerrit-Attention: Xuxin Xiong <xuxinxiong(a)huaqin.corp-partner.google.com>
Gerrit-Attention: Yidi Lin <yidilin(a)google.com>
Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Comment-Date: Tue, 09 Apr 2024 01:25:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Yidi Lin <yidilin(a)google.com>
Gerrit-MessageType: comment
Attention is currently required from: Hung-Te Lin, Ruihai Zhou, Xuxin Xiong, Yang Wu, Yu-Ping Wu.
Yidi Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81752?usp=email )
Change subject: mb/google/corsola/var/staryu: Set orientation to LB_FB_ORIENTATION_RIGHT_UP
......................................................................
Patch Set 4:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/81752/comment/25f30e5e_ef84842a :
PS3, Line 7: mb/google/corsola
> mb/google/corsola/var/staryu
sorry, I did not notice this should be wugtrio
--
To view, visit https://review.coreboot.org/c/coreboot/+/81752?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ie101cc8b983d3d16587f88fa787ed622e59d27eb
Gerrit-Change-Number: 81752
Gerrit-PatchSet: 4
Gerrit-Owner: Yang Wu <wuyang5(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Ruihai Zhou <zhouruihai(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Xuxin Xiong <xuxinxiong(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Attention: Ruihai Zhou <zhouruihai(a)huaqin.corp-partner.google.com>
Gerrit-Attention: Xuxin Xiong <xuxinxiong(a)huaqin.corp-partner.google.com>
Gerrit-Attention: Yang Wu <wuyang5(a)huaqin.corp-partner.google.com>
Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Comment-Date: Tue, 09 Apr 2024 01:20:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Yidi Lin <yidilin(a)google.com>
Gerrit-MessageType: comment
Attention is currently required from: Hung-Te Lin, Ruihai Zhou, Xuxin Xiong, Yang Wu, Yu-Ping Wu.
Hello Hung-Te Lin, Ruihai Zhou, Xuxin Xiong, Yidi Lin, Yu-Ping Wu, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/81752?usp=email
to look at the new patch set (#4).
The following approvals got outdated and were removed:
Code-Review+1 by Ruihai Zhou, Verified+1 by build bot (Jenkins)
Change subject: mb/google/corsola/var/staryu: Set orientation to LB_FB_ORIENTATION_RIGHT_UP
......................................................................
mb/google/corsola/var/staryu: Set orientation to LB_FB_ORIENTATION_RIGHT_UP
Set orientation of KD_KD101NE3_40TI to LB_FB_ORIENTATION_RIGHT_UP to
align the volume up/down direction with menu up/down in FW screen.
BUG=b:331870701
TEST=emerge-staryu coreboot chromeos-bootimage, and check FW screen on
wugtrio, test volume key behaves as expected.
BRANCH=corsola
Change-Id: Ie101cc8b983d3d16587f88fa787ed622e59d27eb
Signed-off-by: Yang Wu <wuyang5(a)huaqin.corp-partner.google.com>
---
M src/mainboard/google/corsola/panel_wugtrio.c
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/52/81752/4
--
To view, visit https://review.coreboot.org/c/coreboot/+/81752?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ie101cc8b983d3d16587f88fa787ed622e59d27eb
Gerrit-Change-Number: 81752
Gerrit-PatchSet: 4
Gerrit-Owner: Yang Wu <wuyang5(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Ruihai Zhou <zhouruihai(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Xuxin Xiong <xuxinxiong(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Attention: Ruihai Zhou <zhouruihai(a)huaqin.corp-partner.google.com>
Gerrit-Attention: Xuxin Xiong <xuxinxiong(a)huaqin.corp-partner.google.com>
Gerrit-Attention: Yang Wu <wuyang5(a)huaqin.corp-partner.google.com>
Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Cliff Huang, Eran Mitrani, Jingyuan Liang, Paul Menzel.
Kyoung Il Kim has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81331?usp=email )
Change subject: drivers/intel/touch: Add driver for Intel Touch Controller and Devices
......................................................................
Patch Set 2: Code-Review+1
(3 comments)
File src/drivers/intel/touch/chip.h:
https://review.coreboot.org/c/coreboot/+/81331/comment/bc322fd0_ed83257f :
PS2, Line 29: Touch Host Controller Mode
THC's 3 protocol modes.
https://review.coreboot.org/c/coreboot/+/81331/comment/d608069e_2110288a :
PS2, Line 30: Switch between Intel THC protocol and Industry standard HID Over SPI protocol
Switch among IPTS, HID-SPI and HID-I2C.
https://review.coreboot.org/c/coreboot/+/81331/comment/c2049ef8_06a0890b :
PS2, Line 33: ;
> Necessary?
THC HID I2C is for future support.
--
To view, visit https://review.coreboot.org/c/coreboot/+/81331?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I52dfcd187c92141cb8fc47f4143b90d243439d4e
Gerrit-Change-Number: 81331
Gerrit-PatchSet: 2
Gerrit-Owner: Cliff Huang <cliff.huang(a)intel.com>
Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com>
Gerrit-Reviewer: Eric Lai <ericllai(a)google.com>
Gerrit-Reviewer: Jingyuan Liang <jingyliang(a)google.com>
Gerrit-Reviewer: Kyoung Il Kim <kyoung.il.kim(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Hannah Williams <hannah.williams(a)intel.com>
Gerrit-CC: Henry Barnor <hbarnor(a)chromium.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Shaunak Saha <shaunak.saha(a)intel.com>
Gerrit-Attention: Cliff Huang <cliff.huang(a)intel.com>
Gerrit-Attention: Jingyuan Liang <jingyliang(a)google.com>
Gerrit-Attention: Eran Mitrani <mitrani(a)google.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Comment-Date: Tue, 09 Apr 2024 01:06:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-MessageType: comment
Attention is currently required from: Patrick Rudolph, Sergii Dmytruk.
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81800?usp=email )
Change subject: configs: enable TPM PPI for asrock_b85m_pro4.tpm2_txt_placeholder_acms
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/81800?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I316747a79b3142e9d6188c5986b344c7751d92d7
Gerrit-Change-Number: 81800
Gerrit-PatchSet: 2
Gerrit-Owner: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Attention: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com>
Gerrit-Comment-Date: Tue, 09 Apr 2024 00:39:56 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Arthur Heymans.
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81777?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: Makefile.mk: Account for large code model sections in cbfs_struct
......................................................................
Patch Set 2:
(1 comment)
File Makefile.mk:
https://review.coreboot.org/c/coreboot/+/81777/comment/7cba8b68_ec83580a :
PS2, Line 369: $(OBJCOPY_ramstage) -O binary --only-section='.data*' --only-section='.bss*' \
Would probably be simpler to just say `--only-section='.*data*' --only-section='.*bss*'` here. In fact this really should be picking up `.rodata` anyway, we're just getting lucky that nobody is marking their structures in these files as `const`. The section restriction was just added originally to exclude `.note.gnu...` stuff.
--
To view, visit https://review.coreboot.org/c/coreboot/+/81777?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ie07779ef548337772183ffe2d642f971d8cceae7
Gerrit-Change-Number: 81777
Gerrit-PatchSet: 2
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Julius Werner <jwerner(a)chromium.org>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Comment-Date: Mon, 08 Apr 2024 23:57:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81618?usp=email )
Change subject: lib: Refactor bmp_load_logo() implementation
......................................................................
Patch Set 5:
(1 comment)
File src/soc/amd/mendocino/fsp_s_params.c:
https://review.coreboot.org/c/coreboot/+/81618/comment/afdf1baa_c675ca0b :
PS4, Line 59: supd->FspsConfig.logo_bmp_buffer = (uint32_t)(uintptr_t)bmp_load_logo(&logo_size);
> > I'm curious why the logo size isn't updated in the FspsConfig. […]
a more precise answer would be that there is no logo size UPD to update in the FspsConfig for AMD Mendocino. See FspsUpd.h in src/vendorcode/amd/fsp/mendocino
--
To view, visit https://review.coreboot.org/c/coreboot/+/81618?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I14bc54670a67980ec93bc366b274832d1f959e50
Gerrit-Change-Number: 81618
Gerrit-PatchSet: 5
Gerrit-Owner: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com>
Gerrit-Reviewer: Ronak Kanabar <ronak.kanabar(a)intel.com>
Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Mon, 08 Apr 2024 21:51:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com>
Comment-In-Reply-To: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-MessageType: comment
Shelley Chen has submitted this change. ( https://review.coreboot.org/c/coreboot/+/81654?usp=email )
Change subject: mb/google/brox: Update verb table to fix headset detection
......................................................................
mb/google/brox: Update verb table to fix headset detection
Correct verbtable value for pin widget 20 of Realtek ALC256 based on the
updated verbtable received from Realtek. Updated Version : 5.0.3.1. This
fixes the headset detection failure, when power_save is enabled in
legacy hda driver.
BUG=b:330433089
BRANCH=None
TEST=Verified headset on Brox
When connected to audiojack in power_save state of legacy hda driver,
headset is detected and audio is resumed.
Change-Id: I71b7d59b3ab5310a0b6cdb31fb5033f94263d151
Signed-off-by: Poornima Tom <poornima.tom(a)intel.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/81654
Reviewed-by: Paul Menzel <paulepanter(a)mailbox.org>
Reviewed-by: Terry Cheong <htcheong(a)google.com>
Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org>
Reviewed-by: Shelley Chen <shchen(a)google.com>
---
M src/mainboard/google/brox/hda_verb.c
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
build bot (Jenkins): Verified
Paul Menzel: Looks good to me, but someone else must approve
Shelley Chen: Looks good to me, approved
Terry Cheong: Looks good to me, but someone else must approve
diff --git a/src/mainboard/google/brox/hda_verb.c b/src/mainboard/google/brox/hda_verb.c
index bf998e1..a012ac4 100644
--- a/src/mainboard/google/brox/hda_verb.c
+++ b/src/mainboard/google/brox/hda_verb.c
@@ -107,9 +107,9 @@
* To set LDO1/LDO2 as default (used for headset)
*/
0x02050008,
- 0x02046A0C,
+ 0x0204EA0C,
0x02050008,
- 0x02046A0C,
+ 0x0204EA0C,
};
const u32 pc_beep_verbs[] = {
--
To view, visit https://review.coreboot.org/c/coreboot/+/81654?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I71b7d59b3ab5310a0b6cdb31fb5033f94263d151
Gerrit-Change-Number: 81654
Gerrit-PatchSet: 4
Gerrit-Owner: Poornima Tom <poornima.tom(a)intel.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: Shelley Chen <shchen(a)google.com>
Gerrit-Reviewer: Terry Cheong <htcheong(a)google.com>
Gerrit-Reviewer: Vamshi Krishna Gopal <vamshi.krishna.gopal(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-MessageType: merged