coreboot-gerrit April 2024

coreboot-gerrit@coreboot.org

1 participants
3293 discussions

[S] Change in coreboot[main]: mb/google/corsola: Add new board variant Skitty
by Herbert Wu (Code Review) 08 Apr '24

08 Apr '24

Attention is currently required from: Hung-Te Lin, Shawn Ku, Shawn Ku, Yidi Lin, Yu-Ping Wu. Herbert Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81772?usp=email ) Change subject: mb/google/corsola: Add new board variant Skitty ...................................................................... Patch Set 6: (4 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/81772/comment/26e0a1a7_dadf6842 : PS2, Line 7: mb/google/corsola: Add new board Skitty : : Add a new board 'Skitty' : : BUG=b:331702790 : BRANCH=corsola : TEST=none > please follow the format of CB:81585 Done, thanks. Commit Message: https://review.coreboot.org/c/coreboot/+/81772/comment/c967e796_9730ed80 : PS4, Line 9: Skitty > Krabby Done, thanks. https://review.coreboot.org/c/coreboot/+/81772/comment/87859d72_6031ec03 : PS4, Line 9: Wugtrio > Skitty Done, thanks. File src/mainboard/google/corsola/Kconfig: https://review.coreboot.org/c/coreboot/+/81772/comment/d222acbe_355c5cbe : PS2, Line 54: select DRIVER_ANALOGIX_ANX7625 if BOARD_GOOGLE_CHINCHOU || \ : BOARD_GOOGLE_KINGLER || \ : BOARD_GOOGLE_KYOGRE || \ : BOARD_GOOGLE_PONYTA || \ : BOARD_GOOGLE_STEELIX || \ : BOARD_GOOGLE_VOLTORB : select DRIVER_PARADE_PS8640 if BOARD_GOOGLE_KRABBY || \ : BOARD_GOOGLE_MAGIKARP || \ : BOARD_GOOGLE_STEELIX || \ : BOARD_GOOGLE_TENTACRUEL : select RTC : select FW_CONFIG : select FW_CONFIG_SOURCE_CHROMEEC_CBI : select MIPI_PANEL_KD_KD101NE3_40TI if BOARD_GOOGLE_WUGTRIO : select MIPI_PANEL_STA_HIMAX83102_J02 if BOARD_GOOGLE_STARMIE : select MIPI_PANEL_STA_ILI9882T if BOARD_GOOGLE_STARMIE > Please either select eDP config `DRIVER_ANALOGIX_ANX7625` / `DRIVER_PARADE_PS8640` or implement `get […] Done, thanks. -- To view, visit https://review.coreboot.org/c/coreboot/+/81772?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I2f12bccfda591a5baf8d23d217b6f1f81b059d15 Gerrit-Change-Number: 81772 Gerrit-PatchSet: 6 Gerrit-Owner: Herbert Wu <herbert1_wu(a)pegatron.corp-partner.google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Shawn Ku <shawnku(a)chromium.org> Gerrit-Reviewer: Shawn Ku <shawnku(a)google.com> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Shawn Ku <shawnku(a)google.com> Gerrit-Attention: Shawn Ku <shawnku(a)chromium.org> Gerrit-Attention: Yidi Lin <yidilin(a)google.com> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Comment-Date: Tue, 09 Apr 2024 03:40:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Yidi Lin <yidilin(a)google.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: mb/google/corsola: Add new board variant Skitty
by Herbert Wu (Code Review) 08 Apr '24

08 Apr '24

Attention is currently required from: Herbert Wu, Hung-Te Lin, Shawn Ku, Shawn Ku, Yu-Ping Wu. Hello Hung-Te Lin, Shawn Ku, Shawn Ku, Yidi Lin, Yu-Ping Wu, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/81772?usp=email to look at the new patch set (#6). Change subject: mb/google/corsola: Add new board variant Skitty ...................................................................... mb/google/corsola: Add new board variant Skitty Add a new Krabby follower device 'Skitty'. BUG=b:331702790 TEST=emerge-corsola coreboot chromeos-bootimage BRANCH=corsola Change-Id: I2f12bccfda591a5baf8d23d217b6f1f81b059d15 Signed-off-by: Herbert Wu <herbert1_wu(a)pegatron.corp-partner.google.com> --- M src/mainboard/google/corsola/Kconfig M src/mainboard/google/corsola/Kconfig.name 2 files changed, 8 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/72/81772/6 -- To view, visit https://review.coreboot.org/c/coreboot/+/81772?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I2f12bccfda591a5baf8d23d217b6f1f81b059d15 Gerrit-Change-Number: 81772 Gerrit-PatchSet: 6 Gerrit-Owner: Herbert Wu <herbert1_wu(a)pegatron.corp-partner.google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Shawn Ku <shawnku(a)chromium.org> Gerrit-Reviewer: Shawn Ku <shawnku(a)google.com> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Herbert Wu <herbert1_wu(a)pegatron.corp-partner.google.com> Gerrit-Attention: Shawn Ku <shawnku(a)google.com> Gerrit-Attention: Shawn Ku <shawnku(a)chromium.org> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[main]: mb/google/corsola: Add new board variant Skitty
by Herbert Wu (Code Review) 08 Apr '24

08 Apr '24

Attention is currently required from: Herbert Wu, Hung-Te Lin, Shawn Ku, Shawn Ku, Yu-Ping Wu. Hello Hung-Te Lin, Shawn Ku, Shawn Ku, Yidi Lin, Yu-Ping Wu, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/81772?usp=email to look at the new patch set (#5). The following approvals got outdated and were removed: Code-Review+1 by Shawn Ku Change subject: mb/google/corsola: Add new board variant Skitty ...................................................................... mb/google/corsola: Add new board variant Skitty Add a new Skitty follower device 'Wugtrio'. BUG=b:331702790 TEST=emerge-corsola coreboot chromeos-bootimage BRANCH=corsola Change-Id: I2f12bccfda591a5baf8d23d217b6f1f81b059d15 Signed-off-by: Herbert Wu <herbert1_wu(a)pegatron.corp-partner.google.com> --- M src/mainboard/google/corsola/Kconfig M src/mainboard/google/corsola/Kconfig.name 2 files changed, 8 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/72/81772/5 -- To view, visit https://review.coreboot.org/c/coreboot/+/81772?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I2f12bccfda591a5baf8d23d217b6f1f81b059d15 Gerrit-Change-Number: 81772 Gerrit-PatchSet: 5 Gerrit-Owner: Herbert Wu <herbert1_wu(a)pegatron.corp-partner.google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Shawn Ku <shawnku(a)chromium.org> Gerrit-Reviewer: Shawn Ku <shawnku(a)google.com> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Herbert Wu <herbert1_wu(a)pegatron.corp-partner.google.com> Gerrit-Attention: Shawn Ku <shawnku(a)google.com> Gerrit-Attention: Shawn Ku <shawnku(a)chromium.org> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-MessageType: newpatchset

1 0

[XS] Change in coreboot[main]: mb/google/corsola: Add new board variant Skitty
by Yidi Lin (Code Review) 08 Apr '24

08 Apr '24

Attention is currently required from: Herbert Wu, Hung-Te Lin, Shawn Ku, Yu-Ping Wu. Yidi Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81772?usp=email ) Change subject: mb/google/corsola: Add new board variant Skitty ...................................................................... Patch Set 4: (3 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/81772/comment/f0cda08f_d938a0e7 : PS4, Line 9: Wugtrio Skitty https://review.coreboot.org/c/coreboot/+/81772/comment/87309a9d_9c9cf10f : PS4, Line 9: Skitty Krabby https://review.coreboot.org/c/coreboot/+/81772/comment/2984e4ac_341e1dcc : PS4, Line 12: emerge-corsola coreboot I don't think it can pass the build. -- To view, visit https://review.coreboot.org/c/coreboot/+/81772?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I2f12bccfda591a5baf8d23d217b6f1f81b059d15 Gerrit-Change-Number: 81772 Gerrit-PatchSet: 4 Gerrit-Owner: Herbert Wu <herbert1_wu(a)pegatron.corp-partner.google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Shawn Ku <shawnku(a)chromium.org> Gerrit-Reviewer: Shawn Ku <shawnku(a)google.com> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Herbert Wu <herbert1_wu(a)pegatron.corp-partner.google.com> Gerrit-Attention: Shawn Ku <shawnku(a)chromium.org> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Comment-Date: Tue, 09 Apr 2024 03:17:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: mb/google/corsola/var/wugtrio: Set orientation to LB_FB_ORIENTATION_R...
by Yang Wu (Code Review) 08 Apr '24

08 Apr '24

Attention is currently required from: Hung-Te Lin, Ruihai Zhou, Xuxin Xiong, Yang Wu, Yu-Ping Wu. Hello Hung-Te Lin, Ruihai Zhou, Xuxin Xiong, Yidi Lin, Yu-Ping Wu, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/81752?usp=email to look at the new patch set (#6). Change subject: mb/google/corsola/var/wugtrio: Set orientation to LB_FB_ORIENTATION_RIGHT_UP ...................................................................... mb/google/corsola/var/wugtrio: Set orientation to LB_FB_ORIENTATION_RIGHT_UP Set orientation of KD_KD101NE3_40TI to LB_FB_ORIENTATION_RIGHT_UP to align the volume up/down direction with menu up/down in FW screen. BUG=b:331870701 TEST=emerge-staryu coreboot chromeos-bootimage, and check FW screen on wugtrio, test volume key behaves as expected. BRANCH=corsola Change-Id: Ie101cc8b983d3d16587f88fa787ed622e59d27eb Signed-off-by: Yang Wu <wuyang5(a)huaqin.corp-partner.google.com> --- M src/mainboard/google/corsola/panel_wugtrio.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/52/81752/6 -- To view, visit https://review.coreboot.org/c/coreboot/+/81752?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ie101cc8b983d3d16587f88fa787ed622e59d27eb Gerrit-Change-Number: 81752 Gerrit-PatchSet: 6 Gerrit-Owner: Yang Wu <wuyang5(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Ruihai Zhou <zhouruihai(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Xuxin Xiong <xuxinxiong(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Ruihai Zhou <zhouruihai(a)huaqin.corp-partner.google.com> Gerrit-Attention: Xuxin Xiong <xuxinxiong(a)huaqin.corp-partner.google.com> Gerrit-Attention: Yang Wu <wuyang5(a)huaqin.corp-partner.google.com> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-MessageType: newpatchset

1 0

[XS] Change in coreboot[main]: mb/google/corsola: Add new board variant Skitty
by Herbert Wu (Code Review) 08 Apr '24

08 Apr '24

Attention is currently required from: Herbert Wu, Hung-Te Lin, Shawn Ku, Yu-Ping Wu. Hello Hung-Te Lin, Shawn Ku, Shawn Ku, Yidi Lin, Yu-Ping Wu, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/81772?usp=email to look at the new patch set (#4). Change subject: mb/google/corsola: Add new board variant Skitty ...................................................................... mb/google/corsola: Add new board variant Skitty Add a new Skitty follower device 'Wugtrio'. BUG=b:331702790 TEST=emerge-corsola coreboot chromeos-bootimage BRANCH=corsola Change-Id: I2f12bccfda591a5baf8d23d217b6f1f81b059d15 Signed-off-by: Herbert Wu <herbert1_wu(a)pegatron.corp-partner.google.com> --- M src/mainboard/google/corsola/Kconfig M src/mainboard/google/corsola/Kconfig.name 2 files changed, 6 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/72/81772/4 -- To view, visit https://review.coreboot.org/c/coreboot/+/81772?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I2f12bccfda591a5baf8d23d217b6f1f81b059d15 Gerrit-Change-Number: 81772 Gerrit-PatchSet: 4 Gerrit-Owner: Herbert Wu <herbert1_wu(a)pegatron.corp-partner.google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Shawn Ku <shawnku(a)chromium.org> Gerrit-Reviewer: Shawn Ku <shawnku(a)google.com> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Herbert Wu <herbert1_wu(a)pegatron.corp-partner.google.com> Gerrit-Attention: Shawn Ku <shawnku(a)chromium.org> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-MessageType: newpatchset

1 0

[XS] Change in coreboot[main]: mb/google/corsola: Set orientation to LB_FB_ORIENTATION_RIGHT_UP
by Yidi Lin (Code Review) 08 Apr '24

08 Apr '24

Attention is currently required from: Hung-Te Lin, Ruihai Zhou, Xuxin Xiong, Yang Wu, Yu-Ping Wu. Yidi Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81752?usp=email ) Change subject: mb/google/corsola: Set orientation to LB_FB_ORIENTATION_RIGHT_UP ...................................................................... Patch Set 5: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/81752/comment/4874b9da_46c1056a : PS5, Line 7: mb/google/corsola mb/google/corsola/var/wugtrio -- To view, visit https://review.coreboot.org/c/coreboot/+/81752?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ie101cc8b983d3d16587f88fa787ed622e59d27eb Gerrit-Change-Number: 81752 Gerrit-PatchSet: 5 Gerrit-Owner: Yang Wu <wuyang5(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Ruihai Zhou <zhouruihai(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Xuxin Xiong <xuxinxiong(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Ruihai Zhou <zhouruihai(a)huaqin.corp-partner.google.com> Gerrit-Attention: Xuxin Xiong <xuxinxiong(a)huaqin.corp-partner.google.com> Gerrit-Attention: Yang Wu <wuyang5(a)huaqin.corp-partner.google.com> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Comment-Date: Tue, 09 Apr 2024 02:39:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: mb/google/corsola: Add new board variant Skitty
by Shawn Ku (Code Review) 08 Apr '24

08 Apr '24

Attention is currently required from: Herbert Wu, Hung-Te Lin, Shawn Ku, Yu-Ping Wu. Shawn Ku has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81772?usp=email ) Change subject: mb/google/corsola: Add new board variant Skitty ...................................................................... Patch Set 3: Code-Review+1 (1 comment) Patchset: PS3: Is the TEST attr. correct? Skitty should follow Krabby, that means: `emerge-corsola coreboot chromeos-bootimage` fit into my expectation. -- To view, visit https://review.coreboot.org/c/coreboot/+/81772?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I2f12bccfda591a5baf8d23d217b6f1f81b059d15 Gerrit-Change-Number: 81772 Gerrit-PatchSet: 3 Gerrit-Owner: Herbert Wu <herbert1_wu(a)pegatron.corp-partner.google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Shawn Ku <shawnku(a)chromium.org> Gerrit-Reviewer: Shawn Ku <shawnku(a)google.com> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Herbert Wu <herbert1_wu(a)pegatron.corp-partner.google.com> Gerrit-Attention: Shawn Ku <shawnku(a)chromium.org> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Comment-Date: Tue, 09 Apr 2024 02:07:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: mb/google/corsola: Add new board variant Skitty
by Herbert Wu (Code Review) 08 Apr '24

08 Apr '24

Attention is currently required from: Herbert Wu, Hung-Te Lin, Shawn Ku, Yu-Ping Wu. Hello Hung-Te Lin, Shawn Ku, Shawn Ku, Yidi Lin, Yu-Ping Wu, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/81772?usp=email to look at the new patch set (#3). Change subject: mb/google/corsola: Add new board variant Skitty ...................................................................... mb/google/corsola: Add new board variant Skitty Add a new Skitty follower device 'Wugtrio'. BUG=b:331702790 TEST=emerge-staryu coreboot chromeos-bootimage BRANCH=corsola Change-Id: I2f12bccfda591a5baf8d23d217b6f1f81b059d15 Signed-off-by: Herbert Wu <herbert1_wu(a)pegatron.corp-partner.google.com> --- M src/mainboard/google/corsola/Kconfig M src/mainboard/google/corsola/Kconfig.name 2 files changed, 6 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/72/81772/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/81772?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I2f12bccfda591a5baf8d23d217b6f1f81b059d15 Gerrit-Change-Number: 81772 Gerrit-PatchSet: 3 Gerrit-Owner: Herbert Wu <herbert1_wu(a)pegatron.corp-partner.google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Shawn Ku <shawnku(a)chromium.org> Gerrit-Reviewer: Shawn Ku <shawnku(a)google.com> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Herbert Wu <herbert1_wu(a)pegatron.corp-partner.google.com> Gerrit-Attention: Shawn Ku <shawnku(a)chromium.org> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-MessageType: newpatchset

1 0

[M] Change in coreboot[main]: drivers/i2c/rt5645: Add RT5645 amp driver
by Eric Lai (Code Review) 08 Apr '24

08 Apr '24

Attention is currently required from: Dolan Liu, Jianeng Ceng, Subrata Banik. Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81773?usp=email ) Change subject: drivers/i2c/rt5645: Add RT5645 amp driver ...................................................................... Patch Set 4: (1 comment) File src/drivers/i2c/rt5645/rt5645.c: https://review.coreboot.org/c/coreboot/+/81773/comment/7b92bc5e_d35a0159 : PS4, Line 14: static int i2c_generic_write_gpio(struct acpi_gpio *gpio, int *curr_index) We may want to export https://source.chromium.org/chromiumos/chromiumos/codesearch/+/main:src/thi… for other driver use? -- To view, visit https://review.coreboot.org/c/coreboot/+/81773?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I602fcc4dd8576043943f6e20884edc4703350320 Gerrit-Change-Number: 81773 Gerrit-PatchSet: 4 Gerrit-Owner: Jianeng Ceng <cengjianeng(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Dolan Liu <liuyong5(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Dolan Liu <liuyong5(a)huaqin.corp-partner.google.com> Gerrit-Attention: Jianeng Ceng <cengjianeng(a)huaqin.corp-partner.google.com> Gerrit-Comment-Date: Tue, 09 Apr 2024 01:50:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit April 2024