coreboot-gerrit April 2024

coreboot-gerrit@coreboot.org

1 participants
3293 discussions

[XL] Change in coreboot[main]: lib/device_tree: Add some FDT helper functions
by Maximilian Brune (Code Review) 13 Apr '24

13 Apr '24

Attention is currently required from: Jakub Czapiga, Julius Werner, Martin L Roth. Maximilian Brune has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81081?usp=email ) Change subject: lib/device_tree: Add some FDT helper functions ...................................................................... Patch Set 18: (1 comment) File src/lib/device_tree.c: https://review.coreboot.org/c/coreboot/+/81081/comment/1971321a_8812952f : PS18, Line 175: "" > I'm confused... […] You always want the addr/size cells from the parent node, since these are the ones that influence the properties (e.g. reg property) of the current node. -- To view, visit https://review.coreboot.org/c/coreboot/+/81081?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I2fb1d93c5b3e1cb2f7d9584db52bbce3767b63d8 Gerrit-Change-Number: 81081 Gerrit-PatchSet: 18 Gerrit-Owner: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Jakub Czapiga <czapiga(a)google.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Alper Nebi Yasak <alpernebiyasak(a)gmail.com> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Jakub Czapiga <czapiga(a)google.com> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Comment-Date: Sat, 13 Apr 2024 10:14:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Julius Werner <jwerner(a)chromium.org> Comment-In-Reply-To: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: arch/x86: Prevent .text/.init overlap with older linkers
by Nico Huber (Code Review) 13 Apr '24

13 Apr '24

Attention is currently required from: Arthur Heymans, Jérémy Compostella, Subrata Banik. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81886?usp=email ) Change subject: arch/x86: Prevent .text/.init overlap with older linkers ...................................................................... Patch Set 2: (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/81886/comment/52c0121f_702c8e8a : PS2, Line 11: (binutils 2.3x) Are you sure this is used with the main branch? I was told ChromeOS always uses the newest toolchain (and hence we have to restrict toolchain updates to the releases). binutils was updated to 2.40 a year ago. https://review.coreboot.org/c/coreboot/+/81886/comment/145b0674_bdf4f286 : PS2, Line 11: Default is 1024 bytes (1 KiB) There was a comment on another change (CB:81678) stating that SIZEOF() is returning 0 (with the old binutils). If that's the case, 1KiB might not be enough (possibly depending on alignment). -- To view, visit https://review.coreboot.org/c/coreboot/+/81886?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I019bf6896d84b2a84dff6f22323f0f446c0740b5 Gerrit-Change-Number: 81886 Gerrit-PatchSet: 2 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-CC: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Sat, 13 Apr 2024 09:47:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in coreboot[main]: cpu/intel/model_206ax: Allow to configure VR settings
by Angel Pons (Code Review) 13 Apr '24

13 Apr '24

Attention is currently required from: Alexander Couzens, Felix Held, Patrick Rudolph. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81597?usp=email ) Change subject: cpu/intel/model_206ax: Allow to configure VR settings ...................................................................... Patch Set 2: Code-Review+2 (1 comment) File src/mainboard/lenovo/x220/devicetree.cb: https://review.coreboot.org/c/coreboot/+/81597/comment/cb78d973_09133638 : PS2, Line 41: 98 > I see. […] Acknowledged -- To view, visit https://review.coreboot.org/c/coreboot/+/81597?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I59edab47fc4fbe0240e1dd7d25647f7549b4def2 Gerrit-Change-Number: 81597 Gerrit-PatchSet: 2 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Sat, 13 Apr 2024 09:38:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Patrick Rudolph <patrick.rudolph(a)9elements.com> Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

[M] Change in coreboot[main]: cpu/intel/model_206ax: Allow to configure VR settings
by Angel Pons (Code Review) 13 Apr '24

13 Apr '24

Attention is currently required from: Alexander Couzens, Felix Held, Patrick Rudolph. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81597?usp=email ) Change subject: cpu/intel/model_206ax: Allow to configure VR settings ...................................................................... Patch Set 2: (2 comments) File src/cpu/intel/model_206ax/model_206ax_init.c: https://review.coreboot.org/c/coreboot/+/81597/comment/6ce42298_769952ca : PS2, Line 213: BIOS_INFO > IMHO all devicetrees should contain those value. […] Let's leave it as it is. File src/mainboard/lenovo/x220/devicetree.cb: https://review.coreboot.org/c/coreboot/+/81597/comment/9809a329_972c93d7 : PS2, Line 41: 98 > As the comment above states, extracted from vendor firmware. I see. I'm confused because the other comment line says 33 amps and 53 amps -- To view, visit https://review.coreboot.org/c/coreboot/+/81597?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I59edab47fc4fbe0240e1dd7d25647f7549b4def2 Gerrit-Change-Number: 81597 Gerrit-PatchSet: 2 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Sat, 13 Apr 2024 09:38:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Patrick Rudolph <patrick.rudolph(a)9elements.com> Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

[L] Change in coreboot[main]: mb/*: Copy bd82x6x boards' USB port config into devicetree
by Angel Pons (Code Review) 13 Apr '24

13 Apr '24

Attention is currently required from: Alexander Couzens, Evgeny Zinoviev, Keith Hui, Kevin Keijzer. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81879?usp=email ) Change subject: mb/*: Copy bd82x6x boards' USB port config into devicetree ...................................................................... Patch Set 1: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/81879/comment/4b4cd8ef_038f5c98 : PS1, Line 11: otherwise the contents are reformatted : into 3-4 lines with extra spaces removed. Please don't. It makes reviewing this change much more challenging. -- To view, visit https://review.coreboot.org/c/coreboot/+/81879?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ia8a967eb3466106f3a34e024260e13d02f449a25 Gerrit-Change-Number: 81879 Gerrit-PatchSet: 1 Gerrit-Owner: Keith Hui <buurin(a)gmail.com> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Evgeny Zinoviev <me(a)ch1p.io> Gerrit-Reviewer: Kevin Keijzer <kevin(a)quietlife.nl> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Kevin Keijzer <kevin(a)quietlife.nl> Gerrit-Attention: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Attention: Evgeny Zinoviev <me(a)ch1p.io> Gerrit-Attention: Keith Hui <buurin(a)gmail.com> Gerrit-Comment-Date: Sat, 13 Apr 2024 09:36:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: sb/intel/bd82x6x: Add four new USB currents
by Nico Huber (Code Review) 13 Apr '24

13 Apr '24

Attention is currently required from: Joel Linn. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81427?usp=email ) Change subject: sb/intel/bd82x6x: Add four new USB currents ...................................................................... Patch Set 4: Code-Review+2 (1 comment) Patchset: PS4: I guess we should keep autoport in sync? Could also be done in a follow up. (Note, I couldn't find the new values in docs, but that's also true for two of the pre-existing values... looks like ODMs know more than what the EDS gives.) -- To view, visit https://review.coreboot.org/c/coreboot/+/81427?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I156787e533c2605e7440548a2d3bf711bb1af5d7 Gerrit-Change-Number: 81427 Gerrit-PatchSet: 4 Gerrit-Owner: Joel Linn <jl_coreboot(a)conductive.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Joel Linn <jl_coreboot(a)conductive.de> Gerrit-Comment-Date: Sat, 13 Apr 2024 09:35:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in coreboot[main]: nb/intel/sandybridge: Pre-render constants in MRC pei_data
by Angel Pons (Code Review) 13 Apr '24

13 Apr '24

Attention is currently required from: Keith Hui. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78206?usp=email ) Change subject: nb/intel/sandybridge: Pre-render constants in MRC pei_data ...................................................................... Patch Set 4: (1 comment) File src/northbridge/intel/sandybridge/raminit_mrc.c: https://review.coreboot.org/c/coreboot/+/78206/comment/3461cbb8_a946cb03 : PS4, Line 404: struct pei_data pei_data; > The same thing can easily be achieved using a struct initialiser here: […] This much easier to maintain, and also allows initialising fields whose value is always the result of some expression that can only be computed at runtime (e.g. `system_type`, `gbe_enable`). -- To view, visit https://review.coreboot.org/c/coreboot/+/78206?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ic0f429a7be11ea497ce31cde007966ea988a256f Gerrit-Change-Number: 78206 Gerrit-PatchSet: 4 Gerrit-Owner: Keith Hui <buurin(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Keith Hui <buurin(a)gmail.com> Gerrit-Comment-Date: Sat, 13 Apr 2024 09:31:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

[M] Change in coreboot[main]: nb/intel/sandybridge: Pre-render constants in MRC pei_data
by Angel Pons (Code Review) 13 Apr '24

13 Apr '24

Attention is currently required from: Keith Hui. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78206?usp=email ) Change subject: nb/intel/sandybridge: Pre-render constants in MRC pei_data ...................................................................... Patch Set 4: (1 comment) File src/northbridge/intel/sandybridge/raminit_mrc.c: https://review.coreboot.org/c/coreboot/+/78206/comment/c62eb3f4_19608061 : PS4, Line 404: struct pei_data pei_data; The same thing can easily be achieved using a struct initialiser here: ``` struct pei_data pei_data = { .pei_version = PEI_VERSION, .mchbar = CONFIG_FIXED_MCHBAR_MMIO_BASE, .dmibar = CONFIG_FIXED_DMIBAR_MMIO_BASE, .epbar = CONFIG_FIXED_EPBAR_MMIO_BASE, .pciexbar = CONFIG_ECAM_MMCONF_BASE_ADDRESS, .smbusbar = CONFIG_FIXED_SMBUS_IO_BASE, .wdbbar = 0x4000000, .wdbsize = 0x1000, .hpet_address = HPET_BASE_ADDRESS, .rcba = (uintptr_t)DEFAULT_RCBA, .pmbase = DEFAULT_PMBASE, .gpiobase = DEFAULT_GPIOBASE, .thermalbase = 0xfed08000, .tseg_size = CONFIG_SMM_TSEG_SIZE, }; ``` This works because unspecified members are zero-initialised by the compiler. So the `memset()` becomes unnecessary. -- To view, visit https://review.coreboot.org/c/coreboot/+/78206?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ic0f429a7be11ea497ce31cde007966ea988a256f Gerrit-Change-Number: 78206 Gerrit-PatchSet: 4 Gerrit-Owner: Keith Hui <buurin(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Keith Hui <buurin(a)gmail.com> Gerrit-Comment-Date: Sat, 13 Apr 2024 09:27:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[L] Change in coreboot[main]: superio/ite: Unify it8772f with common code
by Nico Huber (Code Review) 13 Apr '24

13 Apr '24

Attention is currently required from: Joel Linn, Michał Żygowski, MrChromebox, Piotr Król. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81310?usp=email ) Change subject: superio/ite: Unify it8772f with common code ...................................................................... Patch Set 7: Code-Review+2 (1 comment) Patchset: PS7: > Anything more to be done by me? No, were just waiting for Matt's testing. I suppose that's done now? -- To view, visit https://review.coreboot.org/c/coreboot/+/81310?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ic4d9d5460628e444dc20f620179b39c90dbc28c6 Gerrit-Change-Number: 81310 Gerrit-PatchSet: 7 Gerrit-Owner: Joel Linn <jl_coreboot(a)conductive.de> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: MrChromebox <mrchromebox(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Piotr Król <piotr.krol(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Joel Linn <jl_coreboot(a)conductive.de> Gerrit-Attention: MrChromebox <mrchromebox(a)gmail.com> Gerrit-Attention: Piotr Król <piotr.krol(a)3mdeb.com> Gerrit-Comment-Date: Sat, 13 Apr 2024 09:18:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Joel Linn <jl_coreboot(a)conductive.de> Gerrit-MessageType: comment

1 0

[M] Change in coreboot[main]: [test only] upgrade nasm to 2.16.03rc1
by Elyes Haouas (Code Review) 13 Apr '24

13 Apr '24

Elyes Haouas has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/81900?usp=email ) Change subject: [test only] upgrade nasm to 2.16.03rc1 ...................................................................... [test only] upgrade nasm to 2.16.03rc1 Change-Id: I70408b189b974f8abaadc66f0c809a1dbe10504b Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> --- M util/crossgcc/buildgcc D util/crossgcc/patches/nasm-2.16.01_handle_warning_files_while_building_in_a_directory.patch D util/crossgcc/sum/nasm-2.16.01.tar.bz2.cksum A util/crossgcc/sum/nasm-2.16.03rc1.tar.bz2.cksum 4 files changed, 2 insertions(+), 233 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/00/81900/1 diff --git a/util/crossgcc/buildgcc b/util/crossgcc/buildgcc index 0a0462e..5304ea2 100755 --- a/util/crossgcc/buildgcc +++ b/util/crossgcc/buildgcc @@ -44,7 +44,7 @@ # CLANG version number CLANG_VERSION=17.0.6 CMAKE_VERSION=3.28.3 -NASM_VERSION=2.16.01 +NASM_VERSION=2.16.03rc1 # Filename for each package GMP_ARCHIVE="gmp-${GMP_VERSION}.tar.xz" diff --git a/util/crossgcc/patches/nasm-2.16.01_handle_warning_files_while_building_in_a_directory.patch b/util/crossgcc/patches/nasm-2.16.01_handle_warning_files_while_building_in_a_directory.patch deleted file mode 100644 index b8c97e9..0000000 --- a/util/crossgcc/patches/nasm-2.16.01_handle_warning_files_while_building_in_a_directory.patch +++ /dev/null @@ -1,231 +0,0 @@ -From 7e80d6b834cd792dbbd7a99fbff98e46cdd5789f Mon Sep 17 00:00:00 2001 -From: "H. Peter Anvin" <hpa(a)zytor.com> -Date: Tue, 17 Jan 2023 13:05:55 -0800 -Subject: [PATCH] Make: handle warning files while building in a directory - -The dependency on the warning files breaks when we are building in a -directory *and* the files already exist from being shipped with the -distribution tarballs. The make VPATH simply isn't sophisticated -enough to deal with it, so let the C compiler handle it by #including -the generated file from a dummy C file. - -Reported-by: Rudi Heitbaum <rudi(a)heitbaum.com> -Signed-off-by: H. Peter Anvin <hpa(a)zytor.com> ---- - Makefile.in | 38 ++++++++++++++++++++------------------ - Mkfiles/msvc.mak | 14 +++++++------- - Mkfiles/openwcom.mak | 14 +++++++------- - doc/Makefile.in | 2 +- - 6 files changed, 37 insertions(+), 34 deletions(-) - -diff --git a/Makefile.in b/Makefile.in -index 148fcb50..95268fd2 100644 ---- a/Makefile.in -+++ b/Makefile.in -@@ -37,8 +37,10 @@ AR = @AR@ - RANLIB = @RANLIB@ - STRIP = @STRIP@ - -+tools = $(top_srcdir)/tools -+ - PERL = perl --PERLFLAGS = -I$(srcdir)/perllib -I$(srcdir) -+PERLFLAGS = -I$(top_srcdir)/perllib -I$(srcdir) - RUNPERL = $(PERL) $(PERLFLAGS) - - PYTHON3 = python3 -@@ -65,8 +67,8 @@ LN_S = @LN_S@ - FIND = find - - # Binary suffixes --O = @OBJEXT@ --X = @EXEEXT@ -+O = @OBJEXT@ -+X = @EXEEXT@ - A = @LIBEXT@ - - # Debug stuff -@@ -194,14 +196,14 @@ PERLREQ = config/unconfig.h \ - x86/iflag.c x86/iflaggen.h \ - macros/macros.c \ - asm/pptok.ph asm/directbl.c asm/directiv.h \ -- asm/warnings.c include/warnings.h doc/warnings.src \ -+ $(WARNFILES) \ - misc/nasmtok.el \ - version.h version.mac version.mak nsis/version.nsh - - INSDEP = x86/insns.dat x86/insns.pl x86/insns-iflags.ph x86/iflags.ph - - config/unconfig.h: config/config.h.in -- $(RUNPERL) $(srcdir)/tools/unconfig.pl \ -+ $(RUNPERL) $(tools)/unconfig.pl \ - '$(srcdir)' config/config.h.in config/unconfig.h - - x86/iflag.c: $(INSDEP) -@@ -273,7 +275,7 @@ x86/regs.h: x86/regs.dat x86/regs.pl - # reasonable, but doesn't update the time stamp if the files aren't - # changed, to avoid rebuilding everything every time. Track the actual - # dependency by the empty file asm/warnings.time. --WARNFILES = asm/warnings.c include/warnings.h doc/warnings.src -+WARNFILES = asm/warnings_c.h include/warnings.h doc/warnings.src - - warnings: - $(RM_F) $(WARNFILES) $(WARNFILES:=.time) -@@ -283,11 +285,11 @@ asm/warnings.time: $(ALLOBJ_NW:.$(O)=.c) - : > asm/warnings.time - $(MAKE) $(WARNFILES:=.time) - --asm/warnings.c.time: asm/warnings.pl asm/warnings.time -- $(RUNPERL) $(srcdir)/asm/warnings.pl c asm/warnings.c $(srcdir) -- : > asm/warnings.c.time -+asm/warnings_c.h.time: asm/warnings.pl asm/warnings.time -+ $(RUNPERL) $(srcdir)/asm/warnings.pl c asm/warnings_c.h $(srcdir) -+ : > asm/warnings_c.h.time - --asm/warnings.c: asm/warnings.c.time -+asm/warnings_c.h: asm/warnings_c.h.time - @: Side effect - - include/warnings.h.time: asm/warnings.pl asm/warnings.time -@@ -506,8 +508,8 @@ EXTERNAL_DEPENDENCIES = 1 - # the dependency information will remain external, so it doesn't - # pollute the git logs. - # --Makefile.dep: $(PERLREQ) tools/mkdep.pl config.status -- $(RUNPERL) tools/mkdep.pl -M Makefile.in -- $(DEPDIRS) -+Makefile.dep: $(PERLREQ) $(tools)/mkdep.pl config.status -+ $(RUNPERL) $(tools)/mkdep.pl -M Makefile.in -- $(DEPDIRS) - - dep: Makefile.dep - -@@ -517,9 +519,9 @@ dep: Makefile.dep - # be invoked manually or via "make dist". It should be run before - # creating release archives. - # --alldeps: $(PERLREQ) tools/syncfiles.pl tools/mkdep.pl -- $(RUNPERL) tools/syncfiles.pl Makefile.in Mkfiles/*.mak -- $(RUNPERL) tools/mkdep.pl -i -M Makefile.in Mkfiles/*.mak -- \ -+alldeps: $(PERLREQ) $(tools)/syncfiles.pl $(tools)/mkdep.pl -+ $(RUNPERL) $(tools)/syncfiles.pl Makefile.in Mkfiles/*.mak -+ $(RUNPERL) $(tools)/mkdep.pl -i -M Makefile.in Mkfiles/*.mak -- \ - $(DEPDIRS) - $(RM_F) *.dep - if [ -f config.status ]; then \ -@@ -528,9 +530,9 @@ alldeps: $(PERLREQ) tools/syncfiles.pl tools/mkdep.pl - - # Strip internal dependency information from all Makefiles; this makes - # the output good for git checkin --cleandeps: $(PERLREQ) tools/syncfiles.pl tools/mkdep.pl -- $(RUNPERL) tools/syncfiles.pl Makefile.in Mkfiles/*.mak -- $(RUNPERL) tools/mkdep.pl -e -M Makefile.in Mkfiles/*.mak -- \ -+cleandeps: $(PERLREQ) $(tools)/syncfiles.pl $(tools)/mkdep.pl -+ $(RUNPERL) $(tools)/syncfiles.pl Makefile.in Mkfiles/*.mak -+ $(RUNPERL) $(tools)/mkdep.pl -e -M Makefile.in Mkfiles/*.mak -- \ - $(DEPDIRS) - $(RM_F) *.dep - if [ -f config.status ]; then \ -diff --git a/Mkfiles/msvc.mak b/Mkfiles/msvc.mak -index cf71fffc..da71c5c6 100644 ---- a/Mkfiles/msvc.mak -+++ b/Mkfiles/msvc.mak -@@ -153,14 +153,14 @@ PERLREQ = config\unconfig.h \ - x86\iflag.c x86\iflaggen.h \ - macros\macros.c \ - asm\pptok.ph asm\directbl.c asm\directiv.h \ -- asm\warnings.c include\warnings.h doc\warnings.src \ -+ $(WARNFILES) \ - misc\nasmtok.el \ - version.h version.mac version.mak nsis\version.nsh - - INSDEP = x86\insns.dat x86\insns.pl x86\insns-iflags.ph x86\iflags.ph - - config\unconfig.h: config\config.h.in -- $(RUNPERL) $(srcdir)\tools\unconfig.pl \ -+ $(RUNPERL) $(tools)\unconfig.pl \ - '$(srcdir)' config\config.h.in config\unconfig.h - - x86\iflag.c: $(INSDEP) -@@ -232,7 +232,7 @@ x86\regs.h: x86\regs.dat x86\regs.pl - # reasonable, but doesn't update the time stamp if the files aren't - # changed, to avoid rebuilding everything every time. Track the actual - # dependency by the empty file asm\warnings.time. --WARNFILES = asm\warnings.c include\warnings.h doc\warnings.src -+WARNFILES = asm\warnings_c.h include\warnings.h doc\warnings.src - - warnings: - $(RM_F) $(WARNFILES) $(WARNFILES:=.time) -@@ -242,11 +242,11 @@ asm\warnings.time: $(ALLOBJ_NW:.$(O)=.c) - : > asm\warnings.time - $(MAKE) $(WARNFILES:=.time) - --asm\warnings.c.time: asm\warnings.pl asm\warnings.time -- $(RUNPERL) $(srcdir)\asm\warnings.pl c asm\warnings.c $(srcdir) -- : > asm\warnings.c.time -+asm\warnings_c.h.time: asm\warnings.pl asm\warnings.time -+ $(RUNPERL) $(srcdir)\asm\warnings.pl c asm\warnings_c.h $(srcdir) -+ : > asm\warnings_c.h.time - --asm\warnings.c: asm\warnings.c.time -+asm\warnings_c.h: asm\warnings_c.h.time - @: Side effect - - include\warnings.h.time: asm\warnings.pl asm\warnings.time -diff --git a/Mkfiles/openwcom.mak b/Mkfiles/openwcom.mak -index 5394d85d..605f9afe 100644 ---- a/Mkfiles/openwcom.mak -+++ b/Mkfiles/openwcom.mak -@@ -166,14 +166,14 @@ PERLREQ = config\unconfig.h & - x86\iflag.c x86\iflaggen.h & - macros\macros.c & - asm\pptok.ph asm\directbl.c asm\directiv.h & -- asm\warnings.c include\warnings.h doc\warnings.src & -+ $(WARNFILES) & - misc\nasmtok.el & - version.h version.mac version.mak nsis\version.nsh - - INSDEP = x86\insns.dat x86\insns.pl x86\insns-iflags.ph x86\iflags.ph - - config\unconfig.h: config\config.h.in -- $(RUNPERL) $(srcdir)\tools\unconfig.pl & -+ $(RUNPERL) $(tools)\unconfig.pl & - '$(srcdir)' config\config.h.in config\unconfig.h - - x86\iflag.c: $(INSDEP) -@@ -245,7 +245,7 @@ x86\regs.h: x86\regs.dat x86\regs.pl - # reasonable, but doesn't update the time stamp if the files aren't - # changed, to avoid rebuilding everything every time. Track the actual - # dependency by the empty file asm\warnings.time. --WARNFILES = asm\warnings.c include\warnings.h doc\warnings.src -+WARNFILES = asm\warnings_c.h include\warnings.h doc\warnings.src - - warnings: - $(RM_F) $(WARNFILES) $(WARNFILES:=.time) -@@ -255,11 +255,11 @@ asm\warnings.time: $(ALLOBJ_NW:.$(O)=.c) - : > asm\warnings.time - $(MAKE) $(WARNFILES:=.time) - --asm\warnings.c.time: asm\warnings.pl asm\warnings.time -- $(RUNPERL) $(srcdir)\asm\warnings.pl c asm\warnings.c $(srcdir) -- : > asm\warnings.c.time -+asm\warnings_c.h.time: asm\warnings.pl asm\warnings.time -+ $(RUNPERL) $(srcdir)\asm\warnings.pl c asm\warnings_c.h $(srcdir) -+ : > asm\warnings_c.h.time - --asm\warnings.c: asm\warnings.c.time -+asm\warnings_c.h: asm\warnings_c.h.time - @: Side effect - - include\warnings.h.time: asm\warnings.pl asm\warnings.time -diff --git a/doc/Makefile.in b/doc/Makefile.in -index e92437a0..1c8393c5 100644 ---- a/doc/Makefile.in -+++ b/doc/Makefile.in -@@ -20,7 +20,7 @@ INSTALL = @INSTALL@ - INSTALL_PROGRAM = @INSTALL_PROGRAM@ - INSTALL_DATA = @INSTALL_DATA@ - --PERL = perl -I$(srcdir) -+PERL = perl -I$(top_srcdir)/perllib -I$(srcdir) - - PDFOPT = @PDFOPT@ - diff --git a/util/crossgcc/sum/nasm-2.16.01.tar.bz2.cksum b/util/crossgcc/sum/nasm-2.16.01.tar.bz2.cksum deleted file mode 100644 index 9e7437f..0000000 --- a/util/crossgcc/sum/nasm-2.16.01.tar.bz2.cksum +++ /dev/null @@ -1 +0,0 @@ -cee9844c0c80c248ee1005c390223984332abeb8 tarballs/nasm-2.16.01.tar.bz2 diff --git a/util/crossgcc/sum/nasm-2.16.03rc1.tar.bz2.cksum b/util/crossgcc/sum/nasm-2.16.03rc1.tar.bz2.cksum new file mode 100644 index 0000000..4500f0d --- /dev/null +++ b/util/crossgcc/sum/nasm-2.16.03rc1.tar.bz2.cksum @@ -0,0 +1 @@ +bb7ac12797dd7dea381c418f000f3072cb3e88d0 tarballs/nasm-2.16.03rc1.tar.bz2 -- To view, visit https://review.coreboot.org/c/coreboot/+/81900?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I70408b189b974f8abaadc66f0c809a1dbe10504b Gerrit-Change-Number: 81900 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-MessageType: newchange

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit April 2024