coreboot-gerrit April 2024

coreboot-gerrit@coreboot.org

1 participants
3293 discussions

[M] Change in coreboot[main]: multiboot: Support multiboot framebuffer info
by Vladimir Serbinenko (Code Review) 13 Apr '24

13 Apr '24

Attention is currently required from: Vladimir Serbinenko. Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/81896?usp=email to look at the new patch set (#2). Change subject: multiboot: Support multiboot framebuffer info ...................................................................... multiboot: Support multiboot framebuffer info This allows to quickly iterate prototype using modern video output Change-Id: I5872abc612f3b3ad70bd83c621c1e63bc7a2816c Signed-off-by: Vladimir Serbinenko <phcoder(a)gmail.com> --- M payloads/libpayload/arch/x86/head.S M payloads/libpayload/arch/x86/multiboot.c M payloads/libpayload/include/multiboot_tables.h 3 files changed, 53 insertions(+), 5 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/96/81896/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/81896?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I5872abc612f3b3ad70bd83c621c1e63bc7a2816c Gerrit-Change-Number: 81896 Gerrit-PatchSet: 2 Gerrit-Owner: Vladimir Serbinenko <phcoder(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Vladimir Serbinenko <phcoder(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

[M] Change in coreboot[main]: multiboot: Support multiboot framebuffer info
by Vladimir Serbinenko (Code Review) 13 Apr '24

13 Apr '24

Vladimir Serbinenko has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/81896?usp=email ) Change subject: multiboot: Support multiboot framebuffer info ...................................................................... multiboot: Support multiboot framebuffer info This allows to quickly iterate prototype using modern video output Change-Id: I5872abc612f3b3ad70bd83c621c1e63bc7a2816c --- M payloads/libpayload/arch/x86/head.S M payloads/libpayload/arch/x86/multiboot.c M payloads/libpayload/include/multiboot_tables.h 3 files changed, 53 insertions(+), 5 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/96/81896/1 diff --git a/payloads/libpayload/arch/x86/head.S b/payloads/libpayload/arch/x86/head.S index 1e0e4a0..8a76728 100644 --- a/payloads/libpayload/arch/x86/head.S +++ b/payloads/libpayload/arch/x86/head.S @@ -43,7 +43,7 @@ .align 4 #define MB_MAGIC 0x1BADB002 -#define MB_FLAGS 0x00010003 +#define MB_FLAGS 0x00010007 mb_header: .long MB_MAGIC @@ -54,6 +54,7 @@ .long _edata .long _end .long _init + .long 0, 0, 0, 0 /* * This function saves off the previous stack and switches us to our diff --git a/payloads/libpayload/arch/x86/multiboot.c b/payloads/libpayload/arch/x86/multiboot.c index 26dc4f8..4aa3e01 100644 --- a/payloads/libpayload/arch/x86/multiboot.c +++ b/payloads/libpayload/arch/x86/multiboot.c @@ -104,6 +104,33 @@ } } +static void mb_parse_framebuf(struct multiboot_header *table, struct sysinfo_t *info) +{ + if (table->framebuffer_type != MULTIBOOT_FRAMEBUFFER_TYPE_RGB) + return; + info->framebuffer.tag = CB_TAG_FRAMEBUFFER; + info->framebuffer.size = sizeof(info->framebuffer); + + info->framebuffer.physical_address = table->framebuffer_addr; + info->framebuffer.x_resolution = table->framebuffer_width; + info->framebuffer.y_resolution = table->framebuffer_height; + info->framebuffer.bytes_per_line = table->framebuffer_pitch; + info->framebuffer.bits_per_pixel = table->framebuffer_bpp; + info->framebuffer.red_mask_pos = table->framebuffer_red_field_position; + info->framebuffer.red_mask_size = table->framebuffer_red_mask_size; + info->framebuffer.green_mask_pos = table->framebuffer_green_field_position; + info->framebuffer.green_mask_size = table->framebuffer_green_mask_size; + info->framebuffer.blue_mask_pos = table->framebuffer_blue_field_position; + info->framebuffer.blue_mask_size = table->framebuffer_blue_mask_size; + info->framebuffer.reserved_mask_pos = 0; + info->framebuffer.reserved_mask_size = 0; + info->framebuffer.orientation = CB_FB_ORIENTATION_NORMAL; + info->framebuffer.flags.has_external_display = 0; + info->framebuffer.flags.reserved = 0; + info->framebuffer.pad = 0; + +} + int get_multiboot_info(struct sysinfo_t *info) { struct multiboot_header *table; @@ -123,5 +150,8 @@ if (table->flags & MULTIBOOT_FLAGS_CMDLINE) mb_parse_cmdline(table); + if (table->flags & MULTIBOOT_FLAGS_FRAMEBUFFER_INFO) + mb_parse_framebuf(table, info); + return 0; } diff --git a/payloads/libpayload/include/multiboot_tables.h b/payloads/libpayload/include/multiboot_tables.h index cad8034..03d8881 100644 --- a/payloads/libpayload/include/multiboot_tables.h +++ b/payloads/libpayload/include/multiboot_tables.h @@ -35,6 +35,7 @@ #define MULTIBOOT_FLAGS_MMAP (1 << 6) #define MULTIBOOT_FLAGS_CMDLINE (1 << 2) #define MULTIBOOT_FLAGS_MEMINFO (1 << 0) +#define MULTIBOOT_FLAGS_FRAMEBUFFER_INFO (1 << 12) struct multiboot_header { u32 flags; u32 mem_lower; @@ -60,10 +61,26 @@ u32 vbe_control_info; u32 vbe_mode_info; - u32 vbe_mode; - u32 vbe_interface_seg; - u32 vbe_interface_off; - u32 vbe_interface_len; + u16 vbe_mode; + u16 vbe_interface_seg; + u16 vbe_interface_off; + u16 vbe_interface_len; + + u64 framebuffer_addr; + u32 framebuffer_pitch; + u32 framebuffer_width; + u32 framebuffer_height; + u8 framebuffer_bpp; +#define MULTIBOOT_FRAMEBUFFER_TYPE_INDEXED 0 +#define MULTIBOOT_FRAMEBUFFER_TYPE_RGB 1 +#define MULTIBOOT_FRAMEBUFFER_TYPE_EGA_TEXT 2 + u8 framebuffer_type; + u8 framebuffer_red_field_position; + u8 framebuffer_red_mask_size; + u8 framebuffer_green_field_position; + u8 framebuffer_green_mask_size; + u8 framebuffer_blue_field_position; + u8 framebuffer_blue_mask_size; }; struct multiboot_mmap { -- To view, visit https://review.coreboot.org/c/coreboot/+/81896?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I5872abc612f3b3ad70bd83c621c1e63bc7a2816c Gerrit-Change-Number: 81896 Gerrit-PatchSet: 1 Gerrit-Owner: Vladimir Serbinenko <phcoder(a)gmail.com> Gerrit-MessageType: newchange

1 0

[XL] Change in coreboot[main]: lib/device_tree: Add some FDT helper functions
by Julius Werner (Code Review) 13 Apr '24

13 Apr '24

Attention is currently required from: Jakub Czapiga, Martin L Roth, Maximilian Brune. Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81081?usp=email ) Change subject: lib/device_tree: Add some FDT helper functions ...................................................................... Patch Set 18: (1 comment) File src/lib/device_tree.c: https://review.coreboot.org/c/coreboot/+/81081/comment/9974cfdb_8a236968 : PS18, Line 175: "" > ``` […] I'm confused... don't you _want_ the addr/size cells from the current node? You want the values that would be appropriate for the properties you could read out of the node offset you get returned, and those are the ones from that same node. -- To view, visit https://review.coreboot.org/c/coreboot/+/81081?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I2fb1d93c5b3e1cb2f7d9584db52bbce3767b63d8 Gerrit-Change-Number: 81081 Gerrit-PatchSet: 18 Gerrit-Owner: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Jakub Czapiga <czapiga(a)google.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Alper Nebi Yasak <alpernebiyasak(a)gmail.com> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Jakub Czapiga <czapiga(a)google.com> Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Comment-Date: Fri, 12 Apr 2024 22:59:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Maximilian Brune <maximilian.brune(a)9elements.com> Comment-In-Reply-To: Julius Werner <jwerner(a)chromium.org> Gerrit-MessageType: comment

1 0

[M] Change in coreboot[main]: security/tpm: support compiling in multiple TPM drivers
by Julius Werner (Code Review) 13 Apr '24

13 Apr '24

Attention is currently required from: Arthur Heymans, Christian Walter, Felix Held, Fred Reitberger, Jason Glenesk, Jérémy Compostella, Krystian Hebel, Matt DeVillier, Michał Żygowski, Raul Rangel, Sergii Dmytruk. Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69162?usp=email ) Change subject: security/tpm: support compiling in multiple TPM drivers ...................................................................... Patch Set 40: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/69162?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I44c5a1d825afe414c2f5c2c90f4cfe41ba9bef5f Gerrit-Change-Number: 69162 Gerrit-PatchSet: 40 Gerrit-Owner: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Attention: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Fri, 12 Apr 2024 22:55:22 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in coreboot[main]: arch/arm64: Add EL1/EL2/EL3 support for arm64
by Felix Singer (Code Review) 13 Apr '24

13 Apr '24

Attention is currently required from: Angel Pons, Arthur Heymans, Christian Walter, David Milosevic, Julius Werner, Lean Sheng Tan, Martin L Roth, Maximilian Brune, Nico Huber. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74798?usp=email ) The change is no longer submittable: All-Comments-Resolved is unsatisfied now. Change subject: arch/arm64: Add EL1/EL2/EL3 support for arm64 ...................................................................... Patch Set 17: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/74798/comment/63ac9f5f_97ea82f1 : PS5, Line 11: one boots into TF-A first and drops into EL2 for coreboot afterwards. > As per the agreement in the leadership meeting, will get this patch merged once the new LBBR spec wi […] Then let's keep this thread unresolved until this is done. -- To view, visit https://review.coreboot.org/c/coreboot/+/74798?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Iae1c57f0846c8d0585384f7e54102a837e701e7e Gerrit-Change-Number: 74798 Gerrit-PatchSet: 17 Gerrit-Owner: David Milosevic <David.Milosevic(a)9elements.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: ron minnich <rminnich(a)gmail.com> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-CC: Martin L Roth <gaumless(a)gmail.com> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-CC: Yidi Lin <yidilin(a)google.com> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Attention: David Milosevic <David.Milosevic(a)9elements.com> Gerrit-Comment-Date: Fri, 12 Apr 2024 22:55:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Comment-In-Reply-To: Maximilian Brune <maximilian.brune(a)9elements.com> Comment-In-Reply-To: Julius Werner <jwerner(a)chromium.org> Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Comment-In-Reply-To: Arthur Heymans <arthur(a)aheymans.xyz> Comment-In-Reply-To: Lean Sheng Tan <sheng.tan(a)9elements.com> Comment-In-Reply-To: David Milosevic <David.Milosevic(a)9elements.com> Gerrit-MessageType: comment

1 0

[M] Change in coreboot[main]: drivers/crb: use crb_tpm_ prefix instead of tpm2_
by Julius Werner (Code Review) 13 Apr '24

13 Apr '24

Attention is currently required from: Cliff Huang, Lance Zhao, Sergii Dmytruk, Tim Wawrzynczak. Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81860?usp=email ) Change subject: drivers/crb: use crb_tpm_ prefix instead of tpm2_ ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/81860?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I0aa2686103546e0696ab8dcf77e2b99bf9734915 Gerrit-Change-Number: 81860 Gerrit-PatchSet: 1 Gerrit-Owner: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Reviewer: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Attention: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Attention: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Comment-Date: Fri, 12 Apr 2024 22:54:15 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in coreboot[main]: arch/arm64: Add EL1/EL2/EL3 support for arm64
by ron minnich (Code Review) 13 Apr '24

13 Apr '24

Attention is currently required from: Angel Pons, Arthur Heymans, Christian Walter, David Milosevic, Felix Singer, Martin L Roth, Maximilian Brune, Nico Huber. ron minnich has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74798?usp=email ) Change subject: arch/arm64: Add EL1/EL2/EL3 support for arm64 ...................................................................... Patch Set 17: Code-Review+2 (1 comment) Patchset: PS9: > The best is the enemy of the good, as the saying goes. […] I think we're good! -- To view, visit https://review.coreboot.org/c/coreboot/+/74798?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Iae1c57f0846c8d0585384f7e54102a837e701e7e Gerrit-Change-Number: 74798 Gerrit-PatchSet: 17 Gerrit-Owner: David Milosevic <David.Milosevic(a)9elements.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: ron minnich <rminnich(a)gmail.com> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-CC: Martin L Roth <gaumless(a)gmail.com> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-CC: Yidi Lin <yidilin(a)google.com> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: David Milosevic <David.Milosevic(a)9elements.com> Gerrit-Comment-Date: Fri, 12 Apr 2024 22:35:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: ron minnich <rminnich(a)gmail.com> Gerrit-MessageType: comment

1 0

[L] Change in coreboot[main]: superio/ite: Unify it8772f with common code
by Matt DeVillier (Code Review) 13 Apr '24

13 Apr '24

Attention is currently required from: Joel Linn, Michał Żygowski, MrChromebox, Piotr Król. Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81310?usp=email ) Change subject: superio/ite: Unify it8772f with common code ...................................................................... Patch Set 7: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/81310?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ic4d9d5460628e444dc20f620179b39c90dbc28c6 Gerrit-Change-Number: 81310 Gerrit-PatchSet: 7 Gerrit-Owner: Joel Linn <jl_coreboot(a)conductive.de> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: MrChromebox <mrchromebox(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Piotr Król <piotr.krol(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Joel Linn <jl_coreboot(a)conductive.de> Gerrit-Attention: MrChromebox <mrchromebox(a)gmail.com> Gerrit-Attention: Piotr Król <piotr.krol(a)3mdeb.com> Gerrit-Comment-Date: Fri, 12 Apr 2024 22:30:38 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: acpigen_ps2_keybd: Add Fn key to linux,keymap
by Aseda Aboagye (Code Review) 12 Apr '24

12 Apr '24

Aseda Aboagye has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/81895?usp=email ) Change subject: acpigen_ps2_keybd: Add Fn key to linux,keymap ...................................................................... acpigen_ps2_keybd: Add Fn key to linux,keymap Some devices may generate scancodes for the Fn key if they have one. If they do, we should add them to the linux,keymap binding. BUG=b:333096023 TEST=Flash DUT that emits a scancode for the Fn key, verify that it is mapped to KEY_FN in the Linux kernel. Change-Id: Ie4daa64bc6b619392276d0b5f16e2d195d5bd68c Signed-off-by: Aseda Aboagye <aaboagye(a)google.com> --- M src/acpi/Kconfig M src/acpi/acpigen_ps2_keybd.c 2 files changed, 14 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/95/81895/1 diff --git a/src/acpi/Kconfig b/src/acpi/Kconfig index 417ff60..70b2f12 100644 --- a/src/acpi/Kconfig +++ b/src/acpi/Kconfig @@ -14,6 +14,13 @@ Specifies the ACPI name format string used by the acpigen function to generate the processor scope. Default is CPxx. +config ACPI_FNKEY_GEN_SCANCODE + int + default 0 + help + Specifies the scancode, if any, which is generated when the + Fn key is pressed. + config ACPI_HAVE_PCAT_8259 def_bool y if !ACPI_NO_PCAT_8259 diff --git a/src/acpi/acpigen_ps2_keybd.c b/src/acpi/acpigen_ps2_keybd.c index 67e92a9..8084978 100644 --- a/src/acpi/acpigen_ps2_keybd.c +++ b/src/acpi/acpigen_ps2_keybd.c @@ -243,6 +243,13 @@ acpi_dp_add_integer(dp_array, NULL, keymap); } + /* Add the Fn-key */ + if (CONFIG_ACPI_FNKEY_GEN_SCANCODE != 0) { + acpi_dp_add_integer(dp_array, NULL, KEYMAP(CONFIG_ACPI_FNKEY_GEN_SCANCODE, + KEY_FN)); + total++; + } + total += num_top_row_keys; } -- To view, visit https://review.coreboot.org/c/coreboot/+/81895?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ie4daa64bc6b619392276d0b5f16e2d195d5bd68c Gerrit-Change-Number: 81895 Gerrit-PatchSet: 1 Gerrit-Owner: Aseda Aboagye <aaboagye(a)google.com> Gerrit-MessageType: newchange

1 0

[XS] Change in coreboot[main]: payloads/edk2/Makefile: Drop duplicated build string option
by Matt DeVillier (Code Review) 12 Apr '24

12 Apr '24

Attention is currently required from: Benjamin Doron, Lean Sheng Tan, Martin L Roth, Sean Rhodes. Hello Benjamin Doron, Lean Sheng Tan, Martin L Roth, Sean Rhodes, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/81894?usp=email to look at the new patch set (#2). Change subject: payloads/edk2/Makefile: Drop duplicated build string option ...................................................................... payloads/edk2/Makefile: Drop duplicated build string option The `PRIORITIZE_INTERNAL` option has been upstreamed, so remove the copy under the MrChromebox repo specific settings. TEST=build qemu w/edk2 payload, check build log that the 'PRIORITIZE_INTERNAL' option is only added once to the build string. Change-Id: I4c4c433184d93337c926e256e77054afc00a2566 Signed-off-by: Matt DeVillier <matt.devillier(a)gmail.com> --- M payloads/external/edk2/Makefile 1 file changed, 0 insertions(+), 4 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/94/81894/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/81894?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I4c4c433184d93337c926e256e77054afc00a2566 Gerrit-Change-Number: 81894 Gerrit-PatchSet: 2 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Benjamin Doron <benjamin.doron00(a)gmail.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Benjamin Doron <benjamin.doron00(a)gmail.com> Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-MessageType: newpatchset

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit April 2024