Attention is currently required from: Jason Nien, Martin Roth.
Matt DeVillier has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/81869?usp=email )
Change subject: mb/google/zork: Increase SMMSTORE size to 256K
......................................................................
mb/google/zork: Increase SMMSTORE size to 256K
Anything below 128K will cause SMMSTORE driver in edk2 to fail, since
a minimum of (2) 64K blocks are needed. Increase the size to 256K to
match other boards in the tree.
TEST=build/boot zork (morphius) with SMMSTORE enabled.
Change-Id: Ifd3be9b0757e270d2f106e2fbebf3991e49dec65
Signed-off-by: Matt DeVillier <matt.devillier(a)gmail.com>
---
M src/mainboard/google/zork/chromeos.fmd
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/69/81869/1
diff --git a/src/mainboard/google/zork/chromeos.fmd b/src/mainboard/google/zork/chromeos.fmd
index 4d2eda0..b405b2f 100644
--- a/src/mainboard/google/zork/chromeos.fmd
+++ b/src/mainboard/google/zork/chromeos.fmd
@@ -19,7 +19,7 @@
RW_VPD(PRESERVE) 8K
RW_NVRAM(PRESERVE) 20K
PAD_TO_ALIGN_STORE 16K
- SMMSTORE(PRESERVE) 64K
+ SMMSTORE(PRESERVE) 256K
RW_LEGACY(CBFS)
WP_RO@8M 8M {
RO_VPD(PRESERVE) 16K
--
To view, visit https://review.coreboot.org/c/coreboot/+/81869?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ifd3be9b0757e270d2f106e2fbebf3991e49dec65
Gerrit-Change-Number: 81869
Gerrit-PatchSet: 1
Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: Jason Nien <jason.nien(a)amd.corp-partner.google.com>
Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com>
Gerrit-Attention: Jason Nien <jason.nien(a)amd.corp-partner.google.com>
Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com>
Gerrit-MessageType: newchange
Attention is currently required from: Jason Nien, Martin Roth.
Matt DeVillier has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/81868?usp=email )
Change subject: mb/google/skyrim: Increase SMMSTORE size to 256K
......................................................................
mb/google/skyrim: Increase SMMSTORE size to 256K
Anything below 128K will cause SMMSTORE driver in edk2 to fail, since
a minimum of (2) 64K blocks are needed. Increase the size to 256K to
match other boards in the tree.
TEST=build/boot skyrim (frostflow) with SMMSTORE enabled.
Change-Id: I34f9d27c27ab7148dfc530322f741a576c348de7
Signed-off-by: Matt DeVillier <matt.devillier(a)gmail.com>
---
M src/mainboard/google/skyrim/chromeos.fmd
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/68/81868/1
diff --git a/src/mainboard/google/skyrim/chromeos.fmd b/src/mainboard/google/skyrim/chromeos.fmd
index 217fa98..afc6ce1 100644
--- a/src/mainboard/google/skyrim/chromeos.fmd
+++ b/src/mainboard/google/skyrim/chromeos.fmd
@@ -20,7 +20,7 @@
}
RW_VPD(PRESERVE) 8K
RW_NVRAM(PRESERVE) 20K
- SMMSTORE(PRESERVE)@0x630000 64K
+ SMMSTORE(PRESERVE)@0x630000 256K
RW_VBIOS_CACHE 64K
RECOVERY_MRC_CACHE(PRESERVE) 120K
RW_LEGACY(CBFS)
--
To view, visit https://review.coreboot.org/c/coreboot/+/81868?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I34f9d27c27ab7148dfc530322f741a576c348de7
Gerrit-Change-Number: 81868
Gerrit-PatchSet: 1
Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: Jason Nien <jason.nien(a)amd.corp-partner.google.com>
Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com>
Gerrit-Attention: Jason Nien <jason.nien(a)amd.corp-partner.google.com>
Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com>
Gerrit-MessageType: newchange
Matt DeVillier has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/81867?usp=email )
Change subject: mb/google/myst: Increase SMMSTORE size to 256K
......................................................................
mb/google/myst: Increase SMMSTORE size to 256K
Anything below 128K will cause SMMSTORE driver in edk2 to fail, since
a minimum of (2) 64K blocks are needed. Increase the size to 256K to
match other boards in the tree.
Change-Id: Ic45324b8c5bbd205e889e934c9d5dd17f7775152
Signed-off-by: Matt DeVillier <matt.devillier(a)gmail.com>
---
M src/mainboard/google/myst/chromeos.fmd
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/67/81867/1
diff --git a/src/mainboard/google/myst/chromeos.fmd b/src/mainboard/google/myst/chromeos.fmd
index f57a883..2bfa260 100644
--- a/src/mainboard/google/myst/chromeos.fmd
+++ b/src/mainboard/google/myst/chromeos.fmd
@@ -30,7 +30,7 @@
}
RW_VPD(PRESERVE) 8K
RW_NVRAM(PRESERVE) 20K
- SMMSTORE(PRESERVE) 64K
+ SMMSTORE(PRESERVE) 256K
RW_LEGACY(CBFS)
RW_VBIOS_CACHE 64K
RW_MRC_CACHE 256K
--
To view, visit https://review.coreboot.org/c/coreboot/+/81867?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ic45324b8c5bbd205e889e934c9d5dd17f7775152
Gerrit-Change-Number: 81867
Gerrit-PatchSet: 1
Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-MessageType: newchange
Attention is currently required from: Jason Nien, Martin Roth.
Matt DeVillier has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/81866?usp=email )
Change subject: mb/google/guybrush: Increase SMMSTORE size to 256K
......................................................................
mb/google/guybrush: Increase SMMSTORE size to 256K
Anything below 128K will cause SMMSTORE driver in edk2 to fail, since
a minimum of (2) 64K blocks are needed. Increase the size to 256K to
match other boards in the tree.
TEST=build/boot guybrush (dewatt) with SMMSTORE enabled.
Change-Id: Ic4fdacd493d83fa3c1683a06d1276b0190f6db8b
Signed-off-by: Matt DeVillier <matt.devillier(a)gmail.com>
---
M src/mainboard/google/guybrush/chromeos.fmd
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/66/81866/1
diff --git a/src/mainboard/google/guybrush/chromeos.fmd b/src/mainboard/google/guybrush/chromeos.fmd
index 225fe2a..c4c90a1 100644
--- a/src/mainboard/google/guybrush/chromeos.fmd
+++ b/src/mainboard/google/guybrush/chromeos.fmd
@@ -18,7 +18,7 @@
}
RW_VPD(PRESERVE) 8K
RW_NVRAM(PRESERVE) 20K
- SMMSTORE(PRESERVE)@0x620000 64K
+ SMMSTORE(PRESERVE)@0x620000 256K
RW_LEGACY(CBFS)
WP_RO@8M 8M {
RO_VPD(PRESERVE) 16K
--
To view, visit https://review.coreboot.org/c/coreboot/+/81866?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ic4fdacd493d83fa3c1683a06d1276b0190f6db8b
Gerrit-Change-Number: 81866
Gerrit-PatchSet: 1
Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: Jason Nien <jason.nien(a)amd.corp-partner.google.com>
Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com>
Gerrit-Attention: Jason Nien <jason.nien(a)amd.corp-partner.google.com>
Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com>
Gerrit-MessageType: newchange
Attention is currently required from: Arthur Heymans.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80337?usp=email )
Change subject: cpu/x86: Link page tables in stage if possible
......................................................................
Patch Set 22:
(1 comment)
Patchset:
PS22:
> > > > > Thankyou @arthur. Above mentioned patch was not part of the build as it is not yet mirrored to the chromium repo. Tried adding it still failed. Then added a fixed number as suggested then it is building. https://review.coreboot.org/c/coreboot/+/81680
> > > >
> > > > we have filled an internal bug as well b/332445618 to follow on the fix.
> > >
> > > HI Arthur,
> > >
> > > I am reaching out to you today to inquire about the possibility of finding a solution to the section region overlapping issue without having to update the linker version.
> > >
> > > Do you have any suggestions for a similar or better solution?
> > >
> > > https://review.coreboot.org/c/coreboot/+/81680/1/src/arch/x86/bootblock.ld
> > >
> > > Our current efforts have been stymied by a cyclical dependency between updating the binutil from 2.37 to 2.4x within the chromium code repo. The most recent version of binutil is causing FSP build regressions in 32-bit mode. Unless the Intel/EDK2 team can debug and resolve this issue, we may not be able to update the linker. As a result, we will continue to experience the section overlapping issue. Please let me know your thoughts on this matter.
> > >
> > > We are working to update the linker within the chromium build, and once that has been completed, we can revert the proposed W/A CL. However, until then, we must find a solution in order to make progress.
> >
> > Add a Kconfig for a workaround that adds a fixed number to PROGRAM_SZ that makes all your builds succeed?
>
> Thanks Arthur for prompt response.
>
> Let me submit the CL.
Hello Arthur, As discussed in our last conversation, I had planned to push a kconfig change to make extra space available for PROGRAM_SZ (between .text and .data). However, after cherry-picking CB:80346 and CB:81434 into the chromium repository, I am unable to replicate the overlap issue.
Therefore, I will refrain from pushing any changes and keep an eye on this. As it stands, we are in good shape as long as CB:80346 and CB:81434 are landed in mainline.
--
To view, visit https://review.coreboot.org/c/coreboot/+/80337?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ied54b66b930187cba5fbc578a81ed5859a616562
Gerrit-Change-Number: 80337
Gerrit-PatchSet: 22
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com>
Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Reviewer: Shuo Liu <shuo.liu(a)intel.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com>
Gerrit-CC: Appukuttan V K <appukuttan.vk(a)intel.com>
Gerrit-CC: Lean Sheng Tan <sheng.tan(a)9elements.com>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Comment-Date: Fri, 12 Apr 2024 19:04:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Appukuttan V K <appukuttan.vk(a)intel.com>
Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com>
Comment-In-Reply-To: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-MessageType: comment
Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/79761?usp=email )
Change subject: nb/intel/sandybridge/raminit: Only write register on Ivy Bridge
......................................................................
nb/intel/sandybridge/raminit: Only write register on Ivy Bridge
Only write register WMM_READ_CONFIG on Ivy Bridge as it's
reserved on Sandy Bridge.
Tested on Lenovo X220: Still boots and runs fine.
Change-Id: Ie14ea06d744b1a8368d32803c6c1ccfb1262532e
Signed-off-by: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/79761
Reviewed-by: Paul Menzel <paulepanter(a)mailbox.org>
Reviewed-by: Angel Pons <th3fanbus(a)gmail.com>
Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org>
Reviewed-by: Felix Held <felix-coreboot(a)felixheld.de>
---
M src/northbridge/intel/sandybridge/raminit_common.c
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Angel Pons: Looks good to me, approved
Felix Held: Looks good to me, approved
Paul Menzel: Looks good to me, but someone else must approve
build bot (Jenkins): Verified
diff --git a/src/northbridge/intel/sandybridge/raminit_common.c b/src/northbridge/intel/sandybridge/raminit_common.c
index d6d545c..fea3ca4 100644
--- a/src/northbridge/intel/sandybridge/raminit_common.c
+++ b/src/northbridge/intel/sandybridge/raminit_common.c
@@ -2809,8 +2809,8 @@
int t3_ns;
u32 r32;
- /* FIXME: This register only exists on Ivy Bridge */
- mchbar_write32(WMM_READ_CONFIG, 0x46);
+ if (IS_IVY_CPU(ctrl->cpu))
+ mchbar_write32(WMM_READ_CONFIG, 0x46);
FOR_ALL_CHANNELS {
union tc_othp_reg tc_othp = {
--
To view, visit https://review.coreboot.org/c/coreboot/+/79761?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ie14ea06d744b1a8368d32803c6c1ccfb1262532e
Gerrit-Change-Number: 79761
Gerrit-PatchSet: 4
Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-MessageType: merged