Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/81550?usp=email )
Change subject: mb/dell/optiplex_9020: Fix SATA port maps
......................................................................
mb/dell/optiplex_9020: Fix SATA port maps
Previously incorrect sets of SATA ports were enabled.
There are no publically available schematics, but I am almost certain
the new values are correct.
The original 0x33 value was carlessly copy pasted, and only enables
ports 0, 1, 4, 5, leaving 2, 3 disabled.
On the SFF, with 0x33 only the first 2 ports worked. I have verified
by plugging in devices under the stock firmware that 0, 1, 2 are the
ones that should be enabled, so setting the value to 0x7 per datasheet.
This was also tested in practice to work.
I don't have an MT, but I was told the two white ports didn't work
with 0x33, so those are most certainly ports 3, 4, hence me setting
the value to 0xf. If the MT's working ports are port 0, 1 on the PCH
this is correct.
Signed-off-by: Mate Kukri <kukri.mate(a)gmail.com>
Change-Id: I32cb236b8f8140fba4a04c23161363d21741dcbc
Reviewed-on: https://review.coreboot.org/c/coreboot/+/81550
Reviewed-by: Paul Menzel <paulepanter(a)mailbox.org>
Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org>
Reviewed-by: Angel Pons <th3fanbus(a)gmail.com>
Reviewed-by: Eric Lai <ericllai(a)google.com>
---
M src/mainboard/dell/optiplex_9020/devicetree.cb
M src/mainboard/dell/optiplex_9020/overridetree_mt.cb
2 files changed, 3 insertions(+), 1 deletion(-)
Approvals:
Eric Lai: Looks good to me, approved
build bot (Jenkins): Verified
Paul Menzel: Looks good to me, but someone else must approve
Angel Pons: Looks good to me, approved
diff --git a/src/mainboard/dell/optiplex_9020/devicetree.cb b/src/mainboard/dell/optiplex_9020/devicetree.cb
index c0b17a1..dce5869 100644
--- a/src/mainboard/dell/optiplex_9020/devicetree.cb
+++ b/src/mainboard/dell/optiplex_9020/devicetree.cb
@@ -23,7 +23,7 @@
register "gen2_dec" = "0x007c0901"
register "gen3_dec" = "0x003c07e1"
register "gen4_dec" = "0x001c0901"
- register "sata_port_map" = "0x33"
+ register "sata_port_map" = "0x7"
device pci 14.0 on end # xHCI controller
device pci 16.0 on end # Management Engine interface 1
diff --git a/src/mainboard/dell/optiplex_9020/overridetree_mt.cb b/src/mainboard/dell/optiplex_9020/overridetree_mt.cb
index 90205c2..a781960 100644
--- a/src/mainboard/dell/optiplex_9020/overridetree_mt.cb
+++ b/src/mainboard/dell/optiplex_9020/overridetree_mt.cb
@@ -3,6 +3,8 @@
chip northbridge/intel/haswell
device domain 0 on
chip southbridge/intel/lynxpoint
+ register "sata_port_map" = "0xf"
+
device pci 1c.1 on end # PCI (via XIO2001 bridge)
device pci 1c.2 on end # PCIe 1x slot
end
--
To view, visit https://review.coreboot.org/c/coreboot/+/81550?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I32cb236b8f8140fba4a04c23161363d21741dcbc
Gerrit-Change-Number: 81550
Gerrit-PatchSet: 4
Gerrit-Owner: Máté Kukri <kukri.mate(a)gmail.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Eric Lai <ericllai(a)google.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-MessageType: merged
Attention is currently required from: Jakub Czapiga, Julius Werner, Martin L Roth.
Maximilian Brune has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81081?usp=email )
Change subject: lib/device_tree: Add some FDT helper functions
......................................................................
Patch Set 18:
(1 comment)
File src/lib/device_tree.c:
https://review.coreboot.org/c/coreboot/+/81081/comment/8d97837b_0f4d6661 :
PS18, Line 175: ""
> Okay, sorry, I see your point now. […]
```
In that case, how about just making the function take both offsets (parent_node_offset and child_array_offset) as parameters instead?
```
I have to return the addr-cells and size-cells, but changing the order of the `*path == NULL` check makes it tricky, because instead of getting the addr-cells/size-cells of the parent I will get it from the current node. Any suggestions?
--
To view, visit https://review.coreboot.org/c/coreboot/+/81081?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I2fb1d93c5b3e1cb2f7d9584db52bbce3767b63d8
Gerrit-Change-Number: 81081
Gerrit-PatchSet: 18
Gerrit-Owner: Maximilian Brune <maximilian.brune(a)9elements.com>
Gerrit-Reviewer: Jakub Czapiga <czapiga(a)google.com>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Alper Nebi Yasak <alpernebiyasak(a)gmail.com>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Jakub Czapiga <czapiga(a)google.com>
Gerrit-Attention: Julius Werner <jwerner(a)chromium.org>
Gerrit-Comment-Date: Fri, 12 Apr 2024 16:10:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Julius Werner <jwerner(a)chromium.org>
Comment-In-Reply-To: Maximilian Brune <maximilian.brune(a)9elements.com>
Gerrit-MessageType: comment
Attention is currently required from: Eric Lai.
Elyes Haouas has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81824?usp=email )
Change subject: include: Add 'IWYU pragma: export' comment
......................................................................
Patch Set 3:
(1 comment)
File src/include/device/device.h:
https://review.coreboot.org/c/coreboot/+/81824/comment/4ed92080_b1f04885 :
PS2, Line 12: #include <device/pci_type.h>
> to move <device/pci_type. […]
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/81824?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I3acb5e6b18443e454d8174b0b1f9d207c0fb78b5
Gerrit-Change-Number: 81824
Gerrit-PatchSet: 3
Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Eric Lai <ericllai(a)google.com>
Gerrit-Attention: Eric Lai <ericllai(a)google.com>
Gerrit-Comment-Date: Fri, 12 Apr 2024 15:53:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Eric Lai <ericllai(a)google.com>
Comment-In-Reply-To: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-MessageType: comment
Attention is currently required from: Angel Pons, Felix Singer, Martin L Roth.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68188?usp=email )
Change subject: mb/asrock/z97_extreme6: Add new mainboard
......................................................................
Patch Set 6: Code-Review+1
--
To view, visit https://review.coreboot.org/c/coreboot/+/68188?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: If1d22547725e59f435de36b973e1bf4f334269a9
Gerrit-Change-Number: 68188
Gerrit-PatchSet: 6
Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Lean Sheng Tan <sheng.tan(a)9elements.com>
Gerrit-CC: Martin L Roth <gaumless(a)gmail.com>
Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Comment-Date: Fri, 12 Apr 2024 15:05:45 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: CoolStar, Felix Held, Fred Reitberger, Jason Glenesk, Matt DeVillier.
Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81858?usp=email )
Change subject: soc/amd/picasso: Mark eMMC as non-removable for Windows 10/11 install
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/81858?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: If0e14106521f99cb97d1bf421f4d82d1234c2f15
Gerrit-Change-Number: 81858
Gerrit-PatchSet: 2
Gerrit-Owner: CoolStar <coolstarorganization(a)gmail.com>
Gerrit-Reviewer: CoolStar <coolstarorganization(a)gmail.com>
Gerrit-Reviewer: Eric Lai <ericllai(a)google.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com>
Gerrit-Attention: CoolStar <coolstarorganization(a)gmail.com>
Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Comment-Date: Fri, 12 Apr 2024 14:07:20 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Martin L Roth.
Maximilian Brune has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81859?usp=email )
Change subject: configs: Add Hifive Unleashed config with OpenSBI
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
I noticed that jenkins did not use the config that I added. Is that normal or am I missing something?
--
To view, visit https://review.coreboot.org/c/coreboot/+/81859?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I2101b194bf0d74f4f444fba507e0294bddc746d3
Gerrit-Change-Number: 81859
Gerrit-PatchSet: 2
Gerrit-Owner: Maximilian Brune <maximilian.brune(a)9elements.com>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Comment-Date: Fri, 12 Apr 2024 14:06:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment