coreboot-gerrit April 2024

coreboot-gerrit@coreboot.org

1 participants
3293 discussions

[XS] Change in coreboot[main]: configs: Add Hifive Unleashed config with OpenSBI
by Maximilian Brune (Code Review) 12 Apr '24

12 Apr '24

Maximilian Brune has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/81859?usp=email ) Change subject: configs: Add Hifive Unleashed config with OpenSBI ...................................................................... configs: Add Hifive Unleashed config with OpenSBI OpenSBI often breaks if you update it. This should ensure that jenkins keeps an eye on it. Signed-off-by: Maximilian Brune <maximilian.brune(a)9elements.com> Change-Id: I2101b194bf0d74f4f444fba507e0294bddc746d3 --- A configs/config.sifive_unleashed.opensbi 1 file changed, 3 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/59/81859/1 diff --git a/configs/config.sifive_unleashed.opensbi b/configs/config.sifive_unleashed.opensbi new file mode 100644 index 0000000..3772792 --- /dev/null +++ b/configs/config.sifive_unleashed.opensbi @@ -0,0 +1,3 @@ +CONFIG_VENDOR_SIFIVE=y +CONFIG_BOARD_SIFIVE_HIFIVE_UNLEASHED=y +CONFIG_RISCV_OPENSBI=y -- To view, visit https://review.coreboot.org/c/coreboot/+/81859?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I2101b194bf0d74f4f444fba507e0294bddc746d3 Gerrit-Change-Number: 81859 Gerrit-PatchSet: 1 Gerrit-Owner: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-MessageType: newchange

1 0

[S] Change in libgfxinit[main]: gfxtest: Fix out-of-order components, permanently
by Elyes Haouas (Code Review) 12 Apr '24

12 Apr '24

Attention is currently required from: Angel Pons. Elyes Haouas has posted comments on this change. ( https://review.coreboot.org/c/libgfxinit/+/81854?usp=email ) Change subject: gfxtest: Fix out-of-order components, permanently ...................................................................... Patch Set 1: (1 comment) File gfxtest/hw-gfx-gma-gfx_test.adb: https://review.coreboot.org/c/libgfxinit/+/81854/comment/50f5d81a_5ad43d0f : PS1, Line 54: Blue : Byte; : Green : Byte; : Red : Byte; > Problem is, this record defines the byte ordering for the hardware. […] Acknowledged -- To view, visit https://review.coreboot.org/c/libgfxinit/+/81854?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: libgfxinit Gerrit-Branch: main Gerrit-Change-Id: I77dbdcd6c235e411585585779c31777adcef57d0 Gerrit-Change-Number: 81854 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-CC: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Fri, 12 Apr 2024 12:09:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Comment-In-Reply-To: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: superio/ite: Add function to disable PME# output
by Angel Pons (Code Review) 12 Apr '24

12 Apr '24

Attention is currently required from: Joel Linn. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81589?usp=email ) Change subject: superio/ite: Add function to disable PME# output ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/81589?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I94f023ba6eb24b5fb1c5e0b30eb65738f50a87eb Gerrit-Change-Number: 81589 Gerrit-PatchSet: 1 Gerrit-Owner: Joel Linn <jl_coreboot(a)conductive.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Joel Linn <jl_coreboot(a)conductive.de> Gerrit-Comment-Date: Fri, 12 Apr 2024 11:41:03 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: superio/ite: Add function to disable 3VSBSW# signal
by Angel Pons (Code Review) 12 Apr '24

12 Apr '24

Attention is currently required from: Joel Linn. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81588?usp=email ) Change subject: superio/ite: Add function to disable 3VSBSW# signal ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/81588?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I8535176908ec39e9916774135e028cbc7c203474 Gerrit-Change-Number: 81588 Gerrit-PatchSet: 1 Gerrit-Owner: Joel Linn <jl_coreboot(a)conductive.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Joel Linn <jl_coreboot(a)conductive.de> Gerrit-Comment-Date: Fri, 12 Apr 2024 11:40:41 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: sb/intel/bd82x6x: Add four new USB currents
by Angel Pons (Code Review) 12 Apr '24

12 Apr '24

Attention is currently required from: Joel Linn. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81427?usp=email ) Change subject: sb/intel/bd82x6x: Add four new USB currents ...................................................................... Patch Set 4: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/81427?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I156787e533c2605e7440548a2d3bf711bb1af5d7 Gerrit-Change-Number: 81427 Gerrit-PatchSet: 4 Gerrit-Owner: Joel Linn <jl_coreboot(a)conductive.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Joel Linn <jl_coreboot(a)conductive.de> Gerrit-Comment-Date: Fri, 12 Apr 2024 11:40:04 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[L] Change in coreboot[main]: mb/hp: Add Pro 3500 series (Sandy/Ivy Bridge)
by Angel Pons (Code Review) 12 Apr '24

12 Apr '24

Attention is currently required from: Felix Singer, Joel Linn, Matt DeVillier. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81368?usp=email ) Change subject: mb/hp: Add Pro 3500 series (Sandy/Ivy Bridge) ...................................................................... Patch Set 5: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/81368?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Idf793fe915096cf2553572964faec5c7f8526b9a Gerrit-Change-Number: 81368 Gerrit-PatchSet: 5 Gerrit-Owner: Joel Linn <jl_coreboot(a)conductive.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Attention: Joel Linn <jl_coreboot(a)conductive.de> Gerrit-Comment-Date: Fri, 12 Apr 2024 11:39:36 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[L] Change in coreboot[main]: mb/asrock: Add Z87E-ITX (Haswell)
by Angel Pons (Code Review) 12 Apr '24

12 Apr '24

Attention is currently required from: Máté Kukri, Nicholas Chin. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81022?usp=email ) Change subject: mb/asrock: Add Z87E-ITX (Haswell) ...................................................................... Patch Set 2: Code-Review+1 (6 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/81022/comment/044f6304_762ab920 : PS2, Line 14: socketted nit: socketed (one t) File src/mainboard/asrock/z87e-itx/devicetree.cb: https://review.coreboot.org/c/coreboot/+/81022/comment/c2ddc980_62d3934d : PS2, Line 4: register "ec_present" = "false" Any zero/false options can be omitted https://review.coreboot.org/c/coreboot/+/81022/comment/ffa07541_1f8d86d4 : PS2, Line 10: register "panel_cfg" = "{ : .up_delay_ms = 0, : .down_delay_ms = 0, : .cycle_delay_ms = 500, : .backlight_on_delay_ms = 0, : .backlight_off_delay_ms = 0, : .backlight_pwm_hz = 0, : }" There's no panel on this board File src/mainboard/asrock/z87e-itx/gma-mainboard.ads: https://review.coreboot.org/c/coreboot/+/81022/comment/b824f1a8_ed5a196f : PS2, Line 20: LVDS, : eDP Replace these two with `others => Disabled` File src/mainboard/asrock/z87e-itx/hda_verb.c: https://review.coreboot.org/c/coreboot/+/81022/comment/3f9996ad_c22be0f6 : PS2, Line 20: > This board seems to have HDMI. […] I thought Haswell already incorporates HDA verbs for the Mini-HD in chipset code File src/mainboard/asrock/z87e-itx/romstage.c: https://review.coreboot.org/c/coreboot/+/81022/comment/6075a723_04f1e95c : PS2, Line 19: /* FIXME: check this */ > Can you check which ones are needed with `i2cdetect`? It's most likely 0x50 and 0x52, the first slot of each channel. -- To view, visit https://review.coreboot.org/c/coreboot/+/81022?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I56c22d8f5505f9a4da25f8b4406b00978af1a586 Gerrit-Change-Number: 81022 Gerrit-PatchSet: 2 Gerrit-Owner: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Máté Kukri <kukri.mate(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Máté Kukri <kukri.mate(a)gmail.com> Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Comment-Date: Fri, 12 Apr 2024 11:35:44 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Máté Kukri <kukri.mate(a)gmail.com> Gerrit-MessageType: comment

1 0

[M] Change in coreboot[main]: mb/google/brox: Create greenbayupoc variant
by Paul Menzel (Code Review) 12 Apr '24

12 Apr '24

Attention is currently required from: Eren Peng, Ivan Chen, Karthik Ramasubramanian, Sumeet R Pawnikar. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81565?usp=email ) Change subject: mb/google/brox: Create greenbayupoc variant ...................................................................... Patch Set 5: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/81565?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I90936d97b41e59c49dd92997146caf580bce1f4f Gerrit-Change-Number: 81565 Gerrit-PatchSet: 5 Gerrit-Owner: Eren Peng <peng.eren(a)inventec.corp-partner.google.com> Gerrit-Reviewer: Ivan Chen <yulunchen(a)google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Garen Wu <wu.garen(a)inventec.corp-partner.google.com> Gerrit-CC: Rasheed Hsueh <hsueh.rasheed(a)inventec.corp-partner.google.com> Gerrit-CC: Steven Yeh <yeh.stevenct(a)inventec.corp-partner.google.com> Gerrit-Attention: Eren Peng <peng.eren(a)inventec.corp-partner.google.com> Gerrit-Attention: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Attention: Ivan Chen <yulunchen(a)google.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Comment-Date: Fri, 12 Apr 2024 10:02:04 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: mb/google/brox/var/greenbayupoc: Add fw_config field for storage
by Paul Menzel (Code Review) 12 Apr '24

12 Apr '24

Attention is currently required from: Eren Peng, Ivan Chen, Nick Vaccaro, Shelley Chen. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81833?usp=email ) Change subject: mb/google/brox/var/greenbayupoc: Add fw_config field for storage ...................................................................... Patch Set 2: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/81833/comment/b8a4479e_d2d811f5 : PS2, Line 9: Add fw_config field for storage to prevent depthcharge build break Please mention the options, and add a dot/period at the end of sentences. -- To view, visit https://review.coreboot.org/c/coreboot/+/81833?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I0e220787d6ac73ec8fa2469ed958981d0801920e Gerrit-Change-Number: 81833 Gerrit-PatchSet: 2 Gerrit-Owner: Eren Peng <peng.eren(a)inventec.corp-partner.google.com> Gerrit-Reviewer: Ivan Chen <yulunchen(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Eric Lai <ericllai(a)google.com> Gerrit-CC: Garen Wu <wu.garen(a)inventec.corp-partner.google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Rasheed Hsueh <hsueh.rasheed(a)inventec.corp-partner.google.com> Gerrit-CC: Steven Yeh <yeh.stevenct(a)inventec.corp-partner.google.com> Gerrit-Attention: Shelley Chen <shchen(a)google.com> Gerrit-Attention: Eren Peng <peng.eren(a)inventec.corp-partner.google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Attention: Ivan Chen <yulunchen(a)google.com> Gerrit-Comment-Date: Fri, 12 Apr 2024 10:01:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: mb/google/corsola: Add new board Veluza
by Yu-Ping Wu (Code Review) 12 Apr '24

12 Apr '24

Attention is currently required from: Frank Wu, Hung-Te Lin, Ian Feng, John Su, Paul Menzel, Shawn Ku, Shawn Ku, Yidi Lin. Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81791?usp=email ) Change subject: mb/google/corsola: Add new board Veluza ...................................................................... Patch Set 3: Code-Review+2 (1 comment) File src/mainboard/google/corsola/Kconfig: https://review.coreboot.org/c/coreboot/+/81791/comment/74282325_83a106a5 : PS3, Line 93: default "Veluza" if BOARD_GOOGLE_VELUZA > Is there a reason, this list list is not sorted? Yeah, I'd also prefer sorting these, but probably in a separate patch. -- To view, visit https://review.coreboot.org/c/coreboot/+/81791?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Idedcbfbddd6d98a51cf28a0963d68f6d8c68382c Gerrit-Change-Number: 81791 Gerrit-PatchSet: 3 Gerrit-Owner: Frank Wu <frank_wu(a)compal.corp-partner.google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Ian Feng <ian_feng(a)compal.corp-partner.google.com> Gerrit-Reviewer: John Su <john_su(a)compal.corp-partner.google.com> Gerrit-Reviewer: Shawn Ku <shawnku(a)chromium.org> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Jasper Lee <jasper_lee(a)compal.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Shawn Ku <shawnku(a)google.com> Gerrit-CC: Van Chen <van_chen(a)compal.corp-partner.google.com> Gerrit-Attention: Frank Wu <frank_wu(a)compal.corp-partner.google.com> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: John Su <john_su(a)compal.corp-partner.google.com> Gerrit-Attention: Ian Feng <ian_feng(a)compal.corp-partner.google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Shawn Ku <shawnku(a)google.com> Gerrit-Attention: Shawn Ku <shawnku(a)chromium.org> Gerrit-Attention: Yidi Lin <yidilin(a)google.com> Gerrit-Comment-Date: Fri, 12 Apr 2024 09:52:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit April 2024