Attention is currently required from: Jianeng Ceng, Subrata Banik.
Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81773?usp=email )
Change subject: drivers/i2c/rt5645: Add RT5645 amp driver
......................................................................
Patch Set 9: Code-Review+1
(1 comment)
File src/drivers/i2c/rt5645/rt5645.c:
https://review.coreboot.org/c/coreboot/+/81773/comment/d8291e71_4b3ac33a :
PS9, Line 11: #define RT5645_DP_INT(key, val) \
no need macro if just use ones
--
To view, visit https://review.coreboot.org/c/coreboot/+/81773?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I602fcc4dd8576043943f6e20884edc4703350320
Gerrit-Change-Number: 81773
Gerrit-PatchSet: 9
Gerrit-Owner: Jianeng Ceng <cengjianeng(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Dolan Liu <liuyong5(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Eric Lai <ericllai(a)google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Jianeng Ceng <cengjianeng(a)huaqin.corp-partner.google.com>
Gerrit-Comment-Date: Fri, 12 Apr 2024 07:39:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Dinesh Gehlot, Eric Lai, Jianeng Ceng, Kapil Porwal, Nick Vaccaro, Subrata Banik.
Dolan Liu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81774?usp=email )
Change subject: mb/google/nissa/var/anraggar: Add cbj_sleeve to control mic jack
......................................................................
Patch Set 6: Code-Review+1
--
To view, visit https://review.coreboot.org/c/coreboot/+/81774?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I093be6a3e357aae389fcbe8291a9701c40b62e15
Gerrit-Change-Number: 81774
Gerrit-PatchSet: 6
Gerrit-Owner: Jianeng Ceng <cengjianeng(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Reviewer: Dolan Liu <liuyong5(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Eric Lai <ericllai(a)google.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Eric Lai <ericllai(a)google.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Attention: Jianeng Ceng <cengjianeng(a)huaqin.corp-partner.google.com>
Gerrit-Comment-Date: Fri, 12 Apr 2024 07:28:43 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Jianeng Ceng, Subrata Banik.
Dolan Liu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81788?usp=email )
Change subject: drivers/i2c/generic: Add i2c_generic_write_gpio for public
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://review.coreboot.org/c/coreboot/+/81788?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ifb2e60690711b39743afd455c6776c5ace863378
Gerrit-Change-Number: 81788
Gerrit-PatchSet: 1
Gerrit-Owner: Jianeng Ceng <cengjianeng(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Dolan Liu <liuyong5(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Eric Lai <ericllai(a)google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Jianeng Ceng <cengjianeng(a)huaqin.corp-partner.google.com>
Gerrit-Comment-Date: Fri, 12 Apr 2024 07:28:32 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Eric Lai, Jianeng Ceng, Subrata Banik.
Dolan Liu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81773?usp=email )
Change subject: drivers/i2c/rt5645: Add RT5645 amp driver
......................................................................
Patch Set 9: Code-Review+1
--
To view, visit https://review.coreboot.org/c/coreboot/+/81773?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I602fcc4dd8576043943f6e20884edc4703350320
Gerrit-Change-Number: 81773
Gerrit-PatchSet: 9
Gerrit-Owner: Jianeng Ceng <cengjianeng(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Dolan Liu <liuyong5(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Eric Lai <ericllai(a)google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Eric Lai <ericllai(a)google.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Jianeng Ceng <cengjianeng(a)huaqin.corp-partner.google.com>
Gerrit-Comment-Date: Fri, 12 Apr 2024 07:28:19 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Arthur Heymans.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80337?usp=email )
Change subject: cpu/x86: Link page tables in stage if possible
......................................................................
Patch Set 22:
(1 comment)
Patchset:
PS22:
> > > > Thankyou @arthur. Above mentioned patch was not part of the build as it is not yet mirrored to the chromium repo. Tried adding it still failed. Then added a fixed number as suggested then it is building. https://review.coreboot.org/c/coreboot/+/81680
> > >
> > > we have filled an internal bug as well b/332445618 to follow on the fix.
> >
> > HI Arthur,
> >
> > I am reaching out to you today to inquire about the possibility of finding a solution to the section region overlapping issue without having to update the linker version.
> >
> > Do you have any suggestions for a similar or better solution?
> >
> > https://review.coreboot.org/c/coreboot/+/81680/1/src/arch/x86/bootblock.ld
> >
> > Our current efforts have been stymied by a cyclical dependency between updating the binutil from 2.37 to 2.4x within the chromium code repo. The most recent version of binutil is causing FSP build regressions in 32-bit mode. Unless the Intel/EDK2 team can debug and resolve this issue, we may not be able to update the linker. As a result, we will continue to experience the section overlapping issue. Please let me know your thoughts on this matter.
> >
> > We are working to update the linker within the chromium build, and once that has been completed, we can revert the proposed W/A CL. However, until then, we must find a solution in order to make progress.
>
> Add a Kconfig for a workaround that adds a fixed number to PROGRAM_SZ that makes all your builds succeed?
Thanks Arthur for prompt response.
Let me submit the CL.
--
To view, visit https://review.coreboot.org/c/coreboot/+/80337?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ied54b66b930187cba5fbc578a81ed5859a616562
Gerrit-Change-Number: 80337
Gerrit-PatchSet: 22
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com>
Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Reviewer: Shuo Liu <shuo.liu(a)intel.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com>
Gerrit-CC: Appukuttan V K <appukuttan.vk(a)intel.com>
Gerrit-CC: Lean Sheng Tan <sheng.tan(a)9elements.com>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Comment-Date: Fri, 12 Apr 2024 07:27:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Appukuttan V K <appukuttan.vk(a)intel.com>
Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com>
Comment-In-Reply-To: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-MessageType: comment
Attention is currently required from: Dolan Liu, Eric Lai, Subrata Banik.
Hello Dolan Liu, Eric Lai, Subrata Banik, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/81773?usp=email
to look at the new patch set (#9).
Change subject: drivers/i2c/rt5645: Add RT5645 amp driver
......................................................................
drivers/i2c/rt5645: Add RT5645 amp driver
Add RT5645 AMP support.
Add acpi name cbj-sleeve-gpios for power gate GPIO.
Realtek upstream link:(https://lore.kernel.org/all/20240404035747.118064-1-derek.fang@realte…
BUG=None
TEST=RT5645 driver can probe properly.
Change-Id: I602fcc4dd8576043943f6e20884edc4703350320
Signed-off-by: Jianeng Ceng <cengjianeng(a)huaqin.corp-partner.google.com>
---
A src/drivers/i2c/rt5645/Kconfig
A src/drivers/i2c/rt5645/Makefile.mk
A src/drivers/i2c/rt5645/chip.h
A src/drivers/i2c/rt5645/rt5645.c
4 files changed, 141 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/73/81773/9
--
To view, visit https://review.coreboot.org/c/coreboot/+/81773?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I602fcc4dd8576043943f6e20884edc4703350320
Gerrit-Change-Number: 81773
Gerrit-PatchSet: 9
Gerrit-Owner: Jianeng Ceng <cengjianeng(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Dolan Liu <liuyong5(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Eric Lai <ericllai(a)google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Eric Lai <ericllai(a)google.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Dolan Liu <liuyong5(a)huaqin.corp-partner.google.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Dolan Liu, Eric Lai, Subrata Banik.
Hello Dolan Liu, Eric Lai, Subrata Banik, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/81773?usp=email
to look at the new patch set (#8).
The following approvals got outdated and were removed:
Verified+1 by build bot (Jenkins)
Change subject: drivers/i2c/rt5645: Add RT5645 amp driver
......................................................................
drivers/i2c/rt5645: Add RT5645 amp driver
Add RT5645 AMP support.
Add acpi name cbj-sleeve-gpios for sleeve power gate GPIO.
Realtek upstream link:(https://lore.kernel.org/all/20240404035747.118064-1-derek.fang@realte…
BUG=None
TEST=RT5645 driver can probe properly.
Change-Id: I602fcc4dd8576043943f6e20884edc4703350320
Signed-off-by: Jianeng Ceng <cengjianeng(a)huaqin.corp-partner.google.com>
---
A src/drivers/i2c/rt5645/Kconfig
A src/drivers/i2c/rt5645/Makefile.mk
A src/drivers/i2c/rt5645/chip.h
A src/drivers/i2c/rt5645/rt5645.c
4 files changed, 141 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/73/81773/8
--
To view, visit https://review.coreboot.org/c/coreboot/+/81773?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I602fcc4dd8576043943f6e20884edc4703350320
Gerrit-Change-Number: 81773
Gerrit-PatchSet: 8
Gerrit-Owner: Jianeng Ceng <cengjianeng(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Dolan Liu <liuyong5(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Eric Lai <ericllai(a)google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Eric Lai <ericllai(a)google.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Dolan Liu <liuyong5(a)huaqin.corp-partner.google.com>
Gerrit-MessageType: newpatchset
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80337?usp=email )
Change subject: cpu/x86: Link page tables in stage if possible
......................................................................
Patch Set 22:
(1 comment)
Patchset:
PS22:
> > > Thankyou @arthur. Above mentioned patch was not part of the build as it is not yet mirrored to the chromium repo. Tried adding it still failed. Then added a fixed number as suggested then it is building. https://review.coreboot.org/c/coreboot/+/81680
> >
> > we have filled an internal bug as well b/332445618 to follow on the fix.
>
> HI Arthur,
>
> I am reaching out to you today to inquire about the possibility of finding a solution to the section region overlapping issue without having to update the linker version.
>
> Do you have any suggestions for a similar or better solution?
>
> https://review.coreboot.org/c/coreboot/+/81680/1/src/arch/x86/bootblock.ld
>
> Our current efforts have been stymied by a cyclical dependency between updating the binutil from 2.37 to 2.4x within the chromium code repo. The most recent version of binutil is causing FSP build regressions in 32-bit mode. Unless the Intel/EDK2 team can debug and resolve this issue, we may not be able to update the linker. As a result, we will continue to experience the section overlapping issue. Please let me know your thoughts on this matter.
>
> We are working to update the linker within the chromium build, and once that has been completed, we can revert the proposed W/A CL. However, until then, we must find a solution in order to make progress.
Add a Kconfig for a workaround that adds a fixed number to PROGRAM_SZ that makes all your builds succeed?
--
To view, visit https://review.coreboot.org/c/coreboot/+/80337?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ied54b66b930187cba5fbc578a81ed5859a616562
Gerrit-Change-Number: 80337
Gerrit-PatchSet: 22
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com>
Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Reviewer: Shuo Liu <shuo.liu(a)intel.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com>
Gerrit-CC: Appukuttan V K <appukuttan.vk(a)intel.com>
Gerrit-CC: Lean Sheng Tan <sheng.tan(a)9elements.com>
Gerrit-Comment-Date: Fri, 12 Apr 2024 07:08:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Appukuttan V K <appukuttan.vk(a)intel.com>
Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com>
Comment-In-Reply-To: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-MessageType: comment
Attention is currently required from: Eren Peng, Ivan Chen, Nick Vaccaro, Shelley Chen.
Sumeet R Pawnikar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81833?usp=email )
Change subject: mb/google/brox/var/greenbayupoc: Add fw_config field for storage
......................................................................
Patch Set 2: Code-Review+1
(1 comment)
File src/mainboard/google/brox/variants/greenbayupoc/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/81833/comment/a43a303a_2f19ae6d :
PS2, Line 3:
Remove extra tab.
Same for below 2 lines as well.
--
To view, visit https://review.coreboot.org/c/coreboot/+/81833?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I0e220787d6ac73ec8fa2469ed958981d0801920e
Gerrit-Change-Number: 81833
Gerrit-PatchSet: 2
Gerrit-Owner: Eren Peng <peng.eren(a)inventec.corp-partner.google.com>
Gerrit-Reviewer: Ivan Chen <yulunchen(a)google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Reviewer: Shelley Chen <shchen(a)google.com>
Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Eric Lai <ericllai(a)google.com>
Gerrit-CC: Garen Wu <wu.garen(a)inventec.corp-partner.google.com>
Gerrit-CC: Rasheed Hsueh <hsueh.rasheed(a)inventec.corp-partner.google.com>
Gerrit-CC: Steven Yeh <yeh.stevenct(a)inventec.corp-partner.google.com>
Gerrit-Attention: Shelley Chen <shchen(a)google.com>
Gerrit-Attention: Eren Peng <peng.eren(a)inventec.corp-partner.google.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Attention: Ivan Chen <yulunchen(a)google.com>
Gerrit-Comment-Date: Fri, 12 Apr 2024 06:50:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment