coreboot-gerrit April 2024

coreboot-gerrit@coreboot.org

1 participants
3293 discussions

[S] Change in coreboot[main]: mb/google/corsola: Add new board Veluza
by Frank Wu (Code Review) 12 Apr '24

12 Apr '24

Attention is currently required from: Frank Wu, Hung-Te Lin, Ian Feng, John Su, Shawn Ku, Yidi Lin. Hello Hung-Te Lin, Ian Feng, John Su, Shawn Ku, Yidi Lin, Yu-Ping Wu, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/81791?usp=email to look at the new patch set (#3). Change subject: mb/google/corsola: Add new board Veluza ...................................................................... mb/google/corsola: Add new board Veluza Add a new board 'Veluza' based on Krabby. BUG=b:333630131 BRANCH=corsola TEST=none Change-Id: Idedcbfbddd6d98a51cf28a0963d68f6d8c68382c Signed-off-by: Frank Wu <frank_wu(a)compal.corp-partner.google.com> --- M src/mainboard/google/corsola/Kconfig M src/mainboard/google/corsola/Kconfig.name 2 files changed, 8 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/91/81791/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/81791?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Idedcbfbddd6d98a51cf28a0963d68f6d8c68382c Gerrit-Change-Number: 81791 Gerrit-PatchSet: 3 Gerrit-Owner: Frank Wu <frank_wu(a)compal.corp-partner.google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Ian Feng <ian_feng(a)compal.corp-partner.google.com> Gerrit-Reviewer: John Su <john_su(a)compal.corp-partner.google.com> Gerrit-Reviewer: Shawn Ku <shawnku(a)chromium.org> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Jasper Lee <jasper_lee(a)compal.com> Gerrit-CC: Shawn Ku <shawnku(a)google.com> Gerrit-CC: Van Chen <van_chen(a)compal.corp-partner.google.com> Gerrit-Attention: Frank Wu <frank_wu(a)compal.corp-partner.google.com> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: John Su <john_su(a)compal.corp-partner.google.com> Gerrit-Attention: Ian Feng <ian_feng(a)compal.corp-partner.google.com> Gerrit-Attention: Shawn Ku <shawnku(a)chromium.org> Gerrit-Attention: Yidi Lin <yidilin(a)google.com> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[main]: util/lint: Add lint rule to watch for Makefile.inc
by Varshit Pandya (Code Review) 12 Apr '24

12 Apr '24

Attention is currently required from: Felix Held, Felix Singer, Martin L Roth. Varshit Pandya has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81857?usp=email ) Change subject: util/lint: Add lint rule to watch for Makefile.inc ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/81857?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I4a47998e1c997b82b8a15319eae96cdc0de64e77 Gerrit-Change-Number: 81857 Gerrit-PatchSet: 1 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Varshit Pandya <pandyavarshit(a)gmail.com> Gerrit-CC: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Fri, 12 Apr 2024 05:11:33 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: soc/amd/picasso: Mark eMMC as non-removable for Windows 10/11 install
by CoolStar (Code Review) 12 Apr '24

12 Apr '24

Attention is currently required from: Felix Held, Fred Reitberger, Jason Glenesk, Matt DeVillier. CoolStar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81858?usp=email ) Change subject: soc/amd/picasso: Mark eMMC as non-removable for Windows 10/11 install ...................................................................... Patch Set 2: -Code-Review -- To view, visit https://review.coreboot.org/c/coreboot/+/81858?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: If0e14106521f99cb97d1bf421f4d82d1234c2f15 Gerrit-Change-Number: 81858 Gerrit-PatchSet: 2 Gerrit-Owner: CoolStar <coolstarorganization(a)gmail.com> Gerrit-Reviewer: CoolStar <coolstarorganization(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Fri, 12 Apr 2024 04:26:45 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: soc/amd/picasso: Mark eMMC as non-removable for Windows 10/11 install
by CoolStar (Code Review) 12 Apr '24

12 Apr '24

Attention is currently required from: Felix Held, Fred Reitberger, Jason Glenesk, Matt DeVillier. CoolStar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81858?usp=email ) Change subject: soc/amd/picasso: Mark eMMC as non-removable for Windows 10/11 install ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/81858?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: If0e14106521f99cb97d1bf421f4d82d1234c2f15 Gerrit-Change-Number: 81858 Gerrit-PatchSet: 2 Gerrit-Owner: CoolStar <coolstarorganization(a)gmail.com> Gerrit-Reviewer: CoolStar <coolstarorganization(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Fri, 12 Apr 2024 04:26:33 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: soc/amd/picasso: Mark eMMC as non-removable for Windows 10/11 install
by CoolStar (Code Review) 12 Apr '24

12 Apr '24

CoolStar has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/81858?usp=email ) Change subject: soc/amd/picasso: Mark eMMC as non-removable for Windows 10/11 install ...................................................................... soc/amd/picasso: Mark eMMC as non-removable for Windows 10/11 install Mark eMMC as non-removable to allow Windows 10/11 to install now that edk2 can boot from it. Change-Id: If0e14106521f99cb97d1bf421f4d82d1234c2f15 Signed-off-by: CoolStar <coolstarorganization(a)gmail.com> --- M src/soc/amd/picasso/acpi/mmio.asl 1 file changed, 9 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/58/81858/1 diff --git a/src/soc/amd/picasso/acpi/mmio.asl b/src/soc/amd/picasso/acpi/mmio.asl index 8adc87d..d8bbf06 100644 --- a/src/soc/amd/picasso/acpi/mmio.asl +++ b/src/soc/amd/picasso/acpi/mmio.asl @@ -92,6 +92,15 @@ { Return (STAT) } + + Device (CARD) + { + Name (_ADR, 0x00000008) + Method (_RMV, 0, NotSerialized) + { + Return (0) + } + } } Device (FUR0) -- To view, visit https://review.coreboot.org/c/coreboot/+/81858?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: If0e14106521f99cb97d1bf421f4d82d1234c2f15 Gerrit-Change-Number: 81858 Gerrit-PatchSet: 1 Gerrit-Owner: CoolStar <coolstarorganization(a)gmail.com> Gerrit-MessageType: newchange

1 0

[XS] Change in coreboot[main]: tree: Drop duplicated <stdarg.h> and <stdio.h>
by Elyes Haouas (Code Review) 12 Apr '24

12 Apr '24

Elyes Haouas has submitted this change. ( https://review.coreboot.org/c/coreboot/+/81853?usp=email ) Change subject: tree: Drop duplicated <stdarg.h> and <stdio.h> ...................................................................... tree: Drop duplicated <stdarg.h> and <stdio.h> <string.h> is supposed to provide <stdarg.h> and <stdio.h> Change-Id: I021ba535ba5ec683021c4dfc41ac18d9cebbcfd2 Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> Reviewed-on: https://review.coreboot.org/c/coreboot/+/81853 Reviewed-by: Eric Lai <ericllai(a)google.com> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- M src/console/vsprintf.c M src/console/vtxprintf.c M src/cpu/x86/smm/smm_module_loader.c M src/device/pci_rom.c M src/drivers/ocp/dmi/smbios.c M src/mainboard/ocp/deltalake/ramstage.c M tests/lib/string-test.c 7 files changed, 0 insertions(+), 7 deletions(-) Approvals: Eric Lai: Looks good to me, approved build bot (Jenkins): Verified diff --git a/src/console/vsprintf.c b/src/console/vsprintf.c index 6892639..06b9e49 100644 --- a/src/console/vsprintf.c +++ b/src/console/vsprintf.c @@ -1,7 +1,6 @@ /* SPDX-License-Identifier: GPL-2.0-only */ #include <console/vtxprintf.h> -#include <stdarg.h> #include <string.h> struct vsnprintf_context { diff --git a/src/console/vtxprintf.c b/src/console/vtxprintf.c index cfba6db..fba76bc 100644 --- a/src/console/vtxprintf.c +++ b/src/console/vtxprintf.c @@ -6,7 +6,6 @@ #include <console/vtxprintf.h> #include <ctype.h> -#include <stdarg.h> #include <string.h> #include <types.h> diff --git a/src/cpu/x86/smm/smm_module_loader.c b/src/cpu/x86/smm/smm_module_loader.c index 646f3bb..02debfc 100644 --- a/src/cpu/x86/smm/smm_module_loader.c +++ b/src/cpu/x86/smm/smm_module_loader.c @@ -11,7 +11,6 @@ #include <device/mmio.h> #include <rmodule.h> #include <smmstore.h> -#include <stdio.h> #include <string.h> #include <types.h> diff --git a/src/device/pci_rom.c b/src/device/pci_rom.c index 1e212ab..aca55d6 100644 --- a/src/device/pci_rom.c +++ b/src/device/pci_rom.c @@ -6,7 +6,6 @@ #include <device/pci.h> #include <device/pci_ids.h> #include <device/pci_ops.h> -#include <stdio.h> #include <string.h> #include <cbfs.h> #include <cbmem.h> diff --git a/src/drivers/ocp/dmi/smbios.c b/src/drivers/ocp/dmi/smbios.c index 0ac3334..ead9b4d 100644 --- a/src/drivers/ocp/dmi/smbios.c +++ b/src/drivers/ocp/dmi/smbios.c @@ -6,7 +6,6 @@ #include <delay.h> #include <cpu/x86/mp.h> #include <timer.h> -#include <stdio.h> #include <string.h> #include <soc/soc_util.h> #include <soc/util.h> diff --git a/src/mainboard/ocp/deltalake/ramstage.c b/src/mainboard/ocp/deltalake/ramstage.c index 55a10ad..6dd7c10 100644 --- a/src/mainboard/ocp/deltalake/ramstage.c +++ b/src/mainboard/ocp/deltalake/ramstage.c @@ -20,7 +20,6 @@ #include <soc/smmrelocate.h> #include <soc/soc_util.h> #include <soc/util.h> -#include <stdio.h> #include <string.h> #include <types.h> diff --git a/tests/lib/string-test.c b/tests/lib/string-test.c index 0f21747..621a74c 100644 --- a/tests/lib/string-test.c +++ b/tests/lib/string-test.c @@ -5,7 +5,6 @@ #include <stdint.h> #include <stddef.h> #include <tests/test.h> -#include <stdio.h> /* * Important note: In every particular test, don't use any string-related -- To view, visit https://review.coreboot.org/c/coreboot/+/81853?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I021ba535ba5ec683021c4dfc41ac18d9cebbcfd2 Gerrit-Change-Number: 81853 Gerrit-PatchSet: 3 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Jakub Czapiga <czapiga(a)google.com> Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[XS] Change in coreboot[main]: tree: Drop duplicated <device/pci_{def,type}.h>
by Elyes Haouas (Code Review) 12 Apr '24

12 Apr '24

Elyes Haouas has submitted this change. ( https://review.coreboot.org/c/coreboot/+/81831?usp=email ) Change subject: tree: Drop duplicated <device/pci_{def,type}.h> ...................................................................... tree: Drop duplicated <device/pci_{def,type}.h> <device/pci.h> is supposed to provide <device/pci_{def,type}.h> Change-Id: Ia645b8dba8c688187a25916f508593f333821f88 Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> Reviewed-on: https://review.coreboot.org/c/coreboot/+/81831 Reviewed-by: Eric Lai <ericllai(a)google.com> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- M src/lib/smbios.c M src/soc/intel/xeon_sp/chip_gen1.c M src/soc/intel/xeon_sp/cpx/chip.c M src/soc/intel/xeon_sp/skx/soc_util.c M src/soc/intel/xeon_sp/spr/chip.c M src/southbridge/intel/bd82x6x/common.c 6 files changed, 0 insertions(+), 6 deletions(-) Approvals: Eric Lai: Looks good to me, approved build bot (Jenkins): Verified diff --git a/src/lib/smbios.c b/src/lib/smbios.c index 449e4fd..dcf12bf 100644 --- a/src/lib/smbios.c +++ b/src/lib/smbios.c @@ -15,7 +15,6 @@ #include <commonlib/helpers.h> #include <device/pci_ids.h> #include <device/pci.h> -#include <device/pci_def.h> #include <drivers/vpd/vpd.h> #include <stdlib.h> diff --git a/src/soc/intel/xeon_sp/chip_gen1.c b/src/soc/intel/xeon_sp/chip_gen1.c index 143cc89..b17b773 100644 --- a/src/soc/intel/xeon_sp/chip_gen1.c +++ b/src/soc/intel/xeon_sp/chip_gen1.c @@ -5,7 +5,6 @@ #include <console/console.h> #include <device/pci.h> #include <device/pci_ids.h> -#include <device/pci_def.h> #include <soc/pci_devs.h> #include <intelblocks/acpi.h> #include <soc/acpi.h> diff --git a/src/soc/intel/xeon_sp/cpx/chip.c b/src/soc/intel/xeon_sp/cpx/chip.c index 9c86aee..8b9a673 100644 --- a/src/soc/intel/xeon_sp/cpx/chip.c +++ b/src/soc/intel/xeon_sp/cpx/chip.c @@ -6,7 +6,6 @@ #include <cpu/x86/mp.h> #include <device/pci.h> #include <device/pci_ids.h> -#include <device/pci_def.h> #include <gpio.h> #include <intelblocks/acpi.h> #include <intelblocks/lpc_lib.h> diff --git a/src/soc/intel/xeon_sp/skx/soc_util.c b/src/soc/intel/xeon_sp/skx/soc_util.c index 38d834f..6f48246 100644 --- a/src/soc/intel/xeon_sp/skx/soc_util.c +++ b/src/soc/intel/xeon_sp/skx/soc_util.c @@ -3,7 +3,6 @@ #include <assert.h> #include <console/console.h> #include <device/pci.h> -#include <device/pci_def.h> #include <device/pci_ids.h> #include <hob_iiouds.h> #include <intelblocks/cpulib.h> diff --git a/src/soc/intel/xeon_sp/spr/chip.c b/src/soc/intel/xeon_sp/spr/chip.c index 9b3b46f..ec23940 100644 --- a/src/soc/intel/xeon_sp/spr/chip.c +++ b/src/soc/intel/xeon_sp/spr/chip.c @@ -6,7 +6,6 @@ #include <cpu/x86/lapic.h> #include <device/pci.h> #include <device/pci_ids.h> -#include <device/pci_def.h> #include <device/pciexp.h> #include <intelblocks/acpi.h> #include <intelblocks/gpio.h> diff --git a/src/southbridge/intel/bd82x6x/common.c b/src/southbridge/intel/bd82x6x/common.c index 63d2fb2..401be76 100644 --- a/src/southbridge/intel/bd82x6x/common.c +++ b/src/southbridge/intel/bd82x6x/common.c @@ -5,7 +5,6 @@ #include <console/console.h> #include <delay.h> #include <device/pci.h> -#include <device/pci_def.h> #include <device/pci_ids.h> #include <device/pci_ops.h> #include <stdint.h> -- To view, visit https://review.coreboot.org/c/coreboot/+/81831?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ia645b8dba8c688187a25916f508593f333821f88 Gerrit-Change-Number: 81831 Gerrit-PatchSet: 5 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jakub Czapiga <czapiga(a)google.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Jeff Daly <jeffd(a)silicom-usa.com> Gerrit-Reviewer: Jincheng Li <jincheng.li(a)intel.com> Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Jonathan Zhang <jon.zhixiong.zhang(a)gmail.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Shuo Liu <shuo.liu(a)intel.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun <tstuli(a)gmail.com> Gerrit-Reviewer: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Reviewer: Vanessa Eusebio <vanessa.f.eusebio(a)intel.com> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[M] Change in coreboot[main]: tree: Drop duplicated <device/{path,resource}.h>
by Elyes Haouas (Code Review) 12 Apr '24

12 Apr '24

Elyes Haouas has submitted this change. ( https://review.coreboot.org/c/coreboot/+/81830?usp=email ) Change subject: tree: Drop duplicated <device/{path,resource}.h> ...................................................................... tree: Drop duplicated <device/{path,resource}.h> <device/device.h> is supposed to provide <device/{path,resource}.h> Change-Id: I2ef82c8fe30b1c1399a9f85c1734ce8ba16a1f88 Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> Reviewed-on: https://review.coreboot.org/c/coreboot/+/81830 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Eric Lai <ericllai(a)google.com> --- M src/acpi/device.c M src/arch/x86/cpu.c M src/arch/x86/mpspec.c M src/cpu/x86/mp_init.c M src/device/device_const.c M src/device/device_util.c M src/drivers/generic/adau7002/adau7002.c M src/drivers/generic/alc1015/alc1015.c M src/drivers/generic/bayhub/bh720.c M src/drivers/generic/bayhub_lv2/lv2.c M src/drivers/generic/gpio_keys/gpio_keys.c M src/drivers/generic/max98357a/max98357a.c M src/drivers/generic/nau8315/nau8315.c M src/drivers/genesyslogic/gl9755/gl9755.c M src/drivers/genesyslogic/gl9763e/gl9763e.c M src/drivers/i2c/cs35l53/cs35l53.c M src/drivers/i2c/cs42l42/cs42l42.c M src/drivers/i2c/da7219/da7219.c M src/drivers/i2c/generic/generic.c M src/drivers/i2c/gpiomux/bus/bus.c M src/drivers/i2c/gpiomux/mux/mux.c M src/drivers/i2c/max98373/max98373.c M src/drivers/i2c/max98390/max98390.c M src/drivers/i2c/max98396/max98396.c M src/drivers/i2c/max98927/max98927.c M src/drivers/i2c/nau8825/nau8825.c M src/drivers/i2c/rt1011/rt1011.c M src/drivers/i2c/rt5663/rt5663.c M src/drivers/i2c/sx9310/sx9310.c M src/drivers/i2c/sx9324/sx9324.c M src/drivers/i2c/sx9360/sx9360.c M src/drivers/i2c/tpm/chip.c M src/drivers/intel/mipi_camera/camera.c M src/drivers/intel/soundwire/soundwire.c M src/drivers/intel/usb4/retimer/retimer.c M src/drivers/nxp/uwb/uwb.c M src/drivers/sof/sof.c M src/drivers/soundwire/alc1308/alc1308.c M src/drivers/soundwire/alc5682/alc5682.c M src/drivers/soundwire/alc711/alc711.c M src/drivers/soundwire/cs42l42/cs42l42.c M src/drivers/soundwire/max98363/max98363.c M src/drivers/soundwire/max98373/max98373.c M src/drivers/spi/acpi/acpi.c M src/drivers/uart/acpi/acpi.c M src/drivers/usb/acpi/usb_acpi.c M src/include/device/pci.h M src/include/reg_script.h M src/lib/reg_script.c M src/soc/amd/common/block/root_complex/ioapic.c M src/soc/amd/common/fsp/fsp_graphics.c M src/soc/intel/apollolake/romstage.c M src/soc/intel/cannonlake/graphics.c M src/soc/intel/common/block/smbus/smbus.c M src/soc/intel/common/block/usb4/pcie.c M src/soc/intel/xeon_sp/include/soc/chip_common.h M src/soc/intel/xeon_sp/spr/ioat.c M src/soc/mediatek/common/pcie.c M src/southbridge/intel/bd82x6x/smbus.c M src/southbridge/intel/common/smbus_ops.c M src/southbridge/intel/i82801gx/smbus.c M src/southbridge/intel/i82801ix/smbus.c M src/southbridge/intel/i82801jx/smbus.c M src/southbridge/intel/ibexpeak/smbus.c M src/southbridge/intel/lynxpoint/smbus.c M tests/lib/bootmem-test.c M tests/lib/memrange-test.c M util/vgabios/device.c 68 files changed, 0 insertions(+), 69 deletions(-) Approvals: build bot (Jenkins): Verified Eric Lai: Looks good to me, approved diff --git a/src/acpi/device.c b/src/acpi/device.c index 7fe5a37..95316b0 100644 --- a/src/acpi/device.c +++ b/src/acpi/device.c @@ -7,7 +7,6 @@ #include <acpi/acpigen.h> #include <acpi/acpigen_pci.h> #include <device/device.h> -#include <device/path.h> #include <stdlib.h> #include <types.h> #include <crc_byte.h> diff --git a/src/arch/x86/cpu.c b/src/arch/x86/cpu.c index f4c18c2..91cbcb0 100644 --- a/src/arch/x86/cpu.c +++ b/src/arch/x86/cpu.c @@ -10,7 +10,6 @@ #include <cpu/x86/mp.h> #include <cpu/x86/lapic.h> #include <cpu/x86/tsc.h> -#include <device/path.h> #include <device/device.h> #include <smp/spinlock.h> diff --git a/src/arch/x86/mpspec.c b/src/arch/x86/mpspec.c index f5242d3..d6f0cd5b 100644 --- a/src/arch/x86/mpspec.c +++ b/src/arch/x86/mpspec.c @@ -7,7 +7,6 @@ #include <cpu/cpu.h> #include <cpu/x86/lapic.h> #include <device/device.h> -#include <device/path.h> #include <device/pci_def.h> #include <device/pci_ids.h> #include <identity.h> diff --git a/src/cpu/x86/mp_init.c b/src/cpu/x86/mp_init.c index dd5e94d..bb51697 100644 --- a/src/cpu/x86/mp_init.c +++ b/src/cpu/x86/mp_init.c @@ -17,7 +17,6 @@ #include <cpu/x86/mp.h> #include <delay.h> #include <device/device.h> -#include <device/path.h> #include <smp/atomic.h> #include <smp/spinlock.h> #include <symbols.h> diff --git a/src/device/device_const.c b/src/device/device_const.c index 0521c7e..fc76304 100644 --- a/src/device/device_const.c +++ b/src/device/device_const.c @@ -3,7 +3,6 @@ #include <assert.h> #include <console/console.h> #include <device/device.h> -#include <device/path.h> #include <device/pci_def.h> #include <device/pci_type.h> #include <fw_config.h> diff --git a/src/device/device_util.c b/src/device/device_util.c index b5d0d98..02641c1 100644 --- a/src/device/device_util.c +++ b/src/device/device_util.c @@ -3,9 +3,7 @@ #include <commonlib/bsd/helpers.h> #include <console/console.h> #include <device/device.h> -#include <device/path.h> #include <device/pci_def.h> -#include <device/resource.h> #include <stdlib.h> #include <string.h> #include <types.h> diff --git a/src/drivers/generic/adau7002/adau7002.c b/src/drivers/generic/adau7002/adau7002.c index 5917f69..db48bfe 100644 --- a/src/drivers/generic/adau7002/adau7002.c +++ b/src/drivers/generic/adau7002/adau7002.c @@ -4,7 +4,6 @@ #include <acpi/acpigen.h> #include <console/console.h> #include <device/device.h> -#include <device/path.h> #include "chip.h" #if CONFIG(HAVE_ACPI_TABLES) diff --git a/src/drivers/generic/alc1015/alc1015.c b/src/drivers/generic/alc1015/alc1015.c index 7245f0c..257775e 100644 --- a/src/drivers/generic/alc1015/alc1015.c +++ b/src/drivers/generic/alc1015/alc1015.c @@ -4,7 +4,6 @@ #include <acpi/acpigen.h> #include <console/console.h> #include <device/device.h> -#include <device/path.h> #include "chip.h" static void alc1015_fill_ssdt(const struct device *dev) diff --git a/src/drivers/generic/bayhub/bh720.c b/src/drivers/generic/bayhub/bh720.c index 5104c35..fb782ca 100644 --- a/src/drivers/generic/bayhub/bh720.c +++ b/src/drivers/generic/bayhub/bh720.c @@ -5,7 +5,6 @@ #include <console/console.h> #include <device/device.h> #include <device/mmio.h> -#include <device/path.h> #include <device/pci.h> #include <device/pci_ops.h> #include <device/pci_ids.h> diff --git a/src/drivers/generic/bayhub_lv2/lv2.c b/src/drivers/generic/bayhub_lv2/lv2.c index b2b85e1..3d94ac3 100644 --- a/src/drivers/generic/bayhub_lv2/lv2.c +++ b/src/drivers/generic/bayhub_lv2/lv2.c @@ -4,7 +4,6 @@ #include <console/console.h> #include <device/device.h> -#include <device/path.h> #include <device/pci.h> #include <device/pciexp.h> #include <device/pci_ops.h> diff --git a/src/drivers/generic/gpio_keys/gpio_keys.c b/src/drivers/generic/gpio_keys/gpio_keys.c index 28e5be5..37b90ca 100644 --- a/src/drivers/generic/gpio_keys/gpio_keys.c +++ b/src/drivers/generic/gpio_keys/gpio_keys.c @@ -3,7 +3,6 @@ #include <acpi/acpi_device.h> #include <acpi/acpigen.h> #include <device/device.h> -#include <device/path.h> #include <string.h> #include "chip.h" diff --git a/src/drivers/generic/max98357a/max98357a.c b/src/drivers/generic/max98357a/max98357a.c index 8ce80f1..9b190ce 100644 --- a/src/drivers/generic/max98357a/max98357a.c +++ b/src/drivers/generic/max98357a/max98357a.c @@ -4,7 +4,6 @@ #include <acpi/acpigen.h> #include <console/console.h> #include <device/device.h> -#include <device/path.h> #include <gpio.h> #include "chip.h" diff --git a/src/drivers/generic/nau8315/nau8315.c b/src/drivers/generic/nau8315/nau8315.c index 8fe4e1f..294d519 100644 --- a/src/drivers/generic/nau8315/nau8315.c +++ b/src/drivers/generic/nau8315/nau8315.c @@ -4,7 +4,6 @@ #include <acpi/acpigen.h> #include <console/console.h> #include <device/device.h> -#include <device/path.h> #include <gpio.h> #include "chip.h" diff --git a/src/drivers/genesyslogic/gl9755/gl9755.c b/src/drivers/genesyslogic/gl9755/gl9755.c index 6b8dd7d..a160c0b 100644 --- a/src/drivers/genesyslogic/gl9755/gl9755.c +++ b/src/drivers/genesyslogic/gl9755/gl9755.c @@ -4,7 +4,6 @@ #include <console/console.h> #include <device/device.h> -#include <device/path.h> #include <device/pci.h> #include <device/pci_ops.h> #include <device/pci_ids.h> diff --git a/src/drivers/genesyslogic/gl9763e/gl9763e.c b/src/drivers/genesyslogic/gl9763e/gl9763e.c index 140535d..136c585 100644 --- a/src/drivers/genesyslogic/gl9763e/gl9763e.c +++ b/src/drivers/genesyslogic/gl9763e/gl9763e.c @@ -4,7 +4,6 @@ #include <console/console.h> #include <device/device.h> -#include <device/path.h> #include <device/pci.h> #include <device/pci_ops.h> #include <device/pci_ids.h> diff --git a/src/drivers/i2c/cs35l53/cs35l53.c b/src/drivers/i2c/cs35l53/cs35l53.c index 578e272..479ef7f 100644 --- a/src/drivers/i2c/cs35l53/cs35l53.c +++ b/src/drivers/i2c/cs35l53/cs35l53.c @@ -6,7 +6,6 @@ #include <console/console.h> #include <device/i2c_simple.h> #include <device/device.h> -#include <device/path.h> #include "chip.h" diff --git a/src/drivers/i2c/cs42l42/cs42l42.c b/src/drivers/i2c/cs42l42/cs42l42.c index 8ccfd77..6d29dfe 100644 --- a/src/drivers/i2c/cs42l42/cs42l42.c +++ b/src/drivers/i2c/cs42l42/cs42l42.c @@ -5,7 +5,6 @@ #include <console/console.h> #include <device/i2c_simple.h> #include <device/device.h> -#include <device/path.h> #include "chip.h" diff --git a/src/drivers/i2c/da7219/da7219.c b/src/drivers/i2c/da7219/da7219.c index 1a149ca..e6a5283 100644 --- a/src/drivers/i2c/da7219/da7219.c +++ b/src/drivers/i2c/da7219/da7219.c @@ -6,7 +6,6 @@ #include <console/console.h> #include <device/i2c_simple.h> #include <device/device.h> -#include <device/path.h> #include "chip.h" diff --git a/src/drivers/i2c/generic/generic.c b/src/drivers/i2c/generic/generic.c index 03018ee..afff978 100644 --- a/src/drivers/i2c/generic/generic.c +++ b/src/drivers/i2c/generic/generic.c @@ -6,7 +6,6 @@ #include <device/i2c_bus.h> #include <device/i2c_simple.h> #include <device/device.h> -#include <device/path.h> #include <gpio.h> #include <string.h> #include "chip.h" diff --git a/src/drivers/i2c/gpiomux/bus/bus.c b/src/drivers/i2c/gpiomux/bus/bus.c index a6c603a..5487f6d 100644 --- a/src/drivers/i2c/gpiomux/bus/bus.c +++ b/src/drivers/i2c/gpiomux/bus/bus.c @@ -4,7 +4,6 @@ #include <acpi/acpigen.h> #include <console/console.h> #include <device/device.h> -#include <device/path.h> #include <string.h> #include "chip.h" diff --git a/src/drivers/i2c/gpiomux/mux/mux.c b/src/drivers/i2c/gpiomux/mux/mux.c index 5f79fe5..91d4ebf 100644 --- a/src/drivers/i2c/gpiomux/mux/mux.c +++ b/src/drivers/i2c/gpiomux/mux/mux.c @@ -4,7 +4,6 @@ #include <acpi/acpigen.h> #include <console/console.h> #include <device/device.h> -#include <device/path.h> #include <string.h> #include "chip.h" diff --git a/src/drivers/i2c/max98373/max98373.c b/src/drivers/i2c/max98373/max98373.c index 37a8864..1035a7c 100644 --- a/src/drivers/i2c/max98373/max98373.c +++ b/src/drivers/i2c/max98373/max98373.c @@ -5,7 +5,6 @@ #include <console/console.h> #include <device/i2c_simple.h> #include <device/device.h> -#include <device/path.h> #include "chip.h" #define MAX98373_ACPI_NAME "MAXI" diff --git a/src/drivers/i2c/max98390/max98390.c b/src/drivers/i2c/max98390/max98390.c index f4c4a70..f4912c1 100644 --- a/src/drivers/i2c/max98390/max98390.c +++ b/src/drivers/i2c/max98390/max98390.c @@ -5,7 +5,6 @@ #include <console/console.h> #include <device/i2c.h> #include <device/device.h> -#include <device/path.h> #include <identity.h> #include <stdint.h> #include <vendorcode/google/dsm_calib.h> diff --git a/src/drivers/i2c/max98396/max98396.c b/src/drivers/i2c/max98396/max98396.c index 6ad3931..ca07dbd 100644 --- a/src/drivers/i2c/max98396/max98396.c +++ b/src/drivers/i2c/max98396/max98396.c @@ -5,7 +5,6 @@ #include <console/console.h> #include <device/i2c_simple.h> #include <device/device.h> -#include <device/path.h> #include "chip.h" diff --git a/src/drivers/i2c/max98927/max98927.c b/src/drivers/i2c/max98927/max98927.c index 9935d10..a5775db 100644 --- a/src/drivers/i2c/max98927/max98927.c +++ b/src/drivers/i2c/max98927/max98927.c @@ -5,7 +5,6 @@ #include <console/console.h> #include <device/i2c_simple.h> #include <device/device.h> -#include <device/path.h> #include "chip.h" #define MAX98927_ACPI_NAME "MAXI" diff --git a/src/drivers/i2c/nau8825/nau8825.c b/src/drivers/i2c/nau8825/nau8825.c index 9e82538..8bf9e43 100644 --- a/src/drivers/i2c/nau8825/nau8825.c +++ b/src/drivers/i2c/nau8825/nau8825.c @@ -5,7 +5,6 @@ #include <console/console.h> #include <device/i2c_simple.h> #include <device/device.h> -#include <device/path.h> #include <stdint.h> #include "chip.h" diff --git a/src/drivers/i2c/rt1011/rt1011.c b/src/drivers/i2c/rt1011/rt1011.c index bf62a6f..e8ee8df 100644 --- a/src/drivers/i2c/rt1011/rt1011.c +++ b/src/drivers/i2c/rt1011/rt1011.c @@ -5,7 +5,6 @@ #include <console/console.h> #include <device/i2c.h> #include <device/device.h> -#include <device/path.h> #include <stdint.h> #include <vendorcode/google/dsm_calib.h> #include "chip.h" diff --git a/src/drivers/i2c/rt5663/rt5663.c b/src/drivers/i2c/rt5663/rt5663.c index e2341dd..bcbe0ff 100644 --- a/src/drivers/i2c/rt5663/rt5663.c +++ b/src/drivers/i2c/rt5663/rt5663.c @@ -5,7 +5,6 @@ #include <console/console.h> #include <device/i2c.h> #include <device/device.h> -#include <device/path.h> #include "chip.h" #define RT5663_ACPI_NAME "RT53" diff --git a/src/drivers/i2c/sx9310/sx9310.c b/src/drivers/i2c/sx9310/sx9310.c index 5094608..e5142bc 100644 --- a/src/drivers/i2c/sx9310/sx9310.c +++ b/src/drivers/i2c/sx9310/sx9310.c @@ -5,7 +5,6 @@ #include <console/console.h> #include <device/i2c_simple.h> #include <device/device.h> -#include <device/path.h> #include <string.h> #include "chip.h" diff --git a/src/drivers/i2c/sx9324/sx9324.c b/src/drivers/i2c/sx9324/sx9324.c index 05aca00..966726f 100644 --- a/src/drivers/i2c/sx9324/sx9324.c +++ b/src/drivers/i2c/sx9324/sx9324.c @@ -5,7 +5,6 @@ #include <console/console.h> #include <device/i2c_simple.h> #include <device/device.h> -#include <device/path.h> #include <string.h> #include "chip.h" diff --git a/src/drivers/i2c/sx9360/sx9360.c b/src/drivers/i2c/sx9360/sx9360.c index c9de0de..df154f4 100644 --- a/src/drivers/i2c/sx9360/sx9360.c +++ b/src/drivers/i2c/sx9360/sx9360.c @@ -5,7 +5,6 @@ #include <console/console.h> #include <device/i2c_simple.h> #include <device/device.h> -#include <device/path.h> #include <string.h> #include "chip.h" diff --git a/src/drivers/i2c/tpm/chip.c b/src/drivers/i2c/tpm/chip.c index a1d7389..cb99144 100644 --- a/src/drivers/i2c/tpm/chip.c +++ b/src/drivers/i2c/tpm/chip.c @@ -5,7 +5,6 @@ #include <console/console.h> #include <device/i2c_simple.h> #include <device/device.h> -#include <device/path.h> #include "tpm.h" #include "chip.h" diff --git a/src/drivers/intel/mipi_camera/camera.c b/src/drivers/intel/mipi_camera/camera.c index 4044a26..92c45a8 100644 --- a/src/drivers/intel/mipi_camera/camera.c +++ b/src/drivers/intel/mipi_camera/camera.c @@ -8,7 +8,6 @@ #include <console/console.h> #include <device/i2c_simple.h> #include <device/device.h> -#include <device/path.h> #include <device/pci_def.h> #include "chip.h" diff --git a/src/drivers/intel/soundwire/soundwire.c b/src/drivers/intel/soundwire/soundwire.c index 0137dad..2afb156 100644 --- a/src/drivers/intel/soundwire/soundwire.c +++ b/src/drivers/intel/soundwire/soundwire.c @@ -5,7 +5,6 @@ #include <acpi/acpi_soundwire.h> #include <commonlib/helpers.h> #include <device/device.h> -#include <device/path.h> #include <device/soundwire.h> #include <stdbool.h> diff --git a/src/drivers/intel/usb4/retimer/retimer.c b/src/drivers/intel/usb4/retimer/retimer.c index 9704139..9e627de 100644 --- a/src/drivers/intel/usb4/retimer/retimer.c +++ b/src/drivers/intel/usb4/retimer/retimer.c @@ -5,7 +5,6 @@ #include <acpi/acpi_pld.h> #include <console/console.h> #include <device/device.h> -#include <device/path.h> #include <drivers/usb/acpi/chip.h> #include <gpio.h> #include <string.h> diff --git a/src/drivers/nxp/uwb/uwb.c b/src/drivers/nxp/uwb/uwb.c index b828657..590b3f5 100644 --- a/src/drivers/nxp/uwb/uwb.c +++ b/src/drivers/nxp/uwb/uwb.c @@ -4,7 +4,6 @@ #include <acpi/acpigen.h> #include <console/console.h> #include <device/device.h> -#include <device/path.h> #include <device/spi.h> #include <spi-generic.h> #include <string.h> diff --git a/src/drivers/sof/sof.c b/src/drivers/sof/sof.c index 8cd577e..9f6391b 100644 --- a/src/drivers/sof/sof.c +++ b/src/drivers/sof/sof.c @@ -3,7 +3,6 @@ #include <acpi/acpi_device.h> #include <acpi/acpigen.h> #include <device/device.h> -#include <device/path.h> #include "chip.h" diff --git a/src/drivers/soundwire/alc1308/alc1308.c b/src/drivers/soundwire/alc1308/alc1308.c index 5449fe8..fc7b2af 100644 --- a/src/drivers/soundwire/alc1308/alc1308.c +++ b/src/drivers/soundwire/alc1308/alc1308.c @@ -4,7 +4,6 @@ #include <acpi/acpi_device.h> #include <acpi/acpi_soundwire.h> #include <device/device.h> -#include <device/path.h> #include <device/soundwire.h> #include <mipi/ids.h> #include <stdio.h> diff --git a/src/drivers/soundwire/alc5682/alc5682.c b/src/drivers/soundwire/alc5682/alc5682.c index 0d8a3ab..67ce61c 100644 --- a/src/drivers/soundwire/alc5682/alc5682.c +++ b/src/drivers/soundwire/alc5682/alc5682.c @@ -4,7 +4,6 @@ #include <acpi/acpi_device.h> #include <acpi/acpi_soundwire.h> #include <device/device.h> -#include <device/path.h> #include <device/soundwire.h> #include <mipi/ids.h> #include <stdio.h> diff --git a/src/drivers/soundwire/alc711/alc711.c b/src/drivers/soundwire/alc711/alc711.c index cfe28ad..7d1ac42 100644 --- a/src/drivers/soundwire/alc711/alc711.c +++ b/src/drivers/soundwire/alc711/alc711.c @@ -4,7 +4,6 @@ #include <acpi/acpi_device.h> #include <acpi/acpi_soundwire.h> #include <device/device.h> -#include <device/path.h> #include <device/soundwire.h> #include <mipi/ids.h> #include <stdio.h> diff --git a/src/drivers/soundwire/cs42l42/cs42l42.c b/src/drivers/soundwire/cs42l42/cs42l42.c index e7c14cc..c0e1d90 100644 --- a/src/drivers/soundwire/cs42l42/cs42l42.c +++ b/src/drivers/soundwire/cs42l42/cs42l42.c @@ -4,7 +4,6 @@ #include <acpi/acpi_device.h> #include <acpi/acpi_soundwire.h> #include <device/device.h> -#include <device/path.h> #include <device/soundwire.h> #include <mipi/ids.h> #include <stdio.h> diff --git a/src/drivers/soundwire/max98363/max98363.c b/src/drivers/soundwire/max98363/max98363.c index 7b90d78..6eec97b 100644 --- a/src/drivers/soundwire/max98363/max98363.c +++ b/src/drivers/soundwire/max98363/max98363.c @@ -4,7 +4,6 @@ #include <acpi/acpi_device.h> #include <acpi/acpi_soundwire.h> #include <device/device.h> -#include <device/path.h> #include <device/soundwire.h> #include <mipi/ids.h> #include <stdio.h> diff --git a/src/drivers/soundwire/max98373/max98373.c b/src/drivers/soundwire/max98373/max98373.c index e3107c4..a394154 100644 --- a/src/drivers/soundwire/max98373/max98373.c +++ b/src/drivers/soundwire/max98373/max98373.c @@ -4,7 +4,6 @@ #include <acpi/acpi_device.h> #include <acpi/acpi_soundwire.h> #include <device/device.h> -#include <device/path.h> #include <device/soundwire.h> #include <mipi/ids.h> #include <stdio.h> diff --git a/src/drivers/spi/acpi/acpi.c b/src/drivers/spi/acpi/acpi.c index 537c377..e87946f 100644 --- a/src/drivers/spi/acpi/acpi.c +++ b/src/drivers/spi/acpi/acpi.c @@ -4,7 +4,6 @@ #include <acpi/acpigen.h> #include <console/console.h> #include <device/device.h> -#include <device/path.h> #include <device/spi.h> #include <spi-generic.h> #include <string.h> diff --git a/src/drivers/uart/acpi/acpi.c b/src/drivers/uart/acpi/acpi.c index bcf896d..a245f2c 100644 --- a/src/drivers/uart/acpi/acpi.c +++ b/src/drivers/uart/acpi/acpi.c @@ -3,7 +3,6 @@ #include <acpi/acpi_device.h> #include <acpi/acpigen.h> #include <console/console.h> -#include <device/path.h> #include <string.h> #include "chip.h" diff --git a/src/drivers/usb/acpi/usb_acpi.c b/src/drivers/usb/acpi/usb_acpi.c index b463b3b..569147a 100644 --- a/src/drivers/usb/acpi/usb_acpi.c +++ b/src/drivers/usb/acpi/usb_acpi.c @@ -6,7 +6,6 @@ #include <acpi/acpigen_dsm.h> #include <console/console.h> #include <device/device.h> -#include <device/path.h> #include "chip.h" static bool usb_acpi_add_gpios_to_crs(struct drivers_usb_acpi_config *cfg) diff --git a/src/include/device/pci.h b/src/include/device/pci.h index 88b9555..2e75195 100644 --- a/src/include/device/pci.h +++ b/src/include/device/pci.h @@ -25,7 +25,6 @@ #include <device/pci_ops.h> #include <device/pci_rom.h> #include <device/pci_type.h> /* IWYU pragma: export */ -#include <device/resource.h> #include <stddef.h> #include <stdint.h> diff --git a/src/include/reg_script.h b/src/include/reg_script.h index 38a80aa..56db353 100644 --- a/src/include/reg_script.h +++ b/src/include/reg_script.h @@ -6,7 +6,6 @@ #include <stdint.h> #include <device/device.h> #include <device/pci_type.h> -#include <device/resource.h> /* * The reg script library is a way to provide data-driven I/O accesses for diff --git a/src/lib/reg_script.c b/src/lib/reg_script.c index bad9d9c..c14f927 100644 --- a/src/lib/reg_script.c +++ b/src/lib/reg_script.c @@ -5,7 +5,6 @@ #include <console/console.h> #include <delay.h> #include <device/device.h> -#include <device/resource.h> #include <device/pci.h> #include <stdint.h> #include <reg_script.h> diff --git a/src/soc/amd/common/block/root_complex/ioapic.c b/src/soc/amd/common/block/root_complex/ioapic.c index e183428..17e283f 100644 --- a/src/soc/amd/common/block/root_complex/ioapic.c +++ b/src/soc/amd/common/block/root_complex/ioapic.c @@ -4,7 +4,6 @@ #include <amdblocks/root_complex.h> #include <arch/ioapic.h> #include <device/device.h> -#include <device/resource.h> #include <types.h> void amd_pci_domain_init(struct device *domain) diff --git a/src/soc/amd/common/fsp/fsp_graphics.c b/src/soc/amd/common/fsp/fsp_graphics.c index 4847e3c..3e082e6 100644 --- a/src/soc/amd/common/fsp/fsp_graphics.c +++ b/src/soc/amd/common/fsp/fsp_graphics.c @@ -4,7 +4,6 @@ #include <console/console.h> #include <device/device.h> #include <device/pci.h> -#include <device/resource.h> #include <fsp/graphics.h> void fsp_graphics_init(struct device *const dev) diff --git a/src/soc/intel/apollolake/romstage.c b/src/soc/intel/apollolake/romstage.c index ba865e3..f710883 100644 --- a/src/soc/intel/apollolake/romstage.c +++ b/src/soc/intel/apollolake/romstage.c @@ -9,7 +9,6 @@ #include <device/device.h> #include <delay.h> #include <device/pci_def.h> -#include <device/resource.h> #include <fsp/api.h> #include <fsp/util.h> #include <intelblocks/cpulib.h> diff --git a/src/soc/intel/cannonlake/graphics.c b/src/soc/intel/cannonlake/graphics.c index 93a84c2..abbe079 100644 --- a/src/soc/intel/cannonlake/graphics.c +++ b/src/soc/intel/cannonlake/graphics.c @@ -4,7 +4,6 @@ #include <device/device.h> #include <device/mmio.h> #include <device/pci_def.h> -#include <device/resource.h> #include <drivers/intel/gma/i915_reg.h> #include <intelblocks/graphics.h> #include <soc/ramstage.h> diff --git a/src/soc/intel/common/block/smbus/smbus.c b/src/soc/intel/common/block/smbus/smbus.c index 4f2ed36..97651c0 100644 --- a/src/soc/intel/common/block/smbus/smbus.c +++ b/src/soc/intel/common/block/smbus/smbus.c @@ -1,7 +1,6 @@ /* SPDX-License-Identifier: GPL-2.0-only */ #include <device/device.h> -#include <device/path.h> #include <device/smbus.h> #include <device/pci.h> #include <device/pci_ids.h> diff --git a/src/soc/intel/common/block/usb4/pcie.c b/src/soc/intel/common/block/usb4/pcie.c index c066647..24b6f46 100644 --- a/src/soc/intel/common/block/usb4/pcie.c +++ b/src/soc/intel/common/block/usb4/pcie.c @@ -4,7 +4,6 @@ #include <acpi/acpigen.h> #include <console/console.h> #include <device/device.h> -#include <device/path.h> #include <string.h> #include "chip.h" diff --git a/src/soc/intel/xeon_sp/include/soc/chip_common.h b/src/soc/intel/xeon_sp/include/soc/chip_common.h index c499f62..0c0258a 100644 --- a/src/soc/intel/xeon_sp/include/soc/chip_common.h +++ b/src/soc/intel/xeon_sp/include/soc/chip_common.h @@ -4,7 +4,6 @@ #define _CHIP_COMMON_H_ #include <device/device.h> -#include <device/path.h> #include <soc/soc_util.h> union xeon_domain_path { diff --git a/src/soc/intel/xeon_sp/spr/ioat.c b/src/soc/intel/xeon_sp/spr/ioat.c index ecfc1f7..9ed9576 100644 --- a/src/soc/intel/xeon_sp/spr/ioat.c +++ b/src/soc/intel/xeon_sp/spr/ioat.c @@ -4,7 +4,6 @@ #include <console/console.h> #include <device/device.h> -#include <device/resource.h> #include <defs_iio.h> #include <hob_iiouds.h> diff --git a/src/soc/mediatek/common/pcie.c b/src/soc/mediatek/common/pcie.c index 10bece9..ce9055a 100644 --- a/src/soc/mediatek/common/pcie.c +++ b/src/soc/mediatek/common/pcie.c @@ -6,7 +6,6 @@ #include <device/mmio.h> #include <device/pci.h> #include <device/pci_ids.h> -#include <device/resource.h> #include <delay.h> #include <lib.h> #include <soc/addressmap.h> diff --git a/src/southbridge/intel/bd82x6x/smbus.c b/src/southbridge/intel/bd82x6x/smbus.c index d2ca247..9db8d7a 100644 --- a/src/southbridge/intel/bd82x6x/smbus.c +++ b/src/southbridge/intel/bd82x6x/smbus.c @@ -1,7 +1,6 @@ /* SPDX-License-Identifier: GPL-2.0-only */ #include <device/device.h> -#include <device/path.h> #include <device/smbus.h> #include <device/pci.h> #include <device/pci_ids.h> diff --git a/src/southbridge/intel/common/smbus_ops.c b/src/southbridge/intel/common/smbus_ops.c index 347de73..8542ba3 100644 --- a/src/southbridge/intel/common/smbus_ops.c +++ b/src/southbridge/intel/common/smbus_ops.c @@ -1,7 +1,6 @@ /* SPDX-License-Identifier: GPL-2.0-only */ #include <device/device.h> -#include <device/path.h> #include <device/smbus.h> #include <device/pci.h> #include <device/pci_ids.h> diff --git a/src/southbridge/intel/i82801gx/smbus.c b/src/southbridge/intel/i82801gx/smbus.c index d498037..f26ddd4 100644 --- a/src/southbridge/intel/i82801gx/smbus.c +++ b/src/southbridge/intel/i82801gx/smbus.c @@ -1,7 +1,6 @@ /* SPDX-License-Identifier: GPL-2.0-only */ #include <device/device.h> -#include <device/path.h> #include <device/smbus.h> #include <device/pci.h> #include <device/pci_ids.h> diff --git a/src/southbridge/intel/i82801ix/smbus.c b/src/southbridge/intel/i82801ix/smbus.c index 1ddfb7f..8f60408 100644 --- a/src/southbridge/intel/i82801ix/smbus.c +++ b/src/southbridge/intel/i82801ix/smbus.c @@ -1,7 +1,6 @@ /* SPDX-License-Identifier: GPL-2.0-only */ #include <device/device.h> -#include <device/path.h> #include <device/smbus.h> #include <device/pci.h> #include <device/pci_ids.h> diff --git a/src/southbridge/intel/i82801jx/smbus.c b/src/southbridge/intel/i82801jx/smbus.c index 8fa1914..15643bd 100644 --- a/src/southbridge/intel/i82801jx/smbus.c +++ b/src/southbridge/intel/i82801jx/smbus.c @@ -1,7 +1,6 @@ /* SPDX-License-Identifier: GPL-2.0-only */ #include <device/device.h> -#include <device/path.h> #include <device/smbus.h> #include <device/pci.h> #include <device/pci_ids.h> diff --git a/src/southbridge/intel/ibexpeak/smbus.c b/src/southbridge/intel/ibexpeak/smbus.c index 3318458..6bbd1e4 100644 --- a/src/southbridge/intel/ibexpeak/smbus.c +++ b/src/southbridge/intel/ibexpeak/smbus.c @@ -1,7 +1,6 @@ /* SPDX-License-Identifier: GPL-2.0-only */ #include <device/device.h> -#include <device/path.h> #include <device/smbus.h> #include <device/pci.h> #include <device/pci_ids.h> diff --git a/src/southbridge/intel/lynxpoint/smbus.c b/src/southbridge/intel/lynxpoint/smbus.c index 757254e..0363802 100644 --- a/src/southbridge/intel/lynxpoint/smbus.c +++ b/src/southbridge/intel/lynxpoint/smbus.c @@ -1,7 +1,6 @@ /* SPDX-License-Identifier: GPL-2.0-only */ #include <device/device.h> -#include <device/path.h> #include <device/smbus.h> #include <device/pci.h> #include <device/pci_ids.h> diff --git a/tests/lib/bootmem-test.c b/tests/lib/bootmem-test.c index 4cf9a2d..5137533 100644 --- a/tests/lib/bootmem-test.c +++ b/tests/lib/bootmem-test.c @@ -3,7 +3,6 @@ #include <bootmem.h> #include <commonlib/coreboot_tables.h> #include <device/device.h> -#include <device/resource.h> #include <memrange.h> #include <stdlib.h> #include <string.h> diff --git a/tests/lib/memrange-test.c b/tests/lib/memrange-test.c index 9871484..eac4769 100644 --- a/tests/lib/memrange-test.c +++ b/tests/lib/memrange-test.c @@ -3,7 +3,6 @@ #include <tests/test.h> #include <device/device.h> -#include <device/resource.h> #include <commonlib/helpers.h> #include <memrange.h> diff --git a/util/vgabios/device.c b/util/vgabios/device.c index d130314..a129cbf 100644 --- a/util/vgabios/device.c +++ b/util/vgabios/device.c @@ -11,7 +11,6 @@ #include <device/device.h> #include <device/pci.h> #include <device/pci_ops.h> -#include <device/resource.h> /* the device we are working with... */ biosemu_device_t bios_device; -- To view, visit https://review.coreboot.org/c/coreboot/+/81830?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I2ef82c8fe30b1c1399a9f85c1734ce8ba16a1f88 Gerrit-Change-Number: 81830 Gerrit-PatchSet: 7 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Caveh Jalali <caveh(a)chromium.org> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Forest Mittelberg <bmbm(a)google.com> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Jakub Czapiga <czapiga(a)google.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Jincheng Li <jincheng.li(a)intel.com> Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Jonathan Zhang <jon.zhixiong.zhang(a)gmail.com> Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Shuo Liu <shuo.liu(a)intel.com> Gerrit-Reviewer: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[XS] Change in coreboot[main]: tree: Drop unused <cbmem.h>
by Elyes Haouas (Code Review) 12 Apr '24

12 Apr '24

Elyes Haouas has submitted this change. ( https://review.coreboot.org/c/coreboot/+/81829?usp=email ) Change subject: tree: Drop unused <cbmem.h> ...................................................................... tree: Drop unused <cbmem.h> Change-Id: If8be8dc26f2729f55dc6716e6d01e2b801d79e44 Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> Reviewed-on: https://review.coreboot.org/c/coreboot/+/81829 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Eric Lai <ericllai(a)google.com> --- M src/arch/riscv/payload.c M src/soc/intel/common/block/crashlog/crashlog.c M src/soc/intel/common/block/vtd/vtd.c M src/soc/intel/xeon_sp/spr/soc_acpi.c M src/soc/intel/xeon_sp/uncore_acpi.c 5 files changed, 0 insertions(+), 5 deletions(-) Approvals: build bot (Jenkins): Verified Eric Lai: Looks good to me, approved diff --git a/src/arch/riscv/payload.c b/src/arch/riscv/payload.c index 7c6e0f4..2e35e60 100644 --- a/src/arch/riscv/payload.c +++ b/src/arch/riscv/payload.c @@ -1,6 +1,5 @@ /* SPDX-License-Identifier: GPL-2.0-only */ -#include <cbmem.h> #include <program_loading.h> #include <stdint.h> #include <arch/boot.h> diff --git a/src/soc/intel/common/block/crashlog/crashlog.c b/src/soc/intel/common/block/crashlog/crashlog.c index 541dea4..a9ac8a53 100644 --- a/src/soc/intel/common/block/crashlog/crashlog.c +++ b/src/soc/intel/common/block/crashlog/crashlog.c @@ -1,6 +1,5 @@ /* SPDX-License-Identifier: GPL-2.0-only */ -#include <cbmem.h> #include <console/console.h> #include <delay.h> #include <device/mmio.h> diff --git a/src/soc/intel/common/block/vtd/vtd.c b/src/soc/intel/common/block/vtd/vtd.c index f7da277..f67d8db 100644 --- a/src/soc/intel/common/block/vtd/vtd.c +++ b/src/soc/intel/common/block/vtd/vtd.c @@ -1,7 +1,6 @@ /* SPDX-License-Identifier: GPL-2.0-only */ #include <bootstate.h> -#include <cbmem.h> #include <console/console.h> #include <cpu/cpu.h> #include <device/mmio.h> diff --git a/src/soc/intel/xeon_sp/spr/soc_acpi.c b/src/soc/intel/xeon_sp/spr/soc_acpi.c index 2d1f375..1249b8f 100644 --- a/src/soc/intel/xeon_sp/spr/soc_acpi.c +++ b/src/soc/intel/xeon_sp/spr/soc_acpi.c @@ -4,7 +4,6 @@ #include <arch/smp/mpspec.h> #include <arch/vga.h> #include <assert.h> -#include <cbmem.h> #include <cpu/intel/turbo.h> #include <device/mmio.h> #include <device/pci.h> diff --git a/src/soc/intel/xeon_sp/uncore_acpi.c b/src/soc/intel/xeon_sp/uncore_acpi.c index 86c3a66..29dc3ec 100644 --- a/src/soc/intel/xeon_sp/uncore_acpi.c +++ b/src/soc/intel/xeon_sp/uncore_acpi.c @@ -4,7 +4,6 @@ #include <arch/hpet.h> #include <arch/ioapic.h> #include <assert.h> -#include <cbmem.h> #include <cpu/x86/lapic.h> #include <commonlib/sort.h> #include <device/mmio.h> -- To view, visit https://review.coreboot.org/c/coreboot/+/81829?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: If8be8dc26f2729f55dc6716e6d01e2b801d79e44 Gerrit-Change-Number: 81829 Gerrit-PatchSet: 3 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Jincheng Li <jincheng.li(a)intel.com> Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Jonathan Zhang <jon.zhixiong.zhang(a)gmail.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Philipp Hug <philipp(a)hug.cx> Gerrit-Reviewer: Shuo Liu <shuo.liu(a)intel.com> Gerrit-Reviewer: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: ron minnich <rminnich(a)gmail.com> Gerrit-MessageType: merged

1 0

[XS] Change in coreboot[main]: include/device/device.h: Drop duplicated <console/console.h>
by Elyes Haouas (Code Review) 12 Apr '24

12 Apr '24

Elyes Haouas has submitted this change. ( https://review.coreboot.org/c/coreboot/+/81828?usp=email ) Change subject: include/device/device.h: Drop duplicated <console/console.h> ...................................................................... include/device/device.h: Drop duplicated <console/console.h> Change-Id: Ib81c81843a5252e2ead9ce175cea2fa42f0e8152 Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> Reviewed-on: https://review.coreboot.org/c/coreboot/+/81828 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Eric Lai <ericllai(a)google.com> --- M src/include/device/device.h 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: Eric Lai: Looks good to me, approved build bot (Jenkins): Verified diff --git a/src/include/device/device.h b/src/include/device/device.h index 25f730b..b347d39 100644 --- a/src/include/device/device.h +++ b/src/include/device/device.h @@ -240,7 +240,6 @@ /* Debug macros */ #if CONFIG(DEBUG_FUNC) -#include <console/console.h> #define DEV_FUNC_ENTER(dev) \ printk(BIOS_SPEW, "%s:%s:%d: ENTER (dev: %s)\n", \ __FILE__, __func__, __LINE__, dev_path(dev)) -- To view, visit https://review.coreboot.org/c/coreboot/+/81828?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ib81c81843a5252e2ead9ce175cea2fa42f0e8152 Gerrit-Change-Number: 81828 Gerrit-PatchSet: 2 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit April 2024