coreboot-gerrit April 2024

coreboot-gerrit@coreboot.org

1 participants
3293 discussions

[S] Change in coreboot[main]: mb/google/corsola: Add new board Veluza
by Paul Menzel (Code Review) 12 Apr '24

12 Apr '24

Attention is currently required from: Frank Wu, Hung-Te Lin, Ian Feng, John Su, Shawn Ku, Shawn Ku, Yidi Lin. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81791?usp=email ) The change is no longer submittable: All-Comments-Resolved is unsatisfied now. Change subject: mb/google/corsola: Add new board Veluza ...................................................................... Patch Set 3: (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/81791/comment/b09d4dc5_7b7715c1 : PS3, Line 7: mb/google/corsola: Add new board Veluza Should *variant* be mentioned in the title? File src/mainboard/google/corsola/Kconfig: https://review.coreboot.org/c/coreboot/+/81791/comment/1ba24e4f_28ee4c5f : PS3, Line 93: default "Veluza" if BOARD_GOOGLE_VELUZA Is there a reason, this list list is not sorted? -- To view, visit https://review.coreboot.org/c/coreboot/+/81791?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Idedcbfbddd6d98a51cf28a0963d68f6d8c68382c Gerrit-Change-Number: 81791 Gerrit-PatchSet: 3 Gerrit-Owner: Frank Wu <frank_wu(a)compal.corp-partner.google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Ian Feng <ian_feng(a)compal.corp-partner.google.com> Gerrit-Reviewer: John Su <john_su(a)compal.corp-partner.google.com> Gerrit-Reviewer: Shawn Ku <shawnku(a)chromium.org> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Jasper Lee <jasper_lee(a)compal.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Shawn Ku <shawnku(a)google.com> Gerrit-CC: Van Chen <van_chen(a)compal.corp-partner.google.com> Gerrit-Attention: Frank Wu <frank_wu(a)compal.corp-partner.google.com> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: John Su <john_su(a)compal.corp-partner.google.com> Gerrit-Attention: Ian Feng <ian_feng(a)compal.corp-partner.google.com> Gerrit-Attention: Shawn Ku <shawnku(a)google.com> Gerrit-Attention: Shawn Ku <shawnku(a)chromium.org> Gerrit-Attention: Yidi Lin <yidilin(a)google.com> Gerrit-Comment-Date: Fri, 12 Apr 2024 09:49:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in coreboot[main]: drivers/i2c/rt5645: Add RT5645 amp driver
by Paul Menzel (Code Review) 12 Apr '24

12 Apr '24

Attention is currently required from: Eric Lai, Jianeng Ceng, Subrata Banik. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81773?usp=email ) Change subject: drivers/i2c/rt5645: Add RT5645 amp driver ...................................................................... Patch Set 11: (3 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/81773/comment/7e8ba956_f19b81b9 : PS9, Line 9: Add RT5645 AMP support. > cbj-sleeve-gpios was only added on rt5645. As it’s C code, can’t you guard the device specific parts by an if statement? Commit Message: https://review.coreboot.org/c/coreboot/+/81773/comment/c1a0187a_962753a4 : PS11, Line 11: ALC5650 So why name the directory *rt5645*? Please add a comment in the commit message. Patchset: PS11: Thank you for your quick reply. -- To view, visit https://review.coreboot.org/c/coreboot/+/81773?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I602fcc4dd8576043943f6e20884edc4703350320 Gerrit-Change-Number: 81773 Gerrit-PatchSet: 11 Gerrit-Owner: Jianeng Ceng <cengjianeng(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Dolan Liu <liuyong5(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Eric Lai <ericllai(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Jianeng Ceng <cengjianeng(a)huaqin.corp-partner.google.com> Gerrit-Comment-Date: Fri, 12 Apr 2024 09:39:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Comment-In-Reply-To: Jianeng Ceng <cengjianeng(a)huaqin.corp-partner.google.com> Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: include: Add 'IWYU pragma: export' comment
by Elyes Haouas (Code Review) 12 Apr '24

12 Apr '24

Attention is currently required from: Eric Lai. Elyes Haouas has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81824?usp=email ) Change subject: include: Add 'IWYU pragma: export' comment ...................................................................... Patch Set 2: (2 comments) Patchset: PS2: I can add /* IWYU pragma: export */ for both lines and keep same order if you want File src/include/device/device.h: https://review.coreboot.org/c/coreboot/+/81824/comment/6f29dfee_cbd0fb16 : PS2, Line 12: #include <device/pci_type.h> > why change the order? to move <device/pci_type.h> out of "WYU pragma: begin/end export" -- To view, visit https://review.coreboot.org/c/coreboot/+/81824?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I3acb5e6b18443e454d8174b0b1f9d207c0fb78b5 Gerrit-Change-Number: 81824 Gerrit-PatchSet: 2 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Eric Lai <ericllai(a)google.com> Gerrit-Attention: Eric Lai <ericllai(a)google.com> Gerrit-Comment-Date: Fri, 12 Apr 2024 09:30:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Eric Lai <ericllai(a)google.com> Gerrit-MessageType: comment

1 0

[M] Change in coreboot[main]: drivers/i2c/rt5645: Add RT5645 amp driver
by Jianeng Ceng (Code Review) 12 Apr '24

12 Apr '24

Attention is currently required from: Eric Lai, Paul Menzel, Subrata Banik. Jianeng Ceng has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81773?usp=email ) Change subject: drivers/i2c/rt5645: Add RT5645 amp driver ...................................................................... Patch Set 11: (4 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/81773/comment/4a8f7207_7dd4dc4f : PS9, Line 9: Add RT5645 AMP support. > Please elaborate. […] cbj-sleeve-gpios was only added on rt5645. https://review.coreboot.org/c/coreboot/+/81773/comment/6bb47d74_f2dc4f5a : PS9, Line 12: Realtek upstream link:(https://lore.kernel.org/all/20240404035747.118064-1-derek.fang@realte… > Please put the URL on a separate line without brackets. Done https://review.coreboot.org/c/coreboot/+/81773/comment/d38bf14c_2c5175fc : PS9, Line 15: TEST=RT5645 driver can probe properly. > Please name the device, and paste the relevant log messages. Done File src/drivers/i2c/rt5645/rt5645.c: https://review.coreboot.org/c/coreboot/+/81773/comment/0a0c18d7_7047d115 : PS9, Line 11: #define RT5645_DP_INT(key, val) \ > no need macro if just use ones I am not sure whether other modes will be added in the future, so we reserve this macro. -- To view, visit https://review.coreboot.org/c/coreboot/+/81773?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I602fcc4dd8576043943f6e20884edc4703350320 Gerrit-Change-Number: 81773 Gerrit-PatchSet: 11 Gerrit-Owner: Jianeng Ceng <cengjianeng(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Dolan Liu <liuyong5(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Eric Lai <ericllai(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Fri, 12 Apr 2024 09:12:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Eric Lai <ericllai(a)google.com> Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: comment

1 0

[M] Change in coreboot[main]: drivers/i2c/rt5645: Add RT5645 amp driver
by Jianeng Ceng (Code Review) 12 Apr '24

12 Apr '24

Attention is currently required from: Jianeng Ceng, Subrata Banik. Hello Dolan Liu, Eric Lai, Subrata Banik, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/81773?usp=email to look at the new patch set (#11). Change subject: drivers/i2c/rt5645: Add RT5645 amp driver ...................................................................... drivers/i2c/rt5645: Add RT5645 amp driver Add RT5645 AMP support. Add acpi name cbj-sleeve-gpios for power gate GPIO. ALC5650 DataSheet Rev 0.93 Realtek upstream link: https://lore.kernel.org/all/20240404035747.118064-1-derek.fang@realtek.com/ BUG=None TEST=verified in anraggar and probe device rt5650 succeed ``` \_SB.PCI0.I2C3.RT58: Realtek RT5650 ``` Change-Id: I602fcc4dd8576043943f6e20884edc4703350320 Signed-off-by: Jianeng Ceng <cengjianeng(a)huaqin.corp-partner.google.com> --- A src/drivers/i2c/rt5645/Kconfig A src/drivers/i2c/rt5645/Makefile.mk A src/drivers/i2c/rt5645/chip.h A src/drivers/i2c/rt5645/rt5645.c 4 files changed, 141 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/73/81773/11 -- To view, visit https://review.coreboot.org/c/coreboot/+/81773?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I602fcc4dd8576043943f6e20884edc4703350320 Gerrit-Change-Number: 81773 Gerrit-PatchSet: 11 Gerrit-Owner: Jianeng Ceng <cengjianeng(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Dolan Liu <liuyong5(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Jianeng Ceng <cengjianeng(a)huaqin.corp-partner.google.com> Gerrit-MessageType: newpatchset

1 0

[M] Change in coreboot[main]: drivers/i2c/rt5645: Add RT5645 amp driver
by Jianeng Ceng (Code Review) 12 Apr '24

12 Apr '24

Attention is currently required from: Jianeng Ceng, Subrata Banik. Hello Dolan Liu, Eric Lai, Subrata Banik, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/81773?usp=email to look at the new patch set (#10). Change subject: drivers/i2c/rt5645: Add RT5645 amp driver ...................................................................... drivers/i2c/rt5645: Add RT5645 amp driver Add RT5645 AMP support. Add acpi name cbj-sleeve-gpios for power gate GPIO. ALC5650 DataSheet Rev 0.93 Realtek upstream link: https://lore.kernel.org/all/20240404035747.118064-1-derek.fang @realtek.com/ BUG=None TEST=verified in anraggar and probe device rt5650 succeed ``` \_SB.PCI0.I2C3.RT58: Realtek RT5650 ``` Change-Id: I602fcc4dd8576043943f6e20884edc4703350320 Signed-off-by: Jianeng Ceng <cengjianeng(a)huaqin.corp-partner.google.com> --- A src/drivers/i2c/rt5645/Kconfig A src/drivers/i2c/rt5645/Makefile.mk A src/drivers/i2c/rt5645/chip.h A src/drivers/i2c/rt5645/rt5645.c 4 files changed, 141 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/73/81773/10 -- To view, visit https://review.coreboot.org/c/coreboot/+/81773?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I602fcc4dd8576043943f6e20884edc4703350320 Gerrit-Change-Number: 81773 Gerrit-PatchSet: 10 Gerrit-Owner: Jianeng Ceng <cengjianeng(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Dolan Liu <liuyong5(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Jianeng Ceng <cengjianeng(a)huaqin.corp-partner.google.com> Gerrit-MessageType: newpatchset

1 0

[XL] Change in coreboot[main]: mb/lenovo: Add ThinkCentre M920q (Cannon Lake)
by Michał Kopeć (Code Review) 12 Apr '24

12 Apr '24

1 0

[XL] Change in coreboot[main]: mb/lenovo: Add ThinkCentre M920q (Cannon Lake)
by Michał Kopeć (Code Review) 12 Apr '24

12 Apr '24

Attention is currently required from: Alexander Couzens, Angel Pons, Maciej Pijanowski, Paul Menzel. Michał Kopeć has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80609?usp=email ) Change subject: mb/lenovo: Add ThinkCentre M920q (Cannon Lake) ...................................................................... Patch Set 7: (2 comments) File src/mainboard/lenovo/m920q/romstage.c: https://review.coreboot.org/c/coreboot/+/80609/comment/a86561b2_ce2cd401 : PS6, Line 13: .spd[0] = { > Correct, updated. This was mostly copied over from the reference board code, I think. Done https://review.coreboot.org/c/coreboot/+/80609/comment/7d6da3af_2524defd : PS6, Line 33: /* Rcomp target values for CFL-S, DDR4 and 2 DIMMs per channel */ > I barely remember, but I think the only difference (if any) is the value of the first target (50 or […] Hmm indeed the docs don't have the values for CFL-S SODIMM 1DPC... I agree 50 is probably closer to correct, since that's what CFL-H 1DPC uses -- To view, visit https://review.coreboot.org/c/coreboot/+/80609?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Iea1dc5745c0ecf687fa18b793f0aab4b0855d6d4 Gerrit-Change-Number: 80609 Gerrit-PatchSet: 7 Gerrit-Owner: Maciej Pijanowski <maciej.pijanowski(a)3mdeb.com> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-CC: Nicholas Sudsgaard <devel+coreboot(a)nsudsgaard.com> Gerrit-Attention: Maciej Pijanowski <maciej.pijanowski(a)3mdeb.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Comment-Date: Fri, 12 Apr 2024 08:43:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Maciej Pijanowski <maciej.pijanowski(a)3mdeb.com> Comment-In-Reply-To: Michał Kopeć <michal.kopec(a)3mdeb.com> Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: drivers/i2c/generic: Add i2c_generic_write_gpio for public
by Kapil Porwal (Code Review) 12 Apr '24

12 Apr '24

Attention is currently required from: Jianeng Ceng, Subrata Banik. Kapil Porwal has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81788?usp=email ) Change subject: drivers/i2c/generic: Add i2c_generic_write_gpio for public ...................................................................... Patch Set 1: (1 comment) File src/drivers/i2c/generic/generic.c: https://review.coreboot.org/c/coreboot/+/81788/comment/efb79585_1f5d2405 : PS1, Line 31: int i2c_generic_write_gpio(struct acpi_gpio *gpio, int *curr_index) : { : int ret = -1; : : if (gpio->pin_count == 0) : return ret; : : acpi_device_write_gpio(gpio); : ret = *curr_index; : (*curr_index)++; : : return ret; : } I think this function can be copied to the new driver instead of making it public. The current function name is not appropriate to make it public. -- To view, visit https://review.coreboot.org/c/coreboot/+/81788?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ifb2e60690711b39743afd455c6776c5ace863378 Gerrit-Change-Number: 81788 Gerrit-PatchSet: 1 Gerrit-Owner: Jianeng Ceng <cengjianeng(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Dolan Liu <liuyong5(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Jianeng Ceng <cengjianeng(a)huaqin.corp-partner.google.com> Gerrit-Comment-Date: Fri, 12 Apr 2024 08:39:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in coreboot[main]: drivers/i2c/rt5645: Add RT5645 amp driver
by Paul Menzel (Code Review) 12 Apr '24

12 Apr '24

Attention is currently required from: Jianeng Ceng, Subrata Banik. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81773?usp=email ) Change subject: drivers/i2c/rt5645: Add RT5645 amp driver ...................................................................... Patch Set 9: (3 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/81773/comment/65494596_1c15b514 : PS9, Line 9: Add RT5645 AMP support. Please elaborate. 1. Why can’t `src/drivers/i2c/rt5663/` be generalized? 2. Please document the datasheet name and revision. https://review.coreboot.org/c/coreboot/+/81773/comment/4d86a8db_fab02990 : PS9, Line 12: Realtek upstream link:(https://lore.kernel.org/all/20240404035747.118064-1-derek.fang@realte… Please put the URL on a separate line without brackets. https://review.coreboot.org/c/coreboot/+/81773/comment/9ce00ebd_f7b63a90 : PS9, Line 15: TEST=RT5645 driver can probe properly. Please name the device, and paste the relevant log messages. -- To view, visit https://review.coreboot.org/c/coreboot/+/81773?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I602fcc4dd8576043943f6e20884edc4703350320 Gerrit-Change-Number: 81773 Gerrit-PatchSet: 9 Gerrit-Owner: Jianeng Ceng <cengjianeng(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Dolan Liu <liuyong5(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Jianeng Ceng <cengjianeng(a)huaqin.corp-partner.google.com> Gerrit-Comment-Date: Fri, 12 Apr 2024 08:16:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit April 2024