Attention is currently required from: Amanda Hwang, Dtrain Hsu.
Eric Lai has posted comments on this change by Amanda Hwang. ( https://review.coreboot.org/c/coreboot/+/84781?usp=email )
Change subject: mb/google/fatcat/var/francka: Generate RAM ID for Micron MT62F2G32D4DS-020 WT:F
......................................................................
Patch Set 4: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/84781?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I2de56c8c7a028edefbd3dc53f8b1e26dee3286f7
Gerrit-Change-Number: 84781
Gerrit-PatchSet: 4
Gerrit-Owner: Amanda Hwang <amanda_hwang(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Eric Lai <ericllai(a)google.com>
Gerrit-Reviewer: Pranava Y N <pranavayn(a)google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Ian Feng <ian_feng(a)compal.corp-partner.google.com>
Gerrit-Attention: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com>
Gerrit-Attention: Amanda Hwang <amanda_hwang(a)compal.corp-partner.google.com>
Gerrit-Comment-Date: Mon, 04 Nov 2024 01:57:05 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Yu-Ping Wu has submitted this change. ( https://review.coreboot.org/c/coreboot/+/84950?usp=email )
Change subject: soc/mediatek/mt8188/spi: Fix out-of-bound array access for pad_funcs
......................................................................
soc/mediatek/mt8188/spi: Fix out-of-bound array access for pad_funcs
The size of the inner array of the 2-dimensional array pad_funcs should
be 4 instead of SPI_BUS_NUMBER (6). This bug leads to two extra
gpio_set_mode() calls with unexpected GPIOs.
Inspecting spi.o, the data immediately after the .rodata.pad_funcs
section is .rodata.spi_ctrlr_bus_map, with the following data:
00000428 00 00 00 00 00 00 00 00 00 00 00 00 05 00 00 00
00000438 00 00 00 00 00 00 00 00 ...
This is equivalent to the following calls:
gpio_set_mode(GPIO(GPIO05), 0);
gpio_set_mode(GPIO(GPIO00), 0);
The second call is already included in the pad_funcs array, so the first
call is the only practical impact of this bug.
Change-Id: I9c44f09b3cdadbbf039b95efca7144f213672092
Signed-off-by: Yu-Ping Wu <yupingso(a)chromium.org>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/84950
Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org>
Reviewed-by: Yidi Lin <yidilin(a)google.com>
Reviewed-by: Hung-Te Lin <hungte(a)chromium.org>
Reviewed-by: Paul Menzel <paulepanter(a)mailbox.org>
---
M src/soc/mediatek/mt8188/spi.c
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Paul Menzel: Looks good to me, but someone else must approve
Hung-Te Lin: Looks good to me, approved
Yidi Lin: Looks good to me, approved
build bot (Jenkins): Verified
diff --git a/src/soc/mediatek/mt8188/spi.c b/src/soc/mediatek/mt8188/spi.c
index 994663d..66fbf0f 100644
--- a/src/soc/mediatek/mt8188/spi.c
+++ b/src/soc/mediatek/mt8188/spi.c
@@ -114,7 +114,7 @@
ptr = pad_funcs[bus];
- for (unsigned int i = 0; i < SPI_BUS_NUMBER; i++)
+ for (unsigned int i = 0; i < ARRAY_SIZE(pad_funcs[0]); i++)
gpio_set_mode(ptr[i].gpio, ptr[i].func);
}
--
To view, visit https://review.coreboot.org/c/coreboot/+/84950?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I9c44f09b3cdadbbf039b95efca7144f213672092
Gerrit-Change-Number: 84950
Gerrit-PatchSet: 2
Gerrit-Owner: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Attention is currently required from: Martin Roth, Matt DeVillier, Nick Kochlowski.
Nicholas Chin has posted comments on this change by Nick Kochlowski. ( https://review.coreboot.org/c/coreboot/+/84740?usp=email )
Change subject: Documentation/tutorial/managing_local_additions.md: Add symlink info
......................................................................
Patch Set 9: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/84740?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I75f9e9575005e9ee2f255848a21c5e57c30e9e72
Gerrit-Change-Number: 84740
Gerrit-PatchSet: 9
Gerrit-Owner: Nick Kochlowski <nickkochlowski(a)gmail.com>
Gerrit-Reviewer: Ana Carolina Cabral
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com>
Gerrit-Reviewer: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Martin Roth <martin.roth(a)amd.corp-partner.google.com>
Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com>
Gerrit-Attention: Nick Kochlowski <nickkochlowski(a)gmail.com>
Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com>
Gerrit-Comment-Date: Sun, 03 Nov 2024 19:28:00 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Elyes Haouas has posted comments on this change by Elyes Haouas. ( https://review.coreboot.org/c/coreboot/+/84977?usp=email )
Change subject: Update intel-sec-tools submodule to upstream main
......................................................................
Patch Set 2:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/84977/comment/2b26bc8c_eac32dc1?us… :
PS2, Line 10: 2021-06-22
3 years old ...
--
To view, visit https://review.coreboot.org/c/coreboot/+/84977?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I5f0224dff49b800cb41130f12048ae48e2df4107
Gerrit-Change-Number: 84977
Gerrit-PatchSet: 2
Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Sun, 03 Nov 2024 16:45:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Subrata Banik has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/84981?usp=email )
Change subject: soc/intel/meteorlake: Disable eSOL for Ovis/Deku
......................................................................
soc/intel/meteorlake: Disable eSOL for Ovis/Deku
Disable the `FSP_UGOP_EARLY_SIGN_OF_LIFE` option (eSOL) for the
Ovis baseboard.
eSOL currently only supports display output over eDP and HDMI.
Ovis/Deku exclusively use Type-C for display, and eSOL cannot render
output over Type-C during early boot because it depends on Type-C
firmware loaded in a later stage.
TEST=Able to build and boot google/deku.
Change-Id: I5ddbd340f667b1631a42d130a793f0b1831aa0ba
Signed-off-by: Subrata Banik <subratabanik(a)google.com>
---
M src/soc/intel/meteorlake/Kconfig
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/81/84981/1
diff --git a/src/soc/intel/meteorlake/Kconfig b/src/soc/intel/meteorlake/Kconfig
index 6a21781..efb49f6 100644
--- a/src/soc/intel/meteorlake/Kconfig
+++ b/src/soc/intel/meteorlake/Kconfig
@@ -19,7 +19,7 @@
select FSP_COMPRESS_FSP_S_LZ4
select FAST_SPI_SUPPORTS_EXT_BIOS_WINDOW
select FSP_M_XIP
- select FSP_UGOP_EARLY_SIGN_OF_LIFE if !SOC_INTEL_METEORLAKE_PRE_PRODUCTION_SILICON
+ select FSP_UGOP_EARLY_SIGN_OF_LIFE if !SOC_INTEL_METEORLAKE_PRE_PRODUCTION_SILICON && !BOARD_GOOGLE_BASEBOARD_OVIS
select FSP_USES_CB_DEBUG_EVENT_HANDLER
select FSPS_HAS_ARCH_UPD
select GENERIC_GPIO_LIB
--
To view, visit https://review.coreboot.org/c/coreboot/+/84981?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I5ddbd340f667b1631a42d130a793f0b1831aa0ba
Gerrit-Change-Number: 84981
Gerrit-PatchSet: 1
Gerrit-Owner: Subrata Banik <subratabanik(a)google.com>
Elyes Haouas has posted comments on this change by Elyes Haouas. ( https://review.coreboot.org/c/coreboot/+/84979?usp=email )
Change subject: Update opensbi submodule to upstream master
......................................................................
Patch Set 1:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/84979/comment/a6b0f16b_61ec4f19?us… :
PS1, Line 10: 2022-09-01
2 years old !!!
--
To view, visit https://review.coreboot.org/c/coreboot/+/84979?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I3f30da319aa2e28635059da2c54af537c17ce400
Gerrit-Change-Number: 84979
Gerrit-PatchSet: 1
Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Sun, 03 Nov 2024 09:36:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Elyes Haouas has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/84980?usp=email )
Change subject: Update vboot submodule to upstream main
......................................................................
Update vboot submodule to upstream main
Updating from commit id f1f70f46:
2024-07-31 14:57:49 +0000 - (2lib: Add gbb flag to enforce CSE sync)
to commit id 36621031:
2024-10-31 16:53:36 +0000 - (Reland "host/lib/flashrom: Use flashrom provided in PATH")
This brings in 39 new commits:
36621031 Reland "host/lib/flashrom: Use flashrom provided in PATH"
26e8011f Add configurable temporary directory path
a0f83f9f futility: Drop futility execution logging to /tmp/futility.log
862e250e crossystem: Make crossystem vendor_available
3246e484 futility: updater: Increase try count from 11 to 13
2ab8888b make_dev_ssd: add upstream cmdline flag for ptracers
3c2ef940 Update Rust OWNERS file to include libchromeos-rs/OWNERS
c5af1fd8 make_dev_ssd.sh: avoid page cache aliasing
38f9c255 Revert "host/lib/flashrom: Use flashrom provided in PATH"
7d4b23f9 futility: updater: Revise the test script
8494502d futility: updater: Support emulation in the output mode
54be900d futility: updater: Handle flashrom read failure in load_system_firmware
2a787558 futility: updater: Drop `signature_id` from implementation
90f59170 futility: updater: Add a new config 'output_only'
94d884d8 futility: updater: Deprecate `--signature_id` by `--model`
24fd715c host/lib/flashrom: Use flashrom provided in PATH
ac49f1ca Build thin archives
640fe19f host/lib/crossystem: Make CROSSYSTEM_LOCK_PATH configurable
86b42b6a sign_android_image: calculate and store the vb meta digest
da1d153b Move futility and cgpt to vendor partition
80955816 futility: updater: Remove 'allow_empty_custom_label_tag' quirk
7ad2b0ab futility: updater: Process custom label as standard models
13400d69 futility: updater: Remove signature_id from manifest
f770c7d0 futility: updater: Remove the legacy 'setvars.sh' manifest
ed4556ed tests/futility: Add test cases for unmodified RO
21902629 futility/file_type_bios.c: Skip keyblock checks if magic is invalid
f5924321 Fix partition type check for miniOS B
83f845b3 signing: clean up owners
dc5102f2 signing: miniOS signing in docker.
16e6aa89 futility: updater: Provide default DUT properties for emulation
e56f3686 tests/futility/test_update: Fix --sys_props argument
7e2828a1 futility: updater: cleanup: Remove duplicated comments
060efa0c vboot: Only execute TPM clear on nonchrome FW
2fc6815b sign_official_build: Include full loem.ini path
47658f3c 2lib/2load_kernel: Remove unused VB2_LOAD_PARTITION_WORKBUF_BYTES
7cc2ce4c futility: Skip printing EC RW version if non-printable
8365d546 futility/load_fmap: Erase remaining bytes if file smaller than area
ec01126c swap_ec_rw: Search for keyset in source tree too
b76d74dc futility/load_fmap: use WARN() on non-critical error
Change-Id: I6f3b3a1425b579d6377c17b669b713b5629b4bbf
Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr>
---
M 3rdparty/vboot
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/80/84980/1
diff --git a/3rdparty/vboot b/3rdparty/vboot
index f1f70f4..3662103 160000
--- a/3rdparty/vboot
+++ b/3rdparty/vboot
@@ -1 +1 @@
-Subproject commit f1f70f46dc5482bb7c654e53ed58d4001e386df2
+Subproject commit 3662103165a35b422552e24aeb5af0b8ec051cb6
--
To view, visit https://review.coreboot.org/c/coreboot/+/84980?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I6f3b3a1425b579d6377c17b669b713b5629b4bbf
Gerrit-Change-Number: 84980
Gerrit-PatchSet: 1
Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr>
Elyes Haouas has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/84978?usp=email )
Change subject: Update open-power-signing-utils submodule to upstream master
......................................................................
Update open-power-signing-utils submodule to upstream master
Updating from commit id 591c8f5:
2020-06-03 08:30:23 -0500 - (Merge pull request #32 from mtvaught-ibm/secure-version)
to commit id 9a80ee8:
2024-10-03 08:59:57 -0500 - (Fix hashkeys helptext to list container version 3 (#46))
This brings in 32 new commits:
9a80ee8 Fix hashkeys helptext to list container version 3 (#46)
d464fa5 Add mldsa 87 support (#45)
51b6589 Add v3 container support (#43)
e4fa7b6 Merge pull request #42 from open-power/UpstreamRepo
54a5ef7 Update for public mlca repo
96db818 Add missing required include
c13558b Merge pull request #41 from open-power/AddV2Signing
49fea67 Code updates from review comments
41beb36 Apply clang format to new tool
b668132 Add support for v2 signing with mlca_framework
9b71b5f Merge pull request #40 from mtvaught-ibm/use-sf-short
7010647 Use getopt short flags when calling sf_client
0221718 Merge pull request #39 from mtvaught-ibm/add-aix-build
353294a Add support for building create/print/hash binaries on AIX
5af9cc4 Merge pull request #38 from mtvaught-ibm/add-ssh-passwd-env-to-ini
1c2fa21 Allow defining sshkey password environment variable in .ini config file
bd9418a Merge pull request #37 from mtvaught-ibm/env-pwd
2b1b78b Merge pull request #36 from mtvaught-ibm/multiple-ini
af4a5d5 Add option to provide sf_client the ssh key passphrase through ENV
a863ee4 Add support to --sign-project-config for multiple .ini files
afb556c Merge pull request #34 from open-power/AddV2_2
f70629f Add support to set fw header ECID for v2 containers
a993255 Final fixes for production container signing
110b0a6 Fix crtSignedContainer.sh to pull all SW keys
4bead21 Added support to detect dilithium key files
464c298 Add separate boot/runtime v2 imprint keys
e31d495 Rename default HW key files
bc8057f Add initial support for Dilithium keys
72cf502 Disable container v2 support for downlevel openssl
ea9cbe1 Add support for container version 2
33a3908 Merge pull request #33 from open-power/v0.9-release
0766395 prep for 0.9 release
Change-Id: I37b77a72f3990d929dbaa1f1c5c33ec2d4c1cf00
Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr>
---
M 3rdparty/open-power-signing-utils
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/78/84978/1
diff --git a/3rdparty/open-power-signing-utils b/3rdparty/open-power-signing-utils
index 591c8f5..9a80ee8 160000
--- a/3rdparty/open-power-signing-utils
+++ b/3rdparty/open-power-signing-utils
@@ -1 +1 @@
-Subproject commit 591c8f53482243626901e1cc8a4ae321f314040d
+Subproject commit 9a80ee84740877dbbe1201436503da725f13c9b4
--
To view, visit https://review.coreboot.org/c/coreboot/+/84978?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I37b77a72f3990d929dbaa1f1c5c33ec2d4c1cf00
Gerrit-Change-Number: 84978
Gerrit-PatchSet: 1
Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr>