coreboot-gerrit November 2024

coreboot-gerrit@coreboot.org

1 participants
2202 discussions

[XS] Change in coreboot[main]: soc/intel/alderlake: Disable UFS controllers only on S5 resume
by Jayvik Desai (Code Review) 04 Nov '24

04 Nov '24

Attention is currently required from: Dinesh Gehlot, Kapil Porwal, Karthik Ramasubramanian, Nick Vaccaro, Subrata Banik. Jayvik Desai has posted comments on this change by Subrata Banik. ( https://review.coreboot.org/c/coreboot/+/84974?usp=email ) Change subject: soc/intel/alderlake: Disable UFS controllers only on S5 resume ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/84974?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ia27d2156a002cef032d5f57d212cf4eb520b3bdf Gerrit-Change-Number: 84974 Gerrit-PatchSet: 1 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Comment-Date: Mon, 04 Nov 2024 12:00:03 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in coreboot[main]: mb/google/dedede/var/awasuki: Enable LTR mechanism for PCIe root port 8
by Weimin Wu (Code Review) 04 Nov '24

04 Nov '24

Attention is currently required from: Eric Lai, Hualin Wei, Subrata Banik. Weimin Wu has posted comments on this change by Hualin Wei. ( https://review.coreboot.org/c/coreboot/+/84951?usp=email ) Change subject: mb/google/dedede/var/awasuki: Enable LTR mechanism for PCIe root port 8 ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/84951?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I0c80f89b4fdb52a5d9da17548537072ec2d40418 Gerrit-Change-Number: 84951 Gerrit-PatchSet: 3 Gerrit-Owner: Hualin Wei <weihualin(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Eric Lai <ericllai(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Hualin Wei <weihualin(a)huaqin.corp-partner.google.com> Gerrit-Comment-Date: Mon, 04 Nov 2024 11:37:40 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in coreboot[main]: mb/google/dedede/var/awasuki: Enable LTR mechanism for PCIe root port 8
by Hualin Wei (Code Review) 04 Nov '24

04 Nov '24

Attention is currently required from: Weimin Wu. Hualin Wei has posted comments on this change by Hualin Wei. ( https://review.coreboot.org/c/coreboot/+/84951?usp=email ) Change subject: mb/google/dedede/var/awasuki: Enable LTR mechanism for PCIe root port 8 ...................................................................... Patch Set 3: This change is ready for review. -- To view, visit https://review.coreboot.org/c/coreboot/+/84951?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I0c80f89b4fdb52a5d9da17548537072ec2d40418 Gerrit-Change-Number: 84951 Gerrit-PatchSet: 3 Gerrit-Owner: Hualin Wei <weihualin(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com> Gerrit-Comment-Date: Mon, 04 Nov 2024 11:35:41 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No

1 0

[XS] Change in coreboot[main]: soc/intel/common/cnvi: Add PRW for CNVi device
by Sean Rhodes (Code Review) 04 Nov '24

04 Nov '24

Sean Rhodes has posted comments on this change by Sean Rhodes. ( https://review.coreboot.org/c/coreboot/+/84993?usp=email ) Change subject: soc/intel/common/cnvi: Add PRW for CNVi device ...................................................................... Set Ready For Review -- To view, visit https://review.coreboot.org/c/coreboot/+/84993?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I8b3dcdf7b6cdc32fb910e7a4783029076717beff Gerrit-Change-Number: 84993 Gerrit-PatchSet: 1 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Comment-Date: Mon, 04 Nov 2024 10:26:01 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No

1 0

[S] Change in coreboot[main]: drivers/usb/intel_bluetooth: Add GBTR Method
by Sean Rhodes (Code Review) 04 Nov '24

04 Nov '24

Sean Rhodes has posted comments on this change by Sean Rhodes. ( https://review.coreboot.org/c/coreboot/+/84992?usp=email ) Change subject: drivers/usb/intel_bluetooth: Add GBTR Method ...................................................................... Set Ready For Review -- To view, visit https://review.coreboot.org/c/coreboot/+/84992?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I8d025f63192218399b8d5e60e847853e54a8353c Gerrit-Change-Number: 84992 Gerrit-PatchSet: 1 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Comment-Date: Mon, 04 Nov 2024 10:25:57 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No

1 0

[XS] Change in coreboot[main]: soc/intel/common/cnvi: Nit - fix path in comment
by Sean Rhodes (Code Review) 04 Nov '24

04 Nov '24

Sean Rhodes has posted comments on this change by Sean Rhodes. ( https://review.coreboot.org/c/coreboot/+/84991?usp=email ) Change subject: soc/intel/common/cnvi: Nit - fix path in comment ...................................................................... Set Ready For Review -- To view, visit https://review.coreboot.org/c/coreboot/+/84991?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: If1e5d70a23c2a139ef3ee4970db2e5d528c2661e Gerrit-Change-Number: 84991 Gerrit-PatchSet: 1 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Comment-Date: Mon, 04 Nov 2024 10:25:55 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No

1 0

[M] Change in coreboot[main]: drivers/usb/intel_bluetooth: Relocate BTRT to \_SB.PCI0
by Sean Rhodes (Code Review) 04 Nov '24

04 Nov '24

Sean Rhodes has posted comments on this change by Sean Rhodes. ( https://review.coreboot.org/c/coreboot/+/84990?usp=email ) Change subject: drivers/usb/intel_bluetooth: Relocate BTRT to \_SB.PCI0 ...................................................................... Set Ready For Review -- To view, visit https://review.coreboot.org/c/coreboot/+/84990?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I044b745dce41c9d7a86384b42543ad93485d85ce Gerrit-Change-Number: 84990 Gerrit-PatchSet: 1 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Comment-Date: Mon, 04 Nov 2024 10:25:52 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No

1 0

[XS] Change in coreboot[main]: drivers/usb/intel_bluetooth: Fix GBTE return value
by Sean Rhodes (Code Review) 04 Nov '24

04 Nov '24

Sean Rhodes has posted comments on this change by Sean Rhodes. ( https://review.coreboot.org/c/coreboot/+/84989?usp=email ) Change subject: drivers/usb/intel_bluetooth: Fix GBTE return value ...................................................................... Set Ready For Review -- To view, visit https://review.coreboot.org/c/coreboot/+/84989?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I13263d479d1a4520abaf1b6b38514d021e7d4dc9 Gerrit-Change-Number: 84989 Gerrit-PatchSet: 1 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Comment-Date: Mon, 04 Nov 2024 10:25:49 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No

1 0

[XS] Change in coreboot[main]: drivers/usb/intel_bluetooth: Change the Power Resource to S0
by Sean Rhodes (Code Review) 04 Nov '24

04 Nov '24

Sean Rhodes has posted comments on this change by Sean Rhodes. ( https://review.coreboot.org/c/coreboot/+/84988?usp=email ) Change subject: drivers/usb/intel_bluetooth: Change the Power Resource to S0 ...................................................................... Set Ready For Review -- To view, visit https://review.coreboot.org/c/coreboot/+/84988?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I9ae710ef452c717ec414324d2847bf3218fd62d3 Gerrit-Change-Number: 84988 Gerrit-PatchSet: 1 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Comment-Date: Mon, 04 Nov 2024 10:25:46 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No

1 0

[S] Change in coreboot[main]: mb/google/dedede/var/drawcia: Correct board version in variant_device...
by Robert Chen (Code Review) 04 Nov '24

04 Nov '24

Attention is currently required from: Derek Huang, Karthik Ramasubramanian, Paul Menzel, Shou-Chieh Hsu. Robert Chen has posted comments on this change by Robert Chen. ( https://review.coreboot.org/c/coreboot/+/84953?usp=email ) Change subject: mb/google/dedede/var/drawcia: Correct board version in variant_devicetree_update ...................................................................... Patch Set 11: (5 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/84953/comment/315b349f_698a94c6?us… : PS8, Line 7: Fix devicetree_update > Something more specific would be nice. Done File src/mainboard/google/dedede/variants/drawcia/ramstage.c: https://review.coreboot.org/c/coreboot/+/84953/comment/e0ef6559_ef123dcc?us… : PS8, Line 14: > Unrelated. Done https://review.coreboot.org/c/coreboot/+/84953/comment/125dd646_8fca8d10?us… : PS8, Line 36: if (board_version > 0xb) : ext_vr_update(); > Before it was run for `board_version < 9`. […] Used to be `board_version < 9` not run, Change to https://review.coreboot.org/c/coreboot/+/84953/comment/070db2a5_56def160?us… : PS8, Line 38: /* Remove power IC after board version 0xc */ > What about 0xf? Should it be mentioned in the comment? Refering to Dedede-Drawcia DesignConfigID + FW_Config Sheet. Drawper actully board version 0xa, 0xb and 0xf. https://review.coreboot.org/c/coreboot/+/84953/comment/232cd5d3_cf0dc594?us… : PS8, Line 38: /* Remove power IC after board version 0xc */ : if (board_version != 0xa && : board_version != 0xb && : board_version != 0xf) : update_lte_device_drawcia(); : /* board version 0xa, 0xb , 0xf is for drawper unit */ > This is not mentioned in the commit message. […] Done -- To view, visit https://review.coreboot.org/c/coreboot/+/84953?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I13f4709b6f490169f69054cf2b26430b4de0746a Gerrit-Change-Number: 84953 Gerrit-PatchSet: 11 Gerrit-Owner: Robert Chen <robert.chen(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Derek Huang <derekhuang(a)google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Shou-Chieh Hsu <shouchieh(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Kevin Chiu <kevin.chiu.17802(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Derek Huang <derekhuang(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Shou-Chieh Hsu <shouchieh(a)google.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Comment-Date: Mon, 04 Nov 2024 09:02:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit November 2024