coreboot-gerrit November 2024

coreboot-gerrit@coreboot.org

1 participants
2521 discussions

[XS] Change in coreboot[main]: soc/intel/alderlake: Use CSE sync in ramstage config
by Christian Walter (Code Review) 12 Nov '24

12 Nov '24

Attention is currently required from: Dinesh Gehlot, Kapil Porwal, Karthik Ramasubramanian, Nick Vaccaro, Subrata Banik. Christian Walter has posted comments on this change by Subrata Banik. ( https://review.coreboot.org/c/coreboot/+/85108?usp=email ) Change subject: soc/intel/alderlake: Use CSE sync in ramstage config ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/85108?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I0dd335d5653d774bb5a2e6d7b65831bba080f272 Gerrit-Change-Number: 85108 Gerrit-PatchSet: 1 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Comment-Date: Tue, 12 Nov 2024 13:54:42 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in coreboot[main]: vc/google: Refactor config to set Fn key scancode
by Paul Menzel (Code Review) 12 Nov '24

12 Nov '24

Attention is currently required from: Dinesh Gehlot, Kapil Porwal, Nick Vaccaro. Paul Menzel has posted comments on this change by Kapil Porwal. ( https://review.coreboot.org/c/coreboot/+/85109?usp=email ) Change subject: vc/google: Refactor config to set Fn key scancode ...................................................................... Patch Set 1: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/85109/comment/ca3dac14_ee00bd1f?us… : PS1, Line 9: Google Strauss : keyboard > Thanks @paulepanter@mailbox.org for the review. […] What is the difference to the standard keyboard version? A different key? -- To view, visit https://review.coreboot.org/c/coreboot/+/85109?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I2b5d54879d415e4403b2d7948432bb06ab983b86 Gerrit-Change-Number: 85109 Gerrit-PatchSet: 1 Gerrit-Owner: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Comment-Date: Tue, 12 Nov 2024 13:12:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Kapil Porwal <kapilporwal(a)google.com> Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>

1 0

[XS] Change in coreboot[main]: soc/intel/alderlake: Use CSE sync in ramstage config
by Subrata Banik (Code Review) 12 Nov '24

12 Nov '24

Attention is currently required from: Christian Walter, Dinesh Gehlot, Kapil Porwal, Karthik Ramasubramanian, Nick Vaccaro. Subrata Banik has posted comments on this change by Subrata Banik. ( https://review.coreboot.org/c/coreboot/+/85108?usp=email ) Change subject: soc/intel/alderlake: Use CSE sync in ramstage config ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > If you say `SOC_INTEL_CSE_LITE_SKU` was not correctly used to determine whether o render eSOL during ramstage, do we need to update the other boards selecting `SOC_INTEL_CSE_LITE_SKU` to also select `SOC_INTEL_CSE_LITE_SYNC_IN_RAMSTAGE` ? > > Taking a quick look it's mostly Google and Intel CRBs. We might not need to change all instances of SOC_INTEL_CSE_LITE_SKU to SOC_INTEL_CSE_LITE_SYNC_IN_RAMSTAGE because they're the same unless where we're performing CSE sync. In short, since SOC_INTEL_CSE_LITE_SYNC_IN_RAMSTAGE and SOC_INTEL_CSE_LITE_SYNC_IN_ROMSTAGE handle CSE sync at differnet stages, we need to show eSOL. I initially landed a CL for coreboot (alder lake) to render eSOL (in ramstage), but I missed the case for SOC_INTEL_CSE_LITE_SYNC_IN_ROMSTAGE, and now Karthik wants to land it for romstage https://review.coreboot.org/c/coreboot/+/85103. Therefore, I wish to update my original CL to say what I did earlier is for Ramstage and that clear path for Karthik. -- To view, visit https://review.coreboot.org/c/coreboot/+/85108?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I0dd335d5653d774bb5a2e6d7b65831bba080f272 Gerrit-Change-Number: 85108 Gerrit-PatchSet: 1 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Comment-Date: Tue, 12 Nov 2024 13:07:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Christian Walter <christian.walter(a)9elements.com>

1 0

[S] Change in coreboot[main]: vc/google: Refactor config to set Fn key scancode
by Kapil Porwal (Code Review) 12 Nov '24

12 Nov '24

Attention is currently required from: Dinesh Gehlot, Nick Vaccaro, Paul Menzel. Kapil Porwal has posted comments on this change by Kapil Porwal. ( https://review.coreboot.org/c/coreboot/+/85109?usp=email ) Change subject: vc/google: Refactor config to set Fn key scancode ...................................................................... Patch Set 1: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/85109/comment/76414f11_71b721fc?us… : PS1, Line 9: Google Strauss : keyboard > What is this? Any more info? Thanks @paulepanter@mailbox.org for the review. Could you please elaborate on what type of information is required apart from keyboard name? -- To view, visit https://review.coreboot.org/c/coreboot/+/85109?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I2b5d54879d415e4403b2d7948432bb06ab983b86 Gerrit-Change-Number: 85109 Gerrit-PatchSet: 1 Gerrit-Owner: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Comment-Date: Tue, 12 Nov 2024 12:18:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>

1 0

[XS] Change in coreboot[main]: soc/intel/alderlake: Use CSE sync in ramstage config
by Christian Walter (Code Review) 12 Nov '24

12 Nov '24

Attention is currently required from: Dinesh Gehlot, Kapil Porwal, Karthik Ramasubramanian, Nick Vaccaro, Subrata Banik. Christian Walter has posted comments on this change by Subrata Banik. ( https://review.coreboot.org/c/coreboot/+/85108?usp=email ) Change subject: soc/intel/alderlake: Use CSE sync in ramstage config ...................................................................... Patch Set 1: Code-Review+1 (1 comment) Patchset: PS1: If you say `SOC_INTEL_CSE_LITE_SKU` was not correctly used to determine whether o render eSOL during ramstage, do we need to update the other boards selecting `SOC_INTEL_CSE_LITE_SKU` to also select `SOC_INTEL_CSE_LITE_SYNC_IN_RAMSTAGE` ? Taking a quick look it's mostly Google and Intel CRBs. -- To view, visit https://review.coreboot.org/c/coreboot/+/85108?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I0dd335d5653d774bb5a2e6d7b65831bba080f272 Gerrit-Change-Number: 85108 Gerrit-PatchSet: 1 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Comment-Date: Tue, 12 Nov 2024 11:48:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[M] Change in blobs[main]: soc/mediatek/mt8196: Add dram.elf version 0.3.0 for DRAM calibration
by Crystal Guo (Code Review) 12 Nov '24

12 Nov '24

Crystal Guo has uploaded a new patch set (#2). ( https://review.coreboot.org/c/blobs/+/85110?usp=email ) Change subject: soc/mediatek/mt8196: Add dram.elf version 0.3.0 for DRAM calibration ...................................................................... soc/mediatek/mt8196: Add dram.elf version 0.3.0 for DRAM calibration This blob includes both full calibration and fast calibration flow. BUG=b:317009620 TEST=DRAM calibration pass. Change-Id: I726f1cdadb99ba160cf20e65a6eacaa81998d043 Signed-off-by: Crystal Guo <crystal.guo(a)mediatek.corp-partner.google.com> --- M soc/mediatek/mt8196/README.md A soc/mediatek/mt8196/dram.elf A soc/mediatek/mt8196/dram.elf.md5 A soc/mediatek/mt8196/dram_release_notes.txt 4 files changed, 107 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/blobs refs/changes/10/85110/2 -- To view, visit https://review.coreboot.org/c/blobs/+/85110?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: blobs Gerrit-Branch: main Gerrit-Change-Id: I726f1cdadb99ba160cf20e65a6eacaa81998d043 Gerrit-Change-Number: 85110 Gerrit-PatchSet: 2 Gerrit-Owner: Crystal Guo <crystal.guo(a)mediatek.corp-partner.google.com>

1 0

[S] Change in coreboot[main]: vc/google: Refactor config to set Fn key scancode
by Paul Menzel (Code Review) 12 Nov '24

12 Nov '24

Attention is currently required from: Dinesh Gehlot, Kapil Porwal, Nick Vaccaro. Paul Menzel has posted comments on this change by Kapil Porwal. ( https://review.coreboot.org/c/coreboot/+/85109?usp=email ) The change is no longer submittable: All-Comments-Resolved is unsatisfied now. Change subject: vc/google: Refactor config to set Fn key scancode ...................................................................... Patch Set 1: (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/85109/comment/cd52ad19_5ab7ce93?us… : PS1, Line 9: Google Strauss : keyboard What is this? Any more info? File src/vendorcode/google/Kconfig: https://review.coreboot.org/c/coreboot/+/85109/comment/3dc66348_1154a5f2?us… : PS1, Line 36: Strauss keyboard Could you please extend it with more information? -- To view, visit https://review.coreboot.org/c/coreboot/+/85109?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I2b5d54879d415e4403b2d7948432bb06ab983b86 Gerrit-Change-Number: 85109 Gerrit-PatchSet: 1 Gerrit-Owner: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Comment-Date: Tue, 12 Nov 2024 11:07:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[S] Change in coreboot[main]: vc/google: Refactor config to set Fn key scancode
by Jayvik Desai (Code Review) 12 Nov '24

12 Nov '24

Attention is currently required from: Dinesh Gehlot, Kapil Porwal, Nick Vaccaro. Jayvik Desai has posted comments on this change by Kapil Porwal. ( https://review.coreboot.org/c/coreboot/+/85109?usp=email ) Change subject: vc/google: Refactor config to set Fn key scancode ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/85109?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I2b5d54879d415e4403b2d7948432bb06ab983b86 Gerrit-Change-Number: 85109 Gerrit-PatchSet: 1 Gerrit-Owner: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Comment-Date: Tue, 12 Nov 2024 11:04:14 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in coreboot[main]: soc/intel/alderlake: Use CSE sync in ramstage config
by Jayvik Desai (Code Review) 12 Nov '24

12 Nov '24

Attention is currently required from: Dinesh Gehlot, Kapil Porwal, Karthik Ramasubramanian, Nick Vaccaro, Subrata Banik. Jayvik Desai has posted comments on this change by Subrata Banik. ( https://review.coreboot.org/c/coreboot/+/85108?usp=email ) Change subject: soc/intel/alderlake: Use CSE sync in ramstage config ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/85108?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I0dd335d5653d774bb5a2e6d7b65831bba080f272 Gerrit-Change-Number: 85108 Gerrit-PatchSet: 1 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Comment-Date: Tue, 12 Nov 2024 11:02:25 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in blobs[main]: soc/mediatek/mt8196: Add dram.elf version 0.3.0 for DRAM calibration
by Crystal Guo (Code Review) 12 Nov '24

12 Nov '24

Crystal Guo has uploaded this change for review. ( https://review.coreboot.org/c/blobs/+/85110?usp=email ) Change subject: soc/mediatek/mt8196: Add dram.elf version 0.3.0 for DRAM calibration ...................................................................... soc/mediatek/mt8196: Add dram.elf version 0.3.0 for DRAM calibration This blob includes both full calibration and fast calibration flow. BUG=b:317009620 TEST=DRAM calibration pass. Change-Id: I726f1cdadb99ba160cf20e65a6eacaa81998d043 Signed-off-by: Crystal Guo <crystal.guo(a)mediatek.corp-partner.google.com> --- A soc/mediatek/mt8196/dram.elf A soc/mediatek/mt8196/dram.elf.md5 A soc/mediatek/mt8196/dram_release_notes.txt 3 files changed, 5 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/blobs refs/changes/10/85110/1 diff --git a/soc/mediatek/mt8196/dram.elf b/soc/mediatek/mt8196/dram.elf new file mode 100644 index 0000000..3faa1cf --- /dev/null +++ b/soc/mediatek/mt8196/dram.elf Binary files differ diff --git a/soc/mediatek/mt8196/dram.elf.md5 b/soc/mediatek/mt8196/dram.elf.md5 new file mode 100644 index 0000000..cb044a4 --- /dev/null +++ b/soc/mediatek/mt8196/dram.elf.md5 @@ -0,0 +1 @@ +f28bedae7529a3be011fb0a6bb478c94 *dram.elf diff --git a/soc/mediatek/mt8196/dram_release_notes.txt b/soc/mediatek/mt8196/dram_release_notes.txt new file mode 100644 index 0000000..1d11712 --- /dev/null +++ b/soc/mediatek/mt8196/dram_release_notes.txt @@ -0,0 +1,4 @@ +# 0.3.0 + +1. An official build. + Protocol (params header) version: 3 -- To view, visit https://review.coreboot.org/c/blobs/+/85110?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: blobs Gerrit-Branch: main Gerrit-Change-Id: I726f1cdadb99ba160cf20e65a6eacaa81998d043 Gerrit-Change-Number: 85110 Gerrit-PatchSet: 1 Gerrit-Owner: Crystal Guo <crystal.guo(a)mediatek.corp-partner.google.com>

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit November 2024