coreboot-gerrit January 2024

coreboot-gerrit@coreboot.org

1 participants
3044 discussions

[XS] Change in coreboot[main]: cpu: Rename Makefiles from .inc to .mk
by Felix Singer (Code Review) 24 Jan '24

24 Jan '24

Felix Singer has submitted this change. ( https://review.coreboot.org/c/coreboot/+/80068?usp=email ) ( 3 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: cpu: Rename Makefiles from .inc to .mk ...................................................................... cpu: Rename Makefiles from .inc to .mk The .inc suffix is confusing to various tools as it's not specific to Makefiles. This means that editors don't recognize the files, and don't open them with highlighting and any other specific editor functionality. This issue is also seen in the release notes generation script where Makefiles get renamed before running cloc. Signed-off-by: Martin Roth <gaumless(a)gmail.com> Change-Id: I552d487978906f5ea74c3d0d85373fe5b2de3f38 Reviewed-on: https://review.coreboot.org/c/coreboot/+/80068 Reviewed-by: Michael Niewöhner <foss(a)mniewoehner.de> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Reviewed-by: Maximilian Brune <maximilian.brune(a)9elements.com> --- R src/cpu/Makefile.mk R src/cpu/amd/Makefile.mk R src/cpu/amd/mtrr/Makefile.mk R src/cpu/amd/pi/00730F01/Makefile.mk R src/cpu/amd/pi/Makefile.mk R src/cpu/armltd/Makefile.mk R src/cpu/intel/Makefile.mk R src/cpu/intel/common/Makefile.mk R src/cpu/intel/fit/Makefile.mk R src/cpu/intel/haswell/Makefile.mk R src/cpu/intel/microcode/Makefile.mk R src/cpu/intel/model_1067x/Makefile.mk R src/cpu/intel/model_106cx/Makefile.mk R src/cpu/intel/model_2065x/Makefile.mk R src/cpu/intel/model_206ax/Makefile.mk R src/cpu/intel/model_65x/Makefile.mk R src/cpu/intel/model_67x/Makefile.mk R src/cpu/intel/model_68x/Makefile.mk R src/cpu/intel/model_6bx/Makefile.mk R src/cpu/intel/model_6ex/Makefile.mk R src/cpu/intel/model_6fx/Makefile.mk R src/cpu/intel/model_6xx/Makefile.mk R src/cpu/intel/model_f2x/Makefile.mk R src/cpu/intel/model_f3x/Makefile.mk R src/cpu/intel/model_f4x/Makefile.mk R src/cpu/intel/slot_1/Makefile.mk R src/cpu/intel/smm/Makefile.mk R src/cpu/intel/smm/gen1/Makefile.mk R src/cpu/intel/socket_441/Makefile.mk R src/cpu/intel/socket_BGA956/Makefile.mk R src/cpu/intel/socket_FCBGA559/Makefile.mk R src/cpu/intel/socket_LGA775/Makefile.mk R src/cpu/intel/socket_m/Makefile.mk R src/cpu/intel/socket_mPGA604/Makefile.mk R src/cpu/intel/socket_p/Makefile.mk R src/cpu/intel/speedstep/Makefile.mk R src/cpu/intel/turbo/Makefile.mk R src/cpu/power9/Makefile.mk R src/cpu/qemu-power8/Makefile.mk R src/cpu/qemu-x86/Makefile.mk R src/cpu/x86/64bit/Makefile.mk R src/cpu/x86/Makefile.mk R src/cpu/x86/cache/Makefile.mk R src/cpu/x86/lapic/Makefile.mk R src/cpu/x86/mtrr/Makefile.mk R src/cpu/x86/name/Makefile.mk R src/cpu/x86/pae/Makefile.mk R src/cpu/x86/smm/Makefile.mk R src/cpu/x86/tsc/Makefile.mk 49 files changed, 1 insertion(+), 1 deletion(-) Approvals: Michael Niewöhner: Looks good to me, approved Maximilian Brune: Looks good to me, approved build bot (Jenkins): Verified Felix Singer: Looks good to me, approved diff --git a/src/cpu/Makefile.inc b/src/cpu/Makefile.mk similarity index 100% rename from src/cpu/Makefile.inc rename to src/cpu/Makefile.mk diff --git a/src/cpu/amd/Makefile.inc b/src/cpu/amd/Makefile.mk similarity index 100% rename from src/cpu/amd/Makefile.inc rename to src/cpu/amd/Makefile.mk diff --git a/src/cpu/amd/mtrr/Makefile.inc b/src/cpu/amd/mtrr/Makefile.mk similarity index 100% rename from src/cpu/amd/mtrr/Makefile.inc rename to src/cpu/amd/mtrr/Makefile.mk diff --git a/src/cpu/amd/pi/00730F01/Makefile.inc b/src/cpu/amd/pi/00730F01/Makefile.mk similarity index 100% rename from src/cpu/amd/pi/00730F01/Makefile.inc rename to src/cpu/amd/pi/00730F01/Makefile.mk diff --git a/src/cpu/amd/pi/Makefile.inc b/src/cpu/amd/pi/Makefile.mk similarity index 100% rename from src/cpu/amd/pi/Makefile.inc rename to src/cpu/amd/pi/Makefile.mk diff --git a/src/cpu/armltd/Makefile.inc b/src/cpu/armltd/Makefile.mk similarity index 100% rename from src/cpu/armltd/Makefile.inc rename to src/cpu/armltd/Makefile.mk diff --git a/src/cpu/intel/Makefile.inc b/src/cpu/intel/Makefile.mk similarity index 92% rename from src/cpu/intel/Makefile.inc rename to src/cpu/intel/Makefile.mk index dc0bc53..bc8f537 100644 --- a/src/cpu/intel/Makefile.inc +++ b/src/cpu/intel/Makefile.mk @@ -3,7 +3,7 @@ # Note: From here on down, we are socket-centric. Socket choice determines # what other CPU files are included. # -# Therefore: ONLY include Makefile.inc from socket directories! +# Therefore: ONLY include Makefiles from socket directories! subdirs-$(CONFIG_CPU_INTEL_FIRMWARE_INTERFACE_TABLE) += fit subdirs-$(CONFIG_CPU_INTEL_SOCKET_441) += socket_441 diff --git a/src/cpu/intel/common/Makefile.inc b/src/cpu/intel/common/Makefile.mk similarity index 100% rename from src/cpu/intel/common/Makefile.inc rename to src/cpu/intel/common/Makefile.mk diff --git a/src/cpu/intel/fit/Makefile.inc b/src/cpu/intel/fit/Makefile.mk similarity index 100% rename from src/cpu/intel/fit/Makefile.inc rename to src/cpu/intel/fit/Makefile.mk diff --git a/src/cpu/intel/haswell/Makefile.inc b/src/cpu/intel/haswell/Makefile.mk similarity index 100% rename from src/cpu/intel/haswell/Makefile.inc rename to src/cpu/intel/haswell/Makefile.mk diff --git a/src/cpu/intel/microcode/Makefile.inc b/src/cpu/intel/microcode/Makefile.mk similarity index 100% rename from src/cpu/intel/microcode/Makefile.inc rename to src/cpu/intel/microcode/Makefile.mk diff --git a/src/cpu/intel/model_1067x/Makefile.inc b/src/cpu/intel/model_1067x/Makefile.mk similarity index 100% rename from src/cpu/intel/model_1067x/Makefile.inc rename to src/cpu/intel/model_1067x/Makefile.mk diff --git a/src/cpu/intel/model_106cx/Makefile.inc b/src/cpu/intel/model_106cx/Makefile.mk similarity index 100% rename from src/cpu/intel/model_106cx/Makefile.inc rename to src/cpu/intel/model_106cx/Makefile.mk diff --git a/src/cpu/intel/model_2065x/Makefile.inc b/src/cpu/intel/model_2065x/Makefile.mk similarity index 100% rename from src/cpu/intel/model_2065x/Makefile.inc rename to src/cpu/intel/model_2065x/Makefile.mk diff --git a/src/cpu/intel/model_206ax/Makefile.inc b/src/cpu/intel/model_206ax/Makefile.mk similarity index 100% rename from src/cpu/intel/model_206ax/Makefile.inc rename to src/cpu/intel/model_206ax/Makefile.mk diff --git a/src/cpu/intel/model_65x/Makefile.inc b/src/cpu/intel/model_65x/Makefile.mk similarity index 100% rename from src/cpu/intel/model_65x/Makefile.inc rename to src/cpu/intel/model_65x/Makefile.mk diff --git a/src/cpu/intel/model_67x/Makefile.inc b/src/cpu/intel/model_67x/Makefile.mk similarity index 100% rename from src/cpu/intel/model_67x/Makefile.inc rename to src/cpu/intel/model_67x/Makefile.mk diff --git a/src/cpu/intel/model_68x/Makefile.inc b/src/cpu/intel/model_68x/Makefile.mk similarity index 100% rename from src/cpu/intel/model_68x/Makefile.inc rename to src/cpu/intel/model_68x/Makefile.mk diff --git a/src/cpu/intel/model_6bx/Makefile.inc b/src/cpu/intel/model_6bx/Makefile.mk similarity index 100% rename from src/cpu/intel/model_6bx/Makefile.inc rename to src/cpu/intel/model_6bx/Makefile.mk diff --git a/src/cpu/intel/model_6ex/Makefile.inc b/src/cpu/intel/model_6ex/Makefile.mk similarity index 100% rename from src/cpu/intel/model_6ex/Makefile.inc rename to src/cpu/intel/model_6ex/Makefile.mk diff --git a/src/cpu/intel/model_6fx/Makefile.inc b/src/cpu/intel/model_6fx/Makefile.mk similarity index 100% rename from src/cpu/intel/model_6fx/Makefile.inc rename to src/cpu/intel/model_6fx/Makefile.mk diff --git a/src/cpu/intel/model_6xx/Makefile.inc b/src/cpu/intel/model_6xx/Makefile.mk similarity index 100% rename from src/cpu/intel/model_6xx/Makefile.inc rename to src/cpu/intel/model_6xx/Makefile.mk diff --git a/src/cpu/intel/model_f2x/Makefile.inc b/src/cpu/intel/model_f2x/Makefile.mk similarity index 100% rename from src/cpu/intel/model_f2x/Makefile.inc rename to src/cpu/intel/model_f2x/Makefile.mk diff --git a/src/cpu/intel/model_f3x/Makefile.inc b/src/cpu/intel/model_f3x/Makefile.mk similarity index 100% rename from src/cpu/intel/model_f3x/Makefile.inc rename to src/cpu/intel/model_f3x/Makefile.mk diff --git a/src/cpu/intel/model_f4x/Makefile.inc b/src/cpu/intel/model_f4x/Makefile.mk similarity index 100% rename from src/cpu/intel/model_f4x/Makefile.inc rename to src/cpu/intel/model_f4x/Makefile.mk diff --git a/src/cpu/intel/slot_1/Makefile.inc b/src/cpu/intel/slot_1/Makefile.mk similarity index 100% rename from src/cpu/intel/slot_1/Makefile.inc rename to src/cpu/intel/slot_1/Makefile.mk diff --git a/src/cpu/intel/smm/Makefile.inc b/src/cpu/intel/smm/Makefile.mk similarity index 100% rename from src/cpu/intel/smm/Makefile.inc rename to src/cpu/intel/smm/Makefile.mk diff --git a/src/cpu/intel/smm/gen1/Makefile.inc b/src/cpu/intel/smm/gen1/Makefile.mk similarity index 100% rename from src/cpu/intel/smm/gen1/Makefile.inc rename to src/cpu/intel/smm/gen1/Makefile.mk diff --git a/src/cpu/intel/socket_441/Makefile.inc b/src/cpu/intel/socket_441/Makefile.mk similarity index 100% rename from src/cpu/intel/socket_441/Makefile.inc rename to src/cpu/intel/socket_441/Makefile.mk diff --git a/src/cpu/intel/socket_BGA956/Makefile.inc b/src/cpu/intel/socket_BGA956/Makefile.mk similarity index 100% rename from src/cpu/intel/socket_BGA956/Makefile.inc rename to src/cpu/intel/socket_BGA956/Makefile.mk diff --git a/src/cpu/intel/socket_FCBGA559/Makefile.inc b/src/cpu/intel/socket_FCBGA559/Makefile.mk similarity index 100% rename from src/cpu/intel/socket_FCBGA559/Makefile.inc rename to src/cpu/intel/socket_FCBGA559/Makefile.mk diff --git a/src/cpu/intel/socket_LGA775/Makefile.inc b/src/cpu/intel/socket_LGA775/Makefile.mk similarity index 100% rename from src/cpu/intel/socket_LGA775/Makefile.inc rename to src/cpu/intel/socket_LGA775/Makefile.mk diff --git a/src/cpu/intel/socket_m/Makefile.inc b/src/cpu/intel/socket_m/Makefile.mk similarity index 100% rename from src/cpu/intel/socket_m/Makefile.inc rename to src/cpu/intel/socket_m/Makefile.mk diff --git a/src/cpu/intel/socket_mPGA604/Makefile.inc b/src/cpu/intel/socket_mPGA604/Makefile.mk similarity index 100% rename from src/cpu/intel/socket_mPGA604/Makefile.inc rename to src/cpu/intel/socket_mPGA604/Makefile.mk diff --git a/src/cpu/intel/socket_p/Makefile.inc b/src/cpu/intel/socket_p/Makefile.mk similarity index 100% rename from src/cpu/intel/socket_p/Makefile.inc rename to src/cpu/intel/socket_p/Makefile.mk diff --git a/src/cpu/intel/speedstep/Makefile.inc b/src/cpu/intel/speedstep/Makefile.mk similarity index 100% rename from src/cpu/intel/speedstep/Makefile.inc rename to src/cpu/intel/speedstep/Makefile.mk diff --git a/src/cpu/intel/turbo/Makefile.inc b/src/cpu/intel/turbo/Makefile.mk similarity index 100% rename from src/cpu/intel/turbo/Makefile.inc rename to src/cpu/intel/turbo/Makefile.mk diff --git a/src/cpu/power9/Makefile.inc b/src/cpu/power9/Makefile.mk similarity index 100% rename from src/cpu/power9/Makefile.inc rename to src/cpu/power9/Makefile.mk diff --git a/src/cpu/qemu-power8/Makefile.inc b/src/cpu/qemu-power8/Makefile.mk similarity index 100% rename from src/cpu/qemu-power8/Makefile.inc rename to src/cpu/qemu-power8/Makefile.mk diff --git a/src/cpu/qemu-x86/Makefile.inc b/src/cpu/qemu-x86/Makefile.mk similarity index 100% rename from src/cpu/qemu-x86/Makefile.inc rename to src/cpu/qemu-x86/Makefile.mk diff --git a/src/cpu/x86/64bit/Makefile.inc b/src/cpu/x86/64bit/Makefile.mk similarity index 100% rename from src/cpu/x86/64bit/Makefile.inc rename to src/cpu/x86/64bit/Makefile.mk diff --git a/src/cpu/x86/Makefile.inc b/src/cpu/x86/Makefile.mk similarity index 100% rename from src/cpu/x86/Makefile.inc rename to src/cpu/x86/Makefile.mk diff --git a/src/cpu/x86/cache/Makefile.inc b/src/cpu/x86/cache/Makefile.mk similarity index 100% rename from src/cpu/x86/cache/Makefile.inc rename to src/cpu/x86/cache/Makefile.mk diff --git a/src/cpu/x86/lapic/Makefile.inc b/src/cpu/x86/lapic/Makefile.mk similarity index 100% rename from src/cpu/x86/lapic/Makefile.inc rename to src/cpu/x86/lapic/Makefile.mk diff --git a/src/cpu/x86/mtrr/Makefile.inc b/src/cpu/x86/mtrr/Makefile.mk similarity index 100% rename from src/cpu/x86/mtrr/Makefile.inc rename to src/cpu/x86/mtrr/Makefile.mk diff --git a/src/cpu/x86/name/Makefile.inc b/src/cpu/x86/name/Makefile.mk similarity index 100% rename from src/cpu/x86/name/Makefile.inc rename to src/cpu/x86/name/Makefile.mk diff --git a/src/cpu/x86/pae/Makefile.inc b/src/cpu/x86/pae/Makefile.mk similarity index 100% rename from src/cpu/x86/pae/Makefile.inc rename to src/cpu/x86/pae/Makefile.mk diff --git a/src/cpu/x86/smm/Makefile.inc b/src/cpu/x86/smm/Makefile.mk similarity index 100% rename from src/cpu/x86/smm/Makefile.inc rename to src/cpu/x86/smm/Makefile.mk diff --git a/src/cpu/x86/tsc/Makefile.inc b/src/cpu/x86/tsc/Makefile.mk similarity index 100% rename from src/cpu/x86/tsc/Makefile.inc rename to src/cpu/x86/tsc/Makefile.mk -- To view, visit https://review.coreboot.org/c/coreboot/+/80068?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I552d487978906f5ea74c3d0d85373fe5b2de3f38 Gerrit-Change-Number: 80068 Gerrit-PatchSet: 5 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: ron minnich <rminnich(a)gmail.com> Gerrit-MessageType: merged

1 0

[NoOp] Change in coreboot[main]: vendorcode: Rename Makefiles from .inc to .mk
by Felix Singer (Code Review) 24 Jan '24

24 Jan '24

Felix Singer has submitted this change. ( https://review.coreboot.org/c/coreboot/+/80067?usp=email ) ( 4 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: vendorcode: Rename Makefiles from .inc to .mk ...................................................................... vendorcode: Rename Makefiles from .inc to .mk The .inc suffix is confusing to various tools as it's not specific to Makefiles. This means that editors don't recognize the files, and don't open them with highlighting and any other specific editor functionality. This issue is also seen in the release notes generation script where Makefiles get renamed before running cloc. Signed-off-by: Martin Roth <gaumless(a)gmail.com> Change-Id: I80559b7c86a8fd2583cb0335279f676e0aa0209e Reviewed-on: https://review.coreboot.org/c/coreboot/+/80067 Reviewed-by: Maximilian Brune <maximilian.brune(a)9elements.com> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Reviewed-by: Michael Niewöhner <foss(a)mniewoehner.de> Reviewed-by: Erik van den Bogaert <ebogaert(a)eltan.com> --- R src/vendorcode/Makefile.mk R src/vendorcode/amd/Makefile.mk R src/vendorcode/amd/opensil/Makefile.mk R src/vendorcode/amd/opensil/genoa_poc/Makefile.mk R src/vendorcode/amd/opensil/genoa_poc/mpio/Makefile.mk R src/vendorcode/amd/pi/00670F00/Makefile.mk R src/vendorcode/amd/pi/Makefile.mk R src/vendorcode/cavium/Makefile.mk R src/vendorcode/eltan/Makefile.mk R src/vendorcode/eltan/security/Makefile.mk R src/vendorcode/eltan/security/mboot/Makefile.mk R src/vendorcode/eltan/security/verified_boot/Makefile.mk R src/vendorcode/google/Makefile.mk R src/vendorcode/google/chromeos/Makefile.mk R src/vendorcode/intel/Makefile.mk R src/vendorcode/mediatek/Makefile.mk R src/vendorcode/mediatek/mt8192/Makefile.mk R src/vendorcode/mediatek/mt8192/dramc/Makefile.mk R src/vendorcode/mediatek/mt8195/Makefile.mk R src/vendorcode/mediatek/mt8195/dramc/Makefile.mk R src/vendorcode/siemens/Makefile.mk R src/vendorcode/siemens/hwilib/Makefile.mk 22 files changed, 0 insertions(+), 0 deletions(-) Approvals: Maximilian Brune: Looks good to me, approved Felix Singer: Looks good to me, approved Michael Niewöhner: Looks good to me, approved Erik van den Bogaert: Looks good to me, but someone else must approve build bot (Jenkins): Verified diff --git a/src/vendorcode/Makefile.inc b/src/vendorcode/Makefile.mk similarity index 100% rename from src/vendorcode/Makefile.inc rename to src/vendorcode/Makefile.mk diff --git a/src/vendorcode/amd/Makefile.inc b/src/vendorcode/amd/Makefile.mk similarity index 100% rename from src/vendorcode/amd/Makefile.inc rename to src/vendorcode/amd/Makefile.mk diff --git a/src/vendorcode/amd/opensil/Makefile.inc b/src/vendorcode/amd/opensil/Makefile.mk similarity index 100% rename from src/vendorcode/amd/opensil/Makefile.inc rename to src/vendorcode/amd/opensil/Makefile.mk diff --git a/src/vendorcode/amd/opensil/genoa_poc/Makefile.inc b/src/vendorcode/amd/opensil/genoa_poc/Makefile.mk similarity index 100% rename from src/vendorcode/amd/opensil/genoa_poc/Makefile.inc rename to src/vendorcode/amd/opensil/genoa_poc/Makefile.mk diff --git a/src/vendorcode/amd/opensil/genoa_poc/mpio/Makefile.inc b/src/vendorcode/amd/opensil/genoa_poc/mpio/Makefile.mk similarity index 100% rename from src/vendorcode/amd/opensil/genoa_poc/mpio/Makefile.inc rename to src/vendorcode/amd/opensil/genoa_poc/mpio/Makefile.mk diff --git a/src/vendorcode/amd/pi/00670F00/Makefile.inc b/src/vendorcode/amd/pi/00670F00/Makefile.mk similarity index 100% rename from src/vendorcode/amd/pi/00670F00/Makefile.inc rename to src/vendorcode/amd/pi/00670F00/Makefile.mk diff --git a/src/vendorcode/amd/pi/Makefile.inc b/src/vendorcode/amd/pi/Makefile.mk similarity index 100% rename from src/vendorcode/amd/pi/Makefile.inc rename to src/vendorcode/amd/pi/Makefile.mk diff --git a/src/vendorcode/cavium/Makefile.inc b/src/vendorcode/cavium/Makefile.mk similarity index 100% rename from src/vendorcode/cavium/Makefile.inc rename to src/vendorcode/cavium/Makefile.mk diff --git a/src/vendorcode/eltan/Makefile.inc b/src/vendorcode/eltan/Makefile.mk similarity index 100% rename from src/vendorcode/eltan/Makefile.inc rename to src/vendorcode/eltan/Makefile.mk diff --git a/src/vendorcode/eltan/security/Makefile.inc b/src/vendorcode/eltan/security/Makefile.mk similarity index 100% rename from src/vendorcode/eltan/security/Makefile.inc rename to src/vendorcode/eltan/security/Makefile.mk diff --git a/src/vendorcode/eltan/security/mboot/Makefile.inc b/src/vendorcode/eltan/security/mboot/Makefile.mk similarity index 100% rename from src/vendorcode/eltan/security/mboot/Makefile.inc rename to src/vendorcode/eltan/security/mboot/Makefile.mk diff --git a/src/vendorcode/eltan/security/verified_boot/Makefile.inc b/src/vendorcode/eltan/security/verified_boot/Makefile.mk similarity index 100% rename from src/vendorcode/eltan/security/verified_boot/Makefile.inc rename to src/vendorcode/eltan/security/verified_boot/Makefile.mk diff --git a/src/vendorcode/google/Makefile.inc b/src/vendorcode/google/Makefile.mk similarity index 100% rename from src/vendorcode/google/Makefile.inc rename to src/vendorcode/google/Makefile.mk diff --git a/src/vendorcode/google/chromeos/Makefile.inc b/src/vendorcode/google/chromeos/Makefile.mk similarity index 100% rename from src/vendorcode/google/chromeos/Makefile.inc rename to src/vendorcode/google/chromeos/Makefile.mk diff --git a/src/vendorcode/intel/Makefile.inc b/src/vendorcode/intel/Makefile.mk similarity index 100% rename from src/vendorcode/intel/Makefile.inc rename to src/vendorcode/intel/Makefile.mk diff --git a/src/vendorcode/mediatek/Makefile.inc b/src/vendorcode/mediatek/Makefile.mk similarity index 100% rename from src/vendorcode/mediatek/Makefile.inc rename to src/vendorcode/mediatek/Makefile.mk diff --git a/src/vendorcode/mediatek/mt8192/Makefile.inc b/src/vendorcode/mediatek/mt8192/Makefile.mk similarity index 100% rename from src/vendorcode/mediatek/mt8192/Makefile.inc rename to src/vendorcode/mediatek/mt8192/Makefile.mk diff --git a/src/vendorcode/mediatek/mt8192/dramc/Makefile.inc b/src/vendorcode/mediatek/mt8192/dramc/Makefile.mk similarity index 100% rename from src/vendorcode/mediatek/mt8192/dramc/Makefile.inc rename to src/vendorcode/mediatek/mt8192/dramc/Makefile.mk diff --git a/src/vendorcode/mediatek/mt8195/Makefile.inc b/src/vendorcode/mediatek/mt8195/Makefile.mk similarity index 100% rename from src/vendorcode/mediatek/mt8195/Makefile.inc rename to src/vendorcode/mediatek/mt8195/Makefile.mk diff --git a/src/vendorcode/mediatek/mt8195/dramc/Makefile.inc b/src/vendorcode/mediatek/mt8195/dramc/Makefile.mk similarity index 100% rename from src/vendorcode/mediatek/mt8195/dramc/Makefile.inc rename to src/vendorcode/mediatek/mt8195/dramc/Makefile.mk diff --git a/src/vendorcode/siemens/Makefile.inc b/src/vendorcode/siemens/Makefile.mk similarity index 100% rename from src/vendorcode/siemens/Makefile.inc rename to src/vendorcode/siemens/Makefile.mk diff --git a/src/vendorcode/siemens/hwilib/Makefile.inc b/src/vendorcode/siemens/hwilib/Makefile.mk similarity index 100% rename from src/vendorcode/siemens/hwilib/Makefile.inc rename to src/vendorcode/siemens/hwilib/Makefile.mk -- To view, visit https://review.coreboot.org/c/coreboot/+/80067?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I80559b7c86a8fd2583cb0335279f676e0aa0209e Gerrit-Change-Number: 80067 Gerrit-PatchSet: 6 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Erik van den Bogaert <ebogaert(a)eltan.com> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Frans Hendriks <fhendriks(a)eltan.com> Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Xi Chen <xixi.chen(a)mediatek.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[NoOp] Change in coreboot[main]: acpi,arch,commonlib: Rename Makefiles from .inc to .mk
by Felix Singer (Code Review) 24 Jan '24

24 Jan '24

Felix Singer has submitted this change. ( https://review.coreboot.org/c/coreboot/+/80066?usp=email ) ( 3 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: acpi,arch,commonlib: Rename Makefiles from .inc to .mk ...................................................................... acpi,arch,commonlib: Rename Makefiles from .inc to .mk The .inc suffix is confusing to various tools as it's not specific to Makefiles. This means that editors don't recognize the files, and don't open them with highlighting and any other specific editor functionality. This issue is also seen in the release notes generation script where Makefiles get renamed before running cloc. Signed-off-by: Martin Roth <gaumless(a)gmail.com> Change-Id: Ice5dadd3eaadfa9962225520a3a75b05b44518ca Reviewed-on: https://review.coreboot.org/c/coreboot/+/80066 Reviewed-by: Maximilian Brune <maximilian.brune(a)9elements.com> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Michael Niewöhner <foss(a)mniewoehner.de> Reviewed-by: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> --- R src/acpi/Makefile.mk R src/arch/arm/Makefile.mk R src/arch/arm/armv4/Makefile.mk R src/arch/arm/armv7/Makefile.mk R src/arch/arm/libgcc/Makefile.mk R src/arch/arm64/Makefile.mk R src/arch/arm64/armv8/Makefile.mk R src/arch/ppc64/Makefile.mk R src/arch/riscv/Makefile.mk R src/arch/x86/Makefile.mk R src/commonlib/Makefile.mk R src/commonlib/storage/Makefile.mk 12 files changed, 0 insertions(+), 0 deletions(-) Approvals: build bot (Jenkins): Verified Felix Singer: Looks good to me, approved Michael Niewöhner: Looks good to me, approved Maximilian Brune: Looks good to me, approved diff --git a/src/acpi/Makefile.inc b/src/acpi/Makefile.mk similarity index 100% rename from src/acpi/Makefile.inc rename to src/acpi/Makefile.mk diff --git a/src/arch/arm/Makefile.inc b/src/arch/arm/Makefile.mk similarity index 100% rename from src/arch/arm/Makefile.inc rename to src/arch/arm/Makefile.mk diff --git a/src/arch/arm/armv4/Makefile.inc b/src/arch/arm/armv4/Makefile.mk similarity index 100% rename from src/arch/arm/armv4/Makefile.inc rename to src/arch/arm/armv4/Makefile.mk diff --git a/src/arch/arm/armv7/Makefile.inc b/src/arch/arm/armv7/Makefile.mk similarity index 100% rename from src/arch/arm/armv7/Makefile.inc rename to src/arch/arm/armv7/Makefile.mk diff --git a/src/arch/arm/libgcc/Makefile.inc b/src/arch/arm/libgcc/Makefile.mk similarity index 100% rename from src/arch/arm/libgcc/Makefile.inc rename to src/arch/arm/libgcc/Makefile.mk diff --git a/src/arch/arm64/Makefile.inc b/src/arch/arm64/Makefile.mk similarity index 100% rename from src/arch/arm64/Makefile.inc rename to src/arch/arm64/Makefile.mk diff --git a/src/arch/arm64/armv8/Makefile.inc b/src/arch/arm64/armv8/Makefile.mk similarity index 100% rename from src/arch/arm64/armv8/Makefile.inc rename to src/arch/arm64/armv8/Makefile.mk diff --git a/src/arch/ppc64/Makefile.inc b/src/arch/ppc64/Makefile.mk similarity index 100% rename from src/arch/ppc64/Makefile.inc rename to src/arch/ppc64/Makefile.mk diff --git a/src/arch/riscv/Makefile.inc b/src/arch/riscv/Makefile.mk similarity index 100% rename from src/arch/riscv/Makefile.inc rename to src/arch/riscv/Makefile.mk diff --git a/src/arch/x86/Makefile.inc b/src/arch/x86/Makefile.mk similarity index 100% rename from src/arch/x86/Makefile.inc rename to src/arch/x86/Makefile.mk diff --git a/src/commonlib/Makefile.inc b/src/commonlib/Makefile.mk similarity index 100% rename from src/commonlib/Makefile.inc rename to src/commonlib/Makefile.mk diff --git a/src/commonlib/storage/Makefile.inc b/src/commonlib/storage/Makefile.mk similarity index 100% rename from src/commonlib/storage/Makefile.inc rename to src/commonlib/storage/Makefile.mk -- To view, visit https://review.coreboot.org/c/coreboot/+/80066?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ice5dadd3eaadfa9962225520a3a75b05b44518ca Gerrit-Change-Number: 80066 Gerrit-PatchSet: 5 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Philipp Hug <philipp(a)hug.cx> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: ron minnich <rminnich(a)gmail.com> Gerrit-MessageType: merged

1 0

[S] Change in coreboot[main]: Makefiles: Rename top-level Makefiles from .inc to .mk
by Felix Singer (Code Review) 24 Jan '24

24 Jan '24

Felix Singer has submitted this change. ( https://review.coreboot.org/c/coreboot/+/80063?usp=email ) ( 3 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: Makefiles: Rename top-level Makefiles from .inc to .mk ...................................................................... Makefiles: Rename top-level Makefiles from .inc to .mk The .inc suffix is confusing to various tools as it's not specific to Makefiles. This means that editors don't recognize the files, and don't open them with highlighting and any other specific editor functionality. This issue is also seen in the release notes generation script where Makefiles get renamed before running cloc. The rest of the Makefiles will be renamed in following commits. Signed-off-by: Martin Roth <gaumless(a)gmail.com> Change-Id: Idaf69c6871d0bc1ee5e2e53157b8631c55eb3db9 Reviewed-on: https://review.coreboot.org/c/coreboot/+/80063 Reviewed-by: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Reviewed-by: Maximilian Brune <maximilian.brune(a)9elements.com> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Nico Huber <nico.h(a)gmx.de> --- M Makefile R Makefile.mk R payloads/Makefile.mk M payloads/coreinfo/Makefile M payloads/libpayload/Makefile R tests/Makefile.mk R toolchain.mk R util/kconfig/Makefile.mk M util/lint/kconfig_lint R util/testing/Makefile.mk 10 files changed, 19 insertions(+), 15 deletions(-) Approvals: Maximilian Brune: Looks good to me, approved Felix Singer: Looks good to me, approved Nico Huber: Looks good to me, but someone else must approve build bot (Jenkins): Verified diff --git a/Makefile b/Makefile index b521f04..4a87d2f 100644 --- a/Makefile +++ b/Makefile @@ -50,7 +50,7 @@ SYMLINK_LIST = $(call rwildcard,site-local/,symlink.txt) -# directory containing the toplevel Makefile.inc +# Directory containing the toplevel Makefile.mk TOPLEVEL := . CONFIG_SHELL := sh @@ -102,7 +102,7 @@ # This include must come _before_ the pattern rules below! # Order _does_ matter for pattern rules. -include $(srck)/Makefile.inc +include $(srck)/Makefile.mk # The cases where we don't need fully populated $(obj) lists: # 1. when no .config exists @@ -153,11 +153,12 @@ HOSTCC ?= $(if $(shell type gcc 2>/dev/null),gcc,cc) HOSTCXX ?= g++ -include $(TOPLEVEL)/Makefile.inc -include $(TOPLEVEL)/payloads/Makefile.inc -include $(TOPLEVEL)/util/testing/Makefile.inc +include $(TOPLEVEL)/Makefile.mk +include $(TOPLEVEL)/payloads/Makefile.mk +include $(TOPLEVEL)/util/testing/Makefile.mk +-include $(TOPLEVEL)/site-local/Makefile.mk -include $(TOPLEVEL)/site-local/Makefile.inc -include $(TOPLEVEL)/tests/Makefile.inc +include $(TOPLEVEL)/tests/Makefile.mk printall real-all: @echo "Error: Trying to build, but NOCOMPILE is set." >&2 @echo " Please file a bug with the following information:" @@ -198,7 +199,7 @@ export LANG LC_ALL TZ SOURCE_DATE_EPOCH ifneq ($(UNIT_TEST),1) -include toolchain.inc +include toolchain.mk endif strip_quotes = $(strip $(subst ",,$(subst \",,$(1)))) @@ -276,7 +277,7 @@ $(subst .$(1),,\ $(filter %.ads %.adb,$(2))))))))) -# Clean -y variables, include Makefile.inc +# Clean -y variables, include Makefile.mk & Makefile.inc # Add paths to files in X-y to X-srcs # Add subdirs-y to subdirs includemakefiles= \ @@ -295,10 +296,13 @@ # For each path in $(subdirs) call includemakefiles # Repeat until subdirs is empty +# TODO: Remove Makefile.inc support evaluate_subdirs= \ $(eval cursubdirs:=$(subdirs)) \ $(eval subdirs:=) \ $(foreach dir,$(cursubdirs), \ + $(eval $(call includemakefiles,$(dir)/Makefile.mk))) \ + $(foreach dir,$(cursubdirs), \ $(eval $(call includemakefiles,$(dir)/Makefile.inc))) \ $(if $(subdirs),$(eval $(call evaluate_subdirs))) @@ -306,11 +310,11 @@ subdirs:=$(TOPLEVEL) postinclude-hooks := -# Don't iterate through Makefile.incs under src/ when building tests +# Don't iterate through Makefiles under src/ when building tests ifneq ($(UNIT_TEST),1) $(eval $(call evaluate_subdirs)) else -include $(TOPLEVEL)/tests/Makefile.inc +include $(TOPLEVEL)/tests/Makefile.mk endif ifeq ($(FAILBUILD),1) diff --git a/Makefile.inc b/Makefile.mk similarity index 99% rename from Makefile.inc rename to Makefile.mk index 23f56a4..87c6bcb 100644 --- a/Makefile.inc +++ b/Makefile.mk @@ -1158,7 +1158,7 @@ endif # ifeq ($(CONFIG_ARCH_X86),y) -$(obj)/fmap.fmd: $(top)/Makefile.inc $(DEFAULT_FLASHMAP) $(obj)/config.h +$(obj)/fmap.fmd: $(top)/Makefile.mk $(DEFAULT_FLASHMAP) $(obj)/config.h sed -e "s,##ROM_BASE##,$(FMAP_ROM_ADDR)," \ -e "s,##ROM_SIZE##,$(FMAP_ROM_SIZE)," \ -e "s,##BIOS_BASE##,$(FMAP_BIOS_BASE)," \ diff --git a/payloads/Makefile.inc b/payloads/Makefile.mk similarity index 100% rename from payloads/Makefile.inc rename to payloads/Makefile.mk diff --git a/payloads/coreinfo/Makefile b/payloads/coreinfo/Makefile index 096e9c6..9655e24 100644 --- a/payloads/coreinfo/Makefile +++ b/payloads/coreinfo/Makefile @@ -70,7 +70,7 @@ $(shell mkdir -p $(objk)/lxdialog $(KCONFIG_SPLITCONFIG)) -include $(srck)/Makefile.inc +include $(srck)/Makefile.mk .PHONY: $(PHONY) prepare all real-all defaultbuild diff --git a/payloads/libpayload/Makefile b/payloads/libpayload/Makefile index 0104a11..212e67e 100644 --- a/payloads/libpayload/Makefile +++ b/payloads/libpayload/Makefile @@ -103,7 +103,7 @@ # This include must come _before_ the pattern rules below! # Order _does_ matter for pattern rules. -include $(srck)/Makefile.inc +include $(srck)/Makefile.mk include $(HAVE_DOTCONFIG) @@ -127,7 +127,7 @@ # 3. when make distclean is run # 4. when make help% or make clean% is run # 5. when make %-test or make %-tests or make %coverage-report is run -# Don't waste time on reading all Makefile.incs in these cases +# Don't waste time on reading all Makefiles in these cases ifeq ($(strip $(HAVE_DOTCONFIG)),) NOCOMPILE := 1 endif diff --git a/tests/Makefile.inc b/tests/Makefile.mk similarity index 100% rename from tests/Makefile.inc rename to tests/Makefile.mk diff --git a/toolchain.inc b/toolchain.mk similarity index 100% rename from toolchain.inc rename to toolchain.mk diff --git a/util/kconfig/Makefile.inc b/util/kconfig/Makefile.mk similarity index 100% rename from util/kconfig/Makefile.inc rename to util/kconfig/Makefile.mk diff --git a/util/lint/kconfig_lint b/util/lint/kconfig_lint index e67aebd..e64cf11 100755 --- a/util/lint/kconfig_lint +++ b/util/lint/kconfig_lint @@ -36,7 +36,7 @@ '^build/\|^coreboot-builds/\|^configs/\|^util/\|^\.git/\|^payloads\|^Documentation\|^3rdparty' . '\|' . # directories to exclude when searching for used symbols '\.config\|\.txt$\|\.tex$\|\.tags\|/kconfig.h\|\.fmd'; #files to exclude when looking for symbols -my $payload_files_to_check='payloads/Makefile.inc payloads/external/Makefile.inc'; +my $payload_files_to_check='payloads/Makefile.mk payloads/external/Makefile.inc'; my $config_file = ""; # name of config file to load symbol values from. my @wholeconfig; # document the entire kconfig structure my %loaded_files; # list of each Kconfig file loaded diff --git a/util/testing/Makefile.inc b/util/testing/Makefile.mk similarity index 100% rename from util/testing/Makefile.inc rename to util/testing/Makefile.mk -- To view, visit https://review.coreboot.org/c/coreboot/+/80063?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Idaf69c6871d0bc1ee5e2e53157b8631c55eb3db9 Gerrit-Change-Number: 80063 Gerrit-PatchSet: 5 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Jakub Czapiga <czapiga(a)google.com> Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-MessageType: merged

1 0

[NoOp] Change in coreboot[main]: soc/amd/*: Rename Makefiles from .inc to .mk
by Felix Singer (Code Review) 24 Jan '24

24 Jan '24

Attention is currently required from: Felix Held, Fred Reitberger, Jason Glenesk, Martin L Roth, Matt DeVillier, Maximilian Brune, Michael Niewöhner. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80071?usp=email ) Change subject: soc/amd/*: Rename Makefiles from .inc to .mk ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/80071?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ie449267fe4fdd75110f577e1b9f748cd06140950 Gerrit-Change-Number: 80071 Gerrit-PatchSet: 4 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Attention: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Wed, 24 Jan 2024 08:31:07 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[NoOp] Change in coreboot[main]: soc/amd/*: Rename Makefiles from .inc to .mk
by Felix Singer (Code Review) 24 Jan '24

24 Jan '24

Attention is currently required from: Felix Held, Felix Singer, Fred Reitberger, Jason Glenesk, Martin L Roth, Matt DeVillier, Maximilian Brune, Michael Niewöhner. Felix Singer has uploaded a new patch set (#4) to the change originally created by Martin L Roth. ( https://review.coreboot.org/c/coreboot/+/80071?usp=email ) The following approvals got outdated and were removed: Code-Review+2 by Felix Singer, Code-Review+2 by Maximilian Brune, Code-Review+2 by Michael Niewöhner, Verified+1 by build bot (Jenkins) The change is no longer submittable: Code-Review and Verified are unsatisfied now. Change subject: soc/amd/*: Rename Makefiles from .inc to .mk ...................................................................... soc/amd/*: Rename Makefiles from .inc to .mk The .inc suffix is confusing to various tools as it's not specific to Makefiles. This means that editors don't recognize the files, and don't open them with highlighting and any other specific editor functionality. This issue is also seen in the release notes generation script where Makefiles get renamed before running cloc. Signed-off-by: Martin Roth <gaumless(a)gmail.com> Change-Id: Ie449267fe4fdd75110f577e1b9f748cd06140950 --- R src/soc/amd/cezanne/Makefile.mk R src/soc/amd/cezanne/psp_verstage/Makefile.mk R src/soc/amd/common/Makefile.mk R src/soc/amd/common/block/Makefile.mk R src/soc/amd/common/block/acp/Makefile.mk R src/soc/amd/common/block/acpi/Makefile.mk R src/soc/amd/common/block/acpimmio/Makefile.mk R src/soc/amd/common/block/alink/Makefile.mk R src/soc/amd/common/block/aoac/Makefile.mk R src/soc/amd/common/block/apob/Makefile.mk R src/soc/amd/common/block/cpu/Makefile.mk R src/soc/amd/common/block/cpu/car/Makefile.mk R src/soc/amd/common/block/cpu/mca/Makefile.mk R src/soc/amd/common/block/cpu/noncar/Makefile.mk R src/soc/amd/common/block/cpu/smm/Makefile.mk R src/soc/amd/common/block/cpu/tsc/Makefile.mk R src/soc/amd/common/block/data_fabric/Makefile.mk R src/soc/amd/common/block/emmc/Makefile.mk R src/soc/amd/common/block/gpio/Makefile.mk R src/soc/amd/common/block/graphics/Makefile.mk R src/soc/amd/common/block/hda/Makefile.mk R src/soc/amd/common/block/i2c/Makefile.mk R src/soc/amd/common/block/iommu/Makefile.mk R src/soc/amd/common/block/lpc/Makefile.mk R src/soc/amd/common/block/pci/Makefile.mk R src/soc/amd/common/block/pm/Makefile.mk R src/soc/amd/common/block/psp/Makefile.mk R src/soc/amd/common/block/root_complex/Makefile.mk R src/soc/amd/common/block/sata/Makefile.mk R src/soc/amd/common/block/simnow/Makefile.mk R src/soc/amd/common/block/smbus/Makefile.mk R src/soc/amd/common/block/smi/Makefile.mk R src/soc/amd/common/block/smn/Makefile.mk R src/soc/amd/common/block/smu/Makefile.mk R src/soc/amd/common/block/spi/Makefile.mk R src/soc/amd/common/block/stb/Makefile.mk R src/soc/amd/common/block/uart/Makefile.mk R src/soc/amd/common/block/xhci/Makefile.mk R src/soc/amd/common/fsp/Makefile.mk R src/soc/amd/common/fsp/pci/Makefile.mk R src/soc/amd/common/pi/Makefile.mk R src/soc/amd/common/psp_verstage/Makefile.mk R src/soc/amd/common/vboot/Makefile.mk R src/soc/amd/genoa_poc/Makefile.mk R src/soc/amd/glinda/Makefile.mk R src/soc/amd/glinda/psp_verstage/Makefile.mk R src/soc/amd/mendocino/Makefile.mk R src/soc/amd/mendocino/psp_verstage/Makefile.mk R src/soc/amd/phoenix/Makefile.mk R src/soc/amd/phoenix/psp_verstage/Makefile.mk R src/soc/amd/picasso/Makefile.mk R src/soc/amd/picasso/psp_verstage/Makefile.mk R src/soc/amd/stoneyridge/Makefile.mk 53 files changed, 0 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/71/80071/4 -- To view, visit https://review.coreboot.org/c/coreboot/+/80071?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ie449267fe4fdd75110f577e1b9f748cd06140950 Gerrit-Change-Number: 80071 Gerrit-PatchSet: 4 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Attention: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[main]: soc/intel/cannonlake: Report correct latencies for C states
by Felix Singer (Code Review) 24 Jan '24

24 Jan '24

Felix Singer has submitted this change. ( https://review.coreboot.org/c/coreboot/+/80167?usp=email ) Change subject: soc/intel/cannonlake: Report correct latencies for C states ...................................................................... soc/intel/cannonlake: Report correct latencies for C states The C_STATE_LATENCY_FROM_LAT_REG() macro uses values that we also write into the respective MSRs in configure_c_states(). Match the indices to those used there. Change-Id: Ie01a53d6f06bc02a53d95e390e16e9963f4c65ee Signed-off-by: Nico Huber <nico.huber(a)secunet.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/80167 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Matt DeVillier <matt.devillier(a)gmail.com> --- M src/soc/intel/cannonlake/acpi.c 1 file changed, 9 insertions(+), 9 deletions(-) Approvals: build bot (Jenkins): Verified Matt DeVillier: Looks good to me, approved diff --git a/src/soc/intel/cannonlake/acpi.c b/src/soc/intel/cannonlake/acpi.c index 1545d19..1bd81c4 100644 --- a/src/soc/intel/cannonlake/acpi.c +++ b/src/soc/intel/cannonlake/acpi.c @@ -53,47 +53,47 @@ .resource = MWAIT_RES(0, 1), }, [C_STATE_C6_SHORT_LAT] = { - .latency = C_STATE_LATENCY_FROM_LAT_REG(0), + .latency = C_STATE_LATENCY_FROM_LAT_REG(1), .power = C6_POWER, .resource = MWAIT_RES(2, 0), }, [C_STATE_C6_LONG_LAT] = { - .latency = C_STATE_LATENCY_FROM_LAT_REG(0), + .latency = C_STATE_LATENCY_FROM_LAT_REG(2), .power = C6_POWER, .resource = MWAIT_RES(2, 1), }, [C_STATE_C7_SHORT_LAT] = { - .latency = C_STATE_LATENCY_FROM_LAT_REG(0), + .latency = C_STATE_LATENCY_FROM_LAT_REG(1), .power = C7_POWER, .resource = MWAIT_RES(3, 0), }, [C_STATE_C7_LONG_LAT] = { - .latency = C_STATE_LATENCY_FROM_LAT_REG(0), + .latency = C_STATE_LATENCY_FROM_LAT_REG(2), .power = C7_POWER, .resource = MWAIT_RES(3, 1), }, [C_STATE_C7S_SHORT_LAT] = { - .latency = C_STATE_LATENCY_FROM_LAT_REG(0), + .latency = C_STATE_LATENCY_FROM_LAT_REG(1), .power = C7_POWER, .resource = MWAIT_RES(3, 2), }, [C_STATE_C7S_LONG_LAT] = { - .latency = C_STATE_LATENCY_FROM_LAT_REG(0), + .latency = C_STATE_LATENCY_FROM_LAT_REG(2), .power = C7_POWER, .resource = MWAIT_RES(3, 3), }, [C_STATE_C8] = { - .latency = C_STATE_LATENCY_FROM_LAT_REG(0), + .latency = C_STATE_LATENCY_FROM_LAT_REG(3), .power = C8_POWER, .resource = MWAIT_RES(4, 0), }, [C_STATE_C9] = { - .latency = C_STATE_LATENCY_FROM_LAT_REG(0), + .latency = C_STATE_LATENCY_FROM_LAT_REG(4), .power = C9_POWER, .resource = MWAIT_RES(5, 0), }, [C_STATE_C10] = { - .latency = C_STATE_LATENCY_FROM_LAT_REG(0), + .latency = C_STATE_LATENCY_FROM_LAT_REG(5), .power = C10_POWER, .resource = MWAIT_RES(6, 0), }, -- To view, visit https://review.coreboot.org/c/coreboot/+/80167?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ie01a53d6f06bc02a53d95e390e16e9963f4c65ee Gerrit-Change-Number: 80167 Gerrit-PatchSet: 3 Gerrit-Owner: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[S] Change in coreboot[main]: Makefiles: Rename top-level Makefiles from .inc to .mk
by Felix Singer (Code Review) 24 Jan '24

24 Jan '24

Attention is currently required from: Arthur Heymans, Jakub Czapiga, Martin L Roth. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80063?usp=email ) Change subject: Makefiles: Rename top-level Makefiles from .inc to .mk ...................................................................... Patch Set 3: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/80063/comment/6f5a8c6d_727f9d16 : PS2, Line 10: This means that editors don't recognize the files, and don't : open them with highlighting and any other specific editor functionality. : > I updated the changes until CB:80129. […] Done -- To view, visit https://review.coreboot.org/c/coreboot/+/80063?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Idaf69c6871d0bc1ee5e2e53157b8631c55eb3db9 Gerrit-Change-Number: 80063 Gerrit-PatchSet: 3 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Jakub Czapiga <czapiga(a)google.com> Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Jakub Czapiga <czapiga(a)google.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Wed, 24 Jan 2024 07:56:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Comment-In-Reply-To: Martin L Roth <gaumless(a)gmail.com> Comment-In-Reply-To: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[master]: [TEST] to check upload to main branch
by Tony Huang (Code Review) 24 Jan '24

24 Jan '24

Tony Huang has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/80157?usp=email ) Change subject: [TEST] to check upload to main branch ...................................................................... [TEST] to check upload to main branch Do not merge. Change-Id: Idfc9ead23420911afaf8ec14095c2cc4ed7e6f19 Signed-off-by: Tony Huang <tony-huang(a)quanta.corp-partner.google.com> --- M src/mainboard/google/rex/variants/deku/overridetree.cb 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/57/80157/1 diff --git a/src/mainboard/google/rex/variants/deku/overridetree.cb b/src/mainboard/google/rex/variants/deku/overridetree.cb index 9c35338..1f9b07c 100644 --- a/src/mainboard/google/rex/variants/deku/overridetree.cb +++ b/src/mainboard/google/rex/variants/deku/overridetree.cb @@ -1,7 +1,7 @@ chip soc/intel/meteorlake register "usb2_ports[0]" = "USB2_PORT_TYPE_C(OC0)" # USB2_C2 - register "usb2_ports[1]" = "USB2_PORT_TYPE_C(OC0)" # USB2_C0 + register "usb2_ports[1]" = "USB2_PORT_TYPE_C(OC0)" # USB2_C00 register "usb2_ports[2]" = "USB2_PORT_TYPE_C(OC0)" # USB2_C1 register "usb2_ports[3]" = "USB2_PORT_MID(OC3)" # Type-A Port A0 register "usb2_ports[4]" = "USB2_PORT_TYPE_C(OC0)" # USB2_C3 -- To view, visit https://review.coreboot.org/c/coreboot/+/80157?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Idfc9ead23420911afaf8ec14095c2cc4ed7e6f19 Gerrit-Change-Number: 80157 Gerrit-PatchSet: 1 Gerrit-Owner: Tony Huang <tony-huang(a)quanta.corp-partner.google.com> Gerrit-MessageType: newchange

1 0

[S] Change in coreboot[main]: mb/google/brya/var/omniknight: Add WIFI SAR table
by Subrata Banik (Code Review) 24 Jan '24

24 Jan '24

Attention is currently required from: Derek Huang, Eric Lai, Jamie Chen, Kapil Porwal, Nick Vaccaro. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80152?usp=email ) Change subject: mb/google/brya/var/omniknight: Add WIFI SAR table ...................................................................... Patch Set 10: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/80152?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I70e79577612b3d5c4dc0f92211f87cbea0532d5d Gerrit-Change-Number: 80152 Gerrit-PatchSet: 10 Gerrit-Owner: Jamie Chen <jamie_chen(a)compal.corp-partner.google.com> Gerrit-Reviewer: Derek Huang <derekhuang(a)google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com> Gerrit-CC: Ian Feng <ian_feng(a)compal.corp-partner.google.com> Gerrit-CC: Van Chen <van_chen(a)compal.corp-partner.google.com> Gerrit-Attention: Eric Lai <ericllai(a)google.com> Gerrit-Attention: Jamie Chen <jamie_chen(a)compal.corp-partner.google.com> Gerrit-Attention: Derek Huang <derekhuang(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Comment-Date: Wed, 24 Jan 2024 07:22:38 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit January 2024