coreboot-gerrit January 2024

coreboot-gerrit@coreboot.org

1 participants
3044 discussions

[XS] Change in coreboot[main]: soc/intel: Rename Makefiles from .inc to .mk
by Felix Singer (Code Review) 24 Jan '24

24 Jan '24

Felix Singer has submitted this change. ( https://review.coreboot.org/c/coreboot/+/80073?usp=email ) Change subject: soc/intel: Rename Makefiles from .inc to .mk ...................................................................... soc/intel: Rename Makefiles from .inc to .mk The .inc suffix is confusing to various tools as it's not specific to Makefiles. This means that editors don't recognize the files, and don't open them with highlighting and any other specific editor functionality. This issue is also seen in the release notes generation script where Makefiles get renamed before running cloc. Signed-off-by: Martin Roth <gaumless(a)gmail.com> Change-Id: Ib479b93b7d0b2e790d0495b6a6b4b4298a515d9a Reviewed-on: https://review.coreboot.org/c/coreboot/+/80073 Reviewed-by: Arthur Heymans <arthur(a)aheymans.xyz> Reviewed-by: Michael Niewöhner <foss(a)mniewoehner.de> Reviewed-by: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Reviewed-by: Maximilian Brune <maximilian.brune(a)9elements.com> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- R src/soc/intel/Makefile.mk R src/soc/intel/alderlake/Makefile.mk R src/soc/intel/alderlake/romstage/Makefile.mk R src/soc/intel/apollolake/Makefile.mk R src/soc/intel/baytrail/Makefile.mk R src/soc/intel/baytrail/romstage/Makefile.mk R src/soc/intel/braswell/Makefile.mk R src/soc/intel/braswell/romstage/Makefile.mk R src/soc/intel/broadwell/Makefile.mk R src/soc/intel/broadwell/pch/Makefile.mk R src/soc/intel/cannonlake/Makefile.mk M src/soc/intel/cannonlake/cnl_memcfg_init.c R src/soc/intel/cannonlake/romstage/Makefile.mk R src/soc/intel/common/Makefile.mk R src/soc/intel/common/basecode/Makefile.mk R src/soc/intel/common/basecode/debug/Makefile.mk R src/soc/intel/common/basecode/ramtop/Makefile.mk R src/soc/intel/common/block/Makefile.mk R src/soc/intel/common/block/acpi/Makefile.mk R src/soc/intel/common/block/chip/Makefile.mk R src/soc/intel/common/block/cnvi/Makefile.mk R src/soc/intel/common/block/cpu/Makefile.mk R src/soc/intel/common/block/crashlog/Makefile.mk R src/soc/intel/common/block/cse/Makefile.mk R src/soc/intel/common/block/dsp/Makefile.mk R src/soc/intel/common/block/dtt/Makefile.mk R src/soc/intel/common/block/fast_spi/Makefile.mk R src/soc/intel/common/block/gpio/Makefile.mk R src/soc/intel/common/block/gpmr/Makefile.mk R src/soc/intel/common/block/graphics/Makefile.mk R src/soc/intel/common/block/gspi/Makefile.mk R src/soc/intel/common/block/hda/Makefile.mk R src/soc/intel/common/block/i2c/Makefile.mk R src/soc/intel/common/block/ioc/Makefile.mk R src/soc/intel/common/block/ipu/Makefile.mk R src/soc/intel/common/block/irq/Makefile.mk R src/soc/intel/common/block/itss/Makefile.mk R src/soc/intel/common/block/lpc/Makefile.mk R src/soc/intel/common/block/lpss/Makefile.mk R src/soc/intel/common/block/memory/Makefile.mk R src/soc/intel/common/block/oc_wdt/Makefile.mk R src/soc/intel/common/block/p2sb/Makefile.mk R src/soc/intel/common/block/pcie/Makefile.mk R src/soc/intel/common/block/pcie/rtd3/Makefile.mk R src/soc/intel/common/block/pcr/Makefile.mk R src/soc/intel/common/block/pmc/Makefile.mk R src/soc/intel/common/block/power_limit/Makefile.mk R src/soc/intel/common/block/rtc/Makefile.mk R src/soc/intel/common/block/sata/Makefile.mk R src/soc/intel/common/block/scs/Makefile.mk R src/soc/intel/common/block/sgx/Makefile.mk R src/soc/intel/common/block/smbus/Makefile.mk R src/soc/intel/common/block/smm/Makefile.mk R src/soc/intel/common/block/spi/Makefile.mk R src/soc/intel/common/block/sram/Makefile.mk R src/soc/intel/common/block/systemagent/Makefile.mk R src/soc/intel/common/block/tcss/Makefile.mk R src/soc/intel/common/block/thermal/Makefile.mk R src/soc/intel/common/block/timer/Makefile.mk R src/soc/intel/common/block/tracehub/Makefile.mk R src/soc/intel/common/block/uart/Makefile.mk R src/soc/intel/common/block/usb4/Makefile.mk R src/soc/intel/common/block/vtd/Makefile.mk R src/soc/intel/common/block/xdci/Makefile.mk R src/soc/intel/common/block/xhci/Makefile.mk R src/soc/intel/common/pch/Makefile.mk R src/soc/intel/common/pch/lockdown/Makefile.mk R src/soc/intel/denverton_ns/Makefile.mk R src/soc/intel/elkhartlake/Makefile.mk R src/soc/intel/elkhartlake/romstage/Makefile.mk R src/soc/intel/jasperlake/Makefile.mk R src/soc/intel/jasperlake/romstage/Makefile.mk R src/soc/intel/meteorlake/Makefile.mk R src/soc/intel/meteorlake/romstage/Makefile.mk R src/soc/intel/skylake/Makefile.mk R src/soc/intel/skylake/nhlt/Makefile.mk R src/soc/intel/skylake/romstage/Makefile.mk R src/soc/intel/tigerlake/Makefile.mk R src/soc/intel/tigerlake/romstage/Makefile.mk R src/soc/intel/xeon_sp/Makefile.mk R src/soc/intel/xeon_sp/cpx/Makefile.mk R src/soc/intel/xeon_sp/ebg/Makefile.mk R src/soc/intel/xeon_sp/lbg/Makefile.mk R src/soc/intel/xeon_sp/ras/Makefile.mk R src/soc/intel/xeon_sp/skx/Makefile.mk R src/soc/intel/xeon_sp/spr/Makefile.mk 86 files changed, 1 insertion(+), 1 deletion(-) Approvals: Felix Singer: Looks good to me, approved Michael Niewöhner: Looks good to me, approved Maximilian Brune: Looks good to me, approved build bot (Jenkins): Verified Arthur Heymans: Looks good to me, approved diff --git a/src/soc/intel/Makefile.inc b/src/soc/intel/Makefile.mk similarity index 100% rename from src/soc/intel/Makefile.inc rename to src/soc/intel/Makefile.mk diff --git a/src/soc/intel/alderlake/Makefile.inc b/src/soc/intel/alderlake/Makefile.mk similarity index 100% rename from src/soc/intel/alderlake/Makefile.inc rename to src/soc/intel/alderlake/Makefile.mk diff --git a/src/soc/intel/alderlake/romstage/Makefile.inc b/src/soc/intel/alderlake/romstage/Makefile.mk similarity index 100% rename from src/soc/intel/alderlake/romstage/Makefile.inc rename to src/soc/intel/alderlake/romstage/Makefile.mk diff --git a/src/soc/intel/apollolake/Makefile.inc b/src/soc/intel/apollolake/Makefile.mk similarity index 100% rename from src/soc/intel/apollolake/Makefile.inc rename to src/soc/intel/apollolake/Makefile.mk diff --git a/src/soc/intel/baytrail/Makefile.inc b/src/soc/intel/baytrail/Makefile.mk similarity index 100% rename from src/soc/intel/baytrail/Makefile.inc rename to src/soc/intel/baytrail/Makefile.mk diff --git a/src/soc/intel/baytrail/romstage/Makefile.inc b/src/soc/intel/baytrail/romstage/Makefile.mk similarity index 100% rename from src/soc/intel/baytrail/romstage/Makefile.inc rename to src/soc/intel/baytrail/romstage/Makefile.mk diff --git a/src/soc/intel/braswell/Makefile.inc b/src/soc/intel/braswell/Makefile.mk similarity index 100% rename from src/soc/intel/braswell/Makefile.inc rename to src/soc/intel/braswell/Makefile.mk diff --git a/src/soc/intel/braswell/romstage/Makefile.inc b/src/soc/intel/braswell/romstage/Makefile.mk similarity index 100% rename from src/soc/intel/braswell/romstage/Makefile.inc rename to src/soc/intel/braswell/romstage/Makefile.mk diff --git a/src/soc/intel/broadwell/Makefile.inc b/src/soc/intel/broadwell/Makefile.mk similarity index 100% rename from src/soc/intel/broadwell/Makefile.inc rename to src/soc/intel/broadwell/Makefile.mk diff --git a/src/soc/intel/broadwell/pch/Makefile.inc b/src/soc/intel/broadwell/pch/Makefile.mk similarity index 100% rename from src/soc/intel/broadwell/pch/Makefile.inc rename to src/soc/intel/broadwell/pch/Makefile.mk diff --git a/src/soc/intel/cannonlake/Makefile.inc b/src/soc/intel/cannonlake/Makefile.mk similarity index 100% rename from src/soc/intel/cannonlake/Makefile.inc rename to src/soc/intel/cannonlake/Makefile.mk diff --git a/src/soc/intel/cannonlake/cnl_memcfg_init.c b/src/soc/intel/cannonlake/cnl_memcfg_init.c index 448e56c..db488ee 100644 --- a/src/soc/intel/cannonlake/cnl_memcfg_init.c +++ b/src/soc/intel/cannonlake/cnl_memcfg_init.c @@ -74,7 +74,7 @@ /* * Initialize default memory settings using the spd file specified by * spd_index. The spd_index is an index into the SPD_SOURCES array defined - * in spd/Makefile.inc. + * in spd/Makefile.mk. */ static void meminit_cbfs_spd_index(FSP_M_CONFIG *mem_cfg, int spd_index, uint8_t mem_slot) diff --git a/src/soc/intel/cannonlake/romstage/Makefile.inc b/src/soc/intel/cannonlake/romstage/Makefile.mk similarity index 100% rename from src/soc/intel/cannonlake/romstage/Makefile.inc rename to src/soc/intel/cannonlake/romstage/Makefile.mk diff --git a/src/soc/intel/common/Makefile.inc b/src/soc/intel/common/Makefile.mk similarity index 100% rename from src/soc/intel/common/Makefile.inc rename to src/soc/intel/common/Makefile.mk diff --git a/src/soc/intel/common/basecode/Makefile.inc b/src/soc/intel/common/basecode/Makefile.mk similarity index 100% rename from src/soc/intel/common/basecode/Makefile.inc rename to src/soc/intel/common/basecode/Makefile.mk diff --git a/src/soc/intel/common/basecode/debug/Makefile.inc b/src/soc/intel/common/basecode/debug/Makefile.mk similarity index 100% rename from src/soc/intel/common/basecode/debug/Makefile.inc rename to src/soc/intel/common/basecode/debug/Makefile.mk diff --git a/src/soc/intel/common/basecode/ramtop/Makefile.inc b/src/soc/intel/common/basecode/ramtop/Makefile.mk similarity index 100% rename from src/soc/intel/common/basecode/ramtop/Makefile.inc rename to src/soc/intel/common/basecode/ramtop/Makefile.mk diff --git a/src/soc/intel/common/block/Makefile.inc b/src/soc/intel/common/block/Makefile.mk similarity index 100% rename from src/soc/intel/common/block/Makefile.inc rename to src/soc/intel/common/block/Makefile.mk diff --git a/src/soc/intel/common/block/acpi/Makefile.inc b/src/soc/intel/common/block/acpi/Makefile.mk similarity index 100% rename from src/soc/intel/common/block/acpi/Makefile.inc rename to src/soc/intel/common/block/acpi/Makefile.mk diff --git a/src/soc/intel/common/block/chip/Makefile.inc b/src/soc/intel/common/block/chip/Makefile.mk similarity index 100% rename from src/soc/intel/common/block/chip/Makefile.inc rename to src/soc/intel/common/block/chip/Makefile.mk diff --git a/src/soc/intel/common/block/cnvi/Makefile.inc b/src/soc/intel/common/block/cnvi/Makefile.mk similarity index 100% rename from src/soc/intel/common/block/cnvi/Makefile.inc rename to src/soc/intel/common/block/cnvi/Makefile.mk diff --git a/src/soc/intel/common/block/cpu/Makefile.inc b/src/soc/intel/common/block/cpu/Makefile.mk similarity index 100% rename from src/soc/intel/common/block/cpu/Makefile.inc rename to src/soc/intel/common/block/cpu/Makefile.mk diff --git a/src/soc/intel/common/block/crashlog/Makefile.inc b/src/soc/intel/common/block/crashlog/Makefile.mk similarity index 100% rename from src/soc/intel/common/block/crashlog/Makefile.inc rename to src/soc/intel/common/block/crashlog/Makefile.mk diff --git a/src/soc/intel/common/block/cse/Makefile.inc b/src/soc/intel/common/block/cse/Makefile.mk similarity index 100% rename from src/soc/intel/common/block/cse/Makefile.inc rename to src/soc/intel/common/block/cse/Makefile.mk diff --git a/src/soc/intel/common/block/dsp/Makefile.inc b/src/soc/intel/common/block/dsp/Makefile.mk similarity index 100% rename from src/soc/intel/common/block/dsp/Makefile.inc rename to src/soc/intel/common/block/dsp/Makefile.mk diff --git a/src/soc/intel/common/block/dtt/Makefile.inc b/src/soc/intel/common/block/dtt/Makefile.mk similarity index 100% rename from src/soc/intel/common/block/dtt/Makefile.inc rename to src/soc/intel/common/block/dtt/Makefile.mk diff --git a/src/soc/intel/common/block/fast_spi/Makefile.inc b/src/soc/intel/common/block/fast_spi/Makefile.mk similarity index 100% rename from src/soc/intel/common/block/fast_spi/Makefile.inc rename to src/soc/intel/common/block/fast_spi/Makefile.mk diff --git a/src/soc/intel/common/block/gpio/Makefile.inc b/src/soc/intel/common/block/gpio/Makefile.mk similarity index 100% rename from src/soc/intel/common/block/gpio/Makefile.inc rename to src/soc/intel/common/block/gpio/Makefile.mk diff --git a/src/soc/intel/common/block/gpmr/Makefile.inc b/src/soc/intel/common/block/gpmr/Makefile.mk similarity index 100% rename from src/soc/intel/common/block/gpmr/Makefile.inc rename to src/soc/intel/common/block/gpmr/Makefile.mk diff --git a/src/soc/intel/common/block/graphics/Makefile.inc b/src/soc/intel/common/block/graphics/Makefile.mk similarity index 100% rename from src/soc/intel/common/block/graphics/Makefile.inc rename to src/soc/intel/common/block/graphics/Makefile.mk diff --git a/src/soc/intel/common/block/gspi/Makefile.inc b/src/soc/intel/common/block/gspi/Makefile.mk similarity index 100% rename from src/soc/intel/common/block/gspi/Makefile.inc rename to src/soc/intel/common/block/gspi/Makefile.mk diff --git a/src/soc/intel/common/block/hda/Makefile.inc b/src/soc/intel/common/block/hda/Makefile.mk similarity index 100% rename from src/soc/intel/common/block/hda/Makefile.inc rename to src/soc/intel/common/block/hda/Makefile.mk diff --git a/src/soc/intel/common/block/i2c/Makefile.inc b/src/soc/intel/common/block/i2c/Makefile.mk similarity index 100% rename from src/soc/intel/common/block/i2c/Makefile.inc rename to src/soc/intel/common/block/i2c/Makefile.mk diff --git a/src/soc/intel/common/block/ioc/Makefile.inc b/src/soc/intel/common/block/ioc/Makefile.mk similarity index 100% rename from src/soc/intel/common/block/ioc/Makefile.inc rename to src/soc/intel/common/block/ioc/Makefile.mk diff --git a/src/soc/intel/common/block/ipu/Makefile.inc b/src/soc/intel/common/block/ipu/Makefile.mk similarity index 100% rename from src/soc/intel/common/block/ipu/Makefile.inc rename to src/soc/intel/common/block/ipu/Makefile.mk diff --git a/src/soc/intel/common/block/irq/Makefile.inc b/src/soc/intel/common/block/irq/Makefile.mk similarity index 100% rename from src/soc/intel/common/block/irq/Makefile.inc rename to src/soc/intel/common/block/irq/Makefile.mk diff --git a/src/soc/intel/common/block/itss/Makefile.inc b/src/soc/intel/common/block/itss/Makefile.mk similarity index 100% rename from src/soc/intel/common/block/itss/Makefile.inc rename to src/soc/intel/common/block/itss/Makefile.mk diff --git a/src/soc/intel/common/block/lpc/Makefile.inc b/src/soc/intel/common/block/lpc/Makefile.mk similarity index 100% rename from src/soc/intel/common/block/lpc/Makefile.inc rename to src/soc/intel/common/block/lpc/Makefile.mk diff --git a/src/soc/intel/common/block/lpss/Makefile.inc b/src/soc/intel/common/block/lpss/Makefile.mk similarity index 100% rename from src/soc/intel/common/block/lpss/Makefile.inc rename to src/soc/intel/common/block/lpss/Makefile.mk diff --git a/src/soc/intel/common/block/memory/Makefile.inc b/src/soc/intel/common/block/memory/Makefile.mk similarity index 100% rename from src/soc/intel/common/block/memory/Makefile.inc rename to src/soc/intel/common/block/memory/Makefile.mk diff --git a/src/soc/intel/common/block/oc_wdt/Makefile.inc b/src/soc/intel/common/block/oc_wdt/Makefile.mk similarity index 100% rename from src/soc/intel/common/block/oc_wdt/Makefile.inc rename to src/soc/intel/common/block/oc_wdt/Makefile.mk diff --git a/src/soc/intel/common/block/p2sb/Makefile.inc b/src/soc/intel/common/block/p2sb/Makefile.mk similarity index 100% rename from src/soc/intel/common/block/p2sb/Makefile.inc rename to src/soc/intel/common/block/p2sb/Makefile.mk diff --git a/src/soc/intel/common/block/pcie/Makefile.inc b/src/soc/intel/common/block/pcie/Makefile.mk similarity index 100% rename from src/soc/intel/common/block/pcie/Makefile.inc rename to src/soc/intel/common/block/pcie/Makefile.mk diff --git a/src/soc/intel/common/block/pcie/rtd3/Makefile.inc b/src/soc/intel/common/block/pcie/rtd3/Makefile.mk similarity index 100% rename from src/soc/intel/common/block/pcie/rtd3/Makefile.inc rename to src/soc/intel/common/block/pcie/rtd3/Makefile.mk diff --git a/src/soc/intel/common/block/pcr/Makefile.inc b/src/soc/intel/common/block/pcr/Makefile.mk similarity index 100% rename from src/soc/intel/common/block/pcr/Makefile.inc rename to src/soc/intel/common/block/pcr/Makefile.mk diff --git a/src/soc/intel/common/block/pmc/Makefile.inc b/src/soc/intel/common/block/pmc/Makefile.mk similarity index 100% rename from src/soc/intel/common/block/pmc/Makefile.inc rename to src/soc/intel/common/block/pmc/Makefile.mk diff --git a/src/soc/intel/common/block/power_limit/Makefile.inc b/src/soc/intel/common/block/power_limit/Makefile.mk similarity index 100% rename from src/soc/intel/common/block/power_limit/Makefile.inc rename to src/soc/intel/common/block/power_limit/Makefile.mk diff --git a/src/soc/intel/common/block/rtc/Makefile.inc b/src/soc/intel/common/block/rtc/Makefile.mk similarity index 100% rename from src/soc/intel/common/block/rtc/Makefile.inc rename to src/soc/intel/common/block/rtc/Makefile.mk diff --git a/src/soc/intel/common/block/sata/Makefile.inc b/src/soc/intel/common/block/sata/Makefile.mk similarity index 100% rename from src/soc/intel/common/block/sata/Makefile.inc rename to src/soc/intel/common/block/sata/Makefile.mk diff --git a/src/soc/intel/common/block/scs/Makefile.inc b/src/soc/intel/common/block/scs/Makefile.mk similarity index 100% rename from src/soc/intel/common/block/scs/Makefile.inc rename to src/soc/intel/common/block/scs/Makefile.mk diff --git a/src/soc/intel/common/block/sgx/Makefile.inc b/src/soc/intel/common/block/sgx/Makefile.mk similarity index 100% rename from src/soc/intel/common/block/sgx/Makefile.inc rename to src/soc/intel/common/block/sgx/Makefile.mk diff --git a/src/soc/intel/common/block/smbus/Makefile.inc b/src/soc/intel/common/block/smbus/Makefile.mk similarity index 100% rename from src/soc/intel/common/block/smbus/Makefile.inc rename to src/soc/intel/common/block/smbus/Makefile.mk diff --git a/src/soc/intel/common/block/smm/Makefile.inc b/src/soc/intel/common/block/smm/Makefile.mk similarity index 100% rename from src/soc/intel/common/block/smm/Makefile.inc rename to src/soc/intel/common/block/smm/Makefile.mk diff --git a/src/soc/intel/common/block/spi/Makefile.inc b/src/soc/intel/common/block/spi/Makefile.mk similarity index 100% rename from src/soc/intel/common/block/spi/Makefile.inc rename to src/soc/intel/common/block/spi/Makefile.mk diff --git a/src/soc/intel/common/block/sram/Makefile.inc b/src/soc/intel/common/block/sram/Makefile.mk similarity index 100% rename from src/soc/intel/common/block/sram/Makefile.inc rename to src/soc/intel/common/block/sram/Makefile.mk diff --git a/src/soc/intel/common/block/systemagent/Makefile.inc b/src/soc/intel/common/block/systemagent/Makefile.mk similarity index 100% rename from src/soc/intel/common/block/systemagent/Makefile.inc rename to src/soc/intel/common/block/systemagent/Makefile.mk diff --git a/src/soc/intel/common/block/tcss/Makefile.inc b/src/soc/intel/common/block/tcss/Makefile.mk similarity index 100% rename from src/soc/intel/common/block/tcss/Makefile.inc rename to src/soc/intel/common/block/tcss/Makefile.mk diff --git a/src/soc/intel/common/block/thermal/Makefile.inc b/src/soc/intel/common/block/thermal/Makefile.mk similarity index 100% rename from src/soc/intel/common/block/thermal/Makefile.inc rename to src/soc/intel/common/block/thermal/Makefile.mk diff --git a/src/soc/intel/common/block/timer/Makefile.inc b/src/soc/intel/common/block/timer/Makefile.mk similarity index 100% rename from src/soc/intel/common/block/timer/Makefile.inc rename to src/soc/intel/common/block/timer/Makefile.mk diff --git a/src/soc/intel/common/block/tracehub/Makefile.inc b/src/soc/intel/common/block/tracehub/Makefile.mk similarity index 100% rename from src/soc/intel/common/block/tracehub/Makefile.inc rename to src/soc/intel/common/block/tracehub/Makefile.mk diff --git a/src/soc/intel/common/block/uart/Makefile.inc b/src/soc/intel/common/block/uart/Makefile.mk similarity index 100% rename from src/soc/intel/common/block/uart/Makefile.inc rename to src/soc/intel/common/block/uart/Makefile.mk diff --git a/src/soc/intel/common/block/usb4/Makefile.inc b/src/soc/intel/common/block/usb4/Makefile.mk similarity index 100% rename from src/soc/intel/common/block/usb4/Makefile.inc rename to src/soc/intel/common/block/usb4/Makefile.mk diff --git a/src/soc/intel/common/block/vtd/Makefile.inc b/src/soc/intel/common/block/vtd/Makefile.mk similarity index 100% rename from src/soc/intel/common/block/vtd/Makefile.inc rename to src/soc/intel/common/block/vtd/Makefile.mk diff --git a/src/soc/intel/common/block/xdci/Makefile.inc b/src/soc/intel/common/block/xdci/Makefile.mk similarity index 100% rename from src/soc/intel/common/block/xdci/Makefile.inc rename to src/soc/intel/common/block/xdci/Makefile.mk diff --git a/src/soc/intel/common/block/xhci/Makefile.inc b/src/soc/intel/common/block/xhci/Makefile.mk similarity index 100% rename from src/soc/intel/common/block/xhci/Makefile.inc rename to src/soc/intel/common/block/xhci/Makefile.mk diff --git a/src/soc/intel/common/pch/Makefile.inc b/src/soc/intel/common/pch/Makefile.mk similarity index 100% rename from src/soc/intel/common/pch/Makefile.inc rename to src/soc/intel/common/pch/Makefile.mk diff --git a/src/soc/intel/common/pch/lockdown/Makefile.inc b/src/soc/intel/common/pch/lockdown/Makefile.mk similarity index 100% rename from src/soc/intel/common/pch/lockdown/Makefile.inc rename to src/soc/intel/common/pch/lockdown/Makefile.mk diff --git a/src/soc/intel/denverton_ns/Makefile.inc b/src/soc/intel/denverton_ns/Makefile.mk similarity index 100% rename from src/soc/intel/denverton_ns/Makefile.inc rename to src/soc/intel/denverton_ns/Makefile.mk diff --git a/src/soc/intel/elkhartlake/Makefile.inc b/src/soc/intel/elkhartlake/Makefile.mk similarity index 100% rename from src/soc/intel/elkhartlake/Makefile.inc rename to src/soc/intel/elkhartlake/Makefile.mk diff --git a/src/soc/intel/elkhartlake/romstage/Makefile.inc b/src/soc/intel/elkhartlake/romstage/Makefile.mk similarity index 100% rename from src/soc/intel/elkhartlake/romstage/Makefile.inc rename to src/soc/intel/elkhartlake/romstage/Makefile.mk diff --git a/src/soc/intel/jasperlake/Makefile.inc b/src/soc/intel/jasperlake/Makefile.mk similarity index 100% rename from src/soc/intel/jasperlake/Makefile.inc rename to src/soc/intel/jasperlake/Makefile.mk diff --git a/src/soc/intel/jasperlake/romstage/Makefile.inc b/src/soc/intel/jasperlake/romstage/Makefile.mk similarity index 100% rename from src/soc/intel/jasperlake/romstage/Makefile.inc rename to src/soc/intel/jasperlake/romstage/Makefile.mk diff --git a/src/soc/intel/meteorlake/Makefile.inc b/src/soc/intel/meteorlake/Makefile.mk similarity index 100% rename from src/soc/intel/meteorlake/Makefile.inc rename to src/soc/intel/meteorlake/Makefile.mk diff --git a/src/soc/intel/meteorlake/romstage/Makefile.inc b/src/soc/intel/meteorlake/romstage/Makefile.mk similarity index 100% rename from src/soc/intel/meteorlake/romstage/Makefile.inc rename to src/soc/intel/meteorlake/romstage/Makefile.mk diff --git a/src/soc/intel/skylake/Makefile.inc b/src/soc/intel/skylake/Makefile.mk similarity index 100% rename from src/soc/intel/skylake/Makefile.inc rename to src/soc/intel/skylake/Makefile.mk diff --git a/src/soc/intel/skylake/nhlt/Makefile.inc b/src/soc/intel/skylake/nhlt/Makefile.mk similarity index 100% rename from src/soc/intel/skylake/nhlt/Makefile.inc rename to src/soc/intel/skylake/nhlt/Makefile.mk diff --git a/src/soc/intel/skylake/romstage/Makefile.inc b/src/soc/intel/skylake/romstage/Makefile.mk similarity index 100% rename from src/soc/intel/skylake/romstage/Makefile.inc rename to src/soc/intel/skylake/romstage/Makefile.mk diff --git a/src/soc/intel/tigerlake/Makefile.inc b/src/soc/intel/tigerlake/Makefile.mk similarity index 100% rename from src/soc/intel/tigerlake/Makefile.inc rename to src/soc/intel/tigerlake/Makefile.mk diff --git a/src/soc/intel/tigerlake/romstage/Makefile.inc b/src/soc/intel/tigerlake/romstage/Makefile.mk similarity index 100% rename from src/soc/intel/tigerlake/romstage/Makefile.inc rename to src/soc/intel/tigerlake/romstage/Makefile.mk diff --git a/src/soc/intel/xeon_sp/Makefile.inc b/src/soc/intel/xeon_sp/Makefile.mk similarity index 100% rename from src/soc/intel/xeon_sp/Makefile.inc rename to src/soc/intel/xeon_sp/Makefile.mk diff --git a/src/soc/intel/xeon_sp/cpx/Makefile.inc b/src/soc/intel/xeon_sp/cpx/Makefile.mk similarity index 100% rename from src/soc/intel/xeon_sp/cpx/Makefile.inc rename to src/soc/intel/xeon_sp/cpx/Makefile.mk diff --git a/src/soc/intel/xeon_sp/ebg/Makefile.inc b/src/soc/intel/xeon_sp/ebg/Makefile.mk similarity index 100% rename from src/soc/intel/xeon_sp/ebg/Makefile.inc rename to src/soc/intel/xeon_sp/ebg/Makefile.mk diff --git a/src/soc/intel/xeon_sp/lbg/Makefile.inc b/src/soc/intel/xeon_sp/lbg/Makefile.mk similarity index 100% rename from src/soc/intel/xeon_sp/lbg/Makefile.inc rename to src/soc/intel/xeon_sp/lbg/Makefile.mk diff --git a/src/soc/intel/xeon_sp/ras/Makefile.inc b/src/soc/intel/xeon_sp/ras/Makefile.mk similarity index 100% rename from src/soc/intel/xeon_sp/ras/Makefile.inc rename to src/soc/intel/xeon_sp/ras/Makefile.mk diff --git a/src/soc/intel/xeon_sp/skx/Makefile.inc b/src/soc/intel/xeon_sp/skx/Makefile.mk similarity index 100% rename from src/soc/intel/xeon_sp/skx/Makefile.inc rename to src/soc/intel/xeon_sp/skx/Makefile.mk diff --git a/src/soc/intel/xeon_sp/spr/Makefile.inc b/src/soc/intel/xeon_sp/spr/Makefile.mk similarity index 100% rename from src/soc/intel/xeon_sp/spr/Makefile.inc rename to src/soc/intel/xeon_sp/spr/Makefile.mk -- To view, visit https://review.coreboot.org/c/coreboot/+/80073?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ib479b93b7d0b2e790d0495b6a6b4b4298a515d9a Gerrit-Change-Number: 80073 Gerrit-PatchSet: 4 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Jakub Czapiga <czapiga(a)google.com> Gerrit-Reviewer: Jeff Daly <jeffd(a)silicom-usa.com> Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Jonathan Zhang <jon.zhixiong.zhang(a)gmail.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun <tstuli(a)gmail.com> Gerrit-Reviewer: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Reviewer: Vanessa Eusebio <vanessa.f.eusebio(a)intel.com> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[NoOp] Change in coreboot[main]: soc/amd/*: Rename Makefiles from .inc to .mk
by Felix Singer (Code Review) 24 Jan '24

24 Jan '24

Felix Singer has submitted this change. ( https://review.coreboot.org/c/coreboot/+/80071?usp=email ) Change subject: soc/amd/*: Rename Makefiles from .inc to .mk ...................................................................... soc/amd/*: Rename Makefiles from .inc to .mk The .inc suffix is confusing to various tools as it's not specific to Makefiles. This means that editors don't recognize the files, and don't open them with highlighting and any other specific editor functionality. This issue is also seen in the release notes generation script where Makefiles get renamed before running cloc. Signed-off-by: Martin Roth <gaumless(a)gmail.com> Change-Id: Ie449267fe4fdd75110f577e1b9f748cd06140950 Reviewed-on: https://review.coreboot.org/c/coreboot/+/80071 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Arthur Heymans <arthur(a)aheymans.xyz> Reviewed-by: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> --- R src/soc/amd/cezanne/Makefile.mk R src/soc/amd/cezanne/psp_verstage/Makefile.mk R src/soc/amd/common/Makefile.mk R src/soc/amd/common/block/Makefile.mk R src/soc/amd/common/block/acp/Makefile.mk R src/soc/amd/common/block/acpi/Makefile.mk R src/soc/amd/common/block/acpimmio/Makefile.mk R src/soc/amd/common/block/alink/Makefile.mk R src/soc/amd/common/block/aoac/Makefile.mk R src/soc/amd/common/block/apob/Makefile.mk R src/soc/amd/common/block/cpu/Makefile.mk R src/soc/amd/common/block/cpu/car/Makefile.mk R src/soc/amd/common/block/cpu/mca/Makefile.mk R src/soc/amd/common/block/cpu/noncar/Makefile.mk R src/soc/amd/common/block/cpu/smm/Makefile.mk R src/soc/amd/common/block/cpu/tsc/Makefile.mk R src/soc/amd/common/block/data_fabric/Makefile.mk R src/soc/amd/common/block/emmc/Makefile.mk R src/soc/amd/common/block/gpio/Makefile.mk R src/soc/amd/common/block/graphics/Makefile.mk R src/soc/amd/common/block/hda/Makefile.mk R src/soc/amd/common/block/i2c/Makefile.mk R src/soc/amd/common/block/iommu/Makefile.mk R src/soc/amd/common/block/lpc/Makefile.mk R src/soc/amd/common/block/pci/Makefile.mk R src/soc/amd/common/block/pm/Makefile.mk R src/soc/amd/common/block/psp/Makefile.mk R src/soc/amd/common/block/root_complex/Makefile.mk R src/soc/amd/common/block/sata/Makefile.mk R src/soc/amd/common/block/simnow/Makefile.mk R src/soc/amd/common/block/smbus/Makefile.mk R src/soc/amd/common/block/smi/Makefile.mk R src/soc/amd/common/block/smn/Makefile.mk R src/soc/amd/common/block/smu/Makefile.mk R src/soc/amd/common/block/spi/Makefile.mk R src/soc/amd/common/block/stb/Makefile.mk R src/soc/amd/common/block/uart/Makefile.mk R src/soc/amd/common/block/xhci/Makefile.mk R src/soc/amd/common/fsp/Makefile.mk R src/soc/amd/common/fsp/pci/Makefile.mk R src/soc/amd/common/pi/Makefile.mk R src/soc/amd/common/psp_verstage/Makefile.mk R src/soc/amd/common/vboot/Makefile.mk R src/soc/amd/genoa_poc/Makefile.mk R src/soc/amd/glinda/Makefile.mk R src/soc/amd/glinda/psp_verstage/Makefile.mk R src/soc/amd/mendocino/Makefile.mk R src/soc/amd/mendocino/psp_verstage/Makefile.mk R src/soc/amd/phoenix/Makefile.mk R src/soc/amd/phoenix/psp_verstage/Makefile.mk R src/soc/amd/picasso/Makefile.mk R src/soc/amd/picasso/psp_verstage/Makefile.mk R src/soc/amd/stoneyridge/Makefile.mk 53 files changed, 0 insertions(+), 0 deletions(-) Approvals: build bot (Jenkins): Verified Arthur Heymans: Looks good to me, approved Felix Singer: Looks good to me, approved diff --git a/src/soc/amd/cezanne/Makefile.inc b/src/soc/amd/cezanne/Makefile.mk similarity index 100% rename from src/soc/amd/cezanne/Makefile.inc rename to src/soc/amd/cezanne/Makefile.mk diff --git a/src/soc/amd/cezanne/psp_verstage/Makefile.inc b/src/soc/amd/cezanne/psp_verstage/Makefile.mk similarity index 100% rename from src/soc/amd/cezanne/psp_verstage/Makefile.inc rename to src/soc/amd/cezanne/psp_verstage/Makefile.mk diff --git a/src/soc/amd/common/Makefile.inc b/src/soc/amd/common/Makefile.mk similarity index 100% rename from src/soc/amd/common/Makefile.inc rename to src/soc/amd/common/Makefile.mk diff --git a/src/soc/amd/common/block/Makefile.inc b/src/soc/amd/common/block/Makefile.mk similarity index 100% rename from src/soc/amd/common/block/Makefile.inc rename to src/soc/amd/common/block/Makefile.mk diff --git a/src/soc/amd/common/block/acp/Makefile.inc b/src/soc/amd/common/block/acp/Makefile.mk similarity index 100% rename from src/soc/amd/common/block/acp/Makefile.inc rename to src/soc/amd/common/block/acp/Makefile.mk diff --git a/src/soc/amd/common/block/acpi/Makefile.inc b/src/soc/amd/common/block/acpi/Makefile.mk similarity index 100% rename from src/soc/amd/common/block/acpi/Makefile.inc rename to src/soc/amd/common/block/acpi/Makefile.mk diff --git a/src/soc/amd/common/block/acpimmio/Makefile.inc b/src/soc/amd/common/block/acpimmio/Makefile.mk similarity index 100% rename from src/soc/amd/common/block/acpimmio/Makefile.inc rename to src/soc/amd/common/block/acpimmio/Makefile.mk diff --git a/src/soc/amd/common/block/alink/Makefile.inc b/src/soc/amd/common/block/alink/Makefile.mk similarity index 100% rename from src/soc/amd/common/block/alink/Makefile.inc rename to src/soc/amd/common/block/alink/Makefile.mk diff --git a/src/soc/amd/common/block/aoac/Makefile.inc b/src/soc/amd/common/block/aoac/Makefile.mk similarity index 100% rename from src/soc/amd/common/block/aoac/Makefile.inc rename to src/soc/amd/common/block/aoac/Makefile.mk diff --git a/src/soc/amd/common/block/apob/Makefile.inc b/src/soc/amd/common/block/apob/Makefile.mk similarity index 100% rename from src/soc/amd/common/block/apob/Makefile.inc rename to src/soc/amd/common/block/apob/Makefile.mk diff --git a/src/soc/amd/common/block/cpu/Makefile.inc b/src/soc/amd/common/block/cpu/Makefile.mk similarity index 100% rename from src/soc/amd/common/block/cpu/Makefile.inc rename to src/soc/amd/common/block/cpu/Makefile.mk diff --git a/src/soc/amd/common/block/cpu/car/Makefile.inc b/src/soc/amd/common/block/cpu/car/Makefile.mk similarity index 100% rename from src/soc/amd/common/block/cpu/car/Makefile.inc rename to src/soc/amd/common/block/cpu/car/Makefile.mk diff --git a/src/soc/amd/common/block/cpu/mca/Makefile.inc b/src/soc/amd/common/block/cpu/mca/Makefile.mk similarity index 100% rename from src/soc/amd/common/block/cpu/mca/Makefile.inc rename to src/soc/amd/common/block/cpu/mca/Makefile.mk diff --git a/src/soc/amd/common/block/cpu/noncar/Makefile.inc b/src/soc/amd/common/block/cpu/noncar/Makefile.mk similarity index 100% rename from src/soc/amd/common/block/cpu/noncar/Makefile.inc rename to src/soc/amd/common/block/cpu/noncar/Makefile.mk diff --git a/src/soc/amd/common/block/cpu/smm/Makefile.inc b/src/soc/amd/common/block/cpu/smm/Makefile.mk similarity index 100% rename from src/soc/amd/common/block/cpu/smm/Makefile.inc rename to src/soc/amd/common/block/cpu/smm/Makefile.mk diff --git a/src/soc/amd/common/block/cpu/tsc/Makefile.inc b/src/soc/amd/common/block/cpu/tsc/Makefile.mk similarity index 100% rename from src/soc/amd/common/block/cpu/tsc/Makefile.inc rename to src/soc/amd/common/block/cpu/tsc/Makefile.mk diff --git a/src/soc/amd/common/block/data_fabric/Makefile.inc b/src/soc/amd/common/block/data_fabric/Makefile.mk similarity index 100% rename from src/soc/amd/common/block/data_fabric/Makefile.inc rename to src/soc/amd/common/block/data_fabric/Makefile.mk diff --git a/src/soc/amd/common/block/emmc/Makefile.inc b/src/soc/amd/common/block/emmc/Makefile.mk similarity index 100% rename from src/soc/amd/common/block/emmc/Makefile.inc rename to src/soc/amd/common/block/emmc/Makefile.mk diff --git a/src/soc/amd/common/block/gpio/Makefile.inc b/src/soc/amd/common/block/gpio/Makefile.mk similarity index 100% rename from src/soc/amd/common/block/gpio/Makefile.inc rename to src/soc/amd/common/block/gpio/Makefile.mk diff --git a/src/soc/amd/common/block/graphics/Makefile.inc b/src/soc/amd/common/block/graphics/Makefile.mk similarity index 100% rename from src/soc/amd/common/block/graphics/Makefile.inc rename to src/soc/amd/common/block/graphics/Makefile.mk diff --git a/src/soc/amd/common/block/hda/Makefile.inc b/src/soc/amd/common/block/hda/Makefile.mk similarity index 100% rename from src/soc/amd/common/block/hda/Makefile.inc rename to src/soc/amd/common/block/hda/Makefile.mk diff --git a/src/soc/amd/common/block/i2c/Makefile.inc b/src/soc/amd/common/block/i2c/Makefile.mk similarity index 100% rename from src/soc/amd/common/block/i2c/Makefile.inc rename to src/soc/amd/common/block/i2c/Makefile.mk diff --git a/src/soc/amd/common/block/iommu/Makefile.inc b/src/soc/amd/common/block/iommu/Makefile.mk similarity index 100% rename from src/soc/amd/common/block/iommu/Makefile.inc rename to src/soc/amd/common/block/iommu/Makefile.mk diff --git a/src/soc/amd/common/block/lpc/Makefile.inc b/src/soc/amd/common/block/lpc/Makefile.mk similarity index 100% rename from src/soc/amd/common/block/lpc/Makefile.inc rename to src/soc/amd/common/block/lpc/Makefile.mk diff --git a/src/soc/amd/common/block/pci/Makefile.inc b/src/soc/amd/common/block/pci/Makefile.mk similarity index 100% rename from src/soc/amd/common/block/pci/Makefile.inc rename to src/soc/amd/common/block/pci/Makefile.mk diff --git a/src/soc/amd/common/block/pm/Makefile.inc b/src/soc/amd/common/block/pm/Makefile.mk similarity index 100% rename from src/soc/amd/common/block/pm/Makefile.inc rename to src/soc/amd/common/block/pm/Makefile.mk diff --git a/src/soc/amd/common/block/psp/Makefile.inc b/src/soc/amd/common/block/psp/Makefile.mk similarity index 100% rename from src/soc/amd/common/block/psp/Makefile.inc rename to src/soc/amd/common/block/psp/Makefile.mk diff --git a/src/soc/amd/common/block/root_complex/Makefile.inc b/src/soc/amd/common/block/root_complex/Makefile.mk similarity index 100% rename from src/soc/amd/common/block/root_complex/Makefile.inc rename to src/soc/amd/common/block/root_complex/Makefile.mk diff --git a/src/soc/amd/common/block/sata/Makefile.inc b/src/soc/amd/common/block/sata/Makefile.mk similarity index 100% rename from src/soc/amd/common/block/sata/Makefile.inc rename to src/soc/amd/common/block/sata/Makefile.mk diff --git a/src/soc/amd/common/block/simnow/Makefile.inc b/src/soc/amd/common/block/simnow/Makefile.mk similarity index 100% rename from src/soc/amd/common/block/simnow/Makefile.inc rename to src/soc/amd/common/block/simnow/Makefile.mk diff --git a/src/soc/amd/common/block/smbus/Makefile.inc b/src/soc/amd/common/block/smbus/Makefile.mk similarity index 100% rename from src/soc/amd/common/block/smbus/Makefile.inc rename to src/soc/amd/common/block/smbus/Makefile.mk diff --git a/src/soc/amd/common/block/smi/Makefile.inc b/src/soc/amd/common/block/smi/Makefile.mk similarity index 100% rename from src/soc/amd/common/block/smi/Makefile.inc rename to src/soc/amd/common/block/smi/Makefile.mk diff --git a/src/soc/amd/common/block/smn/Makefile.inc b/src/soc/amd/common/block/smn/Makefile.mk similarity index 100% rename from src/soc/amd/common/block/smn/Makefile.inc rename to src/soc/amd/common/block/smn/Makefile.mk diff --git a/src/soc/amd/common/block/smu/Makefile.inc b/src/soc/amd/common/block/smu/Makefile.mk similarity index 100% rename from src/soc/amd/common/block/smu/Makefile.inc rename to src/soc/amd/common/block/smu/Makefile.mk diff --git a/src/soc/amd/common/block/spi/Makefile.inc b/src/soc/amd/common/block/spi/Makefile.mk similarity index 100% rename from src/soc/amd/common/block/spi/Makefile.inc rename to src/soc/amd/common/block/spi/Makefile.mk diff --git a/src/soc/amd/common/block/stb/Makefile.inc b/src/soc/amd/common/block/stb/Makefile.mk similarity index 100% rename from src/soc/amd/common/block/stb/Makefile.inc rename to src/soc/amd/common/block/stb/Makefile.mk diff --git a/src/soc/amd/common/block/uart/Makefile.inc b/src/soc/amd/common/block/uart/Makefile.mk similarity index 100% rename from src/soc/amd/common/block/uart/Makefile.inc rename to src/soc/amd/common/block/uart/Makefile.mk diff --git a/src/soc/amd/common/block/xhci/Makefile.inc b/src/soc/amd/common/block/xhci/Makefile.mk similarity index 100% rename from src/soc/amd/common/block/xhci/Makefile.inc rename to src/soc/amd/common/block/xhci/Makefile.mk diff --git a/src/soc/amd/common/fsp/Makefile.inc b/src/soc/amd/common/fsp/Makefile.mk similarity index 100% rename from src/soc/amd/common/fsp/Makefile.inc rename to src/soc/amd/common/fsp/Makefile.mk diff --git a/src/soc/amd/common/fsp/pci/Makefile.inc b/src/soc/amd/common/fsp/pci/Makefile.mk similarity index 100% rename from src/soc/amd/common/fsp/pci/Makefile.inc rename to src/soc/amd/common/fsp/pci/Makefile.mk diff --git a/src/soc/amd/common/pi/Makefile.inc b/src/soc/amd/common/pi/Makefile.mk similarity index 100% rename from src/soc/amd/common/pi/Makefile.inc rename to src/soc/amd/common/pi/Makefile.mk diff --git a/src/soc/amd/common/psp_verstage/Makefile.inc b/src/soc/amd/common/psp_verstage/Makefile.mk similarity index 100% rename from src/soc/amd/common/psp_verstage/Makefile.inc rename to src/soc/amd/common/psp_verstage/Makefile.mk diff --git a/src/soc/amd/common/vboot/Makefile.inc b/src/soc/amd/common/vboot/Makefile.mk similarity index 100% rename from src/soc/amd/common/vboot/Makefile.inc rename to src/soc/amd/common/vboot/Makefile.mk diff --git a/src/soc/amd/genoa_poc/Makefile.inc b/src/soc/amd/genoa_poc/Makefile.mk similarity index 100% rename from src/soc/amd/genoa_poc/Makefile.inc rename to src/soc/amd/genoa_poc/Makefile.mk diff --git a/src/soc/amd/glinda/Makefile.inc b/src/soc/amd/glinda/Makefile.mk similarity index 100% rename from src/soc/amd/glinda/Makefile.inc rename to src/soc/amd/glinda/Makefile.mk diff --git a/src/soc/amd/glinda/psp_verstage/Makefile.inc b/src/soc/amd/glinda/psp_verstage/Makefile.mk similarity index 100% rename from src/soc/amd/glinda/psp_verstage/Makefile.inc rename to src/soc/amd/glinda/psp_verstage/Makefile.mk diff --git a/src/soc/amd/mendocino/Makefile.inc b/src/soc/amd/mendocino/Makefile.mk similarity index 100% rename from src/soc/amd/mendocino/Makefile.inc rename to src/soc/amd/mendocino/Makefile.mk diff --git a/src/soc/amd/mendocino/psp_verstage/Makefile.inc b/src/soc/amd/mendocino/psp_verstage/Makefile.mk similarity index 100% rename from src/soc/amd/mendocino/psp_verstage/Makefile.inc rename to src/soc/amd/mendocino/psp_verstage/Makefile.mk diff --git a/src/soc/amd/phoenix/Makefile.inc b/src/soc/amd/phoenix/Makefile.mk similarity index 100% rename from src/soc/amd/phoenix/Makefile.inc rename to src/soc/amd/phoenix/Makefile.mk diff --git a/src/soc/amd/phoenix/psp_verstage/Makefile.inc b/src/soc/amd/phoenix/psp_verstage/Makefile.mk similarity index 100% rename from src/soc/amd/phoenix/psp_verstage/Makefile.inc rename to src/soc/amd/phoenix/psp_verstage/Makefile.mk diff --git a/src/soc/amd/picasso/Makefile.inc b/src/soc/amd/picasso/Makefile.mk similarity index 100% rename from src/soc/amd/picasso/Makefile.inc rename to src/soc/amd/picasso/Makefile.mk diff --git a/src/soc/amd/picasso/psp_verstage/Makefile.inc b/src/soc/amd/picasso/psp_verstage/Makefile.mk similarity index 100% rename from src/soc/amd/picasso/psp_verstage/Makefile.inc rename to src/soc/amd/picasso/psp_verstage/Makefile.mk diff --git a/src/soc/amd/stoneyridge/Makefile.inc b/src/soc/amd/stoneyridge/Makefile.mk similarity index 100% rename from src/soc/amd/stoneyridge/Makefile.inc rename to src/soc/amd/stoneyridge/Makefile.mk -- To view, visit https://review.coreboot.org/c/coreboot/+/80071?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ie449267fe4fdd75110f577e1b9f748cd06140950 Gerrit-Change-Number: 80071 Gerrit-PatchSet: 5 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[NoOp] Change in coreboot[main]: soc/*: Rename Makefiles from .inc to .mk
by Arthur Heymans (Code Review) 24 Jan '24

24 Jan '24

Attention is currently required from: Felix Singer, Hung-Te Lin, Julius Werner, Martin L Roth, Philipp Hug, Xi Chen, Yidi Lin, Yu-Ping Wu, ron minnich. Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80074?usp=email ) Change subject: soc/*: Rename Makefiles from .inc to .mk ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/80074?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I6f502b97864fd7782e514ee2daa902d2081633a2 Gerrit-Change-Number: 80074 Gerrit-PatchSet: 3 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Philipp Hug <philipp(a)hug.cx> Gerrit-Reviewer: Xi Chen <xixi.chen(a)mediatek.com> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: ron minnich <rminnich(a)gmail.com> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Xi Chen <xixi.chen(a)mediatek.com> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Philipp Hug <philipp(a)hug.cx> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Yidi Lin <yidilin(a)google.com> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Attention: ron minnich <rminnich(a)gmail.com> Gerrit-Comment-Date: Wed, 24 Jan 2024 09:59:05 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: soc/intel: Rename Makefiles from .inc to .mk
by Arthur Heymans (Code Review) 24 Jan '24

24 Jan '24

Attention is currently required from: Christian Walter, Dinesh Gehlot, Eran Mitrani, Felix Singer, Jakub Czapiga, Jeff Daly, Johnny Lin, Jonathan Zhang, Kapil Porwal, Lean Sheng Tan, Martin L Roth, Nick Vaccaro, Sean Rhodes, Subrata Banik, Tarun, Tim Chu, Vanessa Eusebio, Werner Zeh. Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80073?usp=email ) Change subject: soc/intel: Rename Makefiles from .inc to .mk ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/80073?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ib479b93b7d0b2e790d0495b6a6b4b4298a515d9a Gerrit-Change-Number: 80073 Gerrit-PatchSet: 3 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Jakub Czapiga <czapiga(a)google.com> Gerrit-Reviewer: Jeff Daly <jeffd(a)silicom-usa.com> Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Jonathan Zhang <jon.zhixiong.zhang(a)gmail.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun <tstuli(a)gmail.com> Gerrit-Reviewer: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Reviewer: Vanessa Eusebio <vanessa.f.eusebio(a)intel.com> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Jeff Daly <jeffd(a)silicom-usa.com> Gerrit-Attention: Eran Mitrani <mitrani(a)google.com> Gerrit-Attention: Jakub Czapiga <czapiga(a)google.com> Gerrit-Attention: Jonathan Zhang <jon.zhixiong.zhang(a)gmail.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Attention: Tarun <tstuli(a)gmail.com> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Vanessa Eusebio <vanessa.f.eusebio(a)intel.com> Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Attention: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Attention: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Comment-Date: Wed, 24 Jan 2024 09:59:00 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[NoOp] Change in coreboot[main]: soc/amd/*: Rename Makefiles from .inc to .mk
by Arthur Heymans (Code Review) 24 Jan '24

24 Jan '24

Attention is currently required from: Felix Held, Felix Singer, Fred Reitberger, Jason Glenesk, Martin L Roth, Matt DeVillier, Maximilian Brune, Michael Niewöhner. Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80071?usp=email ) Change subject: soc/amd/*: Rename Makefiles from .inc to .mk ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/80071?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ie449267fe4fdd75110f577e1b9f748cd06140950 Gerrit-Change-Number: 80071 Gerrit-PatchSet: 4 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Attention: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Wed, 24 Jan 2024 09:58:55 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: arch/x86/car.ld: Accomodate for FSP spec violation on Xeon-SP
by Arthur Heymans (Code Review) 24 Jan '24

24 Jan '24

Attention is currently required from: Angel Pons, Anjaneya "Reddy" Chagam, Arthur Heymans, Christian Walter, Felix Held, Johnny Lin, Jonathan Zhang, Lean Sheng Tan, Marc Jones, Martin L Roth, Patrick Rudolph, Patrick Rudolph, Paul Menzel, Shuo Liu, Tim Chu. Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61164?usp=email ) Change subject: arch/x86/car.ld: Accomodate for FSP spec violation on Xeon-SP ...................................................................... Patch Set 3: (1 comment) Patchset: PS3: > True. It's kind of sad that you need an NDA and a license to redistribute self build FSP to be able to develop and sell this platform with coreboot, but that's really something Intel needs to figure out. It's not encouraging that landing a ~5 LOC fix in FSP, which would resolve this issue cleanly, is impossible even after multiple emails, IPS tickets and meetings have been had over this one. I hope it gets better in the future :-) -- To view, visit https://review.coreboot.org/c/coreboot/+/61164?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ie682bfa376d699c0eee8de0752cd6ae6d8d81fee Gerrit-Change-Number: 61164 Gerrit-PatchSet: 3 Gerrit-Owner: Arthur Heymans <arthur.heymans(a)9elements.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Anjaneya "Reddy" Chagam <anjaneya.chagam(a)intel.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Jay Talbott <JayTalbott(a)sysproconsulting.com> Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Jonathan Zhang <jon.zhixiong.zhang(a)gmail.com> Gerrit-Reviewer: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Patrick Rudolph <rudolphpatrick05(a)gmail.com> Gerrit-Reviewer: Shuo Liu <shuo.liu(a)intel.com> Gerrit-Reviewer: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: David Hendricks <david.hendricks(a)gmail.com> Gerrit-CC: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-CC: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-CC: Martin L Roth <gaumless(a)gmail.com> Gerrit-CC: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Arthur Heymans <arthur.heymans(a)9elements.com> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Jonathan Zhang <jon.zhixiong.zhang(a)gmail.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Patrick Rudolph <rudolphpatrick05(a)gmail.com> Gerrit-Attention: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Attention: Anjaneya "Reddy" Chagam <anjaneya.chagam(a)intel.com> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Shuo Liu <shuo.liu(a)intel.com> Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Attention: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Comment-Date: Wed, 24 Jan 2024 09:52:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Arthur Heymans <arthur(a)aheymans.xyz> Comment-In-Reply-To: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: arch/x86/car.ld: Accomodate for FSP spec violation on Xeon-SP
by Lean Sheng Tan (Code Review) 24 Jan '24

24 Jan '24

Attention is currently required from: Angel Pons, Anjaneya "Reddy" Chagam, Arthur Heymans, Arthur Heymans, Christian Walter, Felix Held, Johnny Lin, Jonathan Zhang, Marc Jones, Martin L Roth, Patrick Rudolph, Patrick Rudolph, Paul Menzel, Shuo Liu, Tim Chu. Lean Sheng Tan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61164?usp=email ) Change subject: arch/x86/car.ld: Accomodate for FSP spec violation on Xeon-SP ...................................................................... Patch Set 3: (1 comment) Patchset: PS3: > > how should we handle this? This issue affects 3 generations of Intel Xeon FSP (CPX, SPR and EMR), […] True. -- To view, visit https://review.coreboot.org/c/coreboot/+/61164?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ie682bfa376d699c0eee8de0752cd6ae6d8d81fee Gerrit-Change-Number: 61164 Gerrit-PatchSet: 3 Gerrit-Owner: Arthur Heymans <arthur.heymans(a)9elements.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Anjaneya "Reddy" Chagam <anjaneya.chagam(a)intel.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Jay Talbott <JayTalbott(a)sysproconsulting.com> Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Jonathan Zhang <jon.zhixiong.zhang(a)gmail.com> Gerrit-Reviewer: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Patrick Rudolph <rudolphpatrick05(a)gmail.com> Gerrit-Reviewer: Shuo Liu <shuo.liu(a)intel.com> Gerrit-Reviewer: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: David Hendricks <david.hendricks(a)gmail.com> Gerrit-CC: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-CC: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-CC: Martin L Roth <gaumless(a)gmail.com> Gerrit-CC: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Arthur Heymans <arthur.heymans(a)9elements.com> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Jonathan Zhang <jon.zhixiong.zhang(a)gmail.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Patrick Rudolph <rudolphpatrick05(a)gmail.com> Gerrit-Attention: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Attention: Anjaneya "Reddy" Chagam <anjaneya.chagam(a)intel.com> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Shuo Liu <shuo.liu(a)intel.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Attention: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Comment-Date: Wed, 24 Jan 2024 09:46:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Arthur Heymans <arthur(a)aheymans.xyz> Comment-In-Reply-To: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: arch/x86/car.ld: Accomodate for FSP spec violation on Xeon-SP
by Arthur Heymans (Code Review) 24 Jan '24

24 Jan '24

Attention is currently required from: Angel Pons, Anjaneya "Reddy" Chagam, Arthur Heymans, Christian Walter, Felix Held, Johnny Lin, Jonathan Zhang, Lean Sheng Tan, Marc Jones, Martin L Roth, Patrick Rudolph, Patrick Rudolph, Paul Menzel, Shuo Liu, Tim Chu. Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61164?usp=email ) Change subject: arch/x86/car.ld: Accomodate for FSP spec violation on Xeon-SP ...................................................................... Patch Set 3: (1 comment) Patchset: PS3: > how should we handle this? This issue affects 3 generations of Intel Xeon FSP (CPX, SPR and EMR), and is not observed on the next gen Xeon. Any idea? Who needs this? Upstream FSP is broken with LinuxBoot on SPR-SP, due to that weird TOCTOU bug. There are no dual socket CPX boards. If everyone is running their own FSP anyway, why bother? -- To view, visit https://review.coreboot.org/c/coreboot/+/61164?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ie682bfa376d699c0eee8de0752cd6ae6d8d81fee Gerrit-Change-Number: 61164 Gerrit-PatchSet: 3 Gerrit-Owner: Arthur Heymans <arthur.heymans(a)9elements.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Anjaneya "Reddy" Chagam <anjaneya.chagam(a)intel.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Jay Talbott <JayTalbott(a)sysproconsulting.com> Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Jonathan Zhang <jon.zhixiong.zhang(a)gmail.com> Gerrit-Reviewer: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Patrick Rudolph <rudolphpatrick05(a)gmail.com> Gerrit-Reviewer: Shuo Liu <shuo.liu(a)intel.com> Gerrit-Reviewer: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: David Hendricks <david.hendricks(a)gmail.com> Gerrit-CC: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-CC: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-CC: Martin L Roth <gaumless(a)gmail.com> Gerrit-CC: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Arthur Heymans <arthur.heymans(a)9elements.com> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Jonathan Zhang <jon.zhixiong.zhang(a)gmail.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Patrick Rudolph <rudolphpatrick05(a)gmail.com> Gerrit-Attention: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Attention: Anjaneya "Reddy" Chagam <anjaneya.chagam(a)intel.com> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Shuo Liu <shuo.liu(a)intel.com> Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Attention: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Comment-Date: Wed, 24 Jan 2024 09:45:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: arch/x86/car.ld: Accomodate for FSP spec violation on Xeon-SP
by Lean Sheng Tan (Code Review) 24 Jan '24

24 Jan '24

Attention is currently required from: Angel Pons, Anjaneya "Reddy" Chagam, Arthur Heymans, Arthur Heymans, Christian Walter, Felix Held, Johnny Lin, Jonathan Zhang, Marc Jones, Martin L Roth, Patrick Rudolph, Patrick Rudolph, Paul Menzel, Shuo Liu, Tim Chu. Lean Sheng Tan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61164?usp=email ) Change subject: arch/x86/car.ld: Accomodate for FSP spec violation on Xeon-SP ...................................................................... Patch Set 3: (1 comment) Patchset: PS3: how should we handle this? This issue affects 3 generations of Intel Xeon FSP (CPX, SPR and EMR), and is not observed on the next gen Xeon. Any idea? -- To view, visit https://review.coreboot.org/c/coreboot/+/61164?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ie682bfa376d699c0eee8de0752cd6ae6d8d81fee Gerrit-Change-Number: 61164 Gerrit-PatchSet: 3 Gerrit-Owner: Arthur Heymans <arthur.heymans(a)9elements.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Anjaneya "Reddy" Chagam <anjaneya.chagam(a)intel.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Jay Talbott <JayTalbott(a)sysproconsulting.com> Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Jonathan Zhang <jon.zhixiong.zhang(a)gmail.com> Gerrit-Reviewer: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Patrick Rudolph <rudolphpatrick05(a)gmail.com> Gerrit-Reviewer: Shuo Liu <shuo.liu(a)intel.com> Gerrit-Reviewer: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: David Hendricks <david.hendricks(a)gmail.com> Gerrit-CC: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-CC: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-CC: Martin L Roth <gaumless(a)gmail.com> Gerrit-CC: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Arthur Heymans <arthur.heymans(a)9elements.com> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Jonathan Zhang <jon.zhixiong.zhang(a)gmail.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Patrick Rudolph <rudolphpatrick05(a)gmail.com> Gerrit-Attention: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Attention: Anjaneya "Reddy" Chagam <anjaneya.chagam(a)intel.com> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Shuo Liu <shuo.liu(a)intel.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Attention: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Comment-Date: Wed, 24 Jan 2024 09:36:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[NoOp] Change in coreboot[main]: northbridge: Rename Makefiles from .inc to .mk
by Felix Singer (Code Review) 24 Jan '24

24 Jan '24

Felix Singer has submitted this change. ( https://review.coreboot.org/c/coreboot/+/80070?usp=email ) ( 3 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: northbridge: Rename Makefiles from .inc to .mk ...................................................................... northbridge: Rename Makefiles from .inc to .mk The .inc suffix is confusing to various tools as it's not specific to Makefiles. This means that editors don't recognize the files, and don't open them with highlighting and any other specific editor functionality. This issue is also seen in the release notes generation script where Makefiles get renamed before running cloc. Signed-off-by: Martin Roth <gaumless(a)gmail.com> Change-Id: Iddac15cc42532f44dda44032be0f8525f6347abd Reviewed-on: https://review.coreboot.org/c/coreboot/+/80070 Reviewed-by: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Michael Niewöhner <foss(a)mniewoehner.de> Reviewed-by: Maximilian Brune <maximilian.brune(a)9elements.com> --- R src/northbridge/amd/pi/00730F01/Makefile.mk R src/northbridge/amd/pi/Makefile.mk R src/northbridge/intel/e7505/Makefile.mk R src/northbridge/intel/gm45/Makefile.mk R src/northbridge/intel/haswell/Makefile.mk R src/northbridge/intel/haswell/broadwell_mrc/Makefile.mk R src/northbridge/intel/haswell/haswell_mrc/Makefile.mk R src/northbridge/intel/haswell/native_raminit/Makefile.mk R src/northbridge/intel/i440bx/Makefile.mk R src/northbridge/intel/i945/Makefile.mk R src/northbridge/intel/ironlake/Makefile.mk R src/northbridge/intel/pineview/Makefile.mk R src/northbridge/intel/sandybridge/Makefile.mk R src/northbridge/intel/x4x/Makefile.mk 14 files changed, 0 insertions(+), 0 deletions(-) Approvals: Michael Niewöhner: Looks good to me, approved build bot (Jenkins): Verified Maximilian Brune: Looks good to me, approved Felix Singer: Looks good to me, approved diff --git a/src/northbridge/amd/pi/00730F01/Makefile.inc b/src/northbridge/amd/pi/00730F01/Makefile.mk similarity index 100% rename from src/northbridge/amd/pi/00730F01/Makefile.inc rename to src/northbridge/amd/pi/00730F01/Makefile.mk diff --git a/src/northbridge/amd/pi/Makefile.inc b/src/northbridge/amd/pi/Makefile.mk similarity index 100% rename from src/northbridge/amd/pi/Makefile.inc rename to src/northbridge/amd/pi/Makefile.mk diff --git a/src/northbridge/intel/e7505/Makefile.inc b/src/northbridge/intel/e7505/Makefile.mk similarity index 100% rename from src/northbridge/intel/e7505/Makefile.inc rename to src/northbridge/intel/e7505/Makefile.mk diff --git a/src/northbridge/intel/gm45/Makefile.inc b/src/northbridge/intel/gm45/Makefile.mk similarity index 100% rename from src/northbridge/intel/gm45/Makefile.inc rename to src/northbridge/intel/gm45/Makefile.mk diff --git a/src/northbridge/intel/haswell/Makefile.inc b/src/northbridge/intel/haswell/Makefile.mk similarity index 100% rename from src/northbridge/intel/haswell/Makefile.inc rename to src/northbridge/intel/haswell/Makefile.mk diff --git a/src/northbridge/intel/haswell/broadwell_mrc/Makefile.inc b/src/northbridge/intel/haswell/broadwell_mrc/Makefile.mk similarity index 100% rename from src/northbridge/intel/haswell/broadwell_mrc/Makefile.inc rename to src/northbridge/intel/haswell/broadwell_mrc/Makefile.mk diff --git a/src/northbridge/intel/haswell/haswell_mrc/Makefile.inc b/src/northbridge/intel/haswell/haswell_mrc/Makefile.mk similarity index 100% rename from src/northbridge/intel/haswell/haswell_mrc/Makefile.inc rename to src/northbridge/intel/haswell/haswell_mrc/Makefile.mk diff --git a/src/northbridge/intel/haswell/native_raminit/Makefile.inc b/src/northbridge/intel/haswell/native_raminit/Makefile.mk similarity index 100% rename from src/northbridge/intel/haswell/native_raminit/Makefile.inc rename to src/northbridge/intel/haswell/native_raminit/Makefile.mk diff --git a/src/northbridge/intel/i440bx/Makefile.inc b/src/northbridge/intel/i440bx/Makefile.mk similarity index 100% rename from src/northbridge/intel/i440bx/Makefile.inc rename to src/northbridge/intel/i440bx/Makefile.mk diff --git a/src/northbridge/intel/i945/Makefile.inc b/src/northbridge/intel/i945/Makefile.mk similarity index 100% rename from src/northbridge/intel/i945/Makefile.inc rename to src/northbridge/intel/i945/Makefile.mk diff --git a/src/northbridge/intel/ironlake/Makefile.inc b/src/northbridge/intel/ironlake/Makefile.mk similarity index 100% rename from src/northbridge/intel/ironlake/Makefile.inc rename to src/northbridge/intel/ironlake/Makefile.mk diff --git a/src/northbridge/intel/pineview/Makefile.inc b/src/northbridge/intel/pineview/Makefile.mk similarity index 100% rename from src/northbridge/intel/pineview/Makefile.inc rename to src/northbridge/intel/pineview/Makefile.mk diff --git a/src/northbridge/intel/sandybridge/Makefile.inc b/src/northbridge/intel/sandybridge/Makefile.mk similarity index 100% rename from src/northbridge/intel/sandybridge/Makefile.inc rename to src/northbridge/intel/sandybridge/Makefile.mk diff --git a/src/northbridge/intel/x4x/Makefile.inc b/src/northbridge/intel/x4x/Makefile.mk similarity index 100% rename from src/northbridge/intel/x4x/Makefile.inc rename to src/northbridge/intel/x4x/Makefile.mk -- To view, visit https://review.coreboot.org/c/coreboot/+/80070?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Iddac15cc42532f44dda44032be0f8525f6347abd Gerrit-Change-Number: 80070 Gerrit-PatchSet: 5 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit January 2024