coreboot-gerrit January 2024

coreboot-gerrit@coreboot.org

1 participants
3044 discussions

[S] Change in coreboot[main]: payloads: Rename Makefiles from .inc to .mk
by Felix Singer (Code Review) 24 Jan '24

24 Jan '24

Felix Singer has submitted this change. ( https://review.coreboot.org/c/coreboot/+/80103?usp=email ) ( 2 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: payloads: Rename Makefiles from .inc to .mk ...................................................................... payloads: Rename Makefiles from .inc to .mk The .inc suffix is confusing to various tools as it's not specific to Makefiles. This means that editors don't recognize the files, and don't open them with highlighting and any other specific editor functionality. This issue is also seen in the release notes generation script where Makefiles get renamed before running cloc. Signed-off-by: Martin Roth <gaumless(a)gmail.com> Change-Id: Ie7038712de8cc646632d5e7d29550e3260bf2c62 Reviewed-on: https://review.coreboot.org/c/coreboot/+/80103 Reviewed-by: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Reviewed-by: Maximilian Brune <maximilian.brune(a)9elements.com> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- R payloads/external/Makefile.mk M payloads/libpayload/Makefile R payloads/libpayload/Makefile.mk R payloads/libpayload/arch/arm/Makefile.mk R payloads/libpayload/arch/arm64/Makefile.mk R payloads/libpayload/arch/mock/Makefile.mk R payloads/libpayload/arch/x86/Makefile.mk R payloads/libpayload/crypto/Makefile.mk R payloads/libpayload/curses/Makefile.mk R payloads/libpayload/drivers/Makefile.mk R payloads/libpayload/gdb/Makefile.mk R payloads/libpayload/libc/Makefile.mk R payloads/libpayload/libcbfs/Makefile.mk R payloads/libpayload/liblz4/Makefile.mk R payloads/libpayload/liblzma/Makefile.mk R payloads/libpayload/libpci/Makefile.mk R payloads/libpayload/tests/Makefile.mk R payloads/libpayload/tests/drivers/Makefile.mk R payloads/libpayload/tests/libc/Makefile.mk R payloads/libpayload/tests/libcbfs/Makefile.mk R payloads/libpayload/vboot/Makefile.mk M util/lint/kconfig_lint 22 files changed, 8 insertions(+), 8 deletions(-) Approvals: Maximilian Brune: Looks good to me, approved build bot (Jenkins): Verified Felix Singer: Looks good to me, approved diff --git a/payloads/external/Makefile.inc b/payloads/external/Makefile.mk similarity index 100% rename from payloads/external/Makefile.inc rename to payloads/external/Makefile.mk diff --git a/payloads/libpayload/Makefile b/payloads/libpayload/Makefile index 212e67e..71d60bc 100644 --- a/payloads/libpayload/Makefile +++ b/payloads/libpayload/Makefile @@ -56,7 +56,7 @@ export KBUILD_KCONFIG := Kconfig export CONFIG_ := CONFIG_LP_ -# directory containing the toplevel Makefile.inc +# directory containing the toplevel Makefile.mk TOPLEVEL := . CONFIG_LP_SHELL := sh @@ -159,8 +159,8 @@ \mv -f $@.tmp $@ 2> /dev/null ifeq ($(NOCOMPILE),1) -include $(TOPLEVEL)/Makefile.inc -include $(TOPLEVEL)/tests/Makefile.inc +include $(TOPLEVEL)/Makefile.mk +include $(TOPLEVEL)/tests/Makefile.mk real-all: config else @@ -285,7 +285,7 @@ $(eval $(1):=) \ $(eval special-classes+=$(1)) -# Clean -y variables, include Makefile.inc +# Clean -y variables, include Makefile.mk # Add paths to files in X-y to X-srcs # Add subdirs-y to subdirs includemakefiles= \ @@ -308,7 +308,7 @@ $(eval cursubdirs:=$(subdirs)) \ $(eval subdirs:=) \ $(foreach dir,$(cursubdirs), \ - $(eval $(call includemakefiles,$(dir)/Makefile.inc))) \ + $(eval $(call includemakefiles,$(dir)/Makefile.mk))) \ $(if $(subdirs),$(eval $(call evaluate_subdirs))) # collect all object files eligible for building or run unit-tests @@ -316,7 +316,7 @@ subdirs:=$(TOPLEVEL) $(eval $(call evaluate_subdirs)) else -include $(TOPLEVEL)/tests/Makefile.inc +include $(TOPLEVEL)/tests/Makefile.mk endif # Converts one or more source file paths to the corresponding build/ paths. diff --git a/payloads/libpayload/Makefile.inc b/payloads/libpayload/Makefile.mk similarity index 100% rename from payloads/libpayload/Makefile.inc rename to payloads/libpayload/Makefile.mk diff --git a/payloads/libpayload/arch/arm/Makefile.inc b/payloads/libpayload/arch/arm/Makefile.mk similarity index 100% rename from payloads/libpayload/arch/arm/Makefile.inc rename to payloads/libpayload/arch/arm/Makefile.mk diff --git a/payloads/libpayload/arch/arm64/Makefile.inc b/payloads/libpayload/arch/arm64/Makefile.mk similarity index 100% rename from payloads/libpayload/arch/arm64/Makefile.inc rename to payloads/libpayload/arch/arm64/Makefile.mk diff --git a/payloads/libpayload/arch/mock/Makefile.inc b/payloads/libpayload/arch/mock/Makefile.mk similarity index 100% rename from payloads/libpayload/arch/mock/Makefile.inc rename to payloads/libpayload/arch/mock/Makefile.mk diff --git a/payloads/libpayload/arch/x86/Makefile.inc b/payloads/libpayload/arch/x86/Makefile.mk similarity index 100% rename from payloads/libpayload/arch/x86/Makefile.inc rename to payloads/libpayload/arch/x86/Makefile.mk diff --git a/payloads/libpayload/crypto/Makefile.inc b/payloads/libpayload/crypto/Makefile.mk similarity index 100% rename from payloads/libpayload/crypto/Makefile.inc rename to payloads/libpayload/crypto/Makefile.mk diff --git a/payloads/libpayload/curses/Makefile.inc b/payloads/libpayload/curses/Makefile.mk similarity index 100% rename from payloads/libpayload/curses/Makefile.inc rename to payloads/libpayload/curses/Makefile.mk diff --git a/payloads/libpayload/drivers/Makefile.inc b/payloads/libpayload/drivers/Makefile.mk similarity index 100% rename from payloads/libpayload/drivers/Makefile.inc rename to payloads/libpayload/drivers/Makefile.mk diff --git a/payloads/libpayload/gdb/Makefile.inc b/payloads/libpayload/gdb/Makefile.mk similarity index 100% rename from payloads/libpayload/gdb/Makefile.inc rename to payloads/libpayload/gdb/Makefile.mk diff --git a/payloads/libpayload/libc/Makefile.inc b/payloads/libpayload/libc/Makefile.mk similarity index 100% rename from payloads/libpayload/libc/Makefile.inc rename to payloads/libpayload/libc/Makefile.mk diff --git a/payloads/libpayload/libcbfs/Makefile.inc b/payloads/libpayload/libcbfs/Makefile.mk similarity index 100% rename from payloads/libpayload/libcbfs/Makefile.inc rename to payloads/libpayload/libcbfs/Makefile.mk diff --git a/payloads/libpayload/liblz4/Makefile.inc b/payloads/libpayload/liblz4/Makefile.mk similarity index 100% rename from payloads/libpayload/liblz4/Makefile.inc rename to payloads/libpayload/liblz4/Makefile.mk diff --git a/payloads/libpayload/liblzma/Makefile.inc b/payloads/libpayload/liblzma/Makefile.mk similarity index 100% rename from payloads/libpayload/liblzma/Makefile.inc rename to payloads/libpayload/liblzma/Makefile.mk diff --git a/payloads/libpayload/libpci/Makefile.inc b/payloads/libpayload/libpci/Makefile.mk similarity index 100% rename from payloads/libpayload/libpci/Makefile.inc rename to payloads/libpayload/libpci/Makefile.mk diff --git a/payloads/libpayload/tests/Makefile.inc b/payloads/libpayload/tests/Makefile.mk similarity index 98% rename from payloads/libpayload/tests/Makefile.inc rename to payloads/libpayload/tests/Makefile.mk index dede340..e271a7c 100644 --- a/payloads/libpayload/tests/Makefile.inc +++ b/payloads/libpayload/tests/Makefile.mk @@ -105,7 +105,7 @@ $(1)-config-file := $(testobj)/$(1)/libpayload-config.h $$($(1)-config-file): $(TEST_KCONFIG_AUTOHEADER) mkdir -p $$(dir $$@); - printf '// File generated by tests/Makefile.inc\n// Do not change\n' > $$@; + printf '// File generated by tests/Makefile.mk\n// Do not change\n' > $$@; printf '#ifndef TEST_LIBPAYLOAD_CONFIG_H_\n' >> $$@; printf '#define TEST_LIBPAYLOAD_CONFIG_H_\n' >> $$@; printf '#include <%s>\n\n' "$(notdir $(TEST_KCONFIG_AUTOHEADER))" >> $$@; diff --git a/payloads/libpayload/tests/drivers/Makefile.inc b/payloads/libpayload/tests/drivers/Makefile.mk similarity index 100% rename from payloads/libpayload/tests/drivers/Makefile.inc rename to payloads/libpayload/tests/drivers/Makefile.mk diff --git a/payloads/libpayload/tests/libc/Makefile.inc b/payloads/libpayload/tests/libc/Makefile.mk similarity index 100% rename from payloads/libpayload/tests/libc/Makefile.inc rename to payloads/libpayload/tests/libc/Makefile.mk diff --git a/payloads/libpayload/tests/libcbfs/Makefile.inc b/payloads/libpayload/tests/libcbfs/Makefile.mk similarity index 100% rename from payloads/libpayload/tests/libcbfs/Makefile.inc rename to payloads/libpayload/tests/libcbfs/Makefile.mk diff --git a/payloads/libpayload/vboot/Makefile.inc b/payloads/libpayload/vboot/Makefile.mk similarity index 100% rename from payloads/libpayload/vboot/Makefile.inc rename to payloads/libpayload/vboot/Makefile.mk diff --git a/util/lint/kconfig_lint b/util/lint/kconfig_lint index e64cf11..43b1630 100755 --- a/util/lint/kconfig_lint +++ b/util/lint/kconfig_lint @@ -36,7 +36,7 @@ '^build/\|^coreboot-builds/\|^configs/\|^util/\|^\.git/\|^payloads\|^Documentation\|^3rdparty' . '\|' . # directories to exclude when searching for used symbols '\.config\|\.txt$\|\.tex$\|\.tags\|/kconfig.h\|\.fmd'; #files to exclude when looking for symbols -my $payload_files_to_check='payloads/Makefile.mk payloads/external/Makefile.inc'; +my $payload_files_to_check='payloads/Makefile.mk payloads/external/Makefile.mk'; my $config_file = ""; # name of config file to load symbol values from. my @wholeconfig; # document the entire kconfig structure my %loaded_files; # list of each Kconfig file loaded -- To view, visit https://review.coreboot.org/c/coreboot/+/80103?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ie7038712de8cc646632d5e7d29550e3260bf2c62 Gerrit-Change-Number: 80103 Gerrit-PatchSet: 4 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Jakub Czapiga <czapiga(a)google.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[NoOp] Change in coreboot[main]: device, security: Rename Makefiles from .inc to .mk
by Felix Singer (Code Review) 24 Jan '24

24 Jan '24

Felix Singer has submitted this change. ( https://review.coreboot.org/c/coreboot/+/80082?usp=email ) ( 2 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: device, security: Rename Makefiles from .inc to .mk ...................................................................... device, security: Rename Makefiles from .inc to .mk The .inc suffix is confusing to various tools as it's not specific to Makefiles. This means that editors don't recognize the files, and don't open them with highlighting and any other specific editor functionality. This issue is also seen in the release notes generation script where Makefiles get renamed before running cloc. Signed-off-by: Martin Roth <gaumless(a)gmail.com> Change-Id: I41f8a9b5d1bdb647a915da1a5e95161b2e34df28 Reviewed-on: https://review.coreboot.org/c/coreboot/+/80082 Reviewed-by: Michael Niewöhner <foss(a)mniewoehner.de> Reviewed-by: Maximilian Brune <maximilian.brune(a)9elements.com> Reviewed-by: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- R src/device/Makefile.mk R src/device/dram/Makefile.mk R src/device/oprom/Makefile.mk R src/device/oprom/realmode/Makefile.mk R src/device/oprom/x86emu/Makefile.mk R src/device/oprom/yabel/Makefile.mk R src/device/oprom/yabel/compat/Makefile.mk R src/security/Makefile.mk R src/security/intel/Makefile.mk R src/security/intel/cbnt/Makefile.mk R src/security/intel/stm/Makefile.mk R src/security/intel/txt/Makefile.mk R src/security/lockdown/Makefile.mk R src/security/memory/Makefile.mk R src/security/tpm/Makefile.mk R src/security/tpm/tss/vendor/cr50/Makefile.mk R src/security/vboot/Makefile.mk 17 files changed, 0 insertions(+), 0 deletions(-) Approvals: build bot (Jenkins): Verified Felix Singer: Looks good to me, approved Maximilian Brune: Looks good to me, approved Michael Niewöhner: Looks good to me, approved diff --git a/src/device/Makefile.inc b/src/device/Makefile.mk similarity index 100% rename from src/device/Makefile.inc rename to src/device/Makefile.mk diff --git a/src/device/dram/Makefile.inc b/src/device/dram/Makefile.mk similarity index 100% rename from src/device/dram/Makefile.inc rename to src/device/dram/Makefile.mk diff --git a/src/device/oprom/Makefile.inc b/src/device/oprom/Makefile.mk similarity index 100% rename from src/device/oprom/Makefile.inc rename to src/device/oprom/Makefile.mk diff --git a/src/device/oprom/realmode/Makefile.inc b/src/device/oprom/realmode/Makefile.mk similarity index 100% rename from src/device/oprom/realmode/Makefile.inc rename to src/device/oprom/realmode/Makefile.mk diff --git a/src/device/oprom/x86emu/Makefile.inc b/src/device/oprom/x86emu/Makefile.mk similarity index 100% rename from src/device/oprom/x86emu/Makefile.inc rename to src/device/oprom/x86emu/Makefile.mk diff --git a/src/device/oprom/yabel/Makefile.inc b/src/device/oprom/yabel/Makefile.mk similarity index 100% rename from src/device/oprom/yabel/Makefile.inc rename to src/device/oprom/yabel/Makefile.mk diff --git a/src/device/oprom/yabel/compat/Makefile.inc b/src/device/oprom/yabel/compat/Makefile.mk similarity index 100% rename from src/device/oprom/yabel/compat/Makefile.inc rename to src/device/oprom/yabel/compat/Makefile.mk diff --git a/src/security/Makefile.inc b/src/security/Makefile.mk similarity index 100% rename from src/security/Makefile.inc rename to src/security/Makefile.mk diff --git a/src/security/intel/Makefile.inc b/src/security/intel/Makefile.mk similarity index 100% rename from src/security/intel/Makefile.inc rename to src/security/intel/Makefile.mk diff --git a/src/security/intel/cbnt/Makefile.inc b/src/security/intel/cbnt/Makefile.mk similarity index 100% rename from src/security/intel/cbnt/Makefile.inc rename to src/security/intel/cbnt/Makefile.mk diff --git a/src/security/intel/stm/Makefile.inc b/src/security/intel/stm/Makefile.mk similarity index 100% rename from src/security/intel/stm/Makefile.inc rename to src/security/intel/stm/Makefile.mk diff --git a/src/security/intel/txt/Makefile.inc b/src/security/intel/txt/Makefile.mk similarity index 100% rename from src/security/intel/txt/Makefile.inc rename to src/security/intel/txt/Makefile.mk diff --git a/src/security/lockdown/Makefile.inc b/src/security/lockdown/Makefile.mk similarity index 100% rename from src/security/lockdown/Makefile.inc rename to src/security/lockdown/Makefile.mk diff --git a/src/security/memory/Makefile.inc b/src/security/memory/Makefile.mk similarity index 100% rename from src/security/memory/Makefile.inc rename to src/security/memory/Makefile.mk diff --git a/src/security/tpm/Makefile.inc b/src/security/tpm/Makefile.mk similarity index 100% rename from src/security/tpm/Makefile.inc rename to src/security/tpm/Makefile.mk diff --git a/src/security/tpm/tss/vendor/cr50/Makefile.inc b/src/security/tpm/tss/vendor/cr50/Makefile.mk similarity index 100% rename from src/security/tpm/tss/vendor/cr50/Makefile.inc rename to src/security/tpm/tss/vendor/cr50/Makefile.mk diff --git a/src/security/vboot/Makefile.inc b/src/security/vboot/Makefile.mk similarity index 100% rename from src/security/vboot/Makefile.inc rename to src/security/vboot/Makefile.mk -- To view, visit https://review.coreboot.org/c/coreboot/+/80082?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I41f8a9b5d1bdb647a915da1a5e95161b2e34df28 Gerrit-Change-Number: 80082 Gerrit-PatchSet: 4 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[NoOp] Change in coreboot[main]: lib,console,sbom: Rename Makefiles from .inc to .mk
by Felix Singer (Code Review) 24 Jan '24

24 Jan '24

Felix Singer has submitted this change. ( https://review.coreboot.org/c/coreboot/+/80081?usp=email ) ( 2 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: lib,console,sbom: Rename Makefiles from .inc to .mk ...................................................................... lib,console,sbom: Rename Makefiles from .inc to .mk The .inc suffix is confusing to various tools as it's not specific to Makefiles. This means that editors don't recognize the files, and don't open them with highlighting and any other specific editor functionality. This issue is also seen in the release notes generation script where Makefiles get renamed before running cloc. Signed-off-by: Martin Roth <gaumless(a)gmail.com> Change-Id: I9eabe84d55fd9f434e4128866810c0e4970f2ae7 Reviewed-on: https://review.coreboot.org/c/coreboot/+/80081 Reviewed-by: Michael Niewöhner <foss(a)mniewoehner.de> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Maximilian Brune <maximilian.brune(a)9elements.com> Reviewed-by: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> --- R src/console/Makefile.mk R src/lib/Makefile.mk R src/lib/gnat/Makefile.mk R src/sbom/Makefile.mk 4 files changed, 0 insertions(+), 0 deletions(-) Approvals: Michael Niewöhner: Looks good to me, approved build bot (Jenkins): Verified Felix Singer: Looks good to me, approved Maximilian Brune: Looks good to me, approved diff --git a/src/console/Makefile.inc b/src/console/Makefile.mk similarity index 100% rename from src/console/Makefile.inc rename to src/console/Makefile.mk diff --git a/src/lib/Makefile.inc b/src/lib/Makefile.mk similarity index 100% rename from src/lib/Makefile.inc rename to src/lib/Makefile.mk diff --git a/src/lib/gnat/Makefile.inc b/src/lib/gnat/Makefile.mk similarity index 100% rename from src/lib/gnat/Makefile.inc rename to src/lib/gnat/Makefile.mk diff --git a/src/sbom/Makefile.inc b/src/sbom/Makefile.mk similarity index 100% rename from src/sbom/Makefile.inc rename to src/sbom/Makefile.mk -- To view, visit https://review.coreboot.org/c/coreboot/+/80081?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I9eabe84d55fd9f434e4128866810c0e4970f2ae7 Gerrit-Change-Number: 80081 Gerrit-PatchSet: 4 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[NoOp] Change in coreboot[main]: driver/parade to /driver/wwan: Rename Makefiles from .inc to .mk
by Felix Singer (Code Review) 24 Jan '24

24 Jan '24

Felix Singer has submitted this change. ( https://review.coreboot.org/c/coreboot/+/80080?usp=email ) ( 2 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: driver/parade to /driver/wwan: Rename Makefiles from .inc to .mk ...................................................................... driver/parade to /driver/wwan: Rename Makefiles from .inc to .mk The .inc suffix is confusing to various tools as it's not specific to Makefiles. This means that editors don't recognize the files, and don't open them with highlighting and any other specific editor functionality. This issue is also seen in the release notes generation script where Makefiles get renamed before running cloc. Signed-off-by: Martin Roth <gaumless(a)gmail.com> Change-Id: I8cf3d2e2cd1b6ebe4e941ad64f27698379fef696 Reviewed-on: https://review.coreboot.org/c/coreboot/+/80080 Reviewed-by: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Reviewed-by: Maximilian Brune <maximilian.brune(a)9elements.com> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- R src/drivers/parade/ps8625/Makefile.mk R src/drivers/parade/ps8640/Makefile.mk R src/drivers/pc80/pc/Makefile.mk R src/drivers/pc80/rtc/Makefile.mk R src/drivers/pc80/tpm/Makefile.mk R src/drivers/pc80/vga/Makefile.mk R src/drivers/pcie/generic/Makefile.mk R src/drivers/pcie/rtd3/device/Makefile.mk R src/drivers/ricoh/rce822/Makefile.mk R src/drivers/secunet/dmi/Makefile.mk R src/drivers/siemens/nc_fpga/Makefile.mk R src/drivers/sil/3114/Makefile.mk R src/drivers/smbus/Makefile.mk R src/drivers/smmstore/Makefile.mk R src/drivers/sof/Makefile.mk R src/drivers/soundwire/alc1308/Makefile.mk R src/drivers/soundwire/alc5682/Makefile.mk R src/drivers/soundwire/alc711/Makefile.mk R src/drivers/soundwire/cs42l42/Makefile.mk R src/drivers/soundwire/max98363/Makefile.mk R src/drivers/soundwire/max98373/Makefile.mk R src/drivers/spi/Makefile.mk R src/drivers/spi/acpi/Makefile.mk R src/drivers/spi/tpm/Makefile.mk R src/drivers/ti/sn65dsi86bridge/Makefile.mk R src/drivers/ti/tps65090/Makefile.mk R src/drivers/ti/tps65913/Makefile.mk R src/drivers/tpm/Makefile.mk R src/drivers/uart/Makefile.mk R src/drivers/uart/acpi/Makefile.mk R src/drivers/usb/Makefile.mk R src/drivers/usb/acpi/Makefile.mk R src/drivers/usb/hub/Makefile.mk R src/drivers/usb/pci_xhci/Makefile.mk R src/drivers/vpd/Makefile.mk R src/drivers/wifi/generic/Makefile.mk R src/drivers/wwan/fm/Makefile.mk 37 files changed, 0 insertions(+), 0 deletions(-) Approvals: Felix Singer: Looks good to me, approved Maximilian Brune: Looks good to me, approved build bot (Jenkins): Verified diff --git a/src/drivers/parade/ps8625/Makefile.inc b/src/drivers/parade/ps8625/Makefile.mk similarity index 100% rename from src/drivers/parade/ps8625/Makefile.inc rename to src/drivers/parade/ps8625/Makefile.mk diff --git a/src/drivers/parade/ps8640/Makefile.inc b/src/drivers/parade/ps8640/Makefile.mk similarity index 100% rename from src/drivers/parade/ps8640/Makefile.inc rename to src/drivers/parade/ps8640/Makefile.mk diff --git a/src/drivers/pc80/pc/Makefile.inc b/src/drivers/pc80/pc/Makefile.mk similarity index 100% rename from src/drivers/pc80/pc/Makefile.inc rename to src/drivers/pc80/pc/Makefile.mk diff --git a/src/drivers/pc80/rtc/Makefile.inc b/src/drivers/pc80/rtc/Makefile.mk similarity index 100% rename from src/drivers/pc80/rtc/Makefile.inc rename to src/drivers/pc80/rtc/Makefile.mk diff --git a/src/drivers/pc80/tpm/Makefile.inc b/src/drivers/pc80/tpm/Makefile.mk similarity index 100% rename from src/drivers/pc80/tpm/Makefile.inc rename to src/drivers/pc80/tpm/Makefile.mk diff --git a/src/drivers/pc80/vga/Makefile.inc b/src/drivers/pc80/vga/Makefile.mk similarity index 100% rename from src/drivers/pc80/vga/Makefile.inc rename to src/drivers/pc80/vga/Makefile.mk diff --git a/src/drivers/pcie/generic/Makefile.inc b/src/drivers/pcie/generic/Makefile.mk similarity index 100% rename from src/drivers/pcie/generic/Makefile.inc rename to src/drivers/pcie/generic/Makefile.mk diff --git a/src/drivers/pcie/rtd3/device/Makefile.inc b/src/drivers/pcie/rtd3/device/Makefile.mk similarity index 100% rename from src/drivers/pcie/rtd3/device/Makefile.inc rename to src/drivers/pcie/rtd3/device/Makefile.mk diff --git a/src/drivers/ricoh/rce822/Makefile.inc b/src/drivers/ricoh/rce822/Makefile.mk similarity index 100% rename from src/drivers/ricoh/rce822/Makefile.inc rename to src/drivers/ricoh/rce822/Makefile.mk diff --git a/src/drivers/secunet/dmi/Makefile.inc b/src/drivers/secunet/dmi/Makefile.mk similarity index 100% rename from src/drivers/secunet/dmi/Makefile.inc rename to src/drivers/secunet/dmi/Makefile.mk diff --git a/src/drivers/siemens/nc_fpga/Makefile.inc b/src/drivers/siemens/nc_fpga/Makefile.mk similarity index 100% rename from src/drivers/siemens/nc_fpga/Makefile.inc rename to src/drivers/siemens/nc_fpga/Makefile.mk diff --git a/src/drivers/sil/3114/Makefile.inc b/src/drivers/sil/3114/Makefile.mk similarity index 100% rename from src/drivers/sil/3114/Makefile.inc rename to src/drivers/sil/3114/Makefile.mk diff --git a/src/drivers/smbus/Makefile.inc b/src/drivers/smbus/Makefile.mk similarity index 100% rename from src/drivers/smbus/Makefile.inc rename to src/drivers/smbus/Makefile.mk diff --git a/src/drivers/smmstore/Makefile.inc b/src/drivers/smmstore/Makefile.mk similarity index 100% rename from src/drivers/smmstore/Makefile.inc rename to src/drivers/smmstore/Makefile.mk diff --git a/src/drivers/sof/Makefile.inc b/src/drivers/sof/Makefile.mk similarity index 100% rename from src/drivers/sof/Makefile.inc rename to src/drivers/sof/Makefile.mk diff --git a/src/drivers/soundwire/alc1308/Makefile.inc b/src/drivers/soundwire/alc1308/Makefile.mk similarity index 100% rename from src/drivers/soundwire/alc1308/Makefile.inc rename to src/drivers/soundwire/alc1308/Makefile.mk diff --git a/src/drivers/soundwire/alc5682/Makefile.inc b/src/drivers/soundwire/alc5682/Makefile.mk similarity index 100% rename from src/drivers/soundwire/alc5682/Makefile.inc rename to src/drivers/soundwire/alc5682/Makefile.mk diff --git a/src/drivers/soundwire/alc711/Makefile.inc b/src/drivers/soundwire/alc711/Makefile.mk similarity index 100% rename from src/drivers/soundwire/alc711/Makefile.inc rename to src/drivers/soundwire/alc711/Makefile.mk diff --git a/src/drivers/soundwire/cs42l42/Makefile.inc b/src/drivers/soundwire/cs42l42/Makefile.mk similarity index 100% rename from src/drivers/soundwire/cs42l42/Makefile.inc rename to src/drivers/soundwire/cs42l42/Makefile.mk diff --git a/src/drivers/soundwire/max98363/Makefile.inc b/src/drivers/soundwire/max98363/Makefile.mk similarity index 100% rename from src/drivers/soundwire/max98363/Makefile.inc rename to src/drivers/soundwire/max98363/Makefile.mk diff --git a/src/drivers/soundwire/max98373/Makefile.inc b/src/drivers/soundwire/max98373/Makefile.mk similarity index 100% rename from src/drivers/soundwire/max98373/Makefile.inc rename to src/drivers/soundwire/max98373/Makefile.mk diff --git a/src/drivers/spi/Makefile.inc b/src/drivers/spi/Makefile.mk similarity index 100% rename from src/drivers/spi/Makefile.inc rename to src/drivers/spi/Makefile.mk diff --git a/src/drivers/spi/acpi/Makefile.inc b/src/drivers/spi/acpi/Makefile.mk similarity index 100% rename from src/drivers/spi/acpi/Makefile.inc rename to src/drivers/spi/acpi/Makefile.mk diff --git a/src/drivers/spi/tpm/Makefile.inc b/src/drivers/spi/tpm/Makefile.mk similarity index 100% rename from src/drivers/spi/tpm/Makefile.inc rename to src/drivers/spi/tpm/Makefile.mk diff --git a/src/drivers/ti/sn65dsi86bridge/Makefile.inc b/src/drivers/ti/sn65dsi86bridge/Makefile.mk similarity index 100% rename from src/drivers/ti/sn65dsi86bridge/Makefile.inc rename to src/drivers/ti/sn65dsi86bridge/Makefile.mk diff --git a/src/drivers/ti/tps65090/Makefile.inc b/src/drivers/ti/tps65090/Makefile.mk similarity index 100% rename from src/drivers/ti/tps65090/Makefile.inc rename to src/drivers/ti/tps65090/Makefile.mk diff --git a/src/drivers/ti/tps65913/Makefile.inc b/src/drivers/ti/tps65913/Makefile.mk similarity index 100% rename from src/drivers/ti/tps65913/Makefile.inc rename to src/drivers/ti/tps65913/Makefile.mk diff --git a/src/drivers/tpm/Makefile.inc b/src/drivers/tpm/Makefile.mk similarity index 100% rename from src/drivers/tpm/Makefile.inc rename to src/drivers/tpm/Makefile.mk diff --git a/src/drivers/uart/Makefile.inc b/src/drivers/uart/Makefile.mk similarity index 100% rename from src/drivers/uart/Makefile.inc rename to src/drivers/uart/Makefile.mk diff --git a/src/drivers/uart/acpi/Makefile.inc b/src/drivers/uart/acpi/Makefile.mk similarity index 100% rename from src/drivers/uart/acpi/Makefile.inc rename to src/drivers/uart/acpi/Makefile.mk diff --git a/src/drivers/usb/Makefile.inc b/src/drivers/usb/Makefile.mk similarity index 100% rename from src/drivers/usb/Makefile.inc rename to src/drivers/usb/Makefile.mk diff --git a/src/drivers/usb/acpi/Makefile.inc b/src/drivers/usb/acpi/Makefile.mk similarity index 100% rename from src/drivers/usb/acpi/Makefile.inc rename to src/drivers/usb/acpi/Makefile.mk diff --git a/src/drivers/usb/hub/Makefile.inc b/src/drivers/usb/hub/Makefile.mk similarity index 100% rename from src/drivers/usb/hub/Makefile.inc rename to src/drivers/usb/hub/Makefile.mk diff --git a/src/drivers/usb/pci_xhci/Makefile.inc b/src/drivers/usb/pci_xhci/Makefile.mk similarity index 100% rename from src/drivers/usb/pci_xhci/Makefile.inc rename to src/drivers/usb/pci_xhci/Makefile.mk diff --git a/src/drivers/vpd/Makefile.inc b/src/drivers/vpd/Makefile.mk similarity index 100% rename from src/drivers/vpd/Makefile.inc rename to src/drivers/vpd/Makefile.mk diff --git a/src/drivers/wifi/generic/Makefile.inc b/src/drivers/wifi/generic/Makefile.mk similarity index 100% rename from src/drivers/wifi/generic/Makefile.inc rename to src/drivers/wifi/generic/Makefile.mk diff --git a/src/drivers/wwan/fm/Makefile.inc b/src/drivers/wwan/fm/Makefile.mk similarity index 100% rename from src/drivers/wwan/fm/Makefile.inc rename to src/drivers/wwan/fm/Makefile.mk -- To view, visit https://review.coreboot.org/c/coreboot/+/80080?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I8cf3d2e2cd1b6ebe4e941ad64f27698379fef696 Gerrit-Change-Number: 80080 Gerrit-PatchSet: 4 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[NoOp] Change in coreboot[main]: driver/intel to /driver/ocp: Rename Makefiles from .inc to .mk
by Felix Singer (Code Review) 24 Jan '24

24 Jan '24

Felix Singer has submitted this change. ( https://review.coreboot.org/c/coreboot/+/80079?usp=email ) ( 2 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: driver/intel to /driver/ocp: Rename Makefiles from .inc to .mk ...................................................................... driver/intel to /driver/ocp: Rename Makefiles from .inc to .mk The .inc suffix is confusing to various tools as it's not specific to Makefiles. This means that editors don't recognize the files, and don't open them with highlighting and any other specific editor functionality. This issue is also seen in the release notes generation script where Makefiles get renamed before running cloc. Signed-off-by: Martin Roth <gaumless(a)gmail.com> Change-Id: Id47a5ef3c53f767d1e03c788e0022d05b21f5c28 Reviewed-on: https://review.coreboot.org/c/coreboot/+/80079 Reviewed-by: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Maximilian Brune <maximilian.brune(a)9elements.com> --- R src/drivers/intel/dptf/Makefile.mk R src/drivers/intel/fsp1_1/Makefile.mk R src/drivers/intel/fsp2_0/Makefile.mk R src/drivers/intel/fsp2_0/ppi/Makefile.mk R src/drivers/intel/gma/Makefile.mk R src/drivers/intel/i210/Makefile.mk R src/drivers/intel/ish/Makefile.mk R src/drivers/intel/mipi_camera/Makefile.mk R src/drivers/intel/pmc_mux/Makefile.mk R src/drivers/intel/pmc_mux/conn/Makefile.mk R src/drivers/intel/ptt/Makefile.mk R src/drivers/intel/soundwire/Makefile.mk R src/drivers/intel/usb4/retimer/Makefile.mk R src/drivers/ipmi/Makefile.mk R src/drivers/ipmi/ocp/Makefile.mk R src/drivers/lenovo/Makefile.mk R src/drivers/lenovo/hybrid_graphics/Makefile.mk R src/drivers/maxim/max77686/Makefile.mk R src/drivers/mipi/Makefile.mk R src/drivers/mrc_cache/Makefile.mk R src/drivers/net/Makefile.mk R src/drivers/net/phy/m88e1512/Makefile.mk R src/drivers/nxp/uwb/Makefile.mk R src/drivers/ocp/dmi/Makefile.mk R src/drivers/ocp/ewl/Makefile.mk R src/drivers/ocp/vpd/Makefile.mk 26 files changed, 0 insertions(+), 0 deletions(-) Approvals: Maximilian Brune: Looks good to me, approved build bot (Jenkins): Verified Felix Singer: Looks good to me, approved diff --git a/src/drivers/intel/dptf/Makefile.inc b/src/drivers/intel/dptf/Makefile.mk similarity index 100% rename from src/drivers/intel/dptf/Makefile.inc rename to src/drivers/intel/dptf/Makefile.mk diff --git a/src/drivers/intel/fsp1_1/Makefile.inc b/src/drivers/intel/fsp1_1/Makefile.mk similarity index 100% rename from src/drivers/intel/fsp1_1/Makefile.inc rename to src/drivers/intel/fsp1_1/Makefile.mk diff --git a/src/drivers/intel/fsp2_0/Makefile.inc b/src/drivers/intel/fsp2_0/Makefile.mk similarity index 100% rename from src/drivers/intel/fsp2_0/Makefile.inc rename to src/drivers/intel/fsp2_0/Makefile.mk diff --git a/src/drivers/intel/fsp2_0/ppi/Makefile.inc b/src/drivers/intel/fsp2_0/ppi/Makefile.mk similarity index 100% rename from src/drivers/intel/fsp2_0/ppi/Makefile.inc rename to src/drivers/intel/fsp2_0/ppi/Makefile.mk diff --git a/src/drivers/intel/gma/Makefile.inc b/src/drivers/intel/gma/Makefile.mk similarity index 100% rename from src/drivers/intel/gma/Makefile.inc rename to src/drivers/intel/gma/Makefile.mk diff --git a/src/drivers/intel/i210/Makefile.inc b/src/drivers/intel/i210/Makefile.mk similarity index 100% rename from src/drivers/intel/i210/Makefile.inc rename to src/drivers/intel/i210/Makefile.mk diff --git a/src/drivers/intel/ish/Makefile.inc b/src/drivers/intel/ish/Makefile.mk similarity index 100% rename from src/drivers/intel/ish/Makefile.inc rename to src/drivers/intel/ish/Makefile.mk diff --git a/src/drivers/intel/mipi_camera/Makefile.inc b/src/drivers/intel/mipi_camera/Makefile.mk similarity index 100% rename from src/drivers/intel/mipi_camera/Makefile.inc rename to src/drivers/intel/mipi_camera/Makefile.mk diff --git a/src/drivers/intel/pmc_mux/Makefile.inc b/src/drivers/intel/pmc_mux/Makefile.mk similarity index 100% rename from src/drivers/intel/pmc_mux/Makefile.inc rename to src/drivers/intel/pmc_mux/Makefile.mk diff --git a/src/drivers/intel/pmc_mux/conn/Makefile.inc b/src/drivers/intel/pmc_mux/conn/Makefile.mk similarity index 100% rename from src/drivers/intel/pmc_mux/conn/Makefile.inc rename to src/drivers/intel/pmc_mux/conn/Makefile.mk diff --git a/src/drivers/intel/ptt/Makefile.inc b/src/drivers/intel/ptt/Makefile.mk similarity index 100% rename from src/drivers/intel/ptt/Makefile.inc rename to src/drivers/intel/ptt/Makefile.mk diff --git a/src/drivers/intel/soundwire/Makefile.inc b/src/drivers/intel/soundwire/Makefile.mk similarity index 100% rename from src/drivers/intel/soundwire/Makefile.inc rename to src/drivers/intel/soundwire/Makefile.mk diff --git a/src/drivers/intel/usb4/retimer/Makefile.inc b/src/drivers/intel/usb4/retimer/Makefile.mk similarity index 100% rename from src/drivers/intel/usb4/retimer/Makefile.inc rename to src/drivers/intel/usb4/retimer/Makefile.mk diff --git a/src/drivers/ipmi/Makefile.inc b/src/drivers/ipmi/Makefile.mk similarity index 100% rename from src/drivers/ipmi/Makefile.inc rename to src/drivers/ipmi/Makefile.mk diff --git a/src/drivers/ipmi/ocp/Makefile.inc b/src/drivers/ipmi/ocp/Makefile.mk similarity index 100% rename from src/drivers/ipmi/ocp/Makefile.inc rename to src/drivers/ipmi/ocp/Makefile.mk diff --git a/src/drivers/lenovo/Makefile.inc b/src/drivers/lenovo/Makefile.mk similarity index 100% rename from src/drivers/lenovo/Makefile.inc rename to src/drivers/lenovo/Makefile.mk diff --git a/src/drivers/lenovo/hybrid_graphics/Makefile.inc b/src/drivers/lenovo/hybrid_graphics/Makefile.mk similarity index 100% rename from src/drivers/lenovo/hybrid_graphics/Makefile.inc rename to src/drivers/lenovo/hybrid_graphics/Makefile.mk diff --git a/src/drivers/maxim/max77686/Makefile.inc b/src/drivers/maxim/max77686/Makefile.mk similarity index 100% rename from src/drivers/maxim/max77686/Makefile.inc rename to src/drivers/maxim/max77686/Makefile.mk diff --git a/src/drivers/mipi/Makefile.inc b/src/drivers/mipi/Makefile.mk similarity index 100% rename from src/drivers/mipi/Makefile.inc rename to src/drivers/mipi/Makefile.mk diff --git a/src/drivers/mrc_cache/Makefile.inc b/src/drivers/mrc_cache/Makefile.mk similarity index 100% rename from src/drivers/mrc_cache/Makefile.inc rename to src/drivers/mrc_cache/Makefile.mk diff --git a/src/drivers/net/Makefile.inc b/src/drivers/net/Makefile.mk similarity index 100% rename from src/drivers/net/Makefile.inc rename to src/drivers/net/Makefile.mk diff --git a/src/drivers/net/phy/m88e1512/Makefile.inc b/src/drivers/net/phy/m88e1512/Makefile.mk similarity index 100% rename from src/drivers/net/phy/m88e1512/Makefile.inc rename to src/drivers/net/phy/m88e1512/Makefile.mk diff --git a/src/drivers/nxp/uwb/Makefile.inc b/src/drivers/nxp/uwb/Makefile.mk similarity index 100% rename from src/drivers/nxp/uwb/Makefile.inc rename to src/drivers/nxp/uwb/Makefile.mk diff --git a/src/drivers/ocp/dmi/Makefile.inc b/src/drivers/ocp/dmi/Makefile.mk similarity index 100% rename from src/drivers/ocp/dmi/Makefile.inc rename to src/drivers/ocp/dmi/Makefile.mk diff --git a/src/drivers/ocp/ewl/Makefile.inc b/src/drivers/ocp/ewl/Makefile.mk similarity index 100% rename from src/drivers/ocp/ewl/Makefile.inc rename to src/drivers/ocp/ewl/Makefile.mk diff --git a/src/drivers/ocp/vpd/Makefile.inc b/src/drivers/ocp/vpd/Makefile.mk similarity index 100% rename from src/drivers/ocp/vpd/Makefile.inc rename to src/drivers/ocp/vpd/Makefile.mk -- To view, visit https://review.coreboot.org/c/coreboot/+/80079?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Id47a5ef3c53f767d1e03c788e0022d05b21f5c28 Gerrit-Change-Number: 80079 Gerrit-PatchSet: 4 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[NoOp] Change in coreboot[main]: driver/i2c: Rename Makefiles from .inc to .mk
by Felix Singer (Code Review) 24 Jan '24

24 Jan '24

Felix Singer has submitted this change. ( https://review.coreboot.org/c/coreboot/+/80078?usp=email ) ( 2 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: driver/i2c: Rename Makefiles from .inc to .mk ...................................................................... driver/i2c: Rename Makefiles from .inc to .mk The .inc suffix is confusing to various tools as it's not specific to Makefiles. This means that editors don't recognize the files, and don't open them with highlighting and any other specific editor functionality. This issue is also seen in the release notes generation script where Makefiles get renamed before running cloc. Signed-off-by: Martin Roth <gaumless(a)gmail.com> Change-Id: I358b878b97adfd9be156a5dd4a9cbaf9e81bca1a Reviewed-on: https://review.coreboot.org/c/coreboot/+/80078 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Reviewed-by: Maximilian Brune <maximilian.brune(a)9elements.com> --- R src/drivers/i2c/at24rf08c/Makefile.mk R src/drivers/i2c/ck505/Makefile.mk R src/drivers/i2c/cs35l53/Makefile.mk R src/drivers/i2c/cs42l42/Makefile.mk R src/drivers/i2c/da7219/Makefile.mk R src/drivers/i2c/designware/Makefile.mk R src/drivers/i2c/generic/Makefile.mk R src/drivers/i2c/gpiomux/Makefile.mk R src/drivers/i2c/gpiomux/bus/Makefile.mk R src/drivers/i2c/gpiomux/mux/Makefile.mk R src/drivers/i2c/hid/Makefile.mk R src/drivers/i2c/lm96000/Makefile.mk R src/drivers/i2c/max98373/Makefile.mk R src/drivers/i2c/max98390/Makefile.mk R src/drivers/i2c/max98396/Makefile.mk R src/drivers/i2c/max98927/Makefile.mk R src/drivers/i2c/nau8825/Makefile.mk R src/drivers/i2c/nct7802y/Makefile.mk R src/drivers/i2c/pca9538/Makefile.mk R src/drivers/i2c/pcf8523/Makefile.mk R src/drivers/i2c/pi608gp/Makefile.mk R src/drivers/i2c/ptn3460/Makefile.mk R src/drivers/i2c/rt1011/Makefile.mk R src/drivers/i2c/rt5663/Makefile.mk R src/drivers/i2c/rtd2132/Makefile.mk R src/drivers/i2c/rv3028c7/Makefile.mk R src/drivers/i2c/rx6110sa/Makefile.mk R src/drivers/i2c/sx9310/Makefile.mk R src/drivers/i2c/sx9324/Makefile.mk R src/drivers/i2c/sx9360/Makefile.mk R src/drivers/i2c/tas5825m/Makefile.mk R src/drivers/i2c/tpm/Makefile.mk R src/drivers/i2c/ww_ring/Makefile.mk 33 files changed, 0 insertions(+), 0 deletions(-) Approvals: Felix Singer: Looks good to me, approved Maximilian Brune: Looks good to me, approved build bot (Jenkins): Verified diff --git a/src/drivers/i2c/at24rf08c/Makefile.inc b/src/drivers/i2c/at24rf08c/Makefile.mk similarity index 100% rename from src/drivers/i2c/at24rf08c/Makefile.inc rename to src/drivers/i2c/at24rf08c/Makefile.mk diff --git a/src/drivers/i2c/ck505/Makefile.inc b/src/drivers/i2c/ck505/Makefile.mk similarity index 100% rename from src/drivers/i2c/ck505/Makefile.inc rename to src/drivers/i2c/ck505/Makefile.mk diff --git a/src/drivers/i2c/cs35l53/Makefile.inc b/src/drivers/i2c/cs35l53/Makefile.mk similarity index 100% rename from src/drivers/i2c/cs35l53/Makefile.inc rename to src/drivers/i2c/cs35l53/Makefile.mk diff --git a/src/drivers/i2c/cs42l42/Makefile.inc b/src/drivers/i2c/cs42l42/Makefile.mk similarity index 100% rename from src/drivers/i2c/cs42l42/Makefile.inc rename to src/drivers/i2c/cs42l42/Makefile.mk diff --git a/src/drivers/i2c/da7219/Makefile.inc b/src/drivers/i2c/da7219/Makefile.mk similarity index 100% rename from src/drivers/i2c/da7219/Makefile.inc rename to src/drivers/i2c/da7219/Makefile.mk diff --git a/src/drivers/i2c/designware/Makefile.inc b/src/drivers/i2c/designware/Makefile.mk similarity index 100% rename from src/drivers/i2c/designware/Makefile.inc rename to src/drivers/i2c/designware/Makefile.mk diff --git a/src/drivers/i2c/generic/Makefile.inc b/src/drivers/i2c/generic/Makefile.mk similarity index 100% rename from src/drivers/i2c/generic/Makefile.inc rename to src/drivers/i2c/generic/Makefile.mk diff --git a/src/drivers/i2c/gpiomux/Makefile.inc b/src/drivers/i2c/gpiomux/Makefile.mk similarity index 100% rename from src/drivers/i2c/gpiomux/Makefile.inc rename to src/drivers/i2c/gpiomux/Makefile.mk diff --git a/src/drivers/i2c/gpiomux/bus/Makefile.inc b/src/drivers/i2c/gpiomux/bus/Makefile.mk similarity index 100% rename from src/drivers/i2c/gpiomux/bus/Makefile.inc rename to src/drivers/i2c/gpiomux/bus/Makefile.mk diff --git a/src/drivers/i2c/gpiomux/mux/Makefile.inc b/src/drivers/i2c/gpiomux/mux/Makefile.mk similarity index 100% rename from src/drivers/i2c/gpiomux/mux/Makefile.inc rename to src/drivers/i2c/gpiomux/mux/Makefile.mk diff --git a/src/drivers/i2c/hid/Makefile.inc b/src/drivers/i2c/hid/Makefile.mk similarity index 100% rename from src/drivers/i2c/hid/Makefile.inc rename to src/drivers/i2c/hid/Makefile.mk diff --git a/src/drivers/i2c/lm96000/Makefile.inc b/src/drivers/i2c/lm96000/Makefile.mk similarity index 100% rename from src/drivers/i2c/lm96000/Makefile.inc rename to src/drivers/i2c/lm96000/Makefile.mk diff --git a/src/drivers/i2c/max98373/Makefile.inc b/src/drivers/i2c/max98373/Makefile.mk similarity index 100% rename from src/drivers/i2c/max98373/Makefile.inc rename to src/drivers/i2c/max98373/Makefile.mk diff --git a/src/drivers/i2c/max98390/Makefile.inc b/src/drivers/i2c/max98390/Makefile.mk similarity index 100% rename from src/drivers/i2c/max98390/Makefile.inc rename to src/drivers/i2c/max98390/Makefile.mk diff --git a/src/drivers/i2c/max98396/Makefile.inc b/src/drivers/i2c/max98396/Makefile.mk similarity index 100% rename from src/drivers/i2c/max98396/Makefile.inc rename to src/drivers/i2c/max98396/Makefile.mk diff --git a/src/drivers/i2c/max98927/Makefile.inc b/src/drivers/i2c/max98927/Makefile.mk similarity index 100% rename from src/drivers/i2c/max98927/Makefile.inc rename to src/drivers/i2c/max98927/Makefile.mk diff --git a/src/drivers/i2c/nau8825/Makefile.inc b/src/drivers/i2c/nau8825/Makefile.mk similarity index 100% rename from src/drivers/i2c/nau8825/Makefile.inc rename to src/drivers/i2c/nau8825/Makefile.mk diff --git a/src/drivers/i2c/nct7802y/Makefile.inc b/src/drivers/i2c/nct7802y/Makefile.mk similarity index 100% rename from src/drivers/i2c/nct7802y/Makefile.inc rename to src/drivers/i2c/nct7802y/Makefile.mk diff --git a/src/drivers/i2c/pca9538/Makefile.inc b/src/drivers/i2c/pca9538/Makefile.mk similarity index 100% rename from src/drivers/i2c/pca9538/Makefile.inc rename to src/drivers/i2c/pca9538/Makefile.mk diff --git a/src/drivers/i2c/pcf8523/Makefile.inc b/src/drivers/i2c/pcf8523/Makefile.mk similarity index 100% rename from src/drivers/i2c/pcf8523/Makefile.inc rename to src/drivers/i2c/pcf8523/Makefile.mk diff --git a/src/drivers/i2c/pi608gp/Makefile.inc b/src/drivers/i2c/pi608gp/Makefile.mk similarity index 100% rename from src/drivers/i2c/pi608gp/Makefile.inc rename to src/drivers/i2c/pi608gp/Makefile.mk diff --git a/src/drivers/i2c/ptn3460/Makefile.inc b/src/drivers/i2c/ptn3460/Makefile.mk similarity index 100% rename from src/drivers/i2c/ptn3460/Makefile.inc rename to src/drivers/i2c/ptn3460/Makefile.mk diff --git a/src/drivers/i2c/rt1011/Makefile.inc b/src/drivers/i2c/rt1011/Makefile.mk similarity index 100% rename from src/drivers/i2c/rt1011/Makefile.inc rename to src/drivers/i2c/rt1011/Makefile.mk diff --git a/src/drivers/i2c/rt5663/Makefile.inc b/src/drivers/i2c/rt5663/Makefile.mk similarity index 100% rename from src/drivers/i2c/rt5663/Makefile.inc rename to src/drivers/i2c/rt5663/Makefile.mk diff --git a/src/drivers/i2c/rtd2132/Makefile.inc b/src/drivers/i2c/rtd2132/Makefile.mk similarity index 100% rename from src/drivers/i2c/rtd2132/Makefile.inc rename to src/drivers/i2c/rtd2132/Makefile.mk diff --git a/src/drivers/i2c/rv3028c7/Makefile.inc b/src/drivers/i2c/rv3028c7/Makefile.mk similarity index 100% rename from src/drivers/i2c/rv3028c7/Makefile.inc rename to src/drivers/i2c/rv3028c7/Makefile.mk diff --git a/src/drivers/i2c/rx6110sa/Makefile.inc b/src/drivers/i2c/rx6110sa/Makefile.mk similarity index 100% rename from src/drivers/i2c/rx6110sa/Makefile.inc rename to src/drivers/i2c/rx6110sa/Makefile.mk diff --git a/src/drivers/i2c/sx9310/Makefile.inc b/src/drivers/i2c/sx9310/Makefile.mk similarity index 100% rename from src/drivers/i2c/sx9310/Makefile.inc rename to src/drivers/i2c/sx9310/Makefile.mk diff --git a/src/drivers/i2c/sx9324/Makefile.inc b/src/drivers/i2c/sx9324/Makefile.mk similarity index 100% rename from src/drivers/i2c/sx9324/Makefile.inc rename to src/drivers/i2c/sx9324/Makefile.mk diff --git a/src/drivers/i2c/sx9360/Makefile.inc b/src/drivers/i2c/sx9360/Makefile.mk similarity index 100% rename from src/drivers/i2c/sx9360/Makefile.inc rename to src/drivers/i2c/sx9360/Makefile.mk diff --git a/src/drivers/i2c/tas5825m/Makefile.inc b/src/drivers/i2c/tas5825m/Makefile.mk similarity index 100% rename from src/drivers/i2c/tas5825m/Makefile.inc rename to src/drivers/i2c/tas5825m/Makefile.mk diff --git a/src/drivers/i2c/tpm/Makefile.inc b/src/drivers/i2c/tpm/Makefile.mk similarity index 100% rename from src/drivers/i2c/tpm/Makefile.inc rename to src/drivers/i2c/tpm/Makefile.mk diff --git a/src/drivers/i2c/ww_ring/Makefile.inc b/src/drivers/i2c/ww_ring/Makefile.mk similarity index 100% rename from src/drivers/i2c/ww_ring/Makefile.inc rename to src/drivers/i2c/ww_ring/Makefile.mk -- To view, visit https://review.coreboot.org/c/coreboot/+/80078?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I358b878b97adfd9be156a5dd4a9cbaf9e81bca1a Gerrit-Change-Number: 80078 Gerrit-PatchSet: 4 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Jeremy Soller <jeremy(a)system76.com> Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Tim Crawford <tcrawford(a)system76.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[NoOp] Change in coreboot[main]: driver/acpi to /driver/gfx: Rename Makefiles from .inc to .mk
by Felix Singer (Code Review) 24 Jan '24

24 Jan '24

Felix Singer has submitted this change. ( https://review.coreboot.org/c/coreboot/+/80077?usp=email ) ( 2 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: driver/acpi to /driver/gfx: Rename Makefiles from .inc to .mk ...................................................................... driver/acpi to /driver/gfx: Rename Makefiles from .inc to .mk The .inc suffix is confusing to various tools as it's not specific to Makefiles. This means that editors don't recognize the files, and don't open them with highlighting and any other specific editor functionality. This issue is also seen in the release notes generation script where Makefiles get renamed before running cloc. Signed-off-by: Martin Roth <gaumless(a)gmail.com> Change-Id: I2f299920eb7c6d6f8888cfe5e223ae03093a1d88 Reviewed-on: https://review.coreboot.org/c/coreboot/+/80077 Reviewed-by: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Michael Niewöhner <foss(a)mniewoehner.de> Reviewed-by: Maximilian Brune <maximilian.brune(a)9elements.com> --- R src/drivers/acpi/thermal_zone/Makefile.mk R src/drivers/amd/agesa/Makefile.mk R src/drivers/amd/i2s_machine_dev/Makefile.mk R src/drivers/ams/Makefile.mk R src/drivers/analogix/anx7625/Makefile.mk R src/drivers/asmedia/Makefile.mk R src/drivers/aspeed/ast2050/Makefile.mk R src/drivers/aspeed/common/Makefile.mk R src/drivers/broadcom/Makefile.mk R src/drivers/camera/Makefile.mk R src/drivers/crb/Makefile.mk R src/drivers/efi/Makefile.mk R src/drivers/elog/Makefile.mk R src/drivers/emulation/qemu/Makefile.mk R src/drivers/generic/adau7002/Makefile.mk R src/drivers/generic/alc1015/Makefile.mk R src/drivers/generic/bayhub/Makefile.mk R src/drivers/generic/bayhub_lv2/Makefile.mk R src/drivers/generic/cbfs-serial/Makefile.mk R src/drivers/generic/cbfs-uuid/Makefile.mk R src/drivers/generic/gpio_keys/Makefile.mk R src/drivers/generic/max98357a/Makefile.mk R src/drivers/generic/nau8315/Makefile.mk R src/drivers/genesyslogic/gl9750/Makefile.mk R src/drivers/genesyslogic/gl9755/Makefile.mk R src/drivers/genesyslogic/gl9763e/Makefile.mk R src/drivers/gfx/generic/Makefile.mk 27 files changed, 0 insertions(+), 0 deletions(-) Approvals: build bot (Jenkins): Verified Maximilian Brune: Looks good to me, approved Michael Niewöhner: Looks good to me, approved Felix Singer: Looks good to me, approved diff --git a/src/drivers/acpi/thermal_zone/Makefile.inc b/src/drivers/acpi/thermal_zone/Makefile.mk similarity index 100% rename from src/drivers/acpi/thermal_zone/Makefile.inc rename to src/drivers/acpi/thermal_zone/Makefile.mk diff --git a/src/drivers/amd/agesa/Makefile.inc b/src/drivers/amd/agesa/Makefile.mk similarity index 100% rename from src/drivers/amd/agesa/Makefile.inc rename to src/drivers/amd/agesa/Makefile.mk diff --git a/src/drivers/amd/i2s_machine_dev/Makefile.inc b/src/drivers/amd/i2s_machine_dev/Makefile.mk similarity index 100% rename from src/drivers/amd/i2s_machine_dev/Makefile.inc rename to src/drivers/amd/i2s_machine_dev/Makefile.mk diff --git a/src/drivers/ams/Makefile.inc b/src/drivers/ams/Makefile.mk similarity index 100% rename from src/drivers/ams/Makefile.inc rename to src/drivers/ams/Makefile.mk diff --git a/src/drivers/analogix/anx7625/Makefile.inc b/src/drivers/analogix/anx7625/Makefile.mk similarity index 100% rename from src/drivers/analogix/anx7625/Makefile.inc rename to src/drivers/analogix/anx7625/Makefile.mk diff --git a/src/drivers/asmedia/Makefile.inc b/src/drivers/asmedia/Makefile.mk similarity index 100% rename from src/drivers/asmedia/Makefile.inc rename to src/drivers/asmedia/Makefile.mk diff --git a/src/drivers/aspeed/ast2050/Makefile.inc b/src/drivers/aspeed/ast2050/Makefile.mk similarity index 100% rename from src/drivers/aspeed/ast2050/Makefile.inc rename to src/drivers/aspeed/ast2050/Makefile.mk diff --git a/src/drivers/aspeed/common/Makefile.inc b/src/drivers/aspeed/common/Makefile.mk similarity index 100% rename from src/drivers/aspeed/common/Makefile.inc rename to src/drivers/aspeed/common/Makefile.mk diff --git a/src/drivers/broadcom/Makefile.inc b/src/drivers/broadcom/Makefile.mk similarity index 100% rename from src/drivers/broadcom/Makefile.inc rename to src/drivers/broadcom/Makefile.mk diff --git a/src/drivers/camera/Makefile.inc b/src/drivers/camera/Makefile.mk similarity index 100% rename from src/drivers/camera/Makefile.inc rename to src/drivers/camera/Makefile.mk diff --git a/src/drivers/crb/Makefile.inc b/src/drivers/crb/Makefile.mk similarity index 100% rename from src/drivers/crb/Makefile.inc rename to src/drivers/crb/Makefile.mk diff --git a/src/drivers/efi/Makefile.inc b/src/drivers/efi/Makefile.mk similarity index 100% rename from src/drivers/efi/Makefile.inc rename to src/drivers/efi/Makefile.mk diff --git a/src/drivers/elog/Makefile.inc b/src/drivers/elog/Makefile.mk similarity index 100% rename from src/drivers/elog/Makefile.inc rename to src/drivers/elog/Makefile.mk diff --git a/src/drivers/emulation/qemu/Makefile.inc b/src/drivers/emulation/qemu/Makefile.mk similarity index 100% rename from src/drivers/emulation/qemu/Makefile.inc rename to src/drivers/emulation/qemu/Makefile.mk diff --git a/src/drivers/generic/adau7002/Makefile.inc b/src/drivers/generic/adau7002/Makefile.mk similarity index 100% rename from src/drivers/generic/adau7002/Makefile.inc rename to src/drivers/generic/adau7002/Makefile.mk diff --git a/src/drivers/generic/alc1015/Makefile.inc b/src/drivers/generic/alc1015/Makefile.mk similarity index 100% rename from src/drivers/generic/alc1015/Makefile.inc rename to src/drivers/generic/alc1015/Makefile.mk diff --git a/src/drivers/generic/bayhub/Makefile.inc b/src/drivers/generic/bayhub/Makefile.mk similarity index 100% rename from src/drivers/generic/bayhub/Makefile.inc rename to src/drivers/generic/bayhub/Makefile.mk diff --git a/src/drivers/generic/bayhub_lv2/Makefile.inc b/src/drivers/generic/bayhub_lv2/Makefile.mk similarity index 100% rename from src/drivers/generic/bayhub_lv2/Makefile.inc rename to src/drivers/generic/bayhub_lv2/Makefile.mk diff --git a/src/drivers/generic/cbfs-serial/Makefile.inc b/src/drivers/generic/cbfs-serial/Makefile.mk similarity index 100% rename from src/drivers/generic/cbfs-serial/Makefile.inc rename to src/drivers/generic/cbfs-serial/Makefile.mk diff --git a/src/drivers/generic/cbfs-uuid/Makefile.inc b/src/drivers/generic/cbfs-uuid/Makefile.mk similarity index 100% rename from src/drivers/generic/cbfs-uuid/Makefile.inc rename to src/drivers/generic/cbfs-uuid/Makefile.mk diff --git a/src/drivers/generic/gpio_keys/Makefile.inc b/src/drivers/generic/gpio_keys/Makefile.mk similarity index 100% rename from src/drivers/generic/gpio_keys/Makefile.inc rename to src/drivers/generic/gpio_keys/Makefile.mk diff --git a/src/drivers/generic/max98357a/Makefile.inc b/src/drivers/generic/max98357a/Makefile.mk similarity index 100% rename from src/drivers/generic/max98357a/Makefile.inc rename to src/drivers/generic/max98357a/Makefile.mk diff --git a/src/drivers/generic/nau8315/Makefile.inc b/src/drivers/generic/nau8315/Makefile.mk similarity index 100% rename from src/drivers/generic/nau8315/Makefile.inc rename to src/drivers/generic/nau8315/Makefile.mk diff --git a/src/drivers/genesyslogic/gl9750/Makefile.inc b/src/drivers/genesyslogic/gl9750/Makefile.mk similarity index 100% rename from src/drivers/genesyslogic/gl9750/Makefile.inc rename to src/drivers/genesyslogic/gl9750/Makefile.mk diff --git a/src/drivers/genesyslogic/gl9755/Makefile.inc b/src/drivers/genesyslogic/gl9755/Makefile.mk similarity index 100% rename from src/drivers/genesyslogic/gl9755/Makefile.inc rename to src/drivers/genesyslogic/gl9755/Makefile.mk diff --git a/src/drivers/genesyslogic/gl9763e/Makefile.inc b/src/drivers/genesyslogic/gl9763e/Makefile.mk similarity index 100% rename from src/drivers/genesyslogic/gl9763e/Makefile.inc rename to src/drivers/genesyslogic/gl9763e/Makefile.mk diff --git a/src/drivers/gfx/generic/Makefile.inc b/src/drivers/gfx/generic/Makefile.mk similarity index 100% rename from src/drivers/gfx/generic/Makefile.inc rename to src/drivers/gfx/generic/Makefile.mk -- To view, visit https://review.coreboot.org/c/coreboot/+/80077?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I2f299920eb7c6d6f8888cfe5e223ae03093a1d88 Gerrit-Change-Number: 80077 Gerrit-PatchSet: 4 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[NoOp] Change in coreboot[main]: superio: Rename Makefiles from .inc to .mk
by Felix Singer (Code Review) 24 Jan '24

24 Jan '24

Felix Singer has submitted this change. ( https://review.coreboot.org/c/coreboot/+/80076?usp=email ) ( 2 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: superio: Rename Makefiles from .inc to .mk ...................................................................... superio: Rename Makefiles from .inc to .mk The .inc suffix is confusing to various tools as it's not specific to Makefiles. This means that editors don't recognize the files, and don't open them with highlighting and any other specific editor functionality. This issue is also seen in the release notes generation script where Makefiles get renamed before running cloc. Signed-off-by: Martin Roth <gaumless(a)gmail.com> Change-Id: I41191f6971bdd8ecff2c56f4bfa2b57c87530b83 Reviewed-on: https://review.coreboot.org/c/coreboot/+/80076 Reviewed-by: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Maximilian Brune <maximilian.brune(a)9elements.com> Reviewed-by: Michael Niewöhner <foss(a)mniewoehner.de> --- R src/superio/aspeed/Makefile.mk R src/superio/aspeed/ast2400/Makefile.mk R src/superio/common/Makefile.mk R src/superio/fintek/Makefile.mk R src/superio/fintek/f71808a/Makefile.mk R src/superio/fintek/f71859/Makefile.mk R src/superio/fintek/f71863fg/Makefile.mk R src/superio/fintek/f71869ad/Makefile.mk R src/superio/fintek/f81803a/Makefile.mk R src/superio/fintek/f81865f/Makefile.mk R src/superio/fintek/f81866d/Makefile.mk R src/superio/ite/Makefile.mk R src/superio/ite/it8528e/Makefile.mk R src/superio/ite/it8613e/Makefile.mk R src/superio/ite/it8623e/Makefile.mk R src/superio/ite/it8712f/Makefile.mk R src/superio/ite/it8718f/Makefile.mk R src/superio/ite/it8720f/Makefile.mk R src/superio/ite/it8721f/Makefile.mk R src/superio/ite/it8728f/Makefile.mk R src/superio/ite/it8772f/Makefile.mk R src/superio/ite/it8783ef/Makefile.mk R src/superio/ite/it8784e/Makefile.mk R src/superio/ite/it8786e/Makefile.mk R src/superio/nsc/Makefile.mk R src/superio/nsc/pc87382/Makefile.mk R src/superio/nsc/pc87384/Makefile.mk R src/superio/nsc/pc87392/Makefile.mk R src/superio/nsc/pc87417/Makefile.mk R src/superio/nuvoton/Makefile.mk R src/superio/nuvoton/nct5104d/Makefile.mk R src/superio/nuvoton/nct5539d/Makefile.mk R src/superio/nuvoton/nct5572d/Makefile.mk R src/superio/nuvoton/nct6687d/Makefile.mk R src/superio/nuvoton/nct6776/Makefile.mk R src/superio/nuvoton/nct6779d/Makefile.mk R src/superio/nuvoton/nct6791d/Makefile.mk R src/superio/nuvoton/npcd378/Makefile.mk R src/superio/nuvoton/wpcm450/Makefile.mk R src/superio/renesas/Makefile.mk R src/superio/renesas/m3885x/Makefile.mk R src/superio/smsc/Makefile.mk R src/superio/smsc/fdc37n972/Makefile.mk R src/superio/smsc/kbc1100/Makefile.mk R src/superio/smsc/lpc47m10x/Makefile.mk R src/superio/smsc/lpc47m15x/Makefile.mk R src/superio/smsc/lpc47n207/Makefile.mk R src/superio/smsc/lpc47n217/Makefile.mk R src/superio/smsc/lpc47n227/Makefile.mk R src/superio/smsc/mec1308/Makefile.mk R src/superio/smsc/sch5545/Makefile.mk R src/superio/smsc/sch555x/Makefile.mk R src/superio/smsc/sio1007/Makefile.mk R src/superio/smsc/sio1036/Makefile.mk R src/superio/smsc/sio10n268/Makefile.mk R src/superio/smsc/smscsuperio/Makefile.mk R src/superio/winbond/Makefile.mk R src/superio/winbond/w83627dhg/Makefile.mk R src/superio/winbond/w83627ehg/Makefile.mk R src/superio/winbond/w83627hf/Makefile.mk R src/superio/winbond/w83627thg/Makefile.mk R src/superio/winbond/w83627uhg/Makefile.mk R src/superio/winbond/w83667hg-a/Makefile.mk R src/superio/winbond/w83977tf/Makefile.mk R src/superio/winbond/wpcd376i/Makefile.mk 65 files changed, 0 insertions(+), 0 deletions(-) Approvals: build bot (Jenkins): Verified Michael Niewöhner: Looks good to me, approved Maximilian Brune: Looks good to me, approved Felix Singer: Looks good to me, approved diff --git a/src/superio/aspeed/Makefile.inc b/src/superio/aspeed/Makefile.mk similarity index 100% rename from src/superio/aspeed/Makefile.inc rename to src/superio/aspeed/Makefile.mk diff --git a/src/superio/aspeed/ast2400/Makefile.inc b/src/superio/aspeed/ast2400/Makefile.mk similarity index 100% rename from src/superio/aspeed/ast2400/Makefile.inc rename to src/superio/aspeed/ast2400/Makefile.mk diff --git a/src/superio/common/Makefile.inc b/src/superio/common/Makefile.mk similarity index 100% rename from src/superio/common/Makefile.inc rename to src/superio/common/Makefile.mk diff --git a/src/superio/fintek/Makefile.inc b/src/superio/fintek/Makefile.mk similarity index 100% rename from src/superio/fintek/Makefile.inc rename to src/superio/fintek/Makefile.mk diff --git a/src/superio/fintek/f71808a/Makefile.inc b/src/superio/fintek/f71808a/Makefile.mk similarity index 100% rename from src/superio/fintek/f71808a/Makefile.inc rename to src/superio/fintek/f71808a/Makefile.mk diff --git a/src/superio/fintek/f71859/Makefile.inc b/src/superio/fintek/f71859/Makefile.mk similarity index 100% rename from src/superio/fintek/f71859/Makefile.inc rename to src/superio/fintek/f71859/Makefile.mk diff --git a/src/superio/fintek/f71863fg/Makefile.inc b/src/superio/fintek/f71863fg/Makefile.mk similarity index 100% rename from src/superio/fintek/f71863fg/Makefile.inc rename to src/superio/fintek/f71863fg/Makefile.mk diff --git a/src/superio/fintek/f71869ad/Makefile.inc b/src/superio/fintek/f71869ad/Makefile.mk similarity index 100% rename from src/superio/fintek/f71869ad/Makefile.inc rename to src/superio/fintek/f71869ad/Makefile.mk diff --git a/src/superio/fintek/f81803a/Makefile.inc b/src/superio/fintek/f81803a/Makefile.mk similarity index 100% rename from src/superio/fintek/f81803a/Makefile.inc rename to src/superio/fintek/f81803a/Makefile.mk diff --git a/src/superio/fintek/f81865f/Makefile.inc b/src/superio/fintek/f81865f/Makefile.mk similarity index 100% rename from src/superio/fintek/f81865f/Makefile.inc rename to src/superio/fintek/f81865f/Makefile.mk diff --git a/src/superio/fintek/f81866d/Makefile.inc b/src/superio/fintek/f81866d/Makefile.mk similarity index 100% rename from src/superio/fintek/f81866d/Makefile.inc rename to src/superio/fintek/f81866d/Makefile.mk diff --git a/src/superio/ite/Makefile.inc b/src/superio/ite/Makefile.mk similarity index 100% rename from src/superio/ite/Makefile.inc rename to src/superio/ite/Makefile.mk diff --git a/src/superio/ite/it8528e/Makefile.inc b/src/superio/ite/it8528e/Makefile.mk similarity index 100% rename from src/superio/ite/it8528e/Makefile.inc rename to src/superio/ite/it8528e/Makefile.mk diff --git a/src/superio/ite/it8613e/Makefile.inc b/src/superio/ite/it8613e/Makefile.mk similarity index 100% rename from src/superio/ite/it8613e/Makefile.inc rename to src/superio/ite/it8613e/Makefile.mk diff --git a/src/superio/ite/it8623e/Makefile.inc b/src/superio/ite/it8623e/Makefile.mk similarity index 100% rename from src/superio/ite/it8623e/Makefile.inc rename to src/superio/ite/it8623e/Makefile.mk diff --git a/src/superio/ite/it8712f/Makefile.inc b/src/superio/ite/it8712f/Makefile.mk similarity index 100% rename from src/superio/ite/it8712f/Makefile.inc rename to src/superio/ite/it8712f/Makefile.mk diff --git a/src/superio/ite/it8718f/Makefile.inc b/src/superio/ite/it8718f/Makefile.mk similarity index 100% rename from src/superio/ite/it8718f/Makefile.inc rename to src/superio/ite/it8718f/Makefile.mk diff --git a/src/superio/ite/it8720f/Makefile.inc b/src/superio/ite/it8720f/Makefile.mk similarity index 100% rename from src/superio/ite/it8720f/Makefile.inc rename to src/superio/ite/it8720f/Makefile.mk diff --git a/src/superio/ite/it8721f/Makefile.inc b/src/superio/ite/it8721f/Makefile.mk similarity index 100% rename from src/superio/ite/it8721f/Makefile.inc rename to src/superio/ite/it8721f/Makefile.mk diff --git a/src/superio/ite/it8728f/Makefile.inc b/src/superio/ite/it8728f/Makefile.mk similarity index 100% rename from src/superio/ite/it8728f/Makefile.inc rename to src/superio/ite/it8728f/Makefile.mk diff --git a/src/superio/ite/it8772f/Makefile.inc b/src/superio/ite/it8772f/Makefile.mk similarity index 100% rename from src/superio/ite/it8772f/Makefile.inc rename to src/superio/ite/it8772f/Makefile.mk diff --git a/src/superio/ite/it8783ef/Makefile.inc b/src/superio/ite/it8783ef/Makefile.mk similarity index 100% rename from src/superio/ite/it8783ef/Makefile.inc rename to src/superio/ite/it8783ef/Makefile.mk diff --git a/src/superio/ite/it8784e/Makefile.inc b/src/superio/ite/it8784e/Makefile.mk similarity index 100% rename from src/superio/ite/it8784e/Makefile.inc rename to src/superio/ite/it8784e/Makefile.mk diff --git a/src/superio/ite/it8786e/Makefile.inc b/src/superio/ite/it8786e/Makefile.mk similarity index 100% rename from src/superio/ite/it8786e/Makefile.inc rename to src/superio/ite/it8786e/Makefile.mk diff --git a/src/superio/nsc/Makefile.inc b/src/superio/nsc/Makefile.mk similarity index 100% rename from src/superio/nsc/Makefile.inc rename to src/superio/nsc/Makefile.mk diff --git a/src/superio/nsc/pc87382/Makefile.inc b/src/superio/nsc/pc87382/Makefile.mk similarity index 100% rename from src/superio/nsc/pc87382/Makefile.inc rename to src/superio/nsc/pc87382/Makefile.mk diff --git a/src/superio/nsc/pc87384/Makefile.inc b/src/superio/nsc/pc87384/Makefile.mk similarity index 100% rename from src/superio/nsc/pc87384/Makefile.inc rename to src/superio/nsc/pc87384/Makefile.mk diff --git a/src/superio/nsc/pc87392/Makefile.inc b/src/superio/nsc/pc87392/Makefile.mk similarity index 100% rename from src/superio/nsc/pc87392/Makefile.inc rename to src/superio/nsc/pc87392/Makefile.mk diff --git a/src/superio/nsc/pc87417/Makefile.inc b/src/superio/nsc/pc87417/Makefile.mk similarity index 100% rename from src/superio/nsc/pc87417/Makefile.inc rename to src/superio/nsc/pc87417/Makefile.mk diff --git a/src/superio/nuvoton/Makefile.inc b/src/superio/nuvoton/Makefile.mk similarity index 100% rename from src/superio/nuvoton/Makefile.inc rename to src/superio/nuvoton/Makefile.mk diff --git a/src/superio/nuvoton/nct5104d/Makefile.inc b/src/superio/nuvoton/nct5104d/Makefile.mk similarity index 100% rename from src/superio/nuvoton/nct5104d/Makefile.inc rename to src/superio/nuvoton/nct5104d/Makefile.mk diff --git a/src/superio/nuvoton/nct5539d/Makefile.inc b/src/superio/nuvoton/nct5539d/Makefile.mk similarity index 100% rename from src/superio/nuvoton/nct5539d/Makefile.inc rename to src/superio/nuvoton/nct5539d/Makefile.mk diff --git a/src/superio/nuvoton/nct5572d/Makefile.inc b/src/superio/nuvoton/nct5572d/Makefile.mk similarity index 100% rename from src/superio/nuvoton/nct5572d/Makefile.inc rename to src/superio/nuvoton/nct5572d/Makefile.mk diff --git a/src/superio/nuvoton/nct6687d/Makefile.inc b/src/superio/nuvoton/nct6687d/Makefile.mk similarity index 100% rename from src/superio/nuvoton/nct6687d/Makefile.inc rename to src/superio/nuvoton/nct6687d/Makefile.mk diff --git a/src/superio/nuvoton/nct6776/Makefile.inc b/src/superio/nuvoton/nct6776/Makefile.mk similarity index 100% rename from src/superio/nuvoton/nct6776/Makefile.inc rename to src/superio/nuvoton/nct6776/Makefile.mk diff --git a/src/superio/nuvoton/nct6779d/Makefile.inc b/src/superio/nuvoton/nct6779d/Makefile.mk similarity index 100% rename from src/superio/nuvoton/nct6779d/Makefile.inc rename to src/superio/nuvoton/nct6779d/Makefile.mk diff --git a/src/superio/nuvoton/nct6791d/Makefile.inc b/src/superio/nuvoton/nct6791d/Makefile.mk similarity index 100% rename from src/superio/nuvoton/nct6791d/Makefile.inc rename to src/superio/nuvoton/nct6791d/Makefile.mk diff --git a/src/superio/nuvoton/npcd378/Makefile.inc b/src/superio/nuvoton/npcd378/Makefile.mk similarity index 100% rename from src/superio/nuvoton/npcd378/Makefile.inc rename to src/superio/nuvoton/npcd378/Makefile.mk diff --git a/src/superio/nuvoton/wpcm450/Makefile.inc b/src/superio/nuvoton/wpcm450/Makefile.mk similarity index 100% rename from src/superio/nuvoton/wpcm450/Makefile.inc rename to src/superio/nuvoton/wpcm450/Makefile.mk diff --git a/src/superio/renesas/Makefile.inc b/src/superio/renesas/Makefile.mk similarity index 100% rename from src/superio/renesas/Makefile.inc rename to src/superio/renesas/Makefile.mk diff --git a/src/superio/renesas/m3885x/Makefile.inc b/src/superio/renesas/m3885x/Makefile.mk similarity index 100% rename from src/superio/renesas/m3885x/Makefile.inc rename to src/superio/renesas/m3885x/Makefile.mk diff --git a/src/superio/smsc/Makefile.inc b/src/superio/smsc/Makefile.mk similarity index 100% rename from src/superio/smsc/Makefile.inc rename to src/superio/smsc/Makefile.mk diff --git a/src/superio/smsc/fdc37n972/Makefile.inc b/src/superio/smsc/fdc37n972/Makefile.mk similarity index 100% rename from src/superio/smsc/fdc37n972/Makefile.inc rename to src/superio/smsc/fdc37n972/Makefile.mk diff --git a/src/superio/smsc/kbc1100/Makefile.inc b/src/superio/smsc/kbc1100/Makefile.mk similarity index 100% rename from src/superio/smsc/kbc1100/Makefile.inc rename to src/superio/smsc/kbc1100/Makefile.mk diff --git a/src/superio/smsc/lpc47m10x/Makefile.inc b/src/superio/smsc/lpc47m10x/Makefile.mk similarity index 100% rename from src/superio/smsc/lpc47m10x/Makefile.inc rename to src/superio/smsc/lpc47m10x/Makefile.mk diff --git a/src/superio/smsc/lpc47m15x/Makefile.inc b/src/superio/smsc/lpc47m15x/Makefile.mk similarity index 100% rename from src/superio/smsc/lpc47m15x/Makefile.inc rename to src/superio/smsc/lpc47m15x/Makefile.mk diff --git a/src/superio/smsc/lpc47n207/Makefile.inc b/src/superio/smsc/lpc47n207/Makefile.mk similarity index 100% rename from src/superio/smsc/lpc47n207/Makefile.inc rename to src/superio/smsc/lpc47n207/Makefile.mk diff --git a/src/superio/smsc/lpc47n217/Makefile.inc b/src/superio/smsc/lpc47n217/Makefile.mk similarity index 100% rename from src/superio/smsc/lpc47n217/Makefile.inc rename to src/superio/smsc/lpc47n217/Makefile.mk diff --git a/src/superio/smsc/lpc47n227/Makefile.inc b/src/superio/smsc/lpc47n227/Makefile.mk similarity index 100% rename from src/superio/smsc/lpc47n227/Makefile.inc rename to src/superio/smsc/lpc47n227/Makefile.mk diff --git a/src/superio/smsc/mec1308/Makefile.inc b/src/superio/smsc/mec1308/Makefile.mk similarity index 100% rename from src/superio/smsc/mec1308/Makefile.inc rename to src/superio/smsc/mec1308/Makefile.mk diff --git a/src/superio/smsc/sch5545/Makefile.inc b/src/superio/smsc/sch5545/Makefile.mk similarity index 100% rename from src/superio/smsc/sch5545/Makefile.inc rename to src/superio/smsc/sch5545/Makefile.mk diff --git a/src/superio/smsc/sch555x/Makefile.inc b/src/superio/smsc/sch555x/Makefile.mk similarity index 100% rename from src/superio/smsc/sch555x/Makefile.inc rename to src/superio/smsc/sch555x/Makefile.mk diff --git a/src/superio/smsc/sio1007/Makefile.inc b/src/superio/smsc/sio1007/Makefile.mk similarity index 100% rename from src/superio/smsc/sio1007/Makefile.inc rename to src/superio/smsc/sio1007/Makefile.mk diff --git a/src/superio/smsc/sio1036/Makefile.inc b/src/superio/smsc/sio1036/Makefile.mk similarity index 100% rename from src/superio/smsc/sio1036/Makefile.inc rename to src/superio/smsc/sio1036/Makefile.mk diff --git a/src/superio/smsc/sio10n268/Makefile.inc b/src/superio/smsc/sio10n268/Makefile.mk similarity index 100% rename from src/superio/smsc/sio10n268/Makefile.inc rename to src/superio/smsc/sio10n268/Makefile.mk diff --git a/src/superio/smsc/smscsuperio/Makefile.inc b/src/superio/smsc/smscsuperio/Makefile.mk similarity index 100% rename from src/superio/smsc/smscsuperio/Makefile.inc rename to src/superio/smsc/smscsuperio/Makefile.mk diff --git a/src/superio/winbond/Makefile.inc b/src/superio/winbond/Makefile.mk similarity index 100% rename from src/superio/winbond/Makefile.inc rename to src/superio/winbond/Makefile.mk diff --git a/src/superio/winbond/w83627dhg/Makefile.inc b/src/superio/winbond/w83627dhg/Makefile.mk similarity index 100% rename from src/superio/winbond/w83627dhg/Makefile.inc rename to src/superio/winbond/w83627dhg/Makefile.mk diff --git a/src/superio/winbond/w83627ehg/Makefile.inc b/src/superio/winbond/w83627ehg/Makefile.mk similarity index 100% rename from src/superio/winbond/w83627ehg/Makefile.inc rename to src/superio/winbond/w83627ehg/Makefile.mk diff --git a/src/superio/winbond/w83627hf/Makefile.inc b/src/superio/winbond/w83627hf/Makefile.mk similarity index 100% rename from src/superio/winbond/w83627hf/Makefile.inc rename to src/superio/winbond/w83627hf/Makefile.mk diff --git a/src/superio/winbond/w83627thg/Makefile.inc b/src/superio/winbond/w83627thg/Makefile.mk similarity index 100% rename from src/superio/winbond/w83627thg/Makefile.inc rename to src/superio/winbond/w83627thg/Makefile.mk diff --git a/src/superio/winbond/w83627uhg/Makefile.inc b/src/superio/winbond/w83627uhg/Makefile.mk similarity index 100% rename from src/superio/winbond/w83627uhg/Makefile.inc rename to src/superio/winbond/w83627uhg/Makefile.mk diff --git a/src/superio/winbond/w83667hg-a/Makefile.inc b/src/superio/winbond/w83667hg-a/Makefile.mk similarity index 100% rename from src/superio/winbond/w83667hg-a/Makefile.inc rename to src/superio/winbond/w83667hg-a/Makefile.mk diff --git a/src/superio/winbond/w83977tf/Makefile.inc b/src/superio/winbond/w83977tf/Makefile.mk similarity index 100% rename from src/superio/winbond/w83977tf/Makefile.inc rename to src/superio/winbond/w83977tf/Makefile.mk diff --git a/src/superio/winbond/wpcd376i/Makefile.inc b/src/superio/winbond/wpcd376i/Makefile.mk similarity index 100% rename from src/superio/winbond/wpcd376i/Makefile.inc rename to src/superio/winbond/wpcd376i/Makefile.mk -- To view, visit https://review.coreboot.org/c/coreboot/+/80076?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I41191f6971bdd8ecff2c56f4bfa2b57c87530b83 Gerrit-Change-Number: 80076 Gerrit-PatchSet: 4 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[NoOp] Change in coreboot[main]: southbridge: Rename Makefiles from .inc to .mk
by Felix Singer (Code Review) 24 Jan '24

24 Jan '24

Felix Singer has submitted this change. ( https://review.coreboot.org/c/coreboot/+/80075?usp=email ) ( 2 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: southbridge: Rename Makefiles from .inc to .mk ...................................................................... southbridge: Rename Makefiles from .inc to .mk The .inc suffix is confusing to various tools as it's not specific to Makefiles. This means that editors don't recognize the files, and don't open them with highlighting and any other specific editor functionality. This issue is also seen in the release notes generation script where Makefiles get renamed before running cloc. Signed-off-by: Martin Roth <gaumless(a)gmail.com> Change-Id: Ic80d27a963da8eddc3d1f0d9a3d59763028d4ed0 Reviewed-on: https://review.coreboot.org/c/coreboot/+/80075 Reviewed-by: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Reviewed-by: Maximilian Brune <maximilian.brune(a)9elements.com> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Michael Niewöhner <foss(a)mniewoehner.de> --- R src/southbridge/amd/common/Makefile.mk R src/southbridge/amd/pi/Makefile.mk R src/southbridge/amd/pi/hudson/Makefile.mk R src/southbridge/intel/bd82x6x/Makefile.mk R src/southbridge/intel/common/Makefile.mk R src/southbridge/intel/common/firmware/Makefile.mk R src/southbridge/intel/i82371eb/Makefile.mk R src/southbridge/intel/i82801dx/Makefile.mk R src/southbridge/intel/i82801gx/Makefile.mk R src/southbridge/intel/i82801ix/Makefile.mk R src/southbridge/intel/i82801jx/Makefile.mk R src/southbridge/intel/i82870/Makefile.mk R src/southbridge/intel/ibexpeak/Makefile.mk R src/southbridge/intel/lynxpoint/Makefile.mk R src/southbridge/intel/lynxpoint/hsio/Makefile.mk R src/southbridge/ricoh/rl5c476/Makefile.mk R src/southbridge/ti/pci1x2x/Makefile.mk R src/southbridge/ti/pci7420/Makefile.mk R src/southbridge/ti/pcixx12/Makefile.mk 19 files changed, 0 insertions(+), 0 deletions(-) Approvals: Michael Niewöhner: Looks good to me, approved Maximilian Brune: Looks good to me, approved Felix Singer: Looks good to me, approved build bot (Jenkins): Verified diff --git a/src/southbridge/amd/common/Makefile.inc b/src/southbridge/amd/common/Makefile.mk similarity index 100% rename from src/southbridge/amd/common/Makefile.inc rename to src/southbridge/amd/common/Makefile.mk diff --git a/src/southbridge/amd/pi/Makefile.inc b/src/southbridge/amd/pi/Makefile.mk similarity index 100% rename from src/southbridge/amd/pi/Makefile.inc rename to src/southbridge/amd/pi/Makefile.mk diff --git a/src/southbridge/amd/pi/hudson/Makefile.inc b/src/southbridge/amd/pi/hudson/Makefile.mk similarity index 100% rename from src/southbridge/amd/pi/hudson/Makefile.inc rename to src/southbridge/amd/pi/hudson/Makefile.mk diff --git a/src/southbridge/intel/bd82x6x/Makefile.inc b/src/southbridge/intel/bd82x6x/Makefile.mk similarity index 100% rename from src/southbridge/intel/bd82x6x/Makefile.inc rename to src/southbridge/intel/bd82x6x/Makefile.mk diff --git a/src/southbridge/intel/common/Makefile.inc b/src/southbridge/intel/common/Makefile.mk similarity index 100% rename from src/southbridge/intel/common/Makefile.inc rename to src/southbridge/intel/common/Makefile.mk diff --git a/src/southbridge/intel/common/firmware/Makefile.inc b/src/southbridge/intel/common/firmware/Makefile.mk similarity index 100% rename from src/southbridge/intel/common/firmware/Makefile.inc rename to src/southbridge/intel/common/firmware/Makefile.mk diff --git a/src/southbridge/intel/i82371eb/Makefile.inc b/src/southbridge/intel/i82371eb/Makefile.mk similarity index 100% rename from src/southbridge/intel/i82371eb/Makefile.inc rename to src/southbridge/intel/i82371eb/Makefile.mk diff --git a/src/southbridge/intel/i82801dx/Makefile.inc b/src/southbridge/intel/i82801dx/Makefile.mk similarity index 100% rename from src/southbridge/intel/i82801dx/Makefile.inc rename to src/southbridge/intel/i82801dx/Makefile.mk diff --git a/src/southbridge/intel/i82801gx/Makefile.inc b/src/southbridge/intel/i82801gx/Makefile.mk similarity index 100% rename from src/southbridge/intel/i82801gx/Makefile.inc rename to src/southbridge/intel/i82801gx/Makefile.mk diff --git a/src/southbridge/intel/i82801ix/Makefile.inc b/src/southbridge/intel/i82801ix/Makefile.mk similarity index 100% rename from src/southbridge/intel/i82801ix/Makefile.inc rename to src/southbridge/intel/i82801ix/Makefile.mk diff --git a/src/southbridge/intel/i82801jx/Makefile.inc b/src/southbridge/intel/i82801jx/Makefile.mk similarity index 100% rename from src/southbridge/intel/i82801jx/Makefile.inc rename to src/southbridge/intel/i82801jx/Makefile.mk diff --git a/src/southbridge/intel/i82870/Makefile.inc b/src/southbridge/intel/i82870/Makefile.mk similarity index 100% rename from src/southbridge/intel/i82870/Makefile.inc rename to src/southbridge/intel/i82870/Makefile.mk diff --git a/src/southbridge/intel/ibexpeak/Makefile.inc b/src/southbridge/intel/ibexpeak/Makefile.mk similarity index 100% rename from src/southbridge/intel/ibexpeak/Makefile.inc rename to src/southbridge/intel/ibexpeak/Makefile.mk diff --git a/src/southbridge/intel/lynxpoint/Makefile.inc b/src/southbridge/intel/lynxpoint/Makefile.mk similarity index 100% rename from src/southbridge/intel/lynxpoint/Makefile.inc rename to src/southbridge/intel/lynxpoint/Makefile.mk diff --git a/src/southbridge/intel/lynxpoint/hsio/Makefile.inc b/src/southbridge/intel/lynxpoint/hsio/Makefile.mk similarity index 100% rename from src/southbridge/intel/lynxpoint/hsio/Makefile.inc rename to src/southbridge/intel/lynxpoint/hsio/Makefile.mk diff --git a/src/southbridge/ricoh/rl5c476/Makefile.inc b/src/southbridge/ricoh/rl5c476/Makefile.mk similarity index 100% rename from src/southbridge/ricoh/rl5c476/Makefile.inc rename to src/southbridge/ricoh/rl5c476/Makefile.mk diff --git a/src/southbridge/ti/pci1x2x/Makefile.inc b/src/southbridge/ti/pci1x2x/Makefile.mk similarity index 100% rename from src/southbridge/ti/pci1x2x/Makefile.inc rename to src/southbridge/ti/pci1x2x/Makefile.mk diff --git a/src/southbridge/ti/pci7420/Makefile.inc b/src/southbridge/ti/pci7420/Makefile.mk similarity index 100% rename from src/southbridge/ti/pci7420/Makefile.inc rename to src/southbridge/ti/pci7420/Makefile.mk diff --git a/src/southbridge/ti/pcixx12/Makefile.inc b/src/southbridge/ti/pcixx12/Makefile.mk similarity index 100% rename from src/southbridge/ti/pcixx12/Makefile.inc rename to src/southbridge/ti/pcixx12/Makefile.mk -- To view, visit https://review.coreboot.org/c/coreboot/+/80075?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ic80d27a963da8eddc3d1f0d9a3d59763028d4ed0 Gerrit-Change-Number: 80075 Gerrit-PatchSet: 4 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[NoOp] Change in coreboot[main]: soc/*: Rename Makefiles from .inc to .mk
by Felix Singer (Code Review) 24 Jan '24

24 Jan '24

Felix Singer has submitted this change. ( https://review.coreboot.org/c/coreboot/+/80074?usp=email ) Change subject: soc/*: Rename Makefiles from .inc to .mk ...................................................................... soc/*: Rename Makefiles from .inc to .mk The .inc suffix is confusing to various tools as it's not specific to Makefiles. This means that editors don't recognize the files, and don't open them with highlighting and any other specific editor functionality. This issue is also seen in the release notes generation script where Makefiles get renamed before running cloc. Signed-off-by: Martin Roth <gaumless(a)gmail.com> Change-Id: I6f502b97864fd7782e514ee2daa902d2081633a2 Reviewed-on: https://review.coreboot.org/c/coreboot/+/80074 Reviewed-by: Maximilian Brune <maximilian.brune(a)9elements.com> Reviewed-by: Michael Niewöhner <foss(a)mniewoehner.de> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Arthur Heymans <arthur(a)aheymans.xyz> Reviewed-by: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> --- R src/soc/cavium/cn81xx/Makefile.mk R src/soc/cavium/common/Makefile.mk R src/soc/cavium/common/pci/Makefile.mk R src/soc/example/min86/Makefile.mk R src/soc/mediatek/mt8173/Makefile.mk R src/soc/mediatek/mt8183/Makefile.mk R src/soc/mediatek/mt8186/Makefile.mk R src/soc/mediatek/mt8188/Makefile.mk R src/soc/mediatek/mt8192/Makefile.mk R src/soc/mediatek/mt8195/Makefile.mk R src/soc/nvidia/tegra124/Makefile.mk R src/soc/nvidia/tegra210/Makefile.mk R src/soc/qualcomm/ipq40xx/Makefile.mk R src/soc/qualcomm/ipq806x/Makefile.mk R src/soc/qualcomm/qcs405/Makefile.mk R src/soc/qualcomm/sc7180/Makefile.mk R src/soc/qualcomm/sc7280/Makefile.mk R src/soc/rockchip/rk3288/Makefile.mk R src/soc/rockchip/rk3399/Makefile.mk R src/soc/samsung/exynos5250/Makefile.mk R src/soc/samsung/exynos5420/Makefile.mk R src/soc/sifive/fu540/Makefile.mk R src/soc/ti/Makefile.mk R src/soc/ti/am335x/Makefile.mk R src/soc/ucb/riscv/Makefile.mk 25 files changed, 0 insertions(+), 0 deletions(-) Approvals: Maximilian Brune: Looks good to me, approved build bot (Jenkins): Verified Arthur Heymans: Looks good to me, approved Michael Niewöhner: Looks good to me, approved Felix Singer: Looks good to me, approved diff --git a/src/soc/cavium/cn81xx/Makefile.inc b/src/soc/cavium/cn81xx/Makefile.mk similarity index 100% rename from src/soc/cavium/cn81xx/Makefile.inc rename to src/soc/cavium/cn81xx/Makefile.mk diff --git a/src/soc/cavium/common/Makefile.inc b/src/soc/cavium/common/Makefile.mk similarity index 100% rename from src/soc/cavium/common/Makefile.inc rename to src/soc/cavium/common/Makefile.mk diff --git a/src/soc/cavium/common/pci/Makefile.inc b/src/soc/cavium/common/pci/Makefile.mk similarity index 100% rename from src/soc/cavium/common/pci/Makefile.inc rename to src/soc/cavium/common/pci/Makefile.mk diff --git a/src/soc/example/min86/Makefile.inc b/src/soc/example/min86/Makefile.mk similarity index 100% rename from src/soc/example/min86/Makefile.inc rename to src/soc/example/min86/Makefile.mk diff --git a/src/soc/mediatek/mt8173/Makefile.inc b/src/soc/mediatek/mt8173/Makefile.mk similarity index 100% rename from src/soc/mediatek/mt8173/Makefile.inc rename to src/soc/mediatek/mt8173/Makefile.mk diff --git a/src/soc/mediatek/mt8183/Makefile.inc b/src/soc/mediatek/mt8183/Makefile.mk similarity index 100% rename from src/soc/mediatek/mt8183/Makefile.inc rename to src/soc/mediatek/mt8183/Makefile.mk diff --git a/src/soc/mediatek/mt8186/Makefile.inc b/src/soc/mediatek/mt8186/Makefile.mk similarity index 100% rename from src/soc/mediatek/mt8186/Makefile.inc rename to src/soc/mediatek/mt8186/Makefile.mk diff --git a/src/soc/mediatek/mt8188/Makefile.inc b/src/soc/mediatek/mt8188/Makefile.mk similarity index 100% rename from src/soc/mediatek/mt8188/Makefile.inc rename to src/soc/mediatek/mt8188/Makefile.mk diff --git a/src/soc/mediatek/mt8192/Makefile.inc b/src/soc/mediatek/mt8192/Makefile.mk similarity index 100% rename from src/soc/mediatek/mt8192/Makefile.inc rename to src/soc/mediatek/mt8192/Makefile.mk diff --git a/src/soc/mediatek/mt8195/Makefile.inc b/src/soc/mediatek/mt8195/Makefile.mk similarity index 100% rename from src/soc/mediatek/mt8195/Makefile.inc rename to src/soc/mediatek/mt8195/Makefile.mk diff --git a/src/soc/nvidia/tegra124/Makefile.inc b/src/soc/nvidia/tegra124/Makefile.mk similarity index 100% rename from src/soc/nvidia/tegra124/Makefile.inc rename to src/soc/nvidia/tegra124/Makefile.mk diff --git a/src/soc/nvidia/tegra210/Makefile.inc b/src/soc/nvidia/tegra210/Makefile.mk similarity index 100% rename from src/soc/nvidia/tegra210/Makefile.inc rename to src/soc/nvidia/tegra210/Makefile.mk diff --git a/src/soc/qualcomm/ipq40xx/Makefile.inc b/src/soc/qualcomm/ipq40xx/Makefile.mk similarity index 100% rename from src/soc/qualcomm/ipq40xx/Makefile.inc rename to src/soc/qualcomm/ipq40xx/Makefile.mk diff --git a/src/soc/qualcomm/ipq806x/Makefile.inc b/src/soc/qualcomm/ipq806x/Makefile.mk similarity index 100% rename from src/soc/qualcomm/ipq806x/Makefile.inc rename to src/soc/qualcomm/ipq806x/Makefile.mk diff --git a/src/soc/qualcomm/qcs405/Makefile.inc b/src/soc/qualcomm/qcs405/Makefile.mk similarity index 100% rename from src/soc/qualcomm/qcs405/Makefile.inc rename to src/soc/qualcomm/qcs405/Makefile.mk diff --git a/src/soc/qualcomm/sc7180/Makefile.inc b/src/soc/qualcomm/sc7180/Makefile.mk similarity index 100% rename from src/soc/qualcomm/sc7180/Makefile.inc rename to src/soc/qualcomm/sc7180/Makefile.mk diff --git a/src/soc/qualcomm/sc7280/Makefile.inc b/src/soc/qualcomm/sc7280/Makefile.mk similarity index 100% rename from src/soc/qualcomm/sc7280/Makefile.inc rename to src/soc/qualcomm/sc7280/Makefile.mk diff --git a/src/soc/rockchip/rk3288/Makefile.inc b/src/soc/rockchip/rk3288/Makefile.mk similarity index 100% rename from src/soc/rockchip/rk3288/Makefile.inc rename to src/soc/rockchip/rk3288/Makefile.mk diff --git a/src/soc/rockchip/rk3399/Makefile.inc b/src/soc/rockchip/rk3399/Makefile.mk similarity index 100% rename from src/soc/rockchip/rk3399/Makefile.inc rename to src/soc/rockchip/rk3399/Makefile.mk diff --git a/src/soc/samsung/exynos5250/Makefile.inc b/src/soc/samsung/exynos5250/Makefile.mk similarity index 100% rename from src/soc/samsung/exynos5250/Makefile.inc rename to src/soc/samsung/exynos5250/Makefile.mk diff --git a/src/soc/samsung/exynos5420/Makefile.inc b/src/soc/samsung/exynos5420/Makefile.mk similarity index 100% rename from src/soc/samsung/exynos5420/Makefile.inc rename to src/soc/samsung/exynos5420/Makefile.mk diff --git a/src/soc/sifive/fu540/Makefile.inc b/src/soc/sifive/fu540/Makefile.mk similarity index 100% rename from src/soc/sifive/fu540/Makefile.inc rename to src/soc/sifive/fu540/Makefile.mk diff --git a/src/soc/ti/Makefile.inc b/src/soc/ti/Makefile.mk similarity index 100% rename from src/soc/ti/Makefile.inc rename to src/soc/ti/Makefile.mk diff --git a/src/soc/ti/am335x/Makefile.inc b/src/soc/ti/am335x/Makefile.mk similarity index 100% rename from src/soc/ti/am335x/Makefile.inc rename to src/soc/ti/am335x/Makefile.mk diff --git a/src/soc/ucb/riscv/Makefile.inc b/src/soc/ucb/riscv/Makefile.mk similarity index 100% rename from src/soc/ucb/riscv/Makefile.inc rename to src/soc/ucb/riscv/Makefile.mk -- To view, visit https://review.coreboot.org/c/coreboot/+/80074?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I6f502b97864fd7782e514ee2daa902d2081633a2 Gerrit-Change-Number: 80074 Gerrit-PatchSet: 4 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Philipp Hug <philipp(a)hug.cx> Gerrit-Reviewer: Xi Chen <xixi.chen(a)mediatek.com> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: ron minnich <rminnich(a)gmail.com> Gerrit-MessageType: merged

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit January 2024