coreboot-gerrit January 2024

coreboot-gerrit@coreboot.org

1 participants
3044 discussions

[NoOp] Change in coreboot[main]: soc/amd/*: Rename Makefiles from .inc to .mk
by Felix Singer (Code Review) 24 Jan '24

24 Jan '24

Attention is currently required from: Felix Held, Fred Reitberger, Jason Glenesk, Martin L Roth, Matt DeVillier, Maximilian Brune, Michael Niewöhner. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80071?usp=email ) Change subject: soc/amd/*: Rename Makefiles from .inc to .mk ...................................................................... Patch Set 4: (1 comment) Patchset: PS4: I had to rebase this patch. I need another review on this one so that I can submit it. -- To view, visit https://review.coreboot.org/c/coreboot/+/80071?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ie449267fe4fdd75110f577e1b9f748cd06140950 Gerrit-Change-Number: 80071 Gerrit-PatchSet: 4 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Attention: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Wed, 24 Jan 2024 09:09:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[XL] Change in coreboot[main]: mb/ocp: Drop tiogapass
by Felix Singer (Code Review) 24 Jan '24

24 Jan '24

Attention is currently required from: Lean Sheng Tan, Morgan Jang, Patrick Rudolph, Shuo Liu. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80171?usp=email ) Change subject: mb/ocp: Drop tiogapass ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > let me confirm first if anyone still interested on this That should be done by a deprecation note in the release notes. https://doc.coreboot.org/releases/templates.html -- To view, visit https://review.coreboot.org/c/coreboot/+/80171?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I838b9ea3955d31ea393494c2e726845fe234ef3a Gerrit-Change-Number: 80171 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Morgan Jang <Morgan_Jang(a)wiwynn.com> Gerrit-Reviewer: Shuo Liu <shuo.liu(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-CC: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Shuo Liu <shuo.liu(a)intel.com> Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Attention: Morgan Jang <Morgan_Jang(a)wiwynn.com> Gerrit-Comment-Date: Wed, 24 Jan 2024 08:59:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-MessageType: comment

1 0

[M] Change in coreboot[main]: soc/intel/common: Add lunarlake device IDs
by Saurabh Mishra (Code Review) 24 Jan '24

24 Jan '24

Attention is currently required from: Appukuttan V K, Ashish Kumar Mishra, Bora Guvendik, Wonkyu Kim. Saurabh Mishra has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79900?usp=email ) Change subject: soc/intel/common: Add lunarlake device IDs ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/79900?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Id31d567287b9921d60909b1eb617c7cfaf6672c9 Gerrit-Change-Number: 79900 Gerrit-PatchSet: 3 Gerrit-Owner: Appukuttan V K <appukuttan.vk(a)intel.com> Gerrit-Reviewer: Ashish Kumar Mishra <ashish.k.mishra(a)intel.com> Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Saurabh Mishra <mishra.saurabh(a)intel.com> Gerrit-Reviewer: Wonkyu Kim <wonkyu.kim(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Attention: Appukuttan V K <appukuttan.vk(a)intel.com> Gerrit-Attention: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Attention: Ashish Kumar Mishra <ashish.k.mishra(a)intel.com> Gerrit-Attention: Wonkyu Kim <wonkyu.kim(a)intel.com> Gerrit-Comment-Date: Wed, 24 Jan 2024 08:58:31 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in coreboot[main]: soc/intel/xeon_sp/chip_common: Improve the domain ID
by Lean Sheng Tan (Code Review) 24 Jan '24

24 Jan '24

Lean Sheng Tan has submitted this change. ( https://review.coreboot.org/c/coreboot/+/80099?usp=email ) ( 1 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: soc/intel/xeon_sp/chip_common: Improve the domain ID ...................................................................... soc/intel/xeon_sp/chip_common: Improve the domain ID Use a union to access the PCI domain ID. This will become handy in the following commits to gather meta-data from the domain ID. Change-Id: I5c371961768410167a571358f6f366847a259eb6 Signed-off-by: Patrick Rudolph <patrick.rudolph(a)9elements.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/80099 Reviewed-by: Arthur Heymans <arthur(a)aheymans.xyz> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- M src/soc/intel/xeon_sp/chip_common.c M src/soc/intel/xeon_sp/include/soc/chip_common.h M src/soc/intel/xeon_sp/spr/ioat.c 3 files changed, 36 insertions(+), 15 deletions(-) Approvals: Arthur Heymans: Looks good to me, approved build bot (Jenkins): Verified diff --git a/src/soc/intel/xeon_sp/chip_common.c b/src/soc/intel/xeon_sp/chip_common.c index 003a03f..bf2a015 100644 --- a/src/soc/intel/xeon_sp/chip_common.c +++ b/src/soc/intel/xeon_sp/chip_common.c @@ -12,12 +12,14 @@ static const STACK_RES *domain_to_stack_res(const struct device *dev) { assert(dev->path.type == DEVICE_PATH_DOMAIN); - const unsigned int dn = dev->path.domain.domain; + const union xeon_domain_path dn = { + .domain_path = dev->path.domain.domain + }; const IIO_UDS *hob = get_iio_uds(); assert(hob != NULL); - return &hob->PlatformData.IIO_resource[dn / MAX_LOGIC_IIO_STACK].StackRes[dn % MAX_LOGIC_IIO_STACK]; + return &hob->PlatformData.IIO_resource[dn.socket].StackRes[dn.stack]; } void iio_pci_domain_read_resources(struct device *dev) @@ -101,6 +103,7 @@ void attach_iio_stacks(struct device *dev) { const IIO_UDS *hob = get_iio_uds(); + union xeon_domain_path dn = { .domain_path = 0 }; if (!hob) return; @@ -113,15 +116,20 @@ if (ri->BusBase > ri->BusLimit) continue; + /* Prepare domain path */ + dn.socket = s; + dn.stack = x; + dn.bus = ri->BusBase; + if (!is_pcie_iio_stack_res(ri)) { if (CONFIG(HAVE_IOAT_DOMAINS)) - soc_create_ioat_domains(dev->bus, ri); + soc_create_ioat_domains(dn, dev->bus, ri); continue; } struct device_path path; path.type = DEVICE_PATH_DOMAIN; - path.domain.domain = s * MAX_LOGIC_IIO_STACK + x; + path.domain.domain = dn.domain_path; struct device *iio_domain = alloc_dev(dev->bus, &path); if (iio_domain == NULL) die("%s: out of memory.\n", __func__); diff --git a/src/soc/intel/xeon_sp/include/soc/chip_common.h b/src/soc/intel/xeon_sp/include/soc/chip_common.h index ac8ba9e..f3cb950 100644 --- a/src/soc/intel/xeon_sp/include/soc/chip_common.h +++ b/src/soc/intel/xeon_sp/include/soc/chip_common.h @@ -5,10 +5,20 @@ #include <hob_iiouds.h> +union xeon_domain_path { + unsigned int domain_path; + struct { + u8 bus; + u8 stack; + u8 socket; + u8 unused; + }; +}; + void iio_pci_domain_read_resources(struct device *dev); void iio_pci_domain_scan_bus(struct device *dev); void attach_iio_stacks(struct device *dev); -void soc_create_ioat_domains(struct bus *bus, const STACK_RES *sr); +void soc_create_ioat_domains(union xeon_domain_path path, struct bus *bus, const STACK_RES *sr); #endif /* _CHIP_COMMON_H_ */ diff --git a/src/soc/intel/xeon_sp/spr/ioat.c b/src/soc/intel/xeon_sp/spr/ioat.c index 38bbd93..02f35cf 100644 --- a/src/soc/intel/xeon_sp/spr/ioat.c +++ b/src/soc/intel/xeon_sp/spr/ioat.c @@ -23,15 +23,20 @@ .scan_bus = pci_host_bridge_scan_bus, }; -static void create_ioat_domain(struct bus *const upstream, const unsigned int domain_base, +static void create_ioat_domain(const union xeon_domain_path dp, struct bus *const upstream, const unsigned int bus_base, const unsigned int bus_limit, const resource_t mem32_base, const resource_t mem32_limit, const resource_t mem64_base, const resource_t mem64_limit) { + union xeon_domain_path new_path = { + .domain_path = dp.domain_path + }; + new_path.bus = bus_base; + struct device_path path = { .type = DEVICE_PATH_DOMAIN, .domain = { - .domain = domain_base + bus_base, + .domain = new_path.domain_path, }, }; struct device *const domain = alloc_dev(upstream, &path); @@ -69,10 +74,8 @@ } } -void soc_create_ioat_domains(struct bus *const bus, const STACK_RES *const sr) +void soc_create_ioat_domains(const union xeon_domain_path path, struct bus *const bus, const STACK_RES *const sr) { - const unsigned int domain_base = MAX_SOCKET * MAX_LOGIC_IIO_STACK; - if (sr->BusLimit < sr->BusBase + HQM_BUS_OFFSET + HQM_RESERVED_BUS) { printk(BIOS_WARNING, "Ignoring IOAT domain with limited bus range.\n"); @@ -96,14 +99,14 @@ mem64_limit = mem64_base + CPM_MMIO_SIZE - 1; bus_base = sr->BusBase + CPM_BUS_OFFSET; bus_limit = bus_base + CPM_RESERVED_BUS; - create_ioat_domain(bus, domain_base, bus_base, bus_limit, 0, -1, mem64_base, mem64_limit); + create_ioat_domain(path, bus, bus_base, bus_limit, 0, -1, mem64_base, mem64_limit); /* HQM0 */ mem64_base = mem64_limit + 1; mem64_limit = mem64_base + HQM_MMIO_SIZE - 1; bus_base = sr->BusBase + HQM_BUS_OFFSET; bus_limit = bus_base + HQM_RESERVED_BUS; - create_ioat_domain(bus, domain_base, bus_base, bus_limit, 0, -1, mem64_base, mem64_limit); + create_ioat_domain(path, bus, bus_base, bus_limit, 0, -1, mem64_base, mem64_limit); /* CPM1 (optional) */ mem64_base = mem64_limit + 1; @@ -111,7 +114,7 @@ bus_base = sr->BusBase + CPM1_BUS_OFFSET; bus_limit = bus_base + CPM_RESERVED_BUS; if (bus_limit <= sr->BusLimit) - create_ioat_domain(bus, domain_base, bus_base, bus_limit, 0, -1, mem64_base, mem64_limit); + create_ioat_domain(path, bus, bus_base, bus_limit, 0, -1, mem64_base, mem64_limit); /* HQM1 (optional) */ mem64_base = mem64_limit + 1; @@ -119,13 +122,13 @@ bus_base = sr->BusBase + HQM1_BUS_OFFSET; bus_limit = bus_base + HQM_RESERVED_BUS; if (bus_limit <= sr->BusLimit) - create_ioat_domain(bus, domain_base, bus_base, bus_limit, 0, -1, mem64_base, mem64_limit); + create_ioat_domain(path, bus, bus_base, bus_limit, 0, -1, mem64_base, mem64_limit); /* DINO */ mem64_base = mem64_limit + 1; mem64_limit = sr->PciResourceMem64Limit; bus_base = sr->BusBase; bus_limit = bus_base; - create_ioat_domain(bus, domain_base, bus_base, bus_limit, sr->PciResourceMem32Base, sr->PciResourceMem32Limit, + create_ioat_domain(path, bus, bus_base, bus_limit, sr->PciResourceMem32Base, sr->PciResourceMem32Limit, mem64_base, mem64_limit); } -- To view, visit https://review.coreboot.org/c/coreboot/+/80099?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I5c371961768410167a571358f6f366847a259eb6 Gerrit-Change-Number: 80099 Gerrit-PatchSet: 4 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[M] Change in coreboot[main]: soc/intel/xeon_sp/chip_common: Improve the domain ID
by Lean Sheng Tan (Code Review) 24 Jan '24

24 Jan '24

Attention is currently required from: Christian Walter, Felix Held, Johnny Lin, Patrick Rudolph, Tim Chu. Lean Sheng Tan has uploaded a new patch set (#3) to the change originally created by Patrick Rudolph. ( https://review.coreboot.org/c/coreboot/+/80099?usp=email ) Change subject: soc/intel/xeon_sp/chip_common: Improve the domain ID ...................................................................... soc/intel/xeon_sp/chip_common: Improve the domain ID Use a union to access the PCI domain ID. This will become handy in the following commits to gather meta-data from the domain ID. Change-Id: I5c371961768410167a571358f6f366847a259eb6 Signed-off-by: Patrick Rudolph <patrick.rudolph(a)9elements.com> --- M src/soc/intel/xeon_sp/chip_common.c M src/soc/intel/xeon_sp/include/soc/chip_common.h M src/soc/intel/xeon_sp/spr/ioat.c 3 files changed, 36 insertions(+), 15 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/99/80099/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/80099?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I5c371961768410167a571358f6f366847a259eb6 Gerrit-Change-Number: 80099 Gerrit-PatchSet: 3 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Attention: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[main]: device/device_util: Add method to retrieve the domain
by Lean Sheng Tan (Code Review) 24 Jan '24

24 Jan '24

Lean Sheng Tan has submitted this change. ( https://review.coreboot.org/c/coreboot/+/80090?usp=email ) Change subject: device/device_util: Add method to retrieve the domain ...................................................................... device/device_util: Add method to retrieve the domain Add a function to return the PCI domain device for the specified device. On multi PCI domain platforms this function allows to determine which domain and thus which socket the PCI device belongs to. Change-Id: I0068b82e139fe7a35e6b1b91b7d386b750c80748 Signed-off-by: Patrick Rudolph <patrick.rudolph(a)9elements.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/80090 Reviewed-by: Lean Sheng Tan <sheng.tan(a)9elements.com> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Nico Huber <nico.h(a)gmx.de> --- M src/device/device_util.c M src/include/device/device.h 2 files changed, 14 insertions(+), 0 deletions(-) Approvals: build bot (Jenkins): Verified Nico Huber: Looks good to me, but someone else must approve Lean Sheng Tan: Looks good to me, approved diff --git a/src/device/device_util.c b/src/device/device_util.c index edf053d..260c9b4 100644 --- a/src/device/device_util.c +++ b/src/device/device_util.c @@ -249,6 +249,19 @@ return "unknown"; } +/* Returns the PCI domain for the given PCI device */ +struct device *dev_get_pci_domain(struct device *dev) +{ + /* Walk up the tree up to the PCI domain */ + while (dev && dev->bus && !is_root_device(dev)) { + dev = dev->bus->dev; + if (dev->path.type == DEVICE_PATH_DOMAIN) + return dev; + } + + return NULL; +} + /** * Allocate 64 more resources to the free list. * diff --git a/src/include/device/device.h b/src/include/device/device.h index 863299c..83588d4 100644 --- a/src/include/device/device.h +++ b/src/include/device/device.h @@ -188,6 +188,7 @@ const char *dev_name(const struct device *dev); const char *dev_path(const struct device *dev); u32 dev_path_encode(const struct device *dev); +struct device *dev_get_pci_domain(struct device *dev); void dev_set_enabled(struct device *dev, int enable); void disable_children(struct bus *bus); bool dev_is_active_bridge(struct device *dev); -- To view, visit https://review.coreboot.org/c/coreboot/+/80090?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I0068b82e139fe7a35e6b1b91b7d386b750c80748 Gerrit-Change-Number: 80090 Gerrit-PatchSet: 3 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Shuo Liu <shuo.liu(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[XL] Change in coreboot[main]: mb/ocp: Drop tiogapass
by Lean Sheng Tan (Code Review) 24 Jan '24

24 Jan '24

Attention is currently required from: Morgan Jang, Patrick Rudolph, Shuo Liu. Lean Sheng Tan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80171?usp=email ) The change is no longer submittable: All-Comments-Resolved is unsatisfied now. Change subject: mb/ocp: Drop tiogapass ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: let me confirm first if anyone still interested on this -- To view, visit https://review.coreboot.org/c/coreboot/+/80171?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I838b9ea3955d31ea393494c2e726845fe234ef3a Gerrit-Change-Number: 80171 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Morgan Jang <Morgan_Jang(a)wiwynn.com> Gerrit-Reviewer: Shuo Liu <shuo.liu(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Shuo Liu <shuo.liu(a)intel.com> Gerrit-Attention: Morgan Jang <Morgan_Jang(a)wiwynn.com> Gerrit-Comment-Date: Wed, 24 Jan 2024 08:49:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: device/device_util: Add method to retrieve the domain
by Lean Sheng Tan (Code Review) 24 Jan '24

24 Jan '24

Attention is currently required from: Felix Held, Patrick Rudolph, Shuo Liu. Lean Sheng Tan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80090?usp=email ) Change subject: device/device_util: Add method to retrieve the domain ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/80090?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I0068b82e139fe7a35e6b1b91b7d386b750c80748 Gerrit-Change-Number: 80090 Gerrit-PatchSet: 2 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Shuo Liu <shuo.liu(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Shuo Liu <shuo.liu(a)intel.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Wed, 24 Jan 2024 08:46:46 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: device: Add inline method to identify PATH_ROOT
by Lean Sheng Tan (Code Review) 24 Jan '24

24 Jan '24

Lean Sheng Tan has submitted this change. ( https://review.coreboot.org/c/coreboot/+/80169?usp=email ) Change subject: device: Add inline method to identify PATH_ROOT ...................................................................... device: Add inline method to identify PATH_ROOT Add and use inline method to identify the root device. Change-Id: I394c8668245bcfea6414b8ca5f14ef8135897e59 Signed-off-by: Patrick Rudolph <patrick.rudolph(a)9elements.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/80169 Reviewed-by: Nico Huber <nico.h(a)gmx.de> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M src/acpi/device.c M src/drivers/usb/pci_xhci/pci_xhci.c M src/include/device/device.h 3 files changed, 14 insertions(+), 6 deletions(-) Approvals: Nico Huber: Looks good to me, but someone else must approve build bot (Jenkins): Verified Arthur Heymans: Looks good to me, approved diff --git a/src/acpi/device.c b/src/acpi/device.c index 92000a3..823cdbeb 100644 --- a/src/acpi/device.c +++ b/src/acpi/device.c @@ -87,7 +87,7 @@ pdev = pdev->bus->dev; if (!pdev) break; - if (pdev->path.type == DEVICE_PATH_ROOT) + if (is_root_device(pdev)) break; if (pdev->ops && pdev->ops->acpi_name) name = pdev->ops->acpi_name(dev); @@ -147,16 +147,15 @@ return cur; /* Walk up the tree to the root device */ - if (dev->path.type != DEVICE_PATH_ROOT && dev->bus && dev->bus->dev) + if (!is_root_device(dev) && dev->bus && dev->bus->dev) next = acpi_device_path_fill(dev->bus->dev, buf, buf_len, cur); if (next < 0) return next; /* Fill in the path from the root device */ next += snprintf(buf + next, buf_len - next, "%s%s", - (dev->path.type == DEVICE_PATH_ROOT - || (strlen(name) == 0)) ? - "" : ".", name); + (is_root_device(dev) || (strlen(name) == 0)) ? + "" : ".", name); return next; } diff --git a/src/drivers/usb/pci_xhci/pci_xhci.c b/src/drivers/usb/pci_xhci/pci_xhci.c index 6d022d1..398595d 100644 --- a/src/drivers/usb/pci_xhci/pci_xhci.c +++ b/src/drivers/usb/pci_xhci/pci_xhci.c @@ -73,7 +73,7 @@ static const struct device *get_xhci_dev(const struct device *dev) { while (dev && dev->ops != &xhci_pci_ops) { - if (dev->path.type == DEVICE_PATH_ROOT) + if (is_root_device(dev)) return NULL; dev = dev->bus->dev; diff --git a/src/include/device/device.h b/src/include/device/device.h index cd0999a..863299c 100644 --- a/src/include/device/device.h +++ b/src/include/device/device.h @@ -458,6 +458,15 @@ */ #define config_of_soc() __pci_0_00_0_config +static inline bool is_root_device(const struct device *dev) +{ + if (!dev || !dev->bus) + return false; + + return (dev->path.type == DEVICE_PATH_ROOT) || + (dev->bus->dev == dev); +} + void enable_static_device(struct device *dev); void enable_static_devices(struct device *bus); void scan_smbus(struct device *bus); -- To view, visit https://review.coreboot.org/c/coreboot/+/80169?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I394c8668245bcfea6414b8ca5f14ef8135897e59 Gerrit-Change-Number: 80169 Gerrit-PatchSet: 2 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[NoOp] Change in coreboot[main]: ec: Rename Makefiles from .inc to .mk
by Felix Singer (Code Review) 24 Jan '24

24 Jan '24

Felix Singer has submitted this change. ( https://review.coreboot.org/c/coreboot/+/80069?usp=email ) ( 3 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: ec: Rename Makefiles from .inc to .mk ...................................................................... ec: Rename Makefiles from .inc to .mk The .inc suffix is confusing to various tools as it's not specific to Makefiles. This means that editors don't recognize the files, and don't open them with highlighting and any other specific editor functionality. This issue is also seen in the release notes generation script where Makefiles get renamed before running cloc. Signed-off-by: Martin Roth <gaumless(a)gmail.com> Change-Id: Ic060f3605cd18d4bf774573c21957f626f984e2c Reviewed-on: https://review.coreboot.org/c/coreboot/+/80069 Reviewed-by: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Reviewed-by: Maximilian Brune <maximilian.brune(a)9elements.com> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Michael Niewöhner <foss(a)mniewoehner.de> --- R src/ec/51nb/npce985la0dx/Makefile.mk R src/ec/acpi/Makefile.mk R src/ec/clevo/it5570e/Makefile.mk R src/ec/compal/ene932/Makefile.mk R src/ec/dell/mec5035/Makefile.mk R src/ec/google/chromeec/Makefile.mk R src/ec/google/chromeec/audio_codec/Makefile.mk R src/ec/google/chromeec/i2c_tunnel/Makefile.mk R src/ec/google/chromeec/mux/Makefile.mk R src/ec/google/chromeec/mux/conn/Makefile.mk R src/ec/google/common/Makefile.mk R src/ec/google/wilco/Makefile.mk R src/ec/hp/kbc1126/Makefile.mk R src/ec/intel/Makefile.mk R src/ec/kontron/it8516e/Makefile.mk R src/ec/kontron/kempld/Makefile.mk R src/ec/lenovo/h8/Makefile.mk R src/ec/lenovo/pmh7/Makefile.mk R src/ec/purism/librem-ec/Makefile.mk R src/ec/quanta/ene_kb3940q/Makefile.mk R src/ec/quanta/it8518/Makefile.mk R src/ec/roda/it8518/Makefile.mk R src/ec/smsc/mec1308/Makefile.mk R src/ec/starlabs/merlin/Makefile.mk R src/ec/system76/ec/Makefile.mk 25 files changed, 0 insertions(+), 0 deletions(-) Approvals: Felix Singer: Looks good to me, approved build bot (Jenkins): Verified Michael Niewöhner: Looks good to me, approved Maximilian Brune: Looks good to me, approved diff --git a/src/ec/51nb/npce985la0dx/Makefile.inc b/src/ec/51nb/npce985la0dx/Makefile.mk similarity index 100% rename from src/ec/51nb/npce985la0dx/Makefile.inc rename to src/ec/51nb/npce985la0dx/Makefile.mk diff --git a/src/ec/acpi/Makefile.inc b/src/ec/acpi/Makefile.mk similarity index 100% rename from src/ec/acpi/Makefile.inc rename to src/ec/acpi/Makefile.mk diff --git a/src/ec/clevo/it5570e/Makefile.inc b/src/ec/clevo/it5570e/Makefile.mk similarity index 100% rename from src/ec/clevo/it5570e/Makefile.inc rename to src/ec/clevo/it5570e/Makefile.mk diff --git a/src/ec/compal/ene932/Makefile.inc b/src/ec/compal/ene932/Makefile.mk similarity index 100% rename from src/ec/compal/ene932/Makefile.inc rename to src/ec/compal/ene932/Makefile.mk diff --git a/src/ec/dell/mec5035/Makefile.inc b/src/ec/dell/mec5035/Makefile.mk similarity index 100% rename from src/ec/dell/mec5035/Makefile.inc rename to src/ec/dell/mec5035/Makefile.mk diff --git a/src/ec/google/chromeec/Makefile.inc b/src/ec/google/chromeec/Makefile.mk similarity index 100% rename from src/ec/google/chromeec/Makefile.inc rename to src/ec/google/chromeec/Makefile.mk diff --git a/src/ec/google/chromeec/audio_codec/Makefile.inc b/src/ec/google/chromeec/audio_codec/Makefile.mk similarity index 100% rename from src/ec/google/chromeec/audio_codec/Makefile.inc rename to src/ec/google/chromeec/audio_codec/Makefile.mk diff --git a/src/ec/google/chromeec/i2c_tunnel/Makefile.inc b/src/ec/google/chromeec/i2c_tunnel/Makefile.mk similarity index 100% rename from src/ec/google/chromeec/i2c_tunnel/Makefile.inc rename to src/ec/google/chromeec/i2c_tunnel/Makefile.mk diff --git a/src/ec/google/chromeec/mux/Makefile.inc b/src/ec/google/chromeec/mux/Makefile.mk similarity index 100% rename from src/ec/google/chromeec/mux/Makefile.inc rename to src/ec/google/chromeec/mux/Makefile.mk diff --git a/src/ec/google/chromeec/mux/conn/Makefile.inc b/src/ec/google/chromeec/mux/conn/Makefile.mk similarity index 100% rename from src/ec/google/chromeec/mux/conn/Makefile.inc rename to src/ec/google/chromeec/mux/conn/Makefile.mk diff --git a/src/ec/google/common/Makefile.inc b/src/ec/google/common/Makefile.mk similarity index 100% rename from src/ec/google/common/Makefile.inc rename to src/ec/google/common/Makefile.mk diff --git a/src/ec/google/wilco/Makefile.inc b/src/ec/google/wilco/Makefile.mk similarity index 100% rename from src/ec/google/wilco/Makefile.inc rename to src/ec/google/wilco/Makefile.mk diff --git a/src/ec/hp/kbc1126/Makefile.inc b/src/ec/hp/kbc1126/Makefile.mk similarity index 100% rename from src/ec/hp/kbc1126/Makefile.inc rename to src/ec/hp/kbc1126/Makefile.mk diff --git a/src/ec/intel/Makefile.inc b/src/ec/intel/Makefile.mk similarity index 100% rename from src/ec/intel/Makefile.inc rename to src/ec/intel/Makefile.mk diff --git a/src/ec/kontron/it8516e/Makefile.inc b/src/ec/kontron/it8516e/Makefile.mk similarity index 100% rename from src/ec/kontron/it8516e/Makefile.inc rename to src/ec/kontron/it8516e/Makefile.mk diff --git a/src/ec/kontron/kempld/Makefile.inc b/src/ec/kontron/kempld/Makefile.mk similarity index 100% rename from src/ec/kontron/kempld/Makefile.inc rename to src/ec/kontron/kempld/Makefile.mk diff --git a/src/ec/lenovo/h8/Makefile.inc b/src/ec/lenovo/h8/Makefile.mk similarity index 100% rename from src/ec/lenovo/h8/Makefile.inc rename to src/ec/lenovo/h8/Makefile.mk diff --git a/src/ec/lenovo/pmh7/Makefile.inc b/src/ec/lenovo/pmh7/Makefile.mk similarity index 100% rename from src/ec/lenovo/pmh7/Makefile.inc rename to src/ec/lenovo/pmh7/Makefile.mk diff --git a/src/ec/purism/librem-ec/Makefile.inc b/src/ec/purism/librem-ec/Makefile.mk similarity index 100% rename from src/ec/purism/librem-ec/Makefile.inc rename to src/ec/purism/librem-ec/Makefile.mk diff --git a/src/ec/quanta/ene_kb3940q/Makefile.inc b/src/ec/quanta/ene_kb3940q/Makefile.mk similarity index 100% rename from src/ec/quanta/ene_kb3940q/Makefile.inc rename to src/ec/quanta/ene_kb3940q/Makefile.mk diff --git a/src/ec/quanta/it8518/Makefile.inc b/src/ec/quanta/it8518/Makefile.mk similarity index 100% rename from src/ec/quanta/it8518/Makefile.inc rename to src/ec/quanta/it8518/Makefile.mk diff --git a/src/ec/roda/it8518/Makefile.inc b/src/ec/roda/it8518/Makefile.mk similarity index 100% rename from src/ec/roda/it8518/Makefile.inc rename to src/ec/roda/it8518/Makefile.mk diff --git a/src/ec/smsc/mec1308/Makefile.inc b/src/ec/smsc/mec1308/Makefile.mk similarity index 100% rename from src/ec/smsc/mec1308/Makefile.inc rename to src/ec/smsc/mec1308/Makefile.mk diff --git a/src/ec/starlabs/merlin/Makefile.inc b/src/ec/starlabs/merlin/Makefile.mk similarity index 100% rename from src/ec/starlabs/merlin/Makefile.inc rename to src/ec/starlabs/merlin/Makefile.mk diff --git a/src/ec/system76/ec/Makefile.inc b/src/ec/system76/ec/Makefile.mk similarity index 100% rename from src/ec/system76/ec/Makefile.inc rename to src/ec/system76/ec/Makefile.mk -- To view, visit https://review.coreboot.org/c/coreboot/+/80069?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ic060f3605cd18d4bf774573c21957f626f984e2c Gerrit-Change-Number: 80069 Gerrit-PatchSet: 5 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Caveh Jalali <caveh(a)chromium.org> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Forest Mittelberg <bmbm(a)google.com> Gerrit-Reviewer: Jeremy Soller <jeremy(a)system76.com> Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Tim Crawford <tcrawford(a)system76.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit January 2024