Attention is currently required from: Felix Held, Fred Reitberger, Jason Glenesk, Paul Menzel.
Anand Vaikar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79283?usp=email )
Change subject: mainboard/amd/birman: Add Birmanplus board variant support for Phoenix SOC
......................................................................
Patch Set 6:
(1 comment)
File src/mainboard/amd/birman/variants/birmanplus/port_descriptors.c:
https://review.coreboot.org/c/coreboot/+/79283/comment/f76d3ac5_352f8a8f :
PS5, Line 153: printk(BIOS_NOTICE,
: "Display connector type couldn't be determined. Disabling DDI1.\n");
> This sounds like error level, and also should be elaborated on, that there is something wrong with t […]
this indicates that there was an issue with reading the connector type. System will continue to boot and user action is generally not required unless there is an issue with getting video.
--
To view, visit https://review.coreboot.org/c/coreboot/+/79283?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I40f196d8a662d19e424511febca24edb88d686dd
Gerrit-Change-Number: 79283
Gerrit-PatchSet: 6
Gerrit-Owner: Anand Vaikar <a.vaikar2021(a)gmail.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: ritul guru <ritul.bits(a)gmail.com>
Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Comment-Date: Tue, 02 Jan 2024 09:18:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-MessageType: comment
Attention is currently required from: Felix Held, Fred Reitberger, Paul Menzel, ritul guru.
Anand Vaikar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79509?usp=email )
Change subject: soc/amd/glinda: Update the maximum CPU threads for glinda
......................................................................
Patch Set 6:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/79509/comment/e65a4186_e5aa130d :
PS1, Line 7: Update the MAX_CPUS config option for glinda
> Please be more specific.
Done
https://review.coreboot.org/c/coreboot/+/79509/comment/2ab975f9_48248d8f :
PS1, Line 8:
> Please elaborate.
Done
Patchset:
PS6:
Addressed comments.
--
To view, visit https://review.coreboot.org/c/coreboot/+/79509?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Id48a5c62d6156c046daffd2648aeebeee380bd88
Gerrit-Change-Number: 79509
Gerrit-PatchSet: 6
Gerrit-Owner: Anand Vaikar <a.vaikar2021(a)gmail.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Reviewer: ritul guru <ritul.bits(a)gmail.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: ritul guru <ritul.bits(a)gmail.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Comment-Date: Tue, 02 Jan 2024 08:00:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-MessageType: comment
Attention is currently required from: Matt Chen, Shou-Chieh Hsu, Simon Yang.
Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79740?usp=email )
Change subject: driver/wifi: DDR RFIM _DSM method function 3 report incorrect value
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/79740?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I642c56a9c3160cdb41b254dc75e126cacf905b14
Gerrit-Change-Number: 79740
Gerrit-PatchSet: 1
Gerrit-Owner: Simon Yang <simon1.yang(a)intel.com>
Gerrit-Reviewer: Eric Lai <ericllai(a)google.com>
Gerrit-Reviewer: Matt Chen <matt.chen(a)intel.corp-partner.google.com>
Gerrit-Reviewer: Rex Chou <rex_chou(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Shou-Chieh Hsu <shouchieh(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Matt Chen <matt.chen(a)intel.corp-partner.google.com>
Gerrit-Attention: Simon Yang <simon1.yang(a)intel.com>
Gerrit-Attention: Shou-Chieh Hsu <shouchieh(a)google.com>
Gerrit-Comment-Date: Tue, 02 Jan 2024 07:20:15 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Eric Lai, Matt Chen, Shou-Chieh Hsu, Simon Yang.
Rex Chou has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79740?usp=email )
Change subject: driver/wifi: DDR RFIM _DSM method function 3 report incorrect value
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://review.coreboot.org/c/coreboot/+/79740?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I642c56a9c3160cdb41b254dc75e126cacf905b14
Gerrit-Change-Number: 79740
Gerrit-PatchSet: 1
Gerrit-Owner: Simon Yang <simon1.yang(a)intel.com>
Gerrit-Reviewer: Eric Lai <ericllai(a)google.com>
Gerrit-Reviewer: Matt Chen <matt.chen(a)intel.corp-partner.google.com>
Gerrit-Reviewer: Rex Chou <rex_chou(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Shou-Chieh Hsu <shouchieh(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Eric Lai <ericllai(a)google.com>
Gerrit-Attention: Matt Chen <matt.chen(a)intel.corp-partner.google.com>
Gerrit-Attention: Simon Yang <simon1.yang(a)intel.com>
Gerrit-Attention: Shou-Chieh Hsu <shouchieh(a)google.com>
Gerrit-Comment-Date: Tue, 02 Jan 2024 07:16:43 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Simon Yang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79740?usp=email )
Change subject: driver/wifi: DDR RFIM _DSM method function 3 report incorrect value
......................................................................
Set Ready For Review
--
To view, visit https://review.coreboot.org/c/coreboot/+/79740?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I642c56a9c3160cdb41b254dc75e126cacf905b14
Gerrit-Change-Number: 79740
Gerrit-PatchSet: 1
Gerrit-Owner: Simon Yang <simon1.yang(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Tue, 02 Jan 2024 07:05:33 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Dinesh Gehlot, Eran Mitrani, Jakub Czapiga, Jason Z Chen, Tarun.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79803?usp=email )
Change subject: mb/google/rex/var/screebo: Prevent camera LED blinking during boot
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/79803?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I43044e64c2c3a645ec0cad2ac903cc19ac89c9af
Gerrit-Change-Number: 79803
Gerrit-PatchSet: 2
Gerrit-Owner: Jason Z Chen <jason.z.chen(a)intel.corp-partner.google.com>
Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com>
Gerrit-Reviewer: Jakub Czapiga <czapiga(a)google.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Tarun <tstuli(a)gmail.com>
Gerrit-Reviewer: Wentao Qin <qinwentao(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Jason Z Chen <jason.z.chen(a)intel.corp-partner.google.com>
Gerrit-Attention: Eran Mitrani <mitrani(a)google.com>
Gerrit-Attention: Jakub Czapiga <czapiga(a)google.com>
Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Attention: Tarun <tstuli(a)gmail.com>
Gerrit-Comment-Date: Tue, 02 Jan 2024 06:16:17 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Dinesh Gehlot, Eran Mitrani, Jakub Czapiga, Jason Z Chen, Subrata Banik, Tarun.
Wentao Qin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79803?usp=email )
Change subject: mb/google/rex/var/screebo: Prevent camera LED blinking during boot
......................................................................
Patch Set 2: Code-Review+1
--
To view, visit https://review.coreboot.org/c/coreboot/+/79803?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I43044e64c2c3a645ec0cad2ac903cc19ac89c9af
Gerrit-Change-Number: 79803
Gerrit-PatchSet: 2
Gerrit-Owner: Jason Z Chen <jason.z.chen(a)intel.corp-partner.google.com>
Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com>
Gerrit-Reviewer: Jakub Czapiga <czapiga(a)google.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Tarun <tstuli(a)gmail.com>
Gerrit-Reviewer: Wentao Qin <qinwentao(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Jason Z Chen <jason.z.chen(a)intel.corp-partner.google.com>
Gerrit-Attention: Eran Mitrani <mitrani(a)google.com>
Gerrit-Attention: Jakub Czapiga <czapiga(a)google.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Attention: Tarun <tstuli(a)gmail.com>
Gerrit-Comment-Date: Tue, 02 Jan 2024 06:14:33 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Dinesh Gehlot, Eran Mitrani, Jakub Czapiga, Jason Z Chen, Subrata Banik, Tarun.
Hello Dinesh Gehlot, Eran Mitrani, Jakub Czapiga, Kapil Porwal, Subrata Banik, Tarun, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/79803?usp=email
to look at the new patch set (#2).
Change subject: mb/google/rex/var/screebo: Prevent camera LED blinking during boot
......................................................................
mb/google/rex/var/screebo: Prevent camera LED blinking during boot
Configure _DSC to ACPI_DEVICE_SLEEP_D3_COLD so that driver skips
initial probe during kernel boot, preventing privacy LED blink.
BUG=b:317434358
TEST=none
Change-Id: I43044e64c2c3a645ec0cad2ac903cc19ac89c9af
Signed-off-by: Jason Chen <jason.z.chen(a)intel.corp-partner.google.com>
---
M src/mainboard/google/rex/variants/screebo/overridetree.cb
1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/03/79803/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/79803?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I43044e64c2c3a645ec0cad2ac903cc19ac89c9af
Gerrit-Change-Number: 79803
Gerrit-PatchSet: 2
Gerrit-Owner: Jason Z Chen <jason.z.chen(a)intel.corp-partner.google.com>
Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com>
Gerrit-Reviewer: Jakub Czapiga <czapiga(a)google.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Tarun <tstuli(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Jason Z Chen <jason.z.chen(a)intel.corp-partner.google.com>
Gerrit-Attention: Eran Mitrani <mitrani(a)google.com>
Gerrit-Attention: Jakub Czapiga <czapiga(a)google.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Attention: Tarun <tstuli(a)gmail.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Dinesh Gehlot, Eran Mitrani, Jakub Czapiga, Jason Z Chen, Subrata Banik, Tarun.
Kapil Porwal has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79803?usp=email )
Change subject: mb/google/rex/var/screebo: Prevent camera LED blinking during boot
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/79803?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I43044e64c2c3a645ec0cad2ac903cc19ac89c9af
Gerrit-Change-Number: 79803
Gerrit-PatchSet: 1
Gerrit-Owner: Jason Z Chen <jason.z.chen(a)intel.corp-partner.google.com>
Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com>
Gerrit-Reviewer: Jakub Czapiga <czapiga(a)google.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Tarun <tstuli(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Jason Z Chen <jason.z.chen(a)intel.corp-partner.google.com>
Gerrit-Attention: Eran Mitrani <mitrani(a)google.com>
Gerrit-Attention: Jakub Czapiga <czapiga(a)google.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Attention: Tarun <tstuli(a)gmail.com>
Gerrit-Comment-Date: Tue, 02 Jan 2024 05:58:07 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Jason Z Chen has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/79803?usp=email )
Change subject: mb/google/rex/var/screebo: Prevent camera LED blinking during boot
......................................................................
mb/google/rex/var/screebo: Prevent camera LED blinking during boot
Configure _DSC to ACPI_DEVICE_SLEEP_D3_COLD so that driver skips
initial probe during kernel boot, preventing privacy LED blink.
BUG=b:317434358
TEST=none
Change-Id: I43044e64c2c3a645ec0cad2ac903cc19ac89c9af
---
M src/mainboard/google/rex/variants/screebo/overridetree.cb
1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/03/79803/1
diff --git a/src/mainboard/google/rex/variants/screebo/overridetree.cb b/src/mainboard/google/rex/variants/screebo/overridetree.cb
index 83366ae..a3ab01c 100644
--- a/src/mainboard/google/rex/variants/screebo/overridetree.cb
+++ b/src/mainboard/google/rex/variants/screebo/overridetree.cb
@@ -514,6 +514,7 @@
register "num_freq_entries" = "1"
register "link_freq[0]" = "400 * MHz"
register "remote_name" = ""IPU0""
+ register "max_dstate_for_probe" = "ACPI_DEVICE_SLEEP_D3_COLD"
register "has_power_resource" = "1"
#Controls
--
To view, visit https://review.coreboot.org/c/coreboot/+/79803?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I43044e64c2c3a645ec0cad2ac903cc19ac89c9af
Gerrit-Change-Number: 79803
Gerrit-PatchSet: 1
Gerrit-Owner: Jason Z Chen <jason.z.chen(a)intel.corp-partner.google.com>
Gerrit-MessageType: newchange