coreboot-gerrit January 2024

coreboot-gerrit@coreboot.org

1 participants
3044 discussions

[XS] Change in coreboot[main]: driver/wifi: DDR RFIM _DSM method function 3 report incorrect value
by Simon Yang (Code Review) 02 Jan '24

02 Jan '24

Simon Yang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79740?usp=email ) Change subject: driver/wifi: DDR RFIM _DSM method function 3 report incorrect value ...................................................................... Set Ready For Review -- To view, visit https://review.coreboot.org/c/coreboot/+/79740?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I642c56a9c3160cdb41b254dc75e126cacf905b14 Gerrit-Change-Number: 79740 Gerrit-PatchSet: 1 Gerrit-Owner: Simon Yang <simon1.yang(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 02 Jan 2024 07:05:33 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: mb/google/rex/var/screebo: Prevent camera LED blinking during boot
by Subrata Banik (Code Review) 02 Jan '24

02 Jan '24

Attention is currently required from: Dinesh Gehlot, Eran Mitrani, Jakub Czapiga, Jason Z Chen, Tarun. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79803?usp=email ) Change subject: mb/google/rex/var/screebo: Prevent camera LED blinking during boot ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/79803?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I43044e64c2c3a645ec0cad2ac903cc19ac89c9af Gerrit-Change-Number: 79803 Gerrit-PatchSet: 2 Gerrit-Owner: Jason Z Chen <jason.z.chen(a)intel.corp-partner.google.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Jakub Czapiga <czapiga(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun <tstuli(a)gmail.com> Gerrit-Reviewer: Wentao Qin <qinwentao(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jason Z Chen <jason.z.chen(a)intel.corp-partner.google.com> Gerrit-Attention: Eran Mitrani <mitrani(a)google.com> Gerrit-Attention: Jakub Czapiga <czapiga(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Tarun <tstuli(a)gmail.com> Gerrit-Comment-Date: Tue, 02 Jan 2024 06:16:17 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: mb/google/rex/var/screebo: Prevent camera LED blinking during boot
by Wentao Qin (Code Review) 02 Jan '24

02 Jan '24

Attention is currently required from: Dinesh Gehlot, Eran Mitrani, Jakub Czapiga, Jason Z Chen, Subrata Banik, Tarun. Wentao Qin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79803?usp=email ) Change subject: mb/google/rex/var/screebo: Prevent camera LED blinking during boot ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/79803?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I43044e64c2c3a645ec0cad2ac903cc19ac89c9af Gerrit-Change-Number: 79803 Gerrit-PatchSet: 2 Gerrit-Owner: Jason Z Chen <jason.z.chen(a)intel.corp-partner.google.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Jakub Czapiga <czapiga(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun <tstuli(a)gmail.com> Gerrit-Reviewer: Wentao Qin <qinwentao(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jason Z Chen <jason.z.chen(a)intel.corp-partner.google.com> Gerrit-Attention: Eran Mitrani <mitrani(a)google.com> Gerrit-Attention: Jakub Czapiga <czapiga(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Tarun <tstuli(a)gmail.com> Gerrit-Comment-Date: Tue, 02 Jan 2024 06:14:33 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: mb/google/rex/var/screebo: Prevent camera LED blinking during boot
by Jason Z Chen (Code Review) 02 Jan '24

02 Jan '24

Attention is currently required from: Dinesh Gehlot, Eran Mitrani, Jakub Czapiga, Jason Z Chen, Subrata Banik, Tarun. Hello Dinesh Gehlot, Eran Mitrani, Jakub Czapiga, Kapil Porwal, Subrata Banik, Tarun, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/79803?usp=email to look at the new patch set (#2). Change subject: mb/google/rex/var/screebo: Prevent camera LED blinking during boot ...................................................................... mb/google/rex/var/screebo: Prevent camera LED blinking during boot Configure _DSC to ACPI_DEVICE_SLEEP_D3_COLD so that driver skips initial probe during kernel boot, preventing privacy LED blink. BUG=b:317434358 TEST=none Change-Id: I43044e64c2c3a645ec0cad2ac903cc19ac89c9af Signed-off-by: Jason Chen <jason.z.chen(a)intel.corp-partner.google.com> --- M src/mainboard/google/rex/variants/screebo/overridetree.cb 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/03/79803/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/79803?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I43044e64c2c3a645ec0cad2ac903cc19ac89c9af Gerrit-Change-Number: 79803 Gerrit-PatchSet: 2 Gerrit-Owner: Jason Z Chen <jason.z.chen(a)intel.corp-partner.google.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Jakub Czapiga <czapiga(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun <tstuli(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jason Z Chen <jason.z.chen(a)intel.corp-partner.google.com> Gerrit-Attention: Eran Mitrani <mitrani(a)google.com> Gerrit-Attention: Jakub Czapiga <czapiga(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Tarun <tstuli(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

[XS] Change in coreboot[main]: mb/google/rex/var/screebo: Prevent camera LED blinking during boot
by Kapil Porwal (Code Review) 02 Jan '24

02 Jan '24

Attention is currently required from: Dinesh Gehlot, Eran Mitrani, Jakub Czapiga, Jason Z Chen, Subrata Banik, Tarun. Kapil Porwal has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79803?usp=email ) Change subject: mb/google/rex/var/screebo: Prevent camera LED blinking during boot ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/79803?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I43044e64c2c3a645ec0cad2ac903cc19ac89c9af Gerrit-Change-Number: 79803 Gerrit-PatchSet: 1 Gerrit-Owner: Jason Z Chen <jason.z.chen(a)intel.corp-partner.google.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Jakub Czapiga <czapiga(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun <tstuli(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jason Z Chen <jason.z.chen(a)intel.corp-partner.google.com> Gerrit-Attention: Eran Mitrani <mitrani(a)google.com> Gerrit-Attention: Jakub Czapiga <czapiga(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Tarun <tstuli(a)gmail.com> Gerrit-Comment-Date: Tue, 02 Jan 2024 05:58:07 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: mb/google/rex/var/screebo: Prevent camera LED blinking during boot
by Jason Z Chen (Code Review) 02 Jan '24

02 Jan '24

Jason Z Chen has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/79803?usp=email ) Change subject: mb/google/rex/var/screebo: Prevent camera LED blinking during boot ...................................................................... mb/google/rex/var/screebo: Prevent camera LED blinking during boot Configure _DSC to ACPI_DEVICE_SLEEP_D3_COLD so that driver skips initial probe during kernel boot, preventing privacy LED blink. BUG=b:317434358 TEST=none Change-Id: I43044e64c2c3a645ec0cad2ac903cc19ac89c9af --- M src/mainboard/google/rex/variants/screebo/overridetree.cb 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/03/79803/1 diff --git a/src/mainboard/google/rex/variants/screebo/overridetree.cb b/src/mainboard/google/rex/variants/screebo/overridetree.cb index 83366ae..a3ab01c 100644 --- a/src/mainboard/google/rex/variants/screebo/overridetree.cb +++ b/src/mainboard/google/rex/variants/screebo/overridetree.cb @@ -514,6 +514,7 @@ register "num_freq_entries" = "1" register "link_freq[0]" = "400 * MHz" register "remote_name" = ""IPU0"" + register "max_dstate_for_probe" = "ACPI_DEVICE_SLEEP_D3_COLD" register "has_power_resource" = "1" #Controls -- To view, visit https://review.coreboot.org/c/coreboot/+/79803?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I43044e64c2c3a645ec0cad2ac903cc19ac89c9af Gerrit-Change-Number: 79803 Gerrit-PatchSet: 1 Gerrit-Owner: Jason Z Chen <jason.z.chen(a)intel.corp-partner.google.com> Gerrit-MessageType: newchange

1 0

[XS] Change in coreboot[master]: mb/google/rex/var/screebo: Prevent camera LED blinking during boot
by Jason Z Chen (Code Review) 02 Jan '24

02 Jan '24

Jason Z Chen has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/79767?usp=email ) Change subject: mb/google/rex/var/screebo: Prevent camera LED blinking during boot ...................................................................... mb/google/rex/var/screebo: Prevent camera LED blinking during boot Configure _DSC to ACPI_DEVICE_SLEEP_D3_COLD so that driver skips initial probe during kernel boot, preventing privacy LED blink. BUG=b:317434358 TEST=none Change-Id: I43044e64c2c3a645ec0cad2ac903cc19ac89c9af --- M src/mainboard/google/rex/variants/screebo/overridetree.cb 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/67/79767/1 diff --git a/src/mainboard/google/rex/variants/screebo/overridetree.cb b/src/mainboard/google/rex/variants/screebo/overridetree.cb index 83366ae..a3ab01c 100644 --- a/src/mainboard/google/rex/variants/screebo/overridetree.cb +++ b/src/mainboard/google/rex/variants/screebo/overridetree.cb @@ -514,6 +514,7 @@ register "num_freq_entries" = "1" register "link_freq[0]" = "400 * MHz" register "remote_name" = ""IPU0"" + register "max_dstate_for_probe" = "ACPI_DEVICE_SLEEP_D3_COLD" register "has_power_resource" = "1" #Controls -- To view, visit https://review.coreboot.org/c/coreboot/+/79767?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I43044e64c2c3a645ec0cad2ac903cc19ac89c9af Gerrit-Change-Number: 79767 Gerrit-PatchSet: 1 Gerrit-Owner: Jason Z Chen <jason.z.chen(a)intel.corp-partner.google.com> Gerrit-MessageType: newchange

1 0

[XS] Change in coreboot[main]: soc/intel/meteorlake: Enable SSE2 accelerated RSA sign. verification
by Subrata Banik (Code Review) 02 Jan '24

02 Jan '24

Subrata Banik has submitted this change. ( https://review.coreboot.org/c/coreboot/+/79291?usp=email ) Change subject: soc/intel/meteorlake: Enable SSE2 accelerated RSA sign. verification ...................................................................... soc/intel/meteorlake: Enable SSE2 accelerated RSA sign. verification Enabling SSE2 accelerated RSA signature verification saves 4.7 ms of boot time. | modpow() function call | original | SSE2 Algorithm 2 | |----------------------------+----------+------------------| | coreboot/verstage - step 1 | 6.644 | 3.042 | | coreboot/verstage - step 2 | 1.891 | 0.757 | |----------------------------+----------+------------------| | Total (ms) | 8.535 | 3.799 | BUG=b:312709384 TEST=modular exponentiation is more than twice faster on rex0 Change-Id: I382e62a765dbf2027c4ac54d6eb19a9542a8c302 Signed-off-by: Jeremy Compostella <jeremy.compostella(a)intel.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/79291 Reviewed-by: Subrata Banik <subratabanik(a)google.com> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- M src/soc/intel/meteorlake/Kconfig 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Subrata Banik: Looks good to me, approved build bot (Jenkins): Verified diff --git a/src/soc/intel/meteorlake/Kconfig b/src/soc/intel/meteorlake/Kconfig index 756d499..5b78fdf 100644 --- a/src/soc/intel/meteorlake/Kconfig +++ b/src/soc/intel/meteorlake/Kconfig @@ -324,6 +324,7 @@ select VBOOT_VBNV_CMOS select VBOOT_VBNV_CMOS_BACKUP_TO_FLASH select VBOOT_X86_SHA256_ACCELERATION + select VBOOT_X86_RSA_ACCELERATION # Default hash block size is 1KiB. Increasing it to 4KiB to improve # hashing time as well as read time. -- To view, visit https://review.coreboot.org/c/coreboot/+/79291?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I382e62a765dbf2027c4ac54d6eb19a9542a8c302 Gerrit-Change-Number: 79291 Gerrit-PatchSet: 11 Gerrit-Owner: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Jakub Czapiga <czapiga(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun <tstuli(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[S] Change in coreboot[main]: mb/google/rex/var/karis: Enhance CNVi and PCIe switching
by Subrata Banik (Code Review) 02 Jan '24

02 Jan '24

Subrata Banik has submitted this change. ( https://review.coreboot.org/c/coreboot/+/79765?usp=email ) ( 2 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: mb/google/rex/var/karis: Enhance CNVi and PCIe switching ...................................................................... mb/google/rex/var/karis: Enhance CNVi and PCIe switching 1. Set PCIe related GPIOs to NC if fw_config use "WIFI_CNVI". 2. Set CNVi related GPIOs to NC if fw_config use "WIFI_PCIE". 3. Remove "ALC5650_NO_AMP_I2S" case in fw_config_gpio_padbased_override(). bt_i2s_enable_pads should not relevant to audio codec/amp, and it is already enabled in "WIFI_CNVI" case. BUG=b:312099281 TEST=Build and test on karis Change-Id: Ib1a32f1a38ae33cf992b80a3408aa8e2fa3ddab0 Signed-off-by: Tyler Wang <tyler.wang(a)quanta.corp-partner.google.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/79765 Reviewed-by: Subrata Banik <subratabanik(a)google.com> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- M src/mainboard/google/rex/variants/karis/fw_config.c 1 file changed, 21 insertions(+), 6 deletions(-) Approvals: Subrata Banik: Looks good to me, approved build bot (Jenkins): Verified diff --git a/src/mainboard/google/rex/variants/karis/fw_config.c b/src/mainboard/google/rex/variants/karis/fw_config.c index ae74a42..6dbf31d 100644 --- a/src/mainboard/google/rex/variants/karis/fw_config.c +++ b/src/mainboard/google/rex/variants/karis/fw_config.c @@ -35,12 +35,29 @@ }; static const struct pad_config cnvi_bt_disable_pads[] = { - /* GPP_F04 : [] ==> CNV_RF_RST_L */ + /* GPP_F00 : [] ==> CNV_BRI_DT_R */ + PAD_NC(GPP_F00, NONE), + /* GPP_F01 : [] ==> CNV_BRI_RSP */ + PAD_NC(GPP_F01, NONE), + /* GPP_F02 : [] ==> CNV_RGI_DT_Rl */ + PAD_NC(GPP_F02, NONE), + /* GPP_F03 : [] ==> CNV_RGI_RSP */ + PAD_NC(GPP_F03, NONE), + /* GPP_F04 : [] ==> CNV_RF_RST_L */ PAD_NC(GPP_F04, NONE), - /* GPP_F05 : [] ==> CNV_CLKREQ */ + /* GPP_F05 : [] ==> CNV_CLKREQ */ PAD_NC(GPP_F05, NONE), }; +static const struct pad_config discrete_bt_disable_pads[] = { + /* GPP_S01 : [] ==> SDW_HP_DATA_WLAN_PCM_SYNC */ + PAD_NC(GPP_S01, NONE), + /* GPP_S02 : [] ==> DMIC_SOC_CLK0_WLAN_PCM_OUT */ + PAD_NC(GPP_S02, NONE), + /* GPP_D21 : [] ==> WLAN_CLKREQ_ODLl */ + PAD_NC(GPP_D21, NONE), +}; + static const struct pad_config bt_i2s_enable_pads[] = { /* GPP_V30 : [] ==> BT_I2S_BCLK */ PAD_CFG_NF(GPP_VGPIO30, NONE, DEEP, NF2), @@ -81,13 +98,11 @@ printk(BIOS_INFO, "Configure GPIOs for no FP module.\n"); GPIO_PADBASED_OVERRIDE(padbased_table, fp_disable_pads); } - if (fw_config_probe(FW_CONFIG(AUDIO, ALC5650_NO_AMP_I2S))) { - printk(BIOS_INFO, "Configure GPIOs for BT offload mode.\n"); - GPIO_PADBASED_OVERRIDE(padbased_table, bt_i2s_enable_pads); - } if (fw_config_probe(FW_CONFIG(WIFI_TYPE, WIFI_CNVI))) { printk(BIOS_INFO, "Configure GPIOs for CNVi WIFI/BT module.\n"); GPIO_PADBASED_OVERRIDE(padbased_table, bt_i2s_enable_pads); + printk(BIOS_INFO, "Disable GPIOs for PCIe WIFI/BT module.\n"); + GPIO_PADBASED_OVERRIDE(padbased_table, discrete_bt_disable_pads); } if (fw_config_probe(FW_CONFIG(WIFI_TYPE, WIFI_PCIE))) { printk(BIOS_INFO, "Configure GPIOs for discrete WIFI/BT module.\n"); -- To view, visit https://review.coreboot.org/c/coreboot/+/79765?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ib1a32f1a38ae33cf992b80a3408aa8e2fa3ddab0 Gerrit-Change-Number: 79765 Gerrit-PatchSet: 4 Gerrit-Owner: Tyler Wang <tyler.wang(a)quanta.corp-partner.google.com> Gerrit-Reviewer: David Wu <david_wu(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Jack Lai <jack.lai(a)intel.corp-partner.google.com> Gerrit-Reviewer: Jakub Czapiga <czapiga(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Mac Chiang <mac.chiang(a)intel.corp-partner.google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun <tstuli(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: merged

1 0

[S] Change in blobs[main]: soc/mediatek/mt8192: Update dram.elf from 1.6.3 to 1.8.3
by Yu-Ping Wu (Code Review) 02 Jan '24

02 Jan '24

Yu-Ping Wu has submitted this change. ( https://review.coreboot.org/c/blobs/+/79371?usp=email ) ( 2 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: soc/mediatek/mt8192: Update dram.elf from 1.6.3 to 1.8.3 ...................................................................... soc/mediatek/mt8192: Update dram.elf from 1.6.3 to 1.8.3 To sync DRAMC_PARAM_HEADER_VERSION with CB:61132 and CB:62549, update dram.elf from ChromeOS build 15692.0.0. BUG=b:315082772 Change-Id: I2ec5b724cf69892f04eea3c512cb28efafc02031 Signed-off-by: Yu-Ping Wu <yupingso(a)chromium.org> --- M soc/mediatek/mt8192/dram.elf M soc/mediatek/mt8192/dram.elf.md5 M soc/mediatek/mt8192/dram_release_notes.txt 3 files changed, 19 insertions(+), 1 deletion(-) Approvals: Yidi Lin: Looks good to me, approved Yu-Ping Wu: Verified diff --git a/soc/mediatek/mt8192/dram.elf b/soc/mediatek/mt8192/dram.elf index 5f249eb..e08d4df 100644 --- a/soc/mediatek/mt8192/dram.elf +++ b/soc/mediatek/mt8192/dram.elf Binary files differ diff --git a/soc/mediatek/mt8192/dram.elf.md5 b/soc/mediatek/mt8192/dram.elf.md5 index e3b7984..fa2fac2 100644 --- a/soc/mediatek/mt8192/dram.elf.md5 +++ b/soc/mediatek/mt8192/dram.elf.md5 @@ -1 +1 @@ -b0873be4ce5cecc432b21977022ae852 *dram.elf +e7901dd5e89e46550e74052b6c09b26a *dram.elf diff --git a/soc/mediatek/mt8192/dram_release_notes.txt b/soc/mediatek/mt8192/dram_release_notes.txt index 78d6656..e95154d 100644 --- a/soc/mediatek/mt8192/dram_release_notes.txt +++ b/soc/mediatek/mt8192/dram_release_notes.txt @@ -1,3 +1,21 @@ +# 1.8.3 + +1. ChromeOS build from 15692.0.0. + Protocol (params header) version: 8 + +2. Include changes: + + CL:*3960051 dramc: Remove duplicate enum declaration + CL:*4389197 mtk-dramk/mt8186,8192,8195: Extract dramc_param_header to common header + CL:*4492533 mtk-dramk: Add 'extern' keyword for do_putc() + CL:*4585853 mtk-dramk/mt8186,8192,8195: Refactor dramc_param to share more structures + CL:*4585213 mt8192: refactor: Move cros-specific files to 'cros/' folder + CL:*4585433 refactor: move the shared */cros/{driver,lib} to common/cros + CL:*4585613 refactor: merge cros/inc and cros/include folders + CL:*4588151 refactor: move dramc_param to common/cros + CL:*4916638 mtk-dramk: Remove trailing whitespaces and newlines + CL:*4933741 mtk-dramk: Refactor emi files + # 1.6.3 1. Chrome OS build from 13885.22.0. -- To view, visit https://review.coreboot.org/c/blobs/+/79371?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: blobs Gerrit-Branch: main Gerrit-Change-Id: I2ec5b724cf69892f04eea3c512cb28efafc02031 Gerrit-Change-Number: 79371 Gerrit-PatchSet: 3 Gerrit-Owner: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-MessageType: merged

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit January 2024