January 2024 - coreboot-gerrit

[S] Change in coreboot[main]: vendorcode/google/chromeos: Use unsigned int for "factory_config"
by Subrata Banik (Code Review) Jan. 2, 2024

Jan. 2, 2024

Subrata Banik has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/79769?usp=email ) Change subject: vendorcode/google/chromeos: Use unsigned int for "factory_config" ...................................................................... vendorcode/google/chromeos: Use unsigned int for "factory_config" This patch ensures `chromeos_get_factory_config()` returns an unsigned integer value because factory config represents bit-fields to determine the Chromebook Plus branding. BUG=b:317880956 TEST=Able to verify that google/screebo is branded as Chromebook Plus. Change-Id: I3021b8646de4750b4c8e2a2981f42500894fa2d0 Signed-off-by: Subrata Banik <subratabanik(a)google.com> --- M src/vendorcode/google/chromeos/chromeos.h M src/vendorcode/google/chromeos/tpm_factory_config.c 2 files changed, 12 insertions(+), 10 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/69/79769/1 diff --git a/src/vendorcode/google/chromeos/chromeos.h b/src/vendorcode/google/chromeos/chromeos.h index 0c5e4f7..5b8c8a0a 100644 --- a/src/vendorcode/google/chromeos/chromeos.h +++ b/src/vendorcode/google/chromeos/chromeos.h @@ -17,6 +17,8 @@ static inline void reboot_from_watchdog(void) { return; } #endif /* CONFIG_CHROMEOS */ +#define CHROMEOS_ERROR ~((uint64_t)0) + /** * Perform any platform specific actions required prior to resetting the Cr50. * Defined as weak function in cr50_enable_update.c @@ -29,9 +31,9 @@ /* * The factory config space is a one-time programmable info page. * For the unprovisioned one, the read will be 0x0. - * Return `-1` in case of error. + * Return "CHROMEOS_ERROR" in case of error. */ -int64_t chromeos_get_factory_config(void); +uint64_t chromeos_get_factory_config(void); /* * Determines whether a ChromeOS device is branded as a Chromebook Plus * based on specific bit flags: diff --git a/src/vendorcode/google/chromeos/tpm_factory_config.c b/src/vendorcode/google/chromeos/tpm_factory_config.c index 4f8801a..022fd48 100644 --- a/src/vendorcode/google/chromeos/tpm_factory_config.c +++ b/src/vendorcode/google/chromeos/tpm_factory_config.c @@ -9,11 +9,11 @@ #define CHROMEBOOK_PLUS_SOFT_BRANDED BIT(0) #define CHROMEBOOK_PLUS_DEVICE (CHROMEBOOK_PLUS_HARD_BRANDED | CHROMEBOOK_PLUS_SOFT_BRANDED) -int64_t chromeos_get_factory_config(void) +uint64_t chromeos_get_factory_config(void) { - static int64_t factory_config = -1; + static uint64_t factory_config = CHROMEOS_ERROR; - if (factory_config >= 0) + if (factory_config != CHROMEOS_ERROR) return factory_config; /* Initialize TPM driver. */ @@ -21,15 +21,15 @@ if (rc != TPM_SUCCESS) { printk(BIOS_ERR, "%s:%d - tlcl_lib_init() failed: %#x\n", __func__, __LINE__, rc); - return -1; + return CHROMEOS_ERROR; } - rc = tlcl_cr50_get_factory_config((uint64_t *)&factory_config); + rc = tlcl_cr50_get_factory_config(&factory_config); if (rc != TPM_SUCCESS) { printk(BIOS_ERR, "%s:%d - tlcl_cr50_get_factory_config() failed: %#x\n", __func__, __LINE__, rc); - return -1; + return CHROMEOS_ERROR; } return factory_config; @@ -48,9 +48,9 @@ */ bool chromeos_device_branded_plus(void) { - int64_t factory_config = chromeos_get_factory_config(); + uint64_t factory_config = chromeos_get_factory_config(); - if (factory_config < 0) + if (factory_config == CHROMEOS_ERROR) return false; return factory_config & CHROMEBOOK_PLUS_DEVICE; -- To view, visit https://review.coreboot.org/c/coreboot/+/79769?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I3021b8646de4750b4c8e2a2981f42500894fa2d0 Gerrit-Change-Number: 79769 Gerrit-PatchSet: 1 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-MessageType: newchange

1 0

[XS] Change in coreboot[main]: mb/google/brya: Enable CSE telemetry for ADL-N
by Subrata Banik (Code Review) Jan. 2, 2024

Jan. 2, 2024

Attention is currently required from: Eran Mitrani, Eric Lai, Kapil Porwal, Nick Vaccaro. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79768?usp=email ) Change subject: mb/google/brya: Enable CSE telemetry for ADL-N ...................................................................... Patch Set 1: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/79768/comment/8c9b5897_e6fa1d75 : PS1, Line 9: Enable CSE telemetry for ADL-N. redundant line. ideally you might like to add a description about what this CL is expected to do -- To view, visit https://review.coreboot.org/c/coreboot/+/79768?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I3f90d0462cb766655bf8e59a90bc550ceefb2256 Gerrit-Change-Number: 79768 Gerrit-PatchSet: 1 Gerrit-Owner: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Eric Lai <ericllai(a)google.com> Gerrit-Attention: Eran Mitrani <mitrani(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Comment-Date: Tue, 02 Jan 2024 17:33:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: Documentation: Update internal URL's
by Jon Murphy (Code Review) Jan. 2, 2024

Jan. 2, 2024

Attention is currently required from: Martin L Roth, Matt DeVillier. Hello Martin L Roth, Matt DeVillier, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/79785?usp=email to look at the new patch set (#2). Change subject: Documentation: Update internal URL's ...................................................................... Documentation: Update internal URL's Update URL's to point to head rather than the deprecated refs/heads/master. Change-Id: I16f0c087762ff049115b67de3ac0b881aa4e4b40 Signed-off-by: Jon Murphy <jpmurphy(a)google.com> --- M Documentation/mainboard/ocp/deltalake.md M README.md 2 files changed, 2 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/85/79785/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/79785?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I16f0c087762ff049115b67de3ac0b881aa4e4b40 Gerrit-Change-Number: 79785 Gerrit-PatchSet: 2 Gerrit-Owner: Jon Murphy <jpmurphy(a)google.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-MessageType: newpatchset

1 0

[XS] Change in coreboot[main]: Documentation: Update internal URL's
by Jon Murphy (Code Review) Jan. 2, 2024

Jan. 2, 2024

Jon Murphy has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/79785?usp=email ) Change subject: Documentation: Update internal URL's ...................................................................... Documentation: Update internal URL's Update URL's to point to head rather than the deprecated refs/heads/master. Change-Id: I16f0c087762ff049115b67de3ac0b881aa4e4b40 Signed-off-by: Jon Murphy <jpmurphy(a)google.com> --- M Documentation/mainboard/ocp/deltalake.md M README.md 2 files changed, 2 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/85/79785/1 diff --git a/Documentation/mainboard/ocp/deltalake.md b/Documentation/mainboard/ocp/deltalake.md index d0573f3..d4c0656 100644 --- a/Documentation/mainboard/ocp/deltalake.md +++ b/Documentation/mainboard/ocp/deltalake.md @@ -222,4 +222,4 @@ [All about u-root]: https://github.com/linuxboot/book/tree/master/u-root [u-root]: https://u-root.org/ [ChromeOS VPD]: https://chromium.googlesource.com/chromiumos/platform/vpd/+/master/README.md -[src/mainboard/ocp/deltalake/vpd.h]: https://review.coreboot.org/plugins/gitiles/coreboot/+/refs/heads/master/sr… +[src/mainboard/ocp/deltalake/vpd.h]: https://review.coreboot.org/plugins/gitiles/coreboot/+/HEAD/src/mainboard/o… diff --git a/README.md b/README.md index eef5eb6..677d62d 100644 --- a/README.md +++ b/README.md @@ -30,7 +30,7 @@ instance](https://review.coreboot.org/). The code may be browsed via [coreboot's Gitiles -instance](https://review.coreboot.org/plugins/gitiles/coreboot/+/refs/heads/master). +instance](https://review.coreboot.org/plugins/gitiles/coreboot/+/HEAD). The coreboot project also maintains a [mirror](https://github.com/coreboot/coreboot) of the project on github. -- To view, visit https://review.coreboot.org/c/coreboot/+/79785?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I16f0c087762ff049115b67de3ac0b881aa4e4b40 Gerrit-Change-Number: 79785 Gerrit-PatchSet: 1 Gerrit-Owner: Jon Murphy <jpmurphy(a)google.com> Gerrit-MessageType: newchange

1 0

[XS] Change in coreboot[main]: mb/google/brya: Enable CSE telemetry for ADL-N
by Kapil Porwal (Code Review) Jan. 2, 2024

Jan. 2, 2024

Attention is currently required from: Eran Mitrani, Nick Vaccaro, Subrata Banik. Kapil Porwal has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79768?usp=email ) Change subject: mb/google/brya: Enable CSE telemetry for ADL-N ...................................................................... Patch Set 1: This change is ready for review. -- To view, visit https://review.coreboot.org/c/coreboot/+/79768?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I3f90d0462cb766655bf8e59a90bc550ceefb2256 Gerrit-Change-Number: 79768 Gerrit-PatchSet: 1 Gerrit-Owner: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Eran Mitrani <mitrani(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Comment-Date: Tue, 02 Jan 2024 17:27:42 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: vendorcode/google/chromeos: Add API to read factory config
by Tim Van Patten (Code Review) Jan. 2, 2024

Jan. 2, 2024

Attention is currently required from: Subrata Banik. Tim Van Patten has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79737?usp=email ) Change subject: vendorcode/google/chromeos: Add API to read factory config ...................................................................... Patch Set 8: (1 comment) File src/vendorcode/google/chromeos/tpm_factory_config.c: https://review.coreboot.org/c/coreboot/+/79737/comment/4c5a07ad_5a1f5d31 : PS8, Line 7: int64_t > > I don't think it's a good idea to make this signed everywhere, it's not a signed number, it's a bi […] Alternatively, follow the same convention as `tlcl_cr50_get_factory_config()` and return a result enum value while taking a `uint64_t *` whose underlying value is updated by `tlcl_cr50_get_factory_config()`. ``` tpm_result_t tlcl_cr50_get_factory_config(uint64_t *factory_config); ``` Plenty of ways to skin the cat. -- To view, visit https://review.coreboot.org/c/coreboot/+/79737?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I34f47c9a94972534cda656ef624ef12ed5ddeb06 Gerrit-Change-Number: 79737 Gerrit-PatchSet: 8 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tim Van Patten <timvp(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Julius Werner <jwerner(a)chromium.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Comment-Date: Tue, 02 Jan 2024 17:00:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com> Comment-In-Reply-To: Julius Werner <jwerner(a)chromium.org> Gerrit-MessageType: comment

1 0

[M] Change in coreboot[main]: soc/amd/picasso/acpi: move SoC-common code from dsdt.asl to soc.asl
by Matt DeVillier (Code Review) Jan. 2, 2024

Jan. 2, 2024

Attention is currently required from: Felix Held, Fred Reitberger, Jason Glenesk, Jason Nien, Martin Roth. Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79653?usp=email ) Change subject: soc/amd/picasso/acpi: move SoC-common code from dsdt.asl to soc.asl ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/79653?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Id4ed3a3d3cb55c8b3b474c66a7c1700e24fe908e Gerrit-Change-Number: 79653 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Tue, 02 Jan 2024 16:38:01 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: arch/x86: introduce HAVE_CONFIGURABLE_APMC_SMI_PORT
by Matt DeVillier (Code Review) Jan. 2, 2024

Jan. 2, 2024

Attention is currently required from: Felix Held, Fred Reitberger, Jason Glenesk. Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79566?usp=email ) Change subject: arch/x86: introduce HAVE_CONFIGURABLE_APMC_SMI_PORT ...................................................................... Patch Set 3: (1 comment) File src/arch/x86/Kconfig: https://review.coreboot.org/c/coreboot/+/79566/comment/1b5b6919_baf7b4b0 : PS3, Line 322: non-fixed APMC SMI command port what exactly does non-fixed mean here? dynamically assigned by another firmware component? -- To view, visit https://review.coreboot.org/c/coreboot/+/79566?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Iaceb61b0f2a630d7afe2e0780b6a2a9806ea62f9 Gerrit-Change-Number: 79566 Gerrit-PatchSet: 3 Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Tue, 02 Jan 2024 16:11:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: vendorcode/google/chromeos: Add API to read factory config
by Subrata Banik (Code Review) Jan. 2, 2024

Jan. 2, 2024

Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79737?usp=email ) Change subject: vendorcode/google/chromeos: Add API to read factory config ...................................................................... Patch Set 8: (1 comment) File src/vendorcode/google/chromeos/tpm_factory_config.c: https://review.coreboot.org/c/coreboot/+/79737/comment/8e1853ac_4291ddf9 : PS8, Line 7: int64_t > I don't think it's a good idea to make this signed everywhere, it's not a signed number, it's a bit field. Even if the top bit will never be allocated, making it signed is confusing. > > You can still use `~(uint64_t)0` as a sentinel value even if it's an unsigned number (e.g. like `UNDEFINED_FW_CONFIG`). good suggestion. -- To view, visit https://review.coreboot.org/c/coreboot/+/79737?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I34f47c9a94972534cda656ef624ef12ed5ddeb06 Gerrit-Change-Number: 79737 Gerrit-PatchSet: 8 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tim Van Patten <timvp(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Julius Werner <jwerner(a)chromium.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Tue, 02 Jan 2024 15:08:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Julius Werner <jwerner(a)chromium.org> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: vendorcode/google/chromeos: Add API to read factory config
by Julius Werner (Code Review) Jan. 2, 2024

Jan. 2, 2024

Attention is currently required from: Subrata Banik. Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79737?usp=email ) Change subject: vendorcode/google/chromeos: Add API to read factory config ...................................................................... Patch Set 8: (1 comment) File src/vendorcode/google/chromeos/tpm_factory_config.c: https://review.coreboot.org/c/coreboot/+/79737/comment/d90e81ca_4a4b2b2a : PS8, Line 7: int64_t I don't think it's a good idea to make this signed everywhere, it's not a signed number, it's a bit field. Even if the top bit will never be allocated, making it signed is confusing. You can still use `~(uint64_t)0` as a sentinel value even if it's an unsigned number (e.g. like `UNDEFINED_FW_CONFIG`). -- To view, visit https://review.coreboot.org/c/coreboot/+/79737?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I34f47c9a94972534cda656ef624ef12ed5ddeb06 Gerrit-Change-Number: 79737 Gerrit-PatchSet: 8 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tim Van Patten <timvp(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Julius Werner <jwerner(a)chromium.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Comment-Date: Tue, 02 Jan 2024 14:53:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0