Attention is currently required from: Dtrain Hsu, Eric Lai, Kenny Pan, Nick Vaccaro, Paul Menzel, Shou-Chieh Hsu, Subrata Banik.
Rex Chou has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79764?usp=email )
Change subject: mb/google/nissa/var/craaskov: Implement touchscreen power sequencing
......................................................................
Patch Set 2:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/79764/comment/cb15d7eb_f407cbfe :
PS1, Line 2: rex_chou
> Done
Done
https://review.coreboot.org/c/coreboot/+/79764/comment/040c1c1a_8d0b3070 :
PS1, Line 11: This will allow coreboot
: to detect the presence of i2c touchscreens during ACPI SSDT generation
: (implemented in a subsequent commit).
:
> removed
Done
https://review.coreboot.org/c/coreboot/+/79764/comment/2e4af5cd_95eef3fe :
PS1, Line 18: Change-Id: I85f2bee58582c0f56331d20a2984a3079c967be4
: Signed-off-by: rex_chou <rex_chou(a)compal.corp-partner.google.com>
:
: Change-Id: I3ca2e2d12a86eaae9e37870a2541c0287e354690
:
> "Change-Id: I3ca2e2d12a86eaae9e37870a2541c0287e354690" is the correct.
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/79764?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I3ca2e2d12a86eaae9e37870a2541c0287e354690
Gerrit-Change-Number: 79764
Gerrit-PatchSet: 2
Gerrit-Owner: Rex Chou <rex_chou(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Eric Lai <ericllai(a)google.com>
Gerrit-Reviewer: Ian Feng <ian_feng(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Kenny Pan <kennypan(a)google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Reviewer: Shou-Chieh Hsu <shouchieh(a)google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Van Chen <van_chen(a)compal.corp-partner.google.com>
Gerrit-Attention: Eric Lai <ericllai(a)google.com>
Gerrit-Attention: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Attention: Kenny Pan <kennypan(a)google.com>
Gerrit-Attention: Shou-Chieh Hsu <shouchieh(a)google.com>
Gerrit-Comment-Date: Thu, 04 Jan 2024 00:50:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Eric Lai <ericllai(a)google.com>
Comment-In-Reply-To: Rex Chou <rex_chou(a)compal.corp-partner.google.com>
Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-MessageType: comment
Attention is currently required from: Mike Banon.
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/64873?usp=email
to look at the new patch set (#11).
The following approvals got outdated and were removed:
Verified-1 by build bot (Jenkins)
Change subject: csb_patcher.sh: gets,checks,installs the coreboot and SeaBIOS patches
......................................................................
csb_patcher.sh: gets,checks,installs the coreboot and SeaBIOS patches
Conveniently and securely gets, checks SHA256 and installs some of my
patches from this page - https://review.coreboot.org/q/status:open+banon
- and also gets a collection of useful floppy-based operating systems.
Sometimes it takes quite a long time to get a patch merged, while the
people might need it today! - and this script could be really helpful.
It asks a [Y/N] question for every addition, and since there are some
"universal" patches as well as great floppies, you may still want to
run this script - even if your board is not Lenovo G505S or not AMD.
Use restore_agesa.sh script to restore AMD AGESA boards before running.
Please share your feedback and tell me about the other useful patches,
preferably the "universal" ones - i.e. SeaBIOS. Currently included:
1) "board-specific": Lenovo G505S discrete GPU support, board-specific
SeaBIOS options, known good AtomBIOS ROMs, good IRQ routing for AMD
Lenovo G505S, ASUS A88XM-E and AM1I-A boards, example configs for
G505S / AM1I-A / A88XM-E, and avoid the apu/amdfw wasting CBFS space.
2) "universal": SeaBIOS patches: advanced_bootmenu, multiple_floppies,
smbios_mptable_768; and also a floppies collection: KolibriOS, FreeDOS,
MichalOS, Visopsys, Snowdrop, Fiwix, Memtest, Tatos, Plop, FloppyBird.
Run ./csb_patcher.sh help or ./csb_patcher.sh usage for more usage info.
Send all your questions/suggestions to [ mikebdp2 [at] gmail [d0t] c0m ]
Change-Id: Ia392bad869a82707380d3a1e3c51b3e15f4f02f2
---
A csb_patcher.sh
1 file changed, 941 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/73/64873/11
--
To view, visit https://review.coreboot.org/c/coreboot/+/64873?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ia392bad869a82707380d3a1e3c51b3e15f4f02f2
Gerrit-Change-Number: 64873
Gerrit-PatchSet: 11
Gerrit-Owner: Mike Banon <mikebdp2(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Martin L Roth <gaumless(a)gmail.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Attention: Mike Banon <mikebdp2(a)gmail.com>
Gerrit-MessageType: newpatchset
Mike Banon has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/79774?usp=email )
Change subject: src/southbridge/amd/agesa/hudson: avoid the apu/amdfw wasting CBFS space
......................................................................
src/southbridge/amd/agesa/hudson: avoid the apu/amdfw wasting CBFS space
apu/amdfw section at CBFS is often empty for these AMD opensource AGESA
platforms: they do not contain a PSP "backdoor" so do not need to store
the "AMDFW" inside CBFS, and XHCI/IMC/GEC binary blobs are rarely used.
Therefore, if XHCI/IMC/GEC binary blobs are not specified, apu/amdfw
section should be excluded to avoid wasting around 200 KB of CBFS.
Change-Id: I8c5865d83294ee59bf92b1611b9365b2c2d23539
Signed-off-by: Mike Banon <mikebdp2(a)gmail.com>
---
M src/southbridge/amd/agesa/hudson/Makefile.inc
1 file changed, 4 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/74/79774/1
diff --git a/src/southbridge/amd/agesa/hudson/Makefile.inc b/src/southbridge/amd/agesa/hudson/Makefile.inc
index b8eb5b9..94b0620 100644
--- a/src/southbridge/amd/agesa/hudson/Makefile.inc
+++ b/src/southbridge/amd/agesa/hudson/Makefile.inc
@@ -60,6 +60,8 @@
OPT_HUDSON_IMC_FWM_FILE=$(call add_opt_prefix, $(CONFIG_HUDSON_IMC_FWM_FILE), --imc)
OPT_HUDSON_GEC_FWM_FILE=$(call add_opt_prefix, $(CONFIG_HUDSON_GEC_FWM_FILE), --gec)
+ifneq ($(CONFIG_HUDSON_XHCI_FWM_FILE)$(CONFIG_HUDSON_IMC_FWM_FILE)$(CONFIG_HUDSON_GEC_FWM_FILE),)
+
$(obj)/amdfw.rom: $(call strip_quotes, $(CONFIG_HUDSON_XHCI_FWM_FILE)) \
$(call strip_quotes, $(CONFIG_HUDSON_IMC_FWM_FILE)) \
$(call strip_quotes, $(CONFIG_HUDSON_GEC_FWM_FILE)) \
@@ -77,3 +79,5 @@
apu/amdfw-file := $(obj)/amdfw.rom
apu/amdfw-position := $(HUDSON_FWM_POSITION)
apu/amdfw-type := raw
+
+endif
--
To view, visit https://review.coreboot.org/c/coreboot/+/79774?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I8c5865d83294ee59bf92b1611b9365b2c2d23539
Gerrit-Change-Number: 79774
Gerrit-PatchSet: 1
Gerrit-Owner: Mike Banon <mikebdp2(a)gmail.com>
Gerrit-MessageType: newchange
Attention is currently required from: Patrick Rudolph.
Hello Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/79786?usp=email
to look at the new patch set (#2).
Change subject: mb/prodrive/hermes: Change UART from hidden to on
......................................................................
mb/prodrive/hermes: Change UART from hidden to on
If the generic device is hidden coreboot errors with '[EMERG]
GENERIC: 0.0 missing resource: 10'. Enabling it solves the issue.
Change-Id: If24e1bf920c0b3edaefb4e20af66e33f4ddc1f3f
Signed-off-by: Christian Walter <christian.walter(a)9elements.com>
---
M src/mainboard/prodrive/hermes/devicetree.cb
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/86/79786/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/79786?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: If24e1bf920c0b3edaefb4e20af66e33f4ddc1f3f
Gerrit-Change-Number: 79786
Gerrit-PatchSet: 2
Gerrit-Owner: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-MessageType: newpatchset
Christian Walter has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/79786?usp=email )
Change subject: mb/prodrive/hermes: Change UART from hidden to on
......................................................................
mb/prodrive/hermes: Change UART from hidden to on
If the generic device is hidden coreboot errors with '[EMERG] GENERIC: 0.0
missing resource: 10'. Enabling it solves the issue.
Change-Id: If24e1bf920c0b3edaefb4e20af66e33f4ddc1f3f
Signed-off-by: Christian Walter <christian.walter(a)9elements.com>
---
M src/mainboard/prodrive/hermes/devicetree.cb
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/86/79786/1
diff --git a/src/mainboard/prodrive/hermes/devicetree.cb b/src/mainboard/prodrive/hermes/devicetree.cb
index 024b97d..b6d23d8 100644
--- a/src/mainboard/prodrive/hermes/devicetree.cb
+++ b/src/mainboard/prodrive/hermes/devicetree.cb
@@ -173,7 +173,7 @@
device pci 19.2 hidden
chip soc/intel/common/block/uart
register "devid" = "PCI_DID_INTEL_CNP_H_UART2"
- device generic 0 hidden end
+ device generic 0 on end
end
end # UART #2, in ACPI mode
device pci 1b.4 on # PCIe root port 21 (Slot 1)
--
To view, visit https://review.coreboot.org/c/coreboot/+/79786?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: If24e1bf920c0b3edaefb4e20af66e33f4ddc1f3f
Gerrit-Change-Number: 79786
Gerrit-PatchSet: 1
Gerrit-Owner: Christian Walter <christian.walter(a)9elements.com>
Gerrit-MessageType: newchange
Attention is currently required from: Angel Pons, Felix Held.
Jonathon Hall has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/77670?usp=email )
Change subject: mb/purism/librem_cnl: Add ramtop to cmos.layout for librem_mini
......................................................................
Patch Set 5:
(1 comment)
Patchset:
PS4:
I just realized this hadn't been merged. Is there any issue merging this? This is needed to build Librem Mini v1/v2 with CONFIG_USE_OPTION_TABLE=y.
--
To view, visit https://review.coreboot.org/c/coreboot/+/77670?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I2bf71f2dd79f2e1e2e13f62a3e08103336bbad61
Gerrit-Change-Number: 77670
Gerrit-PatchSet: 5
Gerrit-Owner: Jonathon Hall <jonathon.hall(a)puri.sm>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Comment-Date: Wed, 03 Jan 2024 21:59:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment