Attention is currently required from: Hung-Te Lin, Ruihai Zhou, Yidi Lin, Yu-Ping Wu, cong yang.
Hello Hung-Te Lin, Yidi Lin, Yu-Ping Wu, build bot (Jenkins), cong yang,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/79845?usp=email
to look at the new patch set (#3).
The following approvals got outdated and were removed:
Verified+1 by build bot (Jenkins)
Change subject: mb/google/geralt: Enable IVO_T109NW41 MIPI panel for Ciri
......................................................................
mb/google/geralt: Enable IVO_T109NW41 MIPI panel for Ciri
The IVO_T109NW41 will be the second source MIPI panel for Ciri.
BUG=b:319025360
TEST=boot Ciri with IVO_T109NW41 panel, see firmware screen
BRANCH=None
Change-Id: I9dc2228d39bb8bb048d1f37727c96b0ad621e912
Signed-off-by: Ruihai Zhou <zhouruihai(a)huaqin.corp-partner.google.com>
---
M src/mainboard/google/geralt/Kconfig
M src/mainboard/google/geralt/panel_ciri.c
2 files changed, 10 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/45/79845/3
--
To view, visit https://review.coreboot.org/c/coreboot/+/79845?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I9dc2228d39bb8bb048d1f37727c96b0ad621e912
Gerrit-Change-Number: 79845
Gerrit-PatchSet: 3
Gerrit-Owner: Ruihai Zhou <zhouruihai(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Reviewer: cong yang <yangcong5(a)huaqin.corp-partner.google.com>
Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Attention: Ruihai Zhou <zhouruihai(a)huaqin.corp-partner.google.com>
Gerrit-Attention: cong yang <yangcong5(a)huaqin.corp-partner.google.com>
Gerrit-Attention: Yidi Lin <yidilin(a)google.com>
Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: cong yang.
Hello cong yang,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/79897?usp=email
to look at the new patch set (#2).
Change subject: drivers/mipi: Update init code for BOE_NV110WUM_L60
......................................................................
drivers/mipi: Update init code for BOE_NV110WUM_L60
1. Correct bank1 to bank0
2. Adjust CLK duty
3. Fix abnormal power off setting
4. Change VDDE power off frame from VGL to VGH
Fixes: 0d50536("drivers/mipi: Add support for BOE_NV110WUM_L60 panel")
BUG=b:319398058
TEST=boot Ciri with BOE_NV110WUM_L60 and see firmware screen
Change-Id: I2f068ba0ec9dede3e3361b55c38a8eca8793905a
Signed-off-by: Ruihai Zhou <zhouruihai(a)huaqin.corp-partner.google.com>
---
M src/drivers/mipi/panel-BOE_NV110WUM_L60.c
1 file changed, 5 insertions(+), 5 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/97/79897/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/79897?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I2f068ba0ec9dede3e3361b55c38a8eca8793905a
Gerrit-Change-Number: 79897
Gerrit-PatchSet: 2
Gerrit-Owner: Ruihai Zhou <zhouruihai(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: cong yang <yangcong5(a)huaqin.corp-partner.google.com>
Gerrit-Attention: cong yang <yangcong5(a)huaqin.corp-partner.google.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: cong yang.
Ruihai Zhou has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79897?usp=email )
Change subject: drivers/mipi: Update init code for BOE_NV110WUM_L60
......................................................................
Patch Set 1:
This change is ready for review.
--
To view, visit https://review.coreboot.org/c/coreboot/+/79897?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I2f068ba0ec9dede3e3361b55c38a8eca8793905a
Gerrit-Change-Number: 79897
Gerrit-PatchSet: 1
Gerrit-Owner: Ruihai Zhou <zhouruihai(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: cong yang <yangcong5(a)huaqin.corp-partner.google.com>
Gerrit-Attention: cong yang <yangcong5(a)huaqin.corp-partner.google.com>
Gerrit-Comment-Date: Thu, 11 Jan 2024 06:27:26 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Hung-Te Lin, Ruihai Zhou, Yidi Lin, Yu-Ping Wu, cong yang.
Hello Hung-Te Lin, Yidi Lin, Yu-Ping Wu, build bot (Jenkins), cong yang,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/79845?usp=email
to look at the new patch set (#2).
The following approvals got outdated and were removed:
Code-Review+1 by cong yang, Verified+1 by build bot (Jenkins)
Change subject: mb/google/geralt: Enable IVO_T109NW41 MIPI panel for Ciri
......................................................................
mb/google/geralt: Enable IVO_T109NW41 MIPI panel for Ciri
The IVO_T109NW41 will be the second source MIPI panel for Ciri.
BUG=b:319025360
TEST=boot Ciri with IVO_T109NW41 panel, see firmware screen
BRANCH=None
Change-Id: I9dc2228d39bb8bb048d1f37727c96b0ad621e912
Signed-off-by: Ruihai Zhou <zhouruihai(a)huaqin.corp-partner.google.com>
---
M src/mainboard/google/geralt/Kconfig
M src/mainboard/google/geralt/panel_ciri.c
2 files changed, 11 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/45/79845/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/79845?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I9dc2228d39bb8bb048d1f37727c96b0ad621e912
Gerrit-Change-Number: 79845
Gerrit-PatchSet: 2
Gerrit-Owner: Ruihai Zhou <zhouruihai(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Reviewer: cong yang <yangcong5(a)huaqin.corp-partner.google.com>
Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Attention: Ruihai Zhou <zhouruihai(a)huaqin.corp-partner.google.com>
Gerrit-Attention: cong yang <yangcong5(a)huaqin.corp-partner.google.com>
Gerrit-Attention: Yidi Lin <yidilin(a)google.com>
Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Hung-Te Lin, Ruihai Zhou, Yu-Ping Wu, cong yang.
Hello Hung-Te Lin, Yidi Lin, Yu-Ping Wu, build bot (Jenkins), cong yang,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/78957?usp=email
to look at the new patch set (#10).
The following approvals got outdated and were removed:
Code-Review+1 by Yu-Ping Wu, Code-Review+1 by cong yang, Verified+1 by build bot (Jenkins)
Change subject: mb/google/geralt: Enable BOE_NV110WUM_L60 panel for Ciri
......................................................................
mb/google/geralt: Enable BOE_NV110WUM_L60 panel for Ciri
The MIPI panel BOE_NV110WUM_L60 will be used for Ciri, enable it.
BUG=b:308968270
TEST=Boot to firmware screen
BRANCH=None
Change-Id: I0a04f062f81c543d38716d7ff185b5633c1aa3a9
Signed-off-by: Ruihai Zhou <zhouruihai(a)huaqin.corp-partner.google.com>
---
M src/mainboard/google/geralt/Kconfig
M src/mainboard/google/geralt/Makefile.inc
M src/mainboard/google/geralt/panel.c
M src/mainboard/google/geralt/panel.h
A src/mainboard/google/geralt/panel_ciri.c
M src/mainboard/google/geralt/panel_geralt.c
6 files changed, 78 insertions(+), 18 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/57/78957/10
--
To view, visit https://review.coreboot.org/c/coreboot/+/78957?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I0a04f062f81c543d38716d7ff185b5633c1aa3a9
Gerrit-Change-Number: 78957
Gerrit-PatchSet: 10
Gerrit-Owner: Ruihai Zhou <zhouruihai(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Reviewer: cong yang <yangcong5(a)huaqin.corp-partner.google.com>
Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Attention: Ruihai Zhou <zhouruihai(a)huaqin.corp-partner.google.com>
Gerrit-Attention: cong yang <yangcong5(a)huaqin.corp-partner.google.com>
Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Annie Chen, Arthur Heymans, Chen, Gang C, Christian Walter, David Hendricks, Felix Held, Jincheng Li, Lean Sheng Tan, Nico Huber, Nill Ge, Patrick Rudolph, Paul Menzel, TangYiwei, Tim Chu.
Shuo Liu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78327?usp=email )
Change subject: soc/intel/xeon_sp: Redesign resource allocation
......................................................................
Patch Set 19: Code-Review+1
(1 comment)
Patchset:
PS19:
retested and OK :)
TEST=intel/archercity CRB
--
To view, visit https://review.coreboot.org/c/coreboot/+/78327?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Idb29c24b71a18e2e092f9d4953d106e6ca0a5fe1
Gerrit-Change-Number: 78327
Gerrit-PatchSet: 19
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Annie Chen <chen.annieet(a)inventec.com>
Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com>
Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Nill Ge <geshijian(a)bytedance.com>
Gerrit-Reviewer: Shuo Liu <shuo.liu(a)intel.com>
Gerrit-Reviewer: TangYiwei
Gerrit-Reviewer: Tim Chu <Tim.Chu(a)quantatw.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Chen, Gang C <gang.c.chen(a)intel.com>
Gerrit-CC: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-CC: Jincheng Li <jincheng.li(a)intel.com>
Gerrit-CC: Lean Sheng Tan <sheng.tan(a)9elements.com>
Gerrit-CC: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Attention: Annie Chen <chen.annieet(a)inventec.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Attention: Nill Ge <geshijian(a)bytedance.com>
Gerrit-Attention: TangYiwei
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Chen, Gang C <gang.c.chen(a)intel.com>
Gerrit-Attention: David Hendricks <david.hendricks(a)gmail.com>
Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Attention: Jincheng Li <jincheng.li(a)intel.com>
Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Attention: Tim Chu <Tim.Chu(a)quantatw.com>
Gerrit-Comment-Date: Thu, 11 Jan 2024 05:24:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Arthur Heymans, Chen, Gang C, Christian Walter, Jincheng Li, Johnny Lin, Nico Huber, Paul Menzel, Tim Chu.
Shuo Liu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79058?usp=email )
Change subject: soc/intel/xeon_sp: Allocate resources above 4G
......................................................................
Patch Set 12: Code-Review+1
(1 comment)
Patchset:
PS12:
retested and OK :)
TEST=intel/archercity CRB
--
To view, visit https://review.coreboot.org/c/coreboot/+/79058?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I27d4f9ce91c12ed4ab3b2f18f2a92b742115d275
Gerrit-Change-Number: 79058
Gerrit-PatchSet: 12
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Chen, Gang C <gang.c.chen(a)intel.com>
Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Reviewer: Jincheng Li <jincheng.li(a)intel.com>
Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Shuo Liu <shuo.liu(a)intel.com>
Gerrit-Reviewer: Tim Chu <Tim.Chu(a)quantatw.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Chen, Gang C <gang.c.chen(a)intel.com>
Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Attention: Jincheng Li <jincheng.li(a)intel.com>
Gerrit-Attention: Tim Chu <Tim.Chu(a)quantatw.com>
Gerrit-Comment-Date: Thu, 11 Jan 2024 05:23:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Arthur Heymans, Chen, Gang C, Jincheng Li, Nico Huber, Paul Menzel.
Shuo Liu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78331?usp=email )
Change subject: device/Kconfig: Add an option to allocate above 4G by default
......................................................................
Patch Set 18: Code-Review+1
(1 comment)
Patchset:
PS18:
retested and OK :)
TEST=intel/archercity CRB
--
To view, visit https://review.coreboot.org/c/coreboot/+/78331?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I01218a8a3efc4a5f8ba344808949ca6b8898525f
Gerrit-Change-Number: 78331
Gerrit-PatchSet: 18
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Chen, Gang C <gang.c.chen(a)intel.com>
Gerrit-Reviewer: Jincheng Li <jincheng.li(a)intel.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: Shuo Liu <shuo.liu(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Chen, Gang C <gang.c.chen(a)intel.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Attention: Jincheng Li <jincheng.li(a)intel.com>
Gerrit-Comment-Date: Thu, 11 Jan 2024 05:23:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment