coreboot-gerrit January 2024

coreboot-gerrit@coreboot.org

1 participants
3043 discussions

[M] Change in coreboot[main]: mb/google/geralt: Enable BOE_NV110WUM_L60 panel for Ciri
by Yidi Lin (Code Review) 11 Jan '24

11 Jan '24

Attention is currently required from: Hung-Te Lin, Ruihai Zhou, Yu-Ping Wu, cong yang. Yidi Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78957?usp=email ) Change subject: mb/google/geralt: Enable BOE_NV110WUM_L60 panel for Ciri ...................................................................... Patch Set 10: (1 comment) File src/mainboard/google/geralt/panel_geralt.c: https://review.coreboot.org/c/coreboot/+/78957/comment/160cc568_3990072a : PS10, Line 3: #include <boardid.h> : #include <console/console.h> : #include <delay.h> : #include <gpio.h> : #include <soc/gpio_common.h> > Build failed if remove <console/console.h> […] Acknowledged -- To view, visit https://review.coreboot.org/c/coreboot/+/78957?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I0a04f062f81c543d38716d7ff185b5633c1aa3a9 Gerrit-Change-Number: 78957 Gerrit-PatchSet: 10 Gerrit-Owner: Ruihai Zhou <zhouruihai(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: cong yang <yangcong5(a)huaqin.corp-partner.google.com> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Ruihai Zhou <zhouruihai(a)huaqin.corp-partner.google.com> Gerrit-Attention: cong yang <yangcong5(a)huaqin.corp-partner.google.com> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Comment-Date: Thu, 11 Jan 2024 08:50:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Ruihai Zhou <zhouruihai(a)huaqin.corp-partner.google.com> Comment-In-Reply-To: Yidi Lin <yidilin(a)google.com> Gerrit-MessageType: comment

1 0

[M] Change in coreboot[main]: mb/google/geralt: Enable BOE_NV110WUM_L60 panel for Ciri
by Ruihai Zhou (Code Review) 11 Jan '24

11 Jan '24

Attention is currently required from: Hung-Te Lin, Yidi Lin, Yu-Ping Wu, cong yang. Ruihai Zhou has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78957?usp=email ) Change subject: mb/google/geralt: Enable BOE_NV110WUM_L60 panel for Ciri ...................................................................... Patch Set 10: (1 comment) File src/mainboard/google/geralt/panel_geralt.c: https://review.coreboot.org/c/coreboot/+/78957/comment/9aba014d_61a790cd : PS10, Line 3: #include <boardid.h> : #include <console/console.h> : #include <delay.h> : #include <gpio.h> : #include <soc/gpio_common.h> > no longer needed ? Build failed if remove <console/console.h> ``` In file included from src/soc/mediatek/mt8188/include/soc/i2c.h:11, from src/mainboard/google/geralt/panel_ciri.c:3: src/soc/mediatek/common/include/soc/i2c_common.h:23:42: error: expected ')' before numeric constant 23 | check_member(mt_i2c_dma_regs, dma_tx_len, 0x24); | ^~~~~ | ) CC ramstage/lib/boot_device.o CC ramstage/lib/bootmem.o cc1: note: unrecognized command-line option '-Wno-array-compare' may have been intended to silence earlier diagnostics ``` -- To view, visit https://review.coreboot.org/c/coreboot/+/78957?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I0a04f062f81c543d38716d7ff185b5633c1aa3a9 Gerrit-Change-Number: 78957 Gerrit-PatchSet: 10 Gerrit-Owner: Ruihai Zhou <zhouruihai(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: cong yang <yangcong5(a)huaqin.corp-partner.google.com> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Yidi Lin <yidilin(a)google.com> Gerrit-Attention: cong yang <yangcong5(a)huaqin.corp-partner.google.com> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Comment-Date: Thu, 11 Jan 2024 08:44:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Yidi Lin <yidilin(a)google.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: soc/intel/common/tcss: Guard disabling MUX with TCSS_HAS_USBC_OPS
by Sean Rhodes (Code Review) 11 Jan '24

11 Jan '24

Attention is currently required from: Kapil Porwal, Matt DeVillier, Subrata Banik. Sean Rhodes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79882?usp=email ) Change subject: soc/intel/common/tcss: Guard disabling MUX with TCSS_HAS_USBC_OPS ...................................................................... Patch Set 5: (1 comment) File src/soc/intel/common/block/tcss/Kconfig: https://review.coreboot.org/c/coreboot/+/79882/comment/4d21af78_04b3444c : PS3, Line 8: to set MUX to a disconnected state > I'd leave this for the help below, and just leave this as "Enable USB-C MUX operations via the EC" o […] Done -- To view, visit https://review.coreboot.org/c/coreboot/+/79882?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ia848668ae9af4637fc7cffec9eb694f29d7deba9 Gerrit-Change-Number: 79882 Gerrit-PatchSet: 5 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Comment-Date: Thu, 11 Jan 2024 08:35:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-MessageType: comment

1 0

[M] Change in coreboot[main]: mb/hp/(elitebook_820_g2|folio_9480m): Add HP Sure Start workaround
by Arthur Heymans (Code Review) 11 Jan '24

11 Jan '24

Attention is currently required from: Iru Cai, Iru Cai. Hello Iru Cai, Iru Cai, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/79881?usp=email to look at the new patch set (#8). The following approvals got outdated and were removed: Verified+1 by build bot (Jenkins) Change subject: mb/hp/(elitebook_820_g2|folio_9480m): Add HP Sure Start workaround ...................................................................... mb/hp/(elitebook_820_g2|folio_9480m): Add HP Sure Start workaround To work around HP Sure Start the top of flash needs to contain a vendor provided image that the EC verifies before releasing the X86 from reset. Instead of using the wrong flash size and padding the image with dd, add an fmap layout and use cbfstool memory map arguments to achieve the same. UNTESTED. Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> Change-Id: I0e59d035ce9281062272aeef92f50f2bbf3a9c5f --- M Documentation/mainboard/hp/elitebook_820_g2.md M Documentation/mainboard/hp/folio_9480m.md M src/mainboard/hp/elitebook_820_g2/Kconfig M src/mainboard/hp/elitebook_820_g2/Makefile.inc A src/mainboard/hp/elitebook_820_g2/board.fmd M src/mainboard/hp/folio_9480m/Kconfig M src/mainboard/hp/folio_9480m/Makefile.inc A src/mainboard/hp/folio_9480m/board.fmd 8 files changed, 81 insertions(+), 11 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/81/79881/8 -- To view, visit https://review.coreboot.org/c/coreboot/+/79881?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I0e59d035ce9281062272aeef92f50f2bbf3a9c5f Gerrit-Change-Number: 79881 Gerrit-PatchSet: 8 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Iru Cai <mytbk920423(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Iru Cai <mytbk920423(a)gmail.com> Gerrit-Attention: Iru Cai <mytbk920423(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[main]: soc/intel/common/tcss: Guard disabling MUX with TCSS_HAS_USBC_OPS
by Sean Rhodes (Code Review) 11 Jan '24

11 Jan '24

Attention is currently required from: Kapil Porwal, Matt DeVillier, Subrata Banik. Sean Rhodes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79882?usp=email ) Change subject: soc/intel/common/tcss: Guard disabling MUX with TCSS_HAS_USBC_OPS ...................................................................... Patch Set 5: (1 comment) File src/soc/intel/common/block/tcss/Kconfig: https://review.coreboot.org/c/coreboot/+/79882/comment/b1b7a84c_524c0d4f : PS5, Line 8: Enable USB-C MUX operations via the EC > this sounds like EC is driving the USB-C mode entry. […] Right - that's what ours do. Is it right to have default y for the Google devices though? -- To view, visit https://review.coreboot.org/c/coreboot/+/79882?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ia848668ae9af4637fc7cffec9eb694f29d7deba9 Gerrit-Change-Number: 79882 Gerrit-PatchSet: 5 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Comment-Date: Thu, 11 Jan 2024 08:32:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com> Gerrit-MessageType: comment

1 0

[M] Change in coreboot[main]: device: Add support for multiple PCI segments
by Patrick Rudolph (Code Review) 11 Jan '24

11 Jan '24

Attention is currently required from: Cliff Huang, Felix Held, Fred Reitberger, Jason Glenesk, Lance Zhao, Matt DeVillier, Nico Huber, Tim Wawrzynczak. Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79877?usp=email ) Change subject: device: Add support for multiple PCI segments ...................................................................... Patch Set 1: (2 comments) File src/device/Kconfig: https://review.coreboot.org/c/coreboot/+/79877/comment/8046d6a4_46124f15 : PS1, Line 559: config ECAM_SEGMENT_COUNT > i first also added a kconfig option for this, but ended up removing it again, since just using 512 o […] My impression was that ECAM_MMCONF_BUS_NUMBER == 256 would be the better choice for the subordinate and max_subordinate handling. File src/include/device/device.h: https://review.coreboot.org/c/coreboot/+/79877/comment/863e1fd5_6a6d3190 : PS1, Line 89: uint8_t segment; /* PCI segment */ > Nico and i discussed this topic on irc some weeks ago and we ended up with the conclusion that using […] I'd be happy to test those to not have duplicate effort. My first try was to use the upper 8 bit of `secondary`, but this was discarded in order to reuse existing code in src/device/pci_device.c. The code really doesn't care about the segment group as long as the pci_*_config functions access the right segment. -- To view, visit https://review.coreboot.org/c/coreboot/+/79877?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Iab2c97a71a650e1ceadce4f985147ce05d4e8c86 Gerrit-Change-Number: 79877 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Thu, 11 Jan 2024 07:32:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Comment-In-Reply-To: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: drivers/mipi: Update init code for BOE_NV110WUM_L60
by Yidi Lin (Code Review) 11 Jan '24

11 Jan '24

Attention is currently required from: Ruihai Zhou, Yu-Ping Wu. Yidi Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79897?usp=email ) Change subject: drivers/mipi: Update init code for BOE_NV110WUM_L60 ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/79897?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I2f068ba0ec9dede3e3361b55c38a8eca8793905a Gerrit-Change-Number: 79897 Gerrit-PatchSet: 3 Gerrit-Owner: Ruihai Zhou <zhouruihai(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: cong yang <yangcong5(a)huaqin.corp-partner.google.com> Gerrit-Attention: Ruihai Zhou <zhouruihai(a)huaqin.corp-partner.google.com> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Comment-Date: Thu, 11 Jan 2024 06:58:17 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: mb/google/geralt: Enable IVO_T109NW41 MIPI panel for Ciri
by Yidi Lin (Code Review) 11 Jan '24

11 Jan '24

Attention is currently required from: Hung-Te Lin, Ruihai Zhou, Yu-Ping Wu, cong yang. Yidi Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79845?usp=email ) Change subject: mb/google/geralt: Enable IVO_T109NW41 MIPI panel for Ciri ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/79845?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I9dc2228d39bb8bb048d1f37727c96b0ad621e912 Gerrit-Change-Number: 79845 Gerrit-PatchSet: 3 Gerrit-Owner: Ruihai Zhou <zhouruihai(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: cong yang <yangcong5(a)huaqin.corp-partner.google.com> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Ruihai Zhou <zhouruihai(a)huaqin.corp-partner.google.com> Gerrit-Attention: cong yang <yangcong5(a)huaqin.corp-partner.google.com> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Comment-Date: Thu, 11 Jan 2024 06:57:29 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in coreboot[main]: mb/google/geralt: Enable BOE_NV110WUM_L60 panel for Ciri
by Yidi Lin (Code Review) 11 Jan '24

11 Jan '24

Attention is currently required from: Hung-Te Lin, Ruihai Zhou, Yu-Ping Wu, cong yang. Yidi Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78957?usp=email ) Change subject: mb/google/geralt: Enable BOE_NV110WUM_L60 panel for Ciri ...................................................................... Patch Set 10: (1 comment) File src/mainboard/google/geralt/panel_geralt.c: https://review.coreboot.org/c/coreboot/+/78957/comment/497d3e5e_39b37819 : PS10, Line 3: #include <boardid.h> : #include <console/console.h> : #include <delay.h> : #include <gpio.h> : #include <soc/gpio_common.h> no longer needed ? -- To view, visit https://review.coreboot.org/c/coreboot/+/78957?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I0a04f062f81c543d38716d7ff185b5633c1aa3a9 Gerrit-Change-Number: 78957 Gerrit-PatchSet: 10 Gerrit-Owner: Ruihai Zhou <zhouruihai(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: cong yang <yangcong5(a)huaqin.corp-partner.google.com> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Ruihai Zhou <zhouruihai(a)huaqin.corp-partner.google.com> Gerrit-Attention: cong yang <yangcong5(a)huaqin.corp-partner.google.com> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Comment-Date: Thu, 11 Jan 2024 06:57:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: WIP: mb/google/brox: fix cnvi
by Shelley Chen (Code Review) 11 Jan '24

11 Jan '24

Shelley Chen has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/79898?usp=email ) Change subject: WIP: mb/google/brox: fix cnvi ...................................................................... WIP: mb/google/brox: fix cnvi Change-Id: If9e861db37e321fd69c09f9b4aafa2e212f92caa Signed-off-by: Shelley Chen <shchen(a)google.com> --- M src/mainboard/google/brox/variants/baseboard/brox/devicetree.cb 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/98/79898/1 diff --git a/src/mainboard/google/brox/variants/baseboard/brox/devicetree.cb b/src/mainboard/google/brox/variants/baseboard/brox/devicetree.cb index c0cfb22..311f60f 100644 --- a/src/mainboard/google/brox/variants/baseboard/brox/devicetree.cb +++ b/src/mainboard/google/brox/variants/baseboard/brox/devicetree.cb @@ -165,6 +165,7 @@ chip drivers/wifi/generic register "wake" = "GPE0_PME_B0" register "add_acpi_dma_property" = "true" + register "enable_cnvi_ddr_rfim" = "true" device generic 0 on end end end -- To view, visit https://review.coreboot.org/c/coreboot/+/79898?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: If9e861db37e321fd69c09f9b4aafa2e212f92caa Gerrit-Change-Number: 79898 Gerrit-PatchSet: 1 Gerrit-Owner: Shelley Chen <shchen(a)google.com> Gerrit-MessageType: newchange

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit January 2024