coreboot-gerrit January 2024

coreboot-gerrit@coreboot.org

1 participants
3043 discussions

[M] Change in coreboot[main]: mb/lenovo/t530: Remove superfluous comments related to PCI devices
by Felix Singer (Code Review) 13 Jan '24

13 Jan '24

Attention is currently required from: Alexander Couzens. Hello Alexander Couzens, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/79938?usp=email to look at the new patch set (#3). Change subject: mb/lenovo/t530: Remove superfluous comments related to PCI devices ...................................................................... mb/lenovo/t530: Remove superfluous comments related to PCI devices Since all devicetrees from lenovo/t530 are using the reference names for PCI devices now, remove the equivalent comments documenting their function. Change-Id: I5ba08843506bc22136aea42ac37936a4f5cad5ce Signed-off-by: Felix Singer <felixsinger(a)posteo.net> --- M src/mainboard/lenovo/t530/devicetree.cb M src/mainboard/lenovo/t530/variants/t530/overridetree.cb M src/mainboard/lenovo/t530/variants/w530/overridetree.cb 3 files changed, 32 insertions(+), 32 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/38/79938/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/79938?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I5ba08843506bc22136aea42ac37936a4f5cad5ce Gerrit-Change-Number: 79938 Gerrit-PatchSet: 3 Gerrit-Owner: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-MessageType: newpatchset

1 0

[M] Change in coreboot[main]: mb/lenovo/t530: Remove superfluous comments related to PCI devices
by Felix Singer (Code Review) 13 Jan '24

13 Jan '24

Attention is currently required from: Alexander Couzens. Hello Alexander Couzens, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/79938?usp=email to look at the new patch set (#2). Change subject: mb/lenovo/t530: Remove superfluous comments related to PCI devices ...................................................................... mb/lenovo/t530: Remove superfluous comments related to PCI devices Since all devicetrees from lenovo/t530 are using the reference names for PCI devices now, remove the equivalent comments documenting their function. Change-Id: I5ba08843506bc22136aea42ac37936a4f5cad5ce Signed-off-by: Felix Singer <felixsinger(a)posteo.net> --- M src/mainboard/lenovo/t530/devicetree.cb M src/mainboard/lenovo/t530/variants/t530/overridetree.cb M src/mainboard/lenovo/t530/variants/w530/overridetree.cb 3 files changed, 32 insertions(+), 32 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/38/79938/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/79938?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I5ba08843506bc22136aea42ac37936a4f5cad5ce Gerrit-Change-Number: 79938 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[main]: mb/lenovo/t530: Convert remaining PCI numbers into reference names
by Felix Singer (Code Review) 13 Jan '24

13 Jan '24

Attention is currently required from: Alexander Couzens. Hello Alexander Couzens, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/79937?usp=email to look at the new patch set (#2). Change subject: mb/lenovo/t530: Convert remaining PCI numbers into reference names ...................................................................... mb/lenovo/t530: Convert remaining PCI numbers into reference names Change-Id: Ied9f37355432d58f83cb8453111a261c4eddc14a Signed-off-by: Felix Singer <felixsinger(a)posteo.net> --- M src/mainboard/lenovo/t530/variants/t530/overridetree.cb M src/mainboard/lenovo/t530/variants/w530/overridetree.cb 2 files changed, 6 insertions(+), 6 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/37/79937/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/79937?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ied9f37355432d58f83cb8453111a261c4eddc14a Gerrit-Change-Number: 79937 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Attention: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-MessageType: newpatchset

1 0

[M] Change in coreboot[main]: mb/lenovo/t530: Remove superfluous comments related to PCI devices
by Felix Singer (Code Review) 13 Jan '24

13 Jan '24

Attention is currently required from: Alexander Couzens. Felix Singer has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/79938?usp=email ) Change subject: mb/lenovo/t530: Remove superfluous comments related to PCI devices ...................................................................... mb/lenovo/t530: Remove superfluous comments related to PCI devices Since all devicetrees from lenovo/t530 are using the reference names for PCI devices now, remove the equivalent comments documenting their function. Change-Id: I5ba08843506bc22136aea42ac37936a4f5cad5ce Signed-off-by: Felix Singer <felixsinger(a)posteo.net> --- M src/mainboard/lenovo/t530/devicetree.cb M src/mainboard/lenovo/t530/variants/t530/overridetree.cb M src/mainboard/lenovo/t530/variants/w530/overridetree.cb 3 files changed, 32 insertions(+), 32 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/38/79938/1 diff --git a/src/mainboard/lenovo/t530/devicetree.cb b/src/mainboard/lenovo/t530/devicetree.cb index becc357..97051a1 100644 --- a/src/mainboard/lenovo/t530/devicetree.cb +++ b/src/mainboard/lenovo/t530/devicetree.cb @@ -18,9 +18,9 @@ device domain 0 on subsystemid 0x17aa 0x21f6 inherit - device ref host_bridge on end # Host bridge - device ref peg10 on end # PCIe bridge for discrete graphics - device ref igd on end # Internal graphics VGA controller + device ref host_bridge on end + device ref peg10 on end + device ref igd on end chip southbridge/intel/bd82x6x # Intel Series 7 Panther Point PCH # GPI routing @@ -53,29 +53,29 @@ register "spi_uvscc" = "0x2005" register "spi_lvscc" = "0x2005" - device ref xhci on end # USB 3.0 Controller - device ref mei1 on end # Management Engine Interface 1 - device ref mei2 off end # Management Engine Interface 2 - device ref me_ide_r off end # Management Engine IDE-R - device ref me_kt off end # Management Engine KT - device ref gbe on # Intel Gigabit Ethernet + device ref xhci on end + device ref mei1 on end + device ref mei2 off end + device ref me_ide_r off end + device ref me_kt off end + device ref gbe on subsystemid 0x17aa 0x21f3 end - device ref ehci2 on end # USB2 EHCI #2 - device ref hda on end # High Definition Audio - device ref pcie_rp1 on end # PCIe Port #1 - device ref pcie_rp2 on end # PCIe Port #2 - device ref pcie_rp3 on # PCIe Port #3 + device ref ehci2 on end + device ref hda on end + device ref pcie_rp1 on end + device ref pcie_rp2 on end + device ref pcie_rp3 on smbios_slot_desc "7" "3" "ExpressCard Slot" "8" end - device ref pcie_rp4 off end # PCIe Port #4 - device ref pcie_rp5 off end # PCIe Port #5 - device ref pcie_rp6 off end # PCIe Port #6 - device ref pcie_rp7 off end # PCIe Port #7 - device ref pcie_rp8 off end # PCIe Port #8 - device ref ehci1 on end # USB2 EHCI #1 - device ref pci_bridge off end # PCI bridge - device ref lpc on # PCI-LPC bridge + device ref pcie_rp4 off end + device ref pcie_rp5 off end + device ref pcie_rp6 off end + device ref pcie_rp7 off end + device ref pcie_rp8 off end + device ref ehci1 on end + device ref pci_bridge off end + device ref lpc on chip ec/lenovo/pmh7 device pnp ff.1 on end # dummy register "backlight_enable" = "true" @@ -137,8 +137,8 @@ register "has_thinker1" = "1" end end - device ref sata1 on end # SATA Controller 1 - device ref smbus on # SMBus + device ref sata1 on end + device ref smbus on # eeprom, 8 virtual devices, same chip chip drivers/i2c/at24rf08c device i2c 54 on end @@ -151,8 +151,8 @@ device i2c 5f on end end end - device ref sata2 off end # SATA Controller 2 - device ref thermal on end # Thermal + device ref sata2 off end + device ref thermal on end end end end diff --git a/src/mainboard/lenovo/t530/variants/t530/overridetree.cb b/src/mainboard/lenovo/t530/variants/t530/overridetree.cb index e7460a1..4da7219 100644 --- a/src/mainboard/lenovo/t530/variants/t530/overridetree.cb +++ b/src/mainboard/lenovo/t530/variants/t530/overridetree.cb @@ -2,7 +2,7 @@ register "spd_addresses" = "{0x50, 0, 0x51, 0}" device domain 0 on chip southbridge/intel/bd82x6x # Intel Series 7 Panther Point PCH - device ref lpc on # PCI-LPC bridge + device ref lpc on chip ec/lenovo/h8 device pnp ff.2 on end # dummy register "has_wwan_detection" = "1" diff --git a/src/mainboard/lenovo/t530/variants/w530/overridetree.cb b/src/mainboard/lenovo/t530/variants/w530/overridetree.cb index c38bf45..0045c5a 100644 --- a/src/mainboard/lenovo/t530/variants/w530/overridetree.cb +++ b/src/mainboard/lenovo/t530/variants/w530/overridetree.cb @@ -1,26 +1,26 @@ chip northbridge/intel/sandybridge register "spd_addresses" = "{0x50, 0x52, 0x51, 0x53}" device domain 0 on - device ref igd on # Internal graphics VGA controller + device ref igd on subsystemid 0x17aa 0x21f5 end chip southbridge/intel/bd82x6x # Intel Series 7 Panther Point PCH - device ref me_kt on end # Management Engine KT - device ref pcie_rp1 on # PCIe Port #1 + device ref me_kt on end + device ref pcie_rp1 on chip drivers/ricoh/rce822 # Ricoh cardreader register "disable_mask" = "0x83" register "sdwppol" = "1" device pci 00.0 on end # Ricoh SD card reader end end - device ref lpc on # PCI-LPC bridge + device ref lpc on chip ec/lenovo/h8 device pnp ff.2 on end # dummy register "config1" = "0x01" register "config3" = "0xe2" end end - device ref thermal off end # Thermal + device ref thermal off end end end end -- To view, visit https://review.coreboot.org/c/coreboot/+/79938?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I5ba08843506bc22136aea42ac37936a4f5cad5ce Gerrit-Change-Number: 79938 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Attention: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-MessageType: newchange

1 0

[S] Change in coreboot[main]: mb/lenovo/t530: Convert remaining PCI numbers into reference names
by Felix Singer (Code Review) 13 Jan '24

13 Jan '24

Felix Singer has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/79937?usp=email ) Change subject: mb/lenovo/t530: Convert remaining PCI numbers into reference names ...................................................................... mb/lenovo/t530: Convert remaining PCI numbers into reference names Change-Id: Ied9f37355432d58f83cb8453111a261c4eddc14a Signed-off-by: Felix Singer <felixsinger(a)posteo.net> --- M src/mainboard/lenovo/t530/variants/t530/overridetree.cb M src/mainboard/lenovo/t530/variants/w530/overridetree.cb 2 files changed, 6 insertions(+), 6 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/37/79937/1 diff --git a/src/mainboard/lenovo/t530/variants/t530/overridetree.cb b/src/mainboard/lenovo/t530/variants/t530/overridetree.cb index 98551ac..e7460a1 100644 --- a/src/mainboard/lenovo/t530/variants/t530/overridetree.cb +++ b/src/mainboard/lenovo/t530/variants/t530/overridetree.cb @@ -2,7 +2,7 @@ register "spd_addresses" = "{0x50, 0, 0x51, 0}" device domain 0 on chip southbridge/intel/bd82x6x # Intel Series 7 Panther Point PCH - device pci 1f.0 on # PCI-LPC bridge + device ref lpc on # PCI-LPC bridge chip ec/lenovo/h8 device pnp ff.2 on end # dummy register "has_wwan_detection" = "1" diff --git a/src/mainboard/lenovo/t530/variants/w530/overridetree.cb b/src/mainboard/lenovo/t530/variants/w530/overridetree.cb index 77b75fd..c38bf45 100644 --- a/src/mainboard/lenovo/t530/variants/w530/overridetree.cb +++ b/src/mainboard/lenovo/t530/variants/w530/overridetree.cb @@ -1,26 +1,26 @@ chip northbridge/intel/sandybridge register "spd_addresses" = "{0x50, 0x52, 0x51, 0x53}" device domain 0 on - device pci 02.0 on # Internal graphics VGA controller + device ref igd on # Internal graphics VGA controller subsystemid 0x17aa 0x21f5 end chip southbridge/intel/bd82x6x # Intel Series 7 Panther Point PCH - device pci 16.3 on end # Management Engine KT - device pci 1c.0 on # PCIe Port #1 + device ref me_kt on end # Management Engine KT + device ref pcie_rp1 on # PCIe Port #1 chip drivers/ricoh/rce822 # Ricoh cardreader register "disable_mask" = "0x83" register "sdwppol" = "1" device pci 00.0 on end # Ricoh SD card reader end end - device pci 1f.0 on # PCI-LPC bridge + device ref lpc on # PCI-LPC bridge chip ec/lenovo/h8 device pnp ff.2 on end # dummy register "config1" = "0x01" register "config3" = "0xe2" end end - device pci 1f.6 off end # Thermal + device ref thermal off end # Thermal end end end -- To view, visit https://review.coreboot.org/c/coreboot/+/79937?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ied9f37355432d58f83cb8453111a261c4eddc14a Gerrit-Change-Number: 79937 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-MessageType: newchange

1 0

[XS] Change in coreboot[main]: tree: Remove duplicated includes
by Felix Singer (Code Review) 13 Jan '24

13 Jan '24

Felix Singer has submitted this change. ( https://review.coreboot.org/c/coreboot/+/79912?usp=email ) Change subject: tree: Remove duplicated includes ...................................................................... tree: Remove duplicated includes Change-Id: I09dd5871cb366ef95410efc1ca6c4337f23b52fd Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> Reviewed-on: https://review.coreboot.org/c/coreboot/+/79912 Reviewed-by: Jonathon Hall <jonathon.hall(a)puri.sm> Reviewed-by: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Nico Huber <nico.h(a)gmx.de> --- M src/mainboard/google/dedede/variants/baseboard/ramstage.c M src/mainboard/purism/librem_l1um_v2/bootblock.c 2 files changed, 0 insertions(+), 2 deletions(-) Approvals: build bot (Jenkins): Verified Nico Huber: Looks good to me, but someone else must approve Jonathon Hall: Looks good to me, approved Felix Singer: Looks good to me, approved diff --git a/src/mainboard/google/dedede/variants/baseboard/ramstage.c b/src/mainboard/google/dedede/variants/baseboard/ramstage.c index d43d08f..e14e956 100644 --- a/src/mainboard/google/dedede/variants/baseboard/ramstage.c +++ b/src/mainboard/google/dedede/variants/baseboard/ramstage.c @@ -6,7 +6,6 @@ #include <drivers/usb/acpi/chip.h> #include <fw_config.h> #include <gpio.h> -#include <soc/pci_devs.h> #include <ec/google/chromeec/ec.h> #include <device/pci_ops.h> #include <intelblocks/power_limit.h> diff --git a/src/mainboard/purism/librem_l1um_v2/bootblock.c b/src/mainboard/purism/librem_l1um_v2/bootblock.c index d815669..58a22d2 100644 --- a/src/mainboard/purism/librem_l1um_v2/bootblock.c +++ b/src/mainboard/purism/librem_l1um_v2/bootblock.c @@ -12,7 +12,6 @@ #include "gpio.h" #include <gpio.h> #include <timer.h> -#include <delay.h> static int64_t bmc_ready_elapsed = 0; -- To view, visit https://review.coreboot.org/c/coreboot/+/79912?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I09dd5871cb366ef95410efc1ca6c4337f23b52fd Gerrit-Change-Number: 79912 Gerrit-PatchSet: 2 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Jonathon Hall <jonathon.hall(a)puri.sm> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[XS] Change in coreboot[main]: lib/fw_config: Remove redundant stdbool and stdint
by Felix Singer (Code Review) 13 Jan '24

13 Jan '24

Felix Singer has submitted this change. ( https://review.coreboot.org/c/coreboot/+/79911?usp=email ) Change subject: lib/fw_config: Remove redundant stdbool and stdint ...................................................................... lib/fw_config: Remove redundant stdbool and stdint <types.h> already includes <stdbool.h> and <stdint.h> Change-Id: Ie8676769127d21a3b4693ed947a7231b94e99241 Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> Reviewed-on: https://review.coreboot.org/c/coreboot/+/79911 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> --- M src/lib/fw_config.c 1 file changed, 0 insertions(+), 2 deletions(-) Approvals: Felix Singer: Looks good to me, approved build bot (Jenkins): Verified diff --git a/src/lib/fw_config.c b/src/lib/fw_config.c index 268be07..02e2a7d 100644 --- a/src/lib/fw_config.c +++ b/src/lib/fw_config.c @@ -9,8 +9,6 @@ #include <fw_config.h> #include <inttypes.h> #include <lib.h> -#include <stdbool.h> -#include <stdint.h> #include <drivers/vpd/vpd.h> uint64_t fw_config_get(void) -- To view, visit https://review.coreboot.org/c/coreboot/+/79911?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ie8676769127d21a3b4693ed947a7231b94e99241 Gerrit-Change-Number: 79911 Gerrit-PatchSet: 2 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[XS] Change in coreboot[main]: soc/intel/{adl, mtl}: Increase heap size (HEAP_SIZE) config
by Subrata Banik (Code Review) 13 Jan '24

13 Jan '24

Attention is currently required from: Dinesh Gehlot, Eran Mitrani, Eric Lai, Jakub Czapiga, Kapil Porwal, Nick Vaccaro, Shelley Chen, Tarun. Hello Dinesh Gehlot, Eran Mitrani, Eric Lai, Jakub Czapiga, Kapil Porwal, Nick Vaccaro, Shelley Chen, Tarun, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/79936?usp=email to look at the new patch set (#2). Change subject: soc/intel/{adl, mtl}: Increase heap size (HEAP_SIZE) config ...................................................................... soc/intel/{adl, mtl}: Increase heap size (HEAP_SIZE) config This patch applies larger value for HEAP_SIZE config for platform that supports BMP_LOGO. TEST=Able to render a colored OEM splash screen w/o any boot hang. Change-Id: If34b1ef497d38ba561221c584aab5399cfc5de82 Signed-off-by: Subrata Banik <subratabanik(a)google.com> --- M src/soc/intel/alderlake/Kconfig M src/soc/intel/meteorlake/Kconfig 2 files changed, 2 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/36/79936/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/79936?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: If34b1ef497d38ba561221c584aab5399cfc5de82 Gerrit-Change-Number: 79936 Gerrit-PatchSet: 2 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Jakub Czapiga <czapiga(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: Tarun <tstuli(a)gmail.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Shelley Chen <shchen(a)google.com> Gerrit-Attention: Eric Lai <ericllai(a)google.com> Gerrit-Attention: Eran Mitrani <mitrani(a)google.com> Gerrit-Attention: Jakub Czapiga <czapiga(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Attention: Tarun <tstuli(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

[L] Change in coreboot[main]: mainboard: Drop redundant PciRpEnable from devicetrees
by Felix Singer (Code Review) 13 Jan '24

13 Jan '24

Attention is currently required from: Angel Pons, Christian Walter, Erik van den Bogaert, Frans Hendriks, Jeremy Soller, Jonathon Hall, Michael Niewöhner, Michał Żygowski, Nicholas Sudsgaard, Nick Vaccaro, Nico Huber, Patrick Rudolph, Piotr Król, Sean Rhodes, Subrata Banik, Tim Crawford, Werner Zeh. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79935?usp=email ) Change subject: mainboard: Drop redundant PciRpEnable from devicetrees ...................................................................... Patch Set 4: (1 comment) Patchset: PS4: The patch still needs to be splitted up into the patches for each platform. Please provide a single command for each platform in order to make that reproducible. Could be done with find and sed. Also, I would like to make sure that the devicetree configuration matches the configuration of the options. The devicetree reference names should help with that, but the conversion is still WIP for Skylake and Cannonlake. -- To view, visit https://review.coreboot.org/c/coreboot/+/79935?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I9641a1ed241084f37089094b2392c29e2ac0fd95 Gerrit-Change-Number: 79935 Gerrit-PatchSet: 4 Gerrit-Owner: Nicholas Sudsgaard <devel+coreboot(a)nsudsgaard.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Erik van den Bogaert <ebogaert(a)eltan.com> Gerrit-Reviewer: Frans Hendriks <fhendriks(a)eltan.com> Gerrit-Reviewer: Jeremy Soller <jeremy(a)system76.com> Gerrit-Reviewer: Jonathon Hall <jonathon.hall(a)puri.sm> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Piotr Król <piotr.krol(a)3mdeb.com> Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tim Crawford <tcrawford(a)system76.com> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Frans Hendriks <fhendriks(a)eltan.com> Gerrit-Attention: Jeremy Soller <jeremy(a)system76.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Attention: Nicholas Sudsgaard <devel+coreboot(a)nsudsgaard.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Jonathon Hall <jonathon.hall(a)puri.sm> Gerrit-Attention: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Attention: Piotr Król <piotr.krol(a)3mdeb.com> Gerrit-Attention: Erik van den Bogaert <ebogaert(a)eltan.com> Gerrit-Attention: Tim Crawford <tcrawford(a)system76.com> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Comment-Date: Sat, 13 Jan 2024 18:00:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: soc/intel/{adl, mtl}: Increase heap size (HEAP_SIZE) config
by Subrata Banik (Code Review) 13 Jan '24

13 Jan '24

Subrata Banik has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/79936?usp=email ) Change subject: soc/intel/{adl, mtl}: Increase heap size (HEAP_SIZE) config ...................................................................... soc/intel/{adl, mtl}: Increase heap size (HEAP_SIZE) config This patch applies larger value for HEAP_SIZE config for platform that supports BMP_LOGO. TEST=Able to render a colored OEM splash screen w/o any boot hang. Change-Id: If34b1ef497d38ba561221c584aab5399cfc5de82 Signed-off-by: Subrata Banik <subratabanik(a)google.com> --- M src/soc/intel/alderlake/Kconfig M src/soc/intel/meteorlake/Kconfig 2 files changed, 2 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/36/79936/1 diff --git a/src/soc/intel/alderlake/Kconfig b/src/soc/intel/alderlake/Kconfig index fd95f9e..2beacb5 100644 --- a/src/soc/intel/alderlake/Kconfig +++ b/src/soc/intel/alderlake/Kconfig @@ -218,7 +218,7 @@ config HEAP_SIZE hex - default 0x80000 if BMP_LOGO + default 0x100000 if BMP_LOGO default 0x10000 config GFX_GMA_DEFAULT_MMIO diff --git a/src/soc/intel/meteorlake/Kconfig b/src/soc/intel/meteorlake/Kconfig index 6dd6273..77895fe 100644 --- a/src/soc/intel/meteorlake/Kconfig +++ b/src/soc/intel/meteorlake/Kconfig @@ -201,7 +201,7 @@ config HEAP_SIZE hex - default 0x80000 if BMP_LOGO + default 0x100000 if BMP_LOGO default 0x10000 # Intel recommends reserving the PCIe TBT root port resources as below: -- To view, visit https://review.coreboot.org/c/coreboot/+/79936?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: If34b1ef497d38ba561221c584aab5399cfc5de82 Gerrit-Change-Number: 79936 Gerrit-PatchSet: 1 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-MessageType: newchange

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit January 2024