coreboot-gerrit January 2024

coreboot-gerrit@coreboot.org

1 participants
3043 discussions

[XS] Change in coreboot[main]: mb/pcengines/apu2: don't enable IOMMU
by Felix Held (Code Review) 12 Jan '24

12 Jan '24

Attention is currently required from: Felix Held, Krystian Hebel, Michał Żygowski, Piotr Król. Hello Krystian Hebel, Michał Żygowski, Piotr Król, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/79896?usp=email to look at the new patch set (#2). Change subject: mb/pcengines/apu2: don't enable IOMMU ...................................................................... mb/pcengines/apu2: don't enable IOMMU Drop the enabling of the IOMMU device from all variant's devicetrees, since there's something broken with either the IVRS table or possibly the IOMMU itself. This fixes the issue of the Linux kernel stalling for about 20 seconds right after printing 'AMD-Vi: Virtual APIC enabled' and only getting unstuck when the periodic NMI results in a backtrace being printed. This was tested with Debian running kernel 5.10.0-27-amd64, but the same issue also showed up with newer kernels. The official APU2 images don't show this bug, but there the IVRS isn't generated by default. TEST=Disabling the IOMMU which results in no IVRS being generated fixes the bug. Signed-off-by: Felix Held <felix-coreboot(a)felixheld.de> Change-Id: If74a7c64f53903fec0c01a55e1b202e800f02986 --- M src/mainboard/pcengines/apu2/variants/apu2/devicetree.cb M src/mainboard/pcengines/apu2/variants/apu3/devicetree.cb M src/mainboard/pcengines/apu2/variants/apu4/devicetree.cb M src/mainboard/pcengines/apu2/variants/apu5/devicetree.cb 4 files changed, 0 insertions(+), 4 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/96/79896/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/79896?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: If74a7c64f53903fec0c01a55e1b202e800f02986 Gerrit-Change-Number: 79896 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Piotr Król <piotr.krol(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Mike Banon <mikebdp2(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Attention: Piotr Król <piotr.krol(a)3mdeb.com> Gerrit-MessageType: newpatchset

1 0

[XS] Change in coreboot[main]: Makefile.inc: Enable Wxor-used-as-pow command option
by Julius Werner (Code Review) 12 Jan '24

12 Jan '24

Attention is currently required from: Elyes Haouas, Martin L Roth, Nico Huber. Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79915?usp=email ) Change subject: Makefile.inc: Enable Wxor-used-as-pow command option ...................................................................... Patch Set 1: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/79915/comment/3e5b3081_63d5c674 : PS1, Line 10: meant exponentiation. https://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html says > Specifically, the warning occurs when the left-hand side is the decimal constant 2 or 10 and the right-hand side is also a decimal constant. Which seems useless enough in actual code that I wouldn't expect any false positives. However, it also says "This warning is enabled by default.", so do we actually need to add it to the Makefile explicitly? -- To view, visit https://review.coreboot.org/c/coreboot/+/79915?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I6ae83c676ab347510f5dfa7d34a7b04ee439e9b6 Gerrit-Change-Number: 79915 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Julius Werner <jwerner(a)chromium.org> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Comment-Date: Fri, 12 Jan 2024 23:58:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Gerrit-MessageType: comment

1 0

[M] Change in coreboot[main]: device: Add support for multiple PCI segment groups
by Felix Held (Code Review) 12 Jan '24

12 Jan '24

Attention is currently required from: Arthur Heymans, Christian Walter, Cliff Huang, Fred Reitberger, Jason Glenesk, Johnny Lin, Jérémy Compostella, Lance Zhao, Matt DeVillier, Nico Huber, Patrick Rudolph, Tim Chu, Tim Wawrzynczak. Hello Arthur Heymans, Christian Walter, Cliff Huang, Fred Reitberger, Jason Glenesk, Johnny Lin, Jérémy Compostella, Lance Zhao, Matt DeVillier, Nico Huber, Patrick Rudolph, Tim Chu, Tim Wawrzynczak, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/79927?usp=email to look at the new patch set (#9). Change subject: device: Add support for multiple PCI segment groups ...................................................................... device: Add support for multiple PCI segment groups Add initial support for multiple PCI segment groups. Instead of modifying secondary in the bus struct introduce a new variable and keep existing common code. Since all platforms currently only use 1 segment this is not a functional change. On platforms that support more than 1 segment the segment has to be set when creating the PCI domain. Signed-off-by: Patrick Rudolph <patrick.rudolph(a)9elements.com> Signed-off-by: Felix Held <felix-coreboot(a)felixheld.de> Change-Id: Ied3313c41896362dd989ee2ab1b1bcdced840aa8 --- M src/acpi/acpi.c M src/arch/x86/mpspec.c M src/device/Kconfig M src/device/device.c M src/device/device_const.c M src/device/device_util.c M src/device/pci_device.c M src/device/pci_rom.c M src/device/pcix_device.c M src/include/device/device.h M src/include/device/pci_def.h M src/include/device/pci_ops.h M src/lib/smbios.c M src/northbridge/amd/pi/00730F01/northbridge.c M src/soc/amd/common/block/acpi/ivrs.c M src/soc/amd/common/block/data_fabric/domain.c M src/soc/amd/genoa_poc/domain.c M src/soc/intel/xeon_sp/cpx/soc_acpi.c M src/soc/intel/xeon_sp/uncore.c 19 files changed, 101 insertions(+), 42 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/27/79927/9 -- To view, visit https://review.coreboot.org/c/coreboot/+/79927?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ied3313c41896362dd989ee2ab1b1bcdced840aa8 Gerrit-Change-Number: 79927 Gerrit-PatchSet: 9 Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Attention: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[main]: sb/intel/i82801{i,j}x/chip.h: Use boolean where appropriate
by Felix Singer (Code Review) 12 Jan '24

12 Jan '24

Attention is currently required from: Alexander Couzens, Elyes Haouas, Felix Held, Nicholas Chin, Stefan Ott. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/77738?usp=email ) Change subject: sb/intel/i82801{i,j}x/chip.h: Use boolean where appropriate ...................................................................... Patch Set 12: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/77738?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I867451ae3d6d37033c9e0e57a4d7fd4a06dedbef Gerrit-Change-Number: 77738 Gerrit-PatchSet: 12 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: Stefan Ott <coreboot(a)desire.ch> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Stefan Ott <coreboot(a)desire.ch> Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Attention: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Comment-Date: Fri, 12 Jan 2024 21:55:32 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in coreboot[main]: device: Add support for multiple PCI segment groups
by Felix Held (Code Review) 12 Jan '24

12 Jan '24

Attention is currently required from: Arthur Heymans, Christian Walter, Cliff Huang, Fred Reitberger, Jason Glenesk, Johnny Lin, Jérémy Compostella, Lance Zhao, Matt DeVillier, Nico Huber, Patrick Rudolph, Tim Chu, Tim Wawrzynczak. Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79927?usp=email ) Change subject: device: Add support for multiple PCI segment groups ...................................................................... Patch Set 8: (1 comment) Patchset: PS8: the last few things where i'm not 100% sure how to handle those are the yabel and realmode oprom execution support; otherwise this should be mostly complete -- To view, visit https://review.coreboot.org/c/coreboot/+/79927?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ied3313c41896362dd989ee2ab1b1bcdced840aa8 Gerrit-Change-Number: 79927 Gerrit-PatchSet: 8 Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Attention: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Comment-Date: Fri, 12 Jan 2024 21:10:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: include/device/pci_mmio_cfg: assert CONFIG_ECAM_MMCONF_BUS_NUMBER != 0
by Matt DeVillier (Code Review) 12 Jan '24

12 Jan '24

Attention is currently required from: Felix Held. Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79933?usp=email ) Change subject: include/device/pci_mmio_cfg: assert CONFIG_ECAM_MMCONF_BUS_NUMBER != 0 ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/79933?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ic102b7dca9ffebb2d384a068a1fb1f4b6fb6c5f8 Gerrit-Change-Number: 79933 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Fri, 12 Jan 2024 21:06:54 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in coreboot[main]: Documentation: Start administrator handbook
by Patrick Georgi (Code Review) 12 Jan '24

12 Jan '24

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/79901?usp=email ) Change subject: Documentation: Start administrator handbook ...................................................................... Documentation: Start administrator handbook Let's spread the work of maintaining various of our services, but to achieve that, we need to document what needs to be done. Change-Id: I87021ee62d18fa464f70351ea8bad732889d55f1 Signed-off-by: Patrick Georgi <patrick(a)coreboot.org> Reviewed-on: https://review.coreboot.org/c/coreboot/+/79901 Reviewed-by: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- A Documentation/infrastructure/admin.md M Documentation/infrastructure/index.md 2 files changed, 53 insertions(+), 1 deletion(-) Approvals: build bot (Jenkins): Verified Felix Singer: Looks good to me, approved diff --git a/Documentation/infrastructure/admin.md b/Documentation/infrastructure/admin.md new file mode 100644 index 0000000..cb75ad4 --- /dev/null +++ b/Documentation/infrastructure/admin.md @@ -0,0 +1,52 @@ +# Operating our services + +## Mailing list moderation + +Our [mailing lists] experience the same barrage of spam mails than any +other email address. We do have a spam filter in front of it, and +since the lists require registration, spam ends up in the moderation +queue. But not only spam ends up there, sometimes users send inquiries +without registering first. It's a custom of the project to let these +through, so that such emails can be discussed. This requires manual +intervention. + +This section describes the tasks related to mailing list management. + +### Registration + +To participate in mailing list moderation, you need to become a list +moderator or owner. This is up for the existing owners to handle and +if you want to contribute in that area, it might be best to bring it +up at the leadership meeting. + +After gaining leadership approval, list admins can add you to the +appropriate group in the [mailing list backend] by selecting the list, +then User / group-name, and add your email address there. + +### Regular tasks + +Most of our lists are auto-subscribing, so users can register +themselves and finish the process by responding to the double-opt-in +email. Some lists are manually managed though. The [mailing list +backend] shows the number of open subscription requests for these +lists on the mailing list's main page. + +It also provides a list of held messages, where they can be accepted, +rejected or dropped. Spam should be dropped, that's clear. Emails with +huge attachments (e.g. screenshots) should be rejected, which gives +you an opportunity to explain the reason (in case of large +attachments, something like "Please re-send without attachments, offer +the files through some other mechanism please: Our emails are +distributed to hundreds of readers, and sending the files to everybody +is inconsiderate of traffic and storage constraints.") + +Legit emails (often simple requests of the form "is this or that +supported") can be accepted, which means they'll be sent out. + +If you notice recurring spam sources (e.g. marketers) you can put them +on the [global ban list] to filter them out across all lists. It takes +entries in regular expression format. + +[mailing lists]: https://mail.coreboot.org/hyperkitty/ +[mailing list backend]: https://mail.coreboot.org/postorius/ +[global ban list]: https://mail.coreboot.org/postorius/bans/ diff --git a/Documentation/infrastructure/index.md b/Documentation/infrastructure/index.md index 744809f..6748637 100644 --- a/Documentation/infrastructure/index.md +++ b/Documentation/infrastructure/index.md @@ -5,7 +5,7 @@ ## Services * [Project services](services.md) - +* [Administrator's handbook](admin.md) ## Jenkins builders and builds * [Setting up Jenkins build machines](builders.md) -- To view, visit https://review.coreboot.org/c/coreboot/+/79901?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I87021ee62d18fa464f70351ea8bad732889d55f1 Gerrit-Change-Number: 79901 Gerrit-PatchSet: 3 Gerrit-Owner: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[M] Change in coreboot[main]: [RFC] util/showdevicetree: drop unmaintained tool
by Felix Held (Code Review) 12 Jan '24

12 Jan '24

Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79934?usp=email ) Change subject: [RFC] util/showdevicetree: drop unmaintained tool ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: might be worth fixing this one instead of dropping it, but would be good if someone who actually wants to use this would do the work -- To view, visit https://review.coreboot.org/c/coreboot/+/79934?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I8ca75db281a215bf3f194ab72a107f666dc0694e Gerrit-Change-Number: 79934 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Fri, 12 Jan 2024 21:03:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in coreboot[main]: [RFC] util/showdevicetree: drop unmaintained tool
by Felix Held (Code Review) 12 Jan '24

12 Jan '24

Felix Held has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/79934?usp=email ) Change subject: [RFC] util/showdevicetree: drop unmaintained tool ...................................................................... [RFC] util/showdevicetree: drop unmaintained tool This tool doesn't have a makefile, when trying to compile it manually with the given instructions it even fails to compile after fixing the paths in the given command, and it references the non-existing PCI_BUS_SEGN_BITS Kconfig symbol, so just drop this. Signed-off-by: Felix Held <felix-coreboot(a)felixheld.de> Change-Id: I8ca75db281a215bf3f194ab72a107f666dc0694e --- D util/showdevicetree/description.md D util/showdevicetree/showdt.c 2 files changed, 0 insertions(+), 157 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/34/79934/1 diff --git a/util/showdevicetree/description.md b/util/showdevicetree/description.md deleted file mode 100644 index 46b7ba8..0000000 --- a/util/showdevicetree/description.md +++ /dev/null @@ -1 +0,0 @@ -Compile and dump the device tree `C` diff --git a/util/showdevicetree/showdt.c b/util/showdevicetree/showdt.c deleted file mode 100644 index 961a69d..0000000 --- a/util/showdevicetree/showdt.c +++ /dev/null @@ -1,156 +0,0 @@ -/* Compile and dump the device tree */ -/* SPDX-License-Identifier: GPL-2.0-only */ -#include <stdio.h> -/* you can't include string.h due to conflicts with coreboot prototypes. */ -void *memcpy(void *m1, void *m2, size_t s); - -struct device_operations default_dev_ops_root = { - .read_resources = NULL, - .set_resources = NULL, - .enable_resources = NULL, - .init = NULL, - .scan_bus = NULL, - .reset_bus = NULL, -}; - -extern struct device dev_root; -struct device *all_devices = &dev_root; - -const char mainboard_name[] = "showdt"; - -/* - * Warning: This function uses a static buffer. Don't call it more than once - * from the same print statement! - */ -const char *dev_path(device_t dev) -{ - static char buffer[DEVICE_PATH_MAX]; - - buffer[0] = '\0'; - if (!dev) { - memcpy(buffer, "<null>", 7); - } else { - switch(dev->path.type) { - case DEVICE_PATH_ROOT: - memcpy(buffer, "Root Device", 12); - break; - case DEVICE_PATH_PCI: -#if CONFIG_PCI_BUS_SEGN_BITS - sprintf(buffer, "PCI: %04x:%02x:%02x.%01x", - dev->bus->secondary >> 8, - dev->bus->secondary & 0xff, - PCI_SLOT(dev->path.pci.devfn), - PCI_FUNC(dev->path.pci.devfn)); -#else - sprintf(buffer, "PCI: %02x:%02x.%01x", - dev->bus->secondary, - PCI_SLOT(dev->path.pci.devfn), - PCI_FUNC(dev->path.pci.devfn)); -#endif - break; - case DEVICE_PATH_PNP: - sprintf(buffer, "PNP: %04x.%01x", - dev->path.pnp.port, dev->path.pnp.device); - break; - case DEVICE_PATH_I2C: - sprintf(buffer, "I2C: %02x:%02x", - dev->bus->secondary, - dev->path.i2c.device); - break; - case DEVICE_PATH_APIC: - sprintf(buffer, "APIC: %02x", - dev->path.apic.apic_id); - break; - case DEVICE_PATH_IOAPIC: - sprintf(buffer, "IOAPIC: %02x", - dev->path.ioapic.ioapic_id); - break; - case DEVICE_PATH_DOMAIN: - sprintf(buffer, "DOMAIN: %04x", - dev->path.domain.domain); - break; - case DEVICE_PATH_CPU_CLUSTER: - sprintf(buffer, "CPU_CLUSTER: %01x", - dev->path.cpu_cluster.cluster); - break; - case DEVICE_PATH_CPU: - sprintf(buffer, "CPU: %02x", dev->path.cpu.id); - break; - case DEVICE_PATH_CPU_BUS: - sprintf(buffer, "CPU_BUS: %02x", dev->path.cpu_bus.id); - break; - case DEVICE_PATH_MMIO: - sprintf(buffer, "MMIO: %08x", dev->path.mmio.addr); - break; - default: - printf("Unknown device path type: %d\n", - dev->path.type); - break; - } - } - return buffer; -} - - -void show_devs_tree(struct device *dev, int debug_level, int depth, int linknum) -{ - char depth_str[20] = ""; - int i; - struct device *sibling; - struct bus *link; - - for (i = 0; i < depth; i++) - depth_str[i] = ' '; - depth_str[i] = '\0'; - - printf("%s%s: enabled %d%s\n", - depth_str, dev_path(dev), dev->enabled, - dev->chip_ops ? ":has a chip":""); - - for (link = dev->link_list; link; link = link->next) { - for (sibling = link->children; sibling; - sibling = sibling->sibling) - show_devs_tree(sibling, debug_level, depth + 1, i); - } -} - -void show_all_devs_tree(int debug_level, const char *msg) -{ - printf("Show all devs in tree form...%s\n", msg); - - show_devs_tree(all_devices, debug_level, 0, -1); -} - -void show_devs_subtree(struct device *root, int debug_level, const char *msg) -{ - printf("Show all devs in subtree %s...%s\n", - dev_path(root), msg); - - printf("%s\n", msg); - show_devs_tree(root, debug_level, 0, -1); -} - -void show_all_devs(int debug_level, const char *msg) -{ - struct device *dev; - - printf("Show all devs...%s\n", msg); - for (dev = all_devices; dev; dev = dev->next) { - printf("%s: enabled %d%s\n", - dev_path(dev), dev->enabled, - dev->chip_ops ? ":has a chip":""); - } -} - -main() -{ - show_all_devs(1, ""); - show_all_devs_tree(1, ""); -} - -/* - * Example: (yank this and paste into M-x compile in emacs) - * or tail -2 showdt.c | head -1 |sh - * or whatever. - cc -I ../src -I ../src/include -I ../src/arch/arm/include/ -include build/mainboard/google/snow/static.c showdt.c -*/ -- To view, visit https://review.coreboot.org/c/coreboot/+/79934?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I8ca75db281a215bf3f194ab72a107f666dc0694e Gerrit-Change-Number: 79934 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-MessageType: newchange

1 0

[XS] Change in coreboot[main]: include/device/pci_mmio_cfg: assert CONFIG_ECAM_MMCONF_BUS_NUMBER != 0
by Felix Held (Code Review) 12 Jan '24

12 Jan '24

Felix Held has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/79933?usp=email ) Change subject: include/device/pci_mmio_cfg: assert CONFIG_ECAM_MMCONF_BUS_NUMBER != 0 ...................................................................... include/device/pci_mmio_cfg: assert CONFIG_ECAM_MMCONF_BUS_NUMBER != 0 Make sure that CONFIG_ECAM_MMCONF_BUS_NUMBER is non-zero when the ECAM_MMCONF_SUPPORT Kconfig option is selected. Signed-off-by: Felix Held <felix-coreboot(a)felixheld.de> Change-Id: Ic102b7dca9ffebb2d384a068a1fb1f4b6fb6c5f8 --- M src/include/device/pci_mmio_cfg.h 1 file changed, 4 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/33/79933/1 diff --git a/src/include/device/pci_mmio_cfg.h b/src/include/device/pci_mmio_cfg.h index 89c9906..4164441 100644 --- a/src/include/device/pci_mmio_cfg.h +++ b/src/include/device/pci_mmio_cfg.h @@ -31,6 +31,10 @@ #error "CONFIG_ECAM_MMCONF_BASE_ADDRESS undefined!" #endif +#if CONFIG_ECAM_MMCONF_BUS_NUMBER == 0 +#error "CONFIG_ECAM_MMCONF_BUS_NUMBER is undefined!" +#endif + #if CONFIG_ECAM_MMCONF_BUS_NUMBER * MiB != CONFIG_ECAM_MMCONF_LENGTH #error "CONFIG_ECAM_MMCONF_LENGTH does not correspond with CONFIG_ECAM_MMCONF_BUS_NUMBER!" #endif -- To view, visit https://review.coreboot.org/c/coreboot/+/79933?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ic102b7dca9ffebb2d384a068a1fb1f4b6fb6c5f8 Gerrit-Change-Number: 79933 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-MessageType: newchange

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit January 2024