coreboot-gerrit January 2024

coreboot-gerrit@coreboot.org

1 participants
3044 discussions

[XS] Change in coreboot[main]: mb/lenovo/x230: Convert remaining PCI numbers into reference names
by Patrick Rudolph (Code Review) 14 Jan '24

14 Jan '24

Attention is currently required from: Alexander Couzens, Felix Singer. Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79963?usp=email ) Change subject: mb/lenovo/x230: Convert remaining PCI numbers into reference names ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/79963?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I38ef315dbdadb140e8e7163e755a078bc906e1b5 Gerrit-Change-Number: 79963 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Comment-Date: Sun, 14 Jan 2024 07:25:27 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in coreboot[main]: mb/lenovo/t430: Remove superfluous comments related to PCI devices
by Patrick Rudolph (Code Review) 14 Jan '24

14 Jan '24

Attention is currently required from: Alexander Couzens, Felix Singer. Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79942?usp=email ) Change subject: mb/lenovo/t430: Remove superfluous comments related to PCI devices ...................................................................... Patch Set 1: (1 comment) File src/mainboard/lenovo/t430s/devicetree.cb: https://review.coreboot.org/c/coreboot/+/79942/comment/aed1b7cd_afbeb401 : PS1, Line 72: device ref pcie_rp6 off end # Intel Gigabit Ethernet PHY (not PCIe) why has it such a comment? it's off? -- To view, visit https://review.coreboot.org/c/coreboot/+/79942?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I84f432e89c41a02115715f7f1b56123dd0d81171 Gerrit-Change-Number: 79942 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Comment-Date: Sun, 14 Jan 2024 07:25:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in coreboot[main]: mb/lenovo/t530: Remove superfluous comments related to PCI devices
by Patrick Rudolph (Code Review) 14 Jan '24

14 Jan '24

Attention is currently required from: Alexander Couzens, Arthur Heymans, Felix Singer. Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79938?usp=email ) Change subject: mb/lenovo/t530: Remove superfluous comments related to PCI devices ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/79938?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I5ba08843506bc22136aea42ac37936a4f5cad5ce Gerrit-Change-Number: 79938 Gerrit-PatchSet: 3 Gerrit-Owner: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Comment-Date: Sun, 14 Jan 2024 07:22:34 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: mb/lenovo/t430: Convert remaining PCI numbers into reference names
by Patrick Rudolph (Code Review) 14 Jan '24

14 Jan '24

Attention is currently required from: Alexander Couzens, Felix Singer. Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79941?usp=email ) Change subject: mb/lenovo/t430: Convert remaining PCI numbers into reference names ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/79941?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ib94dd2778cf89ae8b97b43031d729c728f59a29e Gerrit-Change-Number: 79941 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Comment-Date: Sun, 14 Jan 2024 07:22:28 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in coreboot[main]: mb/lenovo/x220: Remove superfluous comments related to PCI devices
by Patrick Rudolph (Code Review) 14 Jan '24

14 Jan '24

Attention is currently required from: Alexander Couzens, Felix Singer. Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79940?usp=email ) Change subject: mb/lenovo/x220: Remove superfluous comments related to PCI devices ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/79940?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ic8bff0516811371e1fbb72765c8d03812a689701 Gerrit-Change-Number: 79940 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Comment-Date: Sun, 14 Jan 2024 07:21:57 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: mb/lenovo/x220: Convert remaining PCI numbers into reference names
by Patrick Rudolph (Code Review) 14 Jan '24

14 Jan '24

Attention is currently required from: Alexander Couzens, Felix Singer. Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79939?usp=email ) Change subject: mb/lenovo/x220: Convert remaining PCI numbers into reference names ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/79939?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ife8f3bc8b7fd14bb9a0e8dd4bc3d33b44c8f794f Gerrit-Change-Number: 79939 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Comment-Date: Sun, 14 Jan 2024 07:20:59 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in coreboot[main]: mb/lenovo/t530: Remove superfluous comments related to PCI devices
by Patrick Rudolph (Code Review) 14 Jan '24

14 Jan '24

Attention is currently required from: Alexander Couzens, Arthur Heymans, Felix Singer. Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79938?usp=email ) Change subject: mb/lenovo/t530: Remove superfluous comments related to PCI devices ...................................................................... Patch Set 3: (1 comment) File src/mainboard/lenovo/t530/devicetree.cb: https://review.coreboot.org/c/coreboot/+/79938/comment/c20b686c_ed567841 : PS3, Line 22: device ref peg10 on end > Readd comment "discrete graphics" It should have the discrete graphics pci device listed here: device pci 00.0 on end -- To view, visit https://review.coreboot.org/c/coreboot/+/79938?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I5ba08843506bc22136aea42ac37936a4f5cad5ce Gerrit-Change-Number: 79938 Gerrit-PatchSet: 3 Gerrit-Owner: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Comment-Date: Sun, 14 Jan 2024 07:20:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: mb/lenovo/t530: Convert remaining PCI numbers into reference names
by Patrick Rudolph (Code Review) 14 Jan '24

14 Jan '24

Attention is currently required from: Alexander Couzens, Felix Held, Felix Singer. Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79937?usp=email ) Change subject: mb/lenovo/t530: Convert remaining PCI numbers into reference names ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/79937?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ied9f37355432d58f83cb8453111a261c4eddc14a Gerrit-Change-Number: 79937 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Sun, 14 Jan 2024 07:18:20 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: sb/intel/bd82x6x/early_usb: Print error for invalid USB setting
by Patrick Rudolph (Code Review) 14 Jan '24

14 Jan '24

Attention is currently required from: Angel Pons, Martin L Roth, Paul Menzel. Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78827?usp=email ) Change subject: sb/intel/bd82x6x/early_usb: Print error for invalid USB setting ...................................................................... Patch Set 10: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/78827/comment/4889f2e4_565e2c2b : PS8, Line 15: Tested: Lenovo X220 still boots. > So what needs to be done here to get this batch merged? Can this comment just be resolved? It could be tested on desktop boards where the introduced conditional evaluates to true. Since the change increases USB TX/RX gains on such boards the USB devices should work even better, not worse. However it might be difficult to test without an oscilloscope attached to create an eye-diagram, as those USB ports might always have been working "okayish". Marking as resolved to get this merged and let users test it on main. -- To view, visit https://review.coreboot.org/c/coreboot/+/78827?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: If76e9126b4aba8e16c1c91dece725aac12e1a7e9 Gerrit-Change-Number: 78827 Gerrit-PatchSet: 10 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-CC: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-CC: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Sun, 14 Jan 2024 07:16:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Martin L Roth <gaumless(a)gmail.com> Comment-In-Reply-To: Patrick Rudolph <patrick.rudolph(a)9elements.com> Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: sb/intel/bd82x6x/early_usb: Add USB TX/RX gains
by Patrick Rudolph (Code Review) 14 Jan '24

14 Jan '24

Attention is currently required from: Keith Hui, Paul Menzel. Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78829?usp=email ) Change subject: sb/intel/bd82x6x/early_usb: Add USB TX/RX gains ...................................................................... Patch Set 10: (1 comment) File src/southbridge/intel/bd82x6x/early_usb.c: https://review.coreboot.org/c/coreboot/+/78829/comment/f41d31a7_f17d873c : PS10, Line 41: portmap[i].current > It would be nice to have a more meaningful name with an enum to use in devicetree. […] Yes, that's planned as follow-up patch series. -- To view, visit https://review.coreboot.org/c/coreboot/+/78829?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I79d35ca16818daec03ee7f464349a4c8ee0f78e4 Gerrit-Change-Number: 78829 Gerrit-PatchSet: 10 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Keith Hui <buurin(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Keith Hui <buurin(a)gmail.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Sun, 14 Jan 2024 07:08:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit January 2024