coreboot-gerrit January 2024

coreboot-gerrit@coreboot.org

1 participants
3044 discussions

[XS] Change in coreboot[main]: mb/google/nissa/var/craaskov: Modify ELAN touchscreen enable delay fr...
by Felix Held (Code Review) 17 Jan '24

17 Jan '24

Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/79978?usp=email ) ( 3 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: mb/google/nissa/var/craaskov: Modify ELAN touchscreen enable delay from 1ms to 6ms ...................................................................... mb/google/nissa/var/craaskov: Modify ELAN touchscreen enable delay from 1ms to 6ms Modify touchscreen enable_delay to 6ms to meet with spec. eKTH3915N_Product Spec_V1.3_20221028_IPM.pdf BUG=b:318443640 TEST=emerge-nissa coreboot chromeos-bootimage Change-Id: Id57ab04e61d9e95c962f2c564d3a7e2e7ed6b992 Signed-off-by: Rex Chou <rex_chou(a)compal.corp-partner.google.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/79978 Reviewed-by: Eric Lai <ericllai(a)google.com> Reviewed-by: Subrata Banik <subratabanik(a)google.com> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Ian Feng <ian_feng(a)compal.corp-partner.google.com> --- M src/mainboard/google/brya/variants/craaskov/overridetree.cb 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Ian Feng: Looks good to me, approved Subrata Banik: Looks good to me, approved Eric Lai: Looks good to me, approved build bot (Jenkins): Verified diff --git a/src/mainboard/google/brya/variants/craaskov/overridetree.cb b/src/mainboard/google/brya/variants/craaskov/overridetree.cb index cc4ce53..d8d2efb 100644 --- a/src/mainboard/google/brya/variants/craaskov/overridetree.cb +++ b/src/mainboard/google/brya/variants/craaskov/overridetree.cb @@ -243,7 +243,7 @@ register "generic.reset_delay_ms" = "20" register "generic.reset_off_delay_ms" = "2" register "generic.enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_C0)" - register "generic.enable_delay_ms" = "1" + register "generic.enable_delay_ms" = "6" register "generic.stop_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_C6)" register "generic.stop_delay_ms" = "150" register "generic.stop_off_delay_ms" = "2" -- To view, visit https://review.coreboot.org/c/coreboot/+/79978?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Id57ab04e61d9e95c962f2c564d3a7e2e7ed6b992 Gerrit-Change-Number: 79978 Gerrit-PatchSet: 6 Gerrit-Owner: Rex Chou <rex_chou(a)compal.corp-partner.google.com> Gerrit-Reviewer: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Ian Feng <ian_feng(a)compal.corp-partner.google.com> Gerrit-Reviewer: Kenny Pan <kennypan(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Shou-Chieh Hsu <shouchieh(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Van Chen <van_chen(a)compal.corp-partner.google.com> Gerrit-MessageType: merged

1 0

[XS] Change in coreboot[main]: soc/mediatek/mt8188: Enable EARLY_MMU_INIT
by Felix Held (Code Review) 17 Jan '24

17 Jan '24

Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/79991?usp=email ) ( 3 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: soc/mediatek/mt8188: Enable EARLY_MMU_INIT ...................................................................... soc/mediatek/mt8188: Enable EARLY_MMU_INIT The boot time is improved by 65ms. (762ms -> 697ms) BUG=b:320381143 TEST=check timestamps in cbmem Change-Id: I74191ab8cbefa08b7e296312645ea40b46fabf77 Signed-off-by: Yidi Lin <yidilin(a)chromium.org> Reviewed-on: https://review.coreboot.org/c/coreboot/+/79991 Reviewed-by: Yu-Ping Wu <yupingso(a)google.com> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- M src/soc/mediatek/mt8188/Kconfig 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Yu-Ping Wu: Looks good to me, approved build bot (Jenkins): Verified diff --git a/src/soc/mediatek/mt8188/Kconfig b/src/soc/mediatek/mt8188/Kconfig index 7de64aa..494373a 100644 --- a/src/soc/mediatek/mt8188/Kconfig +++ b/src/soc/mediatek/mt8188/Kconfig @@ -14,6 +14,7 @@ select USE_CBMEM_DRAM_INFO select DPM_FOUR_CHANNEL select ARM64_USE_ARCH_TIMER + select EARLY_MMU_INIT if SOC_MEDIATEK_MT8188 -- To view, visit https://review.coreboot.org/c/coreboot/+/79991?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I74191ab8cbefa08b7e296312645ea40b46fabf77 Gerrit-Change-Number: 79991 Gerrit-PatchSet: 5 Gerrit-Owner: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[S] Change in coreboot[main]: soc/mediatek: Add EARLY_MMU_INIT kconfig option
by Felix Held (Code Review) 17 Jan '24

17 Jan '24

Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/79990?usp=email ) Change subject: soc/mediatek: Add EARLY_MMU_INIT kconfig option ...................................................................... soc/mediatek: Add EARLY_MMU_INIT kconfig option Accessing RAM before mmu initialized is time consuming. During mmu initialization, `mmu_init()` and `mmu_config_range()` write logs to the console buffer and contribue the extra boot time. This patch adds a kconfig option to move `mtk_mmu_init()` to `bootblock_soc_early_init()`. When `EARLY_MMU_INIT` is enabled, mmu is initialized before `console_init()` ready. So `mmu_init()` and `mmu_config_range()` won't write logs to the console buffer and save the boot time. It saves about 65ms on Geralt with EARLY_MMU_INIT enabled. Before: 0:1st timestamp 239,841 (0) 11:start of bootblock 239,920 (79) 12:end of bootblock 323,191 (83,271) After: 0:1st timestamp 239,804 (0) 11:start of bootblock 239,884 (80) 12:end of bootblock 258,846 (18,962) BUG=b:320381143 TEST=check timestamps in cbmem Change-Id: I7f4c3c6c836f7276119698c6de362794cf4222a6 Signed-off-by: Yidi Lin <yidilin(a)chromium.org> Reviewed-on: https://review.coreboot.org/c/coreboot/+/79990 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Yu-Ping Wu <yupingso(a)google.com> --- M src/soc/mediatek/common/Kconfig A src/soc/mediatek/common/bootblock.c M src/soc/mediatek/common/mmu_operations.c M src/soc/mediatek/mt8188/Makefile.inc 4 files changed, 25 insertions(+), 1 deletion(-) Approvals: build bot (Jenkins): Verified Yu-Ping Wu: Looks good to me, approved diff --git a/src/soc/mediatek/common/Kconfig b/src/soc/mediatek/common/Kconfig index 8092aa7..268f2f3 100644 --- a/src/soc/mediatek/common/Kconfig +++ b/src/soc/mediatek/common/Kconfig @@ -91,4 +91,11 @@ When this option is enabled, the DEVAPC driver prints the settings after initialization. +config EARLY_MMU_INIT + bool + default n + help + When this option is enabled, `mtk_mmu_init()` will be done in + `bootblock_soc_early_init()` to reduce the boot time. + endif diff --git a/src/soc/mediatek/common/bootblock.c b/src/soc/mediatek/common/bootblock.c new file mode 100644 index 0000000..6474a8f --- /dev/null +++ b/src/soc/mediatek/common/bootblock.c @@ -0,0 +1,10 @@ +/* SPDX-License-Identifier: GPL-2.0-only */ + +#include <bootblock_common.h> +#include <soc/mmu_operations.h> + +void bootblock_soc_early_init(void) +{ + if (CONFIG(EARLY_MMU_INIT)) + mtk_mmu_init(); +} diff --git a/src/soc/mediatek/common/mmu_operations.c b/src/soc/mediatek/common/mmu_operations.c index 340f9ec..cbd6c09 100644 --- a/src/soc/mediatek/common/mmu_operations.c +++ b/src/soc/mediatek/common/mmu_operations.c @@ -9,6 +9,13 @@ void mtk_mmu_init(void) { + static bool mmu_inited; + + if (mmu_inited) + return; + + mmu_inited = true; + mmu_init(); /* diff --git a/src/soc/mediatek/mt8188/Makefile.inc b/src/soc/mediatek/mt8188/Makefile.inc index 4731fab..14f7d38 100644 --- a/src/soc/mediatek/mt8188/Makefile.inc +++ b/src/soc/mediatek/mt8188/Makefile.inc @@ -9,7 +9,7 @@ all-y += timer.c ../common/timer_prepare.c all-y += ../common/uart.c -bootblock-y += bootblock.c +bootblock-y += ../common/bootblock.c bootblock.c bootblock-y += ../common/eint_event.c bootblock-y += ../common/lastbus_v2.c lastbus.c bootblock-y += ../common/mmu_operations.c -- To view, visit https://review.coreboot.org/c/coreboot/+/79990?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I7f4c3c6c836f7276119698c6de362794cf4222a6 Gerrit-Change-Number: 79990 Gerrit-PatchSet: 5 Gerrit-Owner: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[M] Change in coreboot[main]: mb/google/brox: Enable HDA Codec-ALC256
by Paul Menzel (Code Review) 17 Jan '24

17 Jan '24

Attention is currently required from: Poornima Tom, Shelley Chen, Vamshi Krishna Gopal. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79723?usp=email ) Change subject: mb/google/brox: Enable HDA Codec-ALC256 ...................................................................... Patch Set 5: Code-Review+1 (5 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/79723/comment/b27acb40_6dbaff61 : PS5, Line 7: Codec-ALC256 Remove the hyphen? https://review.coreboot.org/c/coreboot/+/79723/comment/7da9b8ca_3e9c30f6 : PS5, Line 9: ALC 256 Remove the space? https://review.coreboot.org/c/coreboot/+/79723/comment/db4dfa57_648cd65c : PS5, Line 9: Add verb table for the same. How did you create this? https://review.coreboot.org/c/coreboot/+/79723/comment/74a0ce4a_da3f8e96 : PS5, Line 11: Please document the datasheet name and revision. https://review.coreboot.org/c/coreboot/+/79723/comment/f9e7e243_265123cd : PS5, Line 14: To verify HDA on Brox Does that mean, you are going to test it? -- To view, visit https://review.coreboot.org/c/coreboot/+/79723?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I1edd5aee053debe39b34048266703031c088cd00 Gerrit-Change-Number: 79723 Gerrit-PatchSet: 5 Gerrit-Owner: Poornima Tom <poornima.tom(a)intel.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: Vamshi Krishna Gopal <vamshi.krishna.gopal(a)intel.com> Gerrit-Reviewer: Vamshi Krishna Gopal <vamshi.krishna.gopal(a)intel.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Poornima Tom <poornima.tom(a)intel.com> Gerrit-Attention: Shelley Chen <shchen(a)google.com> Gerrit-Attention: Vamshi Krishna Gopal <vamshi.krishna.gopal(a)intel.com> Gerrit-Comment-Date: Wed, 17 Jan 2024 14:36:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: device/device.h: Drop acpi_inject_dsdt
by Felix Held (Code Review) 17 Jan '24

17 Jan '24

Attention is currently required from: Arthur Heymans, Chen, Gang C, Cliff Huang, Jincheng Li, Lance Zhao, Paul Menzel, Shuo Liu, Tim Wawrzynczak. Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78334?usp=email ) Change subject: device/device.h: Drop acpi_inject_dsdt ...................................................................... Patch Set 14: (1 comment) Patchset: PS14: > not sure if the coreboot-gerrit reported failure is a false positive […] looks to me that there's something wrong with the order of the patches, since CB:78333 which removes the last usage of acpi_inject_dsdt is now after this patch which removes acpi_inject_dsdt -- To view, visit https://review.coreboot.org/c/coreboot/+/78334?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Iffefc865901b15fa299931b6ed4c27a9e3a1c330 Gerrit-Change-Number: 78334 Gerrit-PatchSet: 14 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Chen, Gang C <gang.c.chen(a)intel.com> Gerrit-Reviewer: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Jincheng Li <jincheng.li(a)intel.com> Gerrit-Reviewer: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Shuo Liu <shuo.liu(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Attention: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Attention: Chen, Gang C <gang.c.chen(a)intel.com> Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Shuo Liu <shuo.liu(a)intel.com> Gerrit-Attention: Jincheng Li <jincheng.li(a)intel.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Wed, 17 Jan 2024 14:29:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Shuo Liu <shuo.liu(a)intel.com> Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: MAINTAINERS: Add Kapil for soc/intel/alderlake and mb/google/brya
by Felix Held (Code Review) 17 Jan '24

17 Jan '24

Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/79989?usp=email ) Change subject: MAINTAINERS: Add Kapil for soc/intel/alderlake and mb/google/brya ...................................................................... MAINTAINERS: Add Kapil for soc/intel/alderlake and mb/google/brya Signed-off-by: Kapil Porwal <kapilporwal(a)google.com> Change-Id: Id8e3637d88d195c6a7d4afd5e6266da718215767 Reviewed-on: https://review.coreboot.org/c/coreboot/+/79989 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Subrata Banik <subratabanik(a)google.com> --- M MAINTAINERS 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Subrata Banik: Looks good to me, approved build bot (Jenkins): Verified diff --git a/MAINTAINERS b/MAINTAINERS index b7db6d8..2648f36 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -359,6 +359,7 @@ M: Subrata Banik <subratabanik(a)google.com> M: Nick Vaccaro <nvaccaro(a)chromium.org> M: Eric Lai <ericllai(a)google.com> +M: Kapil Porwal <kapilporwal(a)google.com> S: Maintained F: src/mainboard/google/brya/ @@ -895,6 +896,7 @@ INTEL ALDERLAKE SOC M: Subrata Banik <subratabanik(a)google.com> M: Nick Vaccaro <nvaccaro(a)chromium.org> +M: Kapil Porwal <kapilporwal(a)google.com> S: Maintained F: src/soc/intel/alderlake/ -- To view, visit https://review.coreboot.org/c/coreboot/+/79989?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Id8e3637d88d195c6a7d4afd5e6266da718215767 Gerrit-Change-Number: 79989 Gerrit-PatchSet: 2 Gerrit-Owner: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[S] Change in coreboot[main]: util/superiotool: reformat alternate dump output
by Paul Menzel (Code Review) 17 Jan '24

17 Jan '24

Attention is currently required from: Matt DeVillier. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80004?usp=email ) The change is no longer submittable: All-Comments-Resolved is unsatisfied now. Change subject: util/superiotool: reformat alternate dump output ...................................................................... Patch Set 1: Code-Review+1 (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/80004/comment/37099a9d_d9bf9dbe : PS1, Line 12: Maybe paste lines of the old and new output in the commit message? -- To view, visit https://review.coreboot.org/c/coreboot/+/80004?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Idef2cc136151328b114620eb297ab8fd62b71bcd Gerrit-Change-Number: 80004 Gerrit-PatchSet: 1 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Comment-Date: Wed, 17 Jan 2024 14:00:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: device/device.h: Drop acpi_inject_dsdt
by Shuo Liu (Code Review) 17 Jan '24

17 Jan '24

Attention is currently required from: Arthur Heymans, Chen, Gang C, Cliff Huang, Felix Held, Jincheng Li, Lance Zhao, Paul Menzel, Tim Wawrzynczak. Shuo Liu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78334?usp=email ) Change subject: device/device.h: Drop acpi_inject_dsdt ...................................................................... Patch Set 14: (1 comment) Patchset: PS14: not sure if the coreboot-gerrit reported failure is a false positive src/soc/intel/xeon_sp/uncore.c:352:3: error: field designator 'acpi_inject_dsdt' does not refer to any field in type 'struct device_operations' .acpi_inject_dsdt = uncore_inject_dsdt, ^ 1 error generated. the marked compilation error occurs at a code line actually doesn't exist -- To view, visit https://review.coreboot.org/c/coreboot/+/78334?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Iffefc865901b15fa299931b6ed4c27a9e3a1c330 Gerrit-Change-Number: 78334 Gerrit-PatchSet: 14 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Chen, Gang C <gang.c.chen(a)intel.com> Gerrit-Reviewer: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Jincheng Li <jincheng.li(a)intel.com> Gerrit-Reviewer: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Shuo Liu <shuo.liu(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Attention: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Attention: Chen, Gang C <gang.c.chen(a)intel.com> Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Jincheng Li <jincheng.li(a)intel.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Wed, 17 Jan 2024 13:21:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in coreboot[main]: mb/google/brox: Enable HDA Codec-ALC256
by Vamshi Krishna Gopal (Code Review) 17 Jan '24

17 Jan '24

Attention is currently required from: Paul Menzel, Poornima Tom, Shelley Chen, Vamshi Krishna Gopal. Vamshi Krishna Gopal has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79723?usp=email ) Change subject: mb/google/brox: Enable HDA Codec-ALC256 ...................................................................... Patch Set 5: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/79723?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I1edd5aee053debe39b34048266703031c088cd00 Gerrit-Change-Number: 79723 Gerrit-PatchSet: 5 Gerrit-Owner: Poornima Tom <poornima.tom(a)intel.com> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: Vamshi Krishna Gopal <vamshi.krishna.gopal(a)intel.com> Gerrit-Reviewer: Vamshi Krishna Gopal <vamshi.krishna.gopal(a)intel.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Poornima Tom <poornima.tom(a)intel.com> Gerrit-Attention: Shelley Chen <shchen(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Vamshi Krishna Gopal <vamshi.krishna.gopal(a)intel.com> Gerrit-Comment-Date: Wed, 17 Jan 2024 12:44:51 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XL] Change in coreboot[main]: mb/arm/rdn2: Add support for Arm Neoverse N2
by Naresh Solanki (Code Review) 17 Jan '24

17 Jan '24

Attention is currently required from: Angel Pons, Arthur Heymans, David Milosevic, Maximilian Brune, Patrick Rudolph, Paul Menzel. Naresh Solanki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79103?usp=email ) Change subject: mb/arm/rdn2: Add support for Arm Neoverse N2 ...................................................................... Patch Set 6: (1 comment) File src/mainboard/arm/rdn2/acpi.c: https://review.coreboot.org/c/coreboot/+/79103/comment/b19d2fe9_76213b70 : PS5, Line 29: platform_get_gicd_base > Yes. […] Done -- To view, visit https://review.coreboot.org/c/coreboot/+/79103?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I17908d3ce773d4a88924bafb1d0e9e2a043c7fbc Gerrit-Change-Number: 79103 Gerrit-PatchSet: 6 Gerrit-Owner: Naresh Solanki <naresh.solanki(a)9elements.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: David Milosevic <David.Milosevic(a)9elements.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Benjamin Doron <benjamin.doron00(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: David Milosevic <David.Milosevic(a)9elements.com> Gerrit-Comment-Date: Wed, 17 Jan 2024 12:41:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Patrick Rudolph <patrick.rudolph(a)9elements.com> Comment-In-Reply-To: Naresh Solanki <naresh.solanki(a)9elements.com> Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit January 2024