coreboot-gerrit April 2023

coreboot-gerrit@coreboot.org

1 participants
5761 discussions

[S] Change in coreboot[master]: soc/amd/mendocino: update FSP parameters for eDP power sequence adjus...
by Chris Wang (Code Review) 26 Apr '23

26 Apr '23

Attention is currently required from: Jason Glenesk, Raul Rangel, Matt DeVillier, Fred Reitberger, Felix Held. Hello build bot (Jenkins), Jason Glenesk, Raul Rangel, Matt DeVillier, Fred Reitberger, Felix Held, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/74758 to look at the new patch set (#3). Change subject: soc/amd/mendocino: update FSP parameters for eDP power sequence adjustment ...................................................................... soc/amd/mendocino: update FSP parameters for eDP power sequence adjustment Update UPD parameters for eDP power sequence adjustment. 1. Set edp_panel_t8_ms for varybl to blon. 2. Set edp_panel_t9_ms for bloff to varybloff. BUG=b:271704149 TEST=Build; Verify the UPD was pass to system integrated table. Signed-off-by: Chris Wang <chris.wang(a)amd.corp-partner.google.com> Change-Id: Ibdf50db12d982b45edca205e8f4612deb702453d --- M src/soc/amd/mendocino/chip.h M src/soc/amd/mendocino/fsp_m_params.c 2 files changed, 24 insertions(+), 4 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/58/74758/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/74758 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibdf50db12d982b45edca205e8f4612deb702453d Gerrit-Change-Number: 74758 Gerrit-PatchSet: 3 Gerrit-Owner: Chris Wang <chris.wang(a)amd.corp-partner.google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: mb/google/skyrim/var/winterhold: adjust eDP panel power sequence
by Chris Wang (Code Review) 26 Apr '23

26 Apr '23

Attention is currently required from: Jason Nien, Matt DeVillier, Martin Roth. Hello build bot (Jenkins), Jason Nien, Matt DeVillier, Martin Roth, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/74759 to look at the new patch set (#4). Change subject: mb/google/skyrim/var/winterhold: adjust eDP panel power sequence ...................................................................... mb/google/skyrim/var/winterhold: adjust eDP panel power sequence 1. Set edp_panel_t8_ms to 112ms 2. Set edp_panel_t9_ms to 8ms BUG=b:271704149 BRANCH=none TEST=Build; Verify the UPD was passed to system integrated table. Signed-off-by: Chris Wang <chris.wang(a)amd.corp-partner.google.com> Change-Id: Ifefd47a86e53d574098ae2e5bd2f41ae79353385 --- M src/mainboard/google/skyrim/variants/winterhold/overridetree.cb 1 file changed, 19 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/59/74759/4 -- To view, visit https://review.coreboot.org/c/coreboot/+/74759 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ifefd47a86e53d574098ae2e5bd2f41ae79353385 Gerrit-Change-Number: 74759 Gerrit-PatchSet: 4 Gerrit-Owner: Chris Wang <chris.wang(a)amd.corp-partner.google.com> Gerrit-Reviewer: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: vc/amd/fsp/mendocino/FspmUpd: Update UPD structure for MDN-FSP
by Chris Wang (Code Review) 26 Apr '23

26 Apr '23

Attention is currently required from: Jason Glenesk, Raul Rangel, Chris Wang, Fred Reitberger, Felix Held. Hello build bot (Jenkins), Jason Glenesk, Raul Rangel, Matt DeVillier, Fred Reitberger, Felix Held, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/74757 to look at the new patch set (#2). Change subject: vc/amd/fsp/mendocino/FspmUpd: Update UPD structure for MDN-FSP ...................................................................... vc/amd/fsp/mendocino/FspmUpd: Update UPD structure for MDN-FSP Update UPD structure to align with MDN-FSP. Also, rename the UDP name to match the eDP sequence timing in ms. BUG=b:271704149 BRANCH=none Test=Build/Boot to ChromeOS Signed-off-by: Chris Wang <chris.wang(a)amd.corp-partner.google.com> Change-Id: Id410c40a65c0fd4b9b73cf36dc1f08eba0a3e44c --- M src/vendorcode/amd/fsp/mendocino/FspmUpd.h 1 file changed, 20 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/57/74757/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/74757 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id410c40a65c0fd4b9b73cf36dc1f08eba0a3e44c Gerrit-Change-Number: 74757 Gerrit-PatchSet: 2 Gerrit-Owner: Chris Wang <chris.wang(a)amd.corp-partner.google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Chris Wang <chris.wang(a)amd.corp-partner.google.com> Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: device/Kconfig: Reduce PCIe hotplug bus numbers and IO resources
by Lean Sheng Tan (Code Review) 26 Apr '23

26 Apr '23

Attention is currently required from: Jeremy Soller, Arthur Heymans, Werner Zeh. Lean Sheng Tan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74774 ) Change subject: device/Kconfig: Reduce PCIe hotplug bus numbers and IO resources ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: > Hey Jeremy. […] Will let Jeremy comments first. -- To view, visit https://review.coreboot.org/c/coreboot/+/74774 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8371958037d479e7d2053f49814735e15461ca6e Gerrit-Change-Number: 74774 Gerrit-PatchSet: 2 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Jeremy Soller <jeremy(a)system76.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Attention: Jeremy Soller <jeremy(a)system76.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Comment-Date: Wed, 26 Apr 2023 09:57:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-MessageType: comment

1 0

[L] Change in coreboot[master]: drivers/i2c: Add PI7C9X2G608GP PCIe switch driver (pi608gp)
by Paul Menzel (Code Review) 26 Apr '23

26 Apr '23

Attention is currently required from: Mario Scheithauer, Arthur Heymans, Lean Sheng Tan, Werner Zeh, Jan Samek. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74433 ) Change subject: drivers/i2c: Add PI7C9X2G608GP PCIe switch driver (pi608gp) ...................................................................... Patch Set 14: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/74433 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id191c4e97b99da58efd3ba38bf8cca3603ece4d5 Gerrit-Change-Number: 74433 Gerrit-PatchSet: 14 Gerrit-Owner: Jan Samek <jan.samek(a)siemens.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Mario Scheithauer <mario.scheithauer(a)siemens.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Mario Scheithauer <mario.scheithauer(a)siemens.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Attention: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Attention: Jan Samek <jan.samek(a)siemens.com> Gerrit-Comment-Date: Wed, 26 Apr 2023 09:55:46 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[L] Change in coreboot[master]: drivers/i2c: Add PI7C9X2G608GP PCIe switch driver (pi608gp)
by Jan Samek (Code Review) 26 Apr '23

26 Apr '23

Attention is currently required from: Paul Menzel, Mario Scheithauer, Lean Sheng Tan, Werner Zeh. Jan Samek has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74433 ) Change subject: drivers/i2c: Add PI7C9X2G608GP PCIe switch driver (pi608gp) ...................................................................... Patch Set 14: (1 comment) File src/drivers/i2c/pi608gp/pi608gp.c: https://review.coreboot.org/c/coreboot/+/74433/comment/33d649bf_ffa34c7d PS12, Line 71: /* Compose the SMBus message for register read init operation (from MSB to LSB): : Byte 1: 7:3 = Rsvd., 2:0 = Command, : Byte 2: 7:4 = Rsvd., 3:0 = Port Select[4:1], : Byte 3: 7 = Port Select[0], 6 = Rsvd., 5:2 = Byte Enable, 1:0 = Reg. Addr. [11:10], : Byte 4: 7:0 = Reg. Addr.[9:2] (Reg. Addr. [1:0] fixed to 0). */ > I’d use: […] OK, now it's clear - thanks. -- To view, visit https://review.coreboot.org/c/coreboot/+/74433 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id191c4e97b99da58efd3ba38bf8cca3603ece4d5 Gerrit-Change-Number: 74433 Gerrit-PatchSet: 14 Gerrit-Owner: Jan Samek <jan.samek(a)siemens.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Mario Scheithauer <mario.scheithauer(a)siemens.com> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Mario Scheithauer <mario.scheithauer(a)siemens.com> Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Attention: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Comment-Date: Wed, 26 Apr 2023 09:54:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Comment-In-Reply-To: Jan Samek <jan.samek(a)siemens.com> Gerrit-MessageType: comment

1 0

[L] Change in coreboot[master]: drivers/i2c: Add PI7C9X2G608GP PCIe switch driver (pi608gp)
by build bot (Jenkins) (Code Review) 26 Apr '23

26 Apr '23

Attention is currently required from: Mario Scheithauer, Lean Sheng Tan, Werner Zeh, Jan Samek. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74433 ) Change subject: drivers/i2c: Add PI7C9X2G608GP PCIe switch driver (pi608gp) ...................................................................... Patch Set 14: (1 comment) Commit Message: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-175012): https://review.coreboot.org/c/coreboot/+/74433/comment/93b7ec00_10e67786 PS14, Line 29: Link to the datasheet: Possible unwrapped commit description (prefer a maximum 72 chars per line) -- To view, visit https://review.coreboot.org/c/coreboot/+/74433 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id191c4e97b99da58efd3ba38bf8cca3603ece4d5 Gerrit-Change-Number: 74433 Gerrit-PatchSet: 14 Gerrit-Owner: Jan Samek <jan.samek(a)siemens.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Mario Scheithauer <mario.scheithauer(a)siemens.com> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Mario Scheithauer <mario.scheithauer(a)siemens.com> Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Attention: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Attention: Jan Samek <jan.samek(a)siemens.com> Gerrit-Comment-Date: Wed, 26 Apr 2023 09:53:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[L] Change in coreboot[master]: drivers/i2c: Add PI7C9X2G608GP PCIe switch driver (pi608gp)
by Jan Samek (Code Review) 26 Apr '23

26 Apr '23

Attention is currently required from: Mario Scheithauer, Lean Sheng Tan, Werner Zeh, Jan Samek. Hello build bot (Jenkins), Mario Scheithauer, Arthur Heymans, Lean Sheng Tan, Werner Zeh, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/74433 to look at the new patch set (#14). Change subject: drivers/i2c: Add PI7C9X2G608GP PCIe switch driver (pi608gp) ...................................................................... drivers/i2c: Add PI7C9X2G608GP PCIe switch driver (pi608gp) This patch adds some of the variety of configuration options exported by the Pericom Inc. PI7C9X2G608GP PCIe switch over its SMBus interface. Currently implemented options are only used to adjust the switch upstream port amplitude and de-emphasis levels in millivolts. Only values specified in the switch datasheet (in tables 6-6 and 6-8) are allowed. Example of a devicetree.cb entry: chip drivers/i2c/pi608gp register "gen2_3p5_enable" = "true" register "gen2_3p5_amp" = "AMP_LVL_MV(425)" register "gen2_3p5_deemph" = \ "DEEMPH_LVL_MV(37, 5)" device i2c 0x6f on ops pi608gp_ops end end Link to the datasheet: https://web.archive.org/web/20210225074853/https://www.diodes.com/assets/Da… BUG=none TEST=Create devicetree.cb and Kconfig entries for this driver in a mainboard containing the switch and verify, that the values read out from the switch config space match the values programmed over the SMBus. Change-Id: Id191c4e97b99da58efd3ba38bf8cca3603ece4d5 Signed-off-by: Jan Samek <jan.samek(a)siemens.com> --- A src/drivers/i2c/pi608gp/Kconfig A src/drivers/i2c/pi608gp/Makefile.inc A src/drivers/i2c/pi608gp/chip.h A src/drivers/i2c/pi608gp/pi608gp.c A src/drivers/i2c/pi608gp/pi608gp.h 5 files changed, 257 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/33/74433/14 -- To view, visit https://review.coreboot.org/c/coreboot/+/74433 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id191c4e97b99da58efd3ba38bf8cca3603ece4d5 Gerrit-Change-Number: 74433 Gerrit-PatchSet: 14 Gerrit-Owner: Jan Samek <jan.samek(a)siemens.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Mario Scheithauer <mario.scheithauer(a)siemens.com> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Mario Scheithauer <mario.scheithauer(a)siemens.com> Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Attention: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Attention: Jan Samek <jan.samek(a)siemens.com> Gerrit-MessageType: newpatchset

1 0

[L] Change in coreboot[master]: [RFC] drivers/option: Add option list in cbtable
by Lean Sheng Tan (Code Review) 26 Apr '23

26 Apr '23

Attention is currently required from: Sean Rhodes, Benjamin Doron, Angel Pons, Maximilian Brune. Lean Sheng Tan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74121 ) Change subject: [RFC] drivers/option: Add option list in cbtable ...................................................................... Patch Set 2: (1 comment) File src/drivers/option/cfr.h: https://review.coreboot.org/c/coreboot/+/74121/comment/e4cf45a5_3c315e51 PS2, Line 10: SETUP_MENU_VAR_FLAG_READONLY = 1 << 0, : SETUP_MENU_VAR_FLAG_GRAYOUT = 1 << 1, : SETUP_MENU_VAR_FLAG_SUPPRESS = 1 << 2, > Or shorten the prefix: CFR_OPTFLAG_ yeah this sounds better -- To view, visit https://review.coreboot.org/c/coreboot/+/74121 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I304de7d26d79245a2e31a6d01f6c5643b31cb772 Gerrit-Change-Number: 74121 Gerrit-PatchSet: 2 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Benjamin Doron <benjamin.doron00(a)gmail.com> Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Daniel Maslowski <info(a)orangecms.org> Gerrit-CC: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Attention: Benjamin Doron <benjamin.doron00(a)gmail.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Comment-Date: Wed, 26 Apr 2023 09:45:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Sean Rhodes <sean(a)starlabs.systems> Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

[L] Change in coreboot[master]: [RFC] drivers/option: Add option list in cbtable
by Angel Pons (Code Review) 26 Apr '23

26 Apr '23

Attention is currently required from: Sean Rhodes, Benjamin Doron, Maximilian Brune, Lean Sheng Tan. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74121 ) Change subject: [RFC] drivers/option: Add option list in cbtable ...................................................................... Patch Set 2: (1 comment) File src/drivers/option/cfr.h: https://review.coreboot.org/c/coreboot/+/74121/comment/42ffa177_16c4bed5 PS2, Line 10: SETUP_MENU_VAR_FLAG_READONLY = 1 << 0, : SETUP_MENU_VAR_FLAG_GRAYOUT = 1 << 1, : SETUP_MENU_VAR_FLAG_SUPPRESS = 1 << 2, > This will make for some very long lines, maybe just RDONLY, GRAYED and SUPPRS? Or shorten the prefix: CFR_OPTFLAG_ -- To view, visit https://review.coreboot.org/c/coreboot/+/74121 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I304de7d26d79245a2e31a6d01f6c5643b31cb772 Gerrit-Change-Number: 74121 Gerrit-PatchSet: 2 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Benjamin Doron <benjamin.doron00(a)gmail.com> Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Daniel Maslowski <info(a)orangecms.org> Gerrit-CC: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Attention: Benjamin Doron <benjamin.doron00(a)gmail.com> Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Comment-Date: Wed, 26 Apr 2023 09:44:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Sean Rhodes <sean(a)starlabs.systems> Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit April 2023