coreboot-gerrit April 2023

coreboot-gerrit@coreboot.org

1 participants
5761 discussions

[S] Change in coreboot[master]: mb/google/nissa/var/yavilla: Add elan touchscreen support
by Tony Huang (Code Review) 26 Apr '23

26 Apr '23

Attention is currently required from: Tarun Tuli, Chen-Tsung Hsieh, Derek Huang. Tony Huang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74776 ) Change subject: mb/google/nissa/var/yavilla: Add elan touchscreen support ...................................................................... Patch Set 1: (1 comment) File src/mainboard/google/brya/variants/yavilla/overridetree.cb: https://review.coreboot.org/c/coreboot/+/74776/comment/9ece9a18_6b499ccf PS1, Line 168: register "stop_delay_ms" = "280" > wondering why stop need 280ms. It's for bring-up. Timing will be measured after device arrives. Thanks -- To view, visit https://review.coreboot.org/c/coreboot/+/74776 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2779c2930d89ff42233f9b20bd8abdf6dc00c0e0 Gerrit-Change-Number: 74776 Gerrit-PatchSet: 1 Gerrit-Owner: Tony Huang <tony-huang(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Chen-Tsung Hsieh <chentsung(a)chromium.org> Gerrit-Reviewer: Derek Huang <derekhuang(a)google.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Robert Chen <robert.chen(a)quanta.corp-partner.google.com> Gerrit-CC: Shon Wang <shon.wang(a)quanta.corp-partner.google.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Chen-Tsung Hsieh <chentsung(a)chromium.org> Gerrit-Attention: Derek Huang <derekhuang(a)google.com> Gerrit-Comment-Date: Wed, 26 Apr 2023 08:53:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: acpi: Add a runtime method to override exposed _Sx sleep states
by Jan Samek (Code Review) 26 Apr '23

26 Apr '23

Attention is currently required from: Lance Zhao, Nico Huber, Paul Menzel, Tim Wawrzynczak, Maximilian Brune, Arthur Heymans, Werner Zeh. Jan Samek has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74762 ) Change subject: acpi: Add a runtime method to override exposed _Sx sleep states ...................................................................... Patch Set 8: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/74762 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic21830c1ef9c183b1e3005cc1f8b7daf7e9ea998 Gerrit-Change-Number: 74762 Gerrit-PatchSet: 8 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Jan Samek <jan.samek(a)siemens.com> Gerrit-Reviewer: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Comment-Date: Wed, 26 Apr 2023 08:52:04 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/prodrive/atlas: Enable/disable sleep states based on EC
by Lean Sheng Tan (Code Review) 26 Apr '23

26 Apr '23

Attention is currently required from: Lance Zhao, Tim Wawrzynczak, Christian Walter, Angel Pons, Arthur Heymans. Lean Sheng Tan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74421 ) Change subject: mb/prodrive/atlas: Enable/disable sleep states based on EC ...................................................................... Patch Set 12: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/74421/comment/01e8c444_dfccf180 PS12, Line 10: have the option to be able to sleep, the reason being that windows goes : to sleep after 30min of inactivity. how about "so that the 'Sleep' function will be disabled properly in Microsoft Windows"? -- To view, visit https://review.coreboot.org/c/coreboot/+/74421 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I424db7e712a705c628aa3a10a486d3313404987a Gerrit-Change-Number: 74421 Gerrit-PatchSet: 12 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Wed, 26 Apr 2023 08:51:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: soc/amd/common/block: Add missing cbfs_unmap()
by Grzegorz Bernacki (Code Review) 26 Apr '23

26 Apr '23

Grzegorz Bernacki has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/74716 ) Change subject: soc/amd/common/block: Add missing cbfs_unmap() ...................................................................... Abandoned This patch has been divided into 3 separate patches -- To view, visit https://review.coreboot.org/c/coreboot/+/74716 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibbebe7401e9f5a5312da1216408bf42fa2449db1 Gerrit-Change-Number: 74716 Gerrit-PatchSet: 2 Gerrit-Owner: Grzegorz Bernacki Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Konrad Adamczyk <konrada(a)google.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Tim Van Patten <timvp(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: abandon

1 0

[M] Change in coreboot[master]: soc/amd/common/block: Add missing cbfs_unmap()
by Grzegorz Bernacki (Code Review) 26 Apr '23

26 Apr '23

Attention is currently required from: Jason Glenesk, Raul Rangel, Jakub Czapiga, Matt DeVillier, Paul Menzel, Tim Van Patten, Fred Reitberger, Karthik Ramasubramanian, Felix Held. Grzegorz Bernacki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74716 ) Change subject: soc/amd/common/block: Add missing cbfs_unmap() ...................................................................... Patch Set 2: (5 comments) File src/soc/amd/common/block/cpu/update_microcode.c: https://review.coreboot.org/c/coreboot/+/74716/comment/293b46f7_3bf2faea PS2, Line 98: ucode = find_microcode(ucode, equivalent_processor_rev_id); > This is a bug, since we can no long `cbfs_unmap(ucode)`, since we've lost the address. […] Thanks for noticing this, I just put `find_microcode()` under if statement, so there is no need to have `ucode_cache` variable https://review.coreboot.org/c/coreboot/+/74716/comment/c0c6a13f_0fd9d9df PS2, Line 100: cbfs_unmap((void *)ucode); > As noted in the previous comment, this is essentially calling `cbfs_unmap(NULL)` (as enforced by the […] I don't modify ucode anymore, it should be fixed https://review.coreboot.org/c/coreboot/+/74716/comment/a3326bd9_bc736ef7 PS2, Line 111: (void *) > Are these casts necessary? Yes, it generates warning otherwise File src/soc/amd/common/block/graphics/graphics.c: https://review.coreboot.org/c/coreboot/+/74716/comment/b20108aa_7e58c5dd PS1, Line 173: cbfs_unmap(rom); > `cbfs_unmap()` ignores addresses it doesn't recognize, so it's (currently) safe to always call it, e […] Yes, you're right, but it would be good to have more clean solution. For now I just move unmapping to pci_rom_free(). File src/soc/amd/common/block/graphics/graphics.c: https://review.coreboot.org/c/coreboot/+/74716/comment/9df48731_9a318320 PS2, Line 164: return; > Based on the comment below, this appears to be missing a call to `timestamp_add_now()`. […] Yes, it is, thanks. I added it in new version -- To view, visit https://review.coreboot.org/c/coreboot/+/74716 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibbebe7401e9f5a5312da1216408bf42fa2449db1 Gerrit-Change-Number: 74716 Gerrit-PatchSet: 2 Gerrit-Owner: Grzegorz Bernacki Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Konrad Adamczyk <konrada(a)google.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Tim Van Patten <timvp(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Tim Van Patten <timvp(a)google.com> Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Wed, 26 Apr 2023 08:48:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Jakub Czapiga <jacz(a)semihalf.com> Comment-In-Reply-To: Grzegorz Bernacki Comment-In-Reply-To: Tim Van Patten <timvp(a)google.com> Comment-In-Reply-To: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: soc/amd/common/block/graphics: Add missing cbfs_unmap()
by Grzegorz Bernacki (Code Review) 26 Apr '23

26 Apr '23

Attention is currently required from: Jason Glenesk, Raul Rangel, Matt DeVillier, Fred Reitberger, Felix Held. Grzegorz Bernacki has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/74779 ) Change subject: soc/amd/common/block/graphics: Add missing cbfs_unmap() ...................................................................... soc/amd/common/block/graphics: Add missing cbfs_unmap() cbfs_map() can allocate memory, so cbfs_unmap() should be called before leaving the function. BUG=278264488 TEST=Build and run with additional debug prints added to confirm that data are correctly unmapped Change-Id: Ie6fbbfd36f0974551befef4d08423a8148e151e7 Signed-off-by: Grzegorz Bernacki <bernacki(a)google.com> --- M src/soc/amd/common/block/graphics/graphics.c 1 file changed, 30 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/79/74779/1 diff --git a/src/soc/amd/common/block/graphics/graphics.c b/src/soc/amd/common/block/graphics/graphics.c index cc52053..abc5eee 100644 --- a/src/soc/amd/common/block/graphics/graphics.c +++ b/src/soc/amd/common/block/graphics/graphics.c @@ -157,11 +157,21 @@ return; } rom = pci_rom_probe(dev); - if (rom == NULL) + if (rom == NULL) { + printk(BIOS_ERR, "%s: Unable to find ROM for %s\n", + __func__, dev_path(dev)); + timestamp_add_now(TS_OPROM_COPY_END); return; + } + ram = pci_rom_load(dev, rom); - if (ram == NULL) - return; + if (ram == NULL) { + printk(BIOS_ERR, "%s: Unable to load ROM for %s\n", + __func__, dev_path(dev)); + } + + pci_rom_free(rom); + timestamp_add_now(TS_OPROM_COPY_END); } -- To view, visit https://review.coreboot.org/c/coreboot/+/74779 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie6fbbfd36f0974551befef4d08423a8148e151e7 Gerrit-Change-Number: 74779 Gerrit-PatchSet: 1 Gerrit-Owner: Grzegorz Bernacki Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-MessageType: newchange

1 0

[S] Change in coreboot[master]: device/pci_rom: Add simple pci_rom_free()
by Grzegorz Bernacki (Code Review) 26 Apr '23

26 Apr '23

Grzegorz Bernacki has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/74778 ) Change subject: device/pci_rom: Add simple pci_rom_free() ...................................................................... device/pci_rom: Add simple pci_rom_free() It adds simple function, which frees the memory which could be allocated by pci_rom_probe(). In the next step it will be modified to free only memory, which was mapped from CBFS. BUG=278264488 TEST=Build and run with additional debug prints added to confirm that data are correctly unmapped Change-Id: Ibc9aad34b6bf101a3a0c06b92ed2dc6f2d7b9b33 Signed-off-by: Grzegorz Bernacki <bernacki(a)google.com> --- M src/device/pci_rom.c M src/include/device/pci_rom.h 2 files changed, 25 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/78/74778/1 diff --git a/src/device/pci_rom.c b/src/device/pci_rom.c index a454c9e..4d9a53e 100644 --- a/src/device/pci_rom.c +++ b/src/device/pci_rom.c @@ -49,6 +49,11 @@ return cbfs_map(name, NULL); } +void pci_rom_free(struct rom_header *rom_header) +{ + cbfs_unmap(rom_header); +} + struct rom_header *pci_rom_probe(const struct device *dev) { struct rom_header *rom_header = NULL; diff --git a/src/include/device/pci_rom.h b/src/include/device/pci_rom.h index 83015a1..47b1a50 100644 --- a/src/include/device/pci_rom.h +++ b/src/include/device/pci_rom.h @@ -41,6 +41,7 @@ struct rom_header *pci_rom_probe(const struct device *dev); struct rom_header *pci_rom_load(struct device *dev, struct rom_header *rom_header); +void pci_rom_free(struct rom_header *rom_header); unsigned long pci_rom_write_acpi_tables(const struct device *device, -- To view, visit https://review.coreboot.org/c/coreboot/+/74778 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibc9aad34b6bf101a3a0c06b92ed2dc6f2d7b9b33 Gerrit-Change-Number: 74778 Gerrit-PatchSet: 1 Gerrit-Owner: Grzegorz Bernacki Gerrit-MessageType: newchange

1 0

[S] Change in coreboot[master]: soc/amd/common/block/cpu: Add missing cbfs_unmap()
by Grzegorz Bernacki (Code Review) 26 Apr '23

26 Apr '23

Grzegorz Bernacki has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/74777 ) Change subject: soc/amd/common/block/cpu: Add missing cbfs_unmap() ...................................................................... soc/amd/common/block/cpu: Add missing cbfs_unmap() cbfs_map() can allocate memory, so cbfs_unmap() should be called before leaving the function. BUG=278264488 TEST=Build and run with additional debug prints added to confirm that data are correctly unmapped Change-Id: I200d24df6157cc6d06bade34809faefea9f0090a Signed-off-by: Grzegorz Bernacki <bernacki(a)google.com> --- M src/soc/amd/common/block/cpu/update_microcode.c 1 file changed, 34 insertions(+), 10 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/77/74777/1 diff --git a/src/soc/amd/common/block/cpu/update_microcode.c b/src/soc/amd/common/block/cpu/update_microcode.c index 0edb9d2..d3d7993 100644 --- a/src/soc/amd/common/block/cpu/update_microcode.c +++ b/src/soc/amd/common/block/cpu/update_microcode.c @@ -1,5 +1,6 @@ /* SPDX-License-Identifier: GPL-2.0-only */ +#include <amdblocks/cpu.h> #include <cbfs.h> #include <commonlib/helpers.h> #include <console/console.h> @@ -75,37 +76,43 @@ void amd_update_microcode_from_cbfs(void) { - static const struct microcode *ucode_cache; - static bool cache_valid; + static const struct microcode *ucode; + static int cpus_updated; - struct microcode *ucode; char name[] = CPU_MICROCODE_BLOB_NAME; uint16_t equivalent_processor_rev_id; /* Cache the buffer so each CPU doesn't need to read the uCode from flash */ /* Note that this code assumes all cores are the same */ - if (!cache_valid) { + if (!ucode) { timestamp_add_now(TS_READ_UCODE_START); equivalent_processor_rev_id = get_equivalent_processor_rev_id(); snprintf(name, sizeof(name), CPU_MICROCODE_BLOB_FORMAT, equivalent_processor_rev_id); + ucode = cbfs_map(name, NULL); if (!ucode) { printk(BIOS_WARNING, "%s not found. Skipping updates.\n", name); + timestamp_add_now(TS_READ_UCODE_END); return; } - ucode_cache = find_microcode(ucode, equivalent_processor_rev_id); - - if (!ucode_cache) { - cbfs_unmap(ucode); + if (find_microcode(ucode, equivalent_processor_rev_id) == NULL) { + cbfs_unmap((void *)ucode); + ucode = NULL; + timestamp_add_now(TS_READ_UCODE_END); return; } - cache_valid = true; timestamp_add_now(TS_READ_UCODE_END); } - apply_microcode_patch(ucode_cache); + apply_microcode_patch(ucode); + cpus_updated++; + + if (cpus_updated >= get_cpu_count()) { + cbfs_unmap((void *)ucode); + ucode = NULL; + } } void preload_microcode(void) -- To view, visit https://review.coreboot.org/c/coreboot/+/74777 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I200d24df6157cc6d06bade34809faefea9f0090a Gerrit-Change-Number: 74777 Gerrit-PatchSet: 1 Gerrit-Owner: Grzegorz Bernacki Gerrit-MessageType: newchange

1 0

[M] Change in coreboot[master]: acpi/acpi.c: Reduce scope of some functions
by Lean Sheng Tan (Code Review) 26 Apr '23

26 Apr '23

Lean Sheng Tan has submitted this change. ( https://review.coreboot.org/c/coreboot/+/74756 ) Change subject: acpi/acpi.c: Reduce scope of some functions ...................................................................... acpi/acpi.c: Reduce scope of some functions These functions are only used in one compilation unit. Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> Change-Id: I6f8282f308506a68b14ce3101f11078cb13709f2 Reviewed-on: https://review.coreboot.org/c/coreboot/+/74756 Reviewed-by: Jan Samek <jan.samek(a)siemens.com> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Maximilian Brune <maximilian.brune(a)9elements.com> Reviewed-by: Tim Wawrzynczak <inforichland(a)gmail.com> Reviewed-by: Elyes Haouas <ehaouas(a)noos.fr> Reviewed-by: Lean Sheng Tan <sheng.tan(a)9elements.com> Reviewed-by: Subrata Banik <subratabanik(a)google.com> --- M src/acpi/acpi.c M src/include/acpi/acpi.h 2 files changed, 29 insertions(+), 25 deletions(-) Approvals: build bot (Jenkins): Verified Elyes Haouas: Looks good to me, approved Lean Sheng Tan: Looks good to me, approved Tim Wawrzynczak: Looks good to me, approved Jan Samek: Looks good to me, but someone else must approve Subrata Banik: Looks good to me, approved Maximilian Brune: Looks good to me, but someone else must approve diff --git a/src/acpi/acpi.c b/src/acpi/acpi.c index fb9a758..2540929 100644 --- a/src/acpi/acpi.c +++ b/src/acpi/acpi.c @@ -288,7 +288,7 @@ return current; } -void acpi_create_madt(acpi_madt_t *madt) +static void acpi_create_madt(acpi_madt_t *madt) { acpi_header_t *header = &(madt->header); unsigned long current = (unsigned long)madt + sizeof(acpi_madt_t); @@ -333,7 +333,7 @@ } /* MCFG is defined in the PCI Firmware Specification 3.0. */ -void acpi_create_mcfg(acpi_mcfg_t *mcfg) +static void acpi_create_mcfg(acpi_mcfg_t *mcfg) { acpi_header_t *header = &(mcfg->header); unsigned long current = (unsigned long)mcfg + sizeof(acpi_mcfg_t); @@ -517,7 +517,7 @@ acpigen_pop_len(); } -void acpi_create_ssdt_generator(acpi_header_t *ssdt, const char *oem_table_id) +static void acpi_create_ssdt_generator(acpi_header_t *ssdt, const char *oem_table_id) { unsigned long current = (unsigned long)ssdt + sizeof(acpi_header_t); @@ -989,7 +989,7 @@ } /* http://www.intel.com/hardwaredesign/hpetspec_1.pdf */ -void acpi_create_hpet(acpi_hpet_t *hpet) +static void acpi_create_hpet(acpi_hpet_t *hpet) { acpi_header_t *header = &(hpet->header); acpi_addr_t *addr = &(hpet->addr); @@ -1330,7 +1330,7 @@ return current; } -void acpi_create_dbg2(acpi_dbg2_header_t *dbg2, +static void acpi_create_dbg2(acpi_dbg2_header_t *dbg2, int port_type, int port_subtype, acpi_addr_t *address, uint32_t address_size, const char *device_path) @@ -1451,7 +1451,7 @@ return current; } -void acpi_create_facs(acpi_facs_t *facs) +static void acpi_create_facs(acpi_facs_t *facs) { memset((void *)facs, 0, sizeof(acpi_facs_t)); @@ -1628,7 +1628,7 @@ } /* ACPI 3.0b */ -void acpi_write_bert(acpi_bert_t *bert, uintptr_t region, size_t length) +static void acpi_write_bert(acpi_bert_t *bert, uintptr_t region, size_t length) { acpi_header_t *header = &(bert->header); @@ -1656,7 +1656,7 @@ __weak void soc_fill_fadt(acpi_fadt_t *fadt) { } __weak void mainboard_fill_fadt(acpi_fadt_t *fadt) { } -void acpi_create_fadt(acpi_fadt_t *fadt, acpi_facs_t *facs, void *dsdt) +static void acpi_create_fadt(acpi_fadt_t *fadt, acpi_facs_t *facs, void *dsdt) { acpi_header_t *header = &(fadt->header); @@ -1709,7 +1709,7 @@ acpi_checksum((void *)fadt, header->length); } -void acpi_create_lpit(acpi_lpit_t *lpit) +static void acpi_create_lpit(acpi_lpit_t *lpit) { acpi_header_t *header = &(lpit->header); unsigned long current = (unsigned long)lpit + sizeof(acpi_lpit_t); diff --git a/src/include/acpi/acpi.h b/src/include/acpi/acpi.h index 77f73ae..58db58c 100644 --- a/src/include/acpi/acpi.h +++ b/src/include/acpi/acpi.h @@ -1308,9 +1308,6 @@ unsigned long write_acpi_tables(unsigned long addr); unsigned long acpi_fill_madt(unsigned long current); unsigned long acpi_fill_ivrs_ioapic(acpi_ivrs_t *ivrs, unsigned long current); -void acpi_create_ssdt_generator(acpi_header_t *ssdt, const char *oem_table_id); -void acpi_write_bert(acpi_bert_t *bert, uintptr_t region, size_t length); -void acpi_create_fadt(acpi_fadt_t *fadt, acpi_facs_t *facs, void *dsdt); void acpi_fill_fadt(acpi_fadt_t *fadt); void arch_fill_fadt(acpi_fadt_t *fadt); @@ -1342,8 +1339,6 @@ int acpi_create_madt_irqoverride(acpi_madt_irqoverride_t *irqoverride, u8 bus, u8 source, u32 gsirq, u16 flags); -void acpi_create_madt(acpi_madt_t *madt); - unsigned long acpi_create_madt_one_lapic(unsigned long current, u32 cpu, u32 apic); unsigned long acpi_create_madt_lapics_with_nmis(unsigned long current); @@ -1401,22 +1396,12 @@ unsigned long (*acpi_fill_crat)(struct acpi_crat_header *crat_struct, unsigned long current)); -void acpi_create_hpet(acpi_hpet_t *hpet); unsigned long acpi_write_hpet(const struct device *device, unsigned long start, acpi_rsdp_t *rsdp); /* cpu/intel/speedstep/acpi.c */ void generate_cpu_entries(const struct device *device); -void acpi_create_mcfg(acpi_mcfg_t *mcfg); - -void acpi_create_facs(acpi_facs_t *facs); - -void acpi_create_dbg2(acpi_dbg2_header_t *dbg2_header, - int port_type, int port_subtype, - acpi_addr_t *address, uint32_t address_size, - const char *device_path); - unsigned long acpi_write_dbg2_pci_uart(acpi_rsdp_t *rsdp, unsigned long current, const struct device *dev, uint8_t access_size); void acpi_create_dmar(acpi_dmar_t *dmar, enum dmar_flags flags, @@ -1455,7 +1440,6 @@ unsigned long acpi_create_hest_error_source(acpi_hest_t *hest, acpi_hest_esd_t *esd, u16 type, void *data, u16 len); -void acpi_create_lpit(acpi_lpit_t *lpit); unsigned long acpi_create_lpi_desc_ncst(acpi_lpi_desc_ncst_t *lpi_desc, uint16_t uid); /* chipsets that select ACPI_BERT must implement this function */ -- To view, visit https://review.coreboot.org/c/coreboot/+/74756 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6f8282f308506a68b14ce3101f11078cb13709f2 Gerrit-Change-Number: 74756 Gerrit-PatchSet: 2 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Jan Samek <jan.samek(a)siemens.com> Gerrit-Reviewer: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[S] Change in coreboot[master]: acpi/acpi.c: Reduce scope of some functions
by Lean Sheng Tan (Code Review) 26 Apr '23

26 Apr '23

Attention is currently required from: Lance Zhao, Martin L Roth, Arthur Heymans, Werner Zeh. Lean Sheng Tan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74756 ) Change subject: acpi/acpi.c: Reduce scope of some functions ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: merge this in earlier as it has >3 +2 and a simple fix. -- To view, visit https://review.coreboot.org/c/coreboot/+/74756 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6f8282f308506a68b14ce3101f11078cb13709f2 Gerrit-Change-Number: 74756 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Jan Samek <jan.samek(a)siemens.com> Gerrit-Reviewer: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Comment-Date: Wed, 26 Apr 2023 08:40:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit April 2023