Attention is currently required from: Jason Glenesk, Raul Rangel, Jakub Czapiga, Matt DeVillier, Paul Menzel, Grzegorz Bernacki, Fred Reitberger, Karthik Ramasubramanian, Felix Held.
Himanshu Sahdev has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74269 )
Change subject: soc/amd/mendocino: Print content of manifest file
......................................................................
Patch Set 4:
(1 comment)
File src/soc/amd/mendocino/manifest.c:
https://review.coreboot.org/c/coreboot/+/74269/comment/13fe2636_afe5a410
PS4, Line 14: return;
printk(BIOS_ERR, "Failed to get amdfw_manifest\n");
before return?
--
To view, visit https://review.coreboot.org/c/coreboot/+/74269
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8df54b74cd987b4a3be635932d38ea178d0b0311
Gerrit-Change-Number: 74269
Gerrit-PatchSet: 4
Gerrit-Owner: Grzegorz Bernacki
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Reviewer: Jakub Czapiga <jacz(a)semihalf.com>
Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com>
Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Himanshu Sahdev <himanshu.sahdev(a)intel.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Attention: Jakub Czapiga <jacz(a)semihalf.com>
Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Grzegorz Bernacki
Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Comment-Date: Wed, 26 Apr 2023 10:50:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Konrad Adamczyk, Jason Glenesk, Raul Rangel, Jakub Czapiga, Matt DeVillier, Paul Menzel, Arthur Heymans, Tim Van Patten, Fred Reitberger, Karthik Ramasubramanian, Felix Held.
Grzegorz Bernacki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74777 )
Change subject: soc/amd/common/block/cpu: Add missing cbfs_unmap()
......................................................................
Patch Set 1:
(1 comment)
File src/soc/amd/common/block/cpu/update_microcode.c:
https://review.coreboot.org/c/coreboot/+/74777/comment/cd6e5bf9_fe0414e7
PS1, Line 110: c
> Updating microcode happens in parallel if I recall correctly. […]
Yes, you're right. I will wait a while for other comments and send new patch with atomic_t.
--
To view, visit https://review.coreboot.org/c/coreboot/+/74777
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I200d24df6157cc6d06bade34809faefea9f0090a
Gerrit-Change-Number: 74777
Gerrit-PatchSet: 1
Gerrit-Owner: Grzegorz Bernacki
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Reviewer: Jakub Czapiga <jacz(a)semihalf.com>
Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Konrad Adamczyk <konrada(a)google.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Reviewer: Tim Van Patten <timvp(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Konrad Adamczyk <konrada(a)google.com>
Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Attention: Jakub Czapiga <jacz(a)semihalf.com>
Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Attention: Tim Van Patten <timvp(a)google.com>
Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Comment-Date: Wed, 26 Apr 2023 10:45:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-MessageType: comment
Attention is currently required from: Jason Nien, Matt DeVillier, Martin Roth.
Hello build bot (Jenkins), Jason Nien, Matt DeVillier, Martin Roth,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/74759
to look at the new patch set (#5).
Change subject: mb/google/skyrim/var/winterhold: adjust eDP panel power sequence
......................................................................
mb/google/skyrim/var/winterhold: adjust eDP panel power sequence
1. Set edp_panel_t8_ms to 112ms
2. Set edp_panel_t9_ms to 8ms
BUG=b:271704149
BRANCH=none
TEST=Build; Verify the UPD was passed to system integrated table.
Signed-off-by: Chris Wang <chris.wang(a)amd.corp-partner.google.com>
Change-Id: Ifefd47a86e53d574098ae2e5bd2f41ae79353385
---
M src/mainboard/google/skyrim/variants/winterhold/overridetree.cb
1 file changed, 19 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/59/74759/5
--
To view, visit https://review.coreboot.org/c/coreboot/+/74759
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ifefd47a86e53d574098ae2e5bd2f41ae79353385
Gerrit-Change-Number: 74759
Gerrit-PatchSet: 5
Gerrit-Owner: Chris Wang <chris.wang(a)amd.corp-partner.google.com>
Gerrit-Reviewer: Jason Nien <jason.nien(a)amd.corp-partner.google.com>
Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Jason Nien <jason.nien(a)amd.corp-partner.google.com>
Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com>
Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Jason Glenesk, Raul Rangel, Chris Wang, Fred Reitberger, Felix Held.
Hello build bot (Jenkins), Jason Glenesk, Raul Rangel, Matt DeVillier, Fred Reitberger, Felix Held,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/74757
to look at the new patch set (#3).
Change subject: soc/amd/mendocino: update FSP parameters for eDP power sequence adjustment
......................................................................
soc/amd/mendocino: update FSP parameters for eDP power sequence adjustment
Update UPD structure to align with MDN-FSP. Also, rename the UDP name to
match the eDP sequence timing in ms.
1. Set edp_panel_t8_ms for varybl to blon.
2. Set edp_panel_t9_ms for bloff to varybloff.
BUG=b:271704149
BRANCH=none
Test=Build/Boot to ChromeOS
Signed-off-by: Chris Wang <chris.wang(a)amd.corp-partner.google.com>
Change-Id: Id410c40a65c0fd4b9b73cf36dc1f08eba0a3e44c
---
M src/soc/amd/mendocino/chip.h
M src/soc/amd/mendocino/fsp_m_params.c
M src/vendorcode/amd/fsp/mendocino/FspmUpd.h
3 files changed, 29 insertions(+), 6 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/57/74757/3
--
To view, visit https://review.coreboot.org/c/coreboot/+/74757
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id410c40a65c0fd4b9b73cf36dc1f08eba0a3e44c
Gerrit-Change-Number: 74757
Gerrit-PatchSet: 3
Gerrit-Owner: Chris Wang <chris.wang(a)amd.corp-partner.google.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com>
Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Attention: Chris Wang <chris.wang(a)amd.corp-partner.google.com>
Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-MessageType: newpatchset
Attention is currently required from: Kapil Porwal.
Himanshu Sahdev has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74765 )
Change subject: soc/intel/cmn/block/cse: Support sending EOP from payload
......................................................................
Patch Set 2:
(1 comment)
File src/soc/intel/common/block/cse/cse.c:
https://review.coreboot.org/c/coreboot/+/74765/comment/04d00650_4d75903c
PS2, Line 1429: two
Update comment to have 3rd option for EOP by payload.
--
To view, visit https://review.coreboot.org/c/coreboot/+/74765
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0fbb9fd0f8522eefad39960ca3167c2ba764f523
Gerrit-Change-Number: 74765
Gerrit-PatchSet: 2
Gerrit-Owner: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Himanshu Sahdev <himanshu.sahdev(a)intel.com>
Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Comment-Date: Wed, 26 Apr 2023 10:35:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Subrata Banik, Dinesh Gehlot, Lean Sheng Tan.
Sean Rhodes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74511 )
Change subject: soc/intel/common: Make ramtop offset configurable
......................................................................
Patch Set 7:
(1 comment)
File src/soc/intel/common/basecode/ramtop/ramtop.c:
https://review.coreboot.org/c/coreboot/+/74511/comment/5220e05b_57203593
PS6, Line 28: RAMTOP_CMOS_OFFSET
> I think we can remove constant RAMTOP_CMOS_OFFSET since it is not used anywhere else in the code.
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/74511
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5327b5d4e78b715a85072e5d9a62cf8fd2ae92c0
Gerrit-Change-Number: 74511
Gerrit-PatchSet: 7
Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com>
Gerrit-Comment-Date: Wed, 26 Apr 2023 10:32:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-MessageType: comment
Attention is currently required from: Sean Rhodes, Subrata Banik, Lean Sheng Tan.
Dinesh Gehlot has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74511 )
Change subject: soc/intel/common: Make ramtop offset configurable
......................................................................
Patch Set 6:
(1 comment)
File src/soc/intel/common/basecode/ramtop/ramtop.c:
https://review.coreboot.org/c/coreboot/+/74511/comment/ef3088e1_46371c23
PS6, Line 28: RAMTOP_CMOS_OFFSET
I think we can remove constant RAMTOP_CMOS_OFFSET since it is not used anywhere else in the code.
--
To view, visit https://review.coreboot.org/c/coreboot/+/74511
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5327b5d4e78b715a85072e5d9a62cf8fd2ae92c0
Gerrit-Change-Number: 74511
Gerrit-PatchSet: 6
Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com>
Gerrit-Comment-Date: Wed, 26 Apr 2023 10:32:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Lance Zhao, Nico Huber, Tim Wawrzynczak, Maximilian Brune, Arthur Heymans, Werner Zeh.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74762 )
Change subject: acpi: Add a runtime method to override exposed _Sx sleep states
......................................................................
Patch Set 8:
(1 comment)
File src/acpi/Kconfig:
https://review.coreboot.org/c/coreboot/+/74762/comment/2e132f0f_b9bb9f1a
PS4, Line 65: config OVERRIDE_ENABLED_SLEEP_STATES
> > Sorry, I meant “always allowing it”. […]
I see. Thank you.
--
To view, visit https://review.coreboot.org/c/coreboot/+/74762
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic21830c1ef9c183b1e3005cc1f8b7daf7e9ea998
Gerrit-Change-Number: 74762
Gerrit-PatchSet: 8
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Jan Samek <jan.samek(a)siemens.com>
Gerrit-Reviewer: Lance Zhao <lance.zhao(a)gmail.com>
Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com>
Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com>
Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Lance Zhao <lance.zhao(a)gmail.com>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com>
Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Attention: Werner Zeh <werner.zeh(a)siemens.com>
Gerrit-Comment-Date: Wed, 26 Apr 2023 10:08:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>
Comment-In-Reply-To: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-MessageType: comment
Attention is currently required from: Arthur Heymans, Lean Sheng Tan, Werner Zeh, Jan Samek.
Mario Scheithauer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74433 )
Change subject: drivers/i2c: Add PI7C9X2G608GP PCIe switch driver (pi608gp)
......................................................................
Patch Set 14: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/74433
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id191c4e97b99da58efd3ba38bf8cca3603ece4d5
Gerrit-Change-Number: 74433
Gerrit-PatchSet: 14
Gerrit-Owner: Jan Samek <jan.samek(a)siemens.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com>
Gerrit-Reviewer: Mario Scheithauer <mario.scheithauer(a)siemens.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com>
Gerrit-Attention: Werner Zeh <werner.zeh(a)siemens.com>
Gerrit-Attention: Jan Samek <jan.samek(a)siemens.com>
Gerrit-Comment-Date: Wed, 26 Apr 2023 10:02:30 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment