coreboot-gerrit February 2023

coreboot-gerrit@coreboot.org

1 participants
5082 discussions

[M] Change in coreboot[master]: treewide: Remove unuseful "_HID: Hardware ID" comment
by Elyes Haouas (Code Review) 02 Feb '23

02 Feb '23

Attention is currently required from: Tim Crawford, Sean Rhodes, Jeremy Soller, Nick Vaccaro, Felix Held. Elyes Haouas has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/72661 ) Change subject: treewide: Remove unuseful "_HID: Hardware ID" comment ...................................................................... Patch Set 1: (1 comment) File src/mainboard/intel/kblrvp/acpi/mipi_camera.asl: https://review.coreboot.org/c/coreboot/+/72661/comment/77427f05_112207d3 PS1, Line 8: */ mixed comment style -- To view, visit https://review.coreboot.org/c/coreboot/+/72661 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5eb1424e9e6c1fbf20cd0bf68fbb52e1ec97f905 Gerrit-Change-Number: 72661 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Jeremy Soller <jeremy(a)system76.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Tim Crawford <tcrawford(a)system76.com> Gerrit-Attention: Tim Crawford <tcrawford(a)system76.com> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Attention: Jeremy Soller <jeremy(a)system76.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Thu, 02 Feb 2023 10:55:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[XL] Change in coreboot[master]: soc/intel/xeon_sp: Rename nb_acpi.c and add SPR-SP support
by build bot (Jenkins) (Code Review) 02 Feb '23

02 Feb '23

Attention is currently required from: Patrick Rudolph, Simon Chou, TimLiu-SMCI, Jonathan Zhang, Christian Walter, Angel Pons, Arthur Heymans, Jian-Ming Wang, Tim Chu, Shelly Chang. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71958 ) Change subject: soc/intel/xeon_sp: Rename nb_acpi.c and add SPR-SP support ...................................................................... Patch Set 8: (1 comment) File src/soc/intel/xeon_sp/uncore_acpi.c: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169716): https://review.coreboot.org/c/coreboot/+/71958/comment/084dbb53_609dc321 PS8, Line 527: if (pciexp_find_extended_cap(dev, PCIE_EXT_CAP_ID_ATS, 0)) { Too many leading tabs - consider code refactoring -- To view, visit https://review.coreboot.org/c/coreboot/+/71958 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4c436a60743bee21b3b6e4060d7874a6cdc75ecf Gerrit-Change-Number: 71958 Gerrit-PatchSet: 8 Gerrit-Owner: Simon Chou <simonchou(a)supermicro.com.tw> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Jian-Ming Wang <jianmingW(a)supermicro.com> Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Shelly Chang <Shelly_Chang(a)wiwynn.com> Gerrit-Reviewer: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Reviewer: TimLiu-SMCI <timliu(a)supermicro.com.tw> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Simon Chou <simonchou(a)supermicro.com.tw> Gerrit-Attention: TimLiu-SMCI <timliu(a)supermicro.com.tw> Gerrit-Attention: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Jian-Ming Wang <jianmingW(a)supermicro.com> Gerrit-Attention: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Attention: Shelly Chang <Shelly_Chang(a)wiwynn.com> Gerrit-Comment-Date: Thu, 02 Feb 2023 10:15:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[XL] Change in coreboot[master]: soc/intel/xeon_sp: Rename nb_acpi.c and add SPR-SP support
by Johnny Lin (Code Review) 02 Feb '23

02 Feb '23

Attention is currently required from: Patrick Rudolph, Simon Chou, TimLiu-SMCI, Jonathan Zhang, Christian Walter, Angel Pons, Arthur Heymans, Jian-Ming Wang, Tim Chu, Shelly Chang. Johnny Lin has uploaded a new patch set (#8) to the change originally created by Simon Chou. ( https://review.coreboot.org/c/coreboot/+/71958 ) Change subject: soc/intel/xeon_sp: Rename nb_acpi.c and add SPR-SP support ...................................................................... soc/intel/xeon_sp: Rename nb_acpi.c and add SPR-SP support Add support for Intel SPR-SP to nb_acpi.c and rename to uncore_acpi.c. Signed-off-by: Tim Chu <Tim.Chu(a)quantatw.com> Signed-off-by: Johnny Lin <johnny_lin(a)wiwynn.com> Signed-off-by: Shelly Chang <Shelly_Chang(a)wiwynn.com> Change-Id: I4c436a60743bee21b3b6e4060d7874a6cdc75ecf --- M src/soc/intel/xeon_sp/Makefile.inc M src/soc/intel/xeon_sp/include/soc/acpi.h D src/soc/intel/xeon_sp/nb_acpi.c A src/soc/intel/xeon_sp/uncore_acpi.c M src/vendorcode/intel/fsp/fsp2_0/cooperlake_sp/hob_iiouds.h M src/vendorcode/intel/fsp/fsp2_0/skylake_sp/FspmUpd.h 6 files changed, 673 insertions(+), 455 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/58/71958/8 -- To view, visit https://review.coreboot.org/c/coreboot/+/71958 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4c436a60743bee21b3b6e4060d7874a6cdc75ecf Gerrit-Change-Number: 71958 Gerrit-PatchSet: 8 Gerrit-Owner: Simon Chou <simonchou(a)supermicro.com.tw> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Jian-Ming Wang <jianmingW(a)supermicro.com> Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Shelly Chang <Shelly_Chang(a)wiwynn.com> Gerrit-Reviewer: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Reviewer: TimLiu-SMCI <timliu(a)supermicro.com.tw> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Simon Chou <simonchou(a)supermicro.com.tw> Gerrit-Attention: TimLiu-SMCI <timliu(a)supermicro.com.tw> Gerrit-Attention: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Jian-Ming Wang <jianmingW(a)supermicro.com> Gerrit-Attention: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Attention: Shelly Chang <Shelly_Chang(a)wiwynn.com> Gerrit-MessageType: newpatchset

1 0

[M] Change in coreboot[master]: security/tpm/tss/tcg-2.0: Add `tlcl_read_public()`
by Yi Chou (Code Review) 02 Feb '23

02 Feb '23

Attention is currently required from: Andrey Pronin, Christian Walter. Yi Chou has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71885 ) Change subject: security/tpm/tss/tcg-2.0: Add `tlcl_read_public()` ...................................................................... Patch Set 2: (1 comment) File src/security/tpm/tss/tcg-2.0/tss_structures.h: https://review.coreboot.org/c/coreboot/+/71885/comment/3c2d1516_6d83f28c PS2, Line 149: RC_VER1 `RC_FMT1` -- To view, visit https://review.coreboot.org/c/coreboot/+/71885 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I79455b3ee73c265a9e4bf3d8b9c6562490efbf1c Gerrit-Change-Number: 71885 Gerrit-PatchSet: 2 Gerrit-Owner: Yi Chou <yich(a)google.com> Gerrit-Reviewer: Andrey Pronin <apronin(a)google.com> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Andrey Pronin <apronin(a)google.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Comment-Date: Thu, 02 Feb 2023 10:13:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: soc/intel/xeon_sp/chip_common.c: Probe all buses in attach_iio_stacks()
by Johnny Lin (Code Review) 02 Feb '23

02 Feb '23

Attention is currently required from: Jonathan Zhang, Simon Chou, TimLiu-SMCI, Paul Menzel, Christian Walter, Jian-Ming Wang, Arthur Heymans. Johnny Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71965 ) Change subject: soc/intel/xeon_sp/chip_common.c: Probe all buses in attach_iio_stacks() ...................................................................... Patch Set 11: (1 comment) File src/soc/intel/xeon_sp/chip_common.c: https://review.coreboot.org/c/coreboot/+/71965/comment/dec77f23_12ff0bac PS2, Line 519: max_subordinate > Done Unresolved this comment until CB:59395 is merged, in case it's merged w/o it. -- To view, visit https://review.coreboot.org/c/coreboot/+/71965 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ica3c61493a0ff6c699b500f30788b2cf5a06c250 Gerrit-Change-Number: 71965 Gerrit-PatchSet: 11 Gerrit-Owner: Simon Chou <simonchou(a)supermicro.com.tw> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Jian-Ming Wang <jianmingW(a)supermicro.com> Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Reviewer: TimLiu-SMCI <timliu(a)supermicro.com.tw> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Attention: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Attention: Simon Chou <simonchou(a)supermicro.com.tw> Gerrit-Attention: TimLiu-SMCI <timliu(a)supermicro.com.tw> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Jian-Ming Wang <jianmingW(a)supermicro.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Thu, 02 Feb 2023 10:08:44 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Jonathan Zhang <jonzhang(a)fb.com> Comment-In-Reply-To: Johnny Lin <Johnny_Lin(a)wiwynn.com> Comment-In-Reply-To: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: soc/intel/xeon_sp/chip_common.c: Probe all buses in attach_iio_stacks()
by Johnny Lin (Code Review) 02 Feb '23

02 Feb '23

Attention is currently required from: Jonathan Zhang, Simon Chou, TimLiu-SMCI, Paul Menzel, Christian Walter, Jian-Ming Wang, Arthur Heymans. Johnny Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71965 ) Change subject: soc/intel/xeon_sp/chip_common.c: Probe all buses in attach_iio_stacks() ...................................................................... Patch Set 11: (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/71965/comment/ea7bda75_fffeb135 PS10, Line 7: Update attach_iio_stacks() > This is too broad. Please be more specific. Done https://review.coreboot.org/c/coreboot/+/71965/comment/bc939866_c07649e0 PS10, Line 7: soc/intel/xeon_sp/chip_common.c: Update attach_iio_stacks() > How about "Probe all buses in attach_iio_stacks()"? Done -- To view, visit https://review.coreboot.org/c/coreboot/+/71965 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ica3c61493a0ff6c699b500f30788b2cf5a06c250 Gerrit-Change-Number: 71965 Gerrit-PatchSet: 11 Gerrit-Owner: Simon Chou <simonchou(a)supermicro.com.tw> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Jian-Ming Wang <jianmingW(a)supermicro.com> Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Reviewer: TimLiu-SMCI <timliu(a)supermicro.com.tw> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Attention: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Attention: Simon Chou <simonchou(a)supermicro.com.tw> Gerrit-Attention: TimLiu-SMCI <timliu(a)supermicro.com.tw> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Jian-Ming Wang <jianmingW(a)supermicro.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Thu, 02 Feb 2023 10:04:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Jonathan Zhang <jonzhang(a)fb.com> Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: soc/intel/xeon_sp/chip_common.c: Probe all buses in attach_iio_stacks()
by Johnny Lin (Code Review) 02 Feb '23

02 Feb '23

Attention is currently required from: TimLiu-SMCI, Johnny Lin, Christian Walter, Jian-Ming Wang, Arthur Heymans. Johnny Lin has uploaded a new patch set (#11) to the change originally created by Simon Chou. ( https://review.coreboot.org/c/coreboot/+/71965 ) Change subject: soc/intel/xeon_sp/chip_common.c: Probe all buses in attach_iio_stacks() ...................................................................... soc/intel/xeon_sp/chip_common.c: Probe all buses in attach_iio_stacks() For some Xeon-SP (such as SPR-SP), more buses should be probed. Signed-off-by: Jonathan Zhang <jonzhang(a)meta.com> Signed-off-by: Johnny Lin <johnny_lin(a)wiwynn.com> Change-Id: Ica3c61493a0ff6c699b500f30788b2cf5a06c250 --- M src/soc/intel/xeon_sp/chip_common.c 1 file changed, 57 insertions(+), 26 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/65/71965/11 -- To view, visit https://review.coreboot.org/c/coreboot/+/71965 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ica3c61493a0ff6c699b500f30788b2cf5a06c250 Gerrit-Change-Number: 71965 Gerrit-PatchSet: 11 Gerrit-Owner: Simon Chou <simonchou(a)supermicro.com.tw> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Jian-Ming Wang <jianmingW(a)supermicro.com> Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Reviewer: TimLiu-SMCI <timliu(a)supermicro.com.tw> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Attention: TimLiu-SMCI <timliu(a)supermicro.com.tw> Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Jian-Ming Wang <jianmingW(a)supermicro.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: soc/intel/xeon_sp/Makefile.inc: Update makefile for spr
by Johnny Lin (Code Review) 02 Feb '23

02 Feb '23

Attention is currently required from: Simon Chou, TimLiu-SMCI, Paul Menzel, Christian Walter, Jian-Ming Wang, Arthur Heymans. Johnny Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71959 ) Change subject: soc/intel/xeon_sp/Makefile.inc: Update makefile for spr ...................................................................... Patch Set 7: (1 comment) File src/soc/intel/xeon_sp/Makefile.inc: https://review.coreboot.org/c/coreboot/+/71959/comment/558859e6_9722dd66 PS4, Line 19: uncore_acpi > Unified and renamed to uncore_acpi. […] Sorry I mean CB:71958 -- To view, visit https://review.coreboot.org/c/coreboot/+/71959 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9429fe332bb5f01a41aa205c76ad9f0159f93eee Gerrit-Change-Number: 71959 Gerrit-PatchSet: 7 Gerrit-Owner: Simon Chou <simonchou(a)supermicro.com.tw> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Jian-Ming Wang <jianmingW(a)supermicro.com> Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Reviewer: TimLiu-SMCI <timliu(a)supermicro.com.tw> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Attention: Simon Chou <simonchou(a)supermicro.com.tw> Gerrit-Attention: TimLiu-SMCI <timliu(a)supermicro.com.tw> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Jian-Ming Wang <jianmingW(a)supermicro.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Thu, 02 Feb 2023 09:51:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Johnny Lin <Johnny_Lin(a)wiwynn.com> Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: soc/intel/xeon_sp/Makefile.inc: Update makefile for spr
by Johnny Lin (Code Review) 02 Feb '23

02 Feb '23

Attention is currently required from: Simon Chou, TimLiu-SMCI, Paul Menzel, Christian Walter, Jian-Ming Wang, Arthur Heymans. Johnny Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71959 ) Change subject: soc/intel/xeon_sp/Makefile.inc: Update makefile for spr ...................................................................... Patch Set 7: (2 comments) File src/soc/intel/xeon_sp/Makefile.inc: https://review.coreboot.org/c/coreboot/+/71959/comment/48ce4c93_18f0505b PS2, Line 19: subdi > ? Done File src/soc/intel/xeon_sp/Makefile.inc: https://review.coreboot.org/c/coreboot/+/71959/comment/3ef94500_3c55bc30 PS4, Line 19: uncore_acpi > Why is this named differently than `nb_acpi. […] Unified and renamed to uncore_acpi.c in CB:71959 -- To view, visit https://review.coreboot.org/c/coreboot/+/71959 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9429fe332bb5f01a41aa205c76ad9f0159f93eee Gerrit-Change-Number: 71959 Gerrit-PatchSet: 7 Gerrit-Owner: Simon Chou <simonchou(a)supermicro.com.tw> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Jian-Ming Wang <jianmingW(a)supermicro.com> Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Reviewer: TimLiu-SMCI <timliu(a)supermicro.com.tw> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Attention: Simon Chou <simonchou(a)supermicro.com.tw> Gerrit-Attention: TimLiu-SMCI <timliu(a)supermicro.com.tw> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Jian-Ming Wang <jianmingW(a)supermicro.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Thu, 02 Feb 2023 09:50:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Comment-In-Reply-To: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-MessageType: comment

1 0

[XL] Change in coreboot[master]: soc/intel/xeon_sp: Rename nb_acpi.c and add SPR-SP support
by Johnny Lin (Code Review) 02 Feb '23

02 Feb '23

Attention is currently required from: Simon Chou, TimLiu-SMCI, Jonathan Zhang, Christian Walter, Arthur Heymans, Jian-Ming Wang, Shelly Chang. Johnny Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71958 ) Change subject: soc/intel/xeon_sp: Rename nb_acpi.c and add SPR-SP support ...................................................................... Patch Set 7: (2 comments) Patchset: PS2: > > With newer xeon_sp processors, the concept of "north bridge" became obsolete, instead uncore shoul […] Upload patchset 7 for review. File src/soc/intel/xeon_sp/uncore_acpi.c: https://review.coreboot.org/c/coreboot/+/71958/comment/6f4847ce_4e9759b1 PS2, Line 52: static unsigned int get_srat_memory_entries(acpi_srat_mem_t *srat_mem) : { : const struct SystemMemoryMapHob *memory_map; : unsigned int mmap_index; : : memory_map = get_system_memory_map(); : assert(memory_map != NULL); : printk(BIOS_DEBUG, "memory_map: %p\n", memory_map); : : mmap_index = 0; : for (int e = 0; e < memory_map->numberEntries; ++e) { : const struct SystemMemoryMapElement *mem_element = &memory_map->Element[e]; : uint64_t addr = : (uint64_t) ((uint64_t)mem_element->BaseAddress << : MEM_ADDR_64MB_SHIFT_BITS); : uint64_t size = : (uint64_t) ((uint64_t)mem_element->ElementSize << : MEM_ADDR_64MB_SHIFT_BITS); : : printk(BIOS_DEBUG, "memory_map %d addr: 0x%llx, BaseAddress: 0x%x, size: 0x%llx, " : "ElementSize: 0x%x, type: %d, reserved: %d\n", : e, addr, mem_element->BaseAddress, size, : mem_element->ElementSize, mem_element->Type, : (mem_element->Type & MEM_TYPE_RESERVED)); : : assert(mmap_index < MAX_ACPI_MEMORY_AFFINITY_COUNT); : : /* skip reserved memory region */ : if (mem_element->Type & MEM_TYPE_RESERVED) : continue; : : /* Skip all non processor attached memory regions */ : /* In other words, skip all the types >= MemTypeCxlAccVolatileMem */ : if (mem_element->Type >= MemTypeCxlAccVolatileMem) : continue; : : /* skip if this address is already added */ : bool skip = false; : for (int idx = 0; idx < mmap_index; ++idx) { : uint64_t base_addr = ((uint64_t)srat_mem[idx].base_address_high << 32) + : srat_mem[idx].base_address_low; : if (addr == base_addr) { : skip = true; : break; : } : } : if (skip) : continue; : : srat_mem[mmap_index].type = 1; /* Memory affinity structure */ : srat_mem[mmap_index].length = sizeof(acpi_srat_mem_t); : srat_mem[mmap_index].base_address_low = (uint32_t) (addr & 0xffffffff); : srat_mem[mmap_index].base_address_high = (uint32_t) (addr >> 32); : srat_mem[mmap_index].length_low = (uint32_t) (size & 0xffffffff); : srat_mem[mmap_index].length_high = (uint32_t) (size >> 32); : srat_mem[mmap_index].proximity_domain = mem_element->SocketId; : srat_mem[mmap_index].flags = SRAT_ACPI_MEMORY_ENABLED; : if ((mem_element->Type & MEMTYPE_VOLATILE_MASK) == 0) : srat_mem[mmap_index].flags |= SRAT_ACPI_MEMORY_NONVOLATILE; : ++mmap_index; : } : : return mmap_index; : } > exactly the same as nb_acpi. […] Done -- To view, visit https://review.coreboot.org/c/coreboot/+/71958 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4c436a60743bee21b3b6e4060d7874a6cdc75ecf Gerrit-Change-Number: 71958 Gerrit-PatchSet: 7 Gerrit-Owner: Simon Chou <simonchou(a)supermicro.com.tw> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Jian-Ming Wang <jianmingW(a)supermicro.com> Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Reviewer: Shelly Chang <Shelly_Chang(a)wiwynn.com> Gerrit-Reviewer: TimLiu-SMCI <timliu(a)supermicro.com.tw> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Attention: Simon Chou <simonchou(a)supermicro.com.tw> Gerrit-Attention: TimLiu-SMCI <timliu(a)supermicro.com.tw> Gerrit-Attention: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Jian-Ming Wang <jianmingW(a)supermicro.com> Gerrit-Attention: Shelly Chang <Shelly_Chang(a)wiwynn.com> Gerrit-Comment-Date: Thu, 02 Feb 2023 09:47:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Jonathan Zhang <jonzhang(a)fb.com> Comment-In-Reply-To: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit February 2023