coreboot-gerrit February 2023

coreboot-gerrit@coreboot.org

1 participants
5082 discussions

[M] Change in coreboot[master]: treewide: Remove unuseful "_UID: Unique ID" comment
by Elyes Haouas (Code Review) 02 Feb '23

02 Feb '23

Attention is currently required from: Tim Crawford, Sean Rhodes, Jeremy Soller, Nick Vaccaro. Hello Tim Crawford, Sean Rhodes, Jeremy Soller, Nick Vaccaro, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/72663 to look at the new patch set (#2). Change subject: treewide: Remove unuseful "_UID: Unique ID" comment ...................................................................... treewide: Remove unuseful "_UID: Unique ID" comment Change-Id: I150a4ed94bcaead6eb45f1c4b4952ae6957e0940 Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> --- M src/ec/purism/librem-ec/acpi/battery.asl M src/ec/system76/ec/acpi/battery.asl M src/mainboard/acer/aspire_vn7_572g/acpi/battery.asl M src/mainboard/google/poppy/variants/atlas/include/variant/acpi/cam0.asl M src/mainboard/google/poppy/variants/baseboard/include/baseboard/acpi/cam0.asl M src/mainboard/google/poppy/variants/baseboard/include/baseboard/acpi/cam1.asl M src/mainboard/google/poppy/variants/baseboard/include/baseboard/acpi/camera_pmic.asl M src/mainboard/google/poppy/variants/nautilus/include/variant/acpi/cam0.asl M src/mainboard/google/poppy/variants/nocturne/include/variant/acpi/cam0.asl M src/mainboard/google/poppy/variants/nocturne/include/variant/acpi/cam1.asl M src/mainboard/google/volteer/variants/baseboard/include/baseboard/acpi/mipi_camera.asl M src/mainboard/google/volteer/variants/voema/include/variant/acpi/mipi_camera.asl M src/mainboard/intel/kblrvp/acpi/mipi_camera.asl M src/mainboard/intel/tglrvp/acpi/mipi_camera.asl M src/mainboard/starlabs/lite/acpi/touchpad.asl M src/mainboard/system76/kbl-u/acpi/battery.asl M src/soc/intel/common/block/acpi/acpi/northbridge.asl M src/soc/intel/skylake/acpi/systemagent.asl 18 files changed, 46 insertions(+), 36 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/63/72663/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/72663 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I150a4ed94bcaead6eb45f1c4b4952ae6957e0940 Gerrit-Change-Number: 72663 Gerrit-PatchSet: 2 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Jeremy Soller <jeremy(a)system76.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Tim Crawford <tcrawford(a)system76.com> Gerrit-Attention: Tim Crawford <tcrawford(a)system76.com> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Attention: Jeremy Soller <jeremy(a)system76.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-MessageType: newpatchset

1 0

[XL] Change in coreboot[master]: mainboard/protectli/vault_ehl: Add initial structure
by Kacper Stojek (Code Review) 02 Feb '23

02 Feb '23

Attention is currently required from: Michał Żygowski, Artur Kowalski, Michał Kopeć, Elyes Haouas, Piotr Król. Kacper Stojek has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/72407 ) Change subject: mainboard/protectli/vault_ehl: Add initial structure ...................................................................... Patch Set 11: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/72407/comment/9fcac854_66a42059 PS2, Line 8: > How as this created? For example the GPIOs? It’d be nice if you elaborated, and documented, what is […] Done -- To view, visit https://review.coreboot.org/c/coreboot/+/72407 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia00c27117d48b76db306d3f988f159fc5d50e4a0 Gerrit-Change-Number: 72407 Gerrit-PatchSet: 11 Gerrit-Owner: Kacper Stojek Gerrit-Reviewer: Artur Kowalski <artur.kowalski(a)3mdeb.com> Gerrit-Reviewer: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Piotr Król <piotr.krol(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Artur Kowalski <artur.kowalski(a)3mdeb.com> Gerrit-Attention: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Attention: Piotr Król <piotr.krol(a)3mdeb.com> Gerrit-Comment-Date: Thu, 02 Feb 2023 07:42:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: comment

1 0

[XL] Change in coreboot[master]: soc/intel/xeon_sp/spr: add ACPI code
by Arthur Heymans (Code Review) 02 Feb '23

02 Feb '23

Attention is currently required from: Patrick Rudolph, Jonathan Zhang, Simon Chou, TimLiu-SMCI, Johnny Lin, Christian Walter, Shuming Chu (Shuming). Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71967 ) Change subject: soc/intel/xeon_sp/spr: add ACPI code ...................................................................... Patch Set 13: (1 comment) File src/soc/intel/xeon_sp/spr/soc_acpi.c: https://review.coreboot.org/c/coreboot/+/71967/comment/2e0a6561_c4f70e1d PS13, Line 387: for (uint8_t socket = 0; socket < hob->PlatformData.numofIIO; ++socket) { > it's fine to generate the DSDT from CONFIG_MAX_SOCKET as long as the SSDT is > 1) generating all the resources consumed by DSDT > 2) setting _STA and _CRS to 0 for all unpopulated devices/sockets It's quite easy to do: https://review.coreboot.org/c/coreboot/+/70501 just implement those method in SSDT rather than DSDT with extern objects from SSDT. -- To view, visit https://review.coreboot.org/c/coreboot/+/71967 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic2a9be0222e122ae087b9cc8e1859d257e3411d6 Gerrit-Change-Number: 71967 Gerrit-PatchSet: 13 Gerrit-Owner: Simon Chou <simonchou(a)supermicro.com.tw> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Jian-Ming Wang <jianmingW(a)supermicro.com> Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Reviewer: TimLiu-SMCI Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-CC: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-CC: Shuming Chu (Shuming) <s1218944(a)gmail.com> Gerrit-CC: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Attention: Simon Chou <simonchou(a)supermicro.com.tw> Gerrit-Attention: TimLiu-SMCI Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Shuming Chu (Shuming) <s1218944(a)gmail.com> Gerrit-Comment-Date: Thu, 02 Feb 2023 07:38:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Patrick Rudolph <patrick.rudolph(a)9elements.com> Comment-In-Reply-To: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: treewide: Remove unuseful "_ADR: Address" comment
by Elyes Haouas (Code Review) 02 Feb '23

02 Feb '23

Elyes Haouas has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/72664 ) Change subject: treewide: Remove unuseful "_ADR: Address" comment ...................................................................... treewide: Remove unuseful "_ADR: Address" comment Change-Id: Ib968fe7f9f95e8f690b46b868fd7d6f9332b4c9a Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> --- M src/mainboard/asus/p8x7x-series/variants/p8c_ws/pci.asl M src/mainboard/gigabyte/ga-b75m-d3h/acpi/pci.asl M src/mainboard/google/cyan/dsdt.asl M src/mainboard/hp/z220_series/acpi/pci.asl M src/mainboard/intel/strago/dsdt.asl M src/mainboard/protectli/vault_bsw/dsdt.asl M src/mainboard/supermicro/x9sae/acpi/pci.asl M src/soc/intel/braswell/acpi/scc.asl M src/soc/intel/common/block/acpi/acpi/ufs.asl M src/southbridge/intel/i82371eb/acpi/i82371eb.asl 10 files changed, 19 insertions(+), 10 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/64/72664/1 diff --git a/src/mainboard/asus/p8x7x-series/variants/p8c_ws/pci.asl b/src/mainboard/asus/p8x7x-series/variants/p8c_ws/pci.asl index 76af84c..e382c7b 100644 --- a/src/mainboard/asus/p8x7x-series/variants/p8c_ws/pci.asl +++ b/src/mainboard/asus/p8x7x-series/variants/p8c_ws/pci.asl @@ -4,7 +4,7 @@ Device (PCIB) { - Name (_ADR, 0x001E0000) // _ADR: Address + Name (_ADR, 0x001E0000) Name (_PRW, Package(){ 13, 4 }) // Power Resources for Wake Method (_PRT) // _PRT: PCI Interrupt Routing Table diff --git a/src/mainboard/gigabyte/ga-b75m-d3h/acpi/pci.asl b/src/mainboard/gigabyte/ga-b75m-d3h/acpi/pci.asl index 47e6971..c29243c 100644 --- a/src/mainboard/gigabyte/ga-b75m-d3h/acpi/pci.asl +++ b/src/mainboard/gigabyte/ga-b75m-d3h/acpi/pci.asl @@ -4,7 +4,7 @@ Device (PCIB) { - Name (_ADR, 0x001E0000) // _ADR: Address + Name (_ADR, 0x001E0000) Name (_PRW, Package(){ 13, 4 }) // Power Resources for Wake Method (_PRT) // _PRT: PCI Interrupt Routing Table diff --git a/src/mainboard/google/cyan/dsdt.asl b/src/mainboard/google/cyan/dsdt.asl index b4fd901..3d6bfdf 100644 --- a/src/mainboard/google/cyan/dsdt.asl +++ b/src/mainboard/google/cyan/dsdt.asl @@ -35,7 +35,7 @@ { Device (RP03) { - Name (_ADR, 0x001C0002) // _ADR: Address + Name (_ADR, 0x001C0002) OperationRegion(RPXX, PCI_Config, 0x00, 0x10) /* Wifi Device */ diff --git a/src/mainboard/hp/z220_series/acpi/pci.asl b/src/mainboard/hp/z220_series/acpi/pci.asl index 6277ac6..ff3866a 100644 --- a/src/mainboard/hp/z220_series/acpi/pci.asl +++ b/src/mainboard/hp/z220_series/acpi/pci.asl @@ -4,7 +4,7 @@ Device (PCIB) { - Name (_ADR, 0x001e0000) // _ADR: Address + Name (_ADR, 0x001e0000) Name (_PRW, Package() { 13, 4 }) // Power Resources for Wake Method (_PRT) // _PRT: PCI Interrupt Routing Table diff --git a/src/mainboard/intel/strago/dsdt.asl b/src/mainboard/intel/strago/dsdt.asl index 8efc4db..a84ac20 100644 --- a/src/mainboard/intel/strago/dsdt.asl +++ b/src/mainboard/intel/strago/dsdt.asl @@ -30,7 +30,7 @@ { Device (RP03) { - Name (_ADR, 0x001C0002) // _ADR: Address + Name (_ADR, 0x001C0002) OperationRegion(RPXX, PCI_Config, 0x00, 0x10) /* Wifi Device */ diff --git a/src/mainboard/protectli/vault_bsw/dsdt.asl b/src/mainboard/protectli/vault_bsw/dsdt.asl index cc50798..c18a267 100644 --- a/src/mainboard/protectli/vault_bsw/dsdt.asl +++ b/src/mainboard/protectli/vault_bsw/dsdt.asl @@ -23,7 +23,7 @@ Device (RP03) { - Name (_ADR, 0x001C0002) // _ADR: Address + Name (_ADR, 0x001C0002) OperationRegion(RPXX, PCI_Config, 0x00, 0x10) } } diff --git a/src/mainboard/supermicro/x9sae/acpi/pci.asl b/src/mainboard/supermicro/x9sae/acpi/pci.asl index 72b497c..e273c64 100644 --- a/src/mainboard/supermicro/x9sae/acpi/pci.asl +++ b/src/mainboard/supermicro/x9sae/acpi/pci.asl @@ -4,7 +4,7 @@ Device (PCIB) { - Name (_ADR, 0x001E0000) // _ADR: Address + Name (_ADR, 0x001E0000) Name (_PRW, Package(){ 13, 4 }) // Power Resources for Wake Method (_PRT) // _PRT: PCI Interrupt Routing Table diff --git a/src/soc/intel/braswell/acpi/scc.asl b/src/soc/intel/braswell/acpi/scc.asl index a071e08..5efe5a0 100644 --- a/src/soc/intel/braswell/acpi/scc.asl +++ b/src/soc/intel/braswell/acpi/scc.asl @@ -65,7 +65,7 @@ Device (PEMC) { - Name (_ADR, 0x00100000) // _ADR: Address + Name (_ADR, 0x00100000) OperationRegion (SDIO, PCI_Config, 0x84, 0x04) Field (SDIO, WordAcc, NoLock, Preserve) diff --git a/src/soc/intel/common/block/acpi/acpi/ufs.asl b/src/soc/intel/common/block/acpi/acpi/ufs.asl index a2ddaa9..fcfe9bd 100644 --- a/src/soc/intel/common/block/acpi/acpi/ufs.asl +++ b/src/soc/intel/common/block/acpi/acpi/ufs.asl @@ -10,7 +10,6 @@ { Device (UFS) { - /* _ADR: Address */ Name (_ADR, UFS_ACPI_DEVICE) /* _DDN: DOS Device Name */ Name (_DDN, "UFS Controller") diff --git a/src/southbridge/intel/i82371eb/acpi/i82371eb.asl b/src/southbridge/intel/i82371eb/acpi/i82371eb.asl index e3e67ea..4a30168 100644 --- a/src/southbridge/intel/i82371eb/acpi/i82371eb.asl +++ b/src/southbridge/intel/i82371eb/acpi/i82371eb.asl @@ -120,7 +120,7 @@ } Device (PX43) { - Name (_ADR, 0x00040003) // _ADR: Address + Name (_ADR, 0x00040003) Method (_CRS, 0, NotSerialized) { -- To view, visit https://review.coreboot.org/c/coreboot/+/72664 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib968fe7f9f95e8f690b46b868fd7d6f9332b4c9a Gerrit-Change-Number: 72664 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-MessageType: newchange

1 0

[M] Change in coreboot[master]: treewide: Remove unuseful "_UID: Unique ID" comment
by Elyes Haouas (Code Review) 02 Feb '23

02 Feb '23

Attention is currently required from: Tim Crawford, Sean Rhodes, Jeremy Soller, Nick Vaccaro. Elyes Haouas has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/72663 ) Change subject: treewide: Remove unuseful "_UID: Unique ID" comment ...................................................................... treewide: Remove unuseful "_UID: Unique ID" comment Change-Id: I150a4ed94bcaead6eb45f1c4b4952ae6957e0940 Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> --- M src/ec/purism/librem-ec/acpi/battery.asl M src/ec/system76/ec/acpi/battery.asl M src/mainboard/acer/aspire_vn7_572g/acpi/battery.asl M src/mainboard/google/poppy/variants/atlas/include/variant/acpi/cam0.asl M src/mainboard/google/poppy/variants/baseboard/include/baseboard/acpi/cam0.asl M src/mainboard/google/poppy/variants/baseboard/include/baseboard/acpi/cam1.asl M src/mainboard/google/poppy/variants/baseboard/include/baseboard/acpi/camera_pmic.asl M src/mainboard/google/poppy/variants/nautilus/include/variant/acpi/cam0.asl M src/mainboard/google/poppy/variants/nocturne/include/variant/acpi/cam0.asl M src/mainboard/google/poppy/variants/nocturne/include/variant/acpi/cam1.asl M src/mainboard/google/volteer/variants/baseboard/include/baseboard/acpi/mipi_camera.asl M src/mainboard/google/volteer/variants/voema/include/variant/acpi/mipi_camera.asl M src/mainboard/intel/kblrvp/acpi/mipi_camera.asl M src/mainboard/intel/tglrvp/acpi/mipi_camera.asl M src/mainboard/starlabs/lite/acpi/touchpad.asl M src/mainboard/system76/kbl-u/acpi/battery.asl M src/soc/intel/common/block/acpi/acpi/northbridge.asl M src/soc/intel/skylake/acpi/systemagent.asl 18 files changed, 46 insertions(+), 36 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/63/72663/1 diff --git a/src/ec/purism/librem-ec/acpi/battery.asl b/src/ec/purism/librem-ec/acpi/battery.asl index 8836c7a..0085225 100644 --- a/src/ec/purism/librem-ec/acpi/battery.asl +++ b/src/ec/purism/librem-ec/acpi/battery.asl @@ -5,7 +5,7 @@ Device (BAT0) { Name (_HID, EisaId ("PNP0C0A") /* Control Method Battery */) - Name (_UID, 0) // _UID: Unique ID + Name (_UID, 0) Name (_PCL, Package (0x01) // _PCL: Power Consumer List { _SB diff --git a/src/ec/system76/ec/acpi/battery.asl b/src/ec/system76/ec/acpi/battery.asl index 64cb370..0c4bf9f 100644 --- a/src/ec/system76/ec/acpi/battery.asl +++ b/src/ec/system76/ec/acpi/battery.asl @@ -3,7 +3,7 @@ Device (BAT0) { Name (_HID, EisaId ("PNP0C0A") /* Control Method Battery */) - Name (_UID, 0) // _UID: Unique ID + Name (_UID, 0) Name (_PCL, Package (0x01) // _PCL: Power Consumer List { _SB diff --git a/src/mainboard/acer/aspire_vn7_572g/acpi/battery.asl b/src/mainboard/acer/aspire_vn7_572g/acpi/battery.asl index a4fa0e7..5395336 100644 --- a/src/mainboard/acer/aspire_vn7_572g/acpi/battery.asl +++ b/src/mainboard/acer/aspire_vn7_572g/acpi/battery.asl @@ -338,7 +338,7 @@ Device (BAT0) { Name (_HID, EisaId ("PNP0C0A") /* Control Method Battery */) - Name (_UID, 0) // _UID: Unique ID + Name (_UID, 0) Name (_PCL, Package () { \_SB }) // _PCL: Power Consumer List Name (B0IP, Package (0x0D) diff --git a/src/mainboard/google/poppy/variants/atlas/include/variant/acpi/cam0.asl b/src/mainboard/google/poppy/variants/atlas/include/variant/acpi/cam0.asl index 726b5b6..9601bf3 100644 --- a/src/mainboard/google/poppy/variants/atlas/include/variant/acpi/cam0.asl +++ b/src/mainboard/google/poppy/variants/atlas/include/variant/acpi/cam0.asl @@ -47,7 +47,7 @@ Device (CAM0) { Name (_HID, "INT3478") - Name (_UID, 0) /* _UID: Unique ID */ + Name (_UID, 0) Name (_DDN, "SONY IMX208 Camera") /* _DDN: DOS Device Name */ Method (_STA, 0, NotSerialized) /* _STA: Status */ @@ -109,7 +109,7 @@ Device (NVM0) { Name (_HID, "INT3499") - Name (_UID, 0) /* _UID: Unique ID */ + Name (_UID, 0) Name (_DDN, "GT24C16S") /* _DDN: DOS Device Name */ Method (_STA, 0, NotSerialized) /* _STA: Status */ diff --git a/src/mainboard/google/poppy/variants/baseboard/include/baseboard/acpi/cam0.asl b/src/mainboard/google/poppy/variants/baseboard/include/baseboard/acpi/cam0.asl index cc63fc3..a77dbcb 100644 --- a/src/mainboard/google/poppy/variants/baseboard/include/baseboard/acpi/cam0.asl +++ b/src/mainboard/google/poppy/variants/baseboard/include/baseboard/acpi/cam0.asl @@ -5,7 +5,7 @@ Device (CAM0) { Name (_HID, "OVTID858") - Name (_UID, 0) /* _UID: Unique ID */ + Name (_UID, 0) Name (_DDN, "OV 13858 Camera") /* _DDN: DOS Device Name */ Name (CAMD, 0x02) @@ -92,7 +92,7 @@ Device (VCM0) { Name (_HID, "PRP0001") - Name (_UID, 0) /* _UID: Unique ID */ + Name (_UID, 0) Name (_DDN, "Dongwoon AF DAC") /* _DDN: DOS Device Name */ Name (CAMD, 0x03) @@ -124,7 +124,7 @@ Device (NVM0) { Name (_HID, "INT3499") - Name (_UID, 0) /* _UID: Unique ID */ + Name (_UID, 0) Name (_DDN, "GT24C16S/CAT24C16") /* _DDN: DOS Device Name */ Method (_STA, 0, NotSerialized) /* _STA: Status */ diff --git a/src/mainboard/google/poppy/variants/baseboard/include/baseboard/acpi/cam1.asl b/src/mainboard/google/poppy/variants/baseboard/include/baseboard/acpi/cam1.asl index b8de067..08b2eb6 100644 --- a/src/mainboard/google/poppy/variants/baseboard/include/baseboard/acpi/cam1.asl +++ b/src/mainboard/google/poppy/variants/baseboard/include/baseboard/acpi/cam1.asl @@ -5,7 +5,7 @@ Device (CAM1) { Name (_HID, "INT3479") - Name (_UID, 0) /* _UID: Unique ID */ + Name (_UID, 0) Name (_DDN, "OV 5670 Camera") /* _DDN: DOS Device Name */ Name (CAMD, 0x02) diff --git a/src/mainboard/google/poppy/variants/baseboard/include/baseboard/acpi/camera_pmic.asl b/src/mainboard/google/poppy/variants/baseboard/include/baseboard/acpi/camera_pmic.asl index 6307d26..61611d1 100644 --- a/src/mainboard/google/poppy/variants/baseboard/include/baseboard/acpi/camera_pmic.asl +++ b/src/mainboard/google/poppy/variants/baseboard/include/baseboard/acpi/camera_pmic.asl @@ -5,7 +5,7 @@ Device (PMIC) { Name (_HID, "INT3472") - Name (_UID, 0) /* _UID: Unique ID */ + Name (_UID, 0) Name (_DDN, "TPS68470 PMIC") /* _DDN: DOS Device Name */ Name (CAMD, 0x64) diff --git a/src/mainboard/google/poppy/variants/nautilus/include/variant/acpi/cam0.asl b/src/mainboard/google/poppy/variants/nautilus/include/variant/acpi/cam0.asl index c22c580..fd4a05d 100644 --- a/src/mainboard/google/poppy/variants/nautilus/include/variant/acpi/cam0.asl +++ b/src/mainboard/google/poppy/variants/nautilus/include/variant/acpi/cam0.asl @@ -5,7 +5,7 @@ Device (CAM0) { Name (_HID, "SONY258A") - Name (_UID, 0) /* _UID: Unique ID */ + Name (_UID, 0) Name (_DDN, "SONY IMX258 Camera") /* _DDN: DOS Device Name */ Method (_STA, 0, NotSerialized) /* _STA: Status */ @@ -73,7 +73,7 @@ Device (VCM0) { Name (_HID, "PRP0001") - Name (_UID, 0) /* _UID: Unique ID */ + Name (_UID, 0) Name (_DDN, "Dongwoon AF DAC") /* _DDN: DOS Device Name */ Method (_STA, 0, NotSerialized) /* _STA: Status */ @@ -104,7 +104,7 @@ Device (NVM0) { Name (_HID, "INT3499") - Name (_UID, 0) /* _UID: Unique ID */ + Name (_UID, 0) Name (_DDN, "Dongwoon NVM") /* _DDN: DOS Device Name */ Method (_STA, 0, NotSerialized) /* _STA: Status */ diff --git a/src/mainboard/google/poppy/variants/nocturne/include/variant/acpi/cam0.asl b/src/mainboard/google/poppy/variants/nocturne/include/variant/acpi/cam0.asl index c8fda8e..41ab47a 100644 --- a/src/mainboard/google/poppy/variants/nocturne/include/variant/acpi/cam0.asl +++ b/src/mainboard/google/poppy/variants/nocturne/include/variant/acpi/cam0.asl @@ -41,7 +41,7 @@ Device (CAM0) { Name (_HID, "SONY319A") - Name (_UID, 0) /* _UID: Unique ID */ + Name (_UID, 0) Name (_DDN, "Sony IMX319 Camera") /* _DDN: DOS Device Name */ Method (_STA, 0, NotSerialized) /* _STA: Status */ @@ -104,7 +104,7 @@ Device (NVM0) { Name (_HID, "INT3499") - Name (_UID, 0) /* _UID: Unique ID */ + Name (_UID, 0) Name (_DDN, "M24C64S") /* _DDN: DOS Device Name */ Method (_STA, 0, NotSerialized) /* _STA: Status */ diff --git a/src/mainboard/google/poppy/variants/nocturne/include/variant/acpi/cam1.asl b/src/mainboard/google/poppy/variants/nocturne/include/variant/acpi/cam1.asl index 11076e3..1fecd15 100644 --- a/src/mainboard/google/poppy/variants/nocturne/include/variant/acpi/cam1.asl +++ b/src/mainboard/google/poppy/variants/nocturne/include/variant/acpi/cam1.asl @@ -40,7 +40,7 @@ Device (CAM1) { Name (_HID, "SONY355A") - Name (_UID, 0) /* _UID: Unique ID */ + Name (_UID, 0) Name (_DDN, "SONY IMX355A Camera") /* _DDN: DOS Device Name */ Method (_STA, 0, NotSerialized) /* _STA: Status */ @@ -106,7 +106,7 @@ Device (VCM1) { Name (_HID, "PRP0001") - Name (_UID, 3) /* _UID: Unique ID */ + Name (_UID, 3) Name (_DDN, "AKM AF DAC") /* _DDN: DOS Device Name */ Method (_STA, 0, NotSerialized) /* _STA: Status */ @@ -138,7 +138,7 @@ Device (NVM1) { Name (_HID, "INT3499") - Name (_UID, 1) /* _UID: Unique ID */ + Name (_UID, 1) Name (_DDN, "M24C64S") /* _DDN: DOS Device Name */ Method (_STA, 0, NotSerialized) /* _STA: Status */ diff --git a/src/mainboard/google/volteer/variants/baseboard/include/baseboard/acpi/mipi_camera.asl b/src/mainboard/google/volteer/variants/baseboard/include/baseboard/acpi/mipi_camera.asl index d8685da..c273f83 100644 --- a/src/mainboard/google/volteer/variants/baseboard/include/baseboard/acpi/mipi_camera.asl +++ b/src/mainboard/google/volteer/variants/baseboard/include/baseboard/acpi/mipi_camera.asl @@ -208,7 +208,7 @@ Device (CAM0) { Name (_HID, "OVTI8856") - Name (_UID, 0) /* _UID: Unique ID */ + Name (_UID, 0) Name (_DDN, "Ov 8856 Camera") /* _DDN: DOS Device Name */ Method (_STA, 0, NotSerialized) /* _STA: Status */ { @@ -365,7 +365,7 @@ Device (VCM0) { Name (_HID, "PRP0001") - Name (_UID, 0x00) /* _UID: Unique ID */ + Name (_UID, 0x00) Name (_DDN, "DW9768 VCM") /* _DDN: DOS Device Name */ Method (_STA, 0, NotSerialized) /* _STA: Status */ { @@ -411,7 +411,7 @@ Device (NVM0) { Name (_HID, "PRP0001") - Name (_UID, 0x01) // _UID: Unique ID + Name (_UID, 0x01) Name (_DDN, "AT24 EEPROM") // _DDN: DOS Device Name Method (_STA, 0, NotSerialized) // _STA: Status { @@ -534,7 +534,7 @@ Device (CAM1) { Name (_HID, "INT3474") - Name (_UID, 0) /* _UID: Unique ID */ + Name (_UID, 0) Name (_DDN, "Ov 2740 Camera") /* _DDN: DOS Device Name */ Method (_STA, 0, NotSerialized) /* _STA: Status */ { diff --git a/src/mainboard/google/volteer/variants/voema/include/variant/acpi/mipi_camera.asl b/src/mainboard/google/volteer/variants/voema/include/variant/acpi/mipi_camera.asl index 290d2b6..e98cd60 100644 --- a/src/mainboard/google/volteer/variants/voema/include/variant/acpi/mipi_camera.asl +++ b/src/mainboard/google/volteer/variants/voema/include/variant/acpi/mipi_camera.asl @@ -158,7 +158,7 @@ Device (CAM1) { Name (_HID, "INT3474") - Name (_UID, 0) /* _UID: Unique ID */ + Name (_UID, 0) Name (_DDN, "Ov 2740 Camera") /* _DDN: DOS Device Name */ Method (_STA, 0, NotSerialized) /* _STA: Status */ { @@ -274,7 +274,7 @@ Device (NVM0) { Name (_HID, "PRP0001") - Name (_UID, 0x01) // _UID: Unique ID + Name (_UID, 0x01) Name (_DDN, "AT24 EEPROM") // _DDN: DOS Device Name Method (_STA, 0, NotSerialized) // _STA: Status { diff --git a/src/mainboard/intel/kblrvp/acpi/mipi_camera.asl b/src/mainboard/intel/kblrvp/acpi/mipi_camera.asl index 292e548..481d96d 100644 --- a/src/mainboard/intel/kblrvp/acpi/mipi_camera.asl +++ b/src/mainboard/intel/kblrvp/acpi/mipi_camera.asl @@ -5,7 +5,7 @@ Device (PMIC) { Name (_HID, "INT3472") - Name (_UID, 0) // _UID: Unique ID */ + Name (_UID, 0) */ Name (_DDN, "TPS68470 PMIC") /* _DDN: DOS Device Name */ Name (CAMD, 0x64) @@ -370,7 +370,7 @@ Device (CAM0) { Name (_HID, "OVTID858") - Name (_UID, 0) /* _UID: Unique ID */ + Name (_UID, 0) Name (_DDN, "OV 13858 Camera") /* _DDN: DOS Device Name */ Name (CAMD, 0x02) @@ -475,7 +475,7 @@ Device (VCM0) { Name (_HID, "DWDWD000") - Name (_UID, 0) /* _UID: Unique ID */ + Name (_UID, 0) Name (_DDN, "Dongwoon AF DAC") /* _DDN: DOS Device Name */ Name (CAMD, 0x03) @@ -503,7 +503,7 @@ Device (PMIC) { Name (_HID, "INT3473") - Name (_UID, 0) /* _UID: Unique ID */ + Name (_UID, 0) Name (_DDN, "TPS68470 PMIC 2") /* _DDN: DOS Device Name */ Name (CAMD, 0x64) @@ -806,7 +806,7 @@ Device (CAM1) { Name (_HID, "INT3479") - Name (_UID, 0) /* _UID: Unique ID */ + Name (_UID, 0) Name (_DDN, "OV 5670 Camera") /* _DDN: DOS Device Name */ Name (CAMD, 0x02) diff --git a/src/mainboard/intel/tglrvp/acpi/mipi_camera.asl b/src/mainboard/intel/tglrvp/acpi/mipi_camera.asl index 8159fa7..d4f2031 100644 --- a/src/mainboard/intel/tglrvp/acpi/mipi_camera.asl +++ b/src/mainboard/intel/tglrvp/acpi/mipi_camera.asl @@ -199,7 +199,7 @@ Device (CAM0) { Name (_HID, "OVTI8856") - Name (_UID, 0) /* _UID: Unique ID */ + Name (_UID, 0) Name (_DDN, "Ov 8856 Camera") /* _DDN: DOS Device Name */ Method (_STA, 0, NotSerialized) /* _STA: Status */ { @@ -322,7 +322,7 @@ Device (VCM0) { Name (_HID, "PRP0001") - Name (_UID, 0x03) /* _UID: Unique ID */ + Name (_UID, 0x03) Name (_DDN, "DW9714 VCM") /* _DDN: DOS Device Name */ Method (_STA, 0, NotSerialized) /* _STA: Status */ { @@ -422,7 +422,7 @@ Device (CAM1) { Name (_HID, "OVTI8856") - Name (_UID, 0) /* _UID: Unique ID */ + Name (_UID, 0) Name (_DDN, "Ov 8856 Camera") /* _DDN: DOS Device Name */ Method (_STA, 0, NotSerialized) /* _STA: Status */ { diff --git a/src/mainboard/starlabs/lite/acpi/touchpad.asl b/src/mainboard/starlabs/lite/acpi/touchpad.asl index 2f9c27c..44eb8d8 100644 --- a/src/mainboard/starlabs/lite/acpi/touchpad.asl +++ b/src/mainboard/starlabs/lite/acpi/touchpad.asl @@ -6,7 +6,7 @@ { Name (_HID, "STAR0001") Name (_CID, "PNP0C50" /* HID Protocol Device (I2C bus) */) - Name (_UID, 0x01) // _UID: Unique ID + Name (_UID, 0x01) Name (_DDN, "Touchpad") // _DDN: DOS Device Name Name (_DEP, Package (0x02) // _DEP: Dependencies { diff --git a/src/mainboard/system76/kbl-u/acpi/battery.asl b/src/mainboard/system76/kbl-u/acpi/battery.asl index a3287e3..6fd0bed 100644 --- a/src/mainboard/system76/kbl-u/acpi/battery.asl +++ b/src/mainboard/system76/kbl-u/acpi/battery.asl @@ -3,7 +3,7 @@ Device (BAT0) { Name (_HID, EisaId ("PNP0C0A") /* Control Method Battery */) - Name (_UID, 0) // _UID: Unique ID + Name (_UID, 0) Name (_PCL, Package (0x01) // _PCL: Power Consumer List { _SB diff --git a/src/soc/intel/common/block/acpi/acpi/northbridge.asl b/src/soc/intel/common/block/acpi/acpi/northbridge.asl index 65c7588..d605625 100644 --- a/src/soc/intel/common/block/acpi/acpi/northbridge.asl +++ b/src/soc/intel/common/block/acpi/acpi/northbridge.asl @@ -6,7 +6,7 @@ Name (_HID, EisaId ("PNP0A08") /* PCI Express Bus */) Name (_CID, EisaId ("PNP0A03") /* PCI Bus */) Name (_SEG, 0) // _SEG: PCI Segment -Name (_UID, 0) // _UID: Unique ID +Name (_UID, 0) Device (MCHC) { diff --git a/src/soc/intel/skylake/acpi/systemagent.asl b/src/soc/intel/skylake/acpi/systemagent.asl index 0fdaab9..0e5d74f 100644 --- a/src/soc/intel/skylake/acpi/systemagent.asl +++ b/src/soc/intel/skylake/acpi/systemagent.asl @@ -6,7 +6,7 @@ Name (_HID, EisaId ("PNP0A08") /* PCI Express Bus */) Name (_CID, EisaId ("PNP0A03") /* PCI Bus */) Name (_SEG, 0) // _SEG: PCI Segment -Name (_UID, 0) // _UID: Unique ID +Name (_UID, 0) Device (MCHC) { -- To view, visit https://review.coreboot.org/c/coreboot/+/72663 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I150a4ed94bcaead6eb45f1c4b4952ae6957e0940 Gerrit-Change-Number: 72663 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Jeremy Soller <jeremy(a)system76.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Tim Crawford <tcrawford(a)system76.com> Gerrit-Attention: Tim Crawford <tcrawford(a)system76.com> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Attention: Jeremy Soller <jeremy(a)system76.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-MessageType: newchange

1 0

[S] Change in coreboot[master]: treewide: Remove unuseful "_CID: Compatible ID" comment
by Elyes Haouas (Code Review) 02 Feb '23

02 Feb '23

Attention is currently required from: Sean Rhodes. Elyes Haouas has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/72662 ) Change subject: treewide: Remove unuseful "_CID: Compatible ID" comment ...................................................................... treewide: Remove unuseful "_CID: Compatible ID" comment Change-Id: I7db69e2faf412b9c6732f6dfc362d5774094ef27 Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> --- M src/mainboard/intel/glkrvp/touchpanel.asl M src/mainboard/starlabs/lite/acpi/touchpad.asl M src/soc/intel/common/block/acpi/acpi/northbridge.asl M src/soc/intel/skylake/acpi/systemagent.asl 4 files changed, 14 insertions(+), 4 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/62/72662/1 diff --git a/src/mainboard/intel/glkrvp/touchpanel.asl b/src/mainboard/intel/glkrvp/touchpanel.asl index 32503b5..acbfb20 100644 --- a/src/mainboard/intel/glkrvp/touchpanel.asl +++ b/src/mainboard/intel/glkrvp/touchpanel.asl @@ -8,7 +8,7 @@ Device (TPL1) { Name (HID2, 1) Name (_HID, "WCOM508E") - Name (_CID, "PNP0C50") // _CID: Compatible ID + Name (_CID, "PNP0C50") Name (_S0W, 0x04) // _S0W: S0 Device Wake State Name (SBFB, ResourceTemplate () { I2cSerialBus ( diff --git a/src/mainboard/starlabs/lite/acpi/touchpad.asl b/src/mainboard/starlabs/lite/acpi/touchpad.asl index 5c9708d..2f9c27c 100644 --- a/src/mainboard/starlabs/lite/acpi/touchpad.asl +++ b/src/mainboard/starlabs/lite/acpi/touchpad.asl @@ -5,7 +5,7 @@ Device (H02C) { Name (_HID, "STAR0001") - Name (_CID, "PNP0C50" /* HID Protocol Device (I2C bus) */) // _CID: Compatible ID + Name (_CID, "PNP0C50" /* HID Protocol Device (I2C bus) */) Name (_UID, 0x01) // _UID: Unique ID Name (_DDN, "Touchpad") // _DDN: DOS Device Name Name (_DEP, Package (0x02) // _DEP: Dependencies diff --git a/src/soc/intel/common/block/acpi/acpi/northbridge.asl b/src/soc/intel/common/block/acpi/acpi/northbridge.asl index b0d0ca8..65c7588 100644 --- a/src/soc/intel/common/block/acpi/acpi/northbridge.asl +++ b/src/soc/intel/common/block/acpi/acpi/northbridge.asl @@ -4,7 +4,7 @@ #include <soc/iomap.h> Name (_HID, EisaId ("PNP0A08") /* PCI Express Bus */) -Name (_CID, EisaId ("PNP0A03") /* PCI Bus */) // _CID: Compatible ID +Name (_CID, EisaId ("PNP0A03") /* PCI Bus */) Name (_SEG, 0) // _SEG: PCI Segment Name (_UID, 0) // _UID: Unique ID diff --git a/src/soc/intel/skylake/acpi/systemagent.asl b/src/soc/intel/skylake/acpi/systemagent.asl index 9c332c4..0fdaab9 100644 --- a/src/soc/intel/skylake/acpi/systemagent.asl +++ b/src/soc/intel/skylake/acpi/systemagent.asl @@ -4,7 +4,7 @@ #include <soc/iomap.h> Name (_HID, EisaId ("PNP0A08") /* PCI Express Bus */) -Name (_CID, EisaId ("PNP0A03") /* PCI Bus */) // _CID: Compatible ID +Name (_CID, EisaId ("PNP0A03") /* PCI Bus */) Name (_SEG, 0) // _SEG: PCI Segment Name (_UID, 0) // _UID: Unique ID -- To view, visit https://review.coreboot.org/c/coreboot/+/72662 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7db69e2faf412b9c6732f6dfc362d5774094ef27 Gerrit-Change-Number: 72662 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems> Gerrit-MessageType: newchange

1 0

[M] Change in coreboot[master]: treewide: Remove unuseful "_HID: Hardware ID" comment
by Elyes Haouas (Code Review) 02 Feb '23

02 Feb '23

Elyes Haouas has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/72661 ) Change subject: treewide: Remove unuseful "_HID: Hardware ID" comment ...................................................................... treewide: Remove unuseful "_HID: Hardware ID" comment Change-Id: I5eb1424e9e6c1fbf20cd0bf68fbb52e1ec97f905 Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> --- M src/ec/purism/librem-ec/acpi/ac.asl M src/ec/purism/librem-ec/acpi/battery.asl M src/ec/purism/librem-ec/acpi/ec.asl M src/ec/roda/it8518/acpi/lid.asl M src/ec/system76/ec/acpi/ac.asl M src/ec/system76/ec/acpi/battery.asl M src/ec/system76/ec/acpi/ec.asl M src/mainboard/acer/aspire_vn7_572g/acpi/ac.asl M src/mainboard/acer/aspire_vn7_572g/acpi/battery.asl M src/mainboard/acer/aspire_vn7_572g/acpi/ec.asl M src/mainboard/acer/aspire_vn7_572g/acpi/mainboard.asl M src/mainboard/google/poppy/variants/atlas/include/variant/acpi/cam0.asl M src/mainboard/google/poppy/variants/baseboard/include/baseboard/acpi/cam0.asl M src/mainboard/google/poppy/variants/baseboard/include/baseboard/acpi/cam1.asl M src/mainboard/google/poppy/variants/baseboard/include/baseboard/acpi/camera_pmic.asl M src/mainboard/google/poppy/variants/nautilus/include/variant/acpi/cam0.asl M src/mainboard/google/poppy/variants/nocturne/include/variant/acpi/cam0.asl M src/mainboard/google/poppy/variants/nocturne/include/variant/acpi/cam1.asl M src/mainboard/google/volteer/variants/baseboard/include/baseboard/acpi/mipi_camera.asl M src/mainboard/google/volteer/variants/voema/include/variant/acpi/mipi_camera.asl M src/mainboard/intel/glkrvp/touchpanel.asl M src/mainboard/intel/kblrvp/acpi/mipi_camera.asl M src/mainboard/intel/tglrvp/acpi/mipi_camera.asl M src/mainboard/roda/rv11/acpi/alsd.asl M src/mainboard/starlabs/lite/acpi/touchpad.asl M src/mainboard/system76/kbl-u/acpi/ac.asl M src/mainboard/system76/kbl-u/acpi/battery.asl M src/mainboard/system76/kbl-u/acpi/ec.asl M src/soc/intel/common/block/acpi/acpi/northbridge.asl M src/soc/intel/skylake/acpi/systemagent.asl M src/superio/winbond/w83977tf/acpi/superio.asl 31 files changed, 60 insertions(+), 50 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/61/72661/1 diff --git a/src/ec/purism/librem-ec/acpi/ac.asl b/src/ec/purism/librem-ec/acpi/ac.asl index b417e03..7bf3a37 100644 --- a/src/ec/purism/librem-ec/acpi/ac.asl +++ b/src/ec/purism/librem-ec/acpi/ac.asl @@ -2,7 +2,7 @@ Device (AC) { - Name (_HID, "ACPI0003" /* Power Source Device */) // _HID: Hardware ID + Name (_HID, "ACPI0003" /* Power Source Device */) Name (_PCL, Package (0x01) // _PCL: Power Consumer List { _SB diff --git a/src/ec/purism/librem-ec/acpi/battery.asl b/src/ec/purism/librem-ec/acpi/battery.asl index 6b1572b..8836c7a 100644 --- a/src/ec/purism/librem-ec/acpi/battery.asl +++ b/src/ec/purism/librem-ec/acpi/battery.asl @@ -4,7 +4,7 @@ Device (BAT0) { - Name (_HID, EisaId ("PNP0C0A") /* Control Method Battery */) // _HID: Hardware ID + Name (_HID, EisaId ("PNP0C0A") /* Control Method Battery */) Name (_UID, 0) // _UID: Unique ID Name (_PCL, Package (0x01) // _PCL: Power Consumer List { diff --git a/src/ec/purism/librem-ec/acpi/ec.asl b/src/ec/purism/librem-ec/acpi/ec.asl index 083d2c0..caef051 100644 --- a/src/ec/purism/librem-ec/acpi/ec.asl +++ b/src/ec/purism/librem-ec/acpi/ec.asl @@ -11,7 +11,7 @@ Device (\_SB.PCI0.LPCB.EC0) { - Name (_HID, EisaId ("PNP0C09") /* Embedded Controller Device */) // _HID: Hardware ID + Name (_HID, EisaId ("PNP0C09") /* Embedded Controller Device */) Name (_GPE, EC_GPE_SCI) // _GPE: General Purpose Events Name (_CRS, ResourceTemplate () // _CRS: Current Resource Settings { diff --git a/src/ec/roda/it8518/acpi/lid.asl b/src/ec/roda/it8518/acpi/lid.asl index 61eda55..3563cbc 100644 --- a/src/ec/roda/it8518/acpi/lid.asl +++ b/src/ec/roda/it8518/acpi/lid.asl @@ -4,7 +4,7 @@ Device (LID) { - Name (_HID, EisaId ("PNP0C0D")) // _HID: Hardware ID + Name (_HID, EisaId ("PNP0C0D")) Method (_LID, 0, NotSerialized) // _LID: Lid Status { Printf ("-----> LID0: _LID") diff --git a/src/ec/system76/ec/acpi/ac.asl b/src/ec/system76/ec/acpi/ac.asl index b417e03..7bf3a37 100644 --- a/src/ec/system76/ec/acpi/ac.asl +++ b/src/ec/system76/ec/acpi/ac.asl @@ -2,7 +2,7 @@ Device (AC) { - Name (_HID, "ACPI0003" /* Power Source Device */) // _HID: Hardware ID + Name (_HID, "ACPI0003" /* Power Source Device */) Name (_PCL, Package (0x01) // _PCL: Power Consumer List { _SB diff --git a/src/ec/system76/ec/acpi/battery.asl b/src/ec/system76/ec/acpi/battery.asl index 2784804..64cb370 100644 --- a/src/ec/system76/ec/acpi/battery.asl +++ b/src/ec/system76/ec/acpi/battery.asl @@ -2,7 +2,7 @@ Device (BAT0) { - Name (_HID, EisaId ("PNP0C0A") /* Control Method Battery */) // _HID: Hardware ID + Name (_HID, EisaId ("PNP0C0A") /* Control Method Battery */) Name (_UID, 0) // _UID: Unique ID Name (_PCL, Package (0x01) // _PCL: Power Consumer List { diff --git a/src/ec/system76/ec/acpi/ec.asl b/src/ec/system76/ec/acpi/ec.asl index f572c97..21d9ad0 100644 --- a/src/ec/system76/ec/acpi/ec.asl +++ b/src/ec/system76/ec/acpi/ec.asl @@ -11,7 +11,7 @@ Device (\_SB.PCI0.LPCB.EC0) { - Name (_HID, EisaId ("PNP0C09") /* Embedded Controller Device */) // _HID: Hardware ID + Name (_HID, EisaId ("PNP0C09") /* Embedded Controller Device */) Name (_GPE, EC_GPE_SCI) // _GPE: General Purpose Events Name (_CRS, ResourceTemplate () // _CRS: Current Resource Settings { diff --git a/src/mainboard/acer/aspire_vn7_572g/acpi/ac.asl b/src/mainboard/acer/aspire_vn7_572g/acpi/ac.asl index c92cbd9..778a470 100644 --- a/src/mainboard/acer/aspire_vn7_572g/acpi/ac.asl +++ b/src/mainboard/acer/aspire_vn7_572g/acpi/ac.asl @@ -2,7 +2,7 @@ Device (ADP1) { - Name (_HID, "ACPI0003" /* Power Source Device */) // _HID: Hardware ID + Name (_HID, "ACPI0003" /* Power Source Device */) Name (_PCL, Package () { \_SB }) // _PCL: Power Consumer List Method (_PSR, 0, NotSerialized) // _PSR: Power Source diff --git a/src/mainboard/acer/aspire_vn7_572g/acpi/battery.asl b/src/mainboard/acer/aspire_vn7_572g/acpi/battery.asl index 1a06314..a4fa0e7 100644 --- a/src/mainboard/acer/aspire_vn7_572g/acpi/battery.asl +++ b/src/mainboard/acer/aspire_vn7_572g/acpi/battery.asl @@ -337,7 +337,7 @@ Device (BAT0) { - Name (_HID, EisaId ("PNP0C0A") /* Control Method Battery */) // _HID: Hardware ID + Name (_HID, EisaId ("PNP0C0A") /* Control Method Battery */) Name (_UID, 0) // _UID: Unique ID Name (_PCL, Package () { \_SB }) // _PCL: Power Consumer List diff --git a/src/mainboard/acer/aspire_vn7_572g/acpi/ec.asl b/src/mainboard/acer/aspire_vn7_572g/acpi/ec.asl index 37595e1..cdbdfb6 100644 --- a/src/mainboard/acer/aspire_vn7_572g/acpi/ec.asl +++ b/src/mainboard/acer/aspire_vn7_572g/acpi/ec.asl @@ -27,7 +27,7 @@ Device (EC0) { - Name (_HID, EisaId ("PNP0C09") /* Embedded Controller Device */) // _HID: Hardware ID + Name (_HID, EisaId ("PNP0C09") /* Embedded Controller Device */) Name (_GPE, 0x50) // _GPE: General Purpose Events Name (\ECOK, 0) #if CONFIG(EC_USE_LGMR) diff --git a/src/mainboard/acer/aspire_vn7_572g/acpi/mainboard.asl b/src/mainboard/acer/aspire_vn7_572g/acpi/mainboard.asl index a3c48b2..f16551d 100644 --- a/src/mainboard/acer/aspire_vn7_572g/acpi/mainboard.asl +++ b/src/mainboard/acer/aspire_vn7_572g/acpi/mainboard.asl @@ -48,7 +48,7 @@ Device (LID0) { - Name (_HID, EisaId ("PNP0C0D") /* Lid Device */) // _HID: Hardware ID + Name (_HID, EisaId ("PNP0C0D") /* Lid Device */) Method (_LID, 0, NotSerialized) // _LID: Lid Status { #if CONFIG(EC_USE_LGMR) @@ -68,7 +68,7 @@ Device (SLPB) { - Name (_HID, EisaId ("PNP0C0E") /* Sleep Button Device */) // _HID: Hardware ID + Name (_HID, EisaId ("PNP0C0E") /* Sleep Button Device */) Name (_PRW, Package () { 0x0A, 3 }) // _PRW: Power Resources for Wake } } diff --git a/src/mainboard/google/poppy/variants/atlas/include/variant/acpi/cam0.asl b/src/mainboard/google/poppy/variants/atlas/include/variant/acpi/cam0.asl index 959ec4a..726b5b6 100644 --- a/src/mainboard/google/poppy/variants/atlas/include/variant/acpi/cam0.asl +++ b/src/mainboard/google/poppy/variants/atlas/include/variant/acpi/cam0.asl @@ -46,7 +46,7 @@ Device (CAM0) { - Name (_HID, "INT3478") /* _HID: Hardware ID */ + Name (_HID, "INT3478") Name (_UID, 0) /* _UID: Unique ID */ Name (_DDN, "SONY IMX208 Camera") /* _DDN: DOS Device Name */ @@ -108,7 +108,7 @@ Device (NVM0) { - Name (_HID, "INT3499") /* _HID: Hardware ID */ + Name (_HID, "INT3499") Name (_UID, 0) /* _UID: Unique ID */ Name (_DDN, "GT24C16S") /* _DDN: DOS Device Name */ diff --git a/src/mainboard/google/poppy/variants/baseboard/include/baseboard/acpi/cam0.asl b/src/mainboard/google/poppy/variants/baseboard/include/baseboard/acpi/cam0.asl index 6ad59f1..cc63fc3 100644 --- a/src/mainboard/google/poppy/variants/baseboard/include/baseboard/acpi/cam0.asl +++ b/src/mainboard/google/poppy/variants/baseboard/include/baseboard/acpi/cam0.asl @@ -4,7 +4,7 @@ { Device (CAM0) { - Name (_HID, "OVTID858") /* _HID: Hardware ID */ + Name (_HID, "OVTID858") Name (_UID, 0) /* _UID: Unique ID */ Name (_DDN, "OV 13858 Camera") /* _DDN: DOS Device Name */ Name (CAMD, 0x02) @@ -91,7 +91,7 @@ Device (VCM0) { - Name (_HID, "PRP0001") /* _HID: Hardware ID */ + Name (_HID, "PRP0001") Name (_UID, 0) /* _UID: Unique ID */ Name (_DDN, "Dongwoon AF DAC") /* _DDN: DOS Device Name */ Name (CAMD, 0x03) @@ -123,7 +123,7 @@ Device (NVM0) { - Name (_HID, "INT3499") /* _HID: Hardware ID */ + Name (_HID, "INT3499") Name (_UID, 0) /* _UID: Unique ID */ Name (_DDN, "GT24C16S/CAT24C16") /* _DDN: DOS Device Name */ diff --git a/src/mainboard/google/poppy/variants/baseboard/include/baseboard/acpi/cam1.asl b/src/mainboard/google/poppy/variants/baseboard/include/baseboard/acpi/cam1.asl index 974f1c4e..b8de067 100644 --- a/src/mainboard/google/poppy/variants/baseboard/include/baseboard/acpi/cam1.asl +++ b/src/mainboard/google/poppy/variants/baseboard/include/baseboard/acpi/cam1.asl @@ -4,7 +4,7 @@ { Device (CAM1) { - Name (_HID, "INT3479") /* _HID: Hardware ID */ + Name (_HID, "INT3479") Name (_UID, 0) /* _UID: Unique ID */ Name (_DDN, "OV 5670 Camera") /* _DDN: DOS Device Name */ Name (CAMD, 0x02) diff --git a/src/mainboard/google/poppy/variants/baseboard/include/baseboard/acpi/camera_pmic.asl b/src/mainboard/google/poppy/variants/baseboard/include/baseboard/acpi/camera_pmic.asl index 5825d77..6307d26 100644 --- a/src/mainboard/google/poppy/variants/baseboard/include/baseboard/acpi/camera_pmic.asl +++ b/src/mainboard/google/poppy/variants/baseboard/include/baseboard/acpi/camera_pmic.asl @@ -4,7 +4,7 @@ { Device (PMIC) { - Name (_HID, "INT3472") /* _HID: Hardware ID */ + Name (_HID, "INT3472") Name (_UID, 0) /* _UID: Unique ID */ Name (_DDN, "TPS68470 PMIC") /* _DDN: DOS Device Name */ Name (CAMD, 0x64) diff --git a/src/mainboard/google/poppy/variants/nautilus/include/variant/acpi/cam0.asl b/src/mainboard/google/poppy/variants/nautilus/include/variant/acpi/cam0.asl index 8d662ea..c22c580 100644 --- a/src/mainboard/google/poppy/variants/nautilus/include/variant/acpi/cam0.asl +++ b/src/mainboard/google/poppy/variants/nautilus/include/variant/acpi/cam0.asl @@ -4,7 +4,7 @@ { Device (CAM0) { - Name (_HID, "SONY258A") /* _HID: Hardware ID */ + Name (_HID, "SONY258A") Name (_UID, 0) /* _UID: Unique ID */ Name (_DDN, "SONY IMX258 Camera") /* _DDN: DOS Device Name */ @@ -72,7 +72,7 @@ Device (VCM0) { - Name (_HID, "PRP0001") /* _HID: Hardware ID */ + Name (_HID, "PRP0001") Name (_UID, 0) /* _UID: Unique ID */ Name (_DDN, "Dongwoon AF DAC") /* _DDN: DOS Device Name */ @@ -103,7 +103,7 @@ Device (NVM0) { - Name (_HID, "INT3499") /* _HID: Hardware ID */ + Name (_HID, "INT3499") Name (_UID, 0) /* _UID: Unique ID */ Name (_DDN, "Dongwoon NVM") /* _DDN: DOS Device Name */ diff --git a/src/mainboard/google/poppy/variants/nocturne/include/variant/acpi/cam0.asl b/src/mainboard/google/poppy/variants/nocturne/include/variant/acpi/cam0.asl index e5cf437..c8fda8e 100644 --- a/src/mainboard/google/poppy/variants/nocturne/include/variant/acpi/cam0.asl +++ b/src/mainboard/google/poppy/variants/nocturne/include/variant/acpi/cam0.asl @@ -40,7 +40,7 @@ Device (CAM0) { - Name (_HID, "SONY319A") /* _HID: Hardware ID */ + Name (_HID, "SONY319A") Name (_UID, 0) /* _UID: Unique ID */ Name (_DDN, "Sony IMX319 Camera") /* _DDN: DOS Device Name */ @@ -103,7 +103,7 @@ Device (NVM0) { - Name (_HID, "INT3499") /* _HID: Hardware ID */ + Name (_HID, "INT3499") Name (_UID, 0) /* _UID: Unique ID */ Name (_DDN, "M24C64S") /* _DDN: DOS Device Name */ diff --git a/src/mainboard/google/poppy/variants/nocturne/include/variant/acpi/cam1.asl b/src/mainboard/google/poppy/variants/nocturne/include/variant/acpi/cam1.asl index 8337cc5..11076e3 100644 --- a/src/mainboard/google/poppy/variants/nocturne/include/variant/acpi/cam1.asl +++ b/src/mainboard/google/poppy/variants/nocturne/include/variant/acpi/cam1.asl @@ -39,7 +39,7 @@ Device (CAM1) { - Name (_HID, "SONY355A") /* _HID: Hardware ID */ + Name (_HID, "SONY355A") Name (_UID, 0) /* _UID: Unique ID */ Name (_DDN, "SONY IMX355A Camera") /* _DDN: DOS Device Name */ @@ -105,7 +105,7 @@ Device (VCM1) { - Name (_HID, "PRP0001") /* _HID: Hardware ID */ + Name (_HID, "PRP0001") Name (_UID, 3) /* _UID: Unique ID */ Name (_DDN, "AKM AF DAC") /* _DDN: DOS Device Name */ @@ -137,7 +137,7 @@ Device (NVM1) { - Name (_HID, "INT3499") /* _HID: Hardware ID */ + Name (_HID, "INT3499") Name (_UID, 1) /* _UID: Unique ID */ Name (_DDN, "M24C64S") /* _DDN: DOS Device Name */ diff --git a/src/mainboard/google/volteer/variants/baseboard/include/baseboard/acpi/mipi_camera.asl b/src/mainboard/google/volteer/variants/baseboard/include/baseboard/acpi/mipi_camera.asl index 1efd1a2..d8685da 100644 --- a/src/mainboard/google/volteer/variants/baseboard/include/baseboard/acpi/mipi_camera.asl +++ b/src/mainboard/google/volteer/variants/baseboard/include/baseboard/acpi/mipi_camera.asl @@ -207,7 +207,7 @@ Device (CAM0) { - Name (_HID, "OVTI8856") /* _HID: Hardware ID */ + Name (_HID, "OVTI8856") Name (_UID, 0) /* _UID: Unique ID */ Name (_DDN, "Ov 8856 Camera") /* _DDN: DOS Device Name */ Method (_STA, 0, NotSerialized) /* _STA: Status */ @@ -364,7 +364,7 @@ Device (VCM0) { - Name (_HID, "PRP0001") /* _HID: Hardware ID */ + Name (_HID, "PRP0001") Name (_UID, 0x00) /* _UID: Unique ID */ Name (_DDN, "DW9768 VCM") /* _DDN: DOS Device Name */ Method (_STA, 0, NotSerialized) /* _STA: Status */ @@ -410,7 +410,7 @@ } Device (NVM0) { - Name (_HID, "PRP0001") // _HID: Hardware ID + Name (_HID, "PRP0001") Name (_UID, 0x01) // _UID: Unique ID Name (_DDN, "AT24 EEPROM") // _DDN: DOS Device Name Method (_STA, 0, NotSerialized) // _STA: Status @@ -533,7 +533,7 @@ Device (CAM1) { - Name (_HID, "INT3474") /* _HID: Hardware ID */ + Name (_HID, "INT3474") Name (_UID, 0) /* _UID: Unique ID */ Name (_DDN, "Ov 2740 Camera") /* _DDN: DOS Device Name */ Method (_STA, 0, NotSerialized) /* _STA: Status */ diff --git a/src/mainboard/google/volteer/variants/voema/include/variant/acpi/mipi_camera.asl b/src/mainboard/google/volteer/variants/voema/include/variant/acpi/mipi_camera.asl index 33c147b..290d2b6 100644 --- a/src/mainboard/google/volteer/variants/voema/include/variant/acpi/mipi_camera.asl +++ b/src/mainboard/google/volteer/variants/voema/include/variant/acpi/mipi_camera.asl @@ -157,7 +157,7 @@ Device (CAM1) { - Name (_HID, "INT3474") /* _HID: Hardware ID */ + Name (_HID, "INT3474") Name (_UID, 0) /* _UID: Unique ID */ Name (_DDN, "Ov 2740 Camera") /* _DDN: DOS Device Name */ Method (_STA, 0, NotSerialized) /* _STA: Status */ @@ -273,7 +273,7 @@ } Device (NVM0) { - Name (_HID, "PRP0001") // _HID: Hardware ID + Name (_HID, "PRP0001") Name (_UID, 0x01) // _UID: Unique ID Name (_DDN, "AT24 EEPROM") // _DDN: DOS Device Name Method (_STA, 0, NotSerialized) // _STA: Status diff --git a/src/mainboard/intel/glkrvp/touchpanel.asl b/src/mainboard/intel/glkrvp/touchpanel.asl index 8d7e435..32503b5 100644 --- a/src/mainboard/intel/glkrvp/touchpanel.asl +++ b/src/mainboard/intel/glkrvp/touchpanel.asl @@ -7,7 +7,7 @@ //------------------------ Device (TPL1) { Name (HID2, 1) - Name (_HID, "WCOM508E") // _HID: Hardware ID + Name (_HID, "WCOM508E") Name (_CID, "PNP0C50") // _CID: Compatible ID Name (_S0W, 0x04) // _S0W: S0 Device Wake State Name (SBFB, ResourceTemplate () { diff --git a/src/mainboard/intel/kblrvp/acpi/mipi_camera.asl b/src/mainboard/intel/kblrvp/acpi/mipi_camera.asl index 5434262..292e548 100644 --- a/src/mainboard/intel/kblrvp/acpi/mipi_camera.asl +++ b/src/mainboard/intel/kblrvp/acpi/mipi_camera.asl @@ -4,7 +4,7 @@ { Device (PMIC) { - Name (_HID, "INT3472") /* _HID: Hardware ID */ + Name (_HID, "INT3472") Name (_UID, 0) // _UID: Unique ID */ Name (_DDN, "TPS68470 PMIC") /* _DDN: DOS Device Name */ Name (CAMD, 0x64) @@ -369,7 +369,7 @@ Device (CAM0) { - Name (_HID, "OVTID858") /* _HID: Hardware ID */ + Name (_HID, "OVTID858") Name (_UID, 0) /* _UID: Unique ID */ Name (_DDN, "OV 13858 Camera") /* _DDN: DOS Device Name */ Name (CAMD, 0x02) @@ -474,7 +474,7 @@ Device (VCM0) { - Name (_HID, "DWDWD000") /* _HID: Hardware ID */ + Name (_HID, "DWDWD000") Name (_UID, 0) /* _UID: Unique ID */ Name (_DDN, "Dongwoon AF DAC") /* _DDN: DOS Device Name */ Name (CAMD, 0x03) @@ -502,7 +502,7 @@ { Device (PMIC) { - Name (_HID, "INT3473") /* _HID: Hardware ID */ + Name (_HID, "INT3473") Name (_UID, 0) /* _UID: Unique ID */ Name (_DDN, "TPS68470 PMIC 2") /* _DDN: DOS Device Name */ Name (CAMD, 0x64) @@ -805,7 +805,7 @@ Device (CAM1) { - Name (_HID, "INT3479") /* _HID: Hardware ID */ + Name (_HID, "INT3479") Name (_UID, 0) /* _UID: Unique ID */ Name (_DDN, "OV 5670 Camera") /* _DDN: DOS Device Name */ Name (CAMD, 0x02) diff --git a/src/mainboard/intel/tglrvp/acpi/mipi_camera.asl b/src/mainboard/intel/tglrvp/acpi/mipi_camera.asl index da4813b..8159fa7 100644 --- a/src/mainboard/intel/tglrvp/acpi/mipi_camera.asl +++ b/src/mainboard/intel/tglrvp/acpi/mipi_camera.asl @@ -198,7 +198,7 @@ Device (CAM0) { - Name (_HID, "OVTI8856") /* _HID: Hardware ID */ + Name (_HID, "OVTI8856") Name (_UID, 0) /* _UID: Unique ID */ Name (_DDN, "Ov 8856 Camera") /* _DDN: DOS Device Name */ Method (_STA, 0, NotSerialized) /* _STA: Status */ @@ -321,7 +321,7 @@ Device (VCM0) { - Name (_HID, "PRP0001") /* _HID: Hardware ID */ + Name (_HID, "PRP0001") Name (_UID, 0x03) /* _UID: Unique ID */ Name (_DDN, "DW9714 VCM") /* _DDN: DOS Device Name */ Method (_STA, 0, NotSerialized) /* _STA: Status */ @@ -421,7 +421,7 @@ Device (CAM1) { - Name (_HID, "OVTI8856") /* _HID: Hardware ID */ + Name (_HID, "OVTI8856") Name (_UID, 0) /* _UID: Unique ID */ Name (_DDN, "Ov 8856 Camera") /* _DDN: DOS Device Name */ Method (_STA, 0, NotSerialized) /* _STA: Status */ diff --git a/src/mainboard/roda/rv11/acpi/alsd.asl b/src/mainboard/roda/rv11/acpi/alsd.asl index 3b9a3ef..f01a1f0 100644 --- a/src/mainboard/roda/rv11/acpi/alsd.asl +++ b/src/mainboard/roda/rv11/acpi/alsd.asl @@ -2,7 +2,7 @@ Device (ALSD) { - Name (_HID, "ACPI0008") // _HID: Hardware ID + Name (_HID, "ACPI0008") Method (_STA, 0, NotSerialized) // _STA: Status { Return (0x0f) diff --git a/src/mainboard/starlabs/lite/acpi/touchpad.asl b/src/mainboard/starlabs/lite/acpi/touchpad.asl index cb003ae..5c9708d 100644 --- a/src/mainboard/starlabs/lite/acpi/touchpad.asl +++ b/src/mainboard/starlabs/lite/acpi/touchpad.asl @@ -4,7 +4,7 @@ { Device (H02C) { - Name (_HID, "STAR0001") // _HID: Hardware ID + Name (_HID, "STAR0001") Name (_CID, "PNP0C50" /* HID Protocol Device (I2C bus) */) // _CID: Compatible ID Name (_UID, 0x01) // _UID: Unique ID Name (_DDN, "Touchpad") // _DDN: DOS Device Name diff --git a/src/mainboard/system76/kbl-u/acpi/ac.asl b/src/mainboard/system76/kbl-u/acpi/ac.asl index b417e03..7bf3a37 100644 --- a/src/mainboard/system76/kbl-u/acpi/ac.asl +++ b/src/mainboard/system76/kbl-u/acpi/ac.asl @@ -2,7 +2,7 @@ Device (AC) { - Name (_HID, "ACPI0003" /* Power Source Device */) // _HID: Hardware ID + Name (_HID, "ACPI0003" /* Power Source Device */) Name (_PCL, Package (0x01) // _PCL: Power Consumer List { _SB diff --git a/src/mainboard/system76/kbl-u/acpi/battery.asl b/src/mainboard/system76/kbl-u/acpi/battery.asl index 48cd4f1..a3287e3 100644 --- a/src/mainboard/system76/kbl-u/acpi/battery.asl +++ b/src/mainboard/system76/kbl-u/acpi/battery.asl @@ -2,7 +2,7 @@ Device (BAT0) { - Name (_HID, EisaId ("PNP0C0A") /* Control Method Battery */) // _HID: Hardware ID + Name (_HID, EisaId ("PNP0C0A") /* Control Method Battery */) Name (_UID, 0) // _UID: Unique ID Name (_PCL, Package (0x01) // _PCL: Power Consumer List { diff --git a/src/mainboard/system76/kbl-u/acpi/ec.asl b/src/mainboard/system76/kbl-u/acpi/ec.asl index 0899eb0..e76b228 100644 --- a/src/mainboard/system76/kbl-u/acpi/ec.asl +++ b/src/mainboard/system76/kbl-u/acpi/ec.asl @@ -2,7 +2,7 @@ Device (EC0) { - Name (_HID, EisaId ("PNP0C09") /* Embedded Controller Device */) // _HID: Hardware ID + Name (_HID, EisaId ("PNP0C09") /* Embedded Controller Device */) Name (_GPE, 0x50 /* GPP_E16 */) // _GPE: General Purpose Events Name (_CRS, ResourceTemplate () // _CRS: Current Resource Settings { diff --git a/src/soc/intel/common/block/acpi/acpi/northbridge.asl b/src/soc/intel/common/block/acpi/acpi/northbridge.asl index 4ef151f..b0d0ca8 100644 --- a/src/soc/intel/common/block/acpi/acpi/northbridge.asl +++ b/src/soc/intel/common/block/acpi/acpi/northbridge.asl @@ -3,7 +3,7 @@ #include <arch/hpet.h> #include <soc/iomap.h> -Name (_HID, EisaId ("PNP0A08") /* PCI Express Bus */) // _HID: Hardware ID +Name (_HID, EisaId ("PNP0A08") /* PCI Express Bus */) Name (_CID, EisaId ("PNP0A03") /* PCI Bus */) // _CID: Compatible ID Name (_SEG, 0) // _SEG: PCI Segment Name (_UID, 0) // _UID: Unique ID diff --git a/src/soc/intel/skylake/acpi/systemagent.asl b/src/soc/intel/skylake/acpi/systemagent.asl index 5a15ac5..9c332c4 100644 --- a/src/soc/intel/skylake/acpi/systemagent.asl +++ b/src/soc/intel/skylake/acpi/systemagent.asl @@ -3,7 +3,7 @@ #include <arch/hpet.h> #include <soc/iomap.h> -Name (_HID, EisaId ("PNP0A08") /* PCI Express Bus */) // _HID: Hardware ID +Name (_HID, EisaId ("PNP0A08") /* PCI Express Bus */) Name (_CID, EisaId ("PNP0A03") /* PCI Bus */) // _CID: Compatible ID Name (_SEG, 0) // _SEG: PCI Segment Name (_UID, 0) // _UID: Unique ID diff --git a/src/superio/winbond/w83977tf/acpi/superio.asl b/src/superio/winbond/w83977tf/acpi/superio.asl index eda6744..76ae692 100644 --- a/src/superio/winbond/w83977tf/acpi/superio.asl +++ b/src/superio/winbond/w83977tf/acpi/superio.asl @@ -89,7 +89,7 @@ #ifdef SUPERIO_SHOW_FDC Device (FDC0) { - Name (_HID, EisaId ("PNP0700")) // _HID: Hardware ID + Name (_HID, EisaId ("PNP0700")) Method (_STA, 0, NotSerialized) // _STA: Status { PNP_GENERIC_STA(W83977TF_FDC) -- To view, visit https://review.coreboot.org/c/coreboot/+/72661 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5eb1424e9e6c1fbf20cd0bf68fbb52e1ec97f905 Gerrit-Change-Number: 72661 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-MessageType: newchange

1 0

[S] Change in coreboot[master]: mb/google/rex: update touchscreen report EN pin setting
by Kapil Porwal (Code Review) 02 Feb '23

02 Feb '23

Attention is currently required from: Tarun Tuli, Ivy Jian. Kapil Porwal has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/72725 ) Change subject: mb/google/rex: update touchscreen report EN pin setting ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/72725 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I19629262776f7e0cccbdebb2285890d177a8a8a6 Gerrit-Change-Number: 72725 Gerrit-PatchSet: 1 Gerrit-Owner: Ivy Jian <ivy.jian(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Ivy Jian <ivy.jian(a)quanta.corp-partner.google.com> Gerrit-Comment-Date: Thu, 02 Feb 2023 07:18:36 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XL] Change in coreboot[master]: soc/intel/xeon_sp/spr: add ACPI code
by Patrick Rudolph (Code Review) 02 Feb '23

02 Feb '23

Attention is currently required from: Jonathan Zhang, Simon Chou, TimLiu-SMCI, Johnny Lin, Christian Walter, Shuming Chu (Shuming), Arthur Heymans. Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71967 ) Change subject: soc/intel/xeon_sp/spr: add ACPI code ...................................................................... Patch Set 13: (1 comment) File src/soc/intel/xeon_sp/spr/soc_acpi.c: https://review.coreboot.org/c/coreboot/+/71967/comment/9d68be0f_00963f2d PS13, Line 387: for (uint8_t socket = 0; socket < hob->PlatformData.numofIIO; ++socket) { > Got you. I think we should use hob->PlatformData. […] it's fine to generate the DSDT from CONFIG_MAX_SOCKET as long as the SSDT is 1) generating all the resources consumed by DSDT 2) setting _STA and _CRS to 0 for all unpopulated devices/sockets -- To view, visit https://review.coreboot.org/c/coreboot/+/71967 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic2a9be0222e122ae087b9cc8e1859d257e3411d6 Gerrit-Change-Number: 71967 Gerrit-PatchSet: 13 Gerrit-Owner: Simon Chou <simonchou(a)supermicro.com.tw> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Jian-Ming Wang <jianmingW(a)supermicro.com> Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Reviewer: TimLiu-SMCI Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-CC: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-CC: Shuming Chu (Shuming) <s1218944(a)gmail.com> Gerrit-CC: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Attention: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Attention: Simon Chou <simonchou(a)supermicro.com.tw> Gerrit-Attention: TimLiu-SMCI Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Shuming Chu (Shuming) <s1218944(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Thu, 02 Feb 2023 07:16:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Patrick Rudolph <patrick.rudolph(a)9elements.com> Comment-In-Reply-To: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: nb/intel/{sandybridge,haswell}: Generate IOAPIC DMAR entries from hw
by Arthur Heymans (Code Review) 02 Feb '23

02 Feb '23

Arthur Heymans has submitted this change. ( https://review.coreboot.org/c/coreboot/+/72513 ) Change subject: nb/intel/{sandybridge,haswell}: Generate IOAPIC DMAR entries from hw ...................................................................... nb/intel/{sandybridge,haswell}: Generate IOAPIC DMAR entries from hw Use acpi_create_dmar_ds_ioapic_from_hw() to generate DMAR entries. This can restore s3 resume capability for Sandy Bridge platforms lost after commit d165357ec37c ("sb,soc/intel: Use register_new_ioapic_gsi0()"). Signed-off-by: Bill XIE <persmule(a)hardenedlinux.org> Change-Id: I83e735707cd9ff30aa339443593239cd7e3e4656 Reviewed-on: https://review.coreboot.org/c/coreboot/+/72513 Reviewed-by: Nico Huber <nico.h(a)gmx.de> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M src/northbridge/intel/haswell/acpi.c M src/northbridge/intel/sandybridge/acpi.c 2 files changed, 28 insertions(+), 4 deletions(-) Approvals: build bot (Jenkins): Verified Nico Huber: Looks good to me, but someone else must approve Arthur Heymans: Looks good to me, approved diff --git a/src/northbridge/intel/haswell/acpi.c b/src/northbridge/intel/haswell/acpi.c index 290dc1e..8d179aa 100644 --- a/src/northbridge/intel/haswell/acpi.c +++ b/src/northbridge/intel/haswell/acpi.c @@ -4,6 +4,7 @@ #include <console/console.h> #include <commonlib/helpers.h> #include <acpi/acpi.h> +#include <arch/ioapic.h> #include <device/device.h> #include <device/pci_ops.h> #include "haswell.h" @@ -38,8 +39,9 @@ const unsigned long tmp = current; current += acpi_create_dmar_drhd(current, DRHD_INCLUDE_PCI_ALL, 0, vtvc0bar); - current += acpi_create_dmar_ds_ioapic(current, 2, PCH_IOAPIC_PCI_BUS, - PCH_IOAPIC_PCI_SLOT, 0); + current += acpi_create_dmar_ds_ioapic_from_hw(current, IO_APIC_ADDR, + PCH_IOAPIC_PCI_BUS, + PCH_IOAPIC_PCI_SLOT, 0); size_t i; for (i = 0; i < 8; ++i) diff --git a/src/northbridge/intel/sandybridge/acpi.c b/src/northbridge/intel/sandybridge/acpi.c index c2f6eae..8be161e 100644 --- a/src/northbridge/intel/sandybridge/acpi.c +++ b/src/northbridge/intel/sandybridge/acpi.c @@ -4,6 +4,7 @@ #include <console/console.h> #include <commonlib/helpers.h> #include <acpi/acpi.h> +#include <arch/ioapic.h> #include <device/device.h> #include <device/pci_ops.h> #include "sandybridge.h" @@ -42,8 +43,9 @@ const unsigned long tmp = current; current += acpi_create_dmar_drhd(current, DRHD_INCLUDE_PCI_ALL, 0, VTVC0_BASE); - current += acpi_create_dmar_ds_ioapic(current, 2, PCH_IOAPIC_PCI_BUS, - PCH_IOAPIC_PCI_SLOT, 0); + current += acpi_create_dmar_ds_ioapic_from_hw(current, IO_APIC_ADDR, + PCH_IOAPIC_PCI_BUS, + PCH_IOAPIC_PCI_SLOT, 0); size_t i; for (i = 0; i < 8; ++i) -- To view, visit https://review.coreboot.org/c/coreboot/+/72513 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I83e735707cd9ff30aa339443593239cd7e3e4656 Gerrit-Change-Number: 72513 Gerrit-PatchSet: 7 Gerrit-Owner: Bill XIE <persmule(a)hardenedlinux.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit February 2023