coreboot-gerrit February 2023

coreboot-gerrit@coreboot.org

1 participants
5082 discussions

[M] Change in coreboot[master]: amdfwtool: Allow the location to be a relative address
by Fred Reitberger (Code Review) 02 Feb '23

02 Feb '23

Attention is currently required from: Bao Zheng, ritul guru, Zheng Bao. Fred Reitberger has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69856 ) Change subject: amdfwtool: Allow the location to be a relative address ...................................................................... Patch Set 16: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/69856 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4308ec9ea05a87329aba0b409508c79ebf42325c Gerrit-Change-Number: 69856 Gerrit-PatchSet: 16 Gerrit-Owner: Bao Zheng <fishbaozi(a)gmail.com> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Zheng Bao Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-CC: ritul guru <ritul.bits(a)gmail.com> Gerrit-Attention: Bao Zheng <fishbaozi(a)gmail.com> Gerrit-Attention: ritul guru <ritul.bits(a)gmail.com> Gerrit-Attention: Zheng Bao Gerrit-Comment-Date: Thu, 02 Feb 2023 12:26:49 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/google/brya: Create constitution variant
by Morris Hsu (Code Review) 02 Feb '23

02 Feb '23

Attention is currently required from: Tarun Tuli. Morris Hsu has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/72730 ) Change subject: mb/google/brya: Create constitution variant ...................................................................... mb/google/brya: Create constitution variant Create the constitution variant of the brask reference board by copying the template files to a new directory named for the variant. (Auto-Generated by create_coreboot_variant.sh version 4.5.0). BUG=b:267539938 TEST=util/abuild/abuild -p none -t google/brya -x -a make sure the build includes GOOGLE_CONSTITUTION Change-Id: Idb6089561d3aa5aac4448f9d46347c731f027e9c Signed-off-by: Morris Hsu <morris-hsu(a)quanta.corp-partner.google.com> --- M src/mainboard/google/brya/Kconfig M src/mainboard/google/brya/Kconfig.name A src/mainboard/google/brya/variants/constitution/include/variant/ec.h A src/mainboard/google/brya/variants/constitution/include/variant/gpio.h A src/mainboard/google/brya/variants/constitution/overridetree.cb 5 files changed, 48 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/30/72730/1 diff --git a/src/mainboard/google/brya/Kconfig b/src/mainboard/google/brya/Kconfig index dad9821..c947ce8 100644 --- a/src/mainboard/google/brya/Kconfig +++ b/src/mainboard/google/brya/Kconfig @@ -155,6 +155,7 @@ default 0x1 if BOARD_GOOGLE_MARASOV default 0x1 if BOARD_GOOGLE_GAELIN default 0x1 if BOARD_GOOGLE_OMNIGUL + default 0x1 if BOARD_GOOGLE_CONSTITUTION config DRIVER_TPM_I2C_ADDR hex @@ -225,6 +226,7 @@ default "Gladios" if BOARD_GOOGLE_GLADIOS default "Marasov" if BOARD_GOOGLE_MARASOV default "Omnigul" if BOARD_GOOGLE_OMNIGUL + default "Constitution" if BOARD_GOOGLE_CONSTITUTION config VARIANT_DIR default "brya0" if BOARD_GOOGLE_BRYA0 @@ -267,6 +269,7 @@ default "gladios" if BOARD_GOOGLE_GLADIOS default "marasov" if BOARD_GOOGLE_MARASOV default "omnigul" if BOARD_GOOGLE_OMNIGUL + default "constitution" if BOARD_GOOGLE_CONSTITUTION config VBOOT select VBOOT_EARLY_EC_SYNC if !BOARD_GOOGLE_BASEBOARD_NISSA diff --git a/src/mainboard/google/brya/Kconfig.name b/src/mainboard/google/brya/Kconfig.name index 7b980e7..5c393b7 100644 --- a/src/mainboard/google/brya/Kconfig.name +++ b/src/mainboard/google/brya/Kconfig.name @@ -331,3 +331,7 @@ select BOARD_GOOGLE_BASEBOARD_BRYA select SOC_INTEL_RAPTORLAKE select USE_UNIFIED_AP_FIRMWARE_FOR_UFS_AND_NON_UFS + +config BOARD_GOOGLE_CONSTITUTION + bool "-> Constitution" + select BOARD_GOOGLE_BASEBOARD_BRASK diff --git a/src/mainboard/google/brya/variants/constitution/include/variant/ec.h b/src/mainboard/google/brya/variants/constitution/include/variant/ec.h new file mode 100644 index 0000000..7a2a6ff --- /dev/null +++ b/src/mainboard/google/brya/variants/constitution/include/variant/ec.h @@ -0,0 +1,8 @@ +/* SPDX-License-Identifier: GPL-2.0-or-later */ + +#ifndef __VARIANT_EC_H__ +#define __VARIANT_EC_H__ + +#include <baseboard/ec.h> + +#endif diff --git a/src/mainboard/google/brya/variants/constitution/include/variant/gpio.h b/src/mainboard/google/brya/variants/constitution/include/variant/gpio.h new file mode 100644 index 0000000..c4fe342 --- /dev/null +++ b/src/mainboard/google/brya/variants/constitution/include/variant/gpio.h @@ -0,0 +1,8 @@ +/* SPDX-License-Identifier: GPL-2.0-or-later */ + +#ifndef VARIANT_GPIO_H +#define VARIANT_GPIO_H + +#include <baseboard/gpio.h> + +#endif diff --git a/src/mainboard/google/brya/variants/constitution/overridetree.cb b/src/mainboard/google/brya/variants/constitution/overridetree.cb new file mode 100644 index 0000000..4f2c04a --- /dev/null +++ b/src/mainboard/google/brya/variants/constitution/overridetree.cb @@ -0,0 +1,6 @@ +chip soc/intel/alderlake + + device domain 0 on + end + +end -- To view, visit https://review.coreboot.org/c/coreboot/+/72730 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Idb6089561d3aa5aac4448f9d46347c731f027e9c Gerrit-Change-Number: 72730 Gerrit-PatchSet: 1 Gerrit-Owner: Morris Hsu <morris-hsu(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-MessageType: newchange

1 0

[S] Change in coreboot[master]: test
by Morris Hsu (Code Review) 02 Feb '23

02 Feb '23

Morris Hsu has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/72729 ) Change subject: test ...................................................................... test Change-Id: I88ee8f380513bc6490c9f84f3e41cb044f9a3afb --- M 3rdparty/amd_blobs M 3rdparty/blobs M 3rdparty/intel-microcode M 3rdparty/libgfxinit M 3rdparty/libhwbase 5 files changed, 14 insertions(+), 5 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/29/72729/1 diff --git a/3rdparty/amd_blobs b/3rdparty/amd_blobs index acf7395..5cc1532 160000 --- a/3rdparty/amd_blobs +++ b/3rdparty/amd_blobs @@ -1 +1 @@ -Subproject commit acf7395452de0c17743068e0bb27d9f53eff9aa0 +Subproject commit 5cc15323c0a35e35df2bdddfe2699d5940ff7dde diff --git a/3rdparty/blobs b/3rdparty/blobs index 01ba156..e82e4b6 160000 --- a/3rdparty/blobs +++ b/3rdparty/blobs @@ -1 +1 @@ -Subproject commit 01ba15667f34793580f5edd0de1e26b7a542cac6 +Subproject commit e82e4b618beaae56f56da9311a8e4f61b6a046f8 diff --git a/3rdparty/intel-microcode b/3rdparty/intel-microcode index 262f0c9..ee319ae 160000 --- a/3rdparty/intel-microcode +++ b/3rdparty/intel-microcode @@ -1 +1 @@ -Subproject commit 262f0c97f2fbc3839a59523cc6c6bcf500e2850b +Subproject commit ee319ae7bc59e88b60142f40a9ec1b46656de4db diff --git a/3rdparty/libgfxinit b/3rdparty/libgfxinit index 066e52e..31042e8 160000 --- a/3rdparty/libgfxinit +++ b/3rdparty/libgfxinit @@ -1 +1 @@ -Subproject commit 066e52eeaa329d782ccee96265a6a351fc395bf1 +Subproject commit 31042e8cb3dd2e1fbc56cd1e07b41c00c37e33c6 diff --git a/3rdparty/libhwbase b/3rdparty/libhwbase index 8be5a82..5ec3927 160000 --- a/3rdparty/libhwbase +++ b/3rdparty/libhwbase @@ -1 +1 @@ -Subproject commit 8be5a82b85ceb3ee8a1c4fbf36c75a4bfbda8900 +Subproject commit 5ec392755dad0644817a72d1d9a379171012b89d -- To view, visit https://review.coreboot.org/c/coreboot/+/72729 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I88ee8f380513bc6490c9f84f3e41cb044f9a3afb Gerrit-Change-Number: 72729 Gerrit-PatchSet: 1 Gerrit-Owner: Morris Hsu <morris-hsu(a)quanta.corp-partner.google.com> Gerrit-MessageType: newchange

1 0

[S] Change in coreboot[master]: treewide: Remove unuseful "_ADR: Address" comment
by Sridhar Siricilla (Code Review) 02 Feb '23

02 Feb '23

Attention is currently required from: Michał Żygowski, Elyes Haouas, Piotr Król. Sridhar Siricilla has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/72664 ) Change subject: treewide: Remove unuseful "_ADR: Address" comment ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/72664 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib968fe7f9f95e8f690b46b868fd7d6f9332b4c9a Gerrit-Change-Number: 72664 Gerrit-PatchSet: 3 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Piotr Król <piotr.krol(a)3mdeb.com> Gerrit-Reviewer: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Attention: Piotr Król <piotr.krol(a)3mdeb.com> Gerrit-Comment-Date: Thu, 02 Feb 2023 11:39:41 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: soc/intel/meteorlake: Enable V1p05-PHY supply external FET control
by Sridhar Siricilla (Code Review) 02 Feb '23

02 Feb '23

Sridhar Siricilla has submitted this change. ( https://review.coreboot.org/c/coreboot/+/72709 ) Change subject: soc/intel/meteorlake: Enable V1p05-PHY supply external FET control ...................................................................... soc/intel/meteorlake: Enable V1p05-PHY supply external FET control This patch enables S0i2.2 by letting 1.5V Phy supply to control the externa FET. BUG=b:256805904 Signed-off-by: Subrata Banik <subratabanik(a)google.com> Change-Id: I8771c11ce3b305343c7e96510e1375538d5e7f04 Reviewed-on: https://review.coreboot.org/c/coreboot/+/72709 Reviewed-by: Tarun Tuli <taruntuli(a)google.com> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Sukumar Ghorai <sukumar.ghorai(a)intel.com> Reviewed-by: Sridhar Siricilla <sridhar.siricilla(a)intel.com> --- M src/soc/intel/meteorlake/fsp_params.c 1 file changed, 21 insertions(+), 0 deletions(-) Approvals: build bot (Jenkins): Verified Sridhar Siricilla: Looks good to me, approved Sukumar Ghorai: Looks good to me, but someone else must approve Tarun Tuli: Looks good to me, approved diff --git a/src/soc/intel/meteorlake/fsp_params.c b/src/soc/intel/meteorlake/fsp_params.c index e850eaa..f8d3f6e 100644 --- a/src/soc/intel/meteorlake/fsp_params.c +++ b/src/soc/intel/meteorlake/fsp_params.c @@ -643,6 +643,7 @@ s_cfg->EnergyEfficientTurbo = 1; s_cfg->PmcLpmS0ixSubStateEnableMask = get_supported_lpm_mask(); s_cfg->PkgCStateDemotion = !config->disable_package_c_state_demotion; + s_cfg->PmcV1p05PhyExtFetControlEn = 1; } -- To view, visit https://review.coreboot.org/c/coreboot/+/72709 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8771c11ce3b305343c7e96510e1375538d5e7f04 Gerrit-Change-Number: 72709 Gerrit-PatchSet: 3 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-Reviewer: Sukumar Ghorai <sukumar.ghorai(a)intel.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[S] Change in coreboot[master]: soc/intel/meteorlake: Enable V1p05-PHY supply external FET control
by Sridhar Siricilla (Code Review) 02 Feb '23

02 Feb '23

Attention is currently required from: Subrata Banik, Kapil Porwal, Sukumar Ghorai. Sridhar Siricilla has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/72709 ) Change subject: soc/intel/meteorlake: Enable V1p05-PHY supply external FET control ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/72709 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8771c11ce3b305343c7e96510e1375538d5e7f04 Gerrit-Change-Number: 72709 Gerrit-PatchSet: 2 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-Reviewer: Sukumar Ghorai <sukumar.ghorai(a)intel.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Sukumar Ghorai <sukumar.ghorai(a)intel.com> Gerrit-Comment-Date: Thu, 02 Feb 2023 11:38:20 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: security/tpm/tss/tcg-2.0: Add `tlcl_read_public()`
by Yi Chou (Code Review) 02 Feb '23

02 Feb '23

Attention is currently required from: Andrey Pronin, Paul Menzel, Christian Walter, Yu-Ping Wu. Yi Chou has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71885 ) Change subject: security/tpm/tss/tcg-2.0: Add `tlcl_read_public()` ...................................................................... Patch Set 3: (6 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/71885/comment/35983642_62cf3801 PS2, Line 10: and > an? Done File src/security/tpm/tss.h: https://review.coreboot.org/c/coreboot/+/71885/comment/3ef42c22_f00a8595 PS2, Line 84: /** > /* Done File src/security/tpm/tss/tcg-2.0/tss.c: https://review.coreboot.org/c/coreboot/+/71885/comment/0c85d706_167f53d1 PS2, Line 504: /* Unknown handle, returned if the key doesn't exist. */ > Is this comment for which switch case? Done File src/security/tpm/tss/tcg-2.0/tss_marshaling.c: https://review.coreboot.org/c/coreboot/+/71885/comment/2718d236_7ae9ffee PS2, Line 550: "%s:%d - " : "size mismatch: expected %d, remaining %zd\n", > Can fit in one line. Done File src/security/tpm/tss/tcg-2.0/tss_structures.h: https://review.coreboot.org/c/coreboot/+/71885/comment/ba137266_056759cd PS2, Line 149: RC_VER1 > `RC_FMT1` Done https://review.coreboot.org/c/coreboot/+/71885/comment/33a305ee_ded6e437 PS2, Line 328: uint16_t size; > Is there a need to use a fixed-length data type, or could it be `unsigned int`? The TPM2 spec said the type of size in TPM2B struct is `UINT16`. https://trustedcomputinggroup.org/wp-content/uploads/TCG_TPM2_r1p59_Part2_S… -- To view, visit https://review.coreboot.org/c/coreboot/+/71885 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I79455b3ee73c265a9e4bf3d8b9c6562490efbf1c Gerrit-Change-Number: 71885 Gerrit-PatchSet: 3 Gerrit-Owner: Yi Chou <yich(a)google.com> Gerrit-Reviewer: Andrey Pronin <apronin(a)google.com> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Andrey Pronin <apronin(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Comment-Date: Thu, 02 Feb 2023 11:28:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Comment-In-Reply-To: Yi Chou <yich(a)google.com> Comment-In-Reply-To: Yu-Ping Wu <yupingso(a)google.com> Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: security/tpm/tss/tcg-2.0: Add `tlcl_read_public()`
by build bot (Jenkins) (Code Review) 02 Feb '23

02 Feb '23

Attention is currently required from: Andrey Pronin, Christian Walter. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71885 ) Change subject: security/tpm/tss/tcg-2.0: Add `tlcl_read_public()` ...................................................................... Patch Set 3: (2 comments) File src/security/tpm/tss/tcg-2.0/tss_structures.h: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169722): https://review.coreboot.org/c/coreboot/+/71885/comment/a10b2222_887d7b64 PS3, Line 102: #define TPM_RC_HANDLE (TPM_RC)(RC_FMT1 + 0x00B) Macros with complex values should be enclosed in parentheses Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169722): https://review.coreboot.org/c/coreboot/+/71885/comment/3e949474_96abc141 PS3, Line 105: #define TPM_RC_1 (TPM_RC)(0x001) Macros with complex values should be enclosed in parentheses -- To view, visit https://review.coreboot.org/c/coreboot/+/71885 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I79455b3ee73c265a9e4bf3d8b9c6562490efbf1c Gerrit-Change-Number: 71885 Gerrit-PatchSet: 3 Gerrit-Owner: Yi Chou <yich(a)google.com> Gerrit-Reviewer: Andrey Pronin <apronin(a)google.com> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Andrey Pronin <apronin(a)google.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Comment-Date: Thu, 02 Feb 2023 11:24:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: treewide: Remove unuseful "_ADR: Address" comment
by Elyes Haouas (Code Review) 02 Feb '23

02 Feb '23

Attention is currently required from: Michał Żygowski, Piotr Król. Hello Michał Żygowski, Piotr Król, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/72664 to look at the new patch set (#3). Change subject: treewide: Remove unuseful "_ADR: Address" comment ...................................................................... treewide: Remove unuseful "_ADR: Address" comment Change-Id: Ib968fe7f9f95e8f690b46b868fd7d6f9332b4c9a Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> --- M src/mainboard/asus/p8x7x-series/variants/p8c_ws/pci.asl M src/mainboard/gigabyte/ga-b75m-d3h/acpi/pci.asl M src/mainboard/google/cyan/dsdt.asl M src/mainboard/hp/z220_series/acpi/pci.asl M src/mainboard/intel/strago/dsdt.asl M src/mainboard/protectli/vault_bsw/dsdt.asl M src/mainboard/supermicro/x9sae/acpi/pci.asl M src/soc/intel/braswell/acpi/scc.asl M src/soc/intel/common/block/acpi/acpi/ufs.asl M src/southbridge/intel/i82371eb/acpi/i82371eb.asl 10 files changed, 19 insertions(+), 10 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/64/72664/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/72664 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib968fe7f9f95e8f690b46b868fd7d6f9332b4c9a Gerrit-Change-Number: 72664 Gerrit-PatchSet: 3 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Piotr Król <piotr.krol(a)3mdeb.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Piotr Król <piotr.krol(a)3mdeb.com> Gerrit-MessageType: newpatchset

1 0

[M] Change in coreboot[master]: treewide: Remove unuseful "_UID: Unique ID" comment
by Elyes Haouas (Code Review) 02 Feb '23

02 Feb '23

Attention is currently required from: Tim Crawford, Sean Rhodes, Jeremy Soller, Nick Vaccaro. Hello Tim Crawford, Sean Rhodes, Jeremy Soller, Nick Vaccaro, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/72663 to look at the new patch set (#3). Change subject: treewide: Remove unuseful "_UID: Unique ID" comment ...................................................................... treewide: Remove unuseful "_UID: Unique ID" comment Change-Id: I150a4ed94bcaead6eb45f1c4b4952ae6957e0940 Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> --- M src/ec/purism/librem-ec/acpi/battery.asl M src/ec/system76/ec/acpi/battery.asl M src/mainboard/acer/aspire_vn7_572g/acpi/battery.asl M src/mainboard/google/poppy/variants/atlas/include/variant/acpi/cam0.asl M src/mainboard/google/poppy/variants/baseboard/include/baseboard/acpi/cam0.asl M src/mainboard/google/poppy/variants/baseboard/include/baseboard/acpi/cam1.asl M src/mainboard/google/poppy/variants/baseboard/include/baseboard/acpi/camera_pmic.asl M src/mainboard/google/poppy/variants/nautilus/include/variant/acpi/cam0.asl M src/mainboard/google/poppy/variants/nocturne/include/variant/acpi/cam0.asl M src/mainboard/google/poppy/variants/nocturne/include/variant/acpi/cam1.asl M src/mainboard/google/volteer/variants/baseboard/include/baseboard/acpi/mipi_camera.asl M src/mainboard/google/volteer/variants/voema/include/variant/acpi/mipi_camera.asl M src/mainboard/intel/kblrvp/acpi/mipi_camera.asl M src/mainboard/intel/tglrvp/acpi/mipi_camera.asl M src/mainboard/starlabs/lite/acpi/touchpad.asl M src/mainboard/system76/kbl-u/acpi/battery.asl M src/soc/intel/common/block/acpi/acpi/northbridge.asl M src/soc/intel/skylake/acpi/systemagent.asl 18 files changed, 46 insertions(+), 36 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/63/72663/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/72663 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I150a4ed94bcaead6eb45f1c4b4952ae6957e0940 Gerrit-Change-Number: 72663 Gerrit-PatchSet: 3 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Jeremy Soller <jeremy(a)system76.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Tim Crawford <tcrawford(a)system76.com> Gerrit-Attention: Tim Crawford <tcrawford(a)system76.com> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Attention: Jeremy Soller <jeremy(a)system76.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-MessageType: newpatchset

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit February 2023