coreboot-gerrit February 2023

coreboot-gerrit@coreboot.org

1 participants
5082 discussions

[XL] Change in coreboot[master]: soc/intel/xeon_sp: Rename nb_acpi.c and add SPR-SP support
by build bot (Jenkins) (Code Review) 02 Feb '23

02 Feb '23

Attention is currently required from: TimLiu-SMCI, Jonathan Zhang, Johnny Lin, Christian Walter, Jian-Ming Wang, Shelly Chang. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71958 ) Change subject: soc/intel/xeon_sp: Rename nb_acpi.c and add SPR-SP support ...................................................................... Patch Set 7: (3 comments) File src/soc/intel/xeon_sp/uncore_acpi.c: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169712): https://review.coreboot.org/c/coreboot/+/71958/comment/ca4aafe5_9db4c2fb PS7, Line 139: dev = (pds.pds[i].device_handle >> 15 ) & 0x1f; space prohibited before that close parenthesis ')' Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169712): https://review.coreboot.org/c/coreboot/+/71958/comment/a9bd3e31_fe8fa3dd PS7, Line 140: func = (pds.pds[i].device_handle >> 12 ) & 0x07; space prohibited before that close parenthesis ')' Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169712): https://review.coreboot.org/c/coreboot/+/71958/comment/f828ec83_234a2ef9 PS7, Line 527: if (pciexp_find_extended_cap(dev, PCIE_EXT_CAP_ID_ATS, 0)) { Too many leading tabs - consider code refactoring -- To view, visit https://review.coreboot.org/c/coreboot/+/71958 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4c436a60743bee21b3b6e4060d7874a6cdc75ecf Gerrit-Change-Number: 71958 Gerrit-PatchSet: 7 Gerrit-Owner: Simon Chou <simonchou(a)supermicro.com.tw> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Jian-Ming Wang <jianmingW(a)supermicro.com> Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Reviewer: Shelly Chang <Shelly_Chang(a)wiwynn.com> Gerrit-Reviewer: TimLiu-SMCI <timliu(a)supermicro.com.tw> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Attention: TimLiu-SMCI <timliu(a)supermicro.com.tw> Gerrit-Attention: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Jian-Ming Wang <jianmingW(a)supermicro.com> Gerrit-Attention: Shelly Chang <Shelly_Chang(a)wiwynn.com> Gerrit-Comment-Date: Thu, 02 Feb 2023 09:45:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: soc/intel/xeon_sp/Makefile.inc: Update makefile for spr
by Johnny Lin (Code Review) 02 Feb '23

02 Feb '23

Attention is currently required from: TimLiu-SMCI, Johnny Lin, Christian Walter, Jian-Ming Wang, Arthur Heymans. Johnny Lin has uploaded a new patch set (#7) to the change originally created by Simon Chou. ( https://review.coreboot.org/c/coreboot/+/71959 ) Change subject: soc/intel/xeon_sp/Makefile.inc: Update makefile for spr ...................................................................... soc/intel/xeon_sp/Makefile.inc: Update makefile for spr Intel SPR-SP chipset has EBG instead of LBG. Signed-off-by: Tim Chu <Tim.Chu(a)quantatw.com> Signed-off-by: Johnny Lin <johnny_lin(a)wiwynn.com> Change-Id: I9429fe332bb5f01a41aa205c76ad9f0159f93eee --- M src/soc/intel/xeon_sp/Makefile.inc 1 file changed, 14 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/59/71959/7 -- To view, visit https://review.coreboot.org/c/coreboot/+/71959 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9429fe332bb5f01a41aa205c76ad9f0159f93eee Gerrit-Change-Number: 71959 Gerrit-PatchSet: 7 Gerrit-Owner: Simon Chou <simonchou(a)supermicro.com.tw> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Jian-Ming Wang <jianmingW(a)supermicro.com> Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Reviewer: TimLiu-SMCI <timliu(a)supermicro.com.tw> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Attention: TimLiu-SMCI <timliu(a)supermicro.com.tw> Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Jian-Ming Wang <jianmingW(a)supermicro.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-MessageType: newpatchset

1 0

[XL] Change in coreboot[master]: soc/intel/xeon_sp: Rename nb_acpi.c and add SPR-SP support
by Johnny Lin (Code Review) 02 Feb '23

02 Feb '23

Attention is currently required from: TimLiu-SMCI, Jonathan Zhang, Johnny Lin, Christian Walter, Jian-Ming Wang, Shelly Chang. Johnny Lin has uploaded a new patch set (#7) to the change originally created by Simon Chou. ( https://review.coreboot.org/c/coreboot/+/71958 ) Change subject: soc/intel/xeon_sp: Rename nb_acpi.c and add SPR-SP support ...................................................................... soc/intel/xeon_sp: Rename nb_acpi.c and add SPR-SP support Add support for Intel SPR-SP to nb_acpi.c and rename to uncore_acpi.c. Signed-off-by: Tim Chu <Tim.Chu(a)quantatw.com> Signed-off-by: Johnny Lin <johnny_lin(a)wiwynn.com> Signed-off-by: Shelly Chang <Shelly_Chang(a)wiwynn.com> Change-Id: I4c436a60743bee21b3b6e4060d7874a6cdc75ecf --- M src/soc/intel/xeon_sp/Makefile.inc M src/soc/intel/xeon_sp/include/soc/acpi.h D src/soc/intel/xeon_sp/nb_acpi.c A src/soc/intel/xeon_sp/uncore_acpi.c M src/vendorcode/intel/fsp/fsp2_0/cooperlake_sp/hob_iiouds.h M src/vendorcode/intel/fsp/fsp2_0/skylake_sp/FspmUpd.h 6 files changed, 673 insertions(+), 455 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/58/71958/7 -- To view, visit https://review.coreboot.org/c/coreboot/+/71958 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4c436a60743bee21b3b6e4060d7874a6cdc75ecf Gerrit-Change-Number: 71958 Gerrit-PatchSet: 7 Gerrit-Owner: Simon Chou <simonchou(a)supermicro.com.tw> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Jian-Ming Wang <jianmingW(a)supermicro.com> Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Reviewer: Shelly Chang <Shelly_Chang(a)wiwynn.com> Gerrit-Reviewer: TimLiu-SMCI <timliu(a)supermicro.com.tw> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Attention: TimLiu-SMCI <timliu(a)supermicro.com.tw> Gerrit-Attention: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Jian-Ming Wang <jianmingW(a)supermicro.com> Gerrit-Attention: Shelly Chang <Shelly_Chang(a)wiwynn.com> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: mb/google/brya/var/marasov: Turn off camera power during S0ix
by Subrata Banik (Code Review) 02 Feb '23

02 Feb '23

Attention is currently required from: Tarun Tuli, Frank Chu, Paul Menzel, Eric Lai. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/72089 ) Change subject: mb/google/brya/var/marasov: Turn off camera power during S0ix ...................................................................... Patch Set 10: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/72089 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie2b300783adfc1cab30bc897d086a3674436724a Gerrit-Change-Number: 72089 Gerrit-PatchSet: 10 Gerrit-Owner: Frank Chu <frank_chu(a)pegatron.corp-partner.google.com> Gerrit-Reviewer: Frank Chu <frank_chu(a)pegatron.corp-partner.google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-CC: Ken Lu <ken_lu(a)pegatron.corp-partner.google.com> Gerrit-CC: Kyle Lin <kylelinck(a)google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Frank Chu <frank_chu(a)pegatron.corp-partner.google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Comment-Date: Thu, 02 Feb 2023 08:59:01 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: security/tpm/tss/tcg-2.0: Add `tlcl_read_public()`
by Yu-Ping Wu (Code Review) 02 Feb '23

02 Feb '23

Attention is currently required from: Andrey Pronin, Christian Walter, Yi Chou. Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71885 ) Change subject: security/tpm/tss/tcg-2.0: Add `tlcl_read_public()` ...................................................................... Patch Set 2: (2 comments) File src/security/tpm/tss/tcg-2.0/tss.c: https://review.coreboot.org/c/coreboot/+/71885/comment/d1b45bb0_f67a4313 PS2, Line 504: /* Unknown handle, returned if the key doesn't exist. */ Is this comment for which switch case? File src/security/tpm/tss/tcg-2.0/tss_marshaling.c: https://review.coreboot.org/c/coreboot/+/71885/comment/1a5ca069_577993ef PS2, Line 550: "%s:%d - " : "size mismatch: expected %d, remaining %zd\n", Can fit in one line. -- To view, visit https://review.coreboot.org/c/coreboot/+/71885 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I79455b3ee73c265a9e4bf3d8b9c6562490efbf1c Gerrit-Change-Number: 71885 Gerrit-PatchSet: 2 Gerrit-Owner: Yi Chou <yich(a)google.com> Gerrit-Reviewer: Andrey Pronin <apronin(a)google.com> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Andrey Pronin <apronin(a)google.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Yi Chou <yich(a)google.com> Gerrit-Comment-Date: Thu, 02 Feb 2023 08:56:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[L] Change in coreboot[master]: soc/intel/xeon_sp: add ebg (Emmitsburg PCH) directory
by Shuming Chu (Shuming) (Code Review) 02 Feb '23

02 Feb '23

Attention is currently required from: Subrata Banik, Simon Chou, TimLiu-SMCI, Jonathan Zhang, Johnny Lin, Paul Menzel, David Hendricks, Christian Walter, Angel Pons, Jian-Ming Wang, Arthur Heymans, Elyes Haouas. Shuming Chu (Shuming) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71945 ) Change subject: soc/intel/xeon_sp: add ebg (Emmitsburg PCH) directory ...................................................................... Patch Set 11: (4 comments) File src/soc/intel/xeon_sp/ebg/include/soc/gpio_soc_defs.h: https://review.coreboot.org/c/coreboot/+/71945/comment/5e3bbfdd_ffed6f19 PS8, Line 88: #define SPI0_IO_2 45 : #define SPI0_IO_3 46 : #define SPI0_MOSI_IO_0 47 : #define SPI0_MOSI_IO_1 48 : #define SPI0_TPM_CSB 49 : #define SPI0_FLASH_0_CSB 50 : #define SPI0_FLASH_2_CSB 51 : #define SPI0_CLK 52 > Tim, could you check this? These fields are not defined in EDS, but I can find them while using Cscript. I remove these fields but keep the order here. Also add comment here to explain the reason why the order is kept. https://review.coreboot.org/c/coreboot/+/71945/comment/c6e7f993_0d6ef270 PS8, Line 187: #define GPP_E20 132 : #define GPP_E21 133 : #define GPP_E22 134 : #define GPP_E23 135 > Tim, could you check this? These fields are not defined in EDS but can be found while using Cscript. I keep them here to make the order correct. These fields are also mentioned in EDS 13.9.1. Is it necessary to remove them? https://review.coreboot.org/c/coreboot/+/71945/comment/8a2b3d26_5488aa27 PS8, Line 192: GPP_E23 > GPP_E19 Although GPP_E23 is not defined in EDS but it does exist, should we change this to GPP_E19? File src/soc/intel/xeon_sp/ebg/include/soc/gpio_soc_defs.h: https://review.coreboot.org/c/coreboot/+/71945/comment/61319960_d5aa37f9 PS6, Line 374: #define GPIO_DRIVER_IRQ_ROUTE_MASK 8 : #define GPIO_DRIVER_IRQ_ROUTE_IRQ14 0 : #define GPIO_DRIVER_IRQ_ROUTE_IRQ15 8 > Tim, could you check this? I removed these definitions. -- To view, visit https://review.coreboot.org/c/coreboot/+/71945 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I393c1df75a344519fca7d680116f41f5f8bd9e87 Gerrit-Change-Number: 71945 Gerrit-PatchSet: 11 Gerrit-Owner: Simon Chou <simonchou(a)supermicro.com.tw> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Jian-Ming Wang <jianmingW(a)supermicro.com> Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: TimLiu-SMCI Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Shuming Chu (Shuming) <s1218944(a)gmail.com> Gerrit-CC: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Simon Chou <simonchou(a)supermicro.com.tw> Gerrit-Attention: TimLiu-SMCI Gerrit-Attention: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Jian-Ming Wang <jianmingW(a)supermicro.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Comment-Date: Thu, 02 Feb 2023 08:51:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Jonathan Zhang <jonzhang(a)fb.com> Comment-In-Reply-To: David Hendricks <david.hendricks(a)gmail.com> Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: soc/intel/xeon_sp: add Kconfig file for SPR-SP
by Simon Chou (Code Review) 02 Feb '23

02 Feb '23

Attention is currently required from: Arthur Heymans, TimLiu-SMCI, Jonathan Zhang, Johnny Lin, Christian Walter, Angel Pons, Jian-Ming Wang, Srinidhi N Kaushik, Tim Chu. Simon Chou has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/72439 ) Change subject: soc/intel/xeon_sp: add Kconfig file for SPR-SP ...................................................................... Patch Set 7: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/72439 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I14cf115b02d8edff9b48e744b798a3b1ba18b8bf Gerrit-Change-Number: 72439 Gerrit-PatchSet: 7 Gerrit-Owner: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur.heymans(a)9elements.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Jian-Ming Wang <jianmingW(a)supermicro.com> Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Simon Chou <simonchou(a)supermicro.com.tw> Gerrit-Reviewer: Srinidhi N Kaushik <srinidhi.n.kaushik(a)intel.com> Gerrit-Reviewer: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Reviewer: TimLiu-SMCI Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Attention: Arthur Heymans <arthur.heymans(a)9elements.com> Gerrit-Attention: TimLiu-SMCI Gerrit-Attention: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Jian-Ming Wang <jianmingW(a)supermicro.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Srinidhi N Kaushik <srinidhi.n.kaushik(a)intel.com> Gerrit-Attention: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Comment-Date: Thu, 02 Feb 2023 08:49:01 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: soc/amd: Create AMD common reset code
by Elyes Haouas (Code Review) 02 Feb '23

02 Feb '23

Attention is currently required from: Jason Glenesk, Raul Rangel, Martin L Roth, Matt DeVillier, Fred Reitberger, Felix Held. Elyes Haouas has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/72658 ) Change subject: soc/amd: Create AMD common reset code ...................................................................... Patch Set 1: (1 comment) File src/soc/amd/common/block/include/amdblocks/reset.h: https://review.coreboot.org/c/coreboot/+/72658/comment/ee81f144_07886318 PS1, Line 10: #include <soc/southbridge.h> : : : void do_warm_reset(void); maybe just one empty line? -- To view, visit https://review.coreboot.org/c/coreboot/+/72658 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib6459e7ab82aacbe57b4c2fc5bbb3759dc5266f7 Gerrit-Change-Number: 72658 Gerrit-PatchSet: 1 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Thu, 02 Feb 2023 08:32:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[L] Change in coreboot[master]: soc/intel/xeon_sp: add ebg (Emmitsburg PCH) directory
by Shuming Chu (Shuming) (Code Review) 02 Feb '23

02 Feb '23

Attention is currently required from: Subrata Banik, TimLiu-SMCI, Jonathan Zhang, Johnny Lin, Paul Menzel, David Hendricks, Christian Walter, Angel Pons, Jian-Ming Wang, Arthur Heymans, Elyes Haouas. Shuming Chu (Shuming) has uploaded a new patch set (#11) to the change originally created by Simon Chou. ( https://review.coreboot.org/c/coreboot/+/71945 ) Change subject: soc/intel/xeon_sp: add ebg (Emmitsburg PCH) directory ...................................................................... soc/intel/xeon_sp: add ebg (Emmitsburg PCH) directory EBG (Emmitsburg) PCH is used in Intel SPR-SP chipset. These changes are in accordance with the documentation: * Intel(R) Emmitsburg Platform Controller Hub External Design Specification. Document Number: 606161 * Emmitsburg PCH BIOS Specification. Document Number: 631063. Signed-off-by: Jonathan Zhang <jonzhang(a)meta.com> Signed-off-by: Tim Chu <Tim.Chu(a)quantatw.com> Change-Id: I393c1df75a344519fca7d680116f41f5f8bd9e87 --- A src/soc/intel/xeon_sp/ebg/Makefile.inc A src/soc/intel/xeon_sp/ebg/include/soc/gpio_soc_defs.h A src/soc/intel/xeon_sp/ebg/include/soc/pcr_ids.h A src/soc/intel/xeon_sp/ebg/include/soc/pmc.h A src/soc/intel/xeon_sp/ebg/include/soc/soc_pch.h A src/soc/intel/xeon_sp/ebg/lockdown.c A src/soc/intel/xeon_sp/ebg/soc_gpio.c A src/soc/intel/xeon_sp/ebg/soc_pch.c A src/soc/intel/xeon_sp/ebg/soc_pmutil.c 9 files changed, 868 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/45/71945/11 -- To view, visit https://review.coreboot.org/c/coreboot/+/71945 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I393c1df75a344519fca7d680116f41f5f8bd9e87 Gerrit-Change-Number: 71945 Gerrit-PatchSet: 11 Gerrit-Owner: Simon Chou <simonchou(a)supermicro.com.tw> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Jian-Ming Wang <jianmingW(a)supermicro.com> Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: TimLiu-SMCI Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Shuming Chu (Shuming) <s1218944(a)gmail.com> Gerrit-CC: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: TimLiu-SMCI Gerrit-Attention: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Jian-Ming Wang <jianmingW(a)supermicro.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: src/sbom/Makefile.inc: Fix variable expansion
by Elyes Haouas (Code Review) 02 Feb '23

02 Feb '23

Attention is currently required from: Maximilian Brune. Elyes Haouas has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/72660 ) Change subject: src/sbom/Makefile.inc: Fix variable expansion ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > would you please rebase on https://review.coreboot. […] Please rebase on #70251. "SBOM" patches still creating a "go" directory into home directory (/home/current_user/go). -- To view, visit https://review.coreboot.org/c/coreboot/+/72660 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I884469a388fd48be89d74ccda686dd8f299d63eb Gerrit-Change-Number: 72660 Gerrit-PatchSet: 1 Gerrit-Owner: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Comment-Date: Thu, 02 Feb 2023 08:10:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit February 2023