Attention is currently required from: Simon Chou, Jonathan Zhang, Ryback Hung, David Hendricks, Angel Pons, Tim Chu.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71953 )
Change subject: soc/intel/common/block/fast_spi: Add SPI BIOS decode lock
......................................................................
Patch Set 6:
(1 comment)
File src/soc/intel/common/block/include/intelblocks/fast_spi.h:
https://review.coreboot.org/c/coreboot/+/71953/comment/9e3738c4_958080c0
PS6, Line 107: * Set FAST_SPIBAR BIOS Decode Lock bit.
Please remove the dot/period at the end.
--
To view, visit https://review.coreboot.org/c/coreboot/+/71953
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3366817b42a5878f16575698ebc546fa7852e285
Gerrit-Change-Number: 71953
Gerrit-PatchSet: 6
Gerrit-Owner: Simon Chou <simonchou(a)supermicro.com.tw>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com>
Gerrit-Reviewer: Jian-Ming Wang <jianmingW(a)supermicro.com>
Gerrit-Reviewer: Jonathan Zhang <jonzhang(a)fb.com>
Gerrit-Reviewer: Ryback Hung <ryback.hung(a)quantatw.com>
Gerrit-Reviewer: Shuming Chu (Shuming) <s1218944(a)gmail.com>
Gerrit-Reviewer: Tim Chu <Tim.Chu(a)quantatw.com>
Gerrit-Reviewer: TimLiu-SMCI
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Simon Chou <simonchou(a)supermicro.com.tw>
Gerrit-Attention: Jonathan Zhang <jonzhang(a)fb.com>
Gerrit-Attention: Ryback Hung <ryback.hung(a)quantatw.com>
Gerrit-Attention: David Hendricks <david.hendricks(a)gmail.com>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: Tim Chu <Tim.Chu(a)quantatw.com>
Gerrit-Comment-Date: Thu, 02 Feb 2023 06:46:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Simon Chou, Jonathan Zhang, Ryback Hung, David Hendricks, Angel Pons, Tim Chu.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71953 )
Change subject: soc/intel/common/block/fast_spi: Add SPI BIOS decode lock
......................................................................
Patch Set 6:
(1 comment)
File src/soc/intel/common/block/fast_spi/fast_spi.c:
https://review.coreboot.org/c/coreboot/+/71953/comment/87996fc5_86106718
PS6, Line 467: pci_write_config32(dev, SPI_BIOS_DECODE_EN, bde);
Can you use `pci_or_config32()`?
--
To view, visit https://review.coreboot.org/c/coreboot/+/71953
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3366817b42a5878f16575698ebc546fa7852e285
Gerrit-Change-Number: 71953
Gerrit-PatchSet: 6
Gerrit-Owner: Simon Chou <simonchou(a)supermicro.com.tw>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com>
Gerrit-Reviewer: Jian-Ming Wang <jianmingW(a)supermicro.com>
Gerrit-Reviewer: Jonathan Zhang <jonzhang(a)fb.com>
Gerrit-Reviewer: Ryback Hung <ryback.hung(a)quantatw.com>
Gerrit-Reviewer: Shuming Chu (Shuming) <s1218944(a)gmail.com>
Gerrit-Reviewer: Tim Chu <Tim.Chu(a)quantatw.com>
Gerrit-Reviewer: TimLiu-SMCI
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Simon Chou <simonchou(a)supermicro.com.tw>
Gerrit-Attention: Jonathan Zhang <jonzhang(a)fb.com>
Gerrit-Attention: Ryback Hung <ryback.hung(a)quantatw.com>
Gerrit-Attention: David Hendricks <david.hendricks(a)gmail.com>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: Tim Chu <Tim.Chu(a)quantatw.com>
Gerrit-Comment-Date: Thu, 02 Feb 2023 06:45:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Simon Chou, Jonathan Zhang, Ryback Hung, Angel Pons, Tim Chu.
David Hendricks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71953 )
Change subject: soc/intel/common/block/fast_spi: Add SPI BIOS decode lock
......................................................................
Patch Set 6: Code-Review+1
(1 comment)
Patchset:
PS6:
Patch looks good, I'm just waiting until Jenkins has successfully run with this rebased on top of master.
--
To view, visit https://review.coreboot.org/c/coreboot/+/71953
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3366817b42a5878f16575698ebc546fa7852e285
Gerrit-Change-Number: 71953
Gerrit-PatchSet: 6
Gerrit-Owner: Simon Chou <simonchou(a)supermicro.com.tw>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com>
Gerrit-Reviewer: Jian-Ming Wang <jianmingW(a)supermicro.com>
Gerrit-Reviewer: Jonathan Zhang <jonzhang(a)fb.com>
Gerrit-Reviewer: Ryback Hung <ryback.hung(a)quantatw.com>
Gerrit-Reviewer: Shuming Chu (Shuming) <s1218944(a)gmail.com>
Gerrit-Reviewer: Tim Chu <Tim.Chu(a)quantatw.com>
Gerrit-Reviewer: TimLiu-SMCI
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Simon Chou <simonchou(a)supermicro.com.tw>
Gerrit-Attention: Jonathan Zhang <jonzhang(a)fb.com>
Gerrit-Attention: Ryback Hung <ryback.hung(a)quantatw.com>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: Tim Chu <Tim.Chu(a)quantatw.com>
Gerrit-Comment-Date: Thu, 02 Feb 2023 06:36:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Jian-Ming Wang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71950 )
Change subject: drivers/intel/fsp2_0: Add saving MRC data after FSP-S option
......................................................................
Patch Set 9: Code-Review+1
(1 comment)
File src/drivers/intel/fsp2_0/save_mrc_data.c:
https://review.coreboot.org/c/coreboot/+/71950/comment/aba36a8f_8eb58cdd
PS9, Line 46: if !CONFIG(SAVE_MRC_AFTER_FSPS)
: BOOT_STATE_INIT_ENTRY(BS_PRE_DEVICE, BS_ON_ENTRY, save_mrc_data, NULL);
: #elif CONFIG(SAVE_MRC_AFTER_FSPS)
: BOOT_STATE_INIT_ENTRY(BS_DEV_INIT_CHIPS, BS_ON_EXIT, save_mrc_data, NULL);
: #endif
> I didn't write the original patch, but I agree that the form you suggest is slightly better so I wen […]
I think the judgement is depending on whether the original idea is to use this definition to tell compiler to include the code into binary. From performance and code size perspective the original one possibly is (slightly?) better. From readability and static/dynamic code analysis perspective, the suggestion from Elyes is better. I think the change might be safe if it passed compiling stage.
--
To view, visit https://review.coreboot.org/c/coreboot/+/71950
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3bab0c5004e717e842b484c89187e8c0b9c2b3eb
Gerrit-Change-Number: 71950
Gerrit-PatchSet: 9
Gerrit-Owner: Simon Chou <simonchou(a)supermicro.com.tw>
Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com>
Gerrit-Reviewer: Daocheng Bu <daocheng.bu(a)intel.com>
Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com>
Gerrit-Reviewer: Jian-Ming Wang <jianmingW(a)supermicro.com>
Gerrit-Reviewer: Jonathan Zhang <jonzhang(a)fb.com>
Gerrit-Reviewer: Ray Han Lim Ng <ray.han.lim.ng(a)intel.com>
Gerrit-Reviewer: Reka Norman <rekanorman(a)chromium.org>
Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com>
Gerrit-Reviewer: TimLiu-SMCI
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-CC: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-CC: Johnny Lin <Johnny_Lin(a)wiwynn.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Comment-Date: Thu, 02 Feb 2023 06:33:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: David Hendricks <david.hendricks(a)gmail.com>
Comment-In-Reply-To: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-MessageType: comment
Attention is currently required from: Tarun Tuli, Jérémy Compostella, Kapil Porwal.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/72715 )
Change subject: [EXPERIMENTAL] soc/intel/meteorlake: Test early sign-of-life
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
We shall first enable libgfxinit instead GFX PEIM as first phase before enabling early SOL. This is my priority for MTL.
--
To view, visit https://review.coreboot.org/c/coreboot/+/72715
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic4c37077b3b3032c861f96231435fcebc7ef36ff
Gerrit-Change-Number: 72715
Gerrit-PatchSet: 1
Gerrit-Owner: Jérémy Compostella <jeremy.compostella(a)intel.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com>
Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com>
Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Comment-Date: Thu, 02 Feb 2023 05:46:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment